[PATCH 2/5] e1000e: Fix wrong comment related to link detection

Reading e1000e_check_for_copper_link() shows that get_link_status is set to false after link has been detected. Therefore, it stays TRUE until then. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt") Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/defines.h | 1 + drivers/net/ethernet/intel/e1000e/netdev.c | 33 +++-- 2 files changed, 27 insertions(+), 7 deletions(-) diff -

[PATCH 3/5] e1000e: Fix return value test

All the helpers return -E1000_ERR_PHY. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 58a87134d2e5

Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

On 2018/01/29 09:22, Alexander Duyck wrote: [...] > > > Consequently, we must clear OTHER manually from ICR, otherwise the > > interrupt is immediately re-raised after exiting the handler. > > > > These observations are the same whether the interrupt is triggered via a > > write to ICS or in hardw

[PATCH net-queue 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

ce mode". Link: https://www.spinics.net/lists/netdev/msg480675.html Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/e

[PATCH net-queue 3/3] e1000e: Avoid missed interrupts following ICR read.

, therefore we no longer need to clear bits explicitly. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/defines.h | 21 - drivers/net/ethernet/intel/e1000e/netdev.c | 11 --- 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/net

[PATCH net-queue 2/3] e1000e: Fix queue interrupt re-raising in Other interrupt.

the queue interrupts in case the txq or rxq bits were set in ICR and the Other interrupt handler read and cleared ICR before the queue interrupt was raised. Fixes: 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/in

Re: [PATCH net-queue 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

tead of manually clearing OTHER via a write to icr as in v1, in v2 we make sure that INT_ASSERTED is always set via bits for all events related to the Other interrupt in IMS. Benjamin Poirier (3): Partial revert "e1000e: Avoid receiver overrun interrupt bursts" e1000e: Fix queue inte

[RFC PATCH] e1000e: Fix link check race condition.

ter having checked the link. It seems this problem has been present since the introduction of e1000e. Link: https://lkml.org/lkml/2018/1/29/338 Reported-by: Alexander Duyck Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 41 - dr

[PATCH net-queue] e1000e: Fix check_for_link return value with autoneg off.

1000e: Separate signaling for link check/link up") Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 +- drivers/net/ethernet/intel/e1000e/mac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ich8

[PATCH] packet: Don't write vnet header beyond end of buffer

... which may happen with certain values of tp_reserve and maclen. Fixes: 58d19b19cd99 ("packet: vnet_hdr support for tpacket_rcv") Signed-off-by: Benjamin Poirier Cc: Willem de Bruijn --- net/packet/af_packet.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) di

Re: [5/5] e1000e: Avoid receiver overrun interrupt bursts

On 2017/09/19 12:38, Philip Prindeville wrote: > Hi. > > We’ve been running this patchset (all 5) for about as long as they’ve been > under review… about 2 months. And in a burn-in lab with heavy traffic. > > We’ve not seen a single link-flap in hundreds of ours of saturated traffic. > > Would

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

On 2017/07/21 11:36, Benjamin Poirier wrote: > When e1000e_poll() is not fast enough to keep up with incoming traffic, the > adapter (when operating in msix mode) raises the Other interrupt to signal > Receiver Overrun. > > This is a double problem because 1) at the moment e

Re: [Intel-wired-lan] [PATCH 4/5] e1000e: Separate signaling for link check/link up

On 2017/08/02 10:34, Lennart Sorensen wrote: > On Wed, Aug 02, 2017 at 02:28:07PM +0300, Neftin, Sasha wrote: > > On 7/21/2017 21:36, Benjamin Poirier wrote: > > > Lennart reported the following race condition: > > > > > > \ e1000_watchdog_task > > &g

Re: [PATCH 4.4 71/96] e1000e: Separate signaling for link check/link up

On 2017/12/07 20:02, Ben Hutchings wrote: > On Tue, 2017-11-28 at 11:23 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > -- > > > > From:

[PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value.

naling for link check/link up") Tested-by: Christian Hesse Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1

<    1   2   3