Re: [PATCH] vfio powerpc: enabled and supported on powernv platform

2012-11-26 Thread Benjamin Herrenschmidt
On Mon, 2012-11-26 at 11:04 -0700, Alex Williamson wrote: > Ok, I see tces are put on shutdown via tce_iommu_detach_group, so you're > more concerned about the guest simply mapping over top of it's own > mappings. Is that common? Is it common enough for every multi-page > mapping to assume it wil

Re: linux-next: build failure after merge of the powerpc tree

2012-11-27 Thread Benjamin Herrenschmidt
On Wed, 2012-11-28 at 14:03 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the powerpc tree, next-20121115's build (powerpc > allmodconfig) failed like this: > > ERROR: ".of_reconfig_notifier_register" [drivers/crypto/nx/nx-compress.ko] > undefined! > ERROR: ".of_reconfig_notifier_un

Re: [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule

2012-11-28 Thread Benjamin Herrenschmidt
On Wed, 2012-11-28 at 11:33 -0700, Stephen Warren wrote: > Following this patch (http://lkml.org/lkml/2012/11/27/555), I posted a > series of patches to convert almost all architectures to using the > centralized rule. The one architecture I didn't convert was PowerPC. > > I didn't convert it bec

Re: [PATCH] export of_reconfig_notifier_[register,unregister]

2012-11-28 Thread Benjamin Herrenschmidt
On Wed, 2012-11-28 at 13:42 -0600, Nathan Fontenot wrote: > The of reconfiguration notification chains should be exported for use > by modules. > > Signed-off-by:Nathan Fontenot Grant, I'm applying that into the powerpc tree (with a slightly modified subject line). You don't need to add it to yo

[git pull] Please pull powerpc.git merge branch

2013-03-17 Thread Benjamin Herrenschmidt
powerpc: Make VSID_BITS* dependency explicit powerpc: Update kernel VSID range powerpc: Rename USER_ESID_BITS* to ESID_BITS* Anton Blanchard (1): powerpc: Fix -mcmodel=medium breakage in prom_init.c Benjamin Herrenschmidt (2): powerpc: Fix STAB initialization powerp

Re: [PATCH 1/2] of: Make device nodes kobjects so they show up in sysfs

2013-03-20 Thread Benjamin Herrenschmidt
additional overhead, but at the cost of > more complexity in the sysfs support code. However, I'm hopeful that > these problems are just imaginary and we can stick with normal sysfs > attributes. Disagreed. It would break stuff, especially the incorrect file size. Cheers, Ben

Re: [PATCH 2/2] of: remove /proc/device-tree

2013-03-20 Thread Benjamin Herrenschmidt
ting > would be appreciated. NAK. It should at the very least be a CONFIG option for a while before completely switching over. Cheers, Ben. > Signed-off-by: Grant Likely > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Benjamin Herrenschmidt > Cc: David S. Miller > --- > drive

Re: [PATCH 1/2] of: Make device nodes kobjects so they show up in sysfs

2013-03-20 Thread Benjamin Herrenschmidt
On Wed, 2013-03-20 at 09:56 -0700, Greg Kroah-Hartman wrote: > > Unfortunately they occasionally are... VPDs can be pretty big for > > example. > > If the attributes are binary blobs, use the binary file capability of > sysfs to properly handle them. Except that we don't know that ... we have pro

Re: [PATCH 2/2] of: remove /proc/device-tree

2013-03-20 Thread Benjamin Herrenschmidt
On Wed, 2013-03-20 at 21:38 +, Grant Likely wrote: > > NAK. It should at the very least be a CONFIG option for a while > before > > completely switching over. > > I'll modify patch 1 to create the symlink if CONFIG_PROC_DEVICETREE is > not set. After the first patch can be applied we can leave

Re: [PATCH 2/2] of: remove /proc/device-tree

2013-03-21 Thread Benjamin Herrenschmidt
On Thu, 2013-03-21 at 07:35 +, Grant Likely wrote: > > Shouldn't we have the symlink just be a config option itself ? > > Eventually distros might want get rid of it completely .. > > Why? It is the cheapest thing in the world and it means the ABI > doesn't change at all. It's also gross and

Re: [PATCH 2/2] of: remove /proc/device-tree

2013-03-21 Thread Benjamin Herrenschmidt
On Thu, 2013-03-21 at 08:16 +, Grant Likely wrote: > On Thu, Mar 21, 2013 at 7:43 AM, Benjamin Herrenschmidt > wrote: > > On Thu, 2013-03-21 at 07:35 +, Grant Likely wrote: > >> > Shouldn't we have the symlink just be a config option itself ? > >> &

Re: [Suggestion] PowerPC: kernel: cross compiling issue with allmodconfig

2013-03-21 Thread Benjamin Herrenschmidt
m in exception vector area" can make room > > larger. > > it can let "some additional config" ok. > > but for allmodconfig, it is still not enough. > > > > > > details > > reason: > > it is caused by: > >

Re: Kobjectify device tree structures

2013-03-21 Thread Benjamin Herrenschmidt
On Thu, 2013-03-21 at 11:24 +, Grant Likely wrote: > 11 files changed, 147 insertions(+), 342 deletions(-) Nice :-) Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [PATCH V2 1/2] of: Make device nodes kobjects so they show up in sysfs

2013-03-21 Thread Benjamin Herrenschmidt
On Thu, 2013-03-21 at 11:24 +, Grant Likely wrote: > Device tree nodes are already treated as objects, and we already want to > expose them to userspace which is done using the /proc filesystem today. > Right now the kernel has to do a lot of work to keep the /proc view in > sync with the in-ke

Re: [PATCH V2 2/2] of: remove /proc/device-tree

2013-03-21 Thread Benjamin Herrenschmidt
etc...), and more. We also need to test the new code with hotplug, I'll see if I can get somebody at IBM to give it a spin. Cheers, Ben. > Signed-off-by: Grant Likely > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Benjamin Herrenschmidt > Cc: David S. Miller &

[git pull] Please pull powerpc.git merge branch

2013-02-03 Thread Benjamin Herrenschmidt
Hi Linus ! Just so that you don't get too bored on your Island here's a patch for 3.8 fixing a nasty bug that affects the new 64T support that was merged in 3.7. Please apply whenever you have a chance (and an internet connection !) Cheers, Ben. The following changes since commit 689dfa894c57842

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-04 Thread Benjamin Herrenschmidt
On Mon, 2013-02-04 at 17:24 +, Arnd Bergmann wrote: > On Monday 04 February 2013, Michal Simek wrote: > > > > > > and select the CONFIG_FOO_BIG_ENDIAN and CONFIG_FOO_LITTLE_ENDIAN > > > symbols in Kconfig based on the system you are building for. > > > > Using CONFIG_FOO_BIG/LITTLE is not good

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Benjamin Herrenschmidt
On Tue, 2013-02-05 at 11:54 +0100, Michal Simek wrote: > > xilinx ppc is big endian > xilinx arm is little endian > xilinx microblaze is little endian and big endian You are talking about the core, why should the xsysace block driver be synthesized with the same endianness as the core ? That's no

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Benjamin Herrenschmidt
On Tue, 2013-02-05 at 17:39 +0530, Vineet Gupta wrote: > Am I correct in understanding that "be" suffix here reflects the byte > ordering of > the device and not the CPU. So for a BE device, driver using ioread32be on LE > processor will get MSB first data - and accessor will swap the bytes to mak

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Benjamin Herrenschmidt
On Tue, 2013-02-05 at 18:03 +0400, Alexey Brodkin wrote: > = > > and its endianess is fixed which is stated in this document > (http://www.xilinx.com/support/documentation/ip_documentation/xps_sysace.pdf). > = > The Xilinx System ACE Compact Flash chip is a true little-endian device > ===

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Benjamin Herrenschmidt
On Tue, 2013-02-05 at 16:12 +0100, Arnd Bergmann wrote: > Ok. In this case, I would recommend making the default for this driver > little-endian, and adding a quirk for broken hardware bridges like the > one you cited to have a mixed-endian mode if configured so at compile > time. > > It seems tha

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-05 Thread Benjamin Herrenschmidt
On Wed, 2013-02-06 at 01:25 +0400, Alexey Brodkin wrote: > Sounds good but how should one tell which approach is correct? For > example here - is the one implemented by Xilinx is golden reference or > not? So I'm reading that PDF you pointed to. So far what I can see is: - In 8-bit mode you onl

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-06 Thread Benjamin Herrenschmidt
On Wed, 2013-02-06 at 10:14 +, Grant Likely wrote: > > Huh? That makes no sense. This device out in the wild with both big > and little endian bus attachments. You can argue all day that one of > them is wrong, but it doesn't matter. It exists, is used, and must be > supported. No. That's whe

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-02-07 at 16:09 +0400, Alexey Brodkin wrote: > > BTW I've just realized that in case if there's no bridge between CPU and > CF-controller or if this bridge is "transparent" (does no swapping > neither bytes nor bits) our data accessors here should be changed. > > Isn't it strange in

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-02-07 at 23:20 +1100, Benjamin Herrenschmidt wrote: > For the "swapped" case, I would suggest using ioread16be for the registers > for the data port, use ioread16_rep followed by a pass of byteswap. I assume > that this incorrect wiring case only happens on BE pl

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-02-07 at 19:12 +0400, Alexey Brodkin wrote: > not sure about items for "ace_datain/out_be16" - what about _rep > options here? Well, you have a backward wiring of an LE device so you can't use the _rep variants, unless you ping pong, so you either use a loop of ioread/write16 (le) and

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-02-07 at 15:23 +, Grant Likely wrote: > > Maybe. In a separate patch. Hmmm... I guess there isn't an > ioread16be_rep variant. Because it would not make sense. The ioread16_rep isn't "LE" ... it should be usable for any kind if data port since such a fifo should never require by

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-02-07 at 16:44 +, Grant Likely wrote: > > I've just spent some quality time with a piece of paper, and I think > I've figured it out... http://linuxplumbers.ubicast.tv/videos/big-and-little-endian-inside-out/ Watch the last part on IO busses This all has to do which which b

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-02-07 at 20:56 +0400, Alexey Brodkin wrote: > > So, if I'm correct that means that for the data port (specifically > > copying between RAM and the data port) using ioread16/iowrite16 on the > > data port results in the correct behaviour. It also means that LE > > support in the current

Re: kernel BUG at arch/powerpc/mm/hash_utils_64.c:1223!

2013-02-07 Thread Benjamin Herrenschmidt
On Fri, 2013-02-08 at 01:09 +0200, Aaro Koskinen wrote: > > I get this BUG when enabling DEBUG_PAGEALLOC with 3.8-rc6+ > (6bacaa9ddacb71c691d32c678d37bc59ffc71fac) on G5 PPC. > > It seems to be fairly reproducible - I saw it 3 times, soon after > booting > while running a compilation job on ext3

Re: [PATCH] powerpc: kernel/kgdb.c: fix memory leakage

2013-02-07 Thread Benjamin Herrenschmidt
On Thu, 2013-01-31 at 20:04 -0600, Jason Wessel wrote: > > diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c > > index 8747447..5ca82cd 100644 > > --- a/arch/powerpc/kernel/kgdb.c > > +++ b/arch/powerpc/kernel/kgdb.c > > @@ -154,12 +154,12 @@ static int kgdb_handle_breakpoint(st

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-11 Thread Benjamin Herrenschmidt
On Mon, 2013-02-11 at 16:57 +0100, Michal Simek wrote: > But it reminds me that maybe the easiest solution is not to use endian > accessors just use two simple macros which should work on all systems. > > #define _readreg(offset) ({__raw_readl(offset); rmb(); }) > #define _writereg(offset

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-11 Thread Benjamin Herrenschmidt
On Mon, 2013-02-11 at 16:08 +, Arnd Bergmann wrote: > I tend to disagree. You should never assume that a device is the same > endianess as the the CPU, and you should try not to use the __raw_* > accessors in device drivers either. > > In particular, ARM can run both big- and little-endian eve

Re: [BUG] irq_dispose_mapping after irq request failure

2013-02-11 Thread Benjamin Herrenschmidt
On Mon, 2013-02-11 at 20:52 +, Grant Likely wrote: > Really the irq mappings should be using reference counting. The existing > code is naive on this count and just releases the irq on the first call > to irq_dispose_mapping(). I've not gotten around to fixing that. Anyone > want to take that

Re: [BUG] irq_dispose_mapping after irq request failure

2013-02-12 Thread Benjamin Herrenschmidt
On Tue, 2013-02-12 at 17:18 +1100, Michael Ellerman wrote: > > I don't think you can, "active" is not well defined. Other code may have > done nothing other than create the mapping and remembered the virq, > which will break if you destroy the mapping. Or? Active as in "requested". Yes there's a

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Benjamin Herrenschmidt
On Tue, 2013-02-12 at 11:11 +0100, Michal Simek wrote: > For high performance IPs using accessors functions is still > problematic > because there will be performance regression it means that > from my point of view there still should be any option to "setup" > proper endians for the driver and it

[git pull] Please pull powerpc.git merge branch

2013-01-28 Thread Benjamin Herrenschmidt
Hi Linus ! Whenever you have a chance between two dives, you might want to consider pulling my merge branch to pickup a few fixes for 3.8 that have been accumulating for the last couple of weeks (I was myself travelling then on vacation). Nothing major, just a handful of powerpc bug fixes that I c

Re: [git pull] Please pull powerpc.git merge branch

2013-01-28 Thread Benjamin Herrenschmidt
On Mon, 2013-01-28 at 16:03 -0800, Linus Torvalds wrote: > I'll have you know that I haven't quite even left for Au yet, and I > have LCA before diving. So no snarky "in between dives" comments, > please. It wasn't meant to be "snarky", sorry about that... > At least not for a few days. > > >

[git pull] Please pull powerpc.git next branch

2013-02-23 Thread Benjamin Herrenschmidt
dd support for CTS-1000 GPIO controlled system poweroff Benjamin Herrenschmidt (4): powerpc: Make room in exception vector area Merge branch 'merge' into next Merge remote-tracking branch 'kumar/next' into next Merge remote-tracking branch &#x

Re: [git pull] signal.git

2013-02-24 Thread Benjamin Herrenschmidt
On Sat, 2013-02-23 at 18:56 -0800, Linus Torvalds wrote: > On Wed, Feb 20, 2013 at 2:52 PM, Al Viro wrote: > > * a bunch of signal-related syscalls (both native and compat) unified. > > Ok, in the meantime I had merged the parisc and powerpc trees, which > had their own fixes in this area: powerp

Re: linux-next: manual merge of the signal tree with the powerpc tree

2013-02-20 Thread Benjamin Herrenschmidt
On Thu, 2013-02-21 at 15:52 +1100, Stephen Rothwell wrote: > Hi Al, > > Today's linux-next merge of the signal tree got conflicts in > arch/powerpc/kernel/signal_32.c and arch/powerpc/kernel/signal_64.c > between commit 2b0a576d15e0 ("powerpc: Add new transactional memory state > to the signal con

Re: Regression with orderly_poweroff()

2013-03-12 Thread Benjamin Herrenschmidt
On Tue, 2013-03-12 at 07:46 -0700, Linus Torvalds wrote: > > Hmm.. You should really have cc'd the people who acked it and were in > the sign-off chain too, because all those people are involved with the > patch as well. Ah oops, my bad, just used David's original CC list, too much stuff on my pl

Re: [PATCH] clk: Make the generic clock API available by default

2012-09-04 Thread Benjamin Herrenschmidt
for the clock API at platform level. > > Signed-off-by: Mark Brown > --- For powerpc: Acked-by: Benjamin Herrenschmidt Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v2] powerpc: fix personality handling in ppc64_personality()

2012-09-04 Thread Benjamin Herrenschmidt
On Thu, 2012-08-02 at 09:10 +0200, Jiri Kosina wrote: > Directly comparing current->personality against PER_LINUX32 doesn't work > in cases when any of the personality flags stored in the top three bytes > are used. > > Directly forcefully setting personality to PER_LINUX32 or PER_LINUX > discards

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-04 Thread Benjamin Herrenschmidt
On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: > On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: > > This patch adds a new device driver to support IBM virtual TPM > > (vTPM) for PPC64. IBM vTPM is supported through the adjunct > > partition with firmware release 740 or higher.

Re: [PATCH v5 3/3] powerpc: Uprobes port to powerpc

2012-09-04 Thread Benjamin Herrenschmidt
On Fri, 2012-08-24 at 13:01 +0530, Ananth N Mavinakayanahalli wrote: > From: Ananth N Mavinakayanahalli > > This is the port of uprobes to powerpc. Usage is similar to x86. Guys, can you do a minimum of build testing ? This one breaks due to uprobe_get_swbp_addr() being defined in both asm and

[git pull] Please pull powerpc.git merge branch

2012-09-04 Thread Benjamin Herrenschmidt
SCR on all CPUs when writing sysfs dscr_default powerpc: Keep thread.dscr and thread.dscr_inherit in sync powerpc: Fix DSCR inheritance in copy_thread() powerpc: Restore correct DSCR in context switch Benjamin Herrenschmidt (1): powerpc: Don't use __put_user() in patc

Re: [PATCH] powerpc/smp: Do not disable IPI interrupts during suspend

2012-09-13 Thread Benjamin Herrenschmidt
On Thu, 2012-09-13 at 13:16 -0500, Kumar Gala wrote: > >> Yes, we disabled all non-boot CPUs on suspend by calling > disable_nonboot_cpus(). > >> The disable_nonboot_cpus() needs IPIs to work. But prior to > >> calling disable_nonboot_cpus(), the IPIs are disabled in > dpm_suspend_noirq(). Sure, n

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Benjamin Herrenschmidt
> > Since Alan has commented on it: > > > > http://lkml.org/lkml/2007/12/17/422 > > > > "5520 in fact is always enabled as it is the host bridge. > > pci_enable_device_io will do just fine. The 5520 fun is if you disable it > > the system hangs." > > > > I moved on assuming that either submitte

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-02 Thread Benjamin Herrenschmidt
Why dropping add-mm-argument-to-pte-pmd-pud-pgd_free.patch though ? It's a sane patch and a helps going further, and a total pain to re-do later on. Besides, I may have some use for it on powerpc at some point too... Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH] Fix ext4 bitops

2008-02-02 Thread Benjamin Herrenschmidt
On Fri, 2008-02-01 at 21:02 +0100, Bastian Blank wrote: > Fix ext4 bitops. Please provide a better description, as it's not obvious at first sight. > Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> > > diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h > index 220d9a7..d0

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-04 Thread Benjamin Herrenschmidt
On Mon, 2008-02-04 at 18:12 +0300, Alexey Dobriyan wrote: > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka > "PCI: Fix bus resource assignment on 32 bits with 64b resources" > renders one tg3-equipped box networkless here. > > tg3.c:v3.87 (December 20, 2007) > tg3: (:02:05.0)

Re: Commit for mm/page_alloc.c breaks boot process on my machine

2008-02-04 Thread Benjamin Herrenschmidt
On Fri, 2008-02-01 at 21:05 +0100, Gerhard Pircher wrote: > Original-Nachricht > > Datum: Fri, 1 Feb 2008 19:11:19 + > > Von: Mel Gorman <[EMAIL PROTECTED]> > > An: Gerhard Pircher <[EMAIL PROTECTED]> > > CC: linux-kernel@vger.kernel.org > > Betreff: Re: Commit for mm/page_al

Re: Commit for mm/page_alloc.c breaks boot process on my machine

2008-02-04 Thread Benjamin Herrenschmidt
> > It's a virtual address so it depends on the value of CONFIG_KERNEL_START > as to whether this is a user program address or not. Shouldn't it be PAGE_OFFSET ? I mean, CONFIG_KERNEL_START should work on powerpc, but still... Ben. -- To unsubscribe from this list: send the line "unsubscribe

Re: Commit for mm/page_alloc.c breaks boot process on my machine

2008-02-04 Thread Benjamin Herrenschmidt
On Fri, 2008-02-01 at 22:06 +0100, Gerhard Pircher wrote: > > Could you try booting with 16MB less memory using mem=? > I started the kernel with 512MB RAM (mem=496) and 1.5GB (mem=1520). > The > kernel oopes in both cases with a "Unable to handle kernel paging > request > for data address 0xb

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-04 Thread Benjamin Herrenschmidt
And I could also use the lspci output without the patch. Thanks, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-04 Thread Benjamin Herrenschmidt
Oh and send me the output of /proc/iomem as well. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lk

Re: [REGRESSION] nfsd crashing with 3.6.0-rc7 on PowerPC

2012-10-01 Thread Benjamin Herrenschmidt
btained with a Chelsio T3 adapter on > two POWER7 boxes, running a 100 session TCP round robin test. > > Performance improved 69% with this patch applied. > > Signed-off-by: Anton Blanchard > Signed-off-by: Benjamin Herrenschmidt > > :04 04

Re: [REGRESSION] nfsd crashing with 3.6.0-rc7 on PowerPC

2012-10-02 Thread Benjamin Herrenschmidt
On Tue, 2012-10-02 at 14:43 -0700, Nishanth Aravamudan wrote: > > Started looking into this. If your suspicion were accurate, wouldn't > the > bisection have stopped at 0e4bc95d87394364f408627067238453830bdbf3 > ("powerpc/iommu: Reduce spinlock coverage in iommu_alloc and > iommu_free")? > > Alex

Re: [git pull] Please pull powerpc.git merge branch

2012-10-04 Thread Benjamin Herrenschmidt
On Thu, 2012-10-04 at 09:00 -0700, Linus Torvalds wrote: > So this happens if you have "reverse merges" (ie you've pulled my > tree, or some other tree I've pulled), and there is no longer a single > clear common point that you started from. In that case, there is no > simple diff for the "what has

Re: [git pull] Please pull powerpc.git merge branch

2012-10-04 Thread Benjamin Herrenschmidt
On Thu, 2012-10-04 at 09:02 -0700, Linus Torvalds wrote: > Hmm. There's nothing there. > > Did you mean for me to pull some branch/tag you didn't mention? Heh, yeah, the mirrors hadn't updated yet so git request-pull didn't put the branch name in. It's common but I usually fix it up by hand. Sinc

Re: [PATCH] MM: Support more pagesizes for MAP_HUGETLB/SHM_HUGETLB v6

2012-10-22 Thread Benjamin Herrenschmidt
On Mon, 2012-10-22 at 18:23 +0200, Michael Kerrisk (man-pages) wrote: > Since PowerPC already allows 16GB page sizes, doesn't there need to be > allowance for the possibility of future expansion? Choosing a larger > minimum size (like 2^16) would allow that. Does the minimum size need > to be 16k?

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 21:41 +, Alan Cox wrote: > On Wed, 13 Feb 2008 08:04:07 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > > > On Fri, 2008-02-08 at 01:44 +0

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > - couple of fixes and preparatory patches > > > > - rework of PowerMac media-bay support ([un]register IDE devices instead of >

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 15:58 +, Tim Ellis wrote: > This change causes attached drives to no longer be detected and > function on the PowerPC Buffalo Linkstation machines: > > <7>pata_sil680 :00:0c.0: version 0.4.8 > <6>sil680: 133MHz clock. > <6>scsi0 : pata_sil680 > <6>scsi1 : pata_sil

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 12:49 +0100, Gabriel Paubert wrote: > On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote: > > > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > - couple of fixes and preparatory patches > > >

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

2008-02-13 Thread Benjamin Herrenschmidt
On Wed, 2008-02-13 at 18:35 +0100, Christian Krafft wrote: > sensors_detect crashes kernel on PowerPC, as it pokes directly to memory. > This patch adds a check_legacy_ioports to read_port and write_port. > It will now return ENXIO, instead of oopsing. > > Signed-off-by: Christian Krafft <[EMAIL

Re: [RFC/PATCH] [POWERPC] Make lmb support large physical addressing

2008-02-13 Thread Benjamin Herrenschmidt
On Wed, 2008-02-13 at 16:43 -0600, Becky Bruce wrote: > Convert the lmb code to use phys_addr_t instead of unsigned long for > physical addresses and sizes. This is needed to support large amounts > of RAM on 32-bit systems that support 36-bit physical addressing. > > Built/booted on mpc8641; bu

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-13 Thread Benjamin Herrenschmidt
On Wed, 2008-02-13 at 23:52 +0100, Rafael J. Wysocki wrote: > On Monday, 4 of February 2008, Alexey Dobriyan wrote: > > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka > > "PCI: Fix bus resource assignment on 32 bits with 64b resources" > > renders one tg3-equipped box networkless here. > > H

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
On Fri, 2008-02-15 at 15:53 +, Alan Cox wrote: > > > That's strange though. Somebody with knowledge of that HW (or specs) who > > > can spot something ? Could it be an issue with timing ? > > > > > > I don't have HW access to this machine. If somebody could send one to me > > > I could do mor

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
> Ben, would an ssh access to such a machine and to a terminal server > suffice? If I can remote-reboot it, yes. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] libata: Add MMIO support to pata_sil680

2008-02-15 Thread Benjamin Herrenschmidt
On Fri, 2008-02-15 at 22:27 +, Alan Cox wrote: > > The dbdma start is mostly harmless (things don't get posted for -that- > > long), though I suppose it's worth fixing. Would reading back dmactl do > > in that case or do you foresee any kind of side effect ? (Maybe only > > doing it for MMIO ?

Re: [PATCH 1/2] fb: add support for foreign endianness

2008-02-16 Thread Benjamin Herrenschmidt
On Tue, 2008-02-05 at 18:44 +0300, Anton Vorontsov wrote: > This patch adds support for the framebuffers with non-native > endianness. This is done via FBINFO_FOREIGN_ENDIAN flag that will > be used by the drivers. Depending on the host endianness this flag > will be overwritten by FBINFO_BE_MATH

[git pull] Please pull powerpc.git merge branch

2012-07-26 Thread Benjamin Herrenschmidt
vm/bookehv: Fix build regression Anton Blanchard (2): powerpc: Enable pseries hardware RNG and crypto modules powerpc: Lack of firmware flash support is not an error Benjamin Herrenschmidt (1): powerpc: Update g5_defconfig Steven Rostedt (1): powerpc/ftrace: Trace function gra

Re: [PATCH] powerpc/smp: Do not disable IPI interrupts during suspend

2012-07-27 Thread Benjamin Herrenschmidt
On Fri, 2012-07-27 at 16:58 -0500, Kumar Gala wrote: > On Jul 20, 2012, at 7:47 AM, Zhao Chenhui wrote: > > > During suspend, all interrupts including IPI will be disabled. In this case, > > the suspend process will hang in SMP. To prevent this, pass the flag > > IRQF_NO_SUSPEND when requesting IP

[git pull] Please pull powerpc.git merge branch

2012-07-31 Thread Benjamin Herrenschmidt
3s_32: Fix MTMSR_EERI macro (2012-07-31 15:21:20 +1000) Alexander Graf (1): powerpc/kvm/book3s_32: Fix MTMSR_EERI macro Benjamin Herrenschmidt (1): Merge remote-tracking branch 'kumar/merge' into merg

Re: CRYPTO_DEV_NX merge problem (Re: linux-next: Tree for July 31)

2012-07-31 Thread Benjamin Herrenschmidt
On Wed, 2012-08-01 at 08:00 +1000, Michael Neuling wrote: > > OK. Please post the fix as a patch. Anton's patch is already in the > powerpc next tree so it won't be changed/rebased directly. > > I'm not sure who can carry this, since the crypto tree doesn't have > Anton's change and the power

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-21 Thread Benjamin Herrenschmidt
On Thu, 2012-09-20 at 18:53 -0400, David Miller wrote: > From: Benjamin Herrenschmidt > Date: Fri, 21 Sep 2012 08:22:44 +1000 > > > Hrm, that's ancient gunk, I'll have to dig. We potentially can support > > ISA devices DMA'ing from an ISA brid

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2012-09-22 Thread Benjamin Herrenschmidt
On Sat, 2012-09-22 at 16:00 -0400, David Miller wrote: > > I think I'm going to just end up restricting this driver to X86 > as was originally suggested. Probably the easiest fix indeed. > There seems to be no real consistent Kconfig protection for users > of isa_virt_to_bus() and friends. > >

Re: [RESEND PATCH 2/4] asm-generic: io: don't perform swab during {in,out} string functions

2012-10-28 Thread Benjamin Herrenschmidt
On Sun, 2012-10-28 at 10:28 +0100, Geert Uytterhoeven wrote: > > This is due to how the PCI bus is wired to the CPU bus, which is called > > "byte address invariant". When doing a read of your byte 0, the CPU will > > effectively read 0 with byte enables picking 48. Since the CPU wants > > the fir

Re: [PATCH 02/10] KVM: PPC: reserve a capability number for multitce support

2013-08-26 Thread Benjamin Herrenschmidt
On Mon, 2013-08-26 at 15:37 +0300, Gleb Natapov wrote: > > Gleb, any chance you can put this (and the next one) into a tree to > > "lock in" the numbers ? > > > Applied it. Sorry for slow response, was on vocation and still go > through the email backlog. Thanks. Since it's not in a topic branch

Re: [PATCH 02/10] KVM: PPC: reserve a capability number for multitce support

2013-08-26 Thread Benjamin Herrenschmidt
On Tue, 2013-08-27 at 14:19 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-08-26 at 15:37 +0300, Gleb Natapov wrote: > > > Gleb, any chance you can put this (and the next one) into a tree to > > > "lock in" the numbers ? > > > > > Applied it

[git pull] Please pull powerpc.git merge branch

2013-08-27 Thread Benjamin Herrenschmidt
linux/kernel/git/benh/powerpc.git merge for you to fetch changes up to d220980b701d838560a70de691b53be007e99e78: powerpc/hvsi: Increase handshake timeout from 200ms to 400ms. (2013-08-27 16:59:56 +1000) Benjamin Herrenschmi

Re: [PATCH 02/10] KVM: PPC: reserve a capability number for multitce support

2013-08-27 Thread Benjamin Herrenschmidt
On Tue, 2013-08-27 at 09:40 +0300, Gleb Natapov wrote: > > Thanks. Since it's not in a topic branch that I can pull, I'm going to > > just cherry-pick them. However, they are in your "queue" branch, not > > "next" branch. Should I still assume this is a stable branch and that > > the numbers aren't

Re: [PATCH 02/10] KVM: PPC: reserve a capability number for multitce support

2013-08-27 Thread Benjamin Herrenschmidt
On Tue, 2013-08-27 at 09:41 +0300, Gleb Natapov wrote: > > Oh and Alexey mentions that there are two capabilities and you only > > applied one :-) > > > Another one is: > [PATCH v8] KVM: PPC: reserve a capability and ioctl numbers for > realmode VFIO > ? Yes, thanks ! Cheers, Ben. -- To unsub

Re: Regression: x86/mm: new _PTE_SWP_SOFT_DIRTY bit conflicts with existing use

2013-08-27 Thread Benjamin Herrenschmidt
On Wed, 2013-08-21 at 09:30 -0700, Linus Torvalds wrote: > I will be reverting the whole soft-dirty mess. I thought the > bit-mapping games it played were already too complicated (the patch to > pgtable-2level.h in commit 41bb3476b361 just makes me want to barf and > came in very late, so I'm not p

Re: [PATCH v8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

2013-08-27 Thread Benjamin Herrenschmidt
On Wed, 2013-08-28 at 10:51 +1000, Alexey Kardashevskiy wrote: > The ioctl I made up is basically a copy of KVM_CREATE_SPAPR_TCE which does > the same thing for emulated devices and it is there for quite a while but > it is not really extensible. And these two ioctls share some bits of code. > Now

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-08-28 Thread Benjamin Herrenschmidt
On Wed, 2013-08-28 at 18:40 -0700, Linus Torvalds wrote: > Just FYI: I've merged two preparatory patches in my tree for the whole > lockref thing. Instead of applying your four patches as-is during the > merge window, I ended up writing two patches that introduce the > concept and use it in the den

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-01 Thread Benjamin Herrenschmidt
On Tue, 2013-10-01 at 13:19 +0200, Paolo Bonzini wrote: > Il 01/10/2013 11:38, Benjamin Herrenschmidt ha scritto: > > So for the sake of that dogma you are going to make us do something that > > is about 100 times slower ? (and possibly involves more lines of code) > > If

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 10:46 +0200, Paolo Bonzini wrote: > > Thanks. Any chance you can give some numbers of a kernel hypercall and > a userspace hypercall on Power, so we have actual data? For example a > hypercall that returns H_PARAMETER as soon as possible. I don't have (yet) numbers at han

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 11:11 +0200, Alexander Graf wrote: > Right, and the difference for the patch in question is really whether > we handle in in kernel virtual mode or in QEMU, so the bulk of the > overhead (kicking threads out of guest context, switching MMU > context, etc) happens either way.

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 13:02 +0300, Gleb Natapov wrote: > Yes, I alluded to it in my email to Paul and Paolo asked also. How this > interface is disabled? Also hwrnd is MMIO in a host why guest needs to > use hypercall instead of emulating the device (in kernel or somewhere > else?). Migration wil

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 13:02 +0300, Gleb Natapov wrote: > Yes, I alluded to it in my email to Paul and Paolo asked also. How this > interface is disabled? Also hwrnd is MMIO in a host why guest needs to > use hypercall instead of emulating the device (in kernel or somewhere > else?). Another things

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 16:08 +0200, Alexander Graf wrote: > A guest should live on the same permission level as a user space > application. If you run QEMU as UID 1000 without access to /dev/mem, > why should the guest suddenly be able to directly access a memory > location (MMIO) it couldn't access

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 17:10 +0300, Gleb Natapov wrote: > > The hwrng is accessible by host userspace via /dev/mem. > > > Regular user has no access to /dev/mem, but he can start kvm guest and > gain access to the device. Seriously. You guys are really trying hard to make our life hell or what ? T

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-02 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 17:37 +0300, Gleb Natapov wrote: > On Wed, Oct 02, 2013 at 04:33:18PM +0200, Paolo Bonzini wrote: > > Il 02/10/2013 16:08, Alexander Graf ha scritto: > > > > The hwrng is accessible by host userspace via /dev/mem. > > > > > > A guest should live on the same permission level a

Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems

2013-10-03 Thread Benjamin Herrenschmidt
On Thu, 2013-10-03 at 08:43 +0300, Gleb Natapov wrote: > Why it can be a bad idea? User can drain hwrng continuously making other > users of it much slower, or even worse, making them fall back to another > much less reliable, source of entropy. Not in a very significant way, we generate entropy a

[git pull] Please pull powerpc.git merge branch

2013-10-03 Thread Benjamin Herrenschmidt
Hi Linus ! Here are a few powerpc fixes, all aimed at -stable, found in part thanks to the ramping up of a major distro testing and in part thanks to the LE guys hitting all sort interesting corner cases. The most scary are probably the register clobber issues in csum_partial_copy_generic(), espe

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-05 Thread Benjamin Herrenschmidt
On Sat, 2013-10-05 at 16:20 +0200, Alexander Gordeev wrote: > So my point is - drivers should first obtain a number of MSIs they *can* > get, then *derive* a number of MSIs the device is fine with and only then > request that number. Not terribly different from memory or any other type > of resourc

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-05 Thread Benjamin Herrenschmidt
On Sun, 2013-10-06 at 08:02 +0200, Alexander Gordeev wrote: > On Sun, Oct 06, 2013 at 08:46:26AM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2013-10-05 at 16:20 +0200, Alexander Gordeev wrote: > > > So my point is - drivers should first obtain a number of MSIs they *ca

  1   2   3   4   5   6   7   8   9   10   >