On 3/9/21 9:47 AM, John Garry wrote:
> This does fall over if some tags are allocated without associated
> request queue, which I do not know exists.
The only tag allocation mechanism I know of is blk_mq_get_tag(). The
only blk_mq_get_tag() callers I know of are __blk_mq_alloc_request() and
blk_mq
On 1/26/21 8:00 PM, Asutosh Das wrote:
> Resumes the scsi device before accessing it.
>
> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
> Signed-off-by: Asutosh Das
> Signed-off-by: Can Guo
> Signed-off-by: Bao D. Nguyen
No Change-Id tags in upstream patches please.
Thanks,
Bart.
anagement Input Parameters
> Field Description
> Input Parameter 2 LSB: Task Tag of the task/command operated by the task
> management function.
Thanks for the clarification. Feel free to add the following to this patch:
Reviewed-by: Bart Van Assche
On 1/20/21 7:23 PM, Can Guo wrote:
> Current task management request send/compl implementation is broken, the
> problems and fixes are listed as below:
>
> Problem: TMR completion timeout. ufshcd_tmc_handler() calls
> blk_mq_tagset_busy_iter(fn == ufshcd_compl_tm()), but since
>
On 1/26/21 11:59 AM, Maxim Mikityanskiy wrote:
> The cited commit introduced a serious regression with SATA write speed,
> as found by bisecting. This patch reverts this commit, which restores
> write speed back to the values observed before this commit.
>
> The performance tests were done on a He
On 12/31/20 9:44 PM, Can Guo wrote:
> During system resume/suspend, hba could be NULL. In this case, do not touch
> eh_sem.
>
> Fixes: 88a92d6ae4fe ("scsi: ufs: Serialize eh_work with system PM events and
> async scan")
>
> Signed-off-by: Can Guo
> ---
> drivers/scsi/ufs/ufshcd.c | 9 +
On 1/4/21 7:33 AM, John Garry wrote:
> On 23/12/2020 15:47, Bart Van Assche wrote:
>> I propose to change the order in which blk_mq_sched_free_requests(q) and
>> blk_mq_debugfs_unregister(q) are called. Today blk_mq_sched_free_requests(q)
>> is called by blk_cleanup_queue()
On 6/16/20 7:07 PM, Finn Thain wrote:
> On Tue, 16 Jun 2020, Bart Van Assche wrote:
>> As far as I know the sbp driver only has had one user ever and that user
>> is no longer user the sbp driver.
>
> So, you estimate the userbase at zero. Can you give a confidence level?
On 1/4/21 2:50 PM, Finn Thain wrote:
> On Mon, 4 Jan 2021, Bart Van Assche wrote:
>> Additionally, there is a good alternative available for the sbp driver.
>> Every system I know of that is equipped with a Firewire port also has an
>> Ethernet port. So users who want t
On 11/26/20 7:02 AM, Pradeep P V K wrote:
> Observes below crash while accessing (use-after-free) request queue
> member of struct request.
>
> 191.784789: <2> Unable to handle kernel paging request at virtual
> address ff81429a4440
> ...
> 191.786174: <2> CPU: 3 PID: 213 Comm: kworker/3:1
On 11/20/20 8:35 AM, Alan Stern wrote:
> On Fri, Nov 20, 2020 at 12:37:22AM -0800, Can Guo wrote:
>> Runtime resume is handled by runtime PM framework, no need to forcibly
>> set runtime PM status to RPM_ACTIVE during system resume/thaw/restore.
>
> Sorry, I don't understand this explanation at al
On 03/11/14 21:48, Alexander Gordeev wrote:
> On Tue, Mar 11, 2014 at 07:10:18PM +0100, Bart Van Assche wrote:
>>> I assume the BUG() above hits? If so, I am failing to understand how
>>> the code gets here. Mind elaborate?
>>
>> You are correct, the BUG() m
On 03/12/14 09:41, Alexander Gordeev wrote:
> Still the hunk below (a) breaks the 'pool->percpu_max_size' threshold
> and (b) somehow suboptimal, because you wake another thread while a
> free tag was/is on this CPU. If it is still here we would better to
> grab it. If not, it was stolen by another
trace cdd1a8a7968266cf ]---
Signed-off-by: Bart Van Assche
Cc: Alexander Gordeev
CC: Jens Axboe
Cc: Kent Overstreet
Cc: Shaohua Li
Cc: Christoph Hellwig
Cc: Mike Christie
---
lib/percpu_ida.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/percpu_ida.c b/lib
On 03/12/14 16:21, Alexander Gordeev wrote:
> While 'remote->nr_free' could be dropped on another CPU it still does not
> explain how steal_tags() enters the loop, but fails to locate 'cpus_have_tags'
> count of bits.
>
> So although v2 of your patch fixes the crash it does not address the root
>
On 11/27/13 03:29, Chen Gang wrote:
> the macro "SP" is too common to make conflict with some architectures,
> so recommend to add prefix for it.
>
> The related warning (with allmodconfig for hexagon):
>
> CC [M] drivers/scsi/scsi_lib.o
> drivers/scsi/scsi_lib.c:46:0: warning: "SP" redefi
+0x5a/0x90
[] vfs_read+0x9b/0x160
[] SyS_read+0x49/0xa0
[] tracesys+0xd0/0xd5
---[ end trace cdd1a8a7968266cf ]---
Signed-off-by: Bart Van Assche
Cc: Kent Overstreet
Cc: Shaohua Li
Cc: Christoph Hellwig
Cc: Jens Axboe
Cc: Alexander Gordeev
Cc: Mike Christie
---
lib/percpu_ida.c | 5 -
1
On 03/11/14 14:51, Alexander Gordeev wrote:
> On Mon, Mar 10, 2014 at 03:12:33PM +0100, Bart Van Assche wrote:
>> Avoid that percpu_ida_alloc() hangs or crashes if there are still
>> tags are available. Wait until a tag becomes available instead of
>> giving up when running ou
On 05/17/14 14:38, Mikulas Patocka wrote:
> I found a memory leak in iSCSI target that was caused by kref initialized
> to zero (the memory object was allocated with kzalloc, kref_init was not
> called and kref_put_spinlock_irqsave was called which changed "0" to "-1"
> and didn't free the object).
On 05/17/14 23:14, Mikulas Patocka wrote:
> BTW. if we talk about performance - what about replacing:
>
> if (atomic_dec_and_test(&variable)) {
> ... release(object);
> }
>
> with this:
>
> if (atomic_read(&variable) == 1 || atomic_dec_and_test(&variable)) {
>
On 03/21/14 16:37, Christoph Hellwig wrote:
> Just curious: why do you think implementing this as a block remapper
> inside device mapper is a better idea than as a blk-mq driver?
>
> At the request layer you already get a lot of infrastructure for all the
> queueing infrastructure for free, as w
Patch "bug: Make BUG() always stop the machine" changed the
behavior of BUG() with CONFIG_BUG=n from a no-op into an infinite
loop. Modify the definition of BUG_ON() accordingly such that the
behavior of BUG_ON(1) is identical to that of BUG().
Signed-off-by: Bart Van Assche
Cc: Arn
On 06/19/14 19:21, j...@joshtriplett.org wrote:
> That's exactly what BUG_ON becomes if CONFIG_BUG=y, and that
> significantly increases kernel size; if you want that, set CONFIG_BUG=y.
> BUG_ON should continue to compile to nothing if CONFIG_BUG=n, or
> CONFIG_BUG=n has no reason to exist.
Hello
On 07/01/14 21:39, Mike Snitzer wrote:
> (btw, Bart Van Assche also has issues with commit e8099177 due to hangs
> during cable pull testing of mpath devices -- Bart: curious to know if
> your cable pull tests pass if you just revert bcccff93).
Sorry but even with bcccff93 reverted af
On 06/27/14 00:07, Elliott, Robert (Server Storage) wrote:
>> -Original Message-
>> From: Jens Axboe [mailto:ax...@kernel.dk]
>> Sent: Wednesday, 25 June, 2014 11:51 PM
>> To: Christoph Hellwig; James Bottomley
>> Cc: Bart Van Assche; Elliott, Robert
able]
int subclass = SINGLE_DEPTH_NESTING;
^
Signed-off-by: Bart Van Assche
Acked-by: David Rientjes
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: David S. Miller
Cc: Andrew Morton
---
include/linux/spinlock.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/spinlo
On 06/12/14 15:48, Christoph Hellwig wrote:
> The usage of blk-mq dramatically decreases CPU usage under all workloads going
> down from 100% CPU usage that the old setup can hit easily to usually less
> than 20% for maxing out storage subsystems with 512 byte reads and writes,
> and it allows to e
bi_rw.
Note: some but not all submit_bio() callers have been fixed
such that bi_rw is set before bio_add_page() is called.
See also http://thread.gmane.org/gmane.comp.file-systems.ocfs2.devel/7988
for a prior discussion of this topic.
Compile tested only, hence the "RFC".
Signed-off-by
On 06/03/14 21:33, Paolo Bonzini wrote:
> From: Ulrich Obergfell
>
> After scsi_try_to_abort_cmd returns, the eh_abort_handler may have
> already found that the command has completed in the device, causing
> the host_byte to be nonzero (e.g. it could be DID_ABORT). When
> this happens, ORing DID
On 06/04/14 12:11, Paolo Bonzini wrote:
> v1->v2: fix all occurrences of "scmd->result |= DID_TIME_OUT << 16"
> in patch 4
Hello Paolo,
Thanks for the quick respin. However, since you are mentioning that in
v2 all occurrences of "scmd->result |= DID_TIME_OUT << 16" have been
addressed, th
On 06/04/14 20:08, Rickard Strandqvist wrote:
> Minimized the use of snprintf()
> And removed a variable that was only used for the temporary storage.
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/scsi/bfa/
On 06/05/14 08:55, Bart Van Assche wrote:
> On 06/04/14 20:08, Rickard Strandqvist wrote:
> This is ugly. Please use sprintf(buf, "%.*s\n", PAGE_SIZE - 1, str)
> instead of strncpy() + strlen().
(replying to my own e-mail)
The above should of course have read "sprintf(
Avoid that gcc reports the following warning when building with W=1:
warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
Signed-off-by: Bart Van Assche
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: Vincent Guittot
---
include/linux/sched.h | 8
1 file changed
able]
int subclass = SINGLE_DEPTH_NESTING;
^
Signed-off-by: Bart Van Assche
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: David S. Miller
---
include/linux/spinlock.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index 3f2867f..
On 06/12/14 15:48, Christoph Hellwig wrote:
> Bart and Robert have helped with some very detailed measurements that they
> might be able to send in reply to this, although these usually involve
> significantly reworked low level drivers to avoid other bottle necks.
In case someone would like to se
On 06/18/14 05:44, Jens Axboe wrote:
> Thanks for posting these numbers, Bart. The CPU utilization and IOPS
> speak a very clear message. The only mystery is why the singe threaded
> performance is down. That we need to get sort, but it's not a show
> stopper for inclusion.
>
> If you run the sing
On 02/03/14 15:34, Masanari Iida wrote:
> This patch fixed following warnings on make htmldocs.
>
> Warning(/drivers/scsi/scsi_transport_srp.c:819):
> No description found for parameter 'rport'
>
> Signed-off-by: Masanari Iida
> ---
> drivers/scsi/scsi_transport_srp.c | 2 ++
> 1 file changed,
On 10/20/13 18:09, Douglas Gilbert wrote:
Given that lk 3.12.0 release is not far away, the safest path
may still be to revert Vaughan Cao's patch. I'll leave that
decision to the maintainers.
Hello Doug,
Thanks for looking into this. But I would appreciate it if you could
address the whitesp
On 12/17/13 20:53, Sasha Levin wrote:
> I'm still seeing warnings with this patch applied:
>
> [ 24.900482] WARNING: CPU: 12 PID: 3654 at lib/debugobjects.c:260
> debug_print_object+
> 0x8d/0xb0()
> [ 24.900482] ODEBUG: free active (active state 0) object type:
> timer_list hint: delay
> ed_wo
On 12/19/13 13:12, Bart Van Assche wrote:
> On 12/17/13 20:53, Sasha Levin wrote:
>> I'm still seeing warnings with this patch applied:
>>
>> [ 24.900482] WARNING: CPU: 12 PID: 3654 at lib/debugobjects.c:260
>> debug_print_object+0x8d/0xb0()
>> [ 24.90048
On 11/13/13 02:10, David Decotigny wrote:
This patch avoids to use an object after it was potentially reclaimed
by scsi_device_put().
Signed-off-by: David Decotigny
---
drivers/scsi/scsi_scan.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_scan.c
This series consists of the following three patches:
0001-kobject-Fix-source-code-comment-spelling.patch
0002-firmware-loader-Add-sparse-annotation.patch
0003-driver-core-Fix-use-after-free-triggered-by-bus_unre.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
Signed-off-by: Bart Van Assche
---
lib/kobject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/kobject.c b/lib/kobject.c
index 5b4b888..0061f55 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -346,7 +346,7 @@ static int kobject_add_varg(struct kobject *kobj, struct
Avoid that sparse reports the following warning on __fw_free_buf():
drivers/base/firmware_class.c:230:9: warning: context imbalance in
'__fw_free_buf' - unexpected unlock
Signed-off-by: Bart Van Assche
Cc: Ming Lei
---
drivers/base/firmware_class.c | 1 +
1 file changed, 1 insertio
48 89 f8 0f 1f 40 00 48 83 c0 01 80
RIP [] strlen+0x0/0x30
RSP
---[ end trace 210f883ef80376aa ]---
Signed-off-by: Bart Van Assche
---
drivers/base/bus.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 73f6c
On 01/04/14 19:06, Mikulas Patocka wrote:
> - if (t && !t->release)
> - pr_debug("kobject: '%s' (%p): does not have a release() "
> - "function, it is broken and must be fixed.\n",
> - kobject_name(kobj), kobj);
> -
Has it been considered t
On 08/29/14 08:19, Hannes Reinecke wrote:
> On 08/29/2014 04:42 AM, Mike Christie wrote:
>> How are distros handling 0x6/0x3f/0x0e (report luns changed) when it
>> gets passed to userspace? Is everyone kicking off a new full (add and
>> delete) scan to handle this or logging it? Is the driver retur
On 09/06/14 16:40, Douglas Gilbert wrote:
On 14-09-05 11:25 AM, Bart Van Assche wrote:
An LLD must call scsi_remove_host() directly or indirectly from the
module
cleanup path. scsi_remove_host() triggers a call to
blk_cleanup_queue(). That
last function sets the flag QUEUE_FLAG_DYING which
On 09/05/14 15:56, Douglas Gilbert wrote:
With scsi-mq I think many LLDs probably have a new
race possibility between a surprise rmmod of the LLD
and another thread presenting a new command at about
the same time (or another thread's command completing
around that time). Does anything above the L
On 07/23/14 01:16, David Rientjes wrote:
> On Tue, 22 Jul 2014, Andrew Morton wrote:
>>> Evaluating a macro argument only if certain configuration options
>>> have been selected is confusing and error-prone. Hence always
>>> evaluate the second argument of spin_lock_nested() and
>>> spin_lock_nest_
ING;
^
Signed-off-by: Bart Van Assche
Acked-by: David Rientjes
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: David S. Miller
Cc: Andrew Morton
---
include/linux/spinlock.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/spinlock.h b/include/linux/spin
On 08/06/14 23:56, David Rientjes wrote:
> On Wed, 6 Aug 2014, Bart Van Assche wrote:
>> diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
>> index 3f2867f..485d5dc 100644
>> --- a/include/linux/spinlock.h
>> +++ b/include/linux/spinlock.h
>> @@ -1
ING;
^
Signed-off-by: Bart Van Assche
Cc: Ingo Molnar
Cc: David Rientjes
Cc: Peter Zijlstra
Cc: David S. Miller
Cc: Andrew Morton
---
include/linux/spinlock.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
in
On 10/07/14 10:46, Bart Van Assche wrote:
Thanks for looking into this. I can't reproduce the I/O lockup after
having reverted my patch and after having applied your patch. In the
test I ran fio was started with the following command-line options:
fio --bs=512 --ioengine=libaio --rw=ran
[] deactivate_locked_super+0x44/0x60
[] deactivate_super+0x4e/0x70
[] cleanup_mnt+0x43/0x90
[] __cleanup_mnt+0x12/0x20
[] task_work_run+0xac/0xe0
[] do_notify_resume+0x61/0xa0
[] int_signal+0x12/0x17
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Robert Elliott
Cc: Ming Lei
Cc: # v3.12+
---
block
alloc+0xd6/0x3d0
[] ? kmem_cache_alloc+0x175/0x3d0
[] do_io_submit+0x11c/0x490
[] SyS_io_submit+0x10/0x20
[] system_call_fastpath+0x16/0x1b
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Ming Lei
Cc: Robert Elliott
Cc:
---
block/blk-mq-tag.c | 31 +++
1
While we are at it, how about the patch below ? That patch shouldn't
change any functionality but should make bt_clear_tag() slightly easier
to read.
Thanks,
Bart.
[PATCH] blk-mq: Make bt_clear_tag() easier to read
Eliminate a backwards goto statement from bt_clear_tag().
Signed-off-by: B
On 10/22/14 15:24, Mikulas Patocka wrote:
I uploaded the new version of SCSI/device-mapper XCOPY patches here:
http://people.redhat.com/~mpatocka/patches/kernel/xcopy/series.html
I am also sending the patches in the following emails.
Hello Mikulas,
Which is the base commit of this patch serie
On 04/14/2016 02:39 AM, Dan Carpenter wrote:
It's possible to use "err" without initializing it. If it happens to be
a 2 which is SCSI_DH_RETRY then that could cause a bug.
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
b/drivers/scsi/device_handler/scsi
On 04/14/2016 11:20 AM, Dan Carpenter wrote:
It's possible to use "err" without initializing it. If it happens to be
a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Van Assche
pointed out that we should probably re-initialize it for every iteration
through the retr
On 05/24/2016 06:52 AM, Bryant G. Ly wrote:
+config SCSI_IBMVSCSIS
+ tristate "IBM Virtual SCSI Server support"
+ depends on PPC_PSERIES && SCSI_SRP && TARGET_CORE
+ help
+ This is the IBM POWER Virtual SCSI Target Server
+
+ The userspace component needed to in
On 05/24/2016 09:34 AM, Greg KH wrote:
On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote:
+static inline long h_send_crq(struct ibmvscsis_adapter *adapter,
+ u64 word1, u64 word2)
+{
+ long rc;
+ struct vio_dev *vdev = adapter->dma_
ust waiting for Sagi Grimberg to speak for iSER and for
Bart van Assche to speak for SRP and let me know that they are OK with
the change. I think a patch set that will essentially change the
licensing nature of their code should carry their explicit approval of
the license change.
(+linux-rdma)
He
On 05/26/16 17:08, Long Li wrote:
The block sector size should be in unit of 512 bytes, not in bytes.
Signed-off-by: Long Li
---
drivers/scsi/sd.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
---
On 11/13/2015 02:00 AM, Nicholas A. Bellinger wrote:
Hello Linus,
Apologies for the late PULL request.
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
This series contains HCH's changes to absorb configfs attribute ->show()
+ ->store() functi
On 11/13/2015 05:46 AM, Christoph Hellwig wrote:
The new name is irq_poll as iopoll is already taken. Better suggestions
welcome.
Hello Christoph,
Would it be possible to provide more background information about this ?
Which other kernel subsystem is using the name iopoll ? I think the name
On 11/13/2015 10:25 AM, Jason Gunthorpe wrote:
On Fri, Nov 13, 2015 at 02:46:43PM +0100, Christoph Hellwig wrote:
This adds an abstraction that allows ULP to simply pass a completion
object and completion callback with each submitted WR and let the RDMA
core handle the nitty gritty details of ho
blank line after declarations. Checkpatch should have
reported this. Anyway:
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
On 12/17/2015 09:49 AM, Johannes Thumshirn wrote:
On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote:
Johannes,
Thank you for the time and effort on the patch. At this time, as it doesn't
functionally change anything, I did not include the patch. I will consider
it if we see additional
On 11/13/2015 05:46 AM, Christoph Hellwig wrote:
- ret = ib_post_send(ch->qp, &wr.wr, &bad_wr);
- if (ret)
- break;
+ if (i == n_rdma - 1) {
+ /* only get completion event for the last rdma read */
+
On 11/18/2015 01:15 AM, Sagi Grimberg wrote:
On 18/11/2015 03:17, Bart Van Assche wrote:
On 11/13/2015 05:46 AM, Christoph Hellwig wrote:
-ret = ib_post_send(ch->qp, &wr.wr, &bad_wr);
-if (ret)
-break;
+if (i == n_rdma - 1) {
+
On 11/17/2015 11:55 PM, Sagi Grimberg wrote:
+static void ib_cq_poll_work(struct work_struct *work)
+{
+struct ib_cq *cq = container_of(work, struct ib_cq, work);
+int completed;
+
+completed = __ib_process_cq(cq, IB_POLL_BUDGET_WORKQUEUE);
+if (completed >= IB_POLL_BUDGET_WORKQUE
On 11/24/2015 02:35 PM, Ben Hutchings wrote:
3.2.74-rc1 review patch. If anyone has any objections, please let me know.
--
From: Bart Van Assche
commit bf2cf3baa20b0a6cd2d08707ef05dc0e992a8aa0 upstream.
Hi Ben,
This patch fixes one bug but introduces another one ... So
On 11/22/14 15:39, Julia Lawall wrote:
Return a negative error code on failure.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.
ocket.
Signed-off-by: Bart Van Assche
Reviewed-by: Sagi Grimberg
Cc: Christoph Hellwig
Cc: Ming Lei
---
block/blk-mq-cpumap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq-cpumap.c b/block/blk-mq-cpumap.c
index 1065d7c..8e56455 100644
--- a/block/blk-mq-cpu
On 05/22/15 08:11, Nicholas A. Bellinger wrote:
diff --git a/include/target/target_core_base.h
b/include/target/target_core_base.h
index e2c0eaf..def5bc8 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -638,7 +638,6 @@ struct se_lun_acl {
};
struct
On 05/22/15 08:11, Nicholas A. Bellinger wrote:
> Here is -v2 series for converting LIO target se_node_acl + se_lun
> mapping tables from fixed size arrays to dynamic RCU hlist_heads.
The full list of new sparse warnings introduced by this patch series for
source files under drivers/target is as f
On 05/26/15 10:13, kbuild test robot wrote:
Signed-off-by: Fengguang Wu
---
target_core_device.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_device.c
b/drivers/target/target_core_device.c
index 2321884..1d309ad 100644
--- a/drivers/targe
On 05/26/15 08:57, Nicholas A. Bellinger wrote:
> @@ -625,6 +626,7 @@ int core_dev_add_initiator_node_lun_acl(
> u32 lun_access)
> {
> struct se_node_acl *nacl = lacl->se_lun_nacl;
> + struct se_device *dev = lockless_dereference(lun->lun_se_dev);
>
> if (!nacl)
>
On 05/26/15 08:57, Nicholas A. Bellinger wrote:
- Add various rcu_dereference and lockless_dereference RCU notation
Hello Nic,
Feedback from an RCU expert (which I'm not) would be appreciated here.
But my understanding is that lockless_dereference(p) should be used for
a pointer p that ha
(sr_index_lock);
/* This semaphore is used to mediate the 0->1 reference get in the
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vg
Document when it is safe to call this function for blk-mq queues.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Shaohua Li
---
block/blk-timeout.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index 246dfb1
On 12/02/14 17:35, Sabrina Dubroca wrote:
> Hello, sorry for the delay.
>
> 2014-10-29, 20:36:03 +0100, Peter Zijlstra wrote:
>> On Wed, Oct 29, 2014 at 07:33:00PM +0100, Thomas Gleixner wrote:
>>> Yuck. No. You are just papering over the problem.
>>>
>>> What happens if you add 'threadirqs' to th
> declared. Should it be static?
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On 02/05/15 13:26, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 5 Feb 2015 13:20:42 +0100
>
> The srp_destroy_fr_pool() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using th
In the source file fs/fcntl.c and also in the fcntl() man page one
can see that the FD_CLOEXEC flag can be manipulated via F_GETFD and
F_SETFD. Update the comment in accordingly.
Signed-off-by: Bart Van Assche
Cc: David Miller
Cc: Stephen Rothwell
---
include/uapi/asm-generic/fcntl.h | 2
On 01/23/15 19:42, James Bottomley wrote:
> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
> index 08c90a7..31ba254 100644
> --- a/drivers/scsi/scsi.c
> +++ b/drivers/scsi/scsi.c
> @@ -965,6 +965,15 @@ int scsi_report_opcode(struct scsi_device *sdev,
> unsigned char *buffer,
> }
> EXPORT
On 01/29/15 00:52, Ming Lei wrote:
> On Thu, Jan 29, 2015 at 2:28 AM, Bart Van Assche
> wrote:
>> This patch fixes a use-after-free that was introduced via patch
>> "blk-mq: fix hctx/ctx kobject use-after-free" (commit
>> 76d697d10769; kernel v3.19-rc4) and fix
On 01/28/15 22:45, James Bottomley wrote:
> On Wed, 2015-01-28 at 10:23 +0100, Bart Van Assche wrote:
>> Is this the latest version of this patch that is available ? I have
>> tried to test the above patch. However, I couldn't test the impact of
>> this patch on the SRP
On 01/29/15 13:18, Ming Lei wrote:
> The kobject memory inside blk-mq hctx/ctx shouldn't have been freed
> before the kobject is released because driver core can access it freely
> before its release.
>
> We can't do that in all ctx/hctx/mq_kobj's release handler because
> it can be run before blk
On 12/12/14 01:42, Akira Hayakawa wrote:
1. Writeboost shouldn't split the bio into 4KB chunks.
No. It is necessary.
I know WALB (https://github.com/starpos/walb) logs data without
splitting but the data structure becomes complicated.
If you read my code carefully, you will notice that splitting
On 12/12/14 10:35, Akira Hayakawa wrote:
Writeboost batches number of writes into a log (that is 512KB large) and
submits to SSD
which maximizes the throughput and the lifetime of the SSD.
Does this mean that dm-writeboost is similar to btier ? If so, this
makes me wonder which of these two s
On 03/15/16 15:39, Ming Lin wrote:
+static void sg_mempoll_free(struct scatterlist *sgl, unsigned int nents)
Please change mempoll into mempool.
Thanks,
Bart.
On 04/05/16 13:58, Bjorn Helgaas wrote:
This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7.
Direct callers of __netpoll_setup() depend on it to set np->dev,
so we can't simply move that assignment up to netpoll_stup().
Reported-by: Bart Van Assche
Signed-off-by: Bjorn
On 04/16/2016 01:55 PM, Davidlohr Bueso wrote:
... as the call obviously already implies unlock/RC semantics,
therefore lets get rid of the superfluous smp_mb calls.
Hello Davidlohr,
Are you sure that this patch has been sent to the right person? I have
helped to review a change in this code
On 04/25/2016 05:10 AM, Philipp Reisner wrote:
As long as the value is 0 the feature is disabled. With setting
it to a positive value, DRBD limits and aligns its resync requests
to the rs-discard-granularity setting. If the sync source detects
all zeros in such a block, the resync target discards
On 04/25/2016 05:10 AM, Philipp Reisner wrote:
If during resync we read only zeroes for a range of sectors assume
that these secotors can be discarded on the sync target node.
Hello Phil,
With which interconnect(s) has this patch been tested? I'm afraid that
for high-speed interconnects this
On 04/25/2016 05:13 AM, Philipp Reisner wrote:
+ while (nr_sectors >= granularity) {
+ nr = min_t(sector_t, nr_sectors, max_discard_sectors);
+ err |= blkdev_issue_discard(bdev, start, nr, GFP_NOIO, 0);
+ nr_sectors -= nr;
+ start += n
On 04/25/2016 09:42 AM, Philipp Reisner wrote:
Am Montag, 25. April 2016, 08:35:26 schrieb Bart Van Assche:
On 04/25/2016 05:10 AM, Philipp Reisner wrote:
As long as the value is 0 the feature is disabled. With setting
it to a positive value, DRBD limits and aligns its resync requests
to the
ee_cmd_mailbox(mdev->dev, mailbox);
return ret;
Reviewed-by: Bart Van Assche
601 - 700 of 1594 matches
Mail list logo
