Re: Improving AIO cancellation

2013-02-08 Thread Bart Van Assche
On 02/08/13 04:42, Anatol Pomozov wrote: Hi, At Google we have several applications that heavily use asynchronous IO. One thing that our userspace developers need is effective AIO cancellation. You might say "sure use io_cancel syscall". Well, while it cancels AIO requests it does it ineffective

Re: How to online remove an error scsi disk from the system?

2013-01-31 Thread Bart Van Assche
On 02/01/13 07:13, Tao Ma wrote: In our product system, we have several sata disks attached to one machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang forever and we will get something in /var/log/messages like below. It seems to me that the io sent to the scsi la

Re: [PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

2012-09-01 Thread Bart Van Assche
On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: > This patchset aims at fixing bugs that have been discovered in our own > SRP test environment so far. These patches are based on your patchset v4, > "Make ib_srp better suited for H.A. purposes",(09 Aug 2012). > > The 5th patch, "fix an erro

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 2:54 PM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Wed, 30 Jan 2008 14:10:47 +0100 > "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > > > On Jan 30, 2008 11:56 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > > > > >

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Bart Van Assche
ll take some time however. Disktest is new to me -- any hints with regard to suitable combinations of command line parameters are welcome. The most recent version I could find on http://ltp.sourceforge.net/ is ltp-20071231. Bart Van Assche. -- To unsubscribe from this list: send the line &quo

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Bart Van Assche
of RAM cache and system call > performance than actual IO. I have ran some tests with Bonnie++, but found out that on a fast network like IB the filesystem used for the test has a really big impact on the test results. If anyone has a suggestion for a better test than dd to compare the performan

Re: Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread Bart Van Assche
ftp/wp-reducing-datacenter-power-consumption.pdf Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
+ iSCSI showed information about licensing deals. Licensing deals can only be closed for software that is not entirely licensed under the GPL. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mor

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
and InfiniBand have specific advantages. See also: InfiniBand Trade Association, InfiniBand Architecture Specification Release 1.2.1, http://www.infinibandta.org/specs/register/publicspec/ Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
On Feb 1, 2008 11:39 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: > > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > > > The PyX storage engine support

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
the GPL version (http://zaal.org/iscsi/index.html). The above implies that this statement is incorrect. Tomo, are you the maintainer of this web page ? I'll try to measure the performance of the LIO Target Stack on the same setup on which I ran the other performance tests. Bart Van Assche. --

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Bart Van Assche
ttp://bugzilla.kernel.org/show_bug.cgi?id=9883). Another issue I have to look further into is that dd and xdd report different results for very large block sizes (> 1 MB). Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [Cbe-oss-dev] LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Bart Van Assche
custom LIO arch detection script ? config.guess is included with a.o. automake and libtool. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
y outperforms NFS for situations when performing streaming, database like accesses and small file transactions. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: kara_am

2008-02-05 Thread Bart Van Assche
2005 ISBN: 0-596-00255-6 Pages: 1062 Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
and some graphs, see also http://software.qlayer.com/display/iSCSI/Measurements . Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
): Block transfer sizes over about 64kB are totally irrelevant for 99% of all people. Please read my e-mail (posted earlier today) with a comparison for 4 KB - 64 KB block transfer sizes between SCST and STGT. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [patch/rfc/rft] sd: allocate request_queue on device's local numa node

2012-10-22 Thread Bart Van Assche
On 10/22/12 21:01, Jeff Moyer wrote: All of the infrastructure is available to allocate a request_queue on a particular numa node, but it isn't being utilized at all. Wire up the sd driver to allocate the request_queue on the HBA's local numa node. This is a request for comments and testing (I'

Re: [patch/rfc/rft] sd: allocate request_queue on device's local numa node

2012-10-23 Thread Bart Van Assche
On 10/23/12 18:52, Jeff Moyer wrote: Bart Van Assche writes: Please keep in mind that a single PCIe bus may have a minimal distance to more than one NUMA node. See e.g. the diagram at the top of page 8 in http://bizsupport1.austin.hp.com/bc/docs/support/SupportManual/c03261871/c03261871.pdf

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-12 Thread Bart Van Assche
s clearly incorrect: * transport_allocate_passthrough(). * iscsi_do_build_list(). Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: Integration of SCST in the mainstream Linux kernel

2008-02-15 Thread Bart Van Assche
On Thu, Feb 7, 2008 at 2:45 PM, Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > > Bart Van Assche wrote: > > Since the focus of this thread shifted somewhat in the last few > > messages, I'll try to summarize what has been discussed so far: > > - There was

Re: BUG/ spinlock lockup, 2.6.24

2008-02-15 Thread Bart Van Assche
ioned > before. Did you already run memtest ? You can run memtest by booting from the Knoppix CD-ROM or DVD. Most Linux distributions also have included memtest on their bootable distribution CD's/DVD's. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscri

Re: [patch 01/10] scsi: make __scsi_alloc_queue numa-aware

2012-11-02 Thread Bart Van Assche
On 10/30/12 21:14, Jeff Moyer wrote: Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer --- drivers/scsi/scsi_lib.c |2 +- 1 files changed, 1 insertions(+), 1 del

Re: [patch,v2 01/10] scsi: add scsi_host_alloc_node

2012-11-03 Thread Bart Van Assche
On 11/02/12 22:45, Jeff Moyer wrote: diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 593085a..7d7ad8b 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -336,16 +336,25 @@ static struct device_type scsi_host_type = { **/ struct Scsi_Host *scsi_host_alloc(struct sc

Re: [patch,v2 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

2012-11-03 Thread Bart Van Assche
On 11/02/12 22:45, Jeff Moyer wrote: diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..4db6973 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16 +173,20 @@ static DEFINE_MUTEX(host_cmd_pool_mutex); * NULL on failure */ static struct scsi_cmnd * -scs

Re: [patch,v2 05/10] sd: use alloc_disk_node

2012-11-03 Thread Bart Van Assche
On 11/02/12 22:45, Jeff Moyer wrote: Signed-off-by: Jeff Moyer --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..8deb915 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2714,7 +2714,7

Re: [patch,v2 05/10] sd: use alloc_disk_node

2012-11-05 Thread Bart Van Assche
On 11/05/12 15:12, Jeff Moyer wrote: Bart Van Assche writes: On 11/02/12 22:45, Jeff Moyer wrote: Signed-off-by: Jeff Moyer --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..8deb915

Re: [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number

2012-07-26 Thread Bart Van Assche
On 07/26/12 09:21, James Bottomley wrote: > On Thu, 2012-07-26 at 11:04 +0200, Paolo Bonzini wrote: >> Il 26/07/2012 10:52, James Bottomley ha scritto: > +static unsigned int virtscsi_get_lun(u8 *lun_bytes) > +{ > + unsigned int lun = (lun_bytes[2] << 8) | lun_bytes[3]; > + return l

Re: [GIT PULL] please pull infiniband.git

2013-07-10 Thread Bart Van Assche
On 07/10/13 16:38, Roland Dreier wrote: On Wed, Jul 10, 2013 at 7:35 AM, Sebastian Riemer wrote: I've checked the commits on that tag and the following commit is not what we've agreed on: Sorry about that. The discussion was long and complex and I probably made a mistake in aplying the patc

Re: [PATCH] prevent CVE-2012-2372 rds-ping causes kernel panic

2012-10-22 Thread Bart Van Assche
On 10/22/12 20:12, Jay Fenlason wrote: If you use rds-ping of the local IP address of some Infiniband HCAs (QLogic, possibly others) the machine will panic with a BUG_ON due to an overly restrictive check. Loosen the restriction a bit This should have gotten sent a while ago (it was first notic

Re: [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

2012-11-10 Thread Bart Van Assche
On 11/09/12 20:18, Jeff Moyer wrote: - cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask); + cmd = kmem_cache_alloc_node(pool->cmd_slab, + gfp_mask | pool->gfp_mask | __GFP_ZERO, + node); Hello Jeff,

Re: [patch,v3 00/10] make I/O path allocations more numa-friendly

2012-11-16 Thread Bart Van Assche
llowing to the first five patches in this series: Reviewed-by: Bart Van Assche Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

[PATCH] kbuild: Unbreak cleaning external module build directory

2012-11-18 Thread Bart Van Assche
Cc: Nick Bowler Cc: Richard Weinberger Cc: Michal Marek Cc: Signed-off-by: Bart Van Assche --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9f6ca12..46b9be5 100644 --- a/Makefile +++ b/Makefile @@ -1252,7 +1252,7 @@ scripts: ; endif # KB

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Bart Van Assche
On 05/30/13 01:01, Andrew Morton wrote: On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche wrote: Make sure that the round_jiffies*() functions return a time that is in the future when the jiffies counter is about to wrap. Actually "when the jiffies counter has recently wrapped".

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-25 Thread Bart Van Assche
On 06/25/13 05:18, Matthew Wilcox wrote: On Mon, Jun 24, 2013 at 10:07:51AM +0200, Ingo Molnar wrote: I'm wondering, how will this scheme work if the IO completion latency is a lot more than the 5 usecs in the testcase? What if it takes 20 usecs or 100 usecs or more? There's clearly a threshol

Re: [PATCH] scsi_prep_fn() check for empty queue

2013-06-26 Thread Bart Van Assche
On 06/26/13 11:02, Maxim Uvarov wrote: This fix: end_request: I/O error, dev sdc, sector 976576 rport-0:0-3: blocked FC remote port time out: removing target and saving binding BUG: unable to handle kernel NULL pointer dereference at 0400 IP: [] scsi_prep_state_check+0xe/0x99 [] s

Re: I/O blocked while dirty pages are being flushed

2013-03-24 Thread Bart Van Assche
On 03/24/13 06:12, Fredrik Tolf wrote: While this flush is running, I find that many a process goes into disk sleep waiting for the flush to complete. This includes the process manipulating the mmapped file whenever it tries to redirty a page currently waiting to be flushed, but also, for instanc

Re: [PATCH V7 4/5] virtio-scsi: introduce multiqueue support

2013-03-25 Thread Bart Van Assche
On 03/23/13 12:28, Wanlong Gao wrote: +static struct virtio_scsi_vq *virtscsi_pick_vq(struct virtio_scsi *vscsi, + struct virtio_scsi_target_state *tgt) +{ + struct virtio_scsi_vq *vq; + unsigned long flags; + u32 queue_num; + +

Re: [GIT PULL] Final round of SCSI updates for the 3.8+ merge window

2013-03-01 Thread Bart Van Assche
On 03/01/13 10:19, James Bottomley wrote: This is an assorted set of stragglers into the merge window with driver updates for qla2xxx, megaraid_sas, storvsc and ufs. It also includes pulls of the uapi tree (all the remaining SCSI pieces) and the fcoe tree (updates to fcoe and libfc) Hello Jame

[PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-21 Thread Bart Van Assche
Make sure that the round_jiffies*() functions return a time that is in the future when the jiffies counter is about to wrap. Signed-off-by: Bart Van Assche Cc: Thomas Gleixner Cc: Arjan van de Ven Cc: Stephen Rothwell --- kernel/timer.c |4 +--- 1 file changed, 1 insertion(+), 3

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-04 Thread Bart Van Assche
On 08/02/12 08:41, Chanho Min wrote: > This patch is to fix a oops from a torn down device. When > scsi_run_queue process starved queues, scsi_request_fn can race with > scsi_remove_device. In this case, rarely, scsi_request_fn release the > last reference and set sdev->request_queue to NULL. It re

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-04 Thread Bart Van Assche
On 08/04/12 16:46, Mike Christie wrote: > I think we have to have scsi-ml do a get_device when a sdev is added to > the starved entry and then do a put_device when it is removed (must do > these under the host lock for the starved entry case too). I am not sure > if that is just a hack/papering-ove

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-06 Thread Bart Van Assche
On 08/04/12 22:36, Mike Christie wrote: > On 08/04/2012 03:18 PM, Bart Van Assche wrote: >> On 08/04/12 16:46, Mike Christie wrote: >>> I think we have to have scsi-ml do a get_device when a sdev is added to >>> the starved entry and then do a put_device when it is remov

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-07 Thread Bart Van Assche
On 08/07/12 08:53, Chanho Min wrote: > On Tue, Aug 7, 2012 at 2:56 AM, Bart Van Assche wrote: >> Indeed. How about the patch below ? Scsi devices are removed from >> starved_list after blk_cleanup_queue() and before put_device(). That >> guarantees that inside scsi_run_queue

Kernel hangs in truncate_inode_pages()

2012-08-24 Thread Bart Van Assche
Hello, If I log in with the open-iscsi initiator to an iSCSI target an power down the target the initiator hangs in truncate_inode_pages(). This happens systematically with kernel 3.6-rc3 and it's something I've never seen with kernel 3.4 or before. Has anyone else already run into this issue ? >

Re: Kernel hangs in truncate_inode_pages()

2012-08-24 Thread Bart Van Assche
On 08/24/12 17:24, Mike Christie wrote: > On 08/24/2012 08:13 AM, Bart Van Assche wrote: >> If I log in with the open-iscsi initiator to an iSCSI target an power >> down the target the initiator hangs in truncate_inode_pages(). This >> happens systematically with kernel 3.6-r

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-07 Thread Bart Van Assche
On 08/07/12 08:53, Chanho Min wrote: > In addition, Is it ironic that we are careful to use put_device at > scsi_request_fn?. If we trigger the ->remove(), > It occur a oops. What about the removal of unlock/lock as patch bellow? > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c >

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

2012-08-08 Thread Bart Van Assche
On 08/08/12 03:42, Chanho Min wrote: > Thank you for the explanation. It look correct. Let's check one more thing. > What If __scsi_remove_device doesn't release device? : reference count > is more than 2. > So We lost starved_list but device is exist. Is there any issue about this? As far as I ca

Re: Integration of SCST in the mainstream Linux kernel

2008-02-18 Thread Bart Van Assche
e as fast as one-sided remote memory reads or writes. As an example, I obtained the following numbers on my setup (SDR 4x network); ib_write_bw: 933 MB/s. ib_read_bw: 905 MB/s. ib_send_bw: 931 MB/s. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

SMP-related kernel memory leak

2008-02-19 Thread Bart Van Assche
anyone notice anything similar ? See also: http://bugzilla.kernel.org/show_bug.cgi?id=9991 Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: SMP-related kernel memory leak

2008-02-19 Thread Bart Van Assche
On Feb 19, 2008 7:18 PM, Oliver Pinter <[EMAIL PROTECTED]> wrote: > On 2/19/08, Bart Van Assche <[EMAIL PROTECTED]> wrote: > > I noticed that the amount of memory used by the Linux kernel steadily > > increases over time on SMP systems (x86 architecture, 32-bit kernel).

Re: Integration of SCST in the mainstream Linux kernel

2008-02-20 Thread Bart Van Assche
On Feb 20, 2008 8:34 AM, Erez Zilber <[EMAIL PROTECTED]> wrote: > Bart Van Assche wrote: > > Or: data sent during the first burst is not transferred via one-sided > > remote memory reads or writes but via two-sided send/receive > > operations. At least on my setup, thes

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
ters. My experience is that the readability of source code decreases when the lines are very long (more than 160 characters). Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [PATCH][SCSI] remove the queue unlock in scsi_requset_fn

2012-08-13 Thread Bart Van Assche
On 08/10/12 03:22, Chanho Min wrote: > We don't need to unlock the queue before put_device in scsi_request_fn() It looks like there is a typo in the patch subject ? Also, you can omit "[SCSI]" from the patch subject - AFAIK James has a script that inserts that text automatically. Bart. -- To uns

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-16 Thread Bart Van Assche
On 08/16/12 01:35, Chanho Min wrote: >> functions will occur in line. I also don't see why the sdev reference >> couldn't drop to zero here. > scsi_request_fn is called under the lock of request_queue->queue_lock. > If we drop the sdev reference to zero here, > scsi_device_dev_release_usercontext

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Bart Van Assche
e are no locking issues) and filesystem and block device each run in another operating system: the filesystem runs inside the virtual machine and iSCSI either runs in the hypervisor or in the native OS. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linu

Re: Integration of SCST in the mainstream Linux kernel

2008-02-06 Thread Bart Van Assche
rivers/infiniband/ulp/iser), you will see that all data is transferred via RDMA and not via TCP/IP. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-07 Thread Bart Van Assche
f the existing iSCSI kernel target implementations (iETD, STGT, SCST and PyX/LIO). As an iSCSI user, I prefer option (3). The big question is whether the various storage target authors agree with this ? Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [PATCH RESEND] remove the queue unlock in scsi_requset_fn

2012-08-18 Thread Bart Van Assche
On 08/16/12 07:52, Bart Van Assche wrote: > On 08/16/12 01:35, Chanho Min wrote: >>> functions will occur in line. I also don't see why the sdev reference >>> couldn't drop to zero here. >> scsi_request_fn is called under the lock of request_queue->queue_l

Re: [PATCH] IB/lmx4: silence GCC warning

2013-02-13 Thread Bart Van Assche
On 10/29/12 10:50, Paul Bolle wrote: On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: You could use: u16 uninitialized_var(vlan); instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at ht

Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

2012-10-11 Thread Bart Van Assche
On 10/11/12 11:15, James Hogan wrote: The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when used in struct osd_cdb_head, but it isn't marked as packed. Some architectures will round the struct size up which triggers BUILD_BUG_ON compile errors in osd_initiator.c when the outer st

Re: Deadlock observed in SCSI device removal

2012-12-15 Thread Bart Van Assche
On 12/15/12 05:22, Amit Sahrawat wrote: We are using kernel version 3.0.33, and the patch which is mentioned for the above problem - is already applied in the kernel. If the kernel reports that io_schedule() hangs that usually means that an I/O request was not finished properly. It would help

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
el code. My (limited) experience with checkpatch is that most checkpatch complaints are easy to resolve. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Integration of SCST in the mainstream Linux kernel

2008-01-23 Thread Bart Van Assche
ions requested by the reviewers ? I expect a.o. that reviewers will ask to move SCST's configuration pseudofiles from procfs to sysfs. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majo

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

2008-01-23 Thread Bart Van Assche
On Jan 18, 2008 1:11 AM, Roland Dreier <[EMAIL PROTECTED]> wrote: > Anyway, here are all the pending things that I'm aware of. As usual, > if something isn't already in my tree and isn't listed below, I > probably missed it or dropped it by mistake. Please remind me again > in that case. Are th

[PATCH] I2C: add support for the PCF8575 chip

2007-10-05 Thread Bart Van Assche
From: Bart Van Assche Add support for the PCF8575 I2C chip. Signed-off-by: Bart Van Assche ([EMAIL PROTECTED]) --- diff -uprN -X orig/linux-2.6.22.9/Documentation/dontdiff orig/linux-2.6.22.9/drivers/i2c/chips/Kconfig linux-2.6.22.9/drivers/i2c/chips/Kconfig --- orig/linux-2.6.22.9/drivers/i2c

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
th ridiculously high values for the following iSER parameters: FirstBurstLength, MaxBurstLength and MaxRecvDataSegmentLength (16 MB, which is more than the 1 MB block size specified to dd). Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
explained in the same thread that it is possible to improve the performance of STGT further, but that this would require a lot of effort (implementing asynchronous I/O in the kernel and also implementing a new caching mechanism using pre-registered buffers). See also: http://sourceforge.net/mailarchive/fo

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 11:56 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Wed, 30 Jan 2008 09:38:04 +0100 > "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > > > > Please specify which parameters you are referring to. As you know I > > Sorry, I can'

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 5:34 PM, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-30 at 09:38 +0100, Bart Van Assche wrote: > > On Jan 30, 2008 12:32 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > > > > > iSER has parameters to limit the maxi

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread Bart Van Assche
On Jan 30, 2008 5:22 PM, James Bottomley <[EMAIL PROTECTED]> wrote: > ... > Deciding what lives in userspace and what should be in the kernel lies > at the very heart of architectural decisions. However, the argument > that "it should be in the kernel because that would make it faster" is > pretty

Re: Is gcc thread-unsafe?

2007-10-26 Thread Bart Van Assche
tp://gcc.gnu.org/ml/gcc/2007-10/msg00465.html Bart Van Assche. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Is gcc thread-unsafe?

2007-10-26 Thread Bart Van Assche
On 10/26/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Fri, 26 Oct 2007, Linus Torvalds wrote: > > > > On Fri, 26 Oct 2007, Bart Van Assche wrote: > > > > > > You can find my proposal to improve gcc here: > > > http://gcc.gnu.org/ml/gcc

Re: Is gcc thread-unsafe?

2007-11-02 Thread Bart Van Assche
declare thread-shared variables volatile if that thread-shared data is consistently protected by calls to locking functions. Bart Van Assche. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Is gcc thread-unsafe?

2007-11-04 Thread Bart Van Assche
On 11/2/07, Andrew Haley <[EMAIL PROTECTED]> wrote: > Bart Van Assche writes: > > On 10/30/07, Andrew Haley <[EMAIL PROTECTED]> wrote: > > > That's what the proposed standard language says, kinda-sorta. There's > > > an informal description at

Re: Is gcc thread-unsafe?

2007-11-04 Thread Bart Van Assche
On 11/4/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Sun, 4 Nov 2007, Bart Van Assche wrote: > > > > Has it already been decided who will do this audit, and when this > > audit will happen ? Has a target date been set when this audit should > > be co

Re: [PATCH] add u64 number parser

2016-07-22 Thread Bart Van Assche
On 07/22/16 17:23, James Smart wrote: + buf = kmalloc(len + 1, GFP_KERNEL); + if (!buf) + return -ENOMEM; + memcpy(buf, s->from, len); + buf[len] = '\0'; Hello James, Have you considered to combine the above kmalloc() and memcpy() calls into a single kasp

Re: [PATCH RFC 00/21] blk-mq: Introduce combined hardware queues

2016-09-19 Thread Bart Van Assche
On 09/19/16 03:38, Alexander Gordeev wrote: > On Fri, Sep 16, 2016 at 05:04:48PM -0400, Keith Busch wrote: > > CC-ing linux-bl...@vger.kernel.org > >> I'm not sure I see how this helps. That probably means I'm not considering >> the right scenario. Could you elaborate on when having multiple hardwa

Re: [PATCH v3 2/3] block: convert to device_add_disk()

2016-06-20 Thread Bart Van Assche
On 06/17/2016 06:34 PM, Dan Williams wrote: diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index ef6b4d960bad..4e7cb5df8e43 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/drivers/ubd_kern.c @@ -823,12 +823,11 @@ static int ubd_disk_register(int major, u64 size, int u

Re: [PATCH v3 1/3] block: introduce device_add_disk()

2016-06-20 Thread Bart Van Assche
art Van Assche

Re: [PATCH 02/13] irq: Introduce IRQD_AFFINITY_MANAGED flag

2016-06-20 Thread Bart Van Assche
On 06/20/2016 02:22 PM, Christoph Hellwig wrote: On Thu, Jun 16, 2016 at 05:39:07PM +0200, Bart Van Assche wrote: On 06/16/2016 05:20 PM, Christoph Hellwig wrote: On Wed, Jun 15, 2016 at 09:36:54PM +0200, Bart Van Assche wrote: My concern is that I doubt that there is an interrupt assignment

Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

2016-06-20 Thread Bart Van Assche
On 06/17/2016 05:47 PM, Arnd Bergmann wrote: - jiffies_to_timespec(jiffies, &v0); - jiffies_to_timespec(lport->boot_time, &v1); - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); + fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ; Does

Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

2016-06-20 Thread Bart Van Assche
On 06/20/2016 04:48 PM, Arnd Bergmann wrote: On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: On 06/17/2016 05:47 PM, Arnd Bergmann wrote: - jiffies_to_timespec(jiffies, &v0); - jiffies_to_timespec(lport->boot_time, &v1); - fc_stats->seconds_since_la

Re: [RFC] IB/srp: Remove create_workqueue

2016-06-21 Thread Bart Van Assche
On 06/20/2016 08:59 PM, Tejun Heo wrote: On Tue, Jun 07, 2016 at 01:00:13PM -0700, Bart Van Assche wrote: srp_remove_wq is used for SRP target port removal work only. This work is neither queued from inside a shrinker nor by the page writeback code so I think it is safe to drop WQ_MEM_RECLAIM

Re: [dm-devel] [RFC][PATCH] dm: Remove dm_bufio_cond_resched()

2016-09-23 Thread Bart Van Assche
On 09/23/16 00:34, Peter Zijlstra wrote: Is anybody still using PREEMPT_NONE? Most workloads also care about latency to some extend. Lots of code has explicit cond_resched() and doesn't worry. From a SLES11 system: $ grep PREEMPT_NONE /boot/config-3.0.101-0.47.67-default CONFIG_PREEMPT_NONE=y

[PATCH] sched: Change READ_ONCE(jiffies) into jiffies

2016-09-25 Thread Bart Van Assche
ady marked volatile. Hence change all 'READ_ONCE(jiffies)' occurrences into 'jiffies'. Signed-off-by: Bart Van Assche Cc: Peter Zijlstra Cc: Oleg Nesterov --- kernel/sched/core.c| 2 +- kernel/sched/cputime.c | 4 ++-- kernel/sched/fair.c| 8 kernel/sched

Re: [PATCH] sched: Change READ_ONCE(jiffies) into jiffies

2016-09-26 Thread Bart Van Assche
On 09/26/16 01:55, Peter Zijlstra wrote: On Sun, Sep 25, 2016 at 07:08:45PM -0700, Bart Van Assche wrote: A quote from Documentation/memory_barriers.txt: For example, because 'jiffies' is marked volatile, it is never necessary to say READ_ONCE(jiffies). The reason for this is that

Re: [PATCH 1/2] wd719x: Remove last declaration using DEFINE_PCI_DEVICE_TABLE

2016-08-31 Thread Bart Van Assche
On 08/31/16 09:19, Joe Perches wrote: > Convert it to the preferred const struct pci_device_id instead. Reviewed-by: Bart Van Assche

Re: Block-level access

2016-09-01 Thread Bart Van Assche
On 09/01/2016 02:48 PM, Alex Austin wrote: CC'ing linux-scsi and linux-block. Also, please CC me in replies. On Thu, Sep 1, 2016 at 4:43 PM, Alex Austin wrote: Hello, What is the most performant way to directly interface with an attached hard drive? I've so far used read()/write() on /dev/sd_

Re: Observing Softlockup's while running heavy IOs

2016-09-01 Thread Bart Van Assche
On 09/01/2016 03:31 AM, Sreekanth Reddy wrote: I reduced the ISR workload by one third in-order to reduce the time that is spent per CPU in interrupt context, even then I am observing softlockups. As I mentioned before only same single CPU in the set of CPUs(enabled in affinity_hint) is busy wit

Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool

2016-09-01 Thread Bart Van Assche
On 09/01/16 13:11, Joe Perches wrote: > Assigning an int to a bitfield:1 can lose precision. > Change the caller argument uses from 1/0 to true/false. Hello Joe, Can you clarify how assigning 0 or 1 to a one-bit bitfield can cause a loss of precision? Thanks, Bart.

Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool

2016-09-02 Thread Bart Van Assche
On 09/01/16 17:51, Joe Perches wrote: > On Fri, 2016-09-02 at 00:47 +0000, Bart Van Assche wrote: >> On 09/01/16 13:11, Joe Perches wrote: >>> >>> Assigning an int to a bitfield:1 can lose precision. >>> Change the caller argument uses from 1/0 to true/false.

Re: [PATCH] iscsi-target: fix spelling mistake "Unsolicitied" -> "Unsolicited"

2016-09-02 Thread Bart Van Assche
On 09/02/2016 07:32 AM, Colin King wrote: Trivial fix to spelling mistakes in pr_debug message and comments Reviewed-by: Bart Van Assche

Re: [PATCH] trivial treewide: Convert dev_set_uevent_suppress argument to bool

2016-09-02 Thread Bart Van Assche
On 09/02/2016 08:41 AM, Joe Perches wrote: On Fri, 2016-09-02 at 13:41 +, Bart Van Assche wrote: On 09/01/16 17:51, Joe Perches wrote: On Fri, 2016-09-02 at 00:47 +, Bart Van Assche wrote: On 09/01/16 13:11, Joe Perches wrote: Assigning an int to a bitfield:1 can lose precision

Re: [PATCH] sched: Avoid that __wait_on_bit_lock() hangs

2016-08-05 Thread Bart Van Assche
On 08/04/2016 07:09 AM, Peter Zijlstra wrote: On Wed, Aug 03, 2016 at 02:51:23PM -0700, Bart Van Assche wrote: So I started testing the patch below that should fix the same hang but without triggering any wait list corruption. diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index

[PATCH v2 0/3] sched: Avoid that __wait_on_bit_lock() hangs

2016-08-06 Thread Bart Van Assche
Hello Ingo, This patch series addresses an issue that my SRP driver test software can trigger reproducibly, namely that __wait_on_bit_lock() hangs. Please review and apply these patches whenever this is convenient for you. The changes compared to the first version of this series are: * Rework

[PATCH v2 2/3] sched: Introduce a local variable in abort_exclusive_wait()

2016-08-06 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Oleg Nesterov Cc: Andrew Morton Cc: Johannes Weiner Cc: Neil Brown Cc: Michael Shaver --- kernel/sched/wait.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH v2 1/3] sched: Avoid that __wait_on_bit_lock() hangs

2016-08-06 Thread Bart Van Assche
2/8/24/185 References: http://www.spinics.net/lists/raid/msg53056.html Signed-off-by: Bart Van Assche Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Oleg Nesterov Cc: Andrew Morton Cc: Johannes Weiner Cc: Neil Brown Cc: Michael Shaver Cc: # v2.6.29+ --- kernel/sched/wait.c | 18 +++-

[PATCH v2 3/3] sched: Avoid that abort_exclusive_wait() triggers spurious wakeups

2016-08-06 Thread Bart Van Assche
Patch "sched: Avoid that __wait_on_bit_lock() hangs" made spurious wakeups possible. Avoid to trigger such spurious wakeups. Signed-off-by: Bart Van Assche Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Oleg Nesterov Cc: Andrew Morton Cc: Johannes Weiner Cc: Neil Brown Cc: Mich

Re: [PATCH v2 1/3] sched: Avoid that __wait_on_bit_lock() hangs

2016-08-06 Thread Bart Van Assche
On 08/05/16 16:09, Bart Van Assche wrote: If delivery of a signal and __wake_up_common() happen concurrently it is possible that the signal is delivered after __wake_up_common() woke up the affected task and before bit_wait_io() checks whether a signal is pending. Avoid that the next waiter is

  1   2   3   4   5   6   7   8   9   10   >