On Mon, Aug 14, 2017 at 04:38:46AM -0700, Bhumika Goyal wrote:
> Make this const as it is only passed as the 2nd argument to the
> function devm_snd_soc_register_platform, which is of type const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
Acked-by:
On 9/16/2018 5:57 PM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
This patch add new bindings required to support MBHC
(Multi Button Headset Control) block in the codec.
This block is used for jack insert/removal detection,
headset type detection and 8 button press/releas
On 9/16/2018 5:57 PM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd9335.c | 268 -
1 file changed, 266 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wc
-bindings/soc/qcom,apr.h
Reviewed-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Otherwise looks good.
Reviewed-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
/sound/qcom,q6afe.h | 31 ++
2 files changed, 135 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.txt
create mode 100644 include/dt-bindings/sound/qcom,q6afe.h
Reviewed-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member
refer to qcom,apr.txt for details of the coommon apr service bindings
Correct "coommon" to "common". Otherwise looks good.
Reviewed-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
++
include/dt-bindings/sound/qcom,q6asm.h | 22 +++
2 files changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt
create mode 100644 include/dt-bindings/sound/qcom,q6asm.h
Reviewed-by: Banajit Goswami
--
The
/qcom/qdsp6/q6dsp-errno.h
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On 5/1/2018 5:08 AM, Srinivas Kandagatla wrote:
This patch adds support to core apr service, which is used to query
status of other static and dynamic services on the dsp.
Signed-off-by: Srinivas Kandagatla
Reviewed-and-tested-by: Rohit kumar
---
sound/soc/qcom/Kconfig| 4 +
soun
/qdsp6/q6afe.h
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
/soc/qcom/qdsp6/q6afe.h | 14 +
2 files changed, 143 insertions(+)
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
?
Also, for better arrangement, please add the port_maps from
PRIMARY_MI2S_RX to QUATERNARY_MI2S_TX in the same sequence of definition
of AFE ports.
Otherwise LGTM.
Once fixed the above comment add-
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
| 171 +--
sound/soc/qcom/qdsp6/q6afe.h | 131 +
2 files changed, 295 insertions(+), 7 deletions(-)
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux
+ ret = -EINVAL;
+ goto fail_cmd;
+ }
+
+fail_cmd:
+ mutex_unlock(&adm->lock);
+ kfree(pkt);
+ return ret;
+}
+EXPORT_SYMBOL_GPL(q6adm_matrix_map);
+
+/**
+ * q6adm_close() - Close adm copp
+ *
+ * @dev: Pointer to adm child device.
+ * @port_id: afe port id.
+ * @perf_mode: perf_mode mode
+ * @copp_idx: copp index to close
+ *
+ * Return: Will be an negative on error or a zero on success.
+ */
+int q6adm_close(struct device *dev, int port_id, int perf_mode, int copp_idx)
perf_mode unused param. Remove for now. Can be added back when needed.
Otherwise LGTM.
Once fixed above, add acked-by
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
therwise LGTM.
Once addressed about, add acked-by-
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
;ac->buf_lock, flags);
+ return 0;
+ }
+
+ buf = kzalloc(((sizeof(struct audio_buffer)) * periods), GFP_ATOMIC);
+ if (!buf) {
+ spin_unlock_irqrestore(&ac->buf_lock, flags);
+ return -ENOMEM;
+ }
+
+
Remove extra blank line.
Ot
+++
1 file changed, 329 insertions(+)
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
+++
1 file changed, 261 insertions(+)
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
to be used with "reg" marked with SND_SOC_NOPM
and FE DAI and BE DAI IDs passed in shift_left and shift_right. This is
to avoid having any "shift" operation issue in DAPM code, when reg is
not marked with SND_SOC_NOPM, and shift value is more than 31.
However, for now, its OK.
Acked-by: Banajit Goswami
insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt
Reviewed-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On 5/1/2018 5:08 AM, Srinivas Kandagatla wrote:
This patch adds support to DB820c machine driver.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/Kconfig | 9 ++
sound/soc/qcom/Makefile | 2 +
sound/soc/qcom/apq8096.c | 238 +++
3 f
/MAINTAINERS
@@ -11531,6 +11531,7 @@ F: drivers/crypto/qat/
QCOM AUDIO (ASoC) DRIVERS
M:Patrick Lai
M:Banajit Goswami
+M: Srinivas Kandagatla
L:alsa-de...@alsa-project.org (moderated for non-subscribers)
S:Supported
F:sound/soc/qcom/
Acked-by: Banajit
ked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
| 1 +
sound/soc/qcom/qdsp6/q6asm-dai.c | 628 +++
3 files changed, 633 insertions(+)
create mode 100644 sound/soc/qcom/qdsp6/q6asm-dai.c
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux
meout\n");
+ rc = -ETIMEDOUT;
+ goto err;
+ }
else set rc to 0 to avoid returning >0 value.
LGTM otherwise.
Acked-by: Banajit Goswami
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
t, so i think that the former copy operation is
> useless and can be removed.
>
> Signed-off-by: Peng Donglin
Acked-by: Banajit Goswami
> ---
> sound/soc/qcom/apq8016_sbc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/qcom/apq8016_sbc.c b/so
ard,the
> function dev_set_drvdata(card->dev, card) will also do the same copy
> operation,so i think that the former copy operation can be removed.
>
> Signed-off-by: Peng Donglin
Acked-by: Banajit Goswami
> ---
> sound/soc/qcom/storm.c | 1 -
> 1 file changed, 1 deletion(-)
>
28 matches
Mail list logo
