Re: [PATCH v12 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-08-02 22:50, Matthias Kaehlcke wrote: On Thu, Aug 02, 2018 at 06:55:12PM +0530, Balakrishna Godavarthi wrote: This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring --- .../bindings

Re: [PATCH v12 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-08-02 23:24, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-08-02 22:50, Matthias Kaehlcke wrote: On Thu, Aug 02, 2018 at 06:55:12PM +0530, Balakrishna Godavarthi wrote: This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by

Re: [PATCH v12 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-08-02 23:40, Matthias Kaehlcke wrote: On Thu, Aug 02, 2018 at 11:35:54PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-08-02 23:24, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-08-02 22:50, Matthias Kaehlcke wrote: > > On Thu, Aug 02

[PATCH v13 0/7]

2018-08-02 Thread Balakrishna Godavarthi
- Adding support to voting up/down regulators for WCN3990. - Bluetooth firmware download for wcn3990. * Add device tree bindings for Atheros chips: These changes are on top of https://patchwork.kernel.org/patch/10316097/. - Description of device tree bindings. B

[PATCH v13 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd --- Changes in v13: * Segregated optional and required properties for wcn3990. --- .../bindings/net/qualcomm-bluetooth.txt

[PATCH v13 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-08-02 Thread Balakrishna Godavarthi
holds the Bluetooth chip connected to APPS processor. soc_ver holds the Bluetooth chip version. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 21 - drivers/bluetooth/btqca.h | 13 +++-- drivers/bluetooth

[PATCH v13 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-08-02 Thread Balakrishna Godavarthi
e these wrapper functions to set speeds. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 93 - 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/

[PATCH v13 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-08-02 Thread Balakrishna Godavarthi
This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers

[PATCH v13 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-08-02 Thread Balakrishna Godavarthi
Enable Qualcomm chips to operate at 3.2Mbps. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 5f8a74d65bec

[PATCH v13 2/7] Bluetooth: btqca: Rename ROME specific functions to generic functions

2018-08-02 Thread Balakrishna Godavarthi
C. To have generic text in logs updated from ROME to QCA where ever possible. This avoids confusion to user, when using the future Qualcomm Bluetooth SoC's. Updated BT_DBG, BT_ERR and BT_INFO with bt_dev_dbg, bt_dev_err and bt_dev_info where ever applicable. Signed-off-by: Balakrishna Godavarthi

[PATCH v13 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- Changes in v13: * updated review comments. Changes in v12: * removed retrying iteration loop in qca_wcn3990_init

Re: [PATCH v13 0/7] Enable Bluetooth functionality for WCN3990

2018-08-02 Thread Balakrishna Godavarthi
my bad forgot to add subject. On 2018-08-03 00:37, Balakrishna Godavarthi wrote: These patches enables Bluetooth functinalties for new Qualcomm Bluetooth chip wnc3990. As this is latest chip with new features, along with some common features to old chip "qcom,qca6174-bt". we have upd

Re: [PATCH v13 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
On 2018-08-03 01:27, Matthias Kaehlcke wrote: On Fri, Aug 03, 2018 at 12:37:32AM +0530, Balakrishna Godavarthi wrote: Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke

[PATCH v14 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-03 Thread Balakrishna Godavarthi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd Reviewed-by: Matthias Kaehlcke --- .../bindings/net/qualcomm-bluetooth.txt | 29 +-- 1 file changed, 27

[PATCH v14 2/7] Bluetooth: btqca: Rename ROME specific functions to generic functions

2018-08-03 Thread Balakrishna Godavarthi
C. To have generic text in logs updated from ROME to QCA where ever possible. This avoids confusion to user, when using the future Qualcomm Bluetooth SoC's. Updated BT_DBG, BT_ERR and BT_INFO with bt_dev_dbg, bt_dev_err and bt_dev_info where ever applicable. Signed-off-by: Balakrishna Godavarthi

[PATCH v14 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-08-03 Thread Balakrishna Godavarthi
This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers

[PATCH v14 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-08-03 Thread Balakrishna Godavarthi
e these wrapper functions to set speeds. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 93 - 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/

[PATCH v14 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-08-03 Thread Balakrishna Godavarthi
Enable Qualcomm chips to operate at 3.2Mbps. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 5f8a74d65bec

[PATCH v14 0/7] Enable Bluetooth functionality for WCN3990

2018-08-03 Thread Balakrishna Godavarthi
- Adding support to voting up/down regulators for WCN3990. - Bluetooth firmware download for wcn3990. * Add device tree bindings for Atheros chips: These changes are on top of https://patchwork.kernel.org/patch/10316097/. - Description of device tree bindings. B

[PATCH v14 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-08-03 Thread Balakrishna Godavarthi
holds the Bluetooth chip connected to APPS processor. soc_ver holds the Bluetooth chip version. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 21 - drivers/bluetooth/btqca.h | 13 +++-- drivers/bluetooth

[PATCH v14 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-03 Thread Balakrishna Godavarthi
Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- Changes in v14: * moved function call qca_read_soc_version() to qca_setup() Changes in v13: * updated review comments

Re: [PATCH v14 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-03 Thread Balakrishna Godavarthi
On 2018-08-03 16:31, Balakrishna Godavarthi wrote: Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- Changes in v14: * moved function call qca_read_soc_version() to

[PATCH v15 0/7] Enable Bluetooth functionality for WCN3990

2018-08-03 Thread Balakrishna Godavarthi
ription of device tree bindings. Balakrishna Godavarthi (7): dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990 Bluetooth: btqca: Rename ROME specific functions to generic functions Bluetooth: btqca: Redefine qca_uart_setup() to generic function. Bluetooth: hc

[PATCH v15 2/7] Bluetooth: btqca: Rename ROME specific functions to generic functions

2018-08-03 Thread Balakrishna Godavarthi
C. To have generic text in logs updated from ROME to QCA where ever possible. This avoids confusion to user, when using the future Qualcomm Bluetooth SoC's. Updated BT_DBG, BT_ERR and BT_INFO with bt_dev_dbg, bt_dev_err and bt_dev_info where ever applicable. Signed-off-by: Balakrishna Godavarthi

[PATCH v15 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-08-03 Thread Balakrishna Godavarthi
e these wrapper functions to set speeds. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 93 - 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/

[PATCH v15 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-08-03 Thread Balakrishna Godavarthi
holds the Bluetooth chip connected to APPS processor. soc_ver holds the Bluetooth chip version. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 21 - drivers/bluetooth/btqca.h | 13 +++-- drivers/bluetooth

[PATCH v15 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-08-03 Thread Balakrishna Godavarthi
Enable Qualcomm chips to operate at 3.2Mbps. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 5f8a74d65bec

[PATCH v15 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-03 Thread Balakrishna Godavarthi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd Reviewed-by: Matthias Kaehlcke --- .../bindings/net/qualcomm-bluetooth.txt | 29 +-- 1 file changed, 27

[PATCH v15 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-08-03 Thread Balakrishna Godavarthi
This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers

[PATCH v15 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-03 Thread Balakrishna Godavarthi
Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- Changes in v15: * addressed return ret to return 0 Changes in v14: * moved function call qca_read_soc_version() to

Re: [PATCH v15 0/7] Enable Bluetooth functionality for WCN3990

2018-08-03 Thread Balakrishna Godavarthi
h/10316097/. - Description of device tree bindings. Balakrishna Godavarthi (7): dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990 Bluetooth: btqca: Rename ROME specific functions to generic functions Bluetooth: btqca: Redefine qca_uart_setup() to generic function. Bluetoot

[PATCH v8 0/7] Enable Bluetooth functionality for WCN3990

2018-06-25 Thread Balakrishna Godavarthi
e bindings. Balakrishna Godavarthi (7): dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990 Bluetooth: btqca: Rename ROME specific functions to Generic functions Bluetooth: btqca: Redefine qca_uart_setup() to generic function. Bluetooth: hci_qca: Add wrapper functions f

[PATCH v8 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-06-25 Thread Balakrishna Godavarthi
This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers

[PATCH v8 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-06-25 Thread Balakrishna Godavarthi
Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 38b7dbe6c897..28187a89b850 100644 --- a/drivers/bluetooth

[PATCH v8 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-06-25 Thread Balakrishna Godavarthi
holds the Bluetooth chip connected to APPS processor. soc_ver holds the Bluetooth chip version. Signed-off-by: Balakrishna Godavarthi --- Changes in v8: * updated soc_type with enum. Changes in v7: * initial patch * redefined qca_uart_setup function to generic. --- drivers/bluetooth

[PATCH v8 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-06-25 Thread Balakrishna Godavarthi
Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi --- changes in v8: * closing qca buffer, if qca_power_setup fails * chnaged ibs start timer function call location. * updated review comments

[PATCH v8 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-06-25 Thread Balakrishna Godavarthi
e these wrapper functions to set speeds. Signed-off-by: Balakrishna Godavarthi --- Changes in v8: * common function to set INIT and operating speeds. * moved hardware flow control to qca_set_speed(). Changes in v7: * initial patch * created wrapper functions for init and o

[PATCH v8 2/7] Bluetooth: btqca: Rename ROME specific functions to Generic functions

2018-06-25 Thread Balakrishna Godavarthi
icable. Signed-off-by: Balakrishna Godavarthi --- Changes in v8: * squashed [v7 2/8] and [v7 3/8] into one. * updated review comments Changes in v7: * updated the all the functions of ROME to generic. Changes in v6: * initial patch * updated names of functions that ar

[PATCH v8 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-06-25 Thread Balakrishna Godavarthi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi --- Changes in v8: * Separated the optional entries between two chips Changes in v7: * no change. Changes in v6: * Changed the oper-speed to max-speed. Changes in

Re: [PATCH v1 1/1] Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990

2018-08-27 Thread Balakrishna Godavarthi
while hci up, we will call vendor specific open/close and setup which will turn on the regulators, requests BT chip version and download the firmware. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 34 ++ 1 file changed, 34 insertions(+) diff

[PATCH v1 0/2] Fix for proto races in hci_serdev.

2018-08-22 Thread Balakrishna Godavarthi
Y while dequeuing an packet. Balakrishna Godavarthi (2): Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races Bluetooth: hci_serdev: Add protocol check in hci_uart_dequeue(). drivers/bluetooth/hci_serdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 d

[PATCH v1 1/2] Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races

2018-08-22 Thread Balakrishna Godavarthi
Clearing HCI_UART_PROTO_READY will avoid usage of proto function pointers before running the proto close function pointer. There is chance of kernel crash, due to usage of non proto close function pointers after proto close. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth

[PATCH v1 2/2] Bluetooth: hci_serdev: Add protocol check in hci_uart_dequeue().

2018-08-22 Thread Balakrishna Godavarthi
] [] skb_dequeue+0x28/0x84 [ 500.160209] [] 0xff8000ad6f48 [ 500.165230] [] 0xff8000ad6610 [ 500.170257] [] process_one_work+0x238/0x3e4 [ 500.176174] [] worker_thread+0x2bc/0x3d4 [ 500.181821] [] kthread+0x138/0x140 [ 500.186945] [] ret_from_fork+0x10/0x18 Signed-off-by: Balakrishna

[PATCH v1 0/2] Bug fixes for qualcomm BT chip wcn3990.

2018-08-22 Thread Balakrishna Godavarthi
open & close call from qca_open & qca_close. Balakrishna Godavarthi (2): Bluetooth: hci_qca: Remove serdev_device_open/close function calls Bluetooth: hci_qca: Remove hdev dereference in qca_close(). drivers/bluetooth/hci_qca.c | 17 + 1 file changed, 9 insertio

[PATCH v1 1/2] Bluetooth: hci_qca: Remove serdev_device_open/close function calls

2018-08-22 Thread Balakrishna Godavarthi
Removed serdev_device_open/close functions from qca_open/close as they are called in hci_uart_register_device() and hci_uart_unregister_device() functions. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH v1 2/2] Bluetooth: hci_qca: Remove hdev dereference in qca_close().

2018-08-22 Thread Balakrishna Godavarthi
freeing it. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index a740d5703914..74f5fede0274 100644 --- a/drivers/bluetooth/hci_qca.c

[PATCH v1 0/1] Cold on & off support for Qualcomm BT chip wcn3990.

2018-08-23 Thread Balakrishna Godavarthi
calling qualcomm setup. Balakrishna Godavarthi (1): Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990 drivers/bluetooth/hci_qca.c | 34 ++ 1 file changed, 34 insertions(+) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora

[PATCH v1 1/1] Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990

2018-08-23 Thread Balakrishna Godavarthi
the regulators, requests BT chip version and download the firmware. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_qca.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index

Re: [PATCH v1 1/1] Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990

2018-08-24 Thread Balakrishna Godavarthi
Hi Stephen, On 2018-08-24 12:17, Stephen Boyd wrote: Quoting Balakrishna Godavarthi (2018-08-23 04:29:35) This patch enables power off support for hci down and power on support for hci up. As wcn3990 power sources are ignited by regulators, we will turn off them during hci down, i.e. an

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-26 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-26 00:01, Matthias Kaehlcke wrote: On Tue, Jul 24, 2018 at 09:25:16PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-07-24 01:24, Matthias Kaehlcke wrote: > On Fri, Jul 20, 2018 at 07:02:43PM +0530, Balakrishna Godavarthi wrote: > > + * som

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-27 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-27 01:21, Matthias Kaehlcke wrote: On Thu, Jul 26, 2018 at 07:51:13PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-07-26 00:01, Matthias Kaehlcke wrote: > On Tue, Jul 24, 2018 at 09:25:16PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, &

[PATCH v11 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi In function qca_setup, we set initial and operating speeds for Qualcomm Bluetooth SoC's. This block of code is common across different Qualcomm Bluetooth SoC's. Instead of duplicating the code, created a wrapper function to set the speeds. So that future co

[PATCH v11 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi --- Changes in v11: * removed support to read regulator currents from dts. * updated review comments. Changes in

[PATCH v11 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi Redefinition of qca_uart_setup will help future Qualcomm Bluetooth SoC, to use the same function instead of duplicating the function. Added new arguments soc_type and soc_ver to the functions. These arguments will help to decide type of firmware files to be loaded

[PATCH v11 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v11 2/7] Bluetooth: btqca: Rename ROME specific functions to generic functions

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi Some of the QCA BTSoC ROME functions, are used for different versions or different make of BTSoC's. Instead of duplicating the same functions for new chip, update names of the functions that are used for both chips to keep this generic and would help in future

[PATCH v11 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring --- Changes in v11: * removed entries of regulator currents. Changes in v10: * added entry for regulator currents

[PATCH v11 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-07-27 Thread Balakrishna Godavarthi
From: Balakrishna Godavarthi Enable Qualcomm chips to operate at 3.2Mbps. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers

[PATCH v11 0/7] Enable Bluetooth functionality for WCN3990

2018-07-27 Thread Balakrishna Godavarthi
or Atheros chips: These changes are on top of https://patchwork.kernel.org/patch/10316097/. - Description of device tree bindings. Balakrishna Godavarthi (7): dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990 Bluetooth: btqca: Rename ROME specific

Re: [PATCH v9 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-20 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-18 22:43, Matthias Kaehlcke wrote: On Wed, Jul 18, 2018 at 09:03:08PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-07-16 21:35, Matthias Kaehlcke wrote: > On Mon, Jul 16, 2018 at 07:21:56PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, &

[PATCH v10 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-07-20 Thread Balakrishna Godavarthi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring --- Changes in v10: * added entry for regulator currents Changes in v9: * updated with latest reg handle and names. * updated max-speed

[PATCH v10 0/7] Enable Bluetooth functionality for WCN3990

2018-07-20 Thread Balakrishna Godavarthi
.org/patch/10316097/. - Description of device tree bindings. Balakrishna Godavarthi (7): dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990 Bluetooth: btqca: Rename ROME specific functions to generic functions Bluetooth: btqca: Redefine qca_uart_setup()

[PATCH v10 2/7] Bluetooth: btqca: Rename ROME specific functions to generic functions

2018-07-20 Thread Balakrishna Godavarthi
C. To have generic text in logs updated from ROME to QCA where ever possible. This avoids confusion to user, when using the future Qualcomm Bluetooth SoC's. Updated BT_DBG, BT_ERR and BT_INFO with bt_dev_dbg, bt_dev_err and bt_dev_info where ever applicable. Signed-off-by: Balakrishna Godavarthi

[PATCH v10 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-07-20 Thread Balakrishna Godavarthi
Enable Qualcomm chips to operate at 3.2Mbps. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 5f8a74d65bec

[PATCH v10 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-07-20 Thread Balakrishna Godavarthi
This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers

[PATCH v10 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-07-20 Thread Balakrishna Godavarthi
holds the Bluetooth chip connected to APPS processor. soc_ver holds the Bluetooth chip version. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 20 +++- drivers/bluetooth/btqca.h | 13 +++-- drivers/bluetooth

[PATCH v10 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-07-20 Thread Balakrishna Godavarthi
e these wrapper functions to set speeds. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 93 - 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/

[PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-20 Thread Balakrishna Godavarthi
Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi --- changes in v10: * added support to read regulator currents from dts. * added support to try to connect with chip if it fails to respond to initial

Re: [PATCH v11 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-07-31 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-31 00:07, Matthias Kaehlcke wrote: On Fri, Jul 27, 2018 at 07:43:16PM +0530, Balakrishna Godavarthi wrote: From: Balakrishna Godavarthi Redefinition of qca_uart_setup will help future Qualcomm Bluetooth SoC, to use the same function instead of duplicating the function

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-31 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-31 01:37, Matthias Kaehlcke wrote: On Fri, Jul 27, 2018 at 05:09:02PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-07-27 01:21, Matthias Kaehlcke wrote: > On Thu, Jul 26, 2018 at 07:51:13PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, &

Re: [PATCH v11 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-31 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-31 02:25, Matthias Kaehlcke wrote: On Fri, Jul 27, 2018 at 07:43:20PM +0530, Balakrishna Godavarthi wrote: From: Balakrishna Godavarthi Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-01 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-31 21:33, Matthias Kaehlcke wrote: On Tue, Jul 31, 2018 at 08:08:40PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-07-31 01:37, Matthias Kaehlcke wrote: > On Fri, Jul 27, 2018 at 05:09:02PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, &

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-01 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-08-01 21:46, Matthias Kaehlcke wrote: On Wed, Aug 01, 2018 at 07:29:29PM +0530, Balakrishna Godavarthi wrote: Hi Matthias, On 2018-07-31 21:33, Matthias Kaehlcke wrote: > On Tue, Jul 31, 2018 at 08:08:40PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, &

[PATCH v12 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-08-02 Thread Balakrishna Godavarthi
holds the Bluetooth chip connected to APPS processor. soc_ver holds the Bluetooth chip version. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- Changes in v12: * updated soc_ver check. Changes in v11: * added error log in qca_read_soc_version() instead

[PATCH v12 6/7] Bluetooth: btqca: Add wcn3990 firmware download support.

2018-08-02 Thread Balakrishna Godavarthi
This patch enables the RAM and NV patch download for wcn3990. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/btqca.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers

[PATCH v12 0/7] Enable Bluetooth functionality for WCN3990

2018-08-02 Thread Balakrishna Godavarthi
or WCN3990. - Bluetooth firmware download for wcn3990. * Add device tree bindings for Atheros chips: These changes are on top of https://patchwork.kernel.org/patch/10316097/. - Description of device tree bindings. Balakrishna Godavarthi (7): dt-bindings: net: bluetooth: Add d

[PATCH v12 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Rob Herring --- .../bindings/net/qualcomm-bluetooth.txt | 26 +-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/Documentation

[PATCH v12 2/7] Bluetooth: btqca: Rename ROME specific functions to generic functions

2018-08-02 Thread Balakrishna Godavarthi
C. To have generic text in logs updated from ROME to QCA where ever possible. This avoids confusion to user, when using the future Qualcomm Bluetooth SoC's. Updated BT_DBG, BT_ERR and BT_INFO with bt_dev_dbg, bt_dev_err and bt_dev_info where ever applicable. Signed-off-by: Balakrishna Godavarthi

[PATCH v12 5/7] Bluetooth: hci_qca: Enable 3.2 Mbps operating speed.

2018-08-02 Thread Balakrishna Godavarthi
Enable Qualcomm chips to operate at 3.2Mbps. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 5f8a74d65bec

[PATCH v12 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-08-02 Thread Balakrishna Godavarthi
e these wrapper functions to set speeds. Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke --- drivers/bluetooth/hci_qca.c | 93 - 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/

[PATCH v12 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-08-02 Thread Balakrishna Godavarthi
Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi --- Changes in v12: * removed retrying iteration loop in qca_wcn3990_init. Changes in v11: * removed support to read regulator currents from dts

Re: [PATCH v10 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

2018-07-23 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-23 23:10, Matthias Kaehlcke wrote: On Fri, Jul 20, 2018 at 07:02:39PM +0530, Balakrishna Godavarthi wrote: Redefinition of qca_uart_setup will help future Qualcomm Bluetooth SoC, to use the same function instead of duplicating the function. Added new arguments soc_type

Re: [PATCH v10 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

2018-07-24 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-23 23:26, Matthias Kaehlcke wrote: On Fri, Jul 20, 2018 at 07:02:40PM +0530, Balakrishna Godavarthi wrote: In function qca_setup, we set initial and operating speeds for Qualcomm Bluetooth SoC's. This block of code is common across different Qualcomm Bluetooth

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

2018-07-24 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-07-24 01:24, Matthias Kaehlcke wrote: On Fri, Jul 20, 2018 at 07:02:43PM +0530, Balakrishna Godavarthi wrote: Add support to set voltage/current of various regulators to power up/down Bluetooth chip wcn3990. Signed-off-by: Balakrishna Godavarthi --- changes in v10

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

2018-09-27 Thread Balakrishna Godavarthi
u8 *)&ba, sizeof(ba)); + if (ret < 0) + return ret; + if (is_zero_ether_addr((u8 *)&ba)) + return -ENODATA; + + *bd_addr = ba; + + return 0; +} +EXPORT_SYMBOL_GPL(device_get_bd_address); Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [PATCH v4 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

2018-09-27 Thread Balakrishna Godavarthi
))) { + if (!device_get_bd_address(&pdev->dev, &btq->bdaddr)) dev_info(&pdev->dev, "BD address %pMR retrieved from device-tree", &btq->bdaddr); - } hdev = hci_alloc_dev(); if (!hdev) Reviewed-by: Balakrishna Godavarthi -- Regards Balakrishna.

Re: [PATCH v2 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2018-11-26 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-11-27 01:12, Matthias Kaehlcke wrote: On Thu, Nov 22, 2018 at 05:45:11PM +0530, Balakrishna Godavarthi wrote: This patch will help to stop frame reassembly errors while changing the baudrate. This is because host send a change baudrate request command to the chip with

Re: [PATCH v2 3/3] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990

2018-11-26 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-11-27 05:57, Matthias Kaehlcke wrote: On Mon, Nov 26, 2018 at 04:09:50PM -0800, Matthias Kaehlcke wrote: On Thu, Nov 22, 2018 at 05:45:12PM +0530, Balakrishna Godavarthi wrote: > During initalization of wcn3990, we observed UART is reading some > stray bytes on

[PATCH v2 0/3] Bug fixes for Qualcomm BT chip wcn3990

2018-11-22 Thread Balakrishna Godavarthi
frame reassembly errors. * Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Changes in v2: * Removed Bluetooth: hci_qca: clear HCI_QUIRK_RESET_ON_CLOSE flag patch will be sending as separate series. Balakrishna Godavarthi (3): Bluetooth: hci_qca: use wait_until_sent() for power

[PATCH v2 3/3] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990

2018-11-22 Thread Balakrishna Godavarthi
: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) Now we enable a flag during bootup to stop executing proto receive function and clear it back once the initialization is done. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke --- v2: * Updated commit text & comments

[PATCH v2 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-11-22 Thread Balakrishna Godavarthi
issues. Signed-off-by: Balakrishna Godavarthi --- v2: * Updated function qca_send_power_pulse() * addressed reviewer comments. v1: * initial patch --- drivers/bluetooth/hci_qca.c | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a

[PATCH v2 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2018-11-22 Thread Balakrishna Godavarthi
with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke --- v2

[PATCH v1] Bluetooth: hci_serdev: Remove setting of HCI_QUIRK_RESET_ON_CLOSE.

2018-11-22 Thread Balakrishna Godavarthi
close, it would be better enabling it in the vendor probes or in proto setup. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_serdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c index c445aa9ac511..490abba

[PATCH v3 2/4] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2018-11-30 Thread Balakrishna Godavarthi
with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke Reviewed

[PATCH v3 3/4] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990

2018-11-30 Thread Balakrishna Godavarthi
: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) Now we enable a flag during bootup to stop executing proto receive function and clear it back once the initialization is done. Signed-off-by: Balakrishna Godavarthi Tested-by: Matthias Kaehlcke --- v3: * moved ibs disable and qca_flush to

[PATCH v3 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-11-30 Thread Balakrishna Godavarthi
issues. Signed-off-by: Balakrishna Godavarthi --- v3: * no change. v2: * Updated function qca_send_power_pulse() * addressed reviewer comments. v1: * initial patch --- drivers/bluetooth/hci_qca.c | 37 + 1 file changed, 13 insertions(+), 24 deletions

[PATCH v3 4/4] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer

2018-11-30 Thread Balakrishna Godavarthi
During hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip. Signed-off-by: Balakrishna Godavarthi

[PATCH v3 0/4] Bug fixes for Qualcomm BT chip wcn3990

2018-11-30 Thread Balakrishna Godavarthi
LOSE flag patch will be sending as separate series. Balakrishna Godavarthi (4): Bluetooth: hci_qca: use wait_until_sent() for power pulses Bluetooth: hci_qca: Deassert RTS while baudrate change command Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Bluetooth: hci_qca: Disable

Re: [PATCH v1 4/4] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990

2018-11-15 Thread Balakrishna Godavarthi
Hi Matthias, On 2018-11-15 01:06, Matthias Kaehlcke wrote: On Tue, Nov 06, 2018 at 05:35:28PM +0530, Balakrishna Godavarthi wrote: [ 176.929612] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) [ 176.945734] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed

Re: [PATCH v1 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses

2018-11-15 Thread Balakrishna Godavarthi
Hi Johan, On 2018-11-14 20:57, Johan Hovold wrote: On Tue, Nov 06, 2018 at 05:35:25PM +0530, Balakrishna Godavarthi wrote: wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing these

  1   2   3   >