Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 6 +-
1 file changed, 5 insertions
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 15 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei-wmi.c | 247
s.
Signed-off-by: Ayman Bagabas
Reviewed-by: Takashi Iwai
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 993d34c141c2..1326f32f4574 100644
--- a/sound/pci/hda/patch_realt
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 15 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei-wmi.c | 247
s.
Signed-off-by: Ayman Bagabas
Reviewed-by: Takashi Iwai
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 993d34c141c2..1326f32f4574 100644
--- a/sound/pci/hda/patch_realt
Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 6 +-
1 file changed, 5 insertions
Huawei PC manager. XF86Tools is
used by default on most desktop environments i.e. Gnome.
Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add support for Huawei WMI hotkeys.
ALSA: hda: add support for Huawei WMI micmute LED
drivers/platform/x86/Kconfig | 15
On Tue, 2018-11-27 at 17:52 +0200, Andy Shevchenko wrote:
> On Tue, Nov 27, 2018 at 1:02 PM Takashi Iwai wrote:
> > On Tue, 27 Nov 2018 03:57:48 +0100,
> > Ayman Bagabas wrote:
> > > + handle = ACPI_HANDLE(&inputdev->dev);
> > > + ar
On Tue, 2018-11-27 at 10:45 +0100, Takashi Iwai wrote:
> On Tue, 27 Nov 2018 03:57:48 +0100,
> Ayman Bagabas wrote:
> > +static const struct key_entry huawei_wmi_keymap[] __initconst = {
> > + { KE_KEY,0x281, { KEY_BRIGHTNESSDOWN } },
> > +
:
* Consistency in file names
* How module would be enabled (Kconfig)
* Match license in SPDX and MODULE_LICENSE
Changes from v3:
* Code formatting
Changes from v2:
* Support for Huawei MBX
* Style and formatting issues
Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 993d34c141c2..1326f32f4574 100644
--- a/sound/pci/hda/patch_realt
Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 6 +-
1 file changed, 5 insertions
. Another solution would be to leave this to
user-space to handle. Which
can be achieved by using "hwdb" tables and remap those keys to "unknown".
This solution seems more natural to me because it leaves the decision to
user-space.
Signed-off-by: Ayman Bagabas
---
drivers/pl
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile| 1 +
drivers/platform
posted on the bug page https://imgur.com/a/N1xsCVZ
[PATCH 3/3]
This enables the micmute LED on Huawei laptops with these IDs:
1. Matebook X (19e5:3200)
2. Matebook X (19e5:3201)
3. Matebook X Pro (19e5:3204)
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers
s.
Signed-off-by: Ayman Bagabas
Reviewed-by: Takashi Iwai
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fa61674a5605..135c0826859b 100644
--- a/sound/pci/hda/patch_realt
Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas
Reviewed-by: Takashi Iwai
---
sound/pci/hda/huawei_wmi_helper.c | 47
On Fri, 2018-12-07 at 00:52 -0500, ayman.baga...@gmail.com wrote:
On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote:
> On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote:
> > On Mon, 03 Dec 2018 19:53:39 +0100,
> > Ayman Bagabas wrote:
> > >
On Mon, 2018-12-03 at 13:00 +0100, Takashi Iwai wrote:
> On Fri, 30 Nov 2018 00:57:37 +0100,
> Ayman Bagabas wrote:
> > This driver adds support for missing hotkeys on some Huawei
> > laptops.
> > Laptops such as the Matebook X have non functioning hotkeys.
> > Whe
On Mon, 2018-12-03 at 13:00 +0100, Takashi Iwai wrote:
> On Fri, 30 Nov 2018 00:57:38 +0100,
> Ayman Bagabas wrote:
> > Some of Huawei laptops come with a LED in the micmute key. This
> > patch
> > enables the use of micmute LED for these devices:
> > 1. Matebook X
and formatting issues
Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add support for Huawei WMI hotkeys.
ALSA: hda: add support for Huawei WMI micmute LED
drivers/platform/x86/Kconfig | 16 +++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 993d34c141c2..1326f32f4574 100644
--- a/sound/pci/hda/patch_realt
Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 6 +-
1
. Another solution would be to leave this to
user-space to handle. Which can be achieved by using "hwdb" tables and
remap those keys to "unknown". This solution seems more natural to me
because it leaves the decision to user-space.
Signed-off-by: Ayman Bagabas
---
drivers/pla
On Mon, 2018-12-03 at 11:41 -0800, Randy Dunlap wrote:
> On 12/3/18 10:53 AM, Ayman Bagabas wrote:
> > This driver adds support for missing hotkeys on some Huawei
> > laptops.
> > Laptops such as the Matebook X have non functioning hotkeys.
> > Whereas
> > newer l
On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote:
> On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote:
> > On Mon, 03 Dec 2018 19:53:39 +0100,
> > Ayman Bagabas wrote:
> > > + if (code == 0x80) {
> > > + acpi_status status;
>
On Thu, 2018-11-08 at 21:59 +0200, Andy Shevchenko wrote:
> On Thu, Nov 8, 2018 at 7:17 PM Ayman Bagabas > wrote:
>
> Is it supposed to go via PDx86 or ALSA tree?
There isn't much of work done on behave of ALSA. So PDx86?
>
> > Changes from v2:
> > * Suppor
On Thu, 2018-11-08 at 21:58 +0200, Andy Shevchenko wrote:
> On Thu, Nov 8, 2018 at 7:17 PM Ayman Bagabas > wrote:
> > This driver adds support for missing hotkeys on some Huawei
> > laptops.
> > Currently, only Huawei Matebook X and Matebook X Pro is supported.
> >
. Matebook X (19e5:3201)
3. Matebook X Pro (19e5:3204)
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers on Huawei MBXP.
ALSA: hda: add support for Huawei WMI micmute LED
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile| 1 +
drivers/platform
Some of Huawei laptops come with a LED in the micmute key. This patch
enables and disable this LED accordingly.
This enables micmute LED for:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/huawei_wmi_helper.c | 47
s.
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fa61674a5605..135c0826859b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sou
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile| 1 +
drivers/platform
://imgur.com/a/N1xsCVZ
[PATCH 3/3]
This enables the micmute LED on Huawei laptops with these IDs:
1. Matebook X (19e5:3200)
2. Matebook X (19e5:3201)
3. Matebook X Pro (19e5:3204)
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers on Huawei MBXP.
ALSA: hda
Some of Huawei laptops come with a LED in the micmute key. This patch
enables and disable this LED accordingly.
This enables micmute LED for:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/huawei_wmi_helper.c | 47
s.
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fa61674a5605..135c0826859b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sou
Changes in v5:
* Consistency in file names
* How module would be enabled (Kconfig)
* Match license in SPDX and MODULE_LICENSE
Changes in v4:
* Code formatting
Changes in v3:
* Support for Huawei MBX
* Style and formatting issues
Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP
. Another solution would be to leave this to
user-space to handle. Which can be achieved by using "hwdb" tables and
remap those keys to "unknown". This solution seems more natural to me
because it leaves the decision to user-space.
Acked-by: Andy Shevchenko
Reviewed-by: Takash
Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Reviewed-by: Andy Shevchenko
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda
Reviewed-by: Andy Shevchenko
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 993d34c141c2..77ee471a67e5 100644
-
Some of Huawei laptops come with a LED in the micmute key. This patch
enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 6 +-
1
. Another solution would be to leave this to
user-space to handle. Which can be achieved by using "hwdb" tables and
remap those keys to "unknown". This solution seems more natural to me
because it leaves the decision to user-space.
Reviewed-by: Takashi Iwai
Signed-off-by
Reviewed-by: Takashi Iwai
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 993d34c141c2..1326f32f4574 100644
--- a/sound/pci/hda/patch_realt
names
* How module would be enabled (Kconfig)
* Match license in SPDX and MODULE_LICENSE
Changes in v4:
* Code formatting
Changes in v3:
* Support for Huawei MBX
* Style and formatting issues
Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add support for Huawei WMI
On Tue, 2018-12-11 at 12:14 +0200, Andy Shevchenko wrote:
> On Tue, Dec 11, 2018 at 8:02 AM Ayman Bagabas <
> ayman.baga...@gmail.com> wrote:
> > This driver adds support for missing hotkeys on some Huawei
> > laptops.
> > Laptops such as the Matebook X have non fu
From bc069762e7e86dd3ab39e55d7b145deb85884dec Mon Sep 17 00:00:00 2001
From: Ayman Bagabas
Date: Wed, 31 Oct 2018 11:24:43 -0400
Subject: [PATCH 1/3] x86: add support for Huawei WMI hotkeys.
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X
From d472c06898cf5a2aebf1a6ef7d5095a672e08901 Mon Sep 17 00:00:00 2001
From: Ayman Bagabas
Date: Wed, 31 Oct 2018 11:34:15 -0400
Subject: [PATCH 2/3] ALSA:hda: fix front speakers on Huawei MBXP.
This patch enables the front speakers on Huawei Matebook X Pro laptops.
These laptops come with
From e7291d296d748b4bdeb3c906b654bf5838c6f8dd Mon Sep 17 00:00:00 2001
From: Ayman Bagabas
Date: Wed, 31 Oct 2018 11:51:09 -0400
Subject: [PATCH 3/3] ALSA:hda: add support for Huawei WMI MicMute LED
Some of Huawei laptops come with a LED in the mic mute key. This patch
enables and disable this
: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 13 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei_wmi.c | 225 ++
3 files changed, 239 insertions(+)
create mode 100644 drivers/platform/x86/huawei_wmi.c
diff --git a/drivers/platform
This patch enables the front speakers on Huawei Matebook X Pro laptops.
These laptops come with Dolby Atmos sound system and these pins
configuration enables the front speakers.
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions
Some of Huawei laptops come with a LED in the mic mute key. This patch
enables and disable this LED when the internal microphone status is
changed.
Signed-off-by: Ayman Bagabas
---
include/linux/huawei_wmi.h| 7
sound/pci/hda/huawei_wmi_helper.c | 66
This patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
https://bugzilla.kernel.org/show_bug.cgi?id=200501
On Wed, 2018-10-31 at 15:20 -0400, Ayman Bagabas wrote:
> This patch enables the front speakers on Huawei Matebook X Pro
> laptops.
> These laptops come wit
/show_bug.cgi?id=200501
It simply uses the pins configurations generated by hdajackretast using the
settings posted on the bug page https://imgur.com/a/N1xsCVZ
[PATCH v3 3/3]
This enables the micmute LED on Huawei laptops using ACPI calls.
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys
Some of Huawei laptops come with a LED in the micmute key. This patch
enables and disable this LED accordingly.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei_wmi.c| 1 +
include/linux/platform_data/x86/huawei_wmi.h | 9
sound/pci/hda/huawei_wmi_helper.c
s.
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fa61674a5605..ed6c9c79ce46 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sou
This driver adds support for missing hotkeys on some Huawei laptops.
Currently, only Huawei Matebook X and Matebook X Pro is supported.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 11 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei_wmi.c | 235
s.
Signed-off-by: Ayman Bagabas
---
sound/pci/hda/patch_realtek.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3ac7ba9b342d..4f7a39c7883c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sou
: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 13 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/huawei_wmi.c | 223 ++
3 files changed, 237 insertions(+)
create mode 100644 drivers/platform/x86/huawei_wmi.c
diff --git a/drivers/platform
method, using
PATCH #1, to turn the micmute LED on/off.
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers on Huawei MBXP.
ALSA: hda: add support for Huawei WMI MicMute LED
drivers/platform/x86/Kconfig | 13 ++
drivers/platform/x86/Makefile
Some of Huawei laptops come with a LED in the mic mute key. This patch
enables and disable this LED accordingly.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei_wmi.c | 1 +
include/linux/huawei_wmi.h| 7 +
sound/pci/hda/huawei_wmi_helper.c | 48
On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote:
> On Fri, Nov 2, 2018 at 6:11 AM Ayman Bagabas > wrote:
> >
> > This driver adds support for missing hotkeys on some Huawei
> > laptops.
> > Currently, only Huawei Matebook X Pro is supported. The driver
>
On Fri, 2018-11-02 at 20:12 +0200, Andy Shevchenko wrote:
> On Fri, Nov 2, 2018 at 6:12 AM Ayman Bagabas > wrote:
> >
> > Some of Huawei laptops come with a LED in the mic mute key. This
> > patch
> > enables and disable this LED accordingly.
> > --- a/drivers
HWMI. WMI0 is the device name
and doesn't have a UID so keep it as it is.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 226 --
1 file changed, 153 insertions(+), 73 deletions(-)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/pla
ebook X (2017) handles micmute led through the "legacy" interface
which is not currently implemented. Use ACPI EC method to control
this led.
and the 2 parameters can enforce the behavior of quirk 1 & 2.
# Add a debugfs interface to WMI
An interface to the WMI manageme
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 77 +++
1 file changed, 77 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/platform/x86/huawei-wmi.c
index 9496ea3c78b5..97ff3d868765 100644
--- a/drivers/platform/x86/hua
Huawei Matebook laptops come with a WMI management interface that can
control various aspects of the device. This interface is also found on
the old Matebook X released in 2017.
Use that to control the mic mute LED.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 217
Controll battery charge thresholds through the battery API and driver's
attributes.
Setting battery charging thresholds can introduce a race condition with
MACH-WX9 where two or more threads are trying to read/write values
from/to EC memory.
Signed-off-by: Ayman Bagabas
---
drivers/pla
Add a debugfs interface that can be used to call the WMI management
interface function if available.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 91 +++
1 file changed, 91 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys.
Along with that, there is this feature called fn-lock that inverts the
behavior of this Fn key and the F1-F12 row.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 85 +++
1
HWMI. WMI0 is the device name
and doesn't have a UID so keep it as it is.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 7 +-
drivers/platform/x86/huawei-wmi.c | 226 --
2 files changed, 156 insertions(+), 77 deletions(-)
diff --git a/dr
havior of quirk 1 & 2.
# Add a debugfs interface to WMI
An interface to the WMI management interface that allows easier
debugging.
Ayman Bagabas (6):
platform/x86: huawei-wmi: Move to platform driver
platform/x86: huawei-wmi: Add quirks and module parameters
platform/x86: huawei-wmi: Imp
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 77 +++
1 file changed, 77 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/platform/x86/huawei-wmi.c
index 9496ea3c78b5..97ff3d868765 100644
--- a/drivers/platform/x86/hua
Huawei Matebook laptops come with a WMI management interface that can
control various aspects of the device. This interface is also found on
the old Matebook X released in 2017.
Use that to control the mic mute LED.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 217
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys.
Along with that, there is this feature called fn-lock that inverts the
behavior of this Fn key and the F1-F12 row.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 85 +++
1
Add a debugfs interface that can be used to call the WMI management
interface function if available.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 91 +++
1 file changed, 91 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b
Control battery charge thresholds through the battery API and driver's
attributes.
Setting battery charging thresholds can introduce a race condition with
MACH-WX9 where two or more threads are trying to read/write values
from/to EC memory.
Signed-off-by: Ayman Bagabas
---
drivers/platfor
ntrol
this led.
and the 2 parameters can enforce the behavior of quirk 1 & 2.
# Add a debugfs interface to WMI
An interface to the WMI management interface that allows easier
debugging.
Ayman Bagabas (6):
platform/x86: huawei-wmi: Move to platform driver
platform/x86: huawei-wmi: Add quirks
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 73 +++
1 file changed, 73 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/platform/x86/huawei-wmi.c
index 9496ea3c78b5..0e919bf56ad1 100644
--- a/drivers/platform/x86/hua
HWMI. WMI0 is the device name
and doesn't have a UID so keep it as it is.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 7 +-
drivers/platform/x86/huawei-wmi.c | 226 --
2 files changed, 156 insertions(+), 77 deletions(-)
diff --git a/dr
Huawei Matebook laptops come with a WMI management interface that can
control various aspects of the device. This interface is also found on
the old Matebook X released in 2017.
Use that to control the mic mute LED.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 217
Control battery charge thresholds through the battery API and driver's
attributes.
Setting battery charging thresholds can introduce a race condition with
MACH-WX9 where two or more threads are trying to read/write values
from/to EC memory.
Signed-off-by: Ayman Bagabas
---
drivers/platfor
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys.
Along with that, there is this feature called fn-lock that inverts the
behavior of this Fn key and the F1-F12 row.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 85 +++
1
Add a debugfs interface that can be used to call the WMI management
interface function if available.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 97 +++
1 file changed, 97 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b
Huawei Matebook laptops come with a WMI management interface that can
control various aspects of the device. This interface is also found on
the old Matebook X released in 2017.
Use that to control the mic mute LED.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 217
not currently implemented. Use ACPI EC method to control
this led.
and the 2 parameters can enforce the behavior of quirk 1 & 2.
# Add a debugfs interface to WMI
An interface to the WMI management interface that allows easier
debugging.
Ayman Bagabas (6):
platform/x86: huawei-wmi: Move t
Control battery charge thresholds through the battery API and driver's
attributes.
Setting battery charging thresholds can introduce a race condition with
MACH-WX9 where two or more threads are trying to read/write values
from/to EC memory.
Signed-off-by: Ayman Bagabas
---
drivers/platfor
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 73 +++
1 file changed, 73 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/platform/x86/huawei-wmi.c
index 9496ea3c78b5..0e919bf56ad1 100644
--- a/drivers/platform/x86/hua
HWMI. WMI0 is the device name
and doesn't have a UID so keep it as it is.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/Kconfig | 7 +-
drivers/platform/x86/huawei-wmi.c | 226 --
2 files changed, 156 insertions(+), 77 deletions(-)
diff --git a/dr
Add a debugfs interface that can be used to call the WMI management
interface function if available.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 97 +++
1 file changed, 97 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c
b
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys.
Along with that, there is this feature called fn-lock that inverts the
behavior of this Fn key and the F1-F12 row.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 85 +++
1
On Tue, 2019-10-15 at 15:46 +0300, Dan Carpenter wrote:
> On Tue, Oct 15, 2019 at 08:21:59AM -0400, Ayman Bagabas wrote:
> > Hi Dan
> >
> > On Tue, Oct 15, 2019, 4:39 AM Dan Carpenter <
> > dan.carpen...@oracle.com>
> > wrote:
> >
> > > I
Hi Gustavo,
On Tue, 2019-10-15 at 13:25 -0500, Gustavo A. R. Silva wrote:
> Comparing the result of strcmp directly with 1 may cause it to be
> misinterpreted. Note that strcmp may return an integer besides -1,
> 0, or 1.
>
> Fix this by returning -ENODEV only when strcmp() returns a value
> othe
Check if battery thresholds are within 0 and 100.
---
drivers/platform/x86/huawei-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/platform/x86/huawei-wmi.c
index 5837d1b8693d..26041d44286a 100644
--- a/drivers/platform/x86/huaw
No need to check for battery name, we already check if the WMI function is
available in huawei_wmi_battery_setup.
---
drivers/platform/x86/huawei-wmi.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/platform/x86/huawei-wmi.c
b/drivers/platform/x86/huawei-wmi.c
index 26041d44286a..
On Sat, 2019-10-19 at 11:31 +0300, Dan Carpenter wrote:
> On Fri, Oct 18, 2019 at 06:42:13PM -0400, Ayman Bagabas wrote:
> > Check if battery thresholds are within 0 and 100.
> > ---
>
> Thanks!
>
> Don't forget to add your Signed-off-by: though.
Signed-off-by:
On Fri, 2019-10-18 at 18:42 -0400, Ayman Bagabas wrote:
> No need to check for battery name, we already check if the WMI
> function is
> available in huawei_wmi_battery_setup.
Signed-off-by: Ayman Bagabas
Thank you,
Ayman
> ---
> drivers/platform/x86/huawei-wmi.c | 4
>
battery_lock mutex is never used and not needed.
Fixes: 355a070b09ab ("platform/x86: huawei-wmi: Add battery charging
thresholds")
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/x86/huawe
Check if battery thresholds are within 0 and 100.
Fixes: 355a070b09ab ("platform/x86: huawei-wmi: Add battery charging
thresholds")
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/
No need to check for battery name, we already check if the WMI function is
available in huawei_wmi_battery_setup.
Fixes: 355a070b09ab ("platform/x86: huawei-wmi: Add battery charging
thresholds")
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 4
1 file
battery_lock mutex is never used and not needed.
Fixes: 355a070b09ab ("platform/x86: huawei-wmi: Add battery charging
thresholds")
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/x86/huawe
1 - 100 of 142 matches
Mail list logo
