Re: [PATCH v2] staging: vt6655: fix space prohibited before that ','

On Mon, Jan 19, 2015 at 12:16:30PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl error: > fix space prohibited before that ',' > > Signed-off-by: Heba Aamer Reviewed-by: Aya Mahfouz > --- > v2: added Signed-off line > > drivers/s

Re: [PATCH] staging: vt6655: mac.h: fix space prohibited before that ','

On Mon, Jan 19, 2015 at 02:30:25PM +0200, Mohamed Lotfy Hammad wrote: > This patch fixes the following checkpatch.pl error: > fix space prohibited before that ',' > > Signed-off-by: Mohamed Lotfy Hammad Reviewed-by: Aya Mahfouz > --- > drivers/staging/vt6655/mac.h

Re: [PATCH] staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)

cachelines: 1, members: 7 */ > /* last cacheline: 30 bytes */ > }; > > Signed-off-by: Heba Aamer Reviewed-by: Aya Mahfouz > --- > drivers/staging/vt6656/rxtx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/rxtx.c

Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl warning: > fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > netdev_info was used since it is a network subsyst

[PATCH] staging: davinci_vpfe: fix space prohibited before semicolon warning

This patch fixes the following checkpatch.pl warning: space prohibited before semicolon Signed-off-by: Aya Mahfouz --- v1: This patch applies to Greg's tree. drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > On 01/28/2015 09:53 AM, Heba Aamer wrote: > >This patch fixes the following checkpatch.pl warning: > >Prefer ether_addr_copy() over memcpy() > >if the Ethernet addresses are __aligned(2) > > > >I used the following coccinelle script: >

[PATCH] staging: media: lirc: modify print calls

This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote: > On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: > > On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: > > > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: > >

Re: [PATCH] staging: media: lirc: modify print calls

On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 4 Nov 2014 23:43:07 +0200 > Aya Mahfouz escreveu: > > > This patches replaces one pr_debug call by dev_dbg and > > changes the device used by one of the dev_err calls. > > Also doesn'

Re: [PATCH] staging: media: lirc: modify print calls

On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote: > On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: > > This patches replaces one pr_debug call by dev_dbg and > > changes the device used by one of the dev_err calls. > > i think you should mention

[PATCH v5] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

for the sake of speed and efficiency. ch->prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz Suggested-by: Arnd Bergmann --- v1: Arnd has advised me to provide

[PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

for the sake of speed and efficiency. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for time calculation. The first option: "accuracy" is used in this patch. The second option: "speed" can be done through jiffies. v2: Moved on

Re: [PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

ill fix that. Sorry! > > Regards, Ursula Braun > Kind Regards, Aya Saif El-yazal Mahfouz > On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote: > > This patch is concerned with migrating the time variables for the s390 > > network driver. The changes handle the y2038 problem wh

[PATCH v3] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

for the sake of speed and efficiency. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for time calculation. The first option: "accuracy" is used in this patch. The second option: "speed" can be done through jiffies. v2: Moved on

[PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

This patch removes one debug message and replaces a dev_err call by pr_err. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc

[PATCH] sound: pci: pcxhr: convert timeval to ktime_t

nanoseconds instead of microseconds. Signed-off-by: Aya Mahfouz Reviewed-by: Arnd Bergmann --- sound/pci/pcxhr/pcxhr.c | 10 ++ sound/pci/pcxhr/pcxhr_core.c | 10 ++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c

[PATCH v2] sound: pci: pcxhr: convert timeval to ktime_t

nanoseconds instead of microseconds. Signed-off-by: Aya Mahfouz Reviewed-by: Arnd Bergmann --- v2: changed variables names to avoid redeclaration conflicts. sound/pci/pcxhr/pcxhr.c | 10 ++ sound/pci/pcxhr/pcxhr_core.c | 10 ++ 2 files changed, 12 insertions(+), 8 deletions

Re: [PATCH] sound: pci: pcxhr: convert timeval to ktime_t

On Tue, Oct 28, 2014 at 12:59:59PM +0100, Takashi Iwai wrote: > At Tue, 28 Oct 2014 13:29:56 +0200, > Aya Mahfouz wrote: > > > > This patch is concerned with migrating the time variables in the pcxhr > > module found in the sound driver. The changes are concerend with the

[PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

variables use monotonic time values through the function ktime_get_ts64(). This is to make sure that all the time values are calculated from a fixed point. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options for time calculation. The first option: "accuracy&quo

[PATCH v4] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

for the sake of speed and efficiency. ch->prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz --- v1: Arnd has advised me to provide you with options

[no subject]

value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c index 11a7cb1..ecdd71e

[PATCH] staging: media: lirc: replace dev_err by pr_err

This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. Signed-off-by: Aya Mahfouz --- drivers/staging/media/lirc/lirc_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers

Re: [PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

On Sun, Nov 02, 2014 at 12:40:13PM +0100, Konrad Zapalowicz wrote: > On 11/01, Aya Mahfouz wrote: > > This patch removes one debug message and replaces a dev_err > > call by pr_err. > > Usually you would like to send this as two separate patches because > replacin

[PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

for the sake of speed and efficiency. ch->prof.tx_time will now hold the difference between two jiffies' values instead of the difference between two xtime values represented in microseconds. Signed-off-by: Aya Mahfouz Suggested-by: Arnd Bergmann --- v1: Arnd has advised me to provide

[PATCH] net: dns_resolver: convert time_t to time64_t

Changes the definition of the pointer _expiry from time_t to time64_t. This is to handle the Y2038 problem where time_t will overflow in the year 2038. The change is safe because the kernel subsystems that call dns_query pass NULL. Signed-off-by: Arnd Bergmann Signed-off-by: Aya Mahfouz

[PATCH v2] staging: lustre: ptlrpc: constify ptlrpc_sec_cops structs

Constifies ptlrpc_sec_cops structures in the lustre driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- Changelog: v2: added const to a ptlrpc_sec_cops structure in the

[PATCH] s390: char: constify hmcdrv_ftp_ops structs

Constifies hmcdrv_ftp_ops structures in s390's char driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/s390/char/hmcdrv_ftp.c | 6 +++--- 1 file changed, 3 insertions(

[PATCH] staging: gdm724x: constify tty_port_operations structs

Constifies tty_port_operations structure in the tty code of the gdm724x driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/staging/gdm724x/gdm_tty.c | 2 +- 1 file changed, 1

[PATCH] tty: serial: constify sunhv_ops structs

Constifies sunhv_ops structures in tty's serial driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/serial/sunhv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

[PATCH] tty: serial: constify uartlite_reg_ops structs

Constifies uartlite_reg_ops structures in tty's serial port driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/serial/uartlite.c | 8 1 file changed, 4 inser

[PATCH] tty: serial: constify psc_ops structs

Constifies psc_ops structures in tty's serial port driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/serial/mpc52xx_uart.c | 8 1 file changed, 4 insertions(

[PATCH] char: constify tty_port_operations structs

Constifies tty_port_operations structure in the char driver since it is not modified after its initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/char/ttyprintk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] tty: constify tty_port_operations structs

Constifies tty_port_operations structures in the tty driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/tty/goldfish.c | 2 +- drivers/tty/mxser.c| 2 +- 2 files changed, 2

Re: [PATCH] tty: serial: constify uartlite_reg_ops structs

On Tue, Dec 15, 2015 at 01:42:05AM +0200, Aya Mahfouz wrote: > Constifies uartlite_reg_ops structures in tty's > serial port driver since they are not modified > after their initialization. > > Detected and found using Coccinelle. > > Suggested-by: Julia Lawall &g

[PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

. replace memset by eth_broadcast_addr if the second argument is the broadcast address (0xff). eth_broadcast_addr is a wrapper function for memset that sets the passed array the broadcast address. The size of the address has to be ETH_ALEN. Cc: Julia Lawall Signed-off-by: Aya Mahfouz --- v2

Re: [PATCH] scripts: checkpatch.pl: add 2 new checks on memset calls

On Mon, Feb 23, 2015 at 07:06:27PM -0800, Joe Perches wrote: > On Mon, 2015-02-23 at 21:18 +0200, Aya Mahfouz wrote: > > This patch adds 2 new checks on memset calls in the file > > checkpatch.pl as follows: > > > > replace memset by eth_zero_addr if the second argument

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: > > This patch adds 2 new checks on memset calls in the file > > checkpatch.pl as follows: > > > > replace memset by eth_zero_addr if the second argument

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: > > On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: > > > On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: > > > > This patch adds 2

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

On Tue, Feb 24, 2015 at 09:45:43PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 06:59 +0200, Aya Mahfouz wrote: > > On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: > > > On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: > > > > On Tue, Feb 24,

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: > On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: > > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > > > On 01/28/2015 09:53 AM, Heba Aamer wrote: > > > >This patch fix

[PATCH] scripts: checkpatch.pl: add 2 new checks on memset calls

. replace memset by eth_broadcast_addr if the second argument is the broadcast address (0xff). eth_broadcast_addr is a wrapper function for memset that sets the passed array the broadcast address. The size of the address has to be ETH_ALEN. Cc: Julia Lawall Signed-off-by: Aya Mahfouz --- scripts

Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls

On Tue, Feb 24, 2015 at 10:20:24PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 08:08 +0200, Aya Mahfouz wrote: > > What is the next step? > > Ideally, you understanding why the suggested patch > is an improvement over the patch you proposed. > > Beyond that, subm

[PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset

$stat has been restricted to handle memset function calls of the form: [ =]* memset(, , ) Cc: Julia Lawall Signed-off-by: Aya Mahfouz Signed-off-by: Joe Perches --- v2: adjusted all checks on memset calls to be in one body v3: adjusted all regular expressions per Joe Perches suggestions. Added a

Re: [PATCH v3] scripts: checkpatch.pl: add 2 new checks on memset

On Sun, Mar 01, 2015 at 02:13:21PM -0800, Joe Perches wrote: > On Sun, 2015-03-01 at 23:43 +0200, Aya Mahfouz wrote: > > calls > > Reply-To: > > > > Add 2 new checks on memset calls in the file checkpatch.pl as follows: > > Hi again Aya > > The initia

[PATCH V4] checkpatch: prefer eth__addr over memset(,,ETH_ALEN)

restricted to handle memset function calls of the form: [ =]* memset(, , ) Cc: Julia Lawall Cc: Andrew Morton Acked-by: Joe Perches Signed-off-by: Aya Mahfouz [j...@perches.com: handled all regular expressions] Portions-by: Joe Perches --- v2: adjusted all checks on memset calls to be in one body v3

[PATCH] staging: lustre: ptlrpc: constify ptlrpc_sec_cops structs

Constifies ptlrpc_sec_cops structures in the lustre driver since they are not modified after their initialization. Detected and found using Coccinelle. Suggested-by: Julia Lawall Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +- drivers/staging/lustre

Re: [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote: > On Oct 17, 2016, at 15:46, Aya Mahfouz wrote: > > > > class_devno_max is an inline function that returns > > MAX_OBD_DEVICES. Replace all calls to the function > > by MAX_OBD_DEVICES. > > Thanks

[PATCH] staging: lustre: remove unused identifier OBD_INIT_CHECK

OBD_INIT_CHECK was previously used by a conditional group. This is no longer the case so it can be removed. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b

[PATCH 0/2] staging: lustre: replace and remove class_devno_max

class_devno_max is an inline function that is written with the sole purpose of returning the value of MAX_OBD_DEVICES. Since no computations are made by the class_devno_max, replace it with MAX_OBD_DEVICES. Aya Mahfouz (2): staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

[PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

class_devno_max is an inline function that returns MAX_OBD_DEVICES. Replace all calls to the function by MAX_OBD_DEVICES. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++--- drivers/staging/lustre/lustre/obdclass/genops.c| 22

[PATCH 2/2] staging: lustre: remove class_devno_max

class_devno_max is an inline function that is not used anymore. Hence, it is removed. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/include/obd_class.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging