Re: [RFC v2 0/6] Managing cluser-level c-states with generic power domains

2015-10-14 Thread Axel Haslam
> @Axel: any plans to repost your series now that we have a little more > momentum here? > sure, no problem, ill rebase adding Marc's patch for the debugfs file and re-post them. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

Re: [PATCH v9 1/6] PM / Domains: prepare for multiple states

2015-10-19 Thread Axel Haslam
Hi Lina, On Mon, Oct 19, 2015 at 6:35 PM, Lina Iyer wrote: > Hi Axel, > > Thanks for rebasing. > > I ran into a compilation issue on ARM64 with defconfig. > > On Mon, Oct 19 2015 at 08:52 -0600, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >&g

Re: [PATCH v10 1/6] PM / Domains: prepare for multiple states

2015-10-27 Thread Axel Haslam
Hi Ulf, > > Hi Axel, > > Apologize for the delay in providing feedback. > Thanks for the review! >> --- >> arch/arm/mach-exynos/pm_domains.c | 2 +- >> arch/arm/mach-imx/gpc.c | 2 +- >> arch/arm/mach-s3c64xx/pm.c| 4 ++-- >> arch/arm/mach-shmobile/pm-rmobile.c

Re: [PATCH v10 2/6] PM / Domains: core changes for multiple states

2015-11-10 Thread Axel Haslam
Hi Zhaoyang, @@ -576,6 +584,8 @@ static void pm_genpd_sync_poweroff(struct generic_pm_domain *genpd, || atomic_read(&genpd->sd_count) > 0) return; + /* Choose the deepest state when suspending */ + genpd->state_idx = genpd->state

Re: [PATCH v10 3/6] PM / Domains: make governor select deepest state

2015-11-10 Thread Axel Haslam
Hi Zhaoyang, @@ -209,14 +186,52 @@ static bool default_power_down_ok(struct dev_pm_domain *pd) * The difference between the computed minimum subdomain or device off * time and the time needed to turn the domain on is the maximum * theoretical time this domain can

Re: [PATCH 0/2] ARM: davinvi: da850 add ohci DT nodes

2016-11-22 Thread Axel Haslam
On Tue, Nov 22, 2016 at 10:33 AM, Sekhar Nori wrote: > On Monday 21 November 2016 10:29 PM, Axel Haslam wrote: >> This adds the DT node for the ohci controller and >> enables it for the omapl138-lckd platform. >> >> DEPENDENCIES: >> >> 1. [PATCH v6 0/5] U

Re: [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio

2016-11-22 Thread Axel Haslam
On Tue, Nov 22, 2016 at 10:53 AM, Sekhar Nori wrote: > On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: >> The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 >> >> Signed-off-by: Axel Haslam > > The LCDK and HawkBoard are different boards. The

Re: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect

2016-11-22 Thread Axel Haslam
On Tue, Nov 22, 2016 at 11:26 AM, Sekhar Nori wrote: > On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: >> Currently the mmc driver is polling the gpio to know if the >> card was removed. >> >> By using a gpio descriptor instead of the platform callbacks, th

Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-22 Thread Axel Haslam
On Mon, Nov 21, 2016 at 5:29 PM, David Lechner wrote: > On 11/21/2016 04:22 AM, Axel Haslam wrote: >> >> Hi David, >> >> Thanks for the review, >> > > You're welcome. > >>>> >>>> @@ -160,15 +212,41 @@ s

Re: [RESEND PATCH 2/3] ARM: davinci: hawk: Remove vbus and over current gpios

2016-11-22 Thread Axel Haslam
Hi Sekhar On Tue, Nov 22, 2016 at 11:37 AM, Sekhar Nori wrote: > On Monday 21 November 2016 10:23 PM, Axel Haslam wrote: >> The hawk board VBUS is fixed to a 5v source, and the over >> current pin is actually not connected to the SoC. >> >> Do not reseve these gpi

Re: [PATCH v3 0/2] regulator: handling of error conditions for usb drivers

2016-11-22 Thread Axel Haslam
Hi Mark, On Fri, Nov 4, 2016 at 10:35 PM, Axel Haslam wrote: > Some usb drivers rely on external power switches/regulators > to for the port vbus. Some of these drivers are using > a plain gpio for the enable pin and also the over current > indicator pin. > > To make these dr

Re: [PATCH v6 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-22 Thread Axel Haslam
On Tue, Nov 22, 2016 at 9:37 PM, David Lechner wrote: > On 11/21/2016 10:30 AM, Axel Haslam wrote: >> >> Using a regulator to handle VBUS will eliminate the need for >> platform data and callbacks, and make the driver more generic >> allowing different types o

[PATCHv7 5/5] USB: ohci: da8xx: Allow probing from DT

2016-11-23 Thread Axel Haslam
This adds the compatible string to the ohci driver to be able to probe from DT Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 07366ae..1818206 100644

[PATCHv7 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-23 Thread Axel Haslam
ble get_power -> regulator_is_enabled get_oci -> regulator_get_error_flags ocic_notify -> regulator event notification Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 96 +-- 1 file changed, 93 insertions(+), 3 deleti

[PATCHv7 0/5] SB: ohci-da8xx: Add device tree support

2016-11-23 Thread Axel Haslam
framework * Fixed regulator is able to register for and over current irq * Added patch by Alexandre to remove build warnings * Moved global variables into private hcd structure. Axel Haslam (5): USB: ohci: da8xx: use ohci priv data instead of globals USB: ohci: da8xx: Add wrappers for platfo

[PATCHv7 2/5] USB: ohci: da8xx: Add wrappers for platform callbacks

2016-11-23 Thread Axel Haslam
place to for the regulator API to coexist with the platform callbacks before all users are converted. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 125 ++ 1 file changed, 102 insertions(+), 23 deletions(-) diff --git a/drivers/usb/host/ohci

[PATCHv7 4/5] USB: ohci: da8xx: Add devicetree bindings

2016-11-23 Thread Axel Haslam
This patch documents the device tree bindings required for the ohci controller found in TI da8xx family of SoC's Cc: robh...@kernel.org Cc: mark.rutl...@arm.com Cc: devicet...@vger.kernel.org Acked-by: Rob Herring Signed-off-by: Axel Haslam --- .../devicetree/bindings/usb/ohci-da8x

[PATCHv7 1/5] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-23 Thread Axel Haslam
Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 73 +-- 1 file changed, 43 insertions(+), 30 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index bd6cf3c..cd75677 100644 --- a/drivers/usb/host/ohci-da8xx.c

[PATCH] USB: ohci: da8xx: Balance ochi_disable with ohci_enable in resume.

2016-11-23 Thread Axel Haslam
ohci_suspend and flags the HW as "accessible" again, resume completes successfully and usb is working after a suspend/resume sequence. While we are here, remove setting device power_state, as this is no longer needed and scheduled for removal. Signed-off-by: Axel Haslam --- drivers/usb/host/oh

[PATCHv2] USB: ohci: da8xx: Resume the entire host controller

2016-11-24 Thread Axel Haslam
, remove setting device power_state, as this is no longer needed and scheduled for removal Acked-by: Alan Stern Signed-off-by: Axel Haslam --- Changes v1->v2 * reword commit message (Alan Stern) drivers/usb/host/ohci-da8xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

[PATCH v2 0/3] ARM: davinci: use gpio descriptors for mmc pins

2016-11-24 Thread Axel Haslam
evm and da830-evm *keep hack board pins as they are not compatible with lcdk (Sekhar) Dependency: This patch depends on a mmc driver patch currently in linux-next. MMC: davinci: fix card detect and write protect https://lkml.org/lkml/2016/11/15/592 Axel Haslam (3): ARM: davinci: hawk: use g

[PATCH v2 3/3] ARM: davinci: da830-evm: use gpio descriptor for mmc pins

2016-11-24 Thread Axel Haslam
, and polling is no longer needed. Also, a dependency on platform callbacks is removed for this board. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 41 + 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/arch/arm/mach-da

[PATCH v2 2/3] ARM: davinci: da850-evm: use gpio descriptor for mmc pins

2016-11-24 Thread Axel Haslam
, and polling is no longer needed. Also, a dependency on platform callbacks is removed for this board. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da850-evm.c | 35 ++--- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/arch/arm/mach-da

[PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor for mmc pins

2016-11-24 Thread Axel Haslam
, and polling is no longer needed. Also, a dependency on platform callbacks is removed for this board. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-omapl138-hawk.c | 42 - 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/arch/arm/mach-da

[PATCH v2 2/3] ARM: davinci: hawk: Remove vbus and over current gpios

2016-11-24 Thread Axel Haslam
The hawk board VBUS is fixed to a 5v source, and the over current pin is actually not connected to the SoC. Do not reseve these gpios for OHCI as they are not related to usb. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-omapl138-hawk.c | 99 ++--- 1 file

[PATCH v2 1/3] ARM: davinci: da830: Handle vbus with a regulator

2016-11-24 Thread Axel Haslam
The usb driver can now take a regulator instead of the platform callbacks for vbus handling. Lets use a regulator so we can remove the callbacks in a later patch. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 109 1 file changed, 39

[PATCH v2 3/3] ARM: davinci: remove ohci platform usage

2016-11-24 Thread Axel Haslam
As all users of ohci platform data have been converted to use a regulator, we dont need to pass platform data to register the ohci device anymore. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 2 +- arch/arm/mach-davinci/board-omapl138-hawk.c | 2 +- arch/arm/mach

[PATCH v2 0/3] ARM: davinci: OHCI: Use a regulator instead of callbacks

2016-11-24 Thread Axel Haslam
hci-da8xx: Add device tree support https://lkml.org/lkml/2016/11/23/557 2. [PATCH v3 0/2] regulator: handling of error conditions for usb drivers https://lkml.org/lkml/2016/11/4/465 Axel Haslam (3): ARM: davinci: da830: Handle vbus with a regulator ARM: davinci: hawk: Remove vbus and over curr

Re: [PATCH 1/2] ARM: dts: da850: Add usb device node

2017-01-06 Thread Axel Haslam
On Thu, Jan 5, 2017 at 11:49 PM, David Lechner wrote: > Hi Sekhar, > > On 11/21/2016 10:59 AM, Axel Haslam wrote: >> >> Add the usb1 device node for the da850 soc. >> This will allow boards to use the usb1 port >> when booting through DT. >> >> Signed-

[PATCH v2 0/2] ARM: davinvi: da850 add ohci DT nodes

2017-01-06 Thread Axel Haslam
on merged ohci patches. Axel Haslam (2): ARM: dts: da850: Add usb device node ARM: dts: da850-lcdk: Enable ohci for omapl138 lcdk arch/arm/boot/dts/da850-lcdk.dts | 4 arch/arm/boot/dts/da850.dtsi | 8 2 files changed, 12 insertions(+) -- 2.9.3

[PATCH v2 1/2] ARM: dts: da850: Add usb device node

2017-01-06 Thread Axel Haslam
Add the usb1 device node for the da850 soc. This will allow boards to use the usb1 port when booting through DT. Signed-off-by: Axel Haslam --- arch/arm/boot/dts/da850.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi

[PATCH v2 2/2] ARM: dts: da850-lcdk: Enable ohci for omapl138 lcdk

2017-01-06 Thread Axel Haslam
Enable the usb1 controller (ohci) and phy for the lcdk board Signed-off-by: Axel Haslam --- arch/arm/boot/dts/da850-lcdk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts index 03f9bfd..94f6ea9 100644 --- a/arch/arm

Re: [PATCH] ARM: davinci: register the usb20_phy clock on the DT file

2016-10-26 Thread Axel Haslam
On Wed, Oct 26, 2016 at 10:03 PM, David Lechner wrote: > On 10/26/2016 03:01 PM, David Lechner wrote: >> >> On 10/26/2016 02:49 PM, ahas...@baylibre.com wrote: >>> >>> From: Axel Haslam >>> >>> The usb20_phy clock needs to be registered for

[PATCH v2] USB: OHCI: make ohci-da8xx a separate driver

2016-10-27 Thread Axel Haslam
, fixed minor comments] Signed-off-by: Axel Haslam --- This was a previews patch submited by Manjunath [1] that was never taken in because of an undefined symbol when loading as a module. That symbol is not present anymore so we can safly build the driver as a module. I rebased, fixing the minor

Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver

2016-10-27 Thread Axel Haslam
On Thu, Oct 27, 2016 at 2:58 AM, David Lechner wrote: > On 10/26/2016 04:08 PM, ahas...@baylibre.com wrote: > >> +module_exit(ohci_da8xx_exit); >> +MODULE_DESCRIPTION(DRIVER_DESC); >> +MODULE_LICENSE("GPL"); >> MODULE_ALIAS("platform:ohci"); > > > The "ohci" in MODULE_ALIAS() should also be repla

Re: [RFC 1/3] regulator: core: Add over current changed event

2016-10-28 Thread Axel Haslam
Hi Mark, On Fri, Oct 28, 2016 at 8:22 PM, Mark Brown wrote: > On Wed, Oct 26, 2016 at 09:00:52PM +0200, ahas...@baylibre.com wrote: >> From: Axel Haslam >> >> Regulator consumers may be interested to know when the >> over current condition is over. >> >>

Re: [RFC 1/3] regulator: core: Add over current changed event

2016-10-29 Thread Axel Haslam
Hi Mark, On Fri, Oct 28, 2016 at 9:41 PM, Axel Haslam wrote: > Hi Mark, > > On Fri, Oct 28, 2016 at 8:22 PM, Mark Brown wrote: >> On Wed, Oct 26, 2016 at 09:00:52PM +0200, ahas...@baylibre.com wrote: >>> From: Axel Haslam >>> >>> Regulator consumers m

[PATCH v3 03/10] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-07 Thread Axel Haslam
-> regulator_enable/regulator_disable get_power -> regulator_is_enabled get_oci -> regulator_get_error_flags ocic_notify -> regulator event notification Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 97 ++- 1 file

[PATCH v3 01/10] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-07 Thread Axel Haslam
Instead of global variables, use the extra_priv_size of the ohci driver. We cannot yet move the ocic mask because this is used on the interrupt handler which is registerded through platform data and does not have an hcd pointer. This will be moved on a later patch. Signed-off-by: Axel Haslam

[PATCH v3 07/10] USB: ohci: da8xx: use a flag instead of mask for ocic

2016-11-07 Thread Axel Haslam
Now that the platform callback is removed, we can move the over current indictor changed flag to the private data structure. Since the driver only handles a single port, there is no need for ocic to be a mask, we can use a simple flag instead. Signed-off-by: Axel Haslam --- drivers/usb/host

[PATCH v3 08/10] USB: ohci: da8xx: Add devicetree bindings

2016-11-07 Thread Axel Haslam
This patch documents the device tree bindings required for the ohci controller found in TI da8xx family of SoC's Cc: devicet...@vger.kernel.org Signed-off-by: Axel Haslam --- .../devicetree/bindings/usb/ohci-da8xx.txt | 39 ++ 1 file changed, 39 insertions(+) c

[PATCH v3 06/10] USB: ohci: da8xx: Remove ohci platform callbacks

2016-11-07 Thread Axel Haslam
Now that all ohci users are are using a regulator, we can remove the platform callbacks and data. potpgt is no longer necessary as a power on delay time can be specified for the regulator itself. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 2 +- arch/arm/mach

[PATCH v3 09/10] USB: ohci: da8xx: Allow probing from DT

2016-11-07 Thread Axel Haslam
This adds the compatible string to the ohci driver to be able to probe from DT Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 83b182e..bbfe342 100644

[PATCH v3 05/10] ARM: davinci: hawk: Remove vbus and over current gpios

2016-11-07 Thread Axel Haslam
The hawk board VBUS is fixed to a 5v source, and the over current pin is actually not connected to the SoC. Do not reseve these gpios for OHCI as they are not related to usb. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-omapl138-hawk.c | 99 ++--- 1 file

[PATCH v3 04/10] ARM: davinci: da830: Handle vbus with a regulator

2016-11-07 Thread Axel Haslam
The usb driver can now take a regulator instead of the platform callbacks for vbus handling. Lets use a regulator so we can remove the callbacks in a later patch. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 108 +++- 1 file changed, 38

[PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-07 Thread Axel Haslam
This adds the ohci device node for the da850 soc. It also enables it for the omapl138 hawk board. Signed-off-by: Axel Haslam --- arch/arm/boot/dts/da850-lcdk.dts | 8 arch/arm/boot/dts/da850.dtsi | 8 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/da850

[PATCH v3 02/10] USB: ohci: da8xx: Prepare to remove platform callbacks

2016-11-07 Thread Axel Haslam
following patch. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 125 ++ 1 file changed, 102 insertions(+), 23 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 0442c64..9ed43c7 100644 --- a/drivers

[PATCH v3 00/10] Add DT support for ohci-da8xx

2016-11-07 Thread Axel Haslam
] http://www.spinics.net/lists/linux-gpio/msg17710.html [4] https://github.com/axelhaslamx/linux-axel/commits/ohci-da8xx-dt-v3 Axel Haslam (10): USB: ohci: da8xx: use ohci priv data instead of globals USB: ohci: da8xx: Prepare to remove platform callbacks USB: ohci: da8xx: Allow a regulator to handle VBUS

Re: [PATCH v3 00/10] Add DT support for ohci-da8xx

2016-11-08 Thread Axel Haslam
Hi, On Mon, Nov 7, 2016 at 9:39 PM, Axel Haslam wrote: > The purpose of this patch series is to add DT support for the davinci > ohci driver. > To make it easier to review. I will split the arch/arm and driver patches into separate series. Regards Axel > To be able to use de

[PATCH 1/3] USB: ohci: da8xx: Add devicetree bindings

2016-11-08 Thread Axel Haslam
This patch documents the device tree bindings required for the ohci controller found in TI da8xx family of SoC's Cc: devicet...@vger.kernel.org Signed-off-by: Axel Haslam --- .../devicetree/bindings/usb/ohci-da8xx.txt | 39 ++ 1 file changed, 39 insertions(+) c

[PATCH v4 0/3] [PART 1/4] USB: ohci-da8xx: Allow a regulator for VBUS and over current

2016-11-08 Thread Axel Haslam
ing Gpios (David Lechner) * Add an over current mode to regulator framework * Fixed regulator is able to register for and over current irq * Added patch by Alexandre to remove build warnings * Moved global variables into private hcd structure. Axel Haslam (3): USB: ohci: da8xx: use ohci priv dat

[PATCH 0/3] [PART 2/4] ARM: davinci: OHCI: Use a regulator instead of callbacks

2016-11-08 Thread Axel Haslam
/axelhaslamx/linux-axel/commits/ohci-da8xx-dt-v4 Axel Haslam (3): ARM: davinci: da830: Handle vbus with a regulator ARM: davinci: hawk: Remove vbus and over current gpios ARM: davinci: remove ohci platform usage arch/arm/mach-davinci/board-da830-evm.c | 108 ++-- arch/arm

[PATCH v4 3/3] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-08 Thread Axel Haslam
-> regulator_enable/regulator_disable get_power -> regulator_is_enabled get_oci -> regulator_get_error_flags ocic_notify -> regulator event notification Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 97 ++- 1 file

[PATCH v4 2/3] USB: ohci: da8xx: Prepare to remove platform callbacks

2016-11-08 Thread Axel Haslam
following patch. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 125 ++ 1 file changed, 102 insertions(+), 23 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 0442c64..9ed43c7 100644 --- a/drivers

[PATCH 0/3] [PART 4/4] USB: ohci-da8xx: Add DT support

2016-11-08 Thread Axel Haslam
://github.com/axelhaslamx/linux-axel/commits/ohci-da8xx-dt-v4 Axel Haslam (3): USB: ohci: da8xx: Add devicetree bindings USB: ohci: da8xx: Allow probing from DT ARM: dts: da850: add usb device node .../devicetree/bindings/usb/ohci-da8xx.txt | 39 ++ arch/arm/boot/dts

[PATCH 2/3] USB: ohci: da8xx: Allow probing from DT

2016-11-08 Thread Axel Haslam
This adds the compatible string to the ohci driver to be able to probe from DT Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 83b182e..bbfe342 100644

[PATCH v4 1/3] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-08 Thread Axel Haslam
Instead of global variables, use the extra_priv_size of the ohci driver. We cannot yet move the ocic mask because this is used on the interrupt handler which is registerded through platform data and does not have an hcd pointer. This will be moved on a later patch. Signed-off-by: Axel Haslam

[PATCH 2/3] ARM: davinci: hawk: Remove vbus and over current gpios

2016-11-08 Thread Axel Haslam
The hawk board VBUS is fixed to a 5v source, and the over current pin is actually not connected to the SoC. Do not reseve these gpios for OHCI as they are not related to usb. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-omapl138-hawk.c | 99 ++--- 1 file

[PATCH 1/3] ARM: davinci: da830: Handle vbus with a regulator

2016-11-08 Thread Axel Haslam
The usb driver can now take a regulator instead of the platform callbacks for vbus handling. Lets use a regulator so we can remove the callbacks in a later patch. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 108 +++- 1 file changed, 38

[PATCH 3/3] ARM: davinci: remove ohci platform usage

2016-11-08 Thread Axel Haslam
As all users of ohci platform data have been converted to use a regulator, we dont need to pass platform data to register the ohci device anymore. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/board-da830-evm.c | 2 +- arch/arm/mach-davinci/board-omapl138-hawk.c | 2 +- arch/arm/mach

[PATCH 0/2] [PART 3/4] USB: ohci-da8xx: Remove platform callbacks

2016-11-08 Thread Axel Haslam
dependencies can be found here: https://github.com/axelhaslamx/linux-axel/commits/ohci-da8xx-dt-v4 Axel Haslam (2): USB: ohci: da8xx: Remove ohci platform callbacks USB: ohci: da8xx: use a flag instead of mask for ocic drivers/usb/host/ohci-da8xx.c | 101

[PATCH 1/2] USB: ohci: da8xx: Remove ohci platform callbacks

2016-11-08 Thread Axel Haslam
Now that all ohci users are are using a regulator, we can remove the platform callbacks and data. potpgt is no longer necessary as a power on delay time can be specified for the regulator itself. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 84

[PATCH 2/2] USB: ohci: da8xx: use a flag instead of mask for ocic

2016-11-08 Thread Axel Haslam
Now that the platform callback is removed, we can move the over current indictor changed flag to the private data structure. Since the driver only handles a single port, there is no need for ocic to be a mask, we can use a simple flag instead. Signed-off-by: Axel Haslam --- drivers/usb/host

[PATCH 3/3] ARM: dts: da850: add usb device node

2016-11-08 Thread Axel Haslam
This adds the ohci device node for the da850 soc. It also enables it for the omapl138 hawk board. Signed-off-by: Axel Haslam --- arch/arm/boot/dts/da850-lcdk.dts | 8 arch/arm/boot/dts/da850.dtsi | 8 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/da850

[PATCH] pinctrl: single: check for any error when getting rows

2016-11-09 Thread Axel Haslam
pinctrl_count_index_with_args returns -ENOENT not -EINVAL. The return check would pass, and we would try to kzalloc with a negative error size throwing a warning. Instead of checking for -EINVAL specifically, lets check for any error and avoid negative size allocations. Signed-off-by: Axel

[PATCH v2 1/2] pinctrl: single: check for any error when getting rows

2016-11-09 Thread Axel Haslam
pinctrl_count_index_with_args returns -ENOENT not -EINVAL. The return check would pass, and we would try to kzalloc with a negative error size throwing a warning. Instead of checking for -EINVAL specifically, lets check for any error and avoid negative size allocations. Signed-off-by: Axel

[PATCH v2 0/2] pinctrl: single: fixes for davinci

2016-11-09 Thread Axel Haslam
) [] (pinctrl_dt_to_map) from [] (pinctrl_get+0xe8/0x484) [snip] This series fixes this error. Changes form v1 -> v2 * Add an error message, and correct also other places where the issue is seen * Add patch to parse for bits instead of pins Axel Haslam (2): pinctrl: single: check for any error when gett

[PATCH v2 2/2] pinctrl: single: search for the bits property when parsing bits

2016-11-09 Thread Axel Haslam
The pcs_parse_bits_in_pinctrl_entry function should search for the "pinctrl-single,bits" and not "pinctrl-single,pins" Signed-off-by: Axel Haslam --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctr

Re: [PATCH/RFT 07/12] USB: ohci-da8xx: Request gpios and handle interrupt in the driver

2016-10-12 Thread Axel Haslam
Hi David On Tue, Oct 11, 2016 at 1:18 AM, David Lechner wrote: > On 10/07/2016 11:42 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >> Currently requesting the vbus and overcurrent gpio is handled on >> the board specific file. But this does not p

[PATCH v5 4/5] USB: ohci: da8xx: Add devicetree bindings

2016-11-14 Thread Axel Haslam
This patch documents the device tree bindings required for the ohci controller found in TI da8xx family of SoC's Cc: robh...@kernel.org Cc: mark.rutl...@arm.com Cc: devicet...@vger.kernel.org Signed-off-by: Axel Haslam --- .../devicetree/bindings/usb/ohci-da8xx.txt

[PATCH v5 1/5] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-14 Thread Axel Haslam
Instead of global variables, use the extra_priv_size of the ohci driver. We cannot yet move the ocic mask because this is used on the interrupt handler which is registerded through platform data and does not have an hcd pointer. This will be moved on a later patch. Signed-off-by: Axel Haslam

[PATCH v5 5/5] USB: ohci: da8xx: Allow probing from DT

2016-11-14 Thread Axel Haslam
This adds the compatible string to the ohci driver to be able to probe from DT Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 42eaeb9..b761b2b 100644

[PATCH v5 2/5] USB: ohci: da8xx: Add wrappers for platform callbacks

2016-11-14 Thread Axel Haslam
In preparation to use a regulator instead of platform callbacks, move the platform callbacks into separate functions. This provides a well defined place to for the regulator API to coexist with the callbacks until all users are converted, and the callbacks can be removed. Signed-off-by: Axel

[PATCH v5 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-14 Thread Axel Haslam
ble get_power -> regulator_is_enabled get_oci -> regulator_get_error_flags ocic_notify -> regulator event notification Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 95 ++- 1 file changed, 93 insertions(+), 2 deleti

[PATCH v5 0/5] USB: ohci-da8xx: Add device tree support

2016-11-14 Thread Axel Haslam
work * Fixed regulator is able to register for and over current irq * Added patch by Alexandre to remove build warnings * Moved global variables into private hcd structure. Axel Haslam (5): USB: ohci: da8xx: use ohci priv data instead of globals USB: ohci: da8xx: Add wrappers for platform callbacks

[PATCH 1/2] MMC: davinci: use mmc_of_parse to parse common mmc configuration

2016-11-15 Thread Axel Haslam
, which will take care of registering the gpios for us, lets use it so that we don't need to poll, and parse the same properties. Signed-off-by: Axel Haslam --- drivers/mmc/host/davinci_mmc.c | 119 +++-- 1 file changed, 55 insertions(+), 64 deletions(-)

[PATCH 2/2] MMC: davinci: request gpios using gpio descriptors

2016-11-15 Thread Axel Haslam
backs. Signed-off-by: Axel Haslam --- drivers/mmc/host/davinci_mmc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 619e50e..36b5af8 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc

[PATCH 0/2] MMC: davinci: fix card detect and write protect

2016-11-15 Thread Axel Haslam
additional patches to platform data and dts files. Axel Haslam (2): MMC: davinci: use mmc_of_parse to parse common mmc configuration MMC: davinci: request gpios using gpio descriptors drivers/mmc/host/davinci_mmc.c | 130 + 1 file changed, 66 insertions

gpiolib-of: Cannot request gpio with multiple chips

2016-10-20 Thread Axel Haslam
Hi Linus, I have recently started testing a omap-lcdk board which uses the davinci gpio driver, and im running into an issue when i try to request a gpio larger than 31, which i think might be a regression of gpiolib-of. The davinci gpio driver, creates several chips, and relies in a single DT no

Re: [PATCH v3 00/10] Add DT support for ohci-da8xx

2016-11-10 Thread Axel Haslam
On Thu, Nov 10, 2016 at 1:02 PM, Greg KH wrote: > On Tue, Nov 08, 2016 at 05:37:41PM +0100, Axel Haslam wrote: >> Hi, >> >> On Mon, Nov 7, 2016 at 9:39 PM, Axel Haslam wrote: >> > The purpose of this patch series is to add DT support for the davinci >> > oh

Re: [RFC 1/3] regulator: core: Add over current changed event

2016-10-30 Thread Axel Haslam
Hi Mark, On Sat, Oct 29, 2016 at 8:40 PM, Mark Brown wrote: > On Fri, Oct 28, 2016 at 09:41:44PM +0200, Axel Haslam wrote: > >> i think today each time an event occurs a notification is sent with the >> corresponding flag(s) set. > > Right, so I think the problem here is

Re: [RFC 1/3] regulator: core: Add over current changed event

2016-11-01 Thread Axel Haslam
Hi Mark, On Mon, Oct 31, 2016 at 5:22 PM, Mark Brown wrote: > On Sun, Oct 30, 2016 at 01:02:21PM +0100, Axel Haslam wrote: > >> The event REGULATOR_EVENT_OVER_CURRENT allready exists. >> what is missing and what i would need form the usb driver, is a way for >> the c

[PATCH 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

2016-11-02 Thread Axel Haslam
To be consistent on the usb driver for the davinci platform follow the example of musb, and add the "-da8xx" postfix to the driver name. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/oh

[PATCH 0/3] fix ohci phy name

2016-11-02 Thread Axel Haslam
name the driver to "ohci-da8xx" to be consistent with davinci musb and other usb drivers. Axel Haslam (3): ARM: davinci: da8xx: Fix ohci driver name phy: da8xx-usb: rename the ohci device to ohci-da8xx usb: ohci-da8xx: rename driver to ohci-da8xx arch/arm/mach-davinci/da830.c

[PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-02 Thread Axel Haslam
There is only one ohci on the da8xx series of chips, so remove the ".0" when creating the phy. Also add the "-da8xx" postfix to be consistent across davinci usb drivers. Signed-off-by: Axel Haslam --- drivers/phy/phy-da8xx-usb.c | 5 +++-- 1 file changed, 3 insertions(+),

[PATCH 1/3] ARM: davinci: da8xx: Fix ohci driver name

2016-11-02 Thread Axel Haslam
the musb driver name. Signed-off-by: Axel Haslam --- arch/arm/mach-davinci/da830.c | 2 +- arch/arm/mach-davinci/da850.c | 2 +- arch/arm/mach-davinci/da8xx-dt.c | 2 +- arch/arm/mach-davinci/usb-da8xx.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/m

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Axel Haslam
Hi Mark, On Mon, Oct 24, 2016 at 7:43 PM, Mark Brown wrote: > On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: >> From: Axel Haslam >> >> Some regulator supplies have an over-current pin that is >> activated when the hw detects an over curr

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-24 Thread Axel Haslam
On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahas...@baylibre.com wrote: > >> + if (ret) { >> + pr_err("Failed to request irq: %d\n", ret); > > dev_err() > >> +++ b/include/linux/regulator/consumer.h >> @@ -74,6 +74,

Re: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 2:38 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Manjunath Goudar >> >> Separate the Davinci OHCI host controller driver from ohci-hcd >> host code so that it can be built as a separate driver module. >> This work is part of e

Re: [PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 2:48 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >> This adds the usb (ohci) device node for the da850 soc. >> Also it enables it for the lcdk board >> >> Signed-

Re: [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 2:53 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >> This adds the compatible string to the ohci driver >> to be able to probe from DT >> >> Signed-off-by: Axel Has

Re: [PATCH/RFT v2 12/17] USB: ochi-da8xx: Use a regulator for vbus/overcurrent

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 3:39 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >> Currently, the da8xx ohci driver uses a set of gpios and callbacks in >> board files to handle vbus and overcurrent irqs

Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-10-25 Thread Axel Haslam
will fail to probe, because the strncmp match in the syscon driver (syscon_match_pdevname) will fail. should i change the phy driver instead? Regards, Axel. >> Signed-off-by: Axel Haslam > > Thanks, > Sekhar >

Re: [PATCH/RFT v2 03/17] ARM: davinci: da8xx: Add USB PHY platform declaration

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 11:18 AM, Sekhar Nori wrote: > On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: >> +static struct platform_device da8xx_usb_phy = { >> + .name = "da8xx-usb-phy", >> + .id = 0, > > There is a single phy control in the system for b

Re: [PATCH/RFT v2 15/17] usb: host: ohci-da8xx: Add devicetree bindings documentation

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 3:02 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >> This patch documents the device tree bindings required for >> the ohci controller found in TI da8xx family of SoC&#

Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 3:12 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> > static const struct ohci_driver_overrides da8xx_overrides __initconst = >> > { >> - .reset

Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 4:53 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote: >> >> From: Axel Haslam >> >> While probing ochi phy with usb20 phy as a parent clock for usb11_phy, >> the usb20_phy clock enable would time out. This is

Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 12:28 PM, Sekhar Nori wrote: > On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: >> From: Axel Haslam >> >> The phy framework requests an optional "phy" regulator. If it does >> not find one, it returns -EPROBE_DEFER. In

Re: [PATCH/RFT v2 12/17] USB: ochi-da8xx: Use a regulator for vbus/overcurrent

2016-10-25 Thread Axel Haslam
On Tue, Oct 25, 2016 at 12:43 PM, Sekhar Nori wrote: > On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: >> From: Axel Haslam >> >> Currently, the da8xx ohci driver uses a set of gpios and callbacks in >> board files to handle vbus and overcurrent

Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

2016-10-25 Thread Axel Haslam
Hi Mark, On Mon, Oct 24, 2016 at 8:19 PM, Mark Brown wrote: > On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote: >> On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > >> > does it make sense to report this as a mode, we don't report other error >> &

  1   2   >