Re: [PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

2018-01-29 Thread Asutosh Das (asd)
On 1/30/2018 11:33 AM, Vivek Gautam wrote: Hi Asutosh, On 1/30/2018 10:11 AM, Asutosh Das wrote: From: Subhash Jadavani UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change

Re: [PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr

2018-05-16 Thread Asutosh Das (asd)
On 5/6/2018 3:44 PM, Alim Akhtar wrote: In the right behavior, setting the bit to '0' indicates clear and '1' indicates no change. If host controller handles this the other way, UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR can be used. Signed-off-by: Seungwon Jeon Signed-off-by: Alim Akhtar --- drivers/

Re: [PATCH v15 1/2] scsi: ufs: Enable power management for wlun

2021-04-07 Thread Asutosh Das (asd)
On 4/7/2021 3:21 AM, Adrian Hunter wrote: On 6/04/21 8:52 pm, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU (START_STOP_UNIT) to wlun during its runtime-suspend. During the

Re: [PATCH v3 5/5] scsi: ufs: Fix possible VCC power drain during runtime suspend

2020-05-19 Thread Asutosh Das (asd)
Hi Stanley, On 5/16/2020 10:46 AM, Stanley Chu wrote: The commit "scsi: ufs: Fix WriteBooster flush during runtime suspend" promises essential resource, i.e., for UFS devices doing WriteBooster buffer flush and Auto BKOPs. However if device finishes its job but not resumed for a very long time,

Re: [PATCH v7 7/8] scsi: ufs: Move dumps in IRQ handler to error handler

2020-07-29 Thread Asutosh Das (asd)
On 7/29/2020 6:02 AM, Can Guo wrote: Hi Asutosh, On 2020-07-29 02:06, Asutosh Das (asd) wrote: On 7/27/2020 10:00 PM, Can Guo wrote: Sometime dumps in IRQ handler are heavy enough to cause system stability issues, move them to error handler. Signed-off-by: Can Guo ---   drivers/scsi/ufs

Re: [PATCH v3 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling

2020-05-20 Thread Asutosh Das (asd)
Hi Pedro, On 11/11/2019 7:54 AM, Pedro Sousa wrote: Hi Asutosh, Please check comments. Sorry for missing out on this and thanks for your review. -Original Message- From: Asutosh Das Sent: Wednesday, October 23, 2019 5:49 PM To: c...@codeaurora.org; rna...@codeaurora.org; vinholika

Re: [PATCH v4 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling

2020-05-20 Thread Asutosh Das (asd)
Hi Avri, On 5/20/2020 2:33 PM, Avri Altman wrote: Hi, Qualcomm controller needs to be in hibern8 before scaling clocks. This change puts the controller in hibern8 state before scaling and brings it out after scaling of clocks. Signed-off-by: Asutosh Das I guess that your previous

Re: [PATCH v9 7/9] scsi: ufs: Move dumps in IRQ handler to error handler

2020-08-03 Thread Asutosh Das (asd)
On 8/3/2020 2:04 AM, Can Guo wrote: Sometime dumps in IRQ handler are heavy enough to cause system stability issues, move them to error handler and only print basic host regs here. Signed-off-by: Can Guo Reviewed-by: Bean Huo --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 23

Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

2020-12-27 Thread Asutosh Das (asd)
On 12/24/2020 5:47 AM, Stanley Chu wrote: Hi Avri, Bean, On Thu, 2020-12-24 at 13:01 +0100, Bean Huo wrote: On Thu, 2020-12-24 at 11:03 +, Avri Altman wrote: Do you see any substantial benefit of having fWriteBoosterBufferFlushEn disabled? 1. The definition of fWriteBoosterBufferFlushEn

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-24 Thread Asutosh Das (asd)
On 3/23/2021 12:19 PM, Adrian Hunter wrote: On 23/03/21 5:13 pm, Asutosh Das (asd) wrote: On 3/22/2021 11:12 PM, Adrian Hunter wrote: On 22/03/21 9:53 pm, Asutosh Das (asd) wrote: On 3/19/2021 10:47 AM, Adrian Hunter wrote: On 19/03/21 2:35 am, Asutosh Das wrote: During runtime-suspend of

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-18 Thread Asutosh Das (asd)
On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote: On Wed, Mar 17, 2021 at 7:37 AM Adrian Hunter wrote: On 16/03/21 10:35 pm, Asutosh Das (asd) wrote: On 3/16/2021 12:48 AM, Adrian Hunter wrote: On 16/03/21 12:22 am, Asutosh Das (asd) wrote: On 3/14/2021 1:11 AM, Adrian Hunter wrote: On 10/03

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-18 Thread Asutosh Das (asd)
On 3/18/2021 10:54 AM, Rafael J. Wysocki wrote: On Thu, Mar 18, 2021 at 6:33 PM Asutosh Das (asd) wrote: On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote: On Wed, Mar 17, 2021 at 7:37 AM Adrian Hunter wrote: On 16/03/21 10:35 pm, Asutosh Das (asd) wrote: On 3/16/2021 12:48 AM, Adrian Hunter

Re: [PATCH v11 1/2] scsi: ufs: Enable power management for wlun

2021-03-18 Thread Asutosh Das (asd)
On 3/15/2021 7:29 AM, Adrian Hunter wrote: On 12/03/21 12:19 am, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-18 Thread Asutosh Das (asd)
On 3/18/2021 12:16 PM, Adrian Hunter wrote: On 18/03/21 7:58 pm, Asutosh Das (asd) wrote: On 3/18/2021 10:54 AM, Rafael J. Wysocki wrote: On Thu, Mar 18, 2021 at 6:33 PM Asutosh Das (asd) wrote: On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote: On Wed, Mar 17, 2021 at 7:37 AM Adrian Hunter

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-19 Thread Asutosh Das (asd)
On 3/18/2021 8:12 PM, Bart Van Assche wrote: On 3/18/21 5:35 PM, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-23 Thread Asutosh Das (asd)
On 3/22/2021 11:12 PM, Adrian Hunter wrote: On 22/03/21 9:53 pm, Asutosh Das (asd) wrote: On 3/19/2021 10:47 AM, Adrian Hunter wrote: On 19/03/21 2:35 am, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them

Re: [PATCH V2 2/3] scsi: ufs: add a vops to configure VCC voltage level

2021-03-31 Thread Asutosh Das (asd)
On 3/21/2021 2:57 PM, Nitin Rawat wrote: Add a vops to configure VCC voltage VCC voltage level for platform supporting both ufs2.x and ufs 3.x devices. Suggested-by: Stanley Chu Suggested-by: Asutosh Das Suggested-by: Bjorn Andersson Signed-off-by: Nitin Rawat Signed-off-by: Veerabhadrarao

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-22 Thread Asutosh Das (asd)
On 3/19/2021 10:47 AM, Adrian Hunter wrote: On 19/03/21 2:35 am, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-15 Thread Asutosh Das (asd)
On 3/14/2021 1:11 AM, Adrian Hunter wrote: On 10/03/21 5:04 am, Asutosh Das (asd) wrote: On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote: On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote: On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki wrote: On Sat, Mar 6, 2021 at 5:17 PM Alan Stern wrote

Re: [PATCH v11 1/2] scsi: ufs: Enable power management for wlun

2021-03-15 Thread Asutosh Das (asd)
On 3/15/2021 7:29 AM, Adrian Hunter wrote: On 12/03/21 12:19 am, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-16 Thread Asutosh Das (asd)
On 3/16/2021 12:48 AM, Adrian Hunter wrote: On 16/03/21 12:22 am, Asutosh Das (asd) wrote: On 3/14/2021 1:11 AM, Adrian Hunter wrote: On 10/03/21 5:04 am, Asutosh Das (asd) wrote: On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote: On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote: On Mon, Mar 8, 2021

Re: [PATCH v18 1/2] scsi: ufs: Enable power management for wlun

2021-04-16 Thread Asutosh Das (asd)
On 4/15/2021 4:11 PM, Bart Van Assche wrote: On 4/14/21 11:58 AM, Asutosh Das wrote: [ ... ] Hi Bart, Thanks for the comments. I will fix the comments in the next version. The following code is executed before ufshcd_async_scan() is called: dev = hba->

Re: [PATCH v14 1/2] scsi: ufs: Enable power management for wlun

2021-03-31 Thread Asutosh Das (asd)
On 3/31/2021 11:19 AM, Adrian Hunter wrote: On 31/03/21 1:31 am, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU (START_STOP_UNIT) to wlun during its runtime-suspend. During the

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-19 Thread Asutosh Das (asd)
On 4/19/2021 11:37 AM, Adrian Hunter wrote: On 16/04/21 10:49 pm, Asutosh Das wrote: Co-developed-by: Can Guo Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- I came across 3 issues while testing. See comments below. Hi Adrian Thanks for the comments. @@ -5794,7 +5839,7

Re: [PATCH v17 1/2] scsi: ufs: Enable power management for wlun

2021-04-09 Thread Asutosh Das (asd)
On 4/9/2021 3:07 AM, Adrian Hunter wrote: On 9/04/21 5:27 am, Daejun Park wrote: Hi Asutosh Das, During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU (START_STOP_UNIT) to wlun during its runtime

Re: [PATCH v3 3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens

2020-11-17 Thread Asutosh Das (asd)
On 11/16/2020 11:04 PM, Can Guo wrote: When AH8 error happens, all the regs and states are dumped in err handler. Sometime we need to look into host regs right after AH8 error happens, which is before leaving the IRQ handler. Signed-off-by: Can Guo --- Reviewed-by: Asutosh Das drivers

Re: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage values

2020-11-30 Thread Asutosh Das (asd)
On 11/30/2020 1:16 AM, Stanley Chu wrote: UFS specficication allows different VCC configurations for UFS devices, for example, (1). 2.70V - 3.60V (By default) (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in device tree) (3). 2.40

Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code

2020-11-30 Thread Asutosh Das (asd)
On 11/26/2020 5:58 PM, Can Guo wrote: Instead of making the scale down gear a hard code, make it a member of ufs_clk_scaling struct. Signed-off-by: Can Guo --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 12 +++- drivers/scsi/ufs/ufshcd.h | 2 ++ 2 files changed, 9

Re: [PATCH v3 1/2] scsi: ufs: Refactor ufshcd_setup_clocks() to remove skip_ref_clk

2020-11-30 Thread Asutosh Das (asd)
On 11/25/2020 6:01 PM, Can Guo wrote: Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a flag in struct ufs_clk_info to tell whether a clock can be disabled or not while the link is active. Reviewed-by: Hongwu Su Reviewed-by: Bean Huo Reviewed-by: Stanley Chu Signed-off-by:

Re: [PATCH 1/3] scsi: ufs: Add "wb_on" sysfs node to control WB on/off

2020-11-30 Thread Asutosh Das (asd)
On 11/30/2020 10:11 AM, Bean Huo wrote: From: Bean Huo Currently we let UFS WriteBooster driver use clock scaling up/down to set WB on/off, for the platform which doesn't support UFSHCD_CAP_CLK_SCALING, WB will be always on. Provide a sysfs attribute to enable/disable WB during runtime. Signed

Re: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage values

2020-11-30 Thread Asutosh Das (asd)
On 11/30/2020 3:14 PM, Bjorn Andersson wrote: On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote: On 11/30/2020 1:16 AM, Stanley Chu wrote: UFS specficication allows different VCC configurations for UFS devices, for example, (1). 2.70V - 3.60V (By default) (2). 1.70V

Re: [PATCH v3 2/2] scsi: ufs-qcom: Keep core_clk_unipro ON while link is active

2020-11-30 Thread Asutosh Das (asd)
On 11/25/2020 6:01 PM, Can Guo wrote: If we want to disable clocks to save power but still keep the link active, core_clk_unipro, as same as ref_clk, should not be the one being disabled. Reviewed-by: Hongwu Su Signed-off-by: Can Guo --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufs

Re: [PATCH v3 2/3] scsi: ufs: Fix a racing problem between ufshcd_abort and eh_work

2020-11-30 Thread Asutosh Das (asd)
in_use shall evetually be cleared in __ufshcd_transfer_req_compl() invoked by the full reset and restore from err_handler. Signed-off-by: Can Guo --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 55 --- drivers/scsi/ufs/ufshcd.h | 2 ++ 2

Re: [PATCH v3 1/3] scsi: ufs: Serialize eh_work with system PM events and async scan

2020-11-30 Thread Asutosh Das (asd)
On 11/16/2020 11:04 PM, Can Guo wrote: Serialize eh_work with system PM events and async scan to make sure eh_work does not run in parallel with them. Signed-off-by: Can Guo --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 64

Re: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage values

2020-11-30 Thread Asutosh Das (asd)
On 11/30/2020 5:25 PM, Stanley Chu wrote: On Mon, 2020-11-30 at 15:54 -0800, Asutosh Das (asd) wrote: On 11/30/2020 3:14 PM, Bjorn Andersson wrote: On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote: On 11/30/2020 1:16 AM, Stanley Chu wrote: UFS specficication allows different VCC

Re: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage values

2020-11-30 Thread Asutosh Das (asd)
On 11/30/2020 6:53 PM, Bjorn Andersson wrote: On Mon 30 Nov 17:54 CST 2020, Asutosh Das (asd) wrote: On 11/30/2020 3:14 PM, Bjorn Andersson wrote: On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote: On 11/30/2020 1:16 AM, Stanley Chu wrote: UFS specficication allows different VCC

Re: [PATCH v1 0/3] Refine error history and introduce notify_event vop

2020-12-04 Thread Asutosh Das (asd)
history functions scsi: ufs: Introduce notify_event variant function drivers/scsi/ufs/ufshcd.c | 122 ++ drivers/scsi/ufs/ufshcd.h | 82 - 2 files changed, 112 insertions(+), 92 deletions(-) Hi Stanley, Reviewed-by: Asutosh Das

Re: [PATCH v2] scsi: ufs: Remove pre-defined initial voltage values of device powers

2020-12-01 Thread Asutosh Das (asd)
Reviewed-by: Bjorn Andersson Signed-off-by: Stanley Chu --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd-pltfrm.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index a6f76399b3ae..09e2f04bf4f6 10064

Re: [PATCH v3 1/2] scsi: ufs: Refactor ufshcd_setup_clocks() to remove skip_ref_clk

2020-12-01 Thread Asutosh Das (asd)
On 11/30/2020 7:11 PM, Can Guo wrote: On 2020-12-01 07:01, Asutosh Das (asd) wrote: On 11/25/2020 6:01 PM, Can Guo wrote: Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a flag in struct ufs_clk_info to tell whether a clock can be disabled or not while the link is active

Re: [PATCH 1/3] scsi: ufs: Add "wb_on" sysfs node to control WB on/off

2020-12-02 Thread Asutosh Das (asd)
On 12/2/2020 8:20 AM, Bean Huo wrote: On Mon, 2020-11-30 at 15:19 -0800, Asutosh Das (asd) wrote: + return -EINVAL; + + pm_runtime_get_sync(hba->dev); + res = ufshcd_wb_ctrl(hba, wb_enable); Say, a platform supports clock-scaling and this bit is toggled. The control g

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-10 Thread Asutosh Das (asd)
On 3/10/2021 8:27 AM, Alan Stern wrote: On Tue, Mar 09, 2021 at 08:04:53PM -0800, Asutosh Das (asd) wrote: On 3/9/2021 7:14 PM, Alan Stern wrote: On Tue, Mar 09, 2021 at 07:04:34PM -0800, Asutosh Das (asd) wrote: Hello I & Can (thanks CanG) debugged this further: Looks like this issue

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-05 Thread Asutosh Das (asd)
On 3/4/2021 7:35 AM, Adrian Hunter wrote: On 3/03/21 12:52 am, Asutosh Das wrote: During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-09 Thread Asutosh Das (asd)
On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote: On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki wrote: On Sat, Mar 6, 2021 at 5:17 PM Alan Stern wrote: On Fri, Mar 05, 2021 at 06:54:24PM -0800, Asutosh Das (asd) wrote: Now during my testing I see a weird issue sometimes (1 in 7). Scenario

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-09 Thread Asutosh Das (asd)
On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote: On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote: On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki wrote: On Sat, Mar 6, 2021 at 5:17 PM Alan Stern wrote: On Fri, Mar 05, 2021 at 06:54:24PM -0800, Asutosh Das (asd) wrote: Now during my testing

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-09 Thread Asutosh Das (asd)
On 3/9/2021 7:14 PM, Alan Stern wrote: On Tue, Mar 09, 2021 at 07:04:34PM -0800, Asutosh Das (asd) wrote: Hello I & Can (thanks CanG) debugged this further: Looks like this issue can occur if the sd probe is asynchronous. Essentially, the sd_probe() is done asynchronously

Re: [PATCH v2 2/2] scsi: ufs: Uninline ufshcd_vops_device_reset function

2020-12-15 Thread Asutosh Das (asd)
On 12/8/2020 5:56 AM, Stanley Chu wrote: Since more and more statements showing up in ufshcd_vops_device_reset(), uninline it to allow compiler making possibly better optimization. Signed-off-by: Stanley Chu --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 27

Re: [PATCH 1/2] mmc: cqhci: replace NUM_SLOTS with cq_host->num_slots

2019-02-08 Thread Asutosh Das (asd)
On 2/8/2019 8:07 AM, Ritesh Harjani wrote: Hi Alamy, On 2/8/2019 1:00 AM, Alamy Liu wrote: It says in B.2.1 in the JESD84-B51.pdf (I don't have JESD84-B51A.pdf): /The TDL is located in a memory location known to the CQE, and is comprised of up to 32 fixed-size slots. Each slot is compr

Re: [ 1/1] scsi: qcom-ufs: Add support for bus voting using ICB framework

2019-01-25 Thread Asutosh Das (asd)
On 1/24/2019 5:16 PM, Georgi Djakov wrote: Hi Asutosh, Thanks for the patch! On 1/24/19 09:01, Asutosh Das wrote: Adapt to the new ICB framework for bus bandwidth voting. It's actually called interconnect API or interconnect framework. Thanks! will change it. This requires the s

Re: [ 1/1] scsi: qcom-ufs: Add support for bus voting using ICB framework

2019-01-25 Thread Asutosh Das (asd)
On 1/24/2019 10:22 PM, Evan Green wrote: On Wed, Jan 23, 2019 at 11:02 PM Asutosh Das wrote: Adapt to the new ICB framework for bus bandwidth voting. This requires the source/destination port ids. Also this requires a tuple of values. The tuple is for two different paths - from UFS master

Re: [PATCH v2] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-30 Thread Asutosh Das (asd)
("scsi: ufs: Add write booster feature support") Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) Reviewed-by: Asutosh Das diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/uf

Re: [PATCH v2 1/3] scsi: ufshcd: Update the set frequency to devfreq

2020-05-26 Thread Asutosh Das (asd)
Hi Jeffrey On 5/25/2020 3:19 PM, Jeffrey Hugo wrote: On Wed, Mar 25, 2020 at 12:29 PM Asutosh Das wrote: Currently, the frequency that devfreq provides the driver to set always leads the clocks to be scaled up. Hence, round the clock-rate to the nearest frequency before deciding to scale

Re: [PATCH v4 0/4] scsi: ufs: Fix WriteBooster and cleanup UFS driver

2020-05-26 Thread Asutosh Das (asd)
s-sysfs.c | 13 - drivers/scsi/ufs/ufs.h | 2 +- drivers/scsi/ufs/ufshcd.c| 99 +--- drivers/scsi/ufs/ufshcd.h| 3 +- 4 files changed, 82 insertions(+), 35 deletions(-) This set looks good to me. Reviewed-by: Asutosh Das -- The Qualcomm I

Re: [PATCH v1 3/5] scsi: ufs: customize flush threshold for WriteBooster

2020-05-08 Thread Asutosh Das (asd)
On 5/8/2020 10:15 AM, Stanley Chu wrote: Allow flush threshold for WriteBooster to be customizable by vendors. To achieve this, make the value as a variable in struct ufs_hba first. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 6 -- drivers/scsi/ufs/ufshcd.h | 1 + 2 files

Re: [PATCH v1 4/4] scsi: ufs: Fix WriteBooster flush during runtime suspend

2020-05-13 Thread Asutosh Das (asd)
On 5/12/2020 3:47 AM, Stanley Chu wrote: Currently UFS host driver promises VCC supply if UFS device needs to do WriteBooster flush during runtime suspend. However the UFS specification mentions, "While the flushing operation is in progress, the device is in Active power mode." Therefore UFS h

Re: [PATCH v1 4/4] scsi: ufs: Fix WriteBooster flush during runtime suspend

2020-05-14 Thread Asutosh Das (asd)
On 5/14/2020 7:49 AM, Stanley Chu wrote: Hi Asutosh, On Thu, 2020-05-14 at 10:23 +0800, Stanley Chu wrote: Hi Asutosh, On Wed, 2020-05-13 at 12:31 -0700, Asutosh Das (asd) wrote: On 5/12/2020 3:47 AM, Stanley Chu wrote: Currently UFS host driver promises VCC supply if UFS device needs to do

Re: [PATCH v2 4/4] scsi: ufs: Fix WriteBooster flush during runtime suspend

2020-05-14 Thread Asutosh Das (asd)
On 5/14/2020 8:01 AM, Stanley Chu wrote: Currently UFS host driver promises VCC supply if UFS device needs to do WriteBooster flush during runtime suspend. However the UFS specification mentions, "While the flushing operation is in progress, the device is in Active power mode." Therefore UFS h

Re: [PATCH v2] scsi: ufshcd: fix missing destroy_workqueue()

2020-11-10 Thread Asutosh Das (asd)
vri Altman Signed-off-by: Qinglang Miao --- Reviewed-by: Asutosh Das v2: consider missing destroy_workqueue ufshcd_remove either. drivers/scsi/ufs/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b8f573a02713..ad

Re: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param()

2020-11-10 Thread Asutosh Das (asd)
corrsponding sysfs entries. Fix it by adding a sanity check of parameter offset against the actual decriptor length. Signed-off-by: Can Guo --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a

Re: [PATCH v1 1/2] scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-11-11 Thread Asutosh Das (asd)
ungate work is queued. To make sure scsi_block_reqs_cnt is handled by ufshcd_hold() and ufshcd_ungate_work() in a paired way, increase it only if queue_work() returns true. Signed-off-by: Can Guo Reviewed-by: Hongwu Su --- Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 6 +++--- 1

Re: [PATCH V4 2/2] scsi: ufs: Allow an error return value from ->device_reset()

2020-11-04 Thread Asutosh Das (asd)
de the callback, but do not do the reset operation should return -EOPNOTSUPP. Signed-off-by: Adrian Hunter Reviewed-by: Asutosh Das --- drivers/scsi/ufs/ufs-mediatek.c | 4 +++- drivers/scsi/ufs/ufs-qcom.c | 6 -- drivers/scsi/ufs/ufshcd.h | 11 +++ 3 files chang

Re: [PATCH V4 1/2] scsi: ufs: Add DeepSleep feature

2020-11-04 Thread Asutosh Das (asd)
med that UFS devices with wspecversion >= 0x310 support DeepSleep. Signed-off-by: Adrian Hunter --- Reviewed-by: Asutosh Das Documentation/ABI/testing/sysfs-driver-ufs | 34 +++ drivers/scsi/ufs/ufs-sysfs.c | 7 drivers/scsi/ufs

Re: [PATCH v7 4/8] scsi: ufs: Add some debug infos to ufshcd_print_host_state

2020-07-28 Thread Asutosh Das (asd)
during debug. In addition, this change makes cleanup to some prints in ufshcd_print_host_regs as similar prints are already available in ufshcd_print_host_state. Signed-off-by: Can Guo Reviewed-by: Avri Altman Reviewed-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c | 31

Re: [PATCH v7 7/8] scsi: ufs: Move dumps in IRQ handler to error handler

2020-07-28 Thread Asutosh Das (asd)
On 7/27/2020 10:00 PM, Can Guo wrote: Sometime dumps in IRQ handler are heavy enough to cause system stability issues, move them to error handler. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) dif

Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy

2020-05-11 Thread Asutosh Das (asd)
aps |= UFSHCD_CAP_WB_EN; + hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); /* * ufshcd_vops_init() is invoked after Patchset looks good to me. Reviewed-by: Asutosh Das -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Coll

Re: [PATCH v1 4/4] scsi: ufs: Fix WriteBooster flush during runtime suspend

2020-05-12 Thread Asutosh Das (asd)
Hi Stanley, On 5/12/2020 3:47 AM, Stanley Chu wrote: Currently UFS host driver promises VCC supply if UFS device needs to do WriteBooster flush during runtime suspend. However the UFS specification mentions, "While the flushing operation is in progress, the device is in Active power mode." Th

Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy

2020-05-12 Thread Asutosh Das (asd)
On 5/12/2020 9:21 AM, Martin K. Petersen wrote: Hi Asutosh! Patchset looks good to me. Reviewed-by: Asutosh Das When you want to approve an entire series, please respond to the cover letter email. Otherwise the kernel.org tooling will only record the tag for the individual patch you are

Re: [PATCH v8 8/8] scsi: ufs: cleanup WriteBooster feature

2020-05-08 Thread Asutosh Das (asd)
an be simplified to "else" since both have the same meaning. This patch does not change any functionality. Signed-off-by: Stanley Chu Reviewed-by: Avri Altman --- The whole series looks good to me. Reviewed-by: Asutosh Das drivers/scsi/ufs/ufshcd.c | 20 +++- 1

Re: [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

2018-02-22 Thread Asutosh Das (asd)
On 2/21/2018 6:48 PM, Stanislav Nijnikov wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Asutosh Das Sent: Wednesday, February 21, 2018 6:57 AM To: subha...@codeaurora.org; c...@codeaurora.org; vivek.gau

Re: [PATCH 1/9] scsi: ufs: Allowing power mode change

2018-02-22 Thread Asutosh Das (asd)
On 2/23/2018 10:40 AM, Kyuho Choi wrote: Hi Asutosh, I've simple question in below. On 2/21/18, Asutosh Das wrote: From: Yaniv Gardi Due to M-PHY issues, moving from HS to any other mode or gear or even Hibern8 causes some un-predicted behavior of the device. This patch fixes this i

Re: [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

2018-02-25 Thread Asutosh Das (asd)
On 2/24/2018 5:27 AM, Miguel Ojeda wrote: On Wed, Feb 21, 2018 at 5:56 AM, Asutosh Das wrote: From: Vijay Viswanath UFS driver can receive a request during memory reclaim by kswapd. So when ufs driver puts the ungate work in queue, and if there are no idle workers, kthreadd is invoked to

Re: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

2018-02-01 Thread Asutosh Das (asd)
g] On Behalf Of Asutosh Das Sent: Tuesday, January 30, 2018 6:54 AM To: subha...@codeaurora.org; c...@codeaurora.org; vivek.gau...@codeaurora.org; rna...@codeaurora.org; vinholika...@gmail.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com Cc: linux-s...@vger.kernel.org; Venkat Gopalakrishnan ; As

Re: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

2018-02-04 Thread Asutosh Das (asd)
On 2/2/2018 8:53 AM, Asutosh Das (asd) wrote: On 1/31/2018 1:09 PM, Avri Altman wrote: Hi, Can you elaborate how this can even happen? Isn't the interrupt aggregation capability should attend for those cases? Thanks, Avri -Original Message- From: linux-scsi-ow...@vger.kerne

[ufs]: [scsi]: BUG: spinlock recursion on CPU#4

2017-05-31 Thread Asutosh Das (asd)
atic_key_false(inline) -025|trace_workqueue_execute_end(inline) -025|process_one_work() -026|worker_thread() -027|kthread() -028|ret_from_fork(asm) ---|end of frame Please can you check if this is actually a bug and my understanding is correct. If so, I can put up a patch for the same. --

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-13 Thread Asutosh Das (asd)
: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Asutosh Das (asd) Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

<    1   2