Re: [PATCH v2] RDMA/umem: minor bug fix and cleanup in error handling paths

2019-03-03 Thread Artemy Kovalyov
On 02/03/2019 21:44, Ira Weiny wrote: On Sat, Mar 02, 2019 at 12:24:35PM -0800, john.hubb...@gmail.com wrote: From: John Hubbard ... 3. Dead code removal: the check for (user_virt & ~page_mask) is checking for a condition that can never happen, because earlier: user_virt = user_virt

Re: [PATCH v2] RDMA/umem: minor bug fix and cleanup in error handling paths

2019-03-05 Thread Artemy Kovalyov
On 04/03/2019 00:37, John Hubbard wrote: On 3/3/19 1:52 AM, Artemy Kovalyov wrote: On 02/03/2019 21:44, Ira Weiny wrote: On Sat, Mar 02, 2019 at 12:24:35PM -0800, john.hubb...@gmail.com wrote: From: John Hubbard ... OK, thanks for explaining! Artemy, while you're here, any tho