[RFC PATCH v1] vsock/test: add '--peer-port' input argument

iour. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/util.c| 17 +++- tools/testing/vsock/util.h| 4 + tools/testing/vsock/vsock_diag_test.c | 18 - tools/testing/vsock/vsock_test.c | 96 +-- tools/testing/vsock/vsock_

Re: [RFC PATCH v1] vsock/test: add '--peer-port' input argument

On 15.01.2024 14:54, Stefano Garzarella wrote: > Hi Arseniy, > thanks for this patch! > > On Sat, Jan 13, 2024 at 12:21:10AM +0300, Arseniy Krasnov wrote: >> Implement port for given CID as input argument instead of using >> hardcoded value '1234'. This allo

[PATCH net-next v2] vsock/test: add '--peer-port' input argument

iour. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Reword usage message. * Add commas after last field in 'opts' declaration. * 'RFC' -> 'net-next'. tools/testing/vsock/util.c| 17 +++- tools/testing/vsock/util.h

[PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET

SOCK_SEQPACKET is supported for virtio transport, so do not interpret such type of socket as unknown. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/vsock_diag_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/vsock/vsock_diag_test.c b/tools/testing/vsock

Re: [PATCH virt] virt: fix uninit-value in vhost_vsock_dev_open

tialize seqpacket_allow after allocation > - set it unconditionally in set_features > > Reported-by: syzbot+6c21aeb59d0e82eb2...@syzkaller.appspotmail.com > Reported-by: Jeongjun Park > Fixes: ced7b713711f ("vhost/vsock: support SEQPACKET for transport"). > Cc: Arseny Krasno

[RFC PATCH v1 0/2] send credit update during setting SO_RCVLOWAT

st parameters correctly (if one day this define will be changed - test may become useless). Head for this patchset is: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=ff269e2cd5adce4ae14f883fc9c8803bc43ee1e9 Arseniy Krasnov (2): virtio/vsock: send credit update d

[RFC PATCH v1 2/2] vsock/test: SO_RCVLOWAT + deferred credit update test

waits for free space at receiver's side. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/vsock_test.c | 131 +++ 1 file changed, 131 insertions(+) diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c index c1f7bc9abd22..c71b3875fd1

[RFC PATCH v1 1/2] virtio/vsock: send credit update during setting SO_RCVLOWAT

gup for tx/rx is possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- drivers/vhost/vsock.c | 2 ++ include/linux/virtio_vsock.h| 1 + net/vmw_vsock/virtio_transport.c|

Re: [RFC PATCH v1 1/2] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 15.11.2023 14:08, Stefano Garzarella wrote: > On Wed, Nov 08, 2023 at 10:20:03AM +0300, Arseniy Krasnov wrote: >> This adds sending credit update message when SO_RCVLOWAT is updated and >> it is bigger than number of bytes in rx queue. It is needed, because >> 'poll

Re: [RFC PATCH v1 2/2] vsock/test: SO_RCVLOWAT + deferred credit update test

On 15.11.2023 14:11, Stefano Garzarella wrote: > On Wed, Nov 08, 2023 at 10:20:04AM +0300, Arseniy Krasnov wrote: >> This adds test which checks, that updating SO_RCVLOWAT value also sends > > You can avoid "This adds", and write just "Add test ...". > &g

Re: [RFC PATCH v1 2/2] vsock/test: SO_RCVLOWAT + deferred credit update test

On 17.11.2023 11:30, Stefano Garzarella wrote: > On Fri, Nov 17, 2023 at 10:12:38AM +0300, Arseniy Krasnov wrote: >> >> >> On 15.11.2023 14:11, Stefano Garzarella wrote: >>> On Wed, Nov 08, 2023 at 10:20:04AM +0300, Arseniy Krasnov wrote: >>>>

[RFC PATCH v2 3/3] vsock/test: SO_RCVLOWAT + deferred credit update test

alue or its usage will be changed in kernel - this test may become useless/broken. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Update commit message by adding details about dependency for thi

[RFC PATCH v2 0/3] send credit update during setting SO_RCVLOWAT

27;sk_rcvlowat' only once in 'af_vsock.c' and in future do not copy-paste it to every transport. It was discussed in v1. * See per-patch changelog after ---. Arseniy Krasnov (3): vsock: update SO_RCVLOWAT setting callback virtio/vsock: send credit update during setting SO_RCVLOWAT

[RFC PATCH v2 1/3] vsock: update SO_RCVLOWAT setting callback

Do not return if transport callback for SO_RCVLOWAT is set (only in error case). In this case we don't need to set 'sk_rcvlowat' field in each transport - only in 'vsock_set_rcvlowat()'. Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/af_vsock.c | 9 +++-- 1 f

[RFC PATCH v2 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 'send_update' variable - set it

[PATCH net v1] vsock/test: fix SEQPACKET message bounds test

d at runtime and always bigger than 'getpagesize()' result. Reproduced on aarch64 with 64KB page size. Fixes: 5c338112e48a ("test/vsock: rework message bounds test") Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/vsock_test.c | 19 +-- 1 file changed, 1

[RFC PATCH v3 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 'send_update' variable - set it

[RFC PATCH v3 0/3] send credit update during setting SO_RCVLOWAT

e changelog after --- in 0003 only (0001 and 0002 still same). Arseniy Krasnov (3): vsock: update SO_RCVLOWAT setting callback virtio/vsock: send credit update during setting SO_RCVLOWAT vsock/test: SO_RCVLOWAT + deferred credit update test drivers/vhost/vsock.c | 2 + inc

[RFC PATCH v3 1/3] vsock: update SO_RCVLOWAT setting callback

Do not return if transport callback for SO_RCVLOWAT is set (only in error case). In this case we don't need to set 'sk_rcvlowat' field in each transport - only in 'vsock_set_rcvlowat()'. Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/af_vsock.c | 9 +++-- 1 f

[RFC PATCH v3 3/3] vsock/test: SO_RCVLOWAT + deferred credit update test

alue or its usage will be changed in kernel - this test may become useless/broken. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Update commit message by adding details about dependency for thi

[RFC PATCH v4 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 'send_update' variable - set it

[RFC PATCH v4 0/3] send credit update during setting SO_RCVLOWAT

very transport. It was discussed in v1. * See per-patch changelog after ---. v2 -> v3: * See changelog after --- in 0003 only (0001 and 0002 still same). v3 -> v4: * Patchset rebased and tested on new HEAD of net-next (see hash above). * See per-patch changelog after ---. Arseniy Krasn

Re: [RFC PATCH v4 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 30.11.2023 11:38, Stefano Garzarella wrote: > On Thu, Nov 30, 2023 at 12:25:18AM +0300, Arseniy Krasnov wrote: >> Send credit update message when SO_RCVLOWAT is updated and it is bigger >> than number of bytes in rx queue. It is needed, because 'poll()' will >>

[PATCH net-next v5 1/3] vsock: update SO_RCVLOWAT setting callback

allback name from 'set_rcvlowat' to 'notify_set_rcvlowat'. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- Changelog: v3 -> v4: * Rename 'set_rcvlowat' to 'notify_set_rcvlowat'. * Commit message updated. include/net/af_vsock.h

[PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 'send_update' variable - set it

[PATCH net-next v5 0/3] send credit update during setting SO_RCVLOWAT

on new HEAD of net-next (see hash above). * See per-patch changelog after ---. v4 -> v5: * Change patchset tag 'RFC' -> 'net-next'. * See per-patch changelog after ---. Arseniy Krasnov (3): vsock: update SO_RCVLOWAT setting callback virtio/vsock: send credit update

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 30.11.2023 16:42, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: >> Send credit update message when SO_RCVLOWAT is updated and it is bigger >> than number of bytes in rx queue. It is needed, because 'poll()' will >>

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 30.11.2023 16:58, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: >> >> >> On 30.11.2023 16:42, Michael S. Tsirkin wrote: >>> On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: >>>> Send

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 30.11.2023 17:11, Stefano Garzarella wrote: > On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote: >> On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: >>> >>> >>> On 30.11.2023 16:42, Michael S. Tsirkin wrote: >>&g

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 30.11.2023 20:37, Michael S. Tsirkin wrote: > On Thu, Nov 30, 2023 at 06:41:56PM +0300, Arseniy Krasnov wrote: >> >> >> On 30.11.2023 17:11, Stefano Garzarella wrote: >>> On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote: >>>>

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wrote: >>> > > >>> > > >>> > > On 30.11.2023 16:42, Michael S. Tsirkin wrote: >>> > > > On Thu, Nov 30, 2023 at 04:08:39PM +0300, Arseniy Krasnov wrote: >>> > > &

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 01.12.2023 12:48, Stefano Garzarella wrote: > On Fri, Dec 01, 2023 at 11:35:56AM +0300, Arseniy Krasnov wrote: >> >> >> On 01.12.2023 11:27, Stefano Garzarella wrote: >>> On Thu, Nov 30, 2023 at 12:40:43PM -0500, Michael S. Tsirkin wrote: >>>>

Re: [PATCH net-next v5 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

On 02.12.2023 23:22, Michael S. Tsirkin wrote: > On Fri, Dec 01, 2023 at 01:40:41PM +0300, Arseniy Krasnov wrote: >> >> >> On 01.12.2023 12:48, Stefano Garzarella wrote: >>> On Fri, Dec 01, 2023 at 11:35:56AM +0300, Arseniy Krasnov wrote: >>>> >>

[PATCH net-next v6 1/4] vsock: update SO_RCVLOWAT setting callback

allback name from 'set_rcvlowat' to 'notify_set_rcvlowat'. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- Changelog: v3 -> v4: * Rename 'set_rcvlowat' to 'notify_set_rcvlowat'. * Commit message updated. include/net/af_vsock.h

[PATCH net-next v6 4/4] vsock/test: two tests to check credit update logic

Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Si

[PATCH net-next v6 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 'send_update' variable - set it

[PATCH net-next v6 0/4] send credit update during setting SO_RCVLOWAT

5 -> v6: * New patch 0003 which sends credit update during reading bytes from socket. * See per-patch changelog after ---. Arseniy Krasnov (4): vsock: update SO_RCVLOWAT setting callback virtio/vsock: send credit update during setting SO_RCVLOWAT virtio/vsock: fix logic which reduces cred

[PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

n, because we need at least SO_RCVLOWAT bytes in our rx queue to wake up user for reading data (in corner case it is also possible to stuck both tx and rx sides, this is why 'Fixes' is used). Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off

Re: [PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

On 05.12.2023 13:54, Stefano Garzarella wrote: > On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote: >> Add one more condition for sending credit update during dequeue from >> stream socket: when number of bytes in the rx queue is smaller than >> SO_RCVLOWA

Re: [PATCH net-next v6 3/4] virtio/vsock: fix logic which reduces credit update messages

On 05.12.2023 17:21, Stefano Garzarella wrote: > On Tue, Dec 05, 2023 at 03:07:47PM +0300, Arseniy Krasnov wrote: >> >> >> On 05.12.2023 13:54, Stefano Garzarella wrote: >>> On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote: >>>> Add on

Re: [PATCH net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning

because we also pass MAX_SKB_FRAGS to iov_iter_npages(), > which performs almost the same check, returning at most MAX_SKB_FRAGS > elements. So, let's eliminate this unnecessary comparison. > > Fixes: 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support") > Cc: avkras...@salu

[PATCH net-next v7 1/4] vsock: update SO_RCVLOWAT setting callback

allback name from 'set_rcvlowat' to 'notify_set_rcvlowat'. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- Changelog: v3 -> v4: * Rename 'set_rcvlowat' to 'notify_set_rcvlowat'. * Commit message updated. include/net/af_vsock.h

[PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

xes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off-by: Arseniy Krasnov --- Changelog: v6 -> v7: * Handle wrap of 'fwd_cnt'. * Do to send credit update when 'fwd_cnt' == 'last_fwd_cnt'. net/vmw_vsock/virtio_transport_commo

[PATCH net-next v7 0/4] send credit update during setting SO_RCVLOWAT

set tag 'RFC' -> 'net-next'. * See per-patch changelog after ---. v5 -> v6: * New patch 0003 which sends credit update during reading bytes from socket. * See per-patch changelog after ---. v6 -> v7: * Patchset rebased and tested on new HEAD of net-next (see hash

[PATCH net-next v7 4/4] vsock/test: two tests to check credit update logic

Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Si

[PATCH net-next v7 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 'send_update' variable - set it

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

On 07.12.2023 00:53, Michael S. Tsirkin wrote: > On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote: >> Add one more condition for sending credit update during dequeue from >> stream socket: when number of bytes in the rx queue is smaller than >> SO_RCVLOWA

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

On 07.12.2023 01:08, Michael S. Tsirkin wrote: > On Thu, Dec 07, 2023 at 12:52:51AM +0300, Arseniy Krasnov wrote: >> >> >> On 07.12.2023 00:53, Michael S. Tsirkin wrote: >>> On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote: >>>> Add on

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

On 11.12.2023 15:01, Stefano Garzarella wrote: > On Thu, Dec 07, 2023 at 01:50:05AM +0300, Arseniy Krasnov wrote: >> >> >> On 07.12.2023 01:08, Michael S. Tsirkin wrote: >>> On Thu, Dec 07, 2023 at 12:52:51AM +0300, Arseniy Krasnov wrote: >>>> >>

[PATCH net-next v8 1/4] vsock: update SO_RCVLOWAT setting callback

allback name from 'set_rcvlowat' to 'notify_set_rcvlowat'. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- Changelog: v3 -> v4: * Rename 'set_rcvlowat' to 'notify_set_rcvlowat'. * Commit message updated. include/net/af_vsock.h

[PATCH net-next v8 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- Changelog: v1 -> v2: * Update commit message by removing 'This patch adds XXX' manner. * Do not initialize 's

[PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

changelog after ---. v6 -> v7: * Patchset rebased and tested on new HEAD of net-next (see hash above). * See per-patch changelog after ---. v7 -> v8: * See per-patch changelog after ---. Arseniy Krasnov (4): vsock: update SO_RCVLOWAT setting callback virtio/vsock: send credit update du

[PATCH net-next v8 4/4] vsock/test: two tests to check credit update logic

Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Si

[PATCH net-next v8 3/4] virtio/vsock: fix logic which reduces credit update messages

n, because we need at least SO_RCVLOWAT bytes in our rx queue to wake up user for reading data (in corner case it is also possible to stuck both tx and rx sides, this is why 'Fixes' is used). Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off-by: A

Re: [PATCH net-next v8 3/4] virtio/vsock: fix logic which reduces credit update messages

On 12.12.2023 18:54, Michael S. Tsirkin wrote: > On Tue, Dec 12, 2023 at 12:16:57AM +0300, Arseniy Krasnov wrote: >> Add one more condition for sending credit update during dequeue from >> stream socket: when number of bytes in the rx queue is smaller than >> SO_RCVLOWA

Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

On 12.12.2023 18:54, Michael S. Tsirkin wrote: > On Tue, Dec 12, 2023 at 12:16:54AM +0300, Arseniy Krasnov wrote: >> Hello, >> >>DESCRIPTION >> >> This patchset fixes old problem with hungup of both rx/tx sides and adds >&g

Re: [PATCH net-next v8 3/4] virtio/vsock: fix logic which reduces credit update messages

On 12.12.2023 19:11, Michael S. Tsirkin wrote: > On Tue, Dec 12, 2023 at 06:50:39PM +0300, Arseniy Krasnov wrote: >> >> >> On 12.12.2023 18:54, Michael S. Tsirkin wrote: >>> On Tue, Dec 12, 2023 at 12:16:57AM +0300, Arseniy Krasnov wrote: >>>> Add on

Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

On 12.12.2023 19:12, Michael S. Tsirkin wrote: > On Tue, Dec 12, 2023 at 06:59:03PM +0300, Arseniy Krasnov wrote: >> >> >> On 12.12.2023 18:54, Michael S. Tsirkin wrote: >>> On Tue, Dec 12, 2023 at 12:16:54AM +0300, Ars

Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

On 13.12.2023 11:43, Stefano Garzarella wrote: > On Tue, Dec 12, 2023 at 08:43:07PM +0300, Arseniy Krasnov wrote: >> >> >> On 12.12.2023 19:12, Michael S. Tsirkin wrote: >>> On Tue, Dec 12, 2023 at 06:59:03PM +0300, Arseniy Krasnov wrote: >>>> >>

Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

On 13.12.2023 12:41, Stefano Garzarella wrote: > On Wed, Dec 13, 2023 at 12:08:27PM +0300, Arseniy Krasnov wrote: >> >> >> On 13.12.2023 11:43, Stefano Garzarella wrote: >>> On Tue, Dec 12, 2023 at 08:43:07PM +0300, Arseniy Krasnov wrote: >>>> >>

Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT

On 13.12.2023 18:13, Michael S. Tsirkin wrote: > On Wed, Dec 13, 2023 at 10:05:44AM -0500, Michael S. Tsirkin wrote: >> On Wed, Dec 13, 2023 at 12:08:27PM +0300, Arseniy Krasnov wrote: >>> >>> >>> On 13.12.2023 11:43, Stefano Garzarella wrote: >>&

[PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

allback name from 'set_rcvlowat' to 'notify_set_rcvlowat'. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella Acked-by: Michael S. Tsirkin --- Changelog: v3 -> v4: * Rename 'set_rcvlowat' to 'notify_set_rcvlowat'. * Commit message updated.

[PATCH net-next v9 0/4] send credit update during setting SO_RCVLOWAT

v9: * Patchset rebased and tested on new HEAD of net-next (see hash above). * Add 'Fixes' tag for the current 0002. * Reorder patches by moving two fixes first. Arseniy Krasnov (4): virtio/vsock: fix logic which reduces credit update messages virtio/vsock: send credit update duri

[PATCH net-next v9 4/4] vsock/test: two tests to check credit update logic

Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Si

[PATCH net-next v9 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

s possible: sender waits for free space and receiver is waiting data in 'poll()'. Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella Acked-by: Michael S. Tsirkin --- Changelog: v1 -> v2: *

[PATCH net-next v9 1/4] virtio/vsock: fix logic which reduces credit update messages

n, because we need at least SO_RCVLOWAT bytes in our rx queue to wake up user for reading data (in corner case it is also possible to stuck both tx and rx sides, this is why 'Fixes' is used). Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off-by

Re: [PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

On 14.12.2023 13:29, Michael S. Tsirkin wrote: > On Thu, Dec 14, 2023 at 12:19:46PM +0300, Arseniy Krasnov wrote: >> Do not return if transport callback for SO_RCVLOWAT is set (only in >> error case). In this case we don't need to set 'sk_rcvlowat' field

[PATCH net-next v10 3/3] vsock/test: two tests to check credit update logic

Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Si

[PATCH net-next v10 0/3] send credit update during setting SO_RCVLOWAT

e). * See per-patch changelog after ---. v7 -> v8: * See per-patch changelog after ---. v8 -> v9: * Patchset rebased and tested on new HEAD of net-next (see hash above). * Add 'Fixes' tag for the current 0002. * Reorder patches by moving two fixes first. v9 -> v10: * Squash 0

[PATCH net-next v10 2/3] virtio/vsock: send credit update during setting SO_RCVLOWAT

to do it. Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella Acked-by: Michael S. Tsirkin --- Changelog: v9 -> v10: * This is squash of 0002 and 0003 from v9. drivers/vhost/vsock.c

[PATCH net-next v10 1/3] virtio/vsock: fix logic which reduces credit update messages

n, because we need at least SO_RCVLOWAT bytes in our rx queue to wake up user for reading data (in corner case it is also possible to stuck both tx and rx sides, this is why 'Fixes' is used). Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages") Signed-off-by

Re: [PATCH net-next v9 3/4] vsock: update SO_RCVLOWAT setting callback

On 14.12.2023 13:29, Michael S. Tsirkin wrote: > On Thu, Dec 14, 2023 at 12:19:46PM +0300, Arseniy Krasnov wrote: >> Do not return if transport callback for SO_RCVLOWAT is set (only in >> error case). In this case we don't need to set 'sk_rcvlowat' field

[RFC PATCH v1 2/2] vsock/test: add test for deferred credit update

credit update - currently it is 64Kb. * It needs permissions to open raw sockets. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/.gitignore | 1 + tools/testing/vsock/Makefile| 2 + tools/testing/vsock/virtio_vsock_test.c | 369 3 files

[RFC PATCH v1 0/2] virtio/vsock: some updates for deferred credit update

This patchset contains: 0001 - patch which reworks deferred credit update. Pls see commit message, it contains full description of this problem. 0002 - test which uses vsockmon interface, and checks that deferred credit update works as expected by parsing raw packets. Arseniy

[RFC PATCH v1 1/2] virtio/vsock: rework deferred credit update logic

is some performance comparison between both versions of 'free_space' calculation: *--*--*--* | | 'rx_cnt' | previous | *--*--*--* |H -> G| 8.42 | 7.82 | *--*--*--* |G -> H| 11.6 | 12.1

Re: [RFC PATCH v1 1/2] virtio/vsock: rework deferred credit update logic

On 25.06.2024 16:46, Stefano Garzarella wrote: > On Fri, Jun 21, 2024 at 10:25:40PM GMT, Arseniy Krasnov wrote: >> Previous calculation of 'free_space' was wrong (but worked as expected >> in most cases, see below), because it didn't account number of byte

[PATCH v1] MAINTAINERS: add me as reviewer of AF_VSOCK and virtio-vsock

I'm working on AF_VSOCK and virtio-vsock. Signed-off-by: Arseniy Krasnov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c0a3d9e93689..2bf0987d87ed 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24131,6 +24131,7 @@ F: virt/lib/ V

Re: [PATCH v1] MAINTAINERS: add me as reviewer of AF_VSOCK and virtio-vsock

On 30.07.2024 18:47, Jakub Kicinski wrote: > On Sun, 28 Jul 2024 21:33:25 +0300 Arseniy Krasnov wrote: >> I'm working on AF_VSOCK and virtio-vsock. > > If you want to review the code perhaps you can use lore+lei > and filter on the paths? > > Adding people to MA

Re: [PATCH v1] MAINTAINERS: add me as reviewer of AF_VSOCK and virtio-vsock

On 31.07.2024 00:54, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2024 at 08:47:07AM -0700, Jakub Kicinski wrote: >> On Sun, 28 Jul 2024 21:33:25 +0300 Arseniy Krasnov wrote: >>> I'm working on AF_VSOCK and virtio-vsock. >> >> If you want to review the code

[PATCH 00/13] High performance balancing logic for big.LITTLE

HPERF_HMP Linaro MP Integral benchmark result 42400 36860 Result: hperf_hmp is 15% better. Arseniy Krasnov (13): hperf_hmp: add new config for arm and arm64. hperf_hmp: introduce hew domain flag. hperf_hmp: add sched domains initialization. hperf_hm

[PATCH 09/13] hperf_hmp: one way balancing function.

Almost identical functions which push/pull task from/to current CPU to/from another cluster. Called when balancing between clusters is broken and we need to fix it. Signed-off-by: Tarek Dakhran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov

[PATCH 01/13] hperf_hmp: add new config for arm and arm64.

sk of A7 cluster(in hex string). Signed-off-by: Tarek Dakhran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- arch/arm/Kconfig | 21 + arch/arm64/Kconfig | 21 + 2 files c

[PATCH 11/13] hperf_hmp: task CPU selection logic.

an Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kernel/sched/fair.c | 132 1 file changed, 101 insertions(+), 31 deletions(-) diff --git a/kernel/sched/fair.

[PATCH 13/13] hperf_hmp: cpufreq routines.

Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kernel/sched/fair.c | 76 + 1 file changed, 76 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 06f6518..87dc0db 100644 --- a/kernel/sched/fair.c +++ b

[PATCH 12/13] hperf_hmp: rest of logic.

ned-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kernel/sched/fair.c | 204 +++- 1 file changed, 202 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 79be023..06f6518 100644 --- a/kernel/sched/fa

[PATCH 03/13] hperf_hmp: add sched domains initialization.

Attaching CPU clusters as 'sched_group' to HMP domains. Each HMP domain has two pointers to A15 and A7 scheduling groups(struct sched_group). Signed-off-by: Tarek Dakhran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-of

[PATCH 08/13] hperf_hmp: swap tasks function.

khran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kernel/sched/fair.c | 100 +++ kernel/sched/sched.h | 1 + 2 files changed, 101 insertions(+) diff --git a/k

[PATCH 07/13] hperf_hmp: migration auxiliary functions.

: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- include/linux/sched.h | 6 + kernel/sched/fair.c | 301 ++ 2 files changed, 307 insertions(+) diff --git a/include/linux/sched.h b/include/linux/sched.h index 89c1bf3

[PATCH 10/13] hperf_hmp: idle pull function.

7;druntime' metric. Only difference is that migration task doesn't need to run 5ms on its cluster before migration. Signed-off-by: Tarek Dakhran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kern

[PATCH 06/13] hperf_hmp: is_hmp_imbalance introduced.

shold when balancing is needed. Signed-off-by: Tarek Dakhran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kernel/sched/fair.c | 103 1 file changed, 103 insertion

[PATCH 05/13] hperf_hmp: introduce druntime metric.

'update_curr' function. Signed-off-by: Tarek Dakhran Signed-off-by: Sergey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- include/linux/sched.h | 3 ++ kernel/sched/core.c | 3 ++ kernel/sched/fair.c | 115 +

[PATCH 04/13] hperf_hmp: scheduler initialization routines.

gey Dyasly Signed-off-by: Dmitriy Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- kernel/sched/core.c | 4 kernel/sched/fair.c | 46 ++ kernel/sched/sched.h | 15 +++ 3 files changed, 65 insertions(+) di

[PATCH 02/13] hperf_hmp: introduce hew domain flag.

Safonov Signed-off-by: Arseniy Krasnov Signed-off-by: Ilya Maximets --- arch/arm/kernel/topology.c | 6 +- include/linux/sched.h | 4 kernel/sched/core.c| 9 - 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel