Re: [PATCH v6 10/16] remoteproc: Introduce function rproc_detach()

2021-02-26 Thread Arnaud POULIQUEN
On 2/24/21 12:35 AM, Mathieu Poirier wrote: > Introduce function rproc_detach() to enable the remoteproc > core to release the resources associated with a remote processor > without stopping its operation. > > Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pou

Re: [PATCH v6 11/16] remoteproc: Properly deal with the resource table when attached

2021-02-26 Thread Arnaud POULIQUEN
On 2/24/21 12:35 AM, Mathieu Poirier wrote: > If it is possible to detach the remote processor, keep an untouched > copy of the resource table. That way we can start from the same > resource table without having to worry about original values or what > elements the startup code has changed when

Re: [PATCH v6 14/16] remoteproc: Properly deal with a stop request when attached

2021-02-26 Thread Arnaud POULIQUEN
On 2/24/21 12:35 AM, Mathieu Poirier wrote: > Allow a remote processor that was started by another entity to be > switched off by the remoteproc core. For that to happen a > rproc::ops::stop() operation needs to be available. > > Signed-off-by: Mathieu Poirier Reviewed-by: A

Re: [PATCH v6 15/16] remoteproc: Properly deal with a detach request when attached

2021-02-26 Thread Arnaud POULIQUEN
r Reviewed-by: Arnaud Pouliquen Thanks, Arnaud > --- > New for V6: > - The RPROC_RUNNING -> RPROC_DETACHED transition is no longer permitted > to avoid dealing with complex resource table management problems. > - Removed Peng and Arnaud's RB tags because of the

Re: [PATCH v6 16/16] remoteproc: Refactor rproc delete and cdev release path

2021-02-26 Thread Arnaud POULIQUEN
On 2/24/21 12:35 AM, Mathieu Poirier wrote: > Refactor function rproc_del() and rproc_cdev_release() to take > into account the current state of the remote processor when choosing > the state to transition to. > > Signed-off-by: Mathieu Poirier > --- > New for V6: > - The RPROC_RUNNING -> RPRO

Re: [PATCH v6 00/16] remoteproc: Add support for detaching a remote processor

2021-02-26 Thread Arnaud POULIQUEN
> it > comes out next week. > > Thanks, > Mathieu > > Arnaud POULIQUEN (1): > remoteproc: stm32: Move memory parsing to rproc_ops > > Mathieu Poirier (15): > remoteproc: Remove useless check in rproc_del() > remoteproc: Rename function rproc_actuate() > r

[PATCH] rpmsg: virtio: fix compilation warning for virtio_rpmsg_channel description

2020-07-31 Thread Arnaud Pouliquen
Complete the virtio_rpmsg_channel structure description to fix a compilation warning with W=1 option: drivers/rpmsg/virtio_rpmsg_bus.c:95: warning: Cannot understand * @vrp: the remote processor this channel belongs to Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 7

Re: [PATCH v6 0/3] rpmsg: core: Add support for name extension

2020-05-20 Thread Arnaud POULIQUEN
Hi Bjorn, On 5/15/20 11:09 PM, Bjorn Andersson wrote: > On Fri 15 May 13:56 PDT 2020, Mathieu Poirier wrote: > >> This patchset adds the capability to supplement the base definition >> published by an rpmsg_driver with a postfix description so that it >> is easy to differentiate entities that use

[PATCH 6/9] rpmsg: virtio: use rpmsg ns device for the ns announcement

2020-07-31 Thread Arnaud Pouliquen
As generic NS driver is available, rely on it for NS management instead of managing it in RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/Kconfig| 1 + drivers/rpmsg/virtio_rpmsg_bus.c | 86 2 files changed, 21 insertions(+), 66

[PATCH 8/9] rpmsg: virtio: use rpmsg_ns driver to manage ns announcement

2020-07-31 Thread Arnaud Pouliquen
Use the new rpmsg_ns API to send the name service announcements if the VIRTIO_RPMSG_F_NS is set, else just not implement the ops. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 94 +--- 1 file changed, 13 insertions(+), 81 deletions(-) diff

[PATCH 7/9] rpmsg: ns: add name service announcement service

2020-07-31 Thread Arnaud Pouliquen
corresponding to the ept created. RPMSG_NS_ADDR as source address make sense as we want to send a message belonging to the NS announcement service and the created ept address is already in the message payload. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_internal.h | 3 +++ drivers/rpmsg

[PATCH 0/9] introduce name service announcement rpmsg driver

2020-07-31 Thread Arnaud Pouliquen
announcement. The virtio backend is updated in consequence to use this service. Applies cleanly on Bjorn rpmsg-next branch (ddd1930d6e3e) Arnaud Pouliquen (9): rpmsg: virtio: rename rpmsg_create_channel rpmsg: core: add channel creation internal API rpmsg: virtio: add rpmsg channel device ops

[PATCH 3/9] rpmsg: virtio: add rpmsg channel device ops

2020-07-31 Thread Arnaud Pouliquen
Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg

[PATCH 9/9] rpmsg: ns: name service announcement endianness

2020-07-31 Thread Arnaud Pouliquen
The endianness has to be fixed to ensure that both sides can decode the message. The Little endian format is used according to the generic virtio implementation. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ns.c | 17 + 1 file changed, 9 insertions(+), 8 deletions

[PATCH 4/9] rpmsg: define the name service announcement as reserved address

2020-07-31 Thread Arnaud Pouliquen
The address 53 is reserved for the dynamic RPMsg device management on name service announcement. Define this address in a reserved enum list. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- include/linux/rpmsg.h| 9 + 2 files changed, 9

[PATCH 5/9] rpmsg: introduce reserved rpmsg driver for ns announcement

2020-07-31 Thread Arnaud Pouliquen
service announcement. This first patch only implements the probe and the RPMsg endpoint to manage create and release channels remote requests. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/Kconfig | 8 ++ drivers/rpmsg/Makefile | 1 + drivers/rpmsg/rpmsg_internal.h | 17

[PATCH 2/9] rpmsg: core: add channel creation internal API

2020-07-31 Thread Arnaud Pouliquen
Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_core.c | 37 ++ drivers/rpmsg/rpmsg_internal.h

[PATCH 1/9] rpmsg: virtio: rename rpmsg_create_channel

2020-07-31 Thread Arnaud Pouliquen
Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg

[PATCH 02/13] rpmsg: introduce rpmsg_control driver for channel creation

2020-07-31 Thread Arnaud Pouliquen
. Instantiating this device as an RPMsg device allows to retrieve the associated RPMsg backend. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/Kconfig | 8 ++ drivers/rpmsg/Makefile | 1 + drivers/rpmsg/rpmsg_ctrl.c | 209 + 3 files changed, 218

[PATCH 00/13] introduce IOCTL interface for RPMsg channel management

2020-07-31 Thread Arnaud Pouliquen
to the ioctl update and available here: https://github.com/arnopo/rpmsgexport. Arnaud Pouliquen (13): rpmsg: introduce rpmsg raw driver rpmsg: introduce rpmsg_control driver for channel creation rpmsg: add helper to create the rpmsg ctrl device rpmsg: virtio: probe the rpmsg_ctrl devic

[PATCH 11/13] rpmsg: virtio: use the driver_override in channel creation

2020-07-31 Thread Arnaud Pouliquen
Use the override information from the channel info structure to set the rpdev override and so link the channel to a specific driver. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b

[PATCH 05/13] rpmsg: uapi: add service param for create destroy ioctls

2020-07-31 Thread Arnaud Pouliquen
services with ID higher or equal to 1024. Signed-off-by: Arnaud Pouliquen --- include/uapi/linux/rpmsg.h | 16 1 file changed, 16 insertions(+) diff --git a/include/uapi/linux/rpmsg.h b/include/uapi/linux/rpmsg.h index e14c6dab4223..2ccc10ffacd4 100644 --- a/include/uapi/linux/rpmsg.h

[PATCH 07/13] rpmsg: control: add driver registration API

2020-07-31 Thread Arnaud Pouliquen
Add API for RPMsg driver to register the supported service. This API has to be called during RPMsg driver init to declare the service. Then the RPMsg control will be able to instantiate associated device. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ctrl.c | 57

[PATCH 03/13] rpmsg: add helper to create the rpmsg ctrl device

2020-07-31 Thread Arnaud Pouliquen
This function creates the rpmsg_ctl device using the driver_override to link device to the driver. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_internal.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg

[PATCH 13/13] rpmsg: ctrl: add support of the endpoints release

2020-07-31 Thread Arnaud Pouliquen
Add the support of the release of an endpoint using the ioctl interface. The endpoint is identified using its name, its source address and is destination address. To support legacy a new ioctl ioctl is created instead of updating RPMSG_DESTROY_EPT_IOCTL. Signed-off-by: Arnaud Pouliquen

[PATCH 06/13] rpmsg: add RPMsg control info structure

2020-07-31 Thread Arnaud Pouliquen
Add new structure for RPMsg driver registration. This structure will be used to link a service to its driver. Signed-off-by: Arnaud Pouliquen --- include/linux/rpmsg.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h index

[PATCH 04/13] rpmsg: virtio: probe the rpmsg_ctrl device

2020-07-31 Thread Arnaud Pouliquen
Probe the rpmsg_ctrl driver on virtio rpmsg bus creation. This provides the possibility to expose an ioctrl to create RPMsg channels. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff

[PATCH 12/13] rpmsg: control: implement the ioctrl function to create device

2020-07-31 Thread Arnaud Pouliquen
Implement the ioctrl function that parses the list of rpmsg drivers registered to create an associated device. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ctrl.c | 39 -- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg

[PATCH 09/13] rpmsg: add override field in channel info

2020-07-31 Thread Arnaud Pouliquen
The override field is already used in the rpmsg_device. This allows to force a service name to be associated to a RPMsg service driver. Adding this field in the channel info allows to force the channel creation with a specified RPMsg service driver. Signed-off-by: Arnaud Pouliquen --- include

[PATCH 10/13] rpmsg: ns: initialize channel info override field

2020-07-31 Thread Arnaud Pouliquen
By default driver_override should be 0 to avoid to force the channel creation with a specified name.The local variable is not initialized. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ns.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg

[PATCH 08/13] rpmsg: raw: register service to the rpmsg control

2020-07-31 Thread Arnaud Pouliquen
Register the RPMSG_RAW_SERVICE service to the RPMsg control Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_raw.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_raw.c b/drivers/rpmsg/rpmsg_raw.c index 8684a78ab4d1

[PATCH 01/13] rpmsg: introduce rpmsg raw driver

2020-07-31 Thread Arnaud Pouliquen
now created by the bus not on the fs open. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/Kconfig | 9 + drivers/rpmsg/Makefile| 1 + drivers/rpmsg/rpmsg_raw.c | 347 ++ 3 files changed, 357 insertions(+) create mode 100644 drivers/rpmsg

[PATCH v2 00/16] introduce generic IOCTL interface for RPMsg channels management

2020-12-22 Thread Arnaud Pouliquen
] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=327277 Arnaud Pouliquen (16): rpmsg: introduce RPMsg control driver for channel creation rpmsg: add RPMsg control API to register service rpmsg: add override field in channel info rpmsg: ctrl: implement the ioctl functio

[PATCH v2 01/16] rpmsg: introduce RPMsg control driver for channel creation

2020-12-22 Thread Arnaud Pouliquen
driver is associated to a RPMsg device with no endpoint. Instantiating this device as an RPMsg device allows to retrieve the associated RPMsg backend. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/Kconfig | 8 ++ drivers/rpmsg/Makefile | 1 + drivers/rpmsg/rpmsg_ctrl.c | 208

[PATCH v2 06/16] rpmsg: add helper to register the rpmsg ctrl device

2020-12-22 Thread Arnaud Pouliquen
This function registers a rpmsg_ctl device and its associated /dev/rpmsg_ctrl interface. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ctrl.c | 16 include/linux/rpmsg.h | 7 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/rpmsg/rpmsg_ctrl.c b

[PATCH v2 03/16] rpmsg: add override field in channel info

2020-12-22 Thread Arnaud Pouliquen
The override field is already used in the rpmsg_device. Adding this field in the channel info allows to force the channel creation with a specified RPMsg service driver. Signed-off-by: Arnaud Pouliquen --- include/linux/rpmsg.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux

[PATCH v2 11/16] rpmsg: char: check destination address is not null

2020-12-22 Thread Arnaud Pouliquen
The name service announcement is not sent if no endpoint is created by default. If the destination address is not precised by the application when creating the device (thanks to the RPMsg CTRL interface), it is not possible to have a valid RPMsg channel. Signed-off-by: Arnaud Pouliquen

[PATCH v2 02/16] rpmsg: add RPMsg control API to register service

2020-12-22 Thread Arnaud Pouliquen
Add API to register a RPMsg service to the control device. The rpmsg_drv_ctrl_info structure links a service to its driver. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ctrl.c | 57 ++ include/linux/rpmsg.h | 31 + include

[PATCH v2 09/16] rpmsg: char: register RPMsg raw service to the ioctl interface.

2020-12-22 Thread Arnaud Pouliquen
Associate the RPMsg char to the RPMSG_RAW_SERVICE, by registering it to the RPMsg Control. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg

[PATCH v2 12/16] rpmsg: virtio: use the driver_override in channel creation ops

2020-12-22 Thread Arnaud Pouliquen
Use the override information from the channel info structure to set the rpdev override and so links the channel to a specific driver. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b

[PATCH v2 10/16] rpmsg: char: allow only one endpoint per device

2020-12-22 Thread Arnaud Pouliquen
Only one endpoint can be created per device, prevent from multi open. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 66e01b979e72..4b0674a2e3e9 100644 --- a

[PATCH v2 14/16] rpmsg: glink: add create and release rpmsg channel ops

2020-12-22 Thread Arnaud Pouliquen
Add the new ops introduced by the rpmsg_ns series and used by the rpmsg_ctrl driver to instantiate a new rpmsg channel. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/qcom_glink_native.c | 94 --- 1 file changed, 75 insertions(+), 19 deletions(-) diff --git a

[PATCH v2 15/16] rpmsg: smd: add create and release rpmsg channel ops

2020-12-22 Thread Arnaud Pouliquen
Add the new ops introduced by the rpmsg_ns series and used by the rpmsg_ctrl driver to instantiate a new rpmsg channel. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/qcom_smd.c | 57 ++-- 1 file changed, 49 insertions(+), 8 deletions(-) diff --git a

[PATCH v2 07/16] rpmsg: char: clean up rpmsg class

2020-12-22 Thread Arnaud Pouliquen
Suppress the management of the rpmsg class as attribute. It is already handled in /sys/bus rpmsg as specified in documentation/ABI/testing/sysfs-bus-rpmsg. This patch prepares the migration of the control device in rpmsg_ctrl. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 48

[PATCH v2 16/16] rpmsg: replace rpmsg_chrdev_register_device use

2020-12-22 Thread Arnaud Pouliquen
Replace rpmsg_chrdev_register_device by the new helper rpmsg_ctl_register_device to probe the new IOCTL interface. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/qcom_glink_native.c | 2 +- drivers/rpmsg/qcom_smd.c | 2 +- drivers/rpmsg/rpmsg_internal.h| 14 -- 3

[PATCH v2 13/16] rpmsg: virtio: probe the rpmsg_ctl device

2020-12-22 Thread Arnaud Pouliquen
Probe the rpmsg_ctl driver on virtio rpmsg bus creation. This provides the possibility to expose an ioctrl to create RPMsg channels. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 37 +++- 1 file changed, 36 insertions(+), 1 deletion(-) diff

[PATCH v2 04/16] rpmsg: ctrl: implement the ioctl function to create device

2020-12-22 Thread Arnaud Pouliquen
Implement the ioctl function that parses the list of rpmsg drivers registered to create an associated device. To be ISO user API, in a first step, the driver_override is only allowed for the RPMsg raw service, supported by the rpmsg_char driver. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg

[PATCH v2 05/16] rpmsg: ns: initialize channel info override field

2020-12-22 Thread Arnaud Pouliquen
By default driver_override should be 0 to avoid to force the channel creation with a specified name.The local variable is not initialized. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_ns.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg

[PATCH v2 08/16] rpmsg: char: make char rpmsg a rpmsg device without the control part

2020-12-22 Thread Arnaud Pouliquen
The RPMsg control part is migrated to the rpmsg_ctrl.c. Clean up the code associated to the support of the /dev/rpmsgctrl0 and update the driver to only manage the char devices as a RPMsg generic service. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 166

Re: [PATCH v3 09/15] remoteproc: Introduce function rproc_detach()

2020-12-08 Thread Arnaud POULIQUEN
+++ b/include/linux/remoteproc.h > @@ -656,6 +656,7 @@ rproc_of_resm_mem_entry_init(struct device *dev, u32 > of_resm_idx, size_t len, > > int rproc_boot(struct rproc *rproc); > void rproc_shutdown(struct rproc *rproc); > +int rproc_detach(struct rproc *rproc); > int rproc_se

Re: [PATCH v2 00/16] introduce generic IOCTL interface for RPMsg channels management

2021-01-14 Thread Arnaud POULIQUEN
Hi Mathieu, On 1/13/21 9:31 PM, Mathieu Poirier wrote: > Hi Arnaud, > > [...] > >> >> Arnaud Pouliquen (16): >> rpmsg: introduce RPMsg control driver for channel creation >> rpmsg: add RPMsg control API to register service >> rpmsg: add overr

Re: [Linux-stm32] [PATCH] rpmsg: char: return an error if device already open

2021-01-15 Thread Arnaud POULIQUEN
Hi Mathieu, On 1/14/21 8:05 PM, Mathieu Poirier wrote: > On Wed, Jan 06, 2021 at 02:37:14PM +0100, Arnaud Pouliquen wrote: >> The rpmsg_create_ept function is invoked when the device is opened. >> As only one endpoint must be created per device. It is not >> possible to

Re: [PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-24 Thread Arnaud POULIQUEN
Hi Mathieu, On 3/23/21 10:19 PM, Mathieu Poirier wrote: > Good day Arnaud, > > On Mon, Mar 22, 2021 at 10:26:51AM +0100, Arnaud Pouliquen wrote: >> From: Arnaud Pouliquen >> >> A mechanism similar to the shutdown mailbox signal is implemented to >> deta

[PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-03-23 Thread Arnaud Pouliquen
CREATE_EPT_IOCTL and RPMSG_DESTROY_EPT_IOCTL controls, is preserved. The next steps should be to correct this: Introduce the IOCTLs RPMSG_CREATE_DEV_IOCTL and RPMSG_DESTROY_DEV_IOCTL to instantiate the rpmsg devices [1]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523

[PATCH 1/7] rpmsg: char: Export eptdev create an destroy functions

2021-03-23 Thread Arnaud Pouliquen
provided as parameter in rpmsg_chrdev_create_eptdev, because the class is associated to the control part. Suggested-by: Mathieu Poirier Signed-off-by: Arnaud Pouliquen --- Update from [1]: - Directly export rpmsg_eptdev_destroy after renaming it. - use IS_REACHABLE instead of IS_ENABLED to

[PATCH 2/7] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-03-23 Thread Arnaud Pouliquen
Create the rpmsg_ctrl.c module and move the code related to the rpmsg_ctrldev device in this new module. Add the dependency between rpmsg_char and rpmsg_ctrl in the kconfig file. Signed-off-by: Arnaud Pouliquen --- update from [1]: - keep rpmsg_ctrldev prefix (no more functions and structures

[PATCH 3/7] rpmsg: Update rpmsg_chrdev_register_device function

2021-03-23 Thread Arnaud Pouliquen
prefix. The platform drivers are updated accordingly. Signed-off-by: Arnaud Pouliquen --- update from [1] - changelog update - no more initialize source and destination address to RPMSG_ADDR_ANY - rename rpmsg_ctrl_register_device in rpmsg_ctrldev_register_device - add virtio platform update [1

[PATCH 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device

2021-03-23 Thread Arnaud Pouliquen
A rpmsg char device allows to probe the endpoint device on a remote name service announcement. With this patch the /dev/rpmsgX interface is created either by a user application or by the remote firmware. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 58

[PATCH 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function

2021-03-23 Thread Arnaud Pouliquen
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns the rpmsg_eptdev context structure. This patch prepares the introduction of a rpmsg channel device for the char device. The rpmsg device will need a reference to the context. Signed-off-by: Arnaud Pouliquen --- update

[PATCH 7/7] rpmsg: char: Return error if user try to destroy a default endpoint.

2021-03-23 Thread Arnaud Pouliquen
he channel does not make sense. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 8064244f8f18..08670e94714a 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/dri

[PATCH 6/7] rpmsg: char: No dynamic endpoint management for the default one

2021-03-23 Thread Arnaud Pouliquen
Do not dynamically manage the default endpoint associated to the rpmsg device. The ept address must not change. This update is needed to manage the rpmsg-raw channel. In this case a default endpoint is used and its address must not change or been reused by another service. Signed-off-by: Arnaud

Re: [PATCH v5 08/16] rpmsg: glink: add sendto and trysendto ops

2021-03-05 Thread Arnaud POULIQUEN
Hi Mathieu, On 3/4/21 8:11 PM, Mathieu Poirier wrote: > On Fri, Feb 19, 2021 at 12:14:53PM +0100, Arnaud Pouliquen wrote: >> Implement the sendto ops to support the future rpmsg_char update for the >> vitio backend support. > > Add a new line, otherwise it is very easy to r

Re: [PATCH v5 13/16] rpmsg: char: introduce __rpmsg_chrdev_create_eptdev function

2021-03-05 Thread Arnaud POULIQUEN
On 3/4/21 7:55 PM, Mathieu Poirier wrote: > On Fri, Feb 19, 2021 at 12:14:58PM +0100, Arnaud Pouliquen wrote: >> Introduce the __rpmsg_chrdev_create_eptdev internal function that returns >> the rpmsg_eptdev context structure. >> This patch prepares the introduction of a

Re: [PATCH v5 15/16] rpmsg: char: no dynamic endpoint management for the default one

2021-03-05 Thread Arnaud POULIQUEN
n. Just for my information, is it a new rule? kernel documentation [1] gives a canonical subject and an example without capital letter. [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format > > On Fri, Feb 19, 2021 at 12:15:00PM +0100, A

Re: [PATCH v5 13/16] rpmsg: char: introduce __rpmsg_chrdev_create_eptdev function

2021-03-05 Thread Arnaud POULIQUEN
Hi Mathieu On 3/4/21 8:05 PM, Mathieu Poirier wrote: > On Fri, Feb 19, 2021 at 12:14:58PM +0100, Arnaud Pouliquen wrote: >> Introduce the __rpmsg_chrdev_create_eptdev internal function that returns >> the rpmsg_eptdev context structure. > > Add newlines between paragra

Re: [PATCH v2 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-31 Thread Arnaud POULIQUEN
On 3/30/21 4:41 PM, Rob Herring wrote: > On Mon, 22 Mar 2021 10:26:50 +0100, Arnaud Pouliquen wrote: >> Add the "detach" mailbox item, that allows to define a mailbox to >> send a IPCC signal to the remote processor on remoteproc detach action. >> >

[PATCH v4 2/2] remoteproc: stm32: add capability to detach

2021-03-31 Thread Arnaud Pouliquen
processor to restart in case of crash. Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier Tested-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 39 ++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/stm32_rproc.c

[PATCH v4 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-31 Thread Arnaud Pouliquen
. Applied and tested on Bjorn's "for_next" branch (2b81aa17008e) [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=447171 Arnaud Pouliquen (2): dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach remoteproc: stm32: add capability to detach

[PATCH v4 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-31 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen Reviewed-by: Rob Herring --- .../bindings/remoteproc/st,stm32-rproc.yaml | 11 +-- 1 file

Re: [PATCH v5 04/16] rpmsg: char: export eptdev create an destroy functions

2021-03-03 Thread Arnaud POULIQUEN
Hi Mathieu, On 3/2/21 6:57 PM, Mathieu Poirier wrote: > Good morning, > > I have started to review this set - comments will be staggered over several > days. > > On Fri, Feb 19, 2021 at 12:14:49PM +0100, Arnaud Pouliquen wrote: >> To prepare the split code relate

Re: [PATCH v5 05/16] rpmsg: char: dissociate the control device from the rpmsg class

2021-03-03 Thread Arnaud POULIQUEN
On 3/2/21 7:01 PM, Mathieu Poirier wrote: > On Fri, Feb 19, 2021 at 12:14:50PM +0100, Arnaud Pouliquen wrote: >> The RPMsg control device is a RPMsg device, it is already >> referenced in the RPMsg bus. There is only an interest to >> reference the ept char devices in the

Re: [PATCH v5 06/16] rpmsg: move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-03-03 Thread Arnaud POULIQUEN
On 3/2/21 7:35 PM, Mathieu Poirier wrote: > On Fri, Feb 19, 2021 at 12:14:51PM +0100, Arnaud Pouliquen wrote: >> Move the code related to the rpmsg_ctrl char device to the new >> rpmsg_ctrl.c module. >> Manage the dependency in the kconfig. >> >>

Re: [PATCH v5 11/16] rpmsg: virtio: register the rpmsg_ctrl device

2021-03-04 Thread Arnaud POULIQUEN
On 3/3/21 7:43 PM, Mathieu Poirier wrote: > On Fri, Feb 19, 2021 at 12:14:56PM +0100, Arnaud Pouliquen wrote: >> Instantiate the rpmsg_ioctl device on virtio RPMsg bus creation. > > s/rpmsg_ioctl/rpmsg_ctrl > > Now I understand what you meant in patch 05. > >>

[PATCH v2 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-22 Thread Arnaud Pouliquen
tested on Bjorn's "for_next" branch (2b81aa17008e) [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=447171 Arnaud Pouliquen (2): dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach remoteproc: stm32: add capability to detach

[PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-22 Thread Arnaud Pouliquen
From: Arnaud Pouliquen A mechanism similar to the shutdown mailbox signal is implemented to detach a remote processor. Upon detachment, a signal is sent to the remote firmware, allowing it to perform specific actions such as stopping RPMsg communication. The Cortex-M hold boot is also disabled

[PATCH v2 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-22 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen --- update from V1: Fix indentation error reported by 'make dt_binding_check'. --- .../bindings

RE: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes

2021-03-29 Thread Arnaud POULIQUEN
Hi, > -Original Message- > From: Pierre-Louis Bossart > Sent: vendredi 26 mars 2021 22:59 > To: alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart ; Arnaud POULIQUEN > ; Liam Girdwood ; > J

RE: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check

2021-03-29 Thread Arnaud POULIQUEN
> -Original Message- > From: Pierre-Louis Bossart > Sent: vendredi 26 mars 2021 22:59 > To: alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart ; Arnaud POULIQUEN > ; Liam Girdwood ; > Jarosl

Re: [PATCH v3 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-30 Thread Arnaud POULIQUEN
Hello Rob, Seems I made a mistake in my mailing list, you are not in... Please could you review the bindings? if it is easier for you i can resend the series. Thanks, Arnaud On 3/26/21 10:42 AM, Arnaud Pouliquen wrote: > Add the "detach" mailbox item, that allows to define a mailbo

[PATCH v3 2/2] remoteproc: stm32: add capability to detach

2021-03-26 Thread Arnaud Pouliquen
processor to restart in case of crash. Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier Tested-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 39 ++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/stm32_rproc.c

[PATCH v3 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-26 Thread Arnaud Pouliquen
on Bjorn's "for_next" branch (2b81aa17008e) [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=447171 Arnaud Pouliquen (2): dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach remoteproc: stm32: add capability to detach .../binding

[PATCH v3 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-26 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen --- No Update from V2. Update from V1: Fix indentation error reported by 'make dt_binding_check'

Re: [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-04-13 Thread Arnaud POULIQUEN
Hello Mathieu, On 4/12/21 10:02 PM, Mathieu Poirier wrote: > On Tue, Mar 23, 2021 at 01:27:30PM +0100, Arnaud Pouliquen wrote: >> This series is the second step in the division of the series [1]: >> "Introducing a Generic IOCTL Interface for RPMsg Channel Management".

[PATCH v2 3/7] rpmsg: Update rpmsg_chrdev_register_device function

2021-04-13 Thread Arnaud Pouliquen
prefix. The platform drivers are updated accordingly. Signed-off-by: Arnaud Pouliquen --- update from v1 - move the rename of the rpmsg_ctrl driver from previous patch to this one. --- drivers/rpmsg/qcom_glink_native.c | 2 +- drivers/rpmsg/qcom_smd.c | 2 +- drivers/rpmsg/rpmsg_ctrl.c

[PATCH v2 7/7] rpmsg: char: Return error if user tries to destroy a default endpoint.

2021-04-13 Thread Arnaud Pouliquen
he channel does not make sense. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index fa59abfa8878..d4316bb904f2 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/dri

[PATCH v2 1/7] rpmsg: char: Export eptdev create an destroy functions

2021-04-13 Thread Arnaud Pouliquen
provided as parameter in rpmsg_chrdev_create_eptdev, because the class is associated to the control part. Suggested-by: Mathieu Poirier Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 19 +-- drivers/rpmsg/rpmsg_char.h | 50 ++ 2

[PATCH v2 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-04-13 Thread Arnaud Pouliquen
k.kernel.org/project/linux-remoteproc/list/?series=453805 [2]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523 Arnaud Pouliquen (7): rpmsg: char: Export eptdev create an destroy functions rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_

[PATCH v2 6/7] rpmsg: char: No dynamic endpoint management for the default one

2021-04-13 Thread Arnaud Pouliquen
Do not dynamically manage the default endpoint associated to the rpmsg device. The ept address must not change. This update is needed to manage the rpmsg-raw channel. In this case a default endpoint is used and its address must not change or been reused by another service. Signed-off-by: Arnaud

[PATCH v2 2/7] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-04-13 Thread Arnaud Pouliquen
Create the rpmsg_ctrl.c module and move the code related to the rpmsg_ctrldev device in this new module. Add the dependency between rpmsg_char and rpmsg_ctrl in the kconfig file. Signed-off-by: Arnaud Pouliquen --- update from v1: - keep "rpmsg_chrdev" driver name in rpmsg_ctrl, driv

[PATCH v2 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function

2021-04-13 Thread Arnaud Pouliquen
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns the rpmsg_eptdev context structure. This patch prepares the introduction of a rpmsg channel device for the char device. The rpmsg device will need a reference to the context. Signed-off-by: Arnaud Pouliquen --- update

[PATCH v2 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device

2021-04-13 Thread Arnaud Pouliquen
A rpmsg char device allows to probe the endpoint device on a remote name service announcement. With this patch the /dev/rpmsgX interface is created either by a user application or by the remote firmware. Signed-off-by: Arnaud Pouliquen --- update from V1: - add missing unregister_rpmsg_driver

Re: [PATCH v4 2/2] remoteproc: stm32: add capability to detach

2021-04-14 Thread Arnaud POULIQUEN
Hello Bjorn On 4/13/21 11:34 PM, Bjorn Andersson wrote: > On Wed 31 Mar 02:33 CDT 2021, Arnaud Pouliquen wrote: > >> A mechanism similar to the shutdown mailbox signal is implemented to >> detach a remote processor. >> >> Upon detachment, a signal is sent to th

[PATCH] remoteproc: stm32: fix mbox_send_message call

2021-04-20 Thread Arnaud Pouliquen
comments are removed because rproc should not have to deal with the behavior of the mailbox frame. Reported-by: Bjorn Andersson Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc

Re: [PATCH v5 00/16] introduce a generic IOCTL interface for RPMsg channels management

2021-03-17 Thread Arnaud POULIQUEN
On 2/19/21 12:14 PM, Arnaud Pouliquen wrote: > This series restructures the RPMsg char driver to decorrelate the control > part and to > create a generic RPMsg ioctl interface compatible with other RPMsg services. > > The V4 and V5 fix compilation issues reported by the ke

[PATCH 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-18 Thread Arnaud Pouliquen
08e) [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=447171 Arnaud Pouliquen (2): dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach remoteproc: stm32: add capability to detach .../bindings/remoteproc/st,stm32-rproc.yaml | 11 +- dri

[PATCH 2/2] remoteproc: stm32: add capability to detach

2021-03-18 Thread Arnaud Pouliquen
From: Arnaud Pouliquen A mechanism similar to the shutdown mailbox signal is implemented to detach a remote processor. Upon detachment, a signal is sent to the remote firmware, allowing it to perform specific actions such as stopping RPMsg communication. The Cortex-M hold boot is also disabled

[PATCH 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-18 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen --- .../bindings/remoteproc/st,stm32-rproc.yaml | 11 +-- 1 file changed, 9 insertions(+), 2

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-17 Thread Arnaud POULIQUEN
On 11/17/20 5:03 PM, Guennadi Liakhovetski wrote: > On Tue, Nov 17, 2020 at 12:42:30PM +0100, Arnaud POULIQUEN wrote: > > [snip] > >> diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c >> index 5bda7cb44618..80c2cc23bada 100644 >> --- a/drivers/rpm

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-17 Thread Arnaud POULIQUEN
On 11/17/20 5:58 PM, Guennadi Liakhovetski wrote: > On Tue, Nov 17, 2020 at 05:44:05PM +0100, Arnaud POULIQUEN wrote: >> >> >> On 11/17/20 5:03 PM, Guennadi Liakhovetski wrote: >>> On Tue, Nov 17, 2020 at 12:42:30PM +0100, Arnaud POULIQUEN wrote: >>> &

Re: [PATCH v3 09/15] remoteproc: Introduce function rproc_detach()

2020-12-09 Thread Arnaud POULIQUEN
On 12/9/20 1:53 AM, Mathieu Poirier wrote: > On Tue, Dec 08, 2020 at 07:35:18PM +0100, Arnaud POULIQUEN wrote: >> Hi Mathieu, >> >> >> On 11/26/20 10:06 PM, Mathieu Poirier wrote: >>> Introduce function rproc_detach() to enable the remoteproc >>> co

<    1   2   3   4   5   6   7   >