Re: [PATCH v4 4/5] mmc: core: Add sdio_retune_hold_now() and sdio_retune_release()

2019-06-14 Thread Arend Van Spriel
On June 14, 2019 6:38:51 PM Doug Anderson wrote: Hi, On Fri, Jun 14, 2019 at 5:10 AM Ulf Hansson wrote: On Fri, 14 Jun 2019 at 01:42, Douglas Anderson wrote: > > We want SDIO drivers to be able to temporarily stop retuning when the > driver knows that the SDIO card is not in a state where

Re: [PATCH v4 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-17 Thread Arend Van Spriel
s all traffic to the card until it's done. Let's disable retuning around the commands we expect might fail. Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") Reviewed-by: Arend van Spriel Signed-off-by: Douglas Anderson

Re: [PATCH v4 5/5] brcmfmac: sdio: Don't tune while the card is off

2019-06-17 Thread Arend Van Spriel
at least with a few retries. The term "sleep command" is a bit confusing. There actually is a CMD14 defined in the eSD spec, but that is not what we are using (unless we program the chip to do so) here. It is simply a specific register access using CMD52. Apart from that Reviewed-b

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Arend Van Spriel
seems we are missing out again? On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > "Tobin C. Harding" writes: > >> Except one: do you know off the top of your head of a canonical >> implementation of a softmac wi-fi driver. > > I'll suggest taking a look at the ath9k driver :) Looking at ks701

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Arend Van Spriel
On 3-4-2017 23:39, Tobin C. Harding wrote: > On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: >> seems we are missing out again? > > Sorry, I don't understand what this comment means? My bad. I had to reset my email account in thunderbird and now it needs t

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-06-30 Thread Arend van Spriel
On 23-06-17 23:53, Luis R. Rodriguez wrote: > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: >>> Since no upstream delta is needed for firmwared I'd like to first encourage >>> evaluating the above.

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

2017-07-11 Thread Arend van Spriel
On 10-07-17 19:02, Russell Joyce wrote: >> 1) I think most of it should be some cfg80211 shareable code. > > I’m not sure exactly what you mean by this, could you please clarify? What I think Rafał is saying is that it would be better to have this code in cfg80211 so other drivers including mac80

Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id.

2017-07-17 Thread Arend van Spriel
On 17-07-17 20:16, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. Acked-by: Arend van Spriel > Signed-off-by:

[PATCH 0/3] drivers: support for sysfs initiated coredump

2018-02-21 Thread Arend van Spriel
than the dev_coredump api. The first 2 patches apply to the master branch of the wireless-drivers-next repository. The last patch applies to the master branch of the bluetooth-next. Arend van Spriel (3): brcmfmac: add support for sysfs initiated coredump mwifiex: support sysfs initiated device

[PATCH 3/3] btmrvl: support sysfs initiated firmware coredump

2018-02-21 Thread Arend van Spriel
-by: Arend van Spriel --- drivers/bluetooth/btmrvl_debugfs.c | 31 --- drivers/bluetooth/btmrvl_drv.h | 2 -- drivers/bluetooth/btmrvl_main.c| 6 -- drivers/bluetooth/btmrvl_sdio.c| 18 -- 4 files changed, 12 insertions(+), 45 deletion

[PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-21 Thread Arend van Spriel
ned-off-by: Arend van Spriel --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 31 +- drivers/net/wireless/marvell/mwifiex/pcie.c| 19 ++-- drivers/net/wireless/marvell/mwifiex/sdio.c| 13 +++ drivers/net/wireless/marvell/mwifiex/usb.

[PATCH 1/3] brcmfmac: add support for sysfs initiated coredump

2018-02-21 Thread Arend van Spriel
Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 + drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h| 2 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 7 ++

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-22 Thread Arend van Spriel
On 2/21/2018 11:59 PM, Brian Norris wrote: On Wed, Feb 21, 2018 at 11:50:19AM +0100, Arend van Spriel wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the

[PATCH] drivers: base: add description for .coredump() callback

2018-02-09 Thread Arend van Spriel
Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added a new callback in struct device_driver, but not a kerneldoc description so here it is. Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops") Signed-off-by: Arend van Spriel --- include/linux/de

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-23 Thread Arend van Spriel
+ Johannes (for devcoredump documentation question). On 2/22/2018 8:35 PM, Brian Norris wrote: Hi Arend, On Thu, Feb 22, 2018 at 01:17:56PM +0100, Arend van Spriel wrote: On 2/21/2018 11:59 PM, Brian Norris wrote: On Wed, Feb 21, 2018 at 11:50:19AM +0100, Arend van Spriel wrote: Since

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-26 Thread Arend van Spriel
On 2/26/2018 11:06 PM, Brian Norris wrote: Hi, On Fri, Feb 23, 2018 at 2:51 AM, Johannes Berg wrote: On Fri, 2018-02-23 at 11:39 +0100, Arend van Spriel wrote: Well, that depends on the eye of the beholder I guess. From user-space perspective it is asynchronous regardless. A write access to

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Arend van Spriel
+ Johannes On 22-11-17 18:43, Florian Fainelli wrote: Hi, (sorry for the cross post) I am at v4.14-12995-g0c86a6bd85ff and just met the following, attached is my .config file. Is this a known problem? Thanks! [1.798714] cfg80211: Loading compiled-in X.509 certificates for regulatory datab

[PATCH 2/2] drivers: base: add coredump driver ops

2017-12-19 Thread Arend van Spriel
From: Arend van Spriel This adds the coredump driver operation. When the driver defines it a coredump file is added in the sysfs folder of the device upon driver binding. The file is removed when the driver is unbound. User-space can trigger a coredump for this device by echo'ing to the cor

[PATCH 1/2] sysfs: add attribute specification for /sysfs/devices/.../coredump

2017-12-19 Thread Arend van Spriel
From: Arend van Spriel This patch adds the specification for /sysfs/devices/.../coredump which allows user-space to trigger a device coredump obtaining binary data from the device for (fault) analysis. It relies on CONFIG_DEV_COREDUMP being enabled. Signed-off-by: Arend van Spriel

[PATCH 0/2] sysfs: allow user-space request for devcoredump

2017-12-19 Thread Arend van Spriel
From: Arend van Spriel Since commit 833c95456a70 ("device coredump: add new device coredump class") device drivers have a unified way to provide binary data obtained from a failing_device to user-space. However, there may be use-cases in which the driver has no reason to obtain the

[PATCH] scripts: tags: change find_other_sources() for include folders

2017-12-15 Thread Arend van Spriel
cp/include ./drivers/gpu/drm/amd/display/include ./drivers/gpu/drm/amd/include ./drivers/gpu/drm/nouveau/include This changes the find command in the find_other_sources() function to include those using the -path option. Signed-off-by: Arend van Spriel --- scripts/tags.sh | 2 +- 1 fi

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

2017-05-09 Thread Arend Van Spriel
On 9-5-2017 7:33, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> The name of an array used by itself will always return the array's address. >> So these tests will always evaluate as false and therefore the _return_ >> will never be executed. >> >> Signed-off-by: Gustavo A. R. Silva > >

Re: [PATCH] wcn36xx: Close SMD channel on device removal

2017-05-10 Thread Arend van Spriel
On 5/10/2017 1:03 AM, Bjorn Andersson wrote: On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: Bjorn Andersson writes: The SMD channel is not the primary WCNSS channel and must explicitly be closed as the device is removed, or the channel will already by open on a subsequent probe call in e.g.

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Arend van Spriel
On 5/30/2017 1:20 PM, Arnd Bergmann wrote: An unknown change in the kernel headers caused a build regression in an MTD partition driver: In file included from drivers/mtd/bcm47xxpart.c:12:0: include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem': include/linux/bcm47xx_nvram.h:2

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Arend van Spriel
On 31-05-17 12:26, Kalle Valo wrote: > Jia-Ju Bai writes: > >> The driver may sleep under a spin lock, and the function call path is: >> b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) >> b43legacy_synchronize_irq >> synchronize_irq --> may sleep >> >> To fix it, the l

Re: [PATCH] bcm47xx: fix build regression

2017-05-31 Thread Arend van Spriel
On 31-05-17 18:31, Paul E. McKenney wrote: > On Wed, May 31, 2017 at 03:34:57PM +0200, Arnd Bergmann wrote: >> On Wed, May 31, 2017 at 3:12 PM, Paul E. McKenney >> wrote: >>> On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: >>>> On Wed, May 31

Re: BRCMFMAC OOB interrupt problem

2017-06-01 Thread Arend van Spriel
On 01-06-17 09:44, Hegr, Jiri wrote: > Dears, > We use small WiFi evaluation board WM-BN-BM-04_EVB_V1.2 with BCM43362 chip > (Broadcom). > This board is connected to OMAP-L138 via SDIO interface with Linux 4.9.10 > containing WiFi driver brcmfmac. > Our problem is in OOB interrupt. The driver (an

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-16 Thread Arend Van Spriel
On 16-5-2017 1:13, Luis R. Rodriguez wrote: > On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: >> try again.. replacing email address from Michał >> On 12-5-2017 22:55, Arend Van Spriel wrote: >>> Let me explain the idea to refresh your memory (and mine)

Re: [PATCH v2] brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain

2017-06-10 Thread Arend van Spriel
On 03-06-17 17:36, Andy Shevchenko wrote: > On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote: >> An earlier change to this function (3bdae810721b) fixed a leak in the >> case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the >> glom_skb buffer, used for emulating a scattering read

Re: [PATCH v2] brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain

2017-06-11 Thread Arend van Spriel
On 11-06-17 02:18, Peter Housel wrote: > >> On Jun 10, 2017, at 12:27 PM, Arend van Spriel >> wrote: >> >> On 03-06-17 17:36, Andy Shevchenko wrote: >>> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel wrote: >>>> An earlier change to this funct

Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important

2017-06-12 Thread Arend van Spriel
On 6/11/2017 11:30 PM, Emil Lenngren wrote: 2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach : On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote: On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote: "Jason A. Donenfeld" writes: Whenever you're comparing two MACs, it's important to do this using

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-03 Thread Arend Van Spriel
On 3-1-2017 18:59, Luis R. Rodriguez wrote: > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >> >> Right question is "should we solve it without user-space help"? >> >> Answer is no, too. Way too complex. Yes, it would be nice if hardware >> was designed in such a way that getting

Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

2017-06-13 Thread Arend van Spriel
On 13-06-17 12:23, Enric Balletbo Serra wrote: > Hello Kalle, > > 2017-06-13 7:54 GMT+02:00 Kalle Valo : >> Enric Balletbo i Serra wrote: >> >>> When request firmware fails, brcmf_ops_sdio_remove is being called and >>> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle >>>

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-03 Thread Arend van Spriel
it will end up in the git commit message. When done you may also add my acknowledgement, ie.: Acked-by: Arend van Spriel Regards, Arend

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-04 Thread Arend van Spriel
On 10/4/2017 11:03 AM, Icenowy Zheng wrote: 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到: Icenowy Zheng writes: Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to use an out-of-band interrupt pin instead of SDIO in-band interrupt. Add the device tree binding of this

Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size

2017-09-22 Thread Arend van Spriel
data bss dec hex filename 39482564 0 400469c6e phy_cmn.o After text data bss dec hex filename 39326620 0 399469c0a phy_cmn.o (gcc 6.3.0, x86-64) Acked-by: Arend van Spriel Signed-off-by: Colin Ia

Re: [PATCH V5 2/2] brcmfmac: don't warn user about NVRAM if fallback to the platform one succeeds

2017-08-01 Thread Arend van Spriel
t; let's try our fallback code first. If that fails as well, then it's a > right moment to print an error. > > This should reduce amount of false reports from users seeing this > warning while having wireless working perfectly fine with the platform > NVRAM. Reviewed-by

Re: [PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

2017-12-07 Thread Arend van Spriel
On 12/7/2017 11:20 AM, Colin King wrote: From: Colin Ian King Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine size of the array. Improvement suggested by coccinelle. Acked-by: Arend van Spriel Signed-off-by: Colin Ian King --- drivers/net/wireless/broadcom/brcm80211

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-30 Thread Arend Van Spriel
On 29-9-2016 23:57, Rafał Miłecki wrote: > On 27 September 2016 at 11:24, Arend Van Spriel > wrote: >> On 26-9-2016 14:38, Rafał Miłecki wrote: >>> On 26 September 2016 at 14:13, Rafał Miłecki wrote: >>>> On 26 September 2016 at 13:46, Arend Van Spriel >

Re: [v2] bcma: use of_dma_configure() to set initial dma mask

2016-09-05 Thread Arend Van Spriel
On 5-9-2016 17:26, Arnd Bergmann wrote: > On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote: >> Arnd Bergmann wrote: >>> While fixing another bug, I noticed that bcma manually sets up >>> a dma_mask pointer for its child devices. We have a generic >>> helper for that now, which sho

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

2016-08-15 Thread Arend Van Spriel
On 15-8-2016 13:52, Rafał Miłecki wrote: > On 15 August 2016 at 12:57, Kalle Valo wrote: >> Rafał Miłecki writes: >> Signed-off-by: Masami Hiramatsu >>> >>> Fixes: a63b09872c1d ("brcmfmac: delete interface directly in code that sent >>> fw request") >>> Acked-by: Rafał Miłecki >>> >>> K

Re: [BUGFIX PATCH 2/2] brcmfmac: Change vif_event_lock to spinlock

2016-08-15 Thread Arend Van Spriel
x3f0 > [ 186.678741] [] ? mntput_no_expire+0x5/0x3f0 > [ 186.678743] [] ? mntput+0x24/0x40 > [ 186.678744] [] ? __fput+0x190/0x200 > [ 186.678746] [] __sys_sendmsg+0x45/0x80 > [ 186.678748] [] SyS_sendmsg+0x12/0x20 > [ 186.678749] [] entry_SYSCALL_64_fast

Re: [PATCH 0/3] hostap: Fine-tuning for a few functions

2016-08-20 Thread Arend van Spriel
On 20-08-16 18:43, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:35:43 +0200 > > A few update suggestions were taken into account > from static source code analysis. Is it worth touching this old stuff especially when you are not making any functional changes. Rega

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Arend Van Spriel
On 22-8-2016 15:03, Nicolas Iooss wrote: > Hello, > > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it and tell me what I may have > done wrong? Nothing. People went on vacation :-) > Thanks, > Nicolas > > On 05/08/16 22:34, Nicolas

[tip:efi/core] firmware/efi: Add NULL pointer checks in efivars API functions

2018-11-30 Thread tip-bot for Arend van Spriel
Commit-ID: ab2180a15ce54739fed381efb4cb12e78dfb1561 Gitweb: https://git.kernel.org/tip/ab2180a15ce54739fed381efb4cb12e78dfb1561 Author: Arend van Spriel AuthorDate: Thu, 29 Nov 2018 18:12:27 +0100 Committer: Ingo Molnar CommitDate: Fri, 30 Nov 2018 09:06:32 +0100 firmware/efi: Add

<    1   2   3   4   5   6