Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions

2015-01-07 Thread Arend van Spriel
On 01/07/15 07:29, Julia Lawall wrote: On Wed, 7 Jan 2015, Rickard Strandqvist wrote: 2015-01-05 12:06 GMT+01:00 Arend van Spriel: On 01/05/15 11:49, Kalle Valo wrote: Rickard Strandqvist writes: As I hope you can see I have made some changes regarding the subject-line. Thought it was

Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest

2015-01-07 Thread Arend van Spriel
On 01/07/15 23:16, Johannes Berg wrote: On Wed, 2015-01-07 at 20:18 +0100, Giel van Schijndel wrote: IMO the aligned block of code has the significant advantage of taking advantage of humans' ability to spot things that break a pattern. Which in this case becomes *very* visible when properly al

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-12 Thread Arend van Spriel
twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel Acked-by: Sergei Shtylyov Signed-off-by: Zhonghui Fu This patch needs to be rebased. Kalle, Please drop this one. Regards, Arend --- drivers/net/wireless/brcm80211

Re: [Patch v5 2/2] gpio: Document GPIO hogging mechanism

2015-01-12 Thread Arend van Spriel
On 01/12/15 11:20, Linus Walleij wrote: On Fri, Dec 19, 2014 at 9:07 PM, Benoit Parrot wrote: Add GPIO hogging documentation to gpio.txt Signed-off-by: Benoit Parrot Reviewed-by: Alexandre Courbot This is starting to look good ... + line_b { + gpio-hog;

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-12 Thread Arend van Spriel
lines above are not needed. WiFi chip has 2 SDIO functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel Acked-by: Sergei Shtylyov Signed-off-by: Zhonghui Fu --- drivers/net/wireless

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/17/15 00:42, Ray Jui wrote: [...] +/* + * Can be expanded in the future if more interrupt status bits are utilized + */ +#define ISR_MASK (1<< IS_M_START_BUSY_SHIFT) + +static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data) +{ + struct bcm_iproc_i2c_dev *iproc_i2c = data; +

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote: On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote: On 01/17/15 00:42, Ray Jui wrote

Re: [PATCH v5 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-18 Thread Arend van Spriel
On 01/18/15 12:56, Uwe Kleine-König wrote: Hello, On Sun, Jan 18, 2015 at 12:46:51PM +0100, Arend van Spriel wrote: On 01/18/15 12:17, Uwe Kleine-König wrote: Hello Wolfram, On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote: On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Arend van Spriel
On 01/27/15 12:48, Alexander Holler wrote: It's an interesting detail, so inform the user about it. Signed-off-by: Alexander Holler --- drivers/mmc/core/bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index 8a1f124..4a60028 100644

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Arend van Spriel
On 01/27/15 18:38, Alexander Holler wrote: Am 27.01.2015 um 18:24 schrieb Steven Rostedt: For most people a message in dmesg is not very useful. What you are asking for is to print a characteristic of a device. Something that someone might want to check much later in boot, where, as Boris state

Re: [PATCH 5/5] ARM: dts: exynos5250-snow: Enable wifi power-on

2015-01-28 Thread Arend van Spriel
On 01/28/15 11:10, Javier Martinez Canillas wrote: The Snow board has a MMC/SDIO wifi chip that is always powered but it needs a power sequence involving a reset (active low) and an enable (active high) pins. Both pins are marked as active low since the MMC simple power sequence driver asserts th

Re: Broadcom 43340 module on iMX6DL

2015-04-23 Thread Arend van Spriel
On 04/23/15 20:10, John Tobias wrote: Hello Guys, I am trying to use the bcmdhd wifi driver 43340 module on iMX6DL processor using kernel Freescale GA (3.10.53). I am having an issue with the sdio registration. I would like to know if anyone here had the same issue and how did you solve it?.

Re: Broadcom 43340 module on iMX6DL

2015-04-23 Thread Arend van Spriel
log says: chip:0xa94c rev:0x2 I will have to check whether that is correct revision for this firmware. I can check. You could try the brcmfmac4334-sdio.bin file instead. All bets are off, but it can not get worse. ;-) Gr. AvS Regards, John On Thu, Apr 23, 2015 at 11:39 AM, Arend van Spr

Re: Broadcom 43340 module on iMX6DL

2015-04-24 Thread Arend van Spriel
/ Regards, John On Thu, Apr 23, 2015 at 5:59 PM, John Tobias wrote: Hi John, Is it possible to have a copy of the firmware for 43340?. Regards, John On Thu, Apr 23, 2015 at 5:57 PM, John Stultz wrote: On Thu, Apr 23, 2015 at 12:00 PM, Arend van Spriel wrote: By the name of the file I

Re: Broadcom 43340 module on iMX6DL

2015-04-24 Thread Arend van Spriel
On 04/24/15 02:57, John Stultz wrote: On Thu, Apr 23, 2015 at 12:00 PM, Arend van Spriel wrote: By the name of the file I suspected you did. Personally, I verified the firmware works on 43341. John Stultz tested both 43340 and 43341 with this firmware. Minor correction here, I only tested on

Re: Broadcom 43340 module on iMX6DL

2015-04-24 Thread Arend van Spriel
your device. Regards, Arend Regards, John On Fri, Apr 24, 2015 at 1:20 AM, Arend van Spriel wrote: On 04/24/15 03:04, John Tobias wrote: Btw, where I could get a copy of the latest driver?. The open-source bcmdhd is in AOSP [1]. I would stick to the android release branch you are

Re: Broadcom 43340 module on iMX6DL

2015-04-24 Thread Arend van Spriel
You need a kernel repo. There are some on the site I referred to, but you may need to contact Freescale whether they provide it publicly like on github or so. Regards, Arend Regards, John On Fri, Apr 24, 2015 at 11:14 AM, Arend van Spriel wrote: On 04/24/15 19:49, John Tobias wrote: Hi

Re: Broadcom 43340 module on iMX6DL

2015-04-25 Thread Arend van Spriel
On 04/24/15 21:03, Arend van Spriel wrote: On 04/24/15 20:24, John Tobias wrote: Hi Arend, Apologize for the confusion. I am asking the repo for the device driver for 43340. Looking at the link you sent, it's more userspace support and didn't see the device driver there... cra

Re: [PATCH 2/2] brcmfmac: keep WiFi chip's power during system suspension

2015-04-27 Thread Arend van Spriel
On 04/27/15 07:06, Fu, Zhonghui wrote: Need to keep the power supply for WiFi chip during system suspension. Otherwise, the context of WiFi chip will be lost. I already submitted a patch doing exactly the same thing [1] Regards, Arend [1] https://patchwork.kernel.org/patch/6217391/ Signed-o

Re: [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac driver

2015-04-27 Thread Arend van Spriel
On 04/27/15 07:00, Fu, Zhonghui wrote: ACPI will manage WiFi chip's power state during suspend/resume process on some tablet platforms(such as ASUS T100TA). This is not supported by brcmfmac driver now, and the context of WiFi chip will be damaged after resume. This patch disconnects the relation

Re: [PATCH] brcmsmac: Move each system tracepoints to their own header

2015-04-08 Thread Arend van Spriel
#undef TRACE_SYSTEM #define TRACE_SYSTEM brcmsmac_msg Unfortunately, this broke new code in the ftrace infrastructure. Moving each of these TRACE_SYSTEMs into their own trace file with just one TRACE_SYSTEM per file fixes the issue. Cc: Arend van Spriel All right. Go ahead and change Cc: into

Re: [PATCH v1 0/6] module params: few simplifications

2015-04-21 Thread Arend van Spriel
On 04/21/15 01:30, Luis R. Rodriguez wrote: Suspect the subject line is screwed up here and should have been "[PATCH v1 1/6] ". Regards, Arend Most code already uses consts for the struct kernel_param_ops, sweep the kernel for the last offending stragglers. Other than include/linux/modul

Re: linux-next: build failure after merge of the wireless-drivers-next tree

2015-05-27 Thread Arend van Spriel
26 for today. Crap. struct acpi_device details are only known when CONFIG_ACPI is set. The attached patch should fix the issue. Regards, Arend >From fd56b4446c613ceec15c11758ed817d13efb9bba Mon Sep 17 00:00:00 2001 From: Arend van Spriel Date: Wed, 27 May 2015 10:48:46 +0200 Subject: [PATCH]

Re: Interaction issue of intel wifi and broadcom bluetooth - it appears that nobody feels responsible for doing something

2015-06-05 Thread Arend van Spriel
+ Marcel, wireless list, and bt list. On 06/05/15 07:12, Jonas Thiem wrote: Hi Jeremiah, thanks for responding! I did have my mobile phone very nearby also connected to the bluetooth headphones while my laptop was still using 11n wifi. I didn't have any noticeable issues with bluetooth there.

Re: [PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

2018-04-05 Thread Arend van Spriel
Acked-by: Arend van Spriel Signed-off-by: Joe Perches --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 -- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 -- drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c | 8 3 files changed, 4 inser

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-04-05 Thread Arend van Spriel
On 4/5/2018 3:10 PM, Kalle Valo wrote: Ulf Hansson writes: On 20 March 2018 at 10:55, Kalle Valo wrote: Arend van Spriel writes: If I get it right, you mean something like this: mmc3: mmc@1c12000 { ... broken-sg-support; sd-head-align = 4; sd-sgentry-align

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

2018-05-28 Thread Arend van Spriel
On 5/28/2018 9:50 AM, Michael Trimarchi wrote: Watchdog need to be stopped in brcmf_sdio_remove to avoid i The system is going down NOW! [ 1348.110759] Unable to handle kernel NULL pointer dereference at virtual address 02f8 Sent SIGTERM to all processes [ 1348.121412] Mem abort info: [ 1348

Re: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-02 Thread Arend Van Spriel
Op 2 maart 2019 04:52:46 schreef "David R. Bergstein" : Larry, Sorry about all these extra replies.  Shortly after I sent my last message my access point started recognizing the connection as 802.11ac with PHY Rate / Modulation Rate of 866.6 Mbps.  What is somewhat misleading is the informatio

Re: [PATCH v2] brcmfmac: add support for CQM RSSI notifications

2021-01-19 Thread Arend Van Spriel
On 1/15/2021 3:57 PM, Alvin Šipraga wrote: Hi Arend, On 1/15/21 3:10 PM, Arend Van Spriel wrote: + Johannes - netdevs On 1/14/2021 5:36 PM, 'Alvin Šipraga' via BRCM80211-DEV-LIST,PDL wrote: Add support for CQM RSSI measurement reporting and advertise the NL80211_EXT_FEATURE_CQM

Re: [PATCH] brcmfmac: add support for CQM RSSI notifications

2021-01-14 Thread Arend van Spriel
On 12-01-2021 12:13, 'Alvin Šipraga' via BRCM80211-DEV-LIST,PDL wrote: Add support for CQM RSSI measurement reporting and advertise the NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace supplicant such as iwd to be notified of changes in the RSSI for roaming and signal monitorin

Re: [PATCH v2 2/2] brcmfmac: support parse country code map from DT

2021-04-15 Thread Arend Van Spriel
Guo Reviewed-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmfmac/of.c | 57 ++- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c index a7554265f

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-12 Thread Arend van Spriel
On 08-04-2021 13:30, Shawn Guo wrote: Add optional brcm,ccode-map property to support translation from ISO3166 country code to brcmfmac firmware country code and revision. Reviewed-by: Arend van Spriel Signed-off-by: Shawn Guo --- .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-12 Thread Arend van Spriel
des table. Support populate country_codes table by parsing the mapping from DT. comment below, but you may add... Reviewed-by: Arend van Spriel Signed-off-by: Shawn Guo --- .../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++ 1 file changed, 53 insertions(+) diff --gi

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-12 Thread Arend van Spriel
On 08-04-2021 13:30, Shawn Guo wrote: With any regulatory domain requests coming from either user space or 802.11 IE (Information Element), the country is coded in ISO3166 standard. It needs to be translated to firmware country code and revision with the mapping info in settings->country_codes t

Re: [PATCH] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

2021-04-12 Thread Arend van Spriel
On 07-03-2021 12:35, Konrad Dybcio wrote: Add support for BCM43596 dual-band AC chip, found in SONY Xperia X Performance, XZ and XZs smartphones (and *possibly* other devices from other manufacturers). The chip doesn't require any special handling and seems to work just fine OOTB. PCIe IDs taken

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-13 Thread Arend van Spriel
On 13-04-2021 09:45, Shawn Guo wrote: On Mon, Apr 12, 2021 at 10:09:38AM +0200, Arend van Spriel wrote: On 08-04-2021 13:30, Shawn Guo wrote: With any regulatory domain requests coming from either user space or 802.11 IE (Information Element), the country is coded in ISO3166 standard. It

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-13 Thread Arend van Spriel
On 09-04-2021 20:46, Rob Herring wrote: On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote: Add optional brcm,ccode-map property to support translation from ISO3166 country code to brcmfmac firmware country code and revision. Signed-off-by: Shawn Guo --- .../devicetree/bindings/net/wir

Re: [PATCH v2] brcmfmac: add support for CQM RSSI notifications

2021-02-08 Thread Arend Van Spriel
and signal monitoring purposes. Reviewed-by: Arend van Spriel Signed-off-by: Alvin Šipraga --- v1 -> v2: - clarify firmware behaviour in a comment - fix detection of upper bound RSSI transition - improve clamping of min/max RSSI values - remove unnecessary check on last RSSI value --- .../broad

Re: [PATCH v2] brcmfmac: add support for CQM RSSI notifications

2021-01-15 Thread Arend Van Spriel
+ Johannes - netdevs On 1/14/2021 5:36 PM, 'Alvin Šipraga' via BRCM80211-DEV-LIST,PDL wrote: Add support for CQM RSSI measurement reporting and advertise the NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace supplicant such as iwd to be notified of changes in the RSSI for roami

Re: [PATCH v2] brcmfmac: add support for CQM RSSI notifications

2021-01-15 Thread Arend van Spriel
On 1/15/2021 3:51 PM, Andrew Zaborowski wrote: On Fri, 15 Jan 2021 at 15:12, Arend Van Spriel wrote:> + Johannes - netdevs On 1/14/2021 5:36 PM, 'Alvin Šipraga' via BRCM80211-DEV-LIST,PDL wrote: Add support for CQM RSSI measurement reporting and

combine per-cpu trace files

2014-02-24 Thread Arend van Spriel
Hi Steven, Regarding trace-cmd I have a question about the trace files. While debugging an driver issue I had trace-cmd recording driver events on the target system until it crashed and I had to power down the machine. Now I have three trace-cmd files: trace.dat, trace.cpu1 and trace.cpu2. trace-c

Re: combine per-cpu trace files

2014-02-24 Thread Arend van Spriel
On 02/24/2014 02:36 PM, Steven Rostedt wrote: > On Mon, 24 Feb 2014 13:07:50 +0100 > Arend van Spriel wrote: > >> Hi Steven, >> >> Regarding trace-cmd I have a question about the trace files. While >> debugging an driver issue I had trace-cmd recording driver eve

Re: [PATCH] ARM: tegra: add device tree for SHIELD

2014-02-25 Thread Arend van Spriel
On 02/25/2014 03:13 AM, Alexandre Courbot wrote: >> >>> +/* Wifi */ >>> +sdhci@7800 { >>> +status = "okay"; >>> +bus-width = <4>; >>> +broken-cd; >>> +keep-power-in-suspend; >>> +cap-sdio-irq; >> >> Is non-removable better than broken-cd, or are t

Re: [PATCH] ARM: tegra: add device tree for SHIELD

2014-02-26 Thread Arend van Spriel
On 02/26/2014 05:52 AM, Alexandre Courbot wrote: > On 02/25/2014 06:52 PM, Arend van Spriel wrote: >> On 02/25/2014 03:13 AM, Alexandre Courbot wrote: >>>> >>>>> +/* Wifi */ >>>>> +sdhci@7800 { >>>>> +status

Re: [PATCH v2 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-11-01 Thread Arend van Spriel
On 11/01/2013 08:45 PM, Matt Porter wrote: Add a binding that describes the Broadcom Kona USB2 PHY found on the BCM281xx family of SoCs. Signed-off-by: Matt Porter --- .../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 +++ 1 file changed, 15 insertions(+) create mo

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-03-13 Thread Arend van Spriel
On 02/25/2014 11:51 PM, Stephen Warren wrote: > On 02/10/2014 12:17 PM, Arend van Spriel wrote: >> The Broadcom bcm43xx sdio devices are fullmac devices that may be >> integrated in ARM platforms. Currently, the brcmfmac driver for >> these devices support use of plat

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-03-13 Thread Arend van Spriel
On 03/13/2014 11:42 AM, Tomasz Figa wrote: > Hi Arend, > > On 13.03.2014 11:16, Arend van Spriel wrote: >> On 02/25/2014 11:51 PM, Stephen Warren wrote: >>> On 02/10/2014 12:17 PM, Arend van Spriel wrote: >>>> The Broadcom bcm43xx sdio devices are fullmac de

Re: [PATCH 3/3] ath10k: add firmware files

2014-03-14 Thread Arend van Spriel
On 03/14/14 13:47, Dave Taht wrote: On Fri, Mar 14, 2014 at 5:36 AM, Luis R. Rodriguez wrote: On Fri, Mar 14, 2014 at 1:45 AM, Kalle Valo wrote: +FOR ANY DIRECT DAMAGES ARISING UNDER OR RESULTING FROM +THIS AGREEMENT OR IN CONNECTION WITH ANY USE OF THE SOFTWARE SHALL NOT +EXCEED A TOTAL AMO

Re: linux-next: build failure after merge of the wireless-next tree

2014-03-06 Thread Arend van Spriel
On 03/06/2014 03:43 AM, Stephen Rothwell wrote: > Hi John, > > After merging the wireless-next tree, today's linux-next build > (arm multi_v7_defconfig) failed like this: > > drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function > 'brcmf_sdio_intr_rstatus': > drivers/net/wireless/brcm8

Re: [PATCH 4/4] brcmfmac: set NET_NAME_USER for P2P ifs

2014-02-27 Thread Arend van Spriel
On 02/27/2014 03:47 PM, David Herrmann wrote: > Netdevs created via nl80211 (currently only P2P ifs) have names provided > by user-space. Therefore, set the naming-policy to NET_NAME_USER so it is > correctly shown in sysfs. > - Cc: Arend van Spriel + Acked-by: Arend van Spriel >

Re: [wireless-next:master 169/199] drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:2469:3: error: implicit declaration of function 'atomic_set_mask'

2014-03-03 Thread Arend van Spriel
On 02/28/14 23:44, Florian Fainelli wrote: 2014-02-28 14:33 GMT-08:00 Arend van Spriel: On 02/28/2014 11:26 PM, Florian Fainelli wrote: 2014-02-28 14:22 GMT-08:00 Arend van Spriel: On 02/28/2014 11:15 PM, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH 0/9] Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL)

2014-03-20 Thread Arend van Spriel
On 20/03/14 15:37, Monam Agarwal wrote: This patchset uses following coccinelle script to replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL) @@ expression E; @@ - rcu_assign_pointer( + RCU_INIT_POINTER( E, NULL) I am not very familiar with rcu functionality nor coccinelle, but i

Re: [PATCH 0/9] Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL)

2014-03-20 Thread Arend van Spriel
On 03/20/14 16:06, Paul E. McKenney wrote: On Thu, Mar 20, 2014 at 03:58:52PM +0100, Arend van Spriel wrote: On 20/03/14 15:37, Monam Agarwal wrote: This patchset uses following coccinelle script to replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL) @@ expression E

[RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-02-10 Thread Arend van Spriel
: Tomasz Figa Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel --- This devicetree binding proposal is intended for platforms with Broadcom wireless device in MMC sdio slot. These devices may have their own interrupt and power line. Also the SDIO drive

IRQ kernel message after upgrade to 3.14-rc1

2014-02-11 Thread Arend van Spriel
I upgraded a couple of test rigs for our wireless drivers and noticed this blurb showing up in the logs resulting in IRQ to be disabled, which I doubt is what I want looking at the handlers listed. Any clue what might be going wrong here. Our isr brcms_isr() either returns IRQ_NONE or IRQ_HANDLED.

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-02-13 Thread Arend van Spriel
On 02/13/2014 10:13 AM, Tomasz Figa wrote: > Hi Arend, > > On 10.02.2014 20:17, Arend van Spriel wrote: >> The Broadcom bcm43xx sdio devices are fullmac devices that may be >> integrated in ARM platforms. Currently, the brcmfmac driver for >> these devices support use o

Re: [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

2014-02-18 Thread Arend van Spriel
On 02/18/2014 03:15 PM, Joe Perches wrote: > On Tue, 2014-02-18 at 15:05 +0100, Denys Vlasenko wrote: >> Signed-off-by: Denys Vlasenko > > Hi Denys > > Perhaps these patch subjects would be better without > the file path, but shortened to something like: > > brcmfmac: sdio_chip: deinline functi

Re: [PATCH] drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: deinline brcmf_sdio_chip_cr4_enterdl, save 440 bytes

2014-02-18 Thread Arend van Spriel
On 02/18/2014 06:24 PM, Arend van Spriel wrote: > On 02/18/2014 03:15 PM, Joe Perches wrote: >> On Tue, 2014-02-18 at 15:05 +0100, Denys Vlasenko wrote: >>> Signed-off-by: Denys Vlasenko >> >> Hi Denys >> >> Perhaps these patch subjects would be better

Re: [PATCH] [RESEND][TRIVIAL] treewide: fix occurrences of "the the "

2013-11-12 Thread Arend van Spriel
e signed-off-by line. Or even better use the message-id of that patch in the 'In-Reply-To:' field that git-send-email prompts for. For driver change mentioned below: Acked-by: Arend van Spriel Signed-off-by: Michael Opdenacker --- so here: 'This is an update to the patch sent on S

Re: trace-cmd problem with FC19

2013-10-17 Thread Arend van Spriel
On 10/17/13 20:41, Steven Rostedt wrote: On Thu, 17 Oct 2013 14:08:08 +0200 "Arend van Spriel" wrote: Hi Steven, When tracing I get these error messages and no trace data is recorded. I also cloned the trace-cmd repo and tried that with the same result. I think the kernel configura

Re: trace-cmd problem with FC19

2013-10-18 Thread Arend van Spriel
On 10/17/2013 11:11 PM, Bob Copeland wrote: On Thu, Oct 17, 2013 at 04:56:56PM -0400, Steven Rostedt wrote: Hmm, are you sure? You may want to do both: sudo trace-cmd -v which trace-cmd Aaargh, bullocks! My home dir is an NFS mount on FC19 x64 machine and it has a 32-bit trace-cmd installed

Re: [cfg80211 / iwlwifi] setting wireless regulatory domain doesn't work.

2013-12-16 Thread Arend van Spriel
On 12/16/2013 12:22 PM, Sander Eikelenboom wrote: > > Wednesday, December 11, 2013, 7:38:50 PM, you wrote: > >> On Wed, Dec 11, 2013 at 7:11 PM, Sander Eikelenboom >> wrote: >>> >>> Wednesday, December 11, 2013, 6:53:07 PM, you wrote: >>> The best way to address all this is by automatic reg

Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-22 Thread Arend van Spriel
brcmu_d11n_decchspec function, which is how I discovered the bug. Introduced by: commit b48d891676f756d48b4d0ee131e4a7a5d43ca417 ("brcmfmac: rework wiphy structure setup") My bad :-(. You can add: Acked-by: Arend van Spriel Signed-off-by: Emil Goode --- drivers/net/wireless/brcm8021

Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-22 Thread Arend van Spriel
On 09/21/14 00:58, Emil Goode wrote: In the brcmf_count_20mhz_channels function we are looping through a list of channels received from firmware. Since the index of the first channel is 0 the condition leads to an off by one bug. This is causing us to hit the WARN_ON_ONCE(1) calls in the brcmu_d1

Re: [PATCH v2] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-23 Thread Arend van Spriel
ter branch. Regards, Arend Acked-by: Arend van Spriel Signed-off-by: Emil Goode --- v2: Added Arends "Acked-by" tag. drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/brcm80211/brcmf

Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-23 Thread Arend van Spriel
specs" query. So 17 channel configs which is expected. Regards, Arend Best regards, Emil On Mon, Sep 22, 2014 at 11:56:43AM +0200, Arend van Spriel wrote: On 09/21/14 00:58, Emil Goode wrote: In the brcmf_count_20mhz_channels function we are looping through a list of channels received fro

Re: [PATCH 0/4 linux-next] drivers/net: use container_of where possible

2014-09-14 Thread Arend van Spriel
patches they can each go through their own subsystem git tree. Generally I tend to submit patches to the subsystem maintainer and Cc the appropriate mailing lists. Regarding the patches for brcmsmac, you can add Acked-by: Arend van Spriel Regards, Arend Fabian Frederick (4): net: fec: use

Re: [PATCH v2 2/2] dmaengine: omap-dma: Restore the CLINK_CTRL in resume path

2014-09-16 Thread Arend van Spriel
On 09/16/14 15:56, Russell King - ARM Linux wrote: On Tue, Sep 16, 2014 at 04:53:49PM +0300, Peter Ujfalusi wrote: When the audio stream is paused or suspended we stop the sDMA and when it is unpaused/resumed we start the channel without reconfiguring it. The omap_dma_stop() clears the link conf

Re: [RFC PATCH] Fix: module signature vs tracepoints: add new TAINT_UNSIGNED_MODULE

2014-02-13 Thread Arend van Spriel
On 02/13/2014 04:44 PM, Steven Rostedt wrote: > On Thu, 13 Feb 2014 10:36:35 -0500 > f...@redhat.com (Frank Ch. Eigler) wrote: > >> >> rostedt wrote: >> >>> [...] >>> Oh! You are saying that if the kernel only *supports* signed modules, >>> and you load a module that is not signed, it will taint t

Re: Bumping required kernels to 3.0 for Linux backports ?

2014-04-09 Thread Arend van Spriel
On 09/04/14 03:03, Luis R. Rodriguez wrote: Folks, [...] To start off -- what's the *last* kernel you realistically need for your users to use backports right now? Is it really 2.6.25? Would anyone kick and scream if for the backports-3.15 release try take things up to support only down to l

Re: Bumping required kernels to 3.0 for Linux backports ?

2014-04-10 Thread Arend van Spriel
On 04/10/14 18:59, Luis R. Rodriguez wrote: On Thu, Apr 10, 2014 at 12:44 AM, Takashi Iwai wrote: At Wed, 9 Apr 2014 14:06:13 -0700, Greg Kroah-Hartman wrote: On Wed, Apr 09, 2014 at 01:52:29PM -0700, Luis R. Rodriguez wrote: On Wed, Apr 9, 2014 at 1:22 PM, Greg Kroah-Hartman wrote: On We

Re: Bumping required kernels to 3.0 for Linux backports ?

2014-04-11 Thread Arend van Spriel
On 10/04/14 20:56, Luis R. Rodriguez wrote: On Thu, Apr 10, 2014 at 10:04 AM, Arend van Spriel wrote: Ok, I guess my voice was cracking when I mentioned 2.6.38 as being used over here. I am probably alone in that desert. I thought broadcom didn't use backports? If they do can you explai

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-04-11 Thread Arend van Spriel
On 10/04/14 23:27, Jörg Krause wrote: On 02/13/14 10:28, Chen-Yu Tsai wrote: Hi, On Thu, Feb 13, 2014 at 5:13 PM, Tomasz Figa<tomasz.figa@> wrote: Hi Arend, On 10.02.2014 20:17, Arend van Spriel wrote: [...] Hi Chen-Yu, picking up this thread. AFAIK, the pinctrl in tied to the

Re: Disabling gcc inline operation

2014-03-24 Thread Arend van Spriel
On 23/03/14 23:31, anish singh wrote: Many a time i have got a crash and it is difficult to find out the exact function which crashed because the crash stack doesn't show the "real" function because gcc inlines many functions when ever it desires or when it optimizes for speed. So i don't want g

Re: [PATCH] drivers/crypto: Use RCU_INIT_POINTER(x, NULL) in nx/nx-842.c

2014-03-24 Thread Arend van Spriel
On 24/03/14 12:16, Neil Horman wrote: On Mon, Mar 24, 2014 at 01:01:04AM +0530, Monam Agarwal wrote: This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to

Re: [bisected] NULL pointer dereference in acpi_gpiochip_add (on modprobe ssb)

2014-03-24 Thread Arend van Spriel
+ Michael + b43-dev-list On 03/24/14 16:49, Sabrina Dubroca wrote: Hi, With next-20140324, I get the BUG below when I modprobe ssb. I bisected it to aa92b6f689ac "gpio / ACPI: Allocate ACPI specific data directly in acpi_gpiochip_add()" The device that needs ssb is: 0c:00.0 Network controller

Re: [PATCH] [trivial]treewide: Fix typo in printk

2014-03-25 Thread Arend van Spriel
/net/ethernet/via/via-velocity.c | 2 +- drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 6 +++--- For this file you may add: Acked-by: Arend van Spriel drivers/scsi/qla2xxx/qla_nx2.c| 2 +- drivers/scsi/scsi_transport_fc.c

Re: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting

2014-06-19 Thread Arend van Spriel
On 19-06-14 18:28, Fu, Zhonghui wrote: On 2014/6/16 16:15, Arend van Spriel wrote: On 16-06-14 07:49, Fu, Zhonghui wrote: From 14485894add32aedacb3e486ebb2cc2b73861abf Mon Sep 17 00:00:00 2001 From: Fu zhonghui Date: Wed, 11 Jun 2014 11:06:55 +0800 Subject: [PATCH] brcmfmac: prevent

Re: [PATCH] net/wireless/brcm80211/brcmfmac: Make return type reflect actual semantics

2014-06-21 Thread Arend van Spriel
brcmf_get_vif_state_any(). You may add 'Reviewed-by: Arend van Spriel ' to the patch. Regards, Arend Signed-off-by: Rasmus Villemoes --- Notes: Alternatively, if the function is supposed to return a count, the one-line fix would be - bool result = 0; + u32

Re: [PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-22 Thread Arend van Spriel
brcmf_get_vif_state_any. Reviewed-by: Arend van Spriel Signed-off-by: Rasmus Villemoes --- Notes: v2: Rename wl_get_vif_state_all => brcmf_get_vif_state_any as requested by Arend. drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 2 +- drivers/net/wireless/brcm80211/brcmf

Re: [PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-22 Thread Arend van Spriel
On 06/22/14 11:27, Arend van Spriel wrote: On 06/22/14 00:55, Rasmus Villemoes wrote: Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller

Re: [PATCH v7 29/33] net: brcmfmac - set name assign type

2014-07-11 Thread Arend van Spriel
On 10-07-14 22:24, Tom Gundersen wrote: > On Thu, Jul 10, 2014 at 10:08 PM, Arend van Spriel wrote: >> On 10-07-14 10:17, Tom Gundersen wrote: >>> The name is given by the firmware, so we assume it is predictable. >> >> How about the scenario where one would have mul

Re: [PATCH v2 1/9] dma-buf: move to drivers/dma-buf

2014-07-01 Thread Arend van Spriel
On 01-07-14 12:57, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst It would help to use '-M' option with format-patch for this kind of rework. Regards, Arend > --- > Documentation/DocBook/device-drivers.tmpl |3 > MAINTAINERS |4 > drivers/Ma

Re: [RFC 1/2] pwrseq: Add subsystem to handle complex power sequences

2014-07-01 Thread Arend van Spriel
On 01-07-14 18:42, Ulf Hansson wrote: > On 20 June 2014 10:14, Hans de Goede wrote: >> Hi, >> >> On 06/20/2014 10:02 AM, Olof Johansson wrote: >>> On Fri, Jun 20, 2014 at 12:27 AM, Hans de Goede wrote: Hi, On 06/19/2014 07:18 PM, Olof Johansson wrote: > Hi, > > > >>

Re: [PATCH v7 01/33] net: add name_assign_type netdev attribute

2014-07-10 Thread Arend van Spriel
On 10-07-14 10:17, Tom Gundersen wrote: > Based on a patch by David Herrmann. > > The name_assign_type attribute gives hints where the interface name of a > given net-device comes from. These values are currently defined: > NET_NAME_ENUM: > The ifname is provided by the kernel with an enumer

Re: [PATCH v7 29/33] net: brcmfmac - set name assign type

2014-07-10 Thread Arend van Spriel
ing whether we should ignore the firmware ifname altogether. Regards, Arend > Signed-off-by: Tom Gundersen > Cc: Brett Rudley > Cc: Arend van Spriel > Cc: "Franky (Zhenhui) Lin" > Cc: Hante Meuleman > Cc: John Linville > Cc: linux-wirel...@vger.kernel.org >

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-03-30 Thread Arend van Spriel
On 02/13/14 10:28, Chen-Yu Tsai wrote: Hi, On Thu, Feb 13, 2014 at 5:13 PM, Tomasz Figa wrote: Hi Arend, On 10.02.2014 20:17, Arend van Spriel wrote: [...] + +Example: + +mmc3: mmc@01c2 { + pinctrl-0 =<&mmc3_pins>; + pinctrl-1 =<&wifi_host_wake>;

Re: [PATCH 1/4] brcm80211: deinline brcmf_chip_cr4_enterdl, save 440 bytes

2014-03-31 Thread Arend van Spriel
On 30/03/14 23:31, Denys Vlasenko wrote: Automated script discovered that without forced inlining, gcc-4.7 generates smaller code for this function. There is no need to declare static functions inline anyway: nowadays gcc detects single-callsite static functions which benefit from inlining. Th

Re: [PATCH 1/4] brcm80211: deinline brcmf_chip_cr4_enterdl, save 440 bytes

2014-03-31 Thread Arend van Spriel
On 31/03/14 13:18, Denys Vlasenko wrote: On 03/31/2014 09:38 AM, Arend van Spriel wrote: On 30/03/14 23:31, Denys Vlasenko wrote: Automated script discovered that without forced inlining, gcc-4.7 generates smaller code for this function. There is no need to declare static functions inline

Re: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting

2014-06-16 Thread Arend van Spriel
On 16-06-14 07:49, Fu, Zhonghui wrote: From 14485894add32aedacb3e486ebb2cc2b73861abf Mon Sep 17 00:00:00 2001 From: Fu zhonghui Date: Wed, 11 Jun 2014 11:06:55 +0800 Subject: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting Watchdog in brcmfmac driver may make

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread Arend van Spriel
On 16-06-14 10:42, Ulf Hansson wrote: On 6 June 2014 09:05, wrote: From: Micky Ching Add support for non-blocking request, pre_req() runs dma_map_sg() and post_req() runs dma_unmap_sg(). This patch can increase card read/write speed, especially for high speed card and slow speed CPU. Inter

Re: [PATCH 3/3] p54: use request_firmware_direct() for optional EEPROM override

2014-06-25 Thread Arend van Spriel
On 25-06-14 00:39, Luis R. Rodriguez wrote: From: "Luis R. Rodriguez" The p54 driver uses request_firmware() twice, once for actual firmware and then another time for an optional user overide on EEPROM, 3826.eeprom. The custom EEPROM is optional but if not present we'll introduce an extra lag

Re: [cfg80211 / iwlwifi] setting wireless regulatory domain doesn't work.

2013-12-18 Thread Arend van Spriel
On 12/18/2013 08:50 AM, Pontus Fuchs wrote: > On 2013-12-17 22:49, Sander Eikelenboom wrote: >> >> Indeed, I looked for a crda hook for initramfs-tools but didn't find >> it, so skipped that idea >> for the moment. >> >> So if i combine the two .. it's essentially just a very bad idea to >> compile

Re: [cfg80211 / iwlwifi] setting wireless regulatory domain doesn't work.

2013-12-18 Thread Arend van Spriel
On 12/17/2013 11:06 PM, Linus Torvalds wrote: > We have literally had this *exact* same issue with firmware loading. > Network drivers shouldn't try to load firmware at module load time. > Same deal. It is kind of a chicken and egg problem for (wireless) networking drivers. To get IFF_UP from the

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-17 Thread Arend van Spriel
On 11/17/13 14:37, Borislav Petkov wrote: From: Borislav Petkov When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get drivers/built-in.o: In function `brcms_led_unregister': (.text+0x351aca): undefined reference to `led_classdev_unregister' drivers/built-in.o: In function `brcms_led_r

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Arend van Spriel
On 11/18/2013 09:40 PM, Borislav Petkov wrote: On Mon, Nov 18, 2013 at 02:32:50PM +0100, Borislav Petkov wrote: On Mon, Nov 18, 2013 at 12:58:58PM +0100, Rafał Miłecki wrote: Borislav: I think I didn't get your original patch. Forget it, I'll send a better one later. Ok, let's try another o

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-19 Thread Arend van Spriel
On 11/19/2013 12:32 AM, Borislav Petkov wrote: On Mon, Nov 18, 2013 at 11:19:08PM +0100, Arend van Spriel wrote: what about: config BRCMSMAC tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver" depends on MAC80211 depends on BCMA_POSSIBLE +

Re: Build regressions/improvements in v3.13-rc7

2014-01-06 Thread Arend van Spriel
On 01/06/2014 10:01 AM, Geert Uytterhoeven wrote: > + /scratch/kisskb/src/drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c: > warning: 'str_mask' may be used uninitialized in this function > [-Wuninitialized]: => 789:19 > + /scratch/kisskb/src/drivers/net/wireless/brcm80211/brcmfmac/sdio_

Re: [RFC v2] device coredump: add new device coredump class

2014-09-08 Thread Arend van Spriel
On 09/05/14 10:50, Johannes Berg wrote: From: Johannes Berg Many devices run firmware and/or complex hardware, and most of that can have bugs. When it misbehaves, however, it is often much harder to debug than software running on the host. Introduce a "device coredump" mechanism to allow dumpin

Re: [PATCH] brcmfmac: BRCMFMAC should depend on HAS_DMA

2014-09-01 Thread Arend van Spriel
On 08/29/14 18:24, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `brcmf_msgbuf_release_array': msgbuf.c:(.text+0x34dbbe): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `brcmf_proto_msgbuf_detach': (.text+0x34dca4): undefined reference to `dma_

<    1   2   3   4   5   6   >