Re: How to get the irq flags from the dts file

2012-08-09 Thread Arend van Spriel
On 08/09/2012 12:43 PM, Wei Ni wrote: > Hi, all > I'm working on tegra wlan upstream issue. > The tegra board use the Broadcom 4329 as wlan device, and the driver is > the brcmfmac. > > This wlan driver support out-band-interrupt (OOB), I want to add DT > support to use this OOB. > I can add foll

Re: listing drivers

2013-01-22 Thread Arend van Spriel
On 01/22/2013 02:46 PM, Thiago Farina wrote: > Hi folks, > > Is there a way to list the drivers installed/used in my desktop and > map them (the path) to their source code in the linux kernel tree? This might work for you (if using bash): for m in $(cat /proc/modules | gawk '{ print $1; }');do m

Re: listing drivers

2013-01-23 Thread Arend van Spriel
On 01/23/2013 04:30 PM, Thiago Farina wrote: > Hi, > > On Tue, Jan 22, 2013 at 12:27 PM, Arend van Spriel wrote: >> On 01/22/2013 02:46 PM, Thiago Farina wrote: >>> Hi folks, >>> >>> Is there a way to list the drivers installed/used in my desktop and &g

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Arend van Spriel
On 02/13/2013 04:35 AM, Peter Hurley wrote: > On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: >> 3.7-stable review patch. If anyone has any objections, please let me know. > > FWIW, I never saw this on 3.7 but it happened 1st time on 3.8-rcX > I haven't tested this fix either. Dito.

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Arend van Spriel
On 02/13/2013 10:43 AM, Ben Skeggs wrote: > On Wed, 2013-02-13 at 10:33 +0100, Arend van Spriel wrote: >> On 02/13/2013 04:35 AM, Peter Hurley wrote: >>> On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: >>>> 3.7-stable review patch. If anyone has any

Re: linux-next: Tree for Feb 15

2013-02-15 Thread Arend van Spriel
On 02/15/2013 08:42 AM, Stephen Rothwell wrote: > Hi all, > > News: Yesterday was the 5th anniversary of linux-next! I can't > believe I am still doing this :-) Was it a big celebration? ;-) Keep up the good work. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: Streamlining Developer's Certificate of Origin, Signed-off-by tag

2012-11-20 Thread Arend van Spriel
On 11/20/2012 10:16 PM, Alan Cox wrote: On Tue, 20 Nov 2012 12:59:40 -0800 "Luis R. Rodriguez" wrote: Thoughts? Nobody is stopping you putting a copy on a web site. Correct me if I am wrong, but I think what Luis is referring to, is the fact that the 'Developer's Certificate of Origin' is

3.8-rc2: lockdep warning in nouveau driver

2013-01-09 Thread Arend van Spriel
Maybe this one is already known, but I did not find a post about it. So here it is. Regards, Arend == [9.422018] usb 1-1.2: new high-speed USB device number 4 using ehci-pci [9.436177] [TTM] Zone kernel: Available gr

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

2016-09-23 Thread Arend Van Spriel
On 21-9-2016 8:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki &g

Re: [PATCH 1/2] brcmfmac: initialize fws(ignal) for BCDC protocol only

2016-09-26 Thread Arend Van Spriel
On 24-9-2016 22:44, Rafał Miłecki wrote: > From: Rafał Miłecki > > There are two protocols used by Broadcom FullMAC devices: BCDC and > msgbuf. They use different ways for (some part of) communication with > the firmware. Firmware Signaling is required for the first one only > (BCDC). > > So far

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Arend Van Spriel
On 26-9-2016 12:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > We need to track 802.1x packets to know if there are any pending ones > for transmission. This is required for performing key update in the > firmware. The problem we are trying to solve is a pretty old one. The problem is that w

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Arend Van Spriel
On 26-9-2016 14:13, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: >> On 26-9-2016 12:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> We need to track 802.1x packets to know if there are any pending ones >

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-27 Thread Arend Van Spriel
On 26-9-2016 16:59, Dan Williams wrote: > On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> wrote: >>> >>> On 26-9-2016 12:23, Rafał Miłecki wrote: >>>> >>>> From: Rafał Miłecki &

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-27 Thread Arend Van Spriel
On 26-9-2016 14:38, Rafał Miłecki wrote: > On 26 September 2016 at 14:13, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> wrote: >>> On 26-9-2016 12:23, Rafał Miłecki wrote: >>>> From: Rafał Miłecki >>>> >>>&

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Arend Van Spriel
t; that will check for 802.1x type as well. > > Freeing skbs without a proper check was leading to counter not being > properly decreased. This was triggering a WARNING every time > brcmf_netdev_wait_pend8021x was called. Acked-by: Arend van Spriel > Signed-off-by: Rafał M

Re: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message

2016-09-27 Thread Arend Van Spriel
re > and backtrace wasn't much useful. Indeed the interesting part would be in another context. So: Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Arend Van Spriel
On 27-9-2016 13:27, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 27-9-2016 11:14, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> Flowrings contain skbs waiting for transmission that were passed to us >>> by netif. It means

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Arend Van Spriel
On 27-9-2016 13:58, Rafał Miłecki wrote: > On 27 September 2016 at 13:44, Rafał Miłecki wrote: >> On 27 September 2016 at 13:27, Kalle Valo wrote: >>> Arend Van Spriel writes: >>> >>>> On 27-9-2016 11:14, Rafał Miłecki wrote: >>>>> From: Raf

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-07-30 Thread Arend van Spriel
+ Luis (again) ;-) On 29-07-16 08:13, Daniel Wagner wrote: > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: >> >>> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: From: Daniel Wagner >> [..] >>> >>> Do not quite like

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Arend van Spriel
mac: add wowl gtk rekeying offload support") Acked-by: Arend van Spriel > Signed-off-by: Christophe JAILLET > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] brcm80211:Fix error handling in the function brcmf_sdio_htclk

2015-10-07 Thread Arend van Spriel
Hi Nick, On 10/06/2015 04:36 AM, Nicholas Krause wrote: This fixes error handling in the function brcmf_sdio_htclk to properly check if the call to the function brcmf_sdio_regrb fails in the else if condition where the clkstate is in the CLK_PENDING state in order to avoid incorrect execution of

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-08-29 Thread Arend van Spriel
On 08/29/2015 09:11 AM, Takashi Iwai wrote: On Sat, 29 Aug 2015 06:09:01 +0200, Ming Lei wrote: On Sat, Aug 29, 2015 at 9:11 AM, Luis R. Rodriguez wrote: On Thu, Aug 27, 2015 at 08:55:13AM +0800, Ming Lei wrote: On Thu, Aug 27, 2015 at 2:07 AM, Linus Torvalds wrote: On Wed, Aug 26, 2015 at

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-08-30 Thread Arend van Spriel
On 08/29/2015 12:38 PM, Ming Lei wrote: On Sat, 29 Aug 2015 10:50:22 +0200 Arend van Spriel wrote: On 08/29/2015 09:11 AM, Takashi Iwai wrote: On Sat, 29 Aug 2015 06:09:01 +0200, Ming Lei wrote: On Sat, Aug 29, 2015 at 9:11 AM, Luis R. Rodriguez wrote: On Thu, Aug 27, 2015 at 08:55:13AM

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-10-17 Thread Arend van Spriel
On 10/16/2015 09:35 PM, Luis R. Rodriguez wrote: On Thu, Sep 03, 2015 at 10:33:51AM -0700, Dmitry Torokhov wrote: On Thu, Sep 3, 2015 at 10:23 AM, Arend van Spriel wrote: On 09/03/2015 01:46 AM, Luis R. Rodriguez wrote: On Wed, Sep 2, 2015 at 4:29 PM, Dmitry Torokhov wrote: On Wed, Sep 2

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-09-02 Thread Arend van Spriel
On 09/02/2015 03:19 AM, Luis R. Rodriguez wrote: On Mon, Aug 31, 2015 at 10:21:34PM +0800, Ming Lei wrote: On Sun, Aug 30, 2015 at 4:25 PM, Arend van Spriel wrote: Does this mean a built-in driver can not get firmware from initramfs or built in the kernel early. Seems a bit too aggressive

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-09-02 Thread Arend van Spriel
On 09/02/2015 02:09 PM, Arend van Spriel wrote: On 09/02/2015 03:19 AM, Luis R. Rodriguez wrote: On Mon, Aug 31, 2015 at 10:21:34PM +0800, Ming Lei wrote: On Sun, Aug 30, 2015 at 4:25 PM, Arend van Spriel wrote: Does this mean a built-in driver can not get firmware from initramfs or built in

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-09-02 Thread Arend van Spriel
On 09/02/2015 08:58 PM, Luis R. Rodriguez wrote: On Wed, Sep 02, 2015 at 02:13:49PM +0200, Arend van Spriel wrote: On 09/02/2015 02:09 PM, Arend van Spriel wrote: On 09/02/2015 03:19 AM, Luis R. Rodriguez wrote: On Mon, Aug 31, 2015 at 10:21:34PM +0800, Ming Lei wrote: On Sun, Aug 30, 2015

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-09-03 Thread Arend van Spriel
On 09/03/2015 01:46 AM, Luis R. Rodriguez wrote: On Wed, Sep 2, 2015 at 4:29 PM, Dmitry Torokhov wrote: On Wed, Sep 2, 2015 at 4:22 PM, Luis R. Rodriguez wrote: On Wed, Sep 02, 2015 at 04:13:51PM -0700, Dmitry Torokhov wrote: On Wed, Sep 2, 2015 at 2:03 PM, Arend van Spriel wrote: Ok. So

Re: [PATCH] brcm80211:Fix locking region in the function brcmf_sdio_sendfromq

2015-10-04 Thread Arend van Spriel
On 10/03/2015 06:19 PM, Nicholas Krause wrote: This fixes the locking region in the function brcmf_sdio_sendfromq to properly lock around the call to the function brcmrf_sdio_txpkt in order to avoid concurrent access issues when calling this function as stated in the function's comments about the

Re: [PATCH] brcm80211:Use proper skb wrapper function in the function brcmf_sdio_txpkt_postp

2015-10-04 Thread Arend van Spriel
On 10/03/2015 06:24 AM, Nicholas Krause wrote: This uses the proper skb wrapper function sk_unlink in the function brcmf_sdio_txpkt_postp to properly protect against concurrent users accessing this skb_buff pointer or skb_buff_head pointer by locking the spinlock as part of the passed skb_buff_he

Re: [PATCH 10/18] brcmsmac: change strncpy+truncation to strlcpy

2018-07-13 Thread Arend van Spriel
On 7/13/2018 3:25 AM, Dominique Martinet wrote: Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Acked-by: Arend van Spriel Signed-off-by: Dominique Martinet --- Please see https://marc.info/?l=linux-kernel&m=153144450722324&w=2 (the first patch of the serie)

Re: [PATCH] hostap: hide unused procfs helpers

2018-07-13 Thread Arend van Spriel
+ Randy On 7/13/2018 9:03 AM, YueHaibing wrote: When CONFIG_PROC_FS isn't set, gcc warning this: drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: ‘prism2_registers_proc_show’ defined but not used [-Wunused-function] static int prism2_registers_proc_show(struct seq_file *m,

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
On 5/12/2017 10:19 AM, Kalle Valo wrote: Xie Qirong writes: The combination of init_timer and setting up the data and function field manually is equivalent to calling setup_timer(). This is an api consolidation only and improves readability. Acked-by: Arend van Spriel Signed-off-by: Xie

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
On 5/12/2017 10:54 AM, Kalle Valo wrote: Arend van Spriel writes: On 5/12/2017 10:19 AM, Kalle Valo wrote: Xie Qirong writes: The combination of init_timer and setting up the data and function field manually is equivalent to calling setup_timer(). This is an api consolidation only and

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-12 Thread Arend Van Spriel
On 4-5-2017 4:28, Luis R. Rodriguez wrote: > On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: >> On 3-1-2017 18:59, Luis R. Rodriguez wrote: >>> On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >>>> >>>> Right question is &

Re: [PATCH V2 0/3] sysfs: allow user-space request for devcoredump

2018-01-11 Thread Arend van Spriel
On Wed, Jan 10, 2018 at 2:53 PM, Arend van Spriel wrote: > Since commit 833c95456a70 ("device coredump: add new device coredump class") > device drivers have a unified way to provide binary data obtained from a > failing_device to user-space. However, there may be use-cases in

[PATCH V3 1/3] sysfs: add attribute specification for /sysfs/devices/.../coredump

2018-01-11 Thread Arend van Spriel
This patch adds the specification for /sysfs/devices/.../coredump which allows user-space to trigger a device coredump obtaining binary data from the device for (fault) analysis. It relies on CONFIG_DEV_COREDUMP being enabled. Signed-off-by: Arend van Spriel --- V2: - no changes. V3: - changed

[RFC V2 3/3] brcmfmac: pcie: implement .coredump() driver callback

2018-01-11 Thread Arend van Spriel
This implements the .coredump() driver callback obtaining binary data from the device and using devcoredump function to expose it in sysfs. Signed-off-by: Arend van Spriel --- V2: - no changes --- .../wireless/broadcom/brcm80211/brcmfmac/pcie.c| 22 ++ 1 file changed

[PATCH V3 2/3] drivers: base: add coredump driver ops

2018-01-11 Thread Arend van Spriel
ff-by: Arend van Spriel --- V2: - extended the commit message. V3: - no changes. --- drivers/base/dd.c | 40 +--- include/linux/device.h | 2 +- 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 53

[PATCH V3 0/3] sysfs: allow user-space request for devcoredump

2018-01-11 Thread Arend van Spriel
API. As an example this series includes a driver implementation as RFC. There are other drivers having some form of device firmware coredump that could benefit from this, but decided to tackle that in another cycle. These patches apply to the driver-core-next branch of the driver-core repository.

Re: [PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

2018-01-09 Thread Arend van Spriel
On 1/9/2018 9:39 AM, Jia-Ju Bai wrote: On 2018/1/9 16:35, Greg KH wrote: On Tue, Jan 09, 2018 at 09:40:06AM +0800, Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with usleep_range, to reduce bu

Re: [PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

2018-01-09 Thread Arend van Spriel
On 1/9/2018 10:47 AM, Jia-Ju Bai wrote: On 2018/1/9 17:07, Arend van Spriel wrote: On 1/9/2018 9:39 AM, Jia-Ju Bai wrote: On 2018/1/9 16:35, Greg KH wrote: On Tue, Jan 09, 2018 at 09:40:06AM +0800, Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor

Fwd: [PATCH 0/2] sysfs: allow user-space request for devcoredump

2018-01-09 Thread Arend van Spriel
+ LKML -- Forwarded message -- From: Arend van Spriel Date: Tue, Jan 9, 2018 at 8:19 PM Subject: Re: [PATCH 0/2] sysfs: allow user-space request for devcoredump To: Greg Kroah-Hartman On Tue, Jan 9, 2018 at 7:46 PM, Greg Kroah-Hartman wrote: > On Tue, Dec 19, 2017 at 11

Re: Fwd: [PATCH 0/2] sysfs: allow user-space request for devcoredump

2018-01-09 Thread Arend van Spriel
On Tue, Jan 9, 2018 at 9:03 PM, Greg KH wrote: > On Tue, Jan 09, 2018 at 08:21:11PM +0100, Arend van Spriel wrote: >> + LKML >> >> -- Forwarded message ------ >> From: Arend van Spriel >> Date: Tue, Jan 9, 2018 at 8:19 PM >> Subject: Re: [PAT

[PATCH V2 0/3] sysfs: allow user-space request for devcoredump

2018-01-10 Thread Arend van Spriel
API. As an example this series includes a driver implementation as RFC. There are other drivers having some form of device firmware coredump that could benefit from this, but decided to tackle that in another cycle. These patches apply to the driver-core-next branch of the driver-core repository.

[PATCH V2 2/3] drivers: base: add coredump driver ops

2018-01-10 Thread Arend van Spriel
ad of obtaining raw coredump data from the driver it is left to the coredump driver operation to invoke the devcoredump API as there are more ways to do that. Signed-off-by: Arend van Spriel --- V2: - extended the commit message. --- drivers/base/dd.c

[PATCH V2 1/3] sysfs: add attribute specification for /sysfs/devices/.../coredump

2018-01-10 Thread Arend van Spriel
This patch adds the specification for /sysfs/devices/.../coredump which allows user-space to trigger a device coredump obtaining binary data from the device for (fault) analysis. It relies on CONFIG_DEV_COREDUMP being enabled. Signed-off-by: Arend van Spriel --- Documentation/ABI/testing/sysfs

[RFC 3/3] brcmfmac: pcie: implement .coredump() driver callback

2018-01-10 Thread Arend van Spriel
This implements the .coredump() driver callback obtaining binary data from the device and using devcoredump function to expose it in sysfs. Signed-off-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmfmac/pcie.c| 22 ++ 1 file changed, 22 insertions(+) diff

Re: [PATCH] brcmfmac: Make sure CLM downloading is optional

2018-01-15 Thread Arend van Spriel
On 1/15/2018 6:10 PM, Bjorn Andersson wrote: The presence of a CLM file is described as optional, but missing the clm blob causes the preinit to return unsuccessfully. Fix this by ignoring the return value of the brcmf_c_process_clm_blob(). Also remove the extra debug print, as brcmf_c_process_c

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

2018-03-10 Thread Arend van Spriel
On 3/9/2018 1:30 PM, Andreas Christoforou wrote: The kernel would like to have all stack VLA usage removed. I think there was a remark made earlier to give more explanation here. It should explain why we want "VLA on stack" removed. Signed-off-by: Andreas Christoforou --- drivers/net/wir

Re: [PATCH 3/3] wlcore: Use common error handling code in wl1271_acx_sta_rate_policies()

2018-03-11 Thread Arend van Spriel
On 3/10/2018 10:33 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 10 Mar 2018 22:18:45 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. You call this an issue?

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-11 Thread Arend van Spriel
On 3/11/2018 5:05 PM, Andres Rodriguez wrote: Your patch series then should also have the driver callers who you want to modify to use this new API. Collect from the 802.11 folks the other drivers which I think they wanted changed as well. Arend, Kalle, would love to hear your feedback. I am

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-11 Thread Arend van Spriel
On 3/10/2018 12:09 AM, Andres Rodriguez wrote: Currently the firmware loader only exposes one silent path for querying optional firmware, and that is request_firmware_direct(). This function also disables the usermodehelper fallback which might not always be the desired behaviour. This patch int

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-12 Thread Arend van Spriel
On 3/12/2018 10:41 AM, Kalle Valo wrote: Arend Van Spriel wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver callback. As there is n

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Arend van Spriel
On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: >> Upon submitting a patch for mwifiex [1] it was discussed whether this >> callback function could fail. To keep things simple there is no need >>

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Arend van Spriel
+ Marcel On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman >> wrote: >> > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrot

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Arend van Spriel
On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman >> wrote: >> > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: >&

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Arend van Spriel
Op vr 6 apr. 2018 4:46 PM schreef Greg Kroah-Hartman : > > On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > > wrote: > > > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >

[RESEND PATCH] drivers: change struct device_driver::coredump() return type to void

2018-04-08 Thread Arend van Spriel
changing it to void. [1] https://patchwork.kernel.org/patch/10231933/ Signed-off-by: Arend van Spriel --- Hi Greg, Here is a resend of my patch that got lost. See if it makes it this time ;-) Regards, Arend --- include/linux/device.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-03-19 Thread Arend van Spriel
if it does make any difference. Are you using some chromebook. I have some lying around here so I could also look into it. What broadcom chipset do you have? Regards, Arend All the best, Alex. On 19 March 2018 at 16:31, Arend van Spriel wrote: On 3/19/2018 2:40 AM, Alexey Roslyakov wrote:

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-03-20 Thread Arend van Spriel
n and these do not describe the wifi device. They are applicable to the wifi device because it is a limitation of the host controller and as such should be described in the DT binding of the host controller. Regards, Arend Regards, Alex On 20 March 2018 at 06:16, Arend van Spriel wrote: +

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-13 Thread Arend van Spriel
On 3/13/2018 2:10 PM, Kalle Valo wrote: Arend van Spriel writes: On 3/12/2018 10:41 AM, Kalle Valo wrote: Arend Van Spriel wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds s

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-13 Thread Arend van Spriel
a need to initiate it through debugfs remove that code. Signed-off-by: Arend van Spriel Based on the discussion I assume this is ok to take to w-d-next. If that's not the case, please let me know ASAP. It is up to the mwifiex maintainers to decide, I guess. The ABI documentation need to be rev

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-14 Thread Arend van Spriel
On 3/13/2018 5:46 PM, Kalle Valo wrote: "Luis R. Rodriguez" writes: On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" writes: +/** + * request_firmware_optional: - request for an optional fw module + * @firmware_p: pointer to firmware image + * @name: name of

Re: [PATCH] drivers: base: add description for .coredump() callback

2018-03-14 Thread Arend van Spriel
On 2/9/2018 10:13 AM, Arend van Spriel wrote: Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added a new callback in struct device_driver, but not a kerneldoc description so here it is. Hi Greg, Revisiting the header file I notice this patch is not yet applied. I

Re: using DMA-API on ARM

2014-12-08 Thread Arend van Spriel
On 12/08/14 17:03, Catalin Marinas wrote: On Mon, Dec 08, 2014 at 03:01:32PM +, Arnd Bergmann wrote: [0.00] PL310 OF: cache setting yield illegal associativity [0.00] PL310 OF: -1069781724 calculated, only 8 and 16 legal [0.00] L2C-310 enabling early BRESP for Cortex-

Re: using DMA-API on ARM

2014-12-09 Thread Arend van Spriel
On 12/08/14 18:01, Arend van Spriel wrote: On 12/08/14 17:03, Catalin Marinas wrote: On Mon, Dec 08, 2014 at 03:01:32PM +, Arnd Bergmann wrote: [ 0.00] PL310 OF: cache setting yield illegal associativity [ 0.00] PL310 OF: -1069781724 calculated, only 8 and 16 legal [ 0.00] L2C

Re: using DMA-API on ARM

2014-12-09 Thread Arend van Spriel
On 12/09/14 11:29, Russell King - ARM Linux wrote: On Tue, Dec 09, 2014 at 11:19:40AM +0100, Arend van Spriel wrote: The issue did not trigger overnight so it seems setting bit 22 solves the issue over here. Now the question is how to move forward with this. As I understood from Catalin this

Re: [PATCH 2/4] PCI: iproc: Add Broadcom iProc PCIe driver

2014-12-11 Thread Arend van Spriel
+ Rafal On 12/10/14 19:46, Florian Fainelli wrote: 2014-12-10 8:46 GMT-08:00 Scott Branden: On 14-12-10 03:31 AM, Arnd Bergmann wrote: On Tuesday 09 December 2014 16:04:29 Ray Jui wrote: Add initial version of the Broadcom iProc PCIe driver. This driver has been tested on NSP and Cygnus and

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2015-01-01 Thread Arend van Spriel
On 01/01/15 11:56, Andreas Hartmann wrote: Arend van Spriel wrote: On 12/31/14 16:14, Andreas Hartmann wrote: [...] All in all: If you want to get rid of wext, you still have to go a *very* long way to get the same *stable* and high throughput quality with *all* chips depending on mac80211

Re: [PATCH] Revert "ipw2200: select CFG80211_WEXT"

2015-01-05 Thread Arend van Spriel
On 01/03/15 23:28, Paul Bolle wrote: On Sat, 2015-01-03 at 10:07 -0800, Linus Torvalds wrote: On Sat, Jan 3, 2015 at 10:02 AM, Marcel Holtmann wrote: why would you revert this? It is obviously the correct change to actually select CFG80211_WEXT. I don't know about obvious, but yeah, I thin

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-05 Thread Arend van Spriel
On 01/05/15 03:34, Fu, Zhonghui wrote: Hi Arend, Where to find your patch for this? Well, we did not submit it. Hence my "Acked-by:" to your patch below. Regards, Arend Thanks, Zhonghui On 2014/12/31 17:56, Arend van Spriel wrote: On 12/31/14 09:20, Fu, Zhonghui wrote

Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions

2015-01-05 Thread Arend van Spriel
On 01/05/15 11:49, Kalle Valo wrote: Rickard Strandqvist writes: As I hope you can see I have made some changes regarding the subject-line. Thought it was an advantage to be able to see which file I actually removed something from. There seems to be a big focus on getting right on subject-line

Re: [PATCH] Revert "ipw2200: select CFG80211_WEXT"

2015-01-05 Thread Arend van Spriel
On 01/05/15 18:38, Paul Bolle wrote: On Mon, 2015-01-05 at 11:14 +0100, Arend van Spriel wrote: On 01/03/15 23:28, Paul Bolle wrote: Side note: am I correct in thinking that there's some successor to CFG80211_WEXT and that the ipw2200 driver could, at least in theory, be ported to

Re: [PATCH] Revert "ipw2200: select CFG80211_WEXT"

2015-01-05 Thread Arend van Spriel
On 01/05/15 23:05, Paul Bolle wrote: On Mon, 2015-01-05 at 19:57 +0100, Johannes Berg wrote: Multiple other groups of ioctls could be converted in similar patches, until at the end you can completely remove ipw_wx_handlers and rely entirely on cfg80211's wext compatibility. So far the theory -

Re: linux-next: manual merge of the driver-core tree with the net-next tree

2014-12-04 Thread Arend van Spriel
On 04-12-14 11:19, Jeremiah Mahler wrote: > Arend, > > I haven't heard if you have looked at this bug at all yet. I was > curious so I looked at it some more and I have some more information > that might be helpful. > > On Wed, Dec 03, 2014 at 01:41:28PM -0800, Jeremiah Mahler wrote: >> On Wed,

using DMA-API on ARM

2014-12-05 Thread Arend van Spriel
Hi Russell, For our brcm80211 development we are working on getting brcmfmac driver up and running on a Broadcom ARM-based platform. The wireless device is a PCIe device, which is hooked up to the system behind a PCIe host bridge, and we transfer information between host and device using a descrip

Re: using DMA-API on ARM

2014-12-05 Thread Arend van Spriel
On 05-12-14 10:45, Russell King - ARM Linux wrote: On Fri, Dec 05, 2014 at 10:22:22AM +0100, Arend van Spriel wrote: For our brcm80211 development we are working on getting brcmfmac driver up and running on a Broadcom ARM-based platform. The wireless device is a PCIe device, which is hooked up

Re: using DMA-API on ARM

2014-12-05 Thread Arend van Spriel
vrijdag 5 december 2014 14:24 To: Hante Meuleman Cc: Will Deacon; Arend Van Spriel; Marek Szyprowski; linux-arm-ker...@lists.infradead.org; David Miller; linux-kernel@vger.kernel.org; brcm80211-dev-list; linux-wireless Subject: Re: using DMA-API on ARM Please wrap your message - replying to a mes

Re: using DMA-API on ARM

2014-12-05 Thread Arend van Spriel
On 12/05/14 19:28, Catalin Marinas wrote: On Fri, Dec 05, 2014 at 03:06:48PM +, Russell King - ARM Linux wrote: I've been doing more digging into the current DMA code, and I'm dismayed to see that there's new bugs in it... commit 513510ddba9650fc7da456eefeb0ead7632324f6 Author: Laura Abbott

Re: using DMA-API on ARM

2014-12-05 Thread Arend van Spriel
On 12/05/14 19:53, Catalin Marinas wrote: On Fri, Dec 05, 2014 at 06:39:45PM +, Catalin Marinas wrote: On Fri, Dec 05, 2014 at 09:22:22AM +, Arend van Spriel wrote: For our brcm80211 development we are working on getting brcmfmac driver up and running on a Broadcom ARM-based platform

Re: using DMA-API on ARM

2014-12-08 Thread Arend van Spriel
On 12/08/14 16:01, Arnd Bergmann wrote: On Monday 08 December 2014 13:47:38 Hante Meuleman wrote: Still using outlook, but will limit the line length, I hope that works for the moment. Attached is a log with the requested information, it is a little bit non-standard though. The dump code from th

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Arend van Spriel
On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can be supported. However, not all platforms populate pdata in which case we crash the kernel because of NULL pointer dereference. Thanks, Mika However, this was already reported by Dan

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Arend van Spriel
On 12/23/14 16:47, Mika Westerberg wrote: On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can be supported. However, not all platforms populate pdata in which case

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Arend van Spriel
On 12/23/14 18:00, Kalle Valo wrote: Arend van Spriel writes: On 12/23/14 16:47, Mika Westerberg wrote: On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can

Re: [PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

2014-12-23 Thread Arend van Spriel
On 12/23/14 16:27, Vaishali Thakkar wrote: This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16, __le16; {u16,__le16} e16; identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le1

Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.

2014-12-24 Thread Arend van Spriel
On 12/24/14 08:20, Kalle Valo wrote: Oscar Forner Martinez writes: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez --- drivers/bcma/driver_chipcommon.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

Re: [PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

2014-12-24 Thread Arend van Spriel
On 12/24/14 03:35, Vaishali Thakkar wrote: On Wed, Dec 24, 2014 at 12:54 AM, Arend van Spriel wrote: On 12/23/14 16:27, Vaishali Thakkar wrote: This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

2014-12-28 Thread Arend van Spriel
On 12/28/14 15:02, Rafał Miłecki wrote: On 28 December 2014 at 10:12, Sedat Dilek wrote: On Sun, Dec 28, 2014 at 9:53 AM, Rafał Miłecki wrote: On 28 December 2014 at 06:50, Sedat Dilek wrote: On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki wrote: On 27 December 2014 at 20:24, Oscar Forner

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2014-12-31 Thread Arend van Spriel
twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. We have a patch queued up for this as well, but this one looks good enough although I personally prefer container_of() instead of dev_to_sdio_func(). Acked-by: Arend van Spriel Signed-off-by

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/30/14 23:52, Jiri Kosina wrote: This reverts commit 24a0aa212ee2dbe44360288684478d76a8e20a0a. It's causing severe userspace breakage. Namely, all the utilities from wireless-utils which are relying on CONFIG_WEXT (which means tools like 'iwconfig', 'iwlist', etc) are not working anymore. T

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 12:10, Grumbach, Emmanuel wrote: On 12/30/14 23:52, Jiri Kosina wrote: This reverts commit 24a0aa212ee2dbe44360288684478d76a8e20a0a. It's causing severe userspace breakage. Namely, all the utilities from wireless-utils which are relying on CONFIG_WEXT (which means tools like 'iwconf

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 15:07, Jiri Kosina wrote: On Wed, 31 Dec 2014, Arend van Spriel wrote: The thing with WEXT is that it will stay as is. So if tools like wicd want to support new features like P2P it will need to make the switch. I checked out wicd repo and found a number of iwconfig calls and they

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 16:14, Andreas Hartmann wrote: Jiri Kosina wrote: On Wed, 31 Dec 2014, Arend van Spriel wrote: The thing with WEXT is that it will stay as is. So if tools like wicd want to support new features like P2P it will need to make the switch. I checked out wicd repo and found a number of

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 18:31, Theodore Ts'o wrote: On Wed, Dec 31, 2014 at 04:02:24PM +0100, Arend van Spriel wrote: It is unfortunately indeed. I think iwconfig and friends will never go away although iw is a better alternative, simply because people don't like to change their home-made scr

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 22:44, Theodore Ts'o wrote: On Wed, Dec 31, 2014 at 09:32:13PM +0100, Arend van Spriel wrote: Agree. I can't even recall using "ip" ever. iw help system does provide command specific help. The phy keyword is both a command and a selector key, which I realize

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 22:57, Linus Torvalds wrote: On Wed, Dec 31, 2014 at 1:44 PM, Theodore Ts'o wrote: Yeah, the confusing part is that "ip" tends to use "verb object" scheme, which is consistent with the Cisco IOS command set it was trying to emulate. Side note: does anybody think that was really a

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-22 Thread Arend van Spriel
ion WiFi chip has 2 SDIO functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel Acked-by: Sergei Shtylyov Acked-by: Kalle Valo Signed-off-by: Zhonghui Fu I don't remember giving

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-23 Thread Arend van Spriel
On 01/23/15 16:29, Kalle Valo wrote: Arend van Spriel writes: On 01/22/15 14:54, Sergei Shtylyov wrote: Hello. On 1/22/2015 4:49 PM, Kalle Valo wrote: > From 04d3fa673897ca4ccbea6c76836d0092dba2484a Mon Sep 17 00:00:00 2001 From: Zhonghui Fu Date: Tue, 20 Jan 2015 11:14:13 +0800 Subj

Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions

2015-01-07 Thread Arend van Spriel
On 01/07/15 00:33, Rickard Strandqvist wrote: 2015-01-05 12:06 GMT+01:00 Arend van Spriel: On 01/05/15 11:49, Kalle Valo wrote: Rickard Strandqvist writes: As I hope you can see I have made some changes regarding the subject-line. Thought it was an advantage to be able to see which file I

<    1   2   3   4   5   6   >