Re: [PATCH] brcmfmac: BRCMFMAC should depend on HAS_DMA

On 09/01/14 10:44, Geert Uytterhoeven wrote: Hi Arend, On Mon, Sep 1, 2014 at 10:21 AM, Arend van Spriel wrote: config BRCMFMAC tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" - depends on CFG80211 + depends on CFG80211A&& HAS_D

Re: [PATCH] staging: xillybus: Move out of staging

On 09/01/14 14:13, Dan Carpenter wrote: Pretty nice. This is very special purpose hardware and the UAPI for this is fine. The documentation seems good. I had some minor style comments but nothing major stands out. Maybe it would be better to use the DMA-API instead of the PCI wrappers. Rega

Re: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting

On 08/04/14 18:36, Fu, Zhonghui wrote: On 2014/7/24 23:22, Fu, Zhonghui wrote: On 2014/7/21 15:42, Fu, Zhonghui wrote: On 2014/6/20 0:37, Arend van Spriel wrote: On 19-06-14 18:28, Fu, Zhonghui wrote: On 2014/6/16 16:15, Arend van Spriel wrote: On 16-06-14 07:49, Fu, Zhonghui wrote

Re: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting

On 08/04/14 18:52, Russell King - ARM Linux wrote: On Tue, Aug 05, 2014 at 12:36:49AM +0800, Fu, Zhonghui wrote: Hi, Arend I investigated this issue, and its root cause is still that sdio controller can't receive interrupts from WiFi chip on sdio bus when sdio controller is in runtime suspend s

Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

cmfmac (skip net:...). - Send the patch to the wireless maintainer, ie. John Linville. Acked-by: Arend van Spriel > Signed-off-by: Rickard Strandqvist > --- > drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 25 > ++-- > 1 file changed, 12 insertions(+), 13 d

Re: [PATCH] debugfs: add helper function to create device related seq_file

On 11-10-14 22:17, Greg Kroah-Hartman wrote: > On Sat, Oct 11, 2014 at 06:01:55PM +0200, Arend van Spriel wrote: >> This patch adds a helper function that simplifies adding a >> sequence file for device drivers. The calling device driver >> needs to provide a read function

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

c_or which downcasts it to 32 bits. Is that OK ? The function is used with 32bit register value from the device so I think it is ok. Regards, Arend --- Cc: Brett Rudley Cc: Arend van Spriel Cc: "Franky (Zhenhui) Lin" Cc: Hante Meuleman Cc: Kalle Valo Cc: Pieter-Paul Giesberts Cc: D

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

On 07/09/2015 08:25 PM, Arend van Spriel wrote: On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for a

Re: [PATCH v2] brcmsmac: Use kstrdup to simplify code

: Arend van Spriel Signed-off-by: Christophe JAILLET --- v2: fix the subject drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/brcm80211

Re: [PATCH] mac80211: Do not use sizeof() on pointer type

On 08/26/2015 12:22 PM, Thierry Reding wrote: From: Thierry Reding The rate_control_cap_mask() function takes a parameter mcs_mask, which GCC will take to be u8 * even though it was declared with a fixed size. This causes the following warning: net/mac80211/rate.c: In function 'rate_co

Re: [PATCH] mac80211: Do not use sizeof() on pointer type

On 08/26/2015 10:23 PM, Arend van Spriel wrote: On 08/26/2015 12:22 PM, Thierry Reding wrote: From: Thierry Reding The rate_control_cap_mask() function takes a parameter mcs_mask, which GCC will take to be u8 * even though it was declared with a fixed size. This causes the following warning

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

bit arches. Assuming LP64 programming model for linux on say x86_64: atomic_or() callers in this driver use long (sana 64 bit) storage and pass it to atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ? --- Cc: Brett Rudley Cc: Arend van Spriel Cc: "Franky (Zhenhui) Lin" Cc

Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

+ Rafael On 08/17/2015 09:29 AM, Johannes Berg wrote: On Mon, 2015-08-17 at 09:48 +0800, Fu, Zhonghui wrote: The suspend/resume timing of wiphy device and related devices will be ensured by their parent/child relationship. So, enabling wiphy device to suspend/resume asynchronously does not cha

Re: [PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak

On 08/17/2015 09:28 PM, Raphaël Beamonte wrote: The MACRO_WILC_BUFFER() macro was using a return statement, and didn't Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here. take care of possible memory leaks and subsequent bugs when it was failing after succeeding some allocations. Th

Re: [PATCH 1/1] brcm80211: simplify assignment

On 18-5-2016 2:57, Heinrich Schuchardt wrote: > Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. Acked-by: Arend van Spriel > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH 4.8 2/2] brcmfmac: support get_channel cfg80211 callback

On 19-5-2016 13:02, Rafał Miłecki wrote: > This is important for brcmfmac as the firmware may pick different > channel than requested. This has been tested with BCM4366B1 (in D-Link > DIR-885L). Can you elaborate? Is this for AP or STA mode? > Signed-off-by: Rafał Miłecki > --- > .../broadcom/b

Re: [PATCH 4.8 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

r control channel. The need to "access all info" is probably the other patch so you might hint here that this change is needed for the .get_channel() callback. Reviewed-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > .../broadcom/brcm80211/brcmfmac/cfg80211.c

Re: [PATCH] brcmfmac: use kmemdup

On 19-5-2016 15:59, Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. Acked-by: Arend van Spriel > Signed-off-by: Muhammad

Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails

On 24-05-16 23:05, Rafał Miłecki wrote: > This is helpful for debugging, without this all I was getting from "iw" > command on device with BCM43602 was: >> command failed: Too many open files in system (-23) > > Signed-off-by: Rafał Miłecki > --- > V2: s/in/if/ in commit message > --- > drivers/

Re: [PATCH] brcmfmac: fix setting AP channel with new firmwares

On 24-05-16 11:09, Rafał Miłecki wrote: > Firmware for new chipsets is based on a new major version of code > internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for > BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was > based on 7.35.177.56. > > Currently

Re: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails

On 26-5-2016 0:44, Rafał Miłecki wrote: > This is helpful for debugging, without this all I was getting from "iw" > command on device with BCM43602 was: >> command failed: Too many open files in system (-23) > > Signed-off-by: Rafał Miłecki > --- > V2: s/in/if/ in commit message > V3: Add one mor

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

On 12-05-16 11:34, Wei-Ning Huang wrote: > On Thu, May 12, 2016 at 2:33 AM, Dan Williams wrote: >> On Wed, 2016-05-11 at 13:03 +0800, Wei-Ning Huang wrote: >>> On Fri, May 6, 2016 at 4:19 PM, Wei-Ning Huang >>> wrote: On Fri, May 6, 2016 at 12:07 AM, Dan Williams wrote: >

Re: [PATCH] brcmfmac: only lock and unlock fws if fws is not null

On 12/02/2015 12:45 PM, Colin King wrote: From: Colin Ian King There is a null ptr check for fws to set bcmc_credit_check, however, there a lock and unlock on fws should only performed if fwts is also not null to also avoid a potential null pointer deference. Acked-by: Arend van Spriel

Re: [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware()

ginning for one local variable that is redefined before its first use. That being said here is my.... Acked-by: Arend van Spriel Signed-off-by: Markus Elfring --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 10:08, SF Markus Elfring wrote: >>> I assume that a software development taste can evolve, can't it? >> >> So far, you have gotten several down votes for this kind of change, > > I am curious when more contributors will share corresponding opinions. Let's burn some cycles on this wh

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 12:21, SF Markus Elfring wrote: >> I have never seen much evolution going on in this area. > > I can get an other impression from a specific document for example. > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > > >> What the patch

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 03-01-16 16:18, Rafał Miłecki wrote: > On 3 January 2016 at 10:36, Arend van Spriel wrote: >> On 02-01-16 12:21, SF Markus Elfring wrote: >>>> Did you look at the resulting assembly code for different target >>>> architectures? >>> >>> N

Re: [PATCH 1/1] net: brcm80211: Deletion of unnecessary checks before two function calls

detected by using the Coccinelle software. Goodo for coccinelle and you for running it. Acked-by: Arend van Spriel Signed-off-by: Markus Elfring --- drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 3 +-- drivers/net/wireless/brcm80211/brcmfmac/firmware.c | 3 +-- drivers/net/wireless

Re: [PATCH] brcmfmac: kill URB when request timed out

On 13-11-14 03:33, Mathy Vanhoef wrote: > Kill the submitted URB in brcmf_usb_dl_cmd if the request timed out. This > assures the URB is never submitted twice. It also prevents a possible > use-after-free of the URB transfer buffer if a timeout occurs. > Acked-by: Arend van Spriel

[PATCH] fs: debugfs: add forward declaration for struct device type

Author: Arend van Spriel Date: Sun Nov 9 11:31:58 2014 +0100 debugfs: add helper function to create device related seq_file The reported build failure for sparc64 architecture was: make.cross ARCH=sparc64 All warnings: In file included from fs/debugfs/file.c:21:0: include

Re: linux-next: manual merge of the driver-core tree with the net-next tree

On 01-12-14 08:19, Stephen Rothwell wrote: > Hi Greg, > > Today's linux-next merge of the driver-core tree got a conflict in > drivers/net/wireless/ath/ath9k/debug.c between commits 70e535ed0029 > ("ath9k: clean up debugfs print of reset causes"), 7b8aaead958e > ("ath9k: restart hardware after noi

Re: linux-next: build warnings after merge of the driver-core tree

On 01-12-14 08:42, Stephen Rothwell wrote: > Hi Greg, > > After merging the driver-core tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > In file included from kernel/power/main.c:16:0: > include/linux/debugfs.h:105:10: warning: 'struct device' declared inside

Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons()

On 10-11-14 21:21, Jes Sorensen wrote: > Chris Ruffin writes: >> Using a u16 pointer typecast for a result from htons() results in the >> following warning from sparse: >> >> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type >> in assignment (different base types) >> dri

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

On 11-11-14 06:56, Gautam (Gautam Kumar) Shukla wrote: > Hi Gautam, Good to see more upstream contributions, but it might be useful to have a driver implementation as well in this series. Maybe we can take a shot with brcmfmac for obvious reasons. Would you happen to have wpa_supplicant changes a

Re: [PATCH 2/2] linux-wireless:Added wiphy capability flag for offloading 4way handshake to driver

On 11-11-14 07:27, Gautam (Gautam Kumar) Shukla wrote: > > For offloading 4 way handshake to driver , currently we don't have WIPHY > capability flag to communicate same to supplicant. > I have added the flag NL80211_ATTR_4WAY_KEY_HANDSHAKE and rest of the code > for the same. > > Tested on x8

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

On 11-11-14 10:29, Johannes Berg wrote: > On Tue, 2014-11-11 at 05:56 +, Gautam (Gautam Kumar) Shukla wrote: >> For offloading 4 way handshake to driver, currently we don't have any >> member of struct cfg80211_connect_params to pass PSK from supplicant >> to driver. I have added psk for the s

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

On 11-11-14 11:03, Johannes Berg wrote: > On Tue, 2014-11-11 at 10:54 +0100, Arend van Spriel wrote: > >>> Also, there's a competing approach from QCA that's far more suited. >> >> I probably was not paying attention to it, but would you have a >> refer

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

On 11-11-14 11:38, Johannes Berg wrote: > On Tue, 2014-11-11 at 11:35 +0100, Arend van Spriel wrote: > >> What did pop up is the wiphy flags vs. nl80211 feature flags. When that >> comes up it looks like 'potAtoes, potaetoes' to me. >> >> So is there are

Re: bluetooth related firmware loader spew on resume.

On 11/26/14 16:27, Takashi Iwai wrote: At Wed, 26 Nov 2014 17:26:15 +0200, Mihai Donțu wrote: On Wed, 26 Nov 2014 16:19:49 +0100 Takashi Iwai wrote: At Wed, 26 Nov 2014 16:56:09 +0200, Mihai Donțu wrote: On Tue, 11 Nov 2014 13:12:28 -0500 Dave Jones wrote: Since the addition of 10d4c6736e

Re: bluetooth related firmware loader spew on resume.

On 11/26/14 19:13, Takashi Iwai wrote: At Wed, 26 Nov 2014 18:42:46 +0100, Arend van Spriel wrote: On 11/26/14 16:27, Takashi Iwai wrote: At Wed, 26 Nov 2014 17:26:15 +0200, Mihai Donțu wrote: On Wed, 26 Nov 2014 16:19:49 +0100 Takashi Iwai wrote: At Wed, 26 Nov 2014 16:56:09 +0200

Re: bluetooth related firmware loader spew on resume.

On 11/27/14 10:17, Takashi Iwai wrote: At Thu, 27 Nov 2014 09:59:12 +0100, Arend van Spriel wrote: On 11/26/14 19:13, Takashi Iwai wrote: At Wed, 26 Nov 2014 18:42:46 +0100, Arend van Spriel wrote: On 11/26/14 16:27, Takashi Iwai wrote: At Wed, 26 Nov 2014 17:26:15 +0200, Mihai Donțu wrote

Re: bluetooth related firmware loader spew on resume.

On 11/27/14 10:29, Arend van Spriel wrote: On 11/27/14 10:17, Takashi Iwai wrote: At Thu, 27 Nov 2014 09:59:12 +0100, Arend van Spriel wrote: On 11/26/14 19:13, Takashi Iwai wrote: At Wed, 26 Nov 2014 18:42:46 +0100, Arend van Spriel wrote: On 11/26/14 16:27, Takashi Iwai wrote: At Wed

Re: [patch] CodingStyle: add some more error handling guidelines

On 12/03/14 13:31, SF Markus Elfring wrote: diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 9f28b14..9c8a234 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle @@ -392,7 +392,12 @@ The goto statement comes in handy when a function exits from multiple

Re: linux-next: manual merge of the driver-core tree with the net-next tree

On 12/03/14 11:51, Jeremiah Mahler wrote: On Wed, Dec 03, 2014 at 12:36:55AM -0800, Jeremiah Mahler wrote: all, On Mon, Dec 01, 2014 at 08:34:05AM +0100, Arend van Spriel wrote: On 01-12-14 08:19, Stephen Rothwell wrote: Hi Greg, Today's linux-next merge of the driver-core tree

Re: [patch] CodingStyle: add some more error handling guidelines

On 12/03/14 14:24, SF Markus Elfring wrote: Sorry. I misread your email. If the code looks like this: foo = kmalloc(); if (!foo) goto kmalloc_failed; The "kmalloc_failed" doesn't add any information. I find that this such a name approach would fit to your exp

Re: [patch] CodingStyle: add some more error handling guidelines

On 12/03/14 17:00, SF Markus Elfring wrote: Which name pattern do you find more appropriate in such an use case? I think Dan wants the label to be descriptive about the tasks needed in the exception handling itself. I would usually prefer also such a target-oriented labelling for the affected

Re: linux-next: manual merge of the driver-core tree with the net-next tree

On 12/03/14 17:21, Greg KH wrote: On Wed, Dec 03, 2014 at 01:49:00PM +0100, Arend van Spriel wrote: On 12/03/14 11:51, Jeremiah Mahler wrote: On Wed, Dec 03, 2014 at 12:36:55AM -0800, Jeremiah Mahler wrote: all, On Mon, Dec 01, 2014 at 08:34:05AM +0100, Arend van Spriel wrote: On 01-12-14

Re: [PATCH] brcmfmac: fix error handling of irq_of_parse_and_map

...@vger.kernel.org # v3.17 +Acked-by: Arend van Spriel Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b

Re: [PATCH] debugfs: add helper function to create device related seq_file

On 12-10-14 10:13, Arend van Spriel wrote: > On 11-10-14 22:17, Greg Kroah-Hartman wrote: >> On Sat, Oct 11, 2014 at 06:01:55PM +0200, Arend van Spriel wrote: >>> This patch adds a helper function that simplifies adding a >>> sequence file for device drivers. The calling

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

On 10/09/14 18:54, Rafał Miłecki wrote: On 9 October 2014 18:41, Guenter Roeck wrote: Commit 2101e533f41a ("bcma: register bcma as device tree driver") introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS is specifically disabled for the sparc architecture. This results i

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

On 10/09/14 19:15, Arend van Spriel wrote: On 10/09/14 18:54, Rafał Miłecki wrote: On 9 October 2014 18:41, Guenter Roeck wrote: Commit 2101e533f41a ("bcma: register bcma as device tree driver") introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS is sp

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

On 10/09/14 23:48, Hauke Mehrtens wrote: On 10/09/2014 09:25 PM, Guenter Roeck wrote: On Thu, Oct 09, 2014 at 08:28:31PM +0200, Hauke Mehrtens wrote: On 10/09/2014 07:29 PM, Guenter Roeck wrote: On Thu, Oct 09, 2014 at 07:18:31PM +0200, Arend van Spriel wrote: On 10/09/14 19:15, Arend van

[PATCH] debugfs: add helper function to create device related seq_file

his data from it and do its seq_printf() calls. Signed-off-by: Arend van Spriel --- fs/debugfs/file.c | 54 + include/linux/debugfs.h | 16 ++- 2 files changed, 69 insertions(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs

Re: [PATCH] debugfs: add helper function to create device related seq_file

On 10/11/14 18:01, Arend van Spriel wrote: This patch adds a helper function that simplifies adding a sequence file for device drivers. The calling device driver needs to provide a read function and a device pointer. The field struct seq_file::private will reference the device pointer upon call

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

On 05/21/15 17:35, Takashi Iwai wrote: At Thu, 21 May 2015 11:26:17 -0400 (EDT), Alan Stern wrote: On Thu, 21 May 2015, Takashi Iwai wrote: At Thu, 21 May 2015 10:18:08 -0400 (EDT), Alan Stern wrote: On Thu, 21 May 2015, Takashi Iwai wrote: Then avoiding the failed firmware is no solution

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

On 05/21/15 19:32, Takashi Iwai wrote: At Thu, 21 May 2015 19:27:41 +0200, Arend van Spriel wrote: On 05/21/15 17:35, Takashi Iwai wrote: At Thu, 21 May 2015 11:26:17 -0400 (EDT), Alan Stern wrote: On Thu, 21 May 2015, Takashi Iwai wrote: At Thu, 21 May 2015 10:18:08 -0400 (EDT), Alan

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

On 05/22/15 02:21, Laura Abbott wrote: On 05/21/2015 08:26 AM, Alan Stern wrote: On Thu, 21 May 2015, Marcel Holtmann wrote: Hi Alan, Then avoiding the failed firmware is no solution, indeed. If it's a new probe, it should be never executed during resume. Can you expand this comment? What'

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

On 05/22/15 09:37, Arend van Spriel wrote: On 05/22/15 02:21, Laura Abbott wrote: On 05/21/2015 08:26 AM, Alan Stern wrote: On Thu, 21 May 2015, Marcel Holtmann wrote: Hi Alan, Then avoiding the failed firmware is no solution, indeed. If it's a new probe, it should be never executed d

Re: [PATCH resend] README: clarify redistribution requirements covering patents

On 05/14/15 19:56, Luis R. Rodriguez wrote: From: "Luis R. Rodriguez" Firmware licenses on linux-firmware should include an implicit or explicit patent grant to end users for full device operation otherwise it would start making linux-firmware useless for many Linux distributions which have posi

Re: [PATCH v2] brcmfmac: prohibit ACPI power management for brcmfmac driver

ading the code wonder whether a mistake has been made. So I would prefer to have the assignment separate for the if statement. For the update patch you may add: Acked-by: Arend van Spriel Regards, Arend + adev->flags.power_manageable = 0; + /* Consume f

Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver

uring suspend/resume process on some tablet platforms(such as ASUS T100TA). This is not supported by brcmfmac driver now, and the context of WiFi chip will be damaged after resume. This patch informs ACPI not to manage WiFi chip's power state. Signed-off-by: Zhonghui Fu Acked-by: Arend van Spriel -

4.1-rc2: build issue with duplicate redefinition of _PAGE_GLOBAL_SHIFT

For our upstream brcm80211 drivers we build for a number of architectures including MIPS. In recent builds we get an error/warning: CC [M] drivers/net/wireless/brcm80211/brcmfmac/cfg80211.o In file included from ./arch/mips/include/asm/io.h:27:0, from ./arch/mips/include/asm/

Re: 4.1-rc2: build issue with duplicate redefinition of _PAGE_GLOBAL_SHIFT

On 05/13/15 21:19, Jonas Gorski wrote: Hi Arend, On Wed, May 13, 2015 at 8:43 PM, Arend van Spriel wrote: For our upstream brcm80211 drivers we build for a number of architectures including MIPS. In recent builds we get an error/warning: CC [M] drivers/net/wireless/brcm80211/brcmfmac

Re: [PATCH 57/86] brcm80211: use uapi/linux/pci_ids.h directly

On 03/29/15 15:41, Michael S. Tsirkin wrote: Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Acked-by: Arend van Spriel Signed-off-by: Michael S. Tsirkin --- drivers/net/wireless/brcm80211/include

Re: [PATCH 83/86] brcm80211: drop pci dependency

On 03/29/15 15:43, Michael S. Tsirkin wrote: This file does not use any pci APIs, drop pci header includes. Acked-by: Arend van Spriel Signed-off-by: Michael S. Tsirkin --- drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net

Re: [PATCH 84/86] brcm80211: drop pci_ids include

On 03/29/15 15:43, Michael S. Tsirkin wrote: This file does not use any pci ids, drop pci_ids.h include. Acked-by: Arend van Spriel Signed-off-by: Michael S. Tsirkin --- drivers/net/wireless/brcm80211/brcmfmac/sdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless

Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

Patch was compile tested with x86_64_defconfig + CONFIG_BRCMFMAC=m Patch is agianst 4.0-rc4 (localversion-next is -next-20150317) It applies to wireless-drivers-next/master as well so Acked-by: Arend van Spriel Signed-off-by: Nicholas Mc Guire --- drivers/net/wireless/brcm80211/brcmfmac/

Re: [PATCH v2] brcmfmac: avoid duplicated suspend/resume operation

, Arend Acked-by: Arend van Spriel Signed-off-by: Zhonghui Fu --- Changes in v2: - Remove two "Acked-by" lines drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmfma

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

ations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel Signed-off-by: Zhonghui Fu --- And when using version info a change log here is even better. Although admittedly I lost track which version this would be ;-) Regards, Arend --- drivers/ne

Re: [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation

On 03/02/15 16:08, Kalle Valo wrote: Arend van Spriel writes: Now that there is not 3.20 version. My understanding is that this patch will be in linus' tree 4.1-rc1, right? Yes. It will go into linux-next first, which you can consider to be an incubator where all stuff for the next re

Re: [PATCH] brcmfmac: use msecs_to_jiffies for time conversion

On 02/06/15 11:26, Nicholas Mc Guire wrote: This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Acked-by: Arend van Spriel Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with x86_64_defconfig

Re: [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation

do the same things. This patch avoid this case. Acked-by: Arend van Spriel Signed-off-by: Fu Zhonghui --- Changes in v3: - Rebase to wireless-drivers-next/master branch drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

Re: Linux 4.0-rc1 out..

On 02/23/15 04:06, Linus Torvalds wrote: On the other hand, the strongest argument for some people advocating 4.0 seems to have been a wish to see 4.1.15 - because "that was the version of Linux skynet used for the T-800 terminator". So they have changed our future already as we will likely hit

Re: [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation

On 02/27/15 08:53, Fu, Zhonghui wrote: On 2015/2/16 17:35, Arend van Spriel wrote: On 02/16/15 08:34, Fu, Zhonghui wrote: On 2015/2/15 22:54, Kalle Valo wrote: Arend van Spriel writes: On 02/15/15 04:27, Pat Erley wrote: On 02/14/2015 08:40 PM, Fu, Zhonghui wrote: Any comments to this

Re: [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation

On 02/16/15 08:34, Fu, Zhonghui wrote: On 2015/2/15 22:54, Kalle Valo wrote: Arend van Spriel writes: On 02/15/15 04:27, Pat Erley wrote: On 02/14/2015 08:40 PM, Fu, Zhonghui wrote: Any comments to this patch? Can it be accepted? I assume that patches are queued up until after the merge

Re: mmc: Driver Strength Device Property

On 02/16/15 15:25, Adrian Hunter wrote: I am in the process of adding an ACPI Device Property to specify the driver strength (aka drive strength, driver type) for use with eMMC/SD/SDIO cards, however the ACPI Specification Workgroup requires that Device Properties be sufficiently generic. This ra

Re: mmc: Driver Strength Device Property

On 02/16/15 22:47, Adrian Hunter wrote: On 16/02/2015 7:47 p.m., Philip Rakity wrote: On Feb 16, 2015, at 5:39 PM, Arend van Spriel wrote: On 02/16/15 15:25, Adrian Hunter wrote: I am in the process of adding an ACPI Device Property to specify the driver strength (aka drive strength

Re: [PATCH v2 1/4] pci: iProc: define Broadcom iProc PCIe binding

Hauke's patch series, we've discussed this in great length already. As Arend van Spriel pointed out in the previous discussion: BCMA core is the bus driver for discoverable ARM AXI interconnect. Apart from that it also provides drivers for some cores. For the chips to be discoverabl

Re: [PATCH v2 1/4] pci: iProc: define Broadcom iProc PCIe binding

On 12/13/14 20:46, Arnd Bergmann wrote: On Saturday 13 December 2014 11:05:52 Arend van Spriel wrote: Makes sense. I think that is what Hauke meant by "adding additional support for registering to bcma". So the discovery info is a piece of read-only memory in the chip. Its address is

Re: [PATCH v2] mwifiex: fix possible NULL dereference

On 12-04-16 13:46, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. And you are changing the scope of the pdev variab

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

On 13-4-2016 10:38, Johannes Berg wrote: > >> The patch was build-tested / debugged by removing the >> "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or less) dead > code, since I don't think anyone really ever touches this driver any > more o

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

On 11/19/2015 08:54 AM, Kalle Valo wrote: Florian Fainelli writes: On 18/11/15 11:19, Hauke Mehrtens wrote: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles from subdirectories to use the new location. S

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

On 11/19/2015 08:48 AM, Kalle Valo wrote: Hauke Mehrtens writes: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles from subdirectories to use the new location. Signed-off-by: Kalle Valo --- I would pref

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

On 11/22/2015 06:23 PM, Kalle Valo wrote: Arend van Spriel writes: On 11/19/2015 08:48 AM, Kalle Valo wrote: Hauke Mehrtens writes: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles from subdirectories

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

On 11/23/2015 11:28 AM, Arend van Spriel wrote: On 11/22/2015 06:23 PM, Kalle Valo wrote: Arend van Spriel writes: On 11/19/2015 08:48 AM, Kalle Valo wrote: Hauke Mehrtens writes: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note

Re: [PATCH] brcmfmac: fix waitqueue_active without memory barrier in brcmfmac driver

On 10/09/2015 02:35 AM, Kosuke Tatsukawa wrote: > brcmf_msgbuf_ioctl_resp_wake() seems to be missing a memory barrier > which might cause the waker to not notice the waiter and miss sending a > wake_up as in the following figure. My mail reader treats this as HTML format or so. Can you resend it i

Re: [PATCH] brcmfmac: fix waitqueue_active without memory barrier in brcmfmac driver

On 10/09/2015 02:35 AM, Kosuke Tatsukawa wrote: > brcmf_msgbuf_ioctl_resp_wake() seems to be missing a memory barrier > which might cause the waker to not notice the waiter and miss sending a > wake_up as in the following figure. > >brcmf_msgbuf_ioctl_resp_wake brcmf_msgbuf_i

Re: [PATCH] net: brcm80211: Delete an unnecessary check before the function call "release_firmware"

Coccinelle software. Acked-by: Arend van Spriel Signed-off-by: Markus Elfring --- drivers/net/wireless/brcm80211/brcmfmac/firmware.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/brcm80211/brcmfmac

Re: [PATCH] brcmfmac: constify brcmf_bus_ops structures

On 11/14/2015 05:22 PM, Julia Lawall wrote: The brcmf_bus_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Acked-by: Arend van Spriel Signed-off-by: Julia Lawall --- drivers/net/wireless/brcm80211/brcmfmac/bus.h |2 +- drivers/net

Re: [PATCH] brcmfmac: replace strncpy() by strscpy()

/brcm80211/brcmfmac/cfg80211.c:4227:2: warning: 'strncpy' output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation] strncpy(iebuf, add_del_cmd, VNDR_IE_CMD_LEN - 1); ^~~~ Acked-

Re: [PATCH] brcmsmac: remove a useless test

On 9/15/2019 9:32 PM, Christophe JAILLET wrote: 'pih' is known to be non-NULL at this point, so the test can be removed. Acked-by: Arend van Spriel Signed-off-by: Christophe JAILLET --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 3 +-- 1 file changed, 1 inser

Re: [PATCH 00/20] Add support for Silicon Labs WiFi chip WF200 and further

On 9/19/2019 1:25 PM, Greg Kroah-Hartman wrote: - I also kept compatibility code for earlier Linux kernel version. I may drop it in future. Maybe I will maintain compatibility with older kernels in a external set of patches. That has to be dropped for the in-kernel version. There

Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions

one was even paying attention to the return value. Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "David S. Miller" Cc: Pieter-Paul Giesberts Cc: Greg Kroah-Hartman Cc: "Rafał Miłecki" Cc: linux-wirel..

Re: [PATCH] brcm80211: no need to check return value of debugfs_create functions

f above is true it would be better to make the debugfs function return void, but I won't ;-p In start_creating() the parent dentry is indeed checked for IS_ERR() so... Acked-by: Arend van Spriel Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng

Re: [PATCH] wireless: remove unneeded semicolon

On 1/18/2019 4:32 AM, YueHaibing wrote: remove unneeded semicolon Acked-by: Arend van Spriel Signed-off-by: YueHaibing --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-

Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354

On 5/18/2019 12:54 AM, Douglas Anderson wrote: In commit 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") we disabled something called "command decode in sdio_aos" for a whole bunch of Broadcom SDIO WiFi parts. After that patch landed I find that my kernel log on rk3288-veyron-mi

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

On 5/19/2019 11:06 AM, Wolfram Sang wrote: Let's add an API that the SDIO card drivers can call that will temporarily disable the auto-tuning functionality. Then we can add a call to this in the Broadcom WiFi driver and any other driver that might have similar needs. Can't you fix the WiFi d

Re: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep

On 5/18/2019 12:54 AM, Douglas Anderson wrote: This series attempts to deal better with the expected transmission errors that we get when waking up the SDIO-based WiFi on rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. Some details about those errors can be found in

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

On 5/18/2019 12:54 AM, Douglas Anderson wrote: Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will trigger a retuning of the card. This is generally a good idea. Probably a question for Adrian, but how is this retuning scheduled. I recall seeing somet

Re: Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

On 5/26/2019 2:21 PM, Brian Masney wrote: + Broadcom wireless maintainers On Fri, May 24, 2019 at 11:49:58AM -0400, Brian Masney wrote: On Fri, May 24, 2019 at 03:17:13PM +0300, Adrian Hunter wrote: On 24/05/19 2:10 PM, Brian Masney wrote: WiFi stopped working on the LG Nexus 5 phone and the

<    1   2   3   4   5   6   >