Re: [RFC v2] Add mempressure cgroup

2012-12-10 Thread Anton Vorontsov
On Mon, Dec 10, 2012 at 01:50:28PM +0200, Kirill A. Shutemov wrote: [...] > I think the interface is broken. One eventfd can be registered to get > many different notifications. But anyone is free to do anything they like with a gun and their leg. :) They simply should not do this, since yes, they

Re: [PATCH 00/12] Refactoring the ab8500 battery management drivers

2012-12-10 Thread Anton Vorontsov
On Fri, Nov 30, 2012 at 11:57:22AM +, Lee Jones wrote: > The aim of this and subsequent patch-sets is to refactor battery > management services provided by the ab8500 MFD. This first patch-set > brings a few modifications to the collection which happened on the > internal kernel, but were never

Re: [PATCH RESEND] pstore: fix NULL pointer dereference in console writes

2012-11-14 Thread Anton Vorontsov
On Wed, Nov 14, 2012 at 11:49:53AM +, Colin King wrote: > From: Colin Ian King > > Passing a NULL id causes a NULL pointer deference in writers > such as erst_writer and efi_pstore_write because they expect > to update this id. Pass a dummy id instead. > > This avoids a cascade of oopses ca

[GIT PULL] linux-pstore.git

2012-11-14 Thread Anton Vorontsov
initial pstore_console_write passes a null which in turn causes writes to the console causing further oopses in subsequent pstore_console_write calls. Signed-off-by: Colin Ian King Acked-by: Kees Cook Cc: sta...@vger.kernel.org Signed-off-by: Anton Vorontsov diff --git a

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-14 Thread Anton Vorontsov
Hi David, Thanks for your comments! On Wed, Nov 14, 2012 at 07:21:14PM -0800, David Rientjes wrote: > > > Why should you be required to use cgroups to get VM pressure events to > > > userspace? > > > > Valid point. But in fact you have it on most systems anyway. > > > > I personally don't like

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-14 Thread Anton Vorontsov
Hi David, Thanks again for your inspirational comments! On Wed, Nov 14, 2012 at 07:59:52PM -0800, David Rientjes wrote: > > > I agree that eventfd is the way to go, but I'll also add that this > > > feature > > > seems to be implemented at a far too coarse of level. Memory, and hence > > > me

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-15 Thread Anton Vorontsov
On Thu, Nov 15, 2012 at 12:11:47AM -0800, David Rientjes wrote: [...] > Might not be too difficult if you implement your own cgroup to aggregate > these tasks for which you want to know memory pressure events; it would > have to be triggered for the task trying to allocate memory at any given >

[RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-07 Thread Anton Vorontsov
Hi all, This is the third RFC. As suggested by Minchan Kim, the API is much simplified now (comparing to vmevent_fd): - As well as Minchan, KOSAKI Motohiro didn't like the timers, so the timers are gone now; - Pekka Enberg didn't like the complex attributes matching code, and so it is no long

[RFC 1/3] mm: Add VM pressure notifications

2012-11-07 Thread Anton Vorontsov
to determine the pre-OOM condition, the pre-OOM priority level can be set via vmpressure_level_oom_prio sysctl. Signed-off-by: Anton Vorontsov --- Documentation/sysctl/vm.txt | 48 arch/x86/syscalls/syscall_64.tbl | 1 + include/linux/syscalls.h | 2 + include/linux/vmpr

[RFC 2/3] tools/testing: Add vmpressure-test utility

2012-11-07 Thread Anton Vorontsov
Just a simple test/example utility for the vmpressure_fd(2) system call. Signed-off-by: Anton Vorontsov --- tools/testing/vmpressure/.gitignore| 1 + tools/testing/vmpressure/Makefile | 30 ++ tools/testing/vmpressure/vmpressure-test.c | 93

[RFC 3/3] man-pages: Add man page for vmpressure_fd(2)

2012-11-07 Thread Anton Vorontsov
. CONFORMING TO The system call is Linux-specific. EXAMPLE Examples can be found in /usr/src/linux/tools/testing/vmpressure/ directory. SEE ALSO poll(2), read(2), proc(5), sysctl(5), vmstat(8) Linux 2012-10-16 VMPRESSURE_FD(

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-07 Thread Anton Vorontsov
On Wed, Nov 07, 2012 at 01:21:36PM +0200, Kirill A. Shutemov wrote: [...] > Sorry, I didn't follow previous discussion on this, but could you > explain what's wrong with memory notifications from memcg? > As I can see you can get pretty similar functionality using memory > thresholds on the root cg

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-07 Thread Anton Vorontsov
On Wed, Nov 07, 2012 at 01:30:16PM +0200, Pekka Enberg wrote: [...] > I love the API and implementation simplifications but I hate the new > ABI. It's a specialized, single-purpose syscall and bunch of procfs > tunables and I don't see how it's 'extensible' to anything but VM It is extensible to V

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-07 Thread Anton Vorontsov
On Wed, Nov 07, 2012 at 02:11:10PM +0200, Kirill A. Shutemov wrote: [...] > >We can have plenty of "free" memory, of which say 90% will be caches, > >and say 10% idle. But we do want to differentiate these types of memory > >(although not going into details about it), i.e. we want to ge

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-09 Thread Anton Vorontsov
On Fri, Nov 09, 2012 at 09:32:03AM +0100, Luiz Capitulino wrote: > Anton Vorontsov wrote: > > This is the third RFC. As suggested by Minchan Kim, the API is much > > simplified now (comparing to vmevent_fd): > > Which tree is this against? I'd like to try this series,

[PATCH 1/2] Add mempressure cgroup

2013-01-04 Thread Anton Vorontsov
ntually we might add a lightweight, non-cgroups API, i.e. vmevent. But this is another story. Signed-off-by: Anton Vorontsov --- Documentation/cgroups/mempressure.txt | 50 ++ include/linux/cgroup_subsys.h | 6 + include/linux/vmstat.h|

[PATCH 0/2] Mempressure cgroup

2013-01-04 Thread Anton Vorontsov
Hi all, Here is another round of the mempressure cgroup. This time I dared to remove the RFC tag. :) In this revision: - Addressed most of Kirill Shutemov's comments. I didn't bother implementing per-level lists, though. It would needlessly complicate the logic, and the gain would be only vi

[PATCH 2/2] Add shrinker interface for mempressure cgroup

2013-01-04 Thread Anton Vorontsov
eport different kinds information (i.e. with the shrinker you don't know the actual system state -- how bad/good the memory situation is). The interface is well documented and comes with a stress-test utility. Signed-off-by: Anton Vorontsov --- Documentation/cgroups/mempressure.tx

Re: [PATCH 00/18] AB8500 battery management series upgrade

2013-01-05 Thread Anton Vorontsov
On Thu, Dec 13, 2012 at 03:21:23PM +, Lee Jones wrote: > Please find the next instalment of the AB8500 Power drivers upgrade. > A lot of work has taken place on the internal development track, but > little effort has gone into mainlining it. At last count there were > around 70+ patches which a

Re: [PATCH 1/3] charger-manager: Fix bug related to checking fully charged state of battery

2013-01-05 Thread Anton Vorontsov
On Thu, Nov 22, 2012 at 04:44:15PM +0900, Chanwoo Choi wrote: > This patch fix bug related to checking fully charged state of battery > when charger-manager call is_full_charged() function. After reading > property of charger/fuel-gauge through power_supply API, val.intval is > more than 1. So, is_

Re: [PATCH 01/25] charger_manager: don't use [delayed_]work_pending()

2013-01-05 Thread Anton Vorontsov
r. It's a very unusual > construct and I'm fairly sure it's racy. You can't break such > circular dependency by calling cancel on each. I strongly recommend > revising the mechanism. > > Signed-off-by: Tejun Heo > Cc: Anton Vorontsov > Cc: David Woodh

Re: [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-18 Thread Anton Vorontsov
Hello Luiz, On Tue, Dec 18, 2012 at 06:16:55PM -0200, Luiz Capitulino wrote: > The auto-ballooning feature automatically performs balloon inflate > or deflate based on host and guest memory pressure. This can help to > avoid swapping or worse in both, host and guest. > > Auto-ballooning has a hos

[GIT PULL] (part2) battery-2.6.git

2012-12-18 Thread Anton Vorontsov
Hello Linus, Here is the second part of the battery tree patches. These are left overs that I didn't have time to review/apply before the merge window opened. I didn't want to "spoil" the first pull request with these late patches, so they were not included. But the stuff is simple enough, so I t

Re: [PATCH v3 0/2] pstore,efi_pstore: Avoid deadlock in non-blocking paths

2012-12-21 Thread Anton Vorontsov
On Fri, Dec 21, 2012 at 11:27:00PM +, Seiji Aguchi wrote: > Tony, > > Could you please apply this patchset to your tree? Actually, I'd prefer to take both patches via pstore tree. The EFI part is isolated and small, so even if it conflicts, it would be easy to resolve, unlike to pstore core p

Re: [PATCH v8 1/3] Runtime Interpreted Power Sequences

2012-11-15 Thread Anton Vorontsov
Hi Alexandre, The code looks neat, thanks for you work! Just a couple of comments... On Fri, Nov 16, 2012 at 03:38:21PM +0900, Alexandre Courbot wrote: [...] > + > +#include "power_seq_delay.c" > +#include "power_seq_regulator.c" > +#include "power_seq_pwm.c" > +#include "power_seq_gpio.c" This

Re: [PATCH v8 2/3] pwm_backlight: use power sequences

2012-11-16 Thread Anton Vorontsov
On Fri, Nov 16, 2012 at 09:49:58AM +0100, Thierry Reding wrote: > On Fri, Nov 16, 2012 at 03:38:22PM +0900, Alexandre Courbot wrote: > > Make use of the power sequences specified in the device tree or platform > > data to control how the backlight is powered on and off. > > > > Signed-off-by: Alex

Re: [PATCH RESEND] power: generic-adc-battery: Fix checking return value of request_any_context_irq

2012-11-16 Thread Anton Vorontsov
On Fri, Nov 16, 2012 at 05:09:22PM +0800, Axel Lin wrote: > On failure, request_any_context_irq() returns a negative value. > On success, it returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED. > > Signed-off-by: Axel Lin > --- > This was sent on https://lkml.org/lkml/2012/10/11/77 > Nobody picks up

Re: [PATCH v8 1/3] Runtime Interpreted Power Sequences

2012-11-16 Thread Anton Vorontsov
On Fri, Nov 16, 2012 at 06:44:22PM +0900, Alex Courbot wrote: > On 11/16/2012 04:26 PM, Anton Vorontsov wrote: > >>+#include "power_seq_delay.c" > >>+#include "power_seq_regulator.c" > >>+#include "power_seq_pwm.c" > >>+#i

Re: [RFC v3 0/3] vmpressure_fd: Linux VM pressure notifications

2012-11-16 Thread Anton Vorontsov
On Fri, Nov 16, 2012 at 01:57:09PM -0800, David Rientjes wrote: > > > I'm wondering if we should have more than three different levels. > > > > > > > In the case I outlined below, for backwards compatibility. What I > > actually mean is that memcg *currently* allows arbitrary notifications. > > O

Re: [patch] power: battery: pointer math issue in gab_probe()

2012-11-16 Thread Anton Vorontsov
On Sat, Sep 29, 2012 at 10:13:46AM +0300, Dan Carpenter wrote: > psy->properties is an enum (32 bit type) so adding sizeof() puts us > four times further along than we intended. It should be cast to a char > pointer before doing the math. > > Signed-off-by: Dan Carpenter > --- > Casting to void

Re: [PATCH] ramoops: Fixup section annotations

2012-11-16 Thread Anton Vorontsov
On Mon, Oct 22, 2012 at 11:53:33AM -0700, Kees Cook wrote: > On Wed, Oct 17, 2012 at 12:39 AM, Hannes Reinecke wrote: > > The compiler complained about missing section annotations. > > Fix it. > > > > Signed-off-by: Hannes Reinecke > > Cc: Anton Vorontsov >

Re: [PATCH v2] pstore/ram: no timekeeping calls when unavailable

2012-11-16 Thread Anton Vorontsov
On Fri, Nov 09, 2012 at 05:26:53PM -0800, Kees Cook wrote: [] > >> @@ -171,7 +171,13 @@ static size_t ramoops_write_kmsg_hdr(struct > >> persistent_ram_zone *prz) > >> struct timeval timestamp; > >> size_t len; > >> > >> - do_gettimeofday(×tamp); > >> + /* Handle dum

Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

2012-11-17 Thread Anton Vorontsov
On Sat, Nov 17, 2012 at 07:55:45PM +0900, Alexandre Courbot wrote: > Some device drivers (e.g. panel or backlights) need to follow precise > sequences for powering on and off, involving GPIOs, regulators, PWMs > and other power-related resources, with a defined powering order and > delays to respec

Re: [PATCH v2] pstore/ram: fix undefined usage of rounddown_pow_of_two(0)

2012-11-17 Thread Anton Vorontsov
On Mon, Oct 22, 2012 at 08:17:27AM -0700, Kees Cook wrote: > On Mon, Oct 22, 2012 at 2:19 AM, Florian Fainelli > wrote: > > From: Maxime Bizon > > > > record_size / console_size / ftrace_size can be 0 (this is how you > > disable the feature), but rounddown_pow_of_two(0) is undefined. As suggest

Re: [PATCH v3 2/9] pstore: add debugfs support for causing dumps and panics

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 02:06:00PM +0300, dragos.tatu...@intel.com wrote: > From: Adrian Hunter > > There are 2 debugfs files: > > pstore/dump writing a kmsg dump reason code > will cause a dump to persistent > storage > > pstore/panic

Re: [PATCH v3 4/9] pstore: allow storing different type id's in ram backend

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 02:06:02PM +0300, dragos.tatu...@intel.com wrote: > From: Dragos Tatulea > > Added pstore_type_id in message header when storing to ram. > On write, take into account the contents of this header and > set the type accordingly. > > Signed-off-by: Dragos Tatulea > --- [...

Re: [PATCH v3 7/9] pstore: make sure pstore_write exists on flush error

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 02:06:05PM +0300, dragos.tatu...@intel.com wrote: > From: Dragos Tatulea > > Return error if flushing to backend failed. I think you can easily fold this into 'pstore: add support for external writers'. Thanks. > Signed-off-by: Dragos Tatulea > --- > fs/pstore/platfor

Re: [PATCH v3 8/9] pstore: max out console log level during sysfs dump switch

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 02:06:06PM +0300, dragos.tatu...@intel.com wrote: > From: Dragos Tatulea > > Otherwise we might miss out on some pstore dumpers that use > printks below current log level. If anything, this should be folded into 'pstore: add debugfs support for causing dumps and panics'.

Re: [PATCH v3 5/9] pstore: add task list dumper

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 02:06:03PM +0300, dragos.tatu...@intel.com wrote: > From: Dragos Tatulea > > The task dumper can dump task information during a panic. > This is equivalent to a magic sysrq 't' command but > the result is captured from the console and written > to persistent storage. Note

Re: [PATCH v3 3/9] pstore: add support for external writers

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 02:06:01PM +0300, dragos.tatu...@intel.com wrote: > From: Adrian Hunter > > Other modules that may wish to write to persistent storage > are supported by adding a notifier and write function. > > The notifier has 3 events: PSTORE_BEGIN, PSTORE_DUMP and > PSTORE_END. Exte

Re: [PATCH 5/6] power: da9052-battery: Convert to the new da9052 interrupt functions

2012-11-17 Thread Anton Vorontsov
On Thu, Oct 04, 2012 at 12:15:08AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Convert to the new da9052 interrupt functions, so that we can get rid of > irq_base references. > > Cc: Anton Vorontsov > Signed-off-by: Fabio Estevam > --- It seems that th

Re: [PATCH 2/2] power_supply: Register power supply for thermal cooling device

2012-11-17 Thread Anton Vorontsov
On Tue, Oct 09, 2012 at 10:25:59PM +0530, Ramakrishna Pallala wrote: > This patch registers the power supply as a cooling device if the > power supply has support for charge throttling. > > Now with this change low level drivers need not register with > thermal framework as it is automatically don

Re: [PATCH v2 3/3] lp8788-charger: fix wrong ADC conversion

2012-11-17 Thread Anton Vorontsov
On Fri, Nov 02, 2012 at 10:09:20AM +, Jonathan Cameron wrote: [...] > > Looks good to me, fwiw: > > > > Reviewed-by Lars-Peter Clausen > > On this stuff as far as I'm concerned Lars' approval is fine but > for what it's worth this all looks fine to me. > > Acked-by: Jonathan Cameron All th

Re: [patch] ds2782_battery: signedness bug in ds278x_read_reg16()

2012-11-18 Thread Anton Vorontsov
On Wed, Oct 24, 2012 at 10:12:29AM +0300, Dan Carpenter wrote: > We need to check for negative values before doing the swab16() for the > error handling to work. > > Signed-off-by: Dan Carpenter Applied, thanks! > diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c > in

Re: [PATCH RESEND] max17042: missing assignment

2012-11-18 Thread Anton Vorontsov
On Thu, Oct 25, 2012 at 02:28:03PM +, Pallala, Ramakrishna wrote: > > Thanks Alan. > > > The second error check is unreachable because the lock function isn't > > assigned > > to ret > > > > Signed-off-by: Alan Cox > Acked-by: Ramakrishna Pallala For some reason I don't have the original

Re: [PATCH v2] New Nokia RX-51 power supply battery driver

2012-11-18 Thread Anton Vorontsov
On Wed, Oct 31, 2012 at 10:48:40AM +0100, Pali Rohár wrote: > Hello, I fixed style issues and added it to Makefile and Kconfig. > > power_supply: Add Nokia RX-51 battery driver > > This driver exporting battery design capacity, temperature and voltage > for battery in Nokia RX-51. This driver is

Re: [PATCH] bq2415x charger driver

2012-11-18 Thread Anton Vorontsov
ries and fix some style issues... commit 7ad85830736f3e0d854becf7621eba3a0c926d13 Author: Anton Vorontsov Date: Sun Nov 18 15:48:52 2012 -0800 bq2415x_charger: Add Kconfig/Makefile entries This commit adds Kconfig and Makefile entries so that we could actually build the driver. Sign

Re: [PATCH] bq27x00_battery: Do not report nominal available capaciy if battery is not calibrated

2012-11-18 Thread Anton Vorontsov
On Sat, Nov 10, 2012 at 03:42:48PM +0100, Pali Rohár wrote: > Signed-off-by: Pali Rohár > --- > drivers/power/bq27x00_battery.c |8 > 1 file changed, 8 insertions(+) OK, I'm assuming we don't want this because otherwise we're getting bogus values in the sysfs, and so we confuse user

Re: [PATCH 2/2] drivres/power/jz4740-battery.c: Use devm_request_and_ioremap

2012-11-18 Thread Anton Vorontsov
On Fri, Nov 09, 2012 at 10:42:11AM +0100, Lars-Peter Clausen wrote: > On 11/07/2012 12:11 AM, Marcos Paulo de Souza wrote: > > No functional changes. Just a cleanup. > > > > Signed-off-by: Marcos Paulo de Souza > > Looks good to me: > > Acked-by: Lars-Peter Clausen Thanks for the patches and

Re: [PATCH] power: twl4030_charger: Change TWL4030_MODULE_* ids to TWL_MODULE_*

2012-11-18 Thread Anton Vorontsov
On Tue, Nov 13, 2012 at 10:42:11AM +0100, Peter Ujfalusi wrote: > To facilitate upcoming cleanup in twl stack. > No functional changes. > > Signed-off-by: Peter Ujfalusi > --- Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Anton Vorontsov
On Tue, Nov 06, 2012 at 03:42:44PM +0800, Qing Xu wrote: > From: Qing Xu > > Signed-off-by: Qing Xu > --- W/ this patch I'm getting this warning: CC drivers/power/max8925_power.o drivers/power/max8925_power.c: In function ‘max8925_power_probe’: drivers/power/max8925_power.c:479:3: w

Re: [PATCH 2/7] power_supply: Add charger control properties

2012-11-18 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 10:14:01PM +0530, Jenny TC wrote: > The battery charger needs to have control path along > with the reporting charger properties. In existing solutions > this is implemented using regulator framework. A regulator > framework doesn't fit a charger driver requirement because o

Re: [PATCH 3/7] power_supply : add supported charger cable feature

2012-11-18 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 10:14:02PM +0530, Jenny TC wrote: > A charger can support different types of charger sources (cables). > It make sense to define a field to inform the power supply subsystem > what kind of cable a charger driver supports. Since a bitmask would > be the easy way to do define

Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

2012-11-18 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 11:29:05AM +0900, Alex Courbot wrote: > On Saturday 17 November 2012 19:38:50 Anton Vorontsov wrote: > > > +++ b/drivers/power/power_seq/Kconfig > > > @@ -0,0 +1,2 @@ > > > +config POWER_SEQ > > > + tristate > > > > This r

Re: [PATCH 5/7] power_supply: Introduce Power Supply charging framework

2012-11-18 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 10:14:04PM +0530, Jenny TC wrote: > The Power Supply charging framework connects multiple subsystems > to do charging in a generic way. The subsystems involves power_supply, > extcon, and thermal. With this the charging is handled in a generic way. [...] > +void power_supply

Re: [PATCH 4/7] power_supply: add throttle state

2012-11-18 Thread Anton Vorontsov
On Thu, Oct 18, 2012 at 10:14:03PM +0530, Jenny TC wrote: > The charger and battery temperature contribute to the > platform thermal. The only way to control the temperature > is to control the charging. The charging can be controlled in different > way. This could be disabling charger, disabling c

Re: [PATCH 0/4] Implement device tree support for ab8500 BM Devices

2012-11-18 Thread Anton Vorontsov
On Wed, Oct 31, 2012 at 03:40:29PM +, Rajanikanth H.V wrote: > From: "Rajanikanth H.V" > > This patch-set adds device tree binding for ab8500 battery-managed > devices. Removes the redundant platform structure maintained > across bm devices and implements common DT probe routine across all th

Re: [PATCH 0/4] Implement device tree support for ab8500 BM Devices

2012-11-18 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 09:28:59AM +0530, Rajanikanth HV wrote: > > FWIW, I fixed these warnings. > > > > CHECK drivers/power/ab8500_bmdata.c > > drivers/power/ab8500_bmdata.c:146:23: warning: symbol > > 'temp_to_batres_tbl_thermistor' was not declared. Should it be static? > > drivers/power/a

Re: [PATCH v2 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 02:52:24PM +0800, Qing Xu wrote: > From: Qing Xu > > Signed-off-by: Qing Xu > --- > drivers/power/max8925_power.c | 61 +--- > 1 files changed, 56 insertions(+), 5 deletions(-) > > diff --git a/drivers/power/max8925_power.c b/driver

Re: [PATCH v3 4/7] mfd: max8925: support dt for power supply

2012-11-18 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 03:39:12PM +0800, Qing Xu wrote: > From: Qing Xu JFYI, I added the following text: This patch adds support for initializing platform data from the device-tree description. Plus added include. > Signed-off-by: Qing Xu > --- Applied, thank you! -- To unsubscribe from

Re: [PATCH v2] New Nokia RX-51 power supply battery driver

2012-11-19 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 01:18:29PM +0100, Pali Rohár wrote: [...] > Ok. Here is missing patch which register this driver in Nokia N900 board > code. Without it driver is not loaded. Cc'ing OMAP folks. > From 0b60efd06a71668439bcb761c6572dd7df91dc17 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Pal

Re: [RFC 3/3] man-pages: Add man page for vmpressure_fd(2)

2012-11-19 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 09:52:11PM -0800, Andrew Morton wrote: > On Wed, 7 Nov 2012 03:01:52 -0800 Anton Vorontsov > wrote: > >Upon these notifications, userland programs can cooperate with > >the kernel, achieving better system's memory management. &

Re: [PATCH] extcon : callback function to read cable property

2012-11-20 Thread Anton Vorontsov
On Tue, Nov 20, 2012 at 09:14:41AM +, Tc, Jenny wrote: [...] > > For example, > > Firstly, the power_supply charging framework check state of charger cable > > whether attached or detached cable. Second, when power_supply charging > > framework receive the changed state of host system from 'Hos

Re: [PATCH] extcon : callback function to read cable property

2012-11-20 Thread Anton Vorontsov
On Tue, Nov 20, 2012 at 11:08:54AM +, Tc, Jenny wrote: [...] > > | We may have: > > |enum extcon_cable_type { > > |EXTCON_CT_REGULATOR, > > |EXTCON_CT_PSY, > > |EXTCON_CT_CHARGER_CB, > > |... > > |}; > > | and have

Re: [PATCH v8 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-04-16 Thread Anton Vorontsov
On Wed, Apr 03, 2013 at 09:31:55AM -0700, Guenter Roeck wrote: > On Wed, Apr 03, 2013 at 08:18:12PM +0800, Hongbo Zhang wrote: > > Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 > > chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for > > all ABX

Re: [PATCH] power: rx51_battery: Fix reporting temperature

2013-04-16 Thread Anton Vorontsov
On Thu, Mar 28, 2013 at 05:42:23PM +0100, Pali Rohár wrote: > This patch fixing units (1/10 °C) in which is temperature reported. > > Signed-off-by: Pali Rohár > --- Applied, thanks! > drivers/power/rx51_battery.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH V2 2/3] power: power_supply: Add core support for supplied_from

2013-04-16 Thread Anton Vorontsov
On Tue, Apr 02, 2013 at 03:31:30PM -0600, Stephen Warren wrote: > On 04/01/2013 03:45 PM, Rhyland Klein wrote: > > This patch adds support for supplies to register a list of char *'s > > which represent the list of supplies which supply them. This is the > > opposite as the supplied_to list. > > T

Re: [PATCH V2 3/3] power: power_supply_core: Add support for supplied_from

2013-04-16 Thread Anton Vorontsov
On Mon, Apr 01, 2013 at 05:45:55PM -0400, Rhyland Klein wrote: > Adding support for supplied_from char * array. This is meant to store the > list of suppliers for a given supply, i.e. chargers for a battery. This > list can be populated through devicetree readily as well as passed > directly from t

Re: [PATCH] power: kmemdup instead of kzalloc + memcpy

2013-04-16 Thread Anton Vorontsov
On Wed, Mar 27, 2013 at 11:48:21PM +0200, Andrei Epure wrote: > Patch found using coccinelle. > > Signed-off-by: Andrei Epure > --- Applied, thanks! > drivers/power/charger-manager.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/power/charger-manager.c

Re: [PATCH] pm2301-charger: Fix suspend/resume

2013-04-16 Thread Anton Vorontsov
On Sat, Apr 13, 2013 at 01:20:07PM +0200, Lars-Peter Clausen wrote: > The pm2301-charger driver implements runtime pm and at the same time uses the > legacy pm callbacks for suspend and resume. This does not work since the I2C > core wont look at the legacy pm callbacks if a driver has the 'pm' fie

Re: [PATCH 2/2] MMC: P2020 SDHC: Fix bug when writing to SDHCI_HOST_CONTROL register

2013-06-13 Thread Anton Vorontsov
.of_node; > + if (of_device_is_compatible(np, "fsl,p2020-esdhc")) { > + /* Freescale messed up with P2020 as it has a non-standard > + * host control register > + */ Ditto. Otherwise, it looks good. Thanks! Reviewed-by: Anton Vorontsov > + h

Re: [PATCH 1/2] MMC: P2020 SDHC: Add support for 8-bit bus width and non-removable card

2013-06-13 Thread Anton Vorontsov
pdata); > + struct sdhci_host *host; > + int ret = 0; No need for the 0 initializer. Otherwise it looks OK, thanks! Reviewed-by: Anton Vorontsov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [GIT PULL] pstore/ram for 3.11

2013-06-14 Thread Anton Vorontsov
east they fix real issues for Rob. :) Acked-by: Anton Vorontsov (Or I can pick this via linux-pstore.git tree, I'll let Tony decide.) Thanks! Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH 1/8] 88pm860x_battery: remove unnecessary platform_set_drvdata()

2013-06-06 Thread Anton Vorontsov
On Mon, May 06, 2013 at 01:16:30PM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to

Re: [PATCH] power: lp8727: support the device tree feature

2013-06-06 Thread Anton Vorontsov
On Fri, May 10, 2013 at 07:17:51AM +, Kim, Milo wrote: > The interrupt and charging parameters are configurable in the device tree > structure. In the board test, a GPIO is used for handling LP8727 interrupts. > The device tree binding documentation is added also. > > Signed-off-by: Milo(Woogy

Re: [PATCH] power_supply: pm2301_charger: Return error if create_singlethread_workqueue fails

2013-06-06 Thread Anton Vorontsov
On Mon, May 20, 2013 at 01:42:43PM +0200, Linus Walleij wrote: > On Thu, May 16, 2013 at 3:17 PM, Axel Lin wrote: > > > Return error instead of 0 if create_singlethread_workqueue call fails. > > > > Signed-off-by: Axel Lin > > Acked-by: Linus Walleij Also applied, thank you! Anton -- To unsu

Re: [PATCH] power_supply: pm2301_charger: Fix NULL pointer dereference

2013-06-06 Thread Anton Vorontsov
On Fri, May 17, 2013 at 03:45:55PM +0200, Linus Walleij wrote: > On Thu, May 16, 2013 at 11:31 AM, Axel Lin wrote: > > > Add checking pl_data in probe, this prevent possible NULL pointer > > dereference. > > Also fix NULL pointer deference in dev_err when allocate memory for pm2 > > fails. > >

Re: [PATCH] power: use platform_{get,set}_drvdata()

2013-06-06 Thread Anton Vorontsov
On Thu, May 23, 2013 at 07:34:39PM +0900, Jingoo Han wrote: > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han > ---

Re: [PATCH] power_supply: generic-adc-battery: Fix checking if none of the channels are supported

2013-06-06 Thread Anton Vorontsov
On Tue, May 28, 2013 at 11:57:37AM +0530, anish singh wrote: > On Fri, May 24, 2013 at 11:11 PM, Axel Lin wrote: > > If none of the channels are supported, index is 0. > > Also ensure to return error code instead of 0 in goto second_mem_fail path. > > > > Signed-off-by: Axel Lin > Acked-by: anish

Re: [PATCH V2] power: replace strict_strtoul() with kstrtoul()

2013-06-06 Thread Anton Vorontsov
On Mon, Jun 03, 2013 at 01:49:49PM +0300, Andy Shevchenko wrote: > On Mon, Jun 3, 2013 at 12:05 PM, Jingoo Han wrote: > > The usage of strict_strtoul() is not preferred, because > > strict_strtoul() is obsolete. Thus, kstrtoul() should be > > used. > > > > Signed-off-by: Jingoo Han > > Looks bet

Re: [PATCH 4/8] power: ensure event is not used as format string

2013-06-06 Thread Anton Vorontsov
On Thu, Jun 06, 2013 at 01:52:21PM -0700, Kees Cook wrote: > The exposed interface for cm_notify_event() could result in the event > msg string being parsed as a format string. Make sure it is only used > as a literal string. > > Signed-off-by: Kees Cook > Cc: sta...@vger.kern

Re: [PATCH] power/reset: Make the vexpress driver optional on arm and arm64

2013-06-21 Thread Anton Vorontsov
On Mon, Jun 10, 2013 at 04:12:01PM +0100, Pawel Moll wrote: > The driver can be used on either arm or arm64 platforms, but > the latter doesn't have any platform-specific configuration > options, so it must be possible to manually enable the driver. > > Signed-off-by: Pawel Moll > Acked-by: Catal

Re: [PATCH] vmpressure: implement strict mode

2013-06-25 Thread Anton Vorontsov
mode is for the cases when an application wants to implement some fancy logic as it makes a decision based on a concrete level. Otherwise, it looks good. Acked-by: Anton Vorontsov Thanks! Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH] MAINTAINERS: Update email address for Anton Vorontsov

2013-06-09 Thread Anton Vorontsov
Old email addresses seem to gradually stop working so people are getting bounces. This patch updates my email address. Suggested-by: Andy Shevchenko Signed-off-by: Anton Vorontsov --- I'm about to merge this patch via battery-2.6.git tree. MAINTAINERS | 8 1 file chang

Re: [PATCH 1/1] tps65090-charger: Fix AC detect

2013-06-09 Thread Anton Vorontsov
On Fri, Jun 07, 2013 at 12:07:39PM -0400, Rhyland Klein wrote: > On 6/6/2013 5:12 PM, Andrew Chew wrote: > > The VACG interrupt was not being enabled. Thus, interrupts were never > > generated when AC status changes. In addition, interrupts were never > > cleared after taking and processing the i

Re: [PATCH] power: Add missing newlines, fix a couple of typos, add pr_fmt

2013-06-09 Thread Anton Vorontsov
On Fri, Jun 07, 2013 at 11:31:06AM -0700, Kees Cook wrote: > On Thu, Jun 6, 2013 at 6:25 PM, Joe Perches wrote: > > Make sure that dev_ calls are newline terminated. > > Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to prefix > > all pr_ calls with "charger-manager: " > > > > Fix a couple of typ

Re: [PATCH v2] vmpressure: implement strict mode

2013-07-01 Thread Anton Vorontsov
On Mon, Jul 01, 2013 at 05:22:36PM +0900, Hyunhee Kim wrote: > >> > > for each event in memory.pressure_level; do > >> > > /* register eventfd to be notified on "event" */ > >> > > done > >> > > >> > This scheme registers "all" events. > >> > >> Yes, because I thought that's the user-case that ma

Re: [PATCH v2] vmpressure: implement strict mode

2013-07-02 Thread Anton Vorontsov
On Tue, Jul 02, 2013 at 10:59:11AM -0400, Luiz Capitulino wrote: > 2. Considering the interface can be extended, how can new applications > work on backwards mode? Say, we add ultra-critical on 3.12 and > I update my application to work on it, how will my application > work on 3.11? I

Re: [PATCH] vmpressure: implement strict mode

2013-06-26 Thread Anton Vorontsov
On Wed, Jun 26, 2013 at 04:50:51PM +0900, Minchan Kim wrote: > On Tue, Jun 25, 2013 at 05:51:29PM -0400, Luiz Capitulino wrote: > > Currently, applications are notified for the level they registered for > > _plus_ higher levels. > > > > This is a problem if the application wants to implement diffe

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-27 Thread Anton Vorontsov
On Thu, Jun 27, 2013 at 05:34:33PM -0700, Andrew Morton wrote: > > If so, userland daemon would receive lots of events which are no interest. > > "lots"? If vmpressure is generating events at such a high frequency that > this matters then it's already busted? Current frequency is 1/(2MB). Suppos

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-27 Thread Anton Vorontsov
On Thu, Jun 27, 2013 at 06:13:53PM -0700, Andrew Morton wrote: > On Thu, 27 Jun 2013 17:58:53 -0700 Anton Vorontsov wrote: > > Current frequency is 1/(2MB). Suppose we ended up scanning the whole > > memory on a 2GB host, this will give us 1024 hits. Doesn't feel too much*

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-27 Thread Anton Vorontsov
On Thu, Jun 27, 2013 at 09:34:11PM -0700, Anton Vorontsov wrote: > ... we can add the strict mode and deprecate the > "filtering" -- basically we'll implement the idea of requiring that > userspace registers a separate fd for each level. Btw, assuming that more levels can

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Anton Vorontsov
On Fri, Jun 28, 2013 at 10:00:27AM -0400, Luiz Capitulino wrote: > On Thu, 27 Jun 2013 22:07:12 -0700 > Anton Vorontsov wrote: > > > On Thu, Jun 27, 2013 at 09:34:11PM -0700, Anton Vorontsov wrote: > > > ... we can add the strict mode and deprecate the > > &g

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Anton Vorontsov
On Fri, Jun 28, 2013 at 09:57:22AM -0700, Anton Vorontsov wrote: > On Fri, Jun 28, 2013 at 10:00:27AM -0400, Luiz Capitulino wrote: > > On Thu, 27 Jun 2013 22:07:12 -0700 > > Anton Vorontsov wrote: > > > > > On Thu, Jun 27, 2013 at 09:34:11PM -0700, Anton Vorontsov

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Anton Vorontsov
On Fri, Jun 28, 2013 at 02:25:58PM -0400, Luiz Capitulino wrote: > > > > That's how it's expected to work, because on strict mode you're notified > > > > for the level you registered for. So apps registering for critical, will > > > > still be notified on critical just like before. > > > > > > Sup

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Anton Vorontsov
On Fri, Jun 28, 2013 at 02:45:07PM -0400, Luiz Capitulino wrote: > On Fri, 28 Jun 2013 10:09:17 -0700 > Anton Vorontsov wrote: > > > So, I would now argue that the current scheme is perfectly OK and can do > > everything you can do with the "strict" one, > &g

Re: [PATCH v2] vmpressure: implement strict mode

2013-06-28 Thread Anton Vorontsov
On Fri, Jun 28, 2013 at 03:44:02PM -0400, Luiz Capitulino wrote: > > Why can't you use poll() and demultiplex the events? Check if there is an > > event in the crit fd, and if there is, then just ignore all the rest. > > This may be a valid workaround for current kernels, but application > behavio

Re: [PATCH 1/4] power_supply: Add of_node_put to fix refcount

2013-06-28 Thread Anton Vorontsov
by the patch below and applied your 1-3 series. Thanks! Anton commit b50df95c8f0703c95625181d2eaf53855c5ebee5 Author: Anton Vorontsov Date: Fri Jun 28 18:17:22 2013 -0700 power_supply: Move of_node out of the #ifdef CONFIG_OF Similar to linux/device.h, move of_node struct member

Re: [PATCH v2] power: charger-manager: regulator_get() never returns NULL.

2013-06-28 Thread Anton Vorontsov
On Tue, Jun 25, 2013 at 02:54:17PM +0900, Chanwoo Choi wrote: > Acked-by: Chanwoo Choi > > > This patch fixes return value checking of regulator_get() in > > charger-manager > > driver. The API, regulator_get(), returns ERR_PTR() when it fails to get > > regulator with given name, not NULL. > > >

Re: [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()

2013-06-28 Thread Anton Vorontsov
On Wed, Jun 26, 2013 at 09:57:14AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > --- The patch does not apply to the battery-2.6.

<    1   2   3   4   5   6   7   8   9   >