Re: SOC-specific action for irq_set_wake

2016-07-19 Thread Andy Gross
ably already solved it? > Any other suggestions for approaching the problem? Any preferred > solution? I think we have the same problem. Can you provide more detail on the hardware implementation of your wake irq controller? I presume you have some set of registers, an irq maybe, and some other stuff? And how does it fit into the overall architecture from a hardware perspective? Regards, Andy Gross

Re: SOC-specific action for irq_set_wake

2016-07-20 Thread Andy Gross
On Wed, Jul 20, 2016 at 06:16:06AM -0700, Sören Brinkmann wrote: > Hi Marc, > > On Wed, 2016-07-20 at 09:17:16 +0100, Marc Zyngier wrote: > > On 20/07/16 00:34, Sören Brinkmann wrote: > > > Hi Andy, > > > > > > On Tue, 2016-07-19 at 17:47:13 -0500, And

Re: [PATCH v2 16/16] arm64: dts: msm8996: add sdc2 support

2016-06-21 Thread Andy Gross
On Tue, Jun 21, 2016 at 06:39:53PM +0100, Srinivas Kandagatla wrote: > This patch adds support to sdc2 sdhci controller, which is used on some > of the boards. > > Signed-off-by: Srinivas Kandagatla > --- > Hi Andy, > > Am resending just this one patch, as It does not make sense > to resend ent

Re: [PATCH 15/16] arm64: dts: msm8996: add sdc2 pinctrl

2016-06-21 Thread Andy Gross
On Fri, Jun 17, 2016 at 04:14:12PM +0100, Srinivas Kandagatla wrote: > This patch adds pinctrl required for sdhci for external sd card > controller. > > Signed-off-by: Srinivas Kandagatla > --- I presume this is the right patch 15? As it matches the subject in your cover letter? Andy

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Andy Gross
low compile testing without SMD support after patch 2 > > include/linux/soc/qcom/wcnss_ctrl.h | 13 + > 1 file changed, 13 insertions(+) > This is fine. Acked-by: Andy Gross

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Andy Gross
On Thu, Sep 08, 2016 at 09:21:59PM -0700, Bjorn Andersson wrote: > On Thu 08 Sep 10:35 PDT 2016, Kalle Valo wrote: > > > Bjorn Andersson writes: > > > > > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote: > > >> Bjorn Andersson writes: > > >> > > >>> The wcn36xx wifi driver follows the life cy

Re: [PATCH] i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended

2016-09-14 Thread Andy Gross
issue by executing qup_i2c_pm_suspend_runtime > conditionally in qup_i2c_suspend. > > Cc: Andy Gross > Cc: David Brown > Cc: Wolfram Sang > Signed-off-by: Sudeep Holla Reviewed-by: Andy Gross

Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

2016-09-01 Thread Andy Gross
On Thu, Sep 01, 2016 at 05:58:17PM +0300, Stanimir Varbanov wrote: > Hi, > > Cc: Marek > > On 08/30/2016 08:17 PM, Bjorn Andersson wrote: > > On Mon 29 Aug 04:48 PDT 2016, Stanimir Varbanov wrote: > > > > [..] > >>> Trying to wrap my head around how the iommu part works here. The > >>> downstrea

Re: [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo

2016-08-04 Thread Andy Gross
On Thu, Aug 04, 2016 at 05:57:48PM -0700, Stephen Boyd wrote: > On 07/11, Andy Gross wrote: > > On Mon, Jul 11, 2016 at 02:50:08PM -0700, Stephen Boyd wrote: > > > The voltage ranges listed here are wrong. The pma8084 pldo > > > supports three different over

Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41

2016-08-04 Thread Andy Gross
On Thu, Aug 04, 2016 at 05:58:26PM -0700, Stephen Boyd wrote: > On 07/11, Andy Gross wrote: > > On Mon, Jul 11, 2016 at 02:50:07PM -0700, Stephen Boyd wrote: > > > > > static const struct regulator_desc pm8941_pldo = { > > > .linear_ranges

Re: [PATCH] arm64: defconfig: Enable QDF2432 config options

2016-08-23 Thread Andy Gross
On Fri, Jul 01, 2016 at 10:11:00AM -0500, Timur Tabi wrote: > Christopher Covington wrote: > >Due to distribution differences [1][2], I see =y built-in as the default > >on mobile platforms and =m modular as the default on server platforms. > > I don't think we should mix "server" defconfing entri

Re: [PATCH v3] PM / sleep: enable suspend-to-idle even without registered suspend_ops

2016-08-23 Thread Andy Gross
. Wysocki" > Signed-off-by: Sudeep Holla I tested this patch on the Qualcomm 410c platform. It worked like a charm. Thanks for working on this! Tested-by: Andy Gross

Re: [PATCH v3 0/5] dts patches for qcom tsens support

2016-08-24 Thread Andy Gross
On 24 August 2016 at 07:18, Nayak, Rajendra wrote: > > On 8/24/2016 3:52 PM, Paolo Pisati wrote: >> >> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote: >>> >>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote: >>>> >>&

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Andy Gross
On 17 June 2016 at 05:16, Pramod Gurav wrote: > @@ -1635,6 +1732,7 @@ static int msm_serial_remove(struct platform_device > *pdev) > struct uart_port *port = platform_get_drvdata(pdev); > > uart_remove_one_port(&msm_uart_driver, port); > + pm_runtime_disable(&pdev->dev);

Re: [PATCH v3 0/5] dts patches for qcom tsens support

2016-08-24 Thread Andy Gross
On 24 August 2016 at 22:13, Bjorn Andersson wrote: > On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote: > >> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote: >> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote: >> > > Hey Andy, >>

Re: [PATCH] spi: qup: skip clk_disable_unprepare if the device is already runtime suspended

2016-08-25 Thread Andy Gross
s/clk/clk.c:476 > clk_core_unprepare+0x80/0x90 > Modules linked in: > Thanks for fixing this. I had noticed this yesterday when I was testing your freeze patch but hadn't had time to dig in. Tested-by: Andy Gross

Re: [RFC 2/3] of: reserved_mem: Accessor for acquiring reserved_mem

2017-05-26 Thread Andy Gross
se address of > the reserved memory region. > > This patch adds an accessor for such drivers to acquire a handle to > their associated reserved-memory for this purpose. > > Signed-off-by: Bjorn Andersson Reviewed-by: Andy Gross

Re: [PATCH 1/3] arm64: defconfig: remove CONFIG_USB_EHCI_MSM

2017-10-25 Thread Andy Gross
: Bjorn Andersson Acked-by: Andy Gross

Re: [PATCH 3/3] arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

2017-10-25 Thread Andy Gross
f-by: Alex Elder > Acked-by: Bjorn Andersson Acked-by: Andy Gross

Re: [PATCH 2/3] arm64: defconfig: remove CONFIG_USB_MSM_OTG

2017-10-25 Thread Andy Gross
lex Elder > Acked-by: Bjorn Andersson Acked-by: Andy Gross

Re: [PATCH 0/3] arm64: remove some unused defconfig options

2017-10-25 Thread Andy Gross
On Tue, Oct 24, 2017 at 05:20:20PM -0700, Stephen Boyd wrote: > On 10/20, Alex Elder wrote: > > This series deletes three config options related to USB on Qualcomm > > SoCs from the arm64 "defconfig", along with the code that they > > enable. The code is no longer needed by any Qualcomm hardware.

Re: [PATCH v8 1/4] firmware: scm: Add new SCM call API for switching memory ownership

2017-10-30 Thread Andy Gross
nterface for making secure monitor call for > memory ownership switching request. > > Signed-off-by: Avaneesh Kumar Dwivedi Looks fine to me. Acked-by: Andy Gross

[Patch v2] firmware: qcom: scm: Convert to platform driver

2015-10-06 Thread Andy Gross
This patch creates a platform driver for the SCM so that we can adequately manage resources. This removes clients having to carry the necessary clocks to use the SCM resources. Signed-off-by: Andy Gross --- .../devicetree/bindings/firmware/qcom,scm.txt | 25 drivers/firmware

Re: linux-next: manual merge of the qcom tree with the arm-soc tree

2015-10-12 Thread Andy Gross
On Mon, Oct 12, 2015 at 10:19:12AM +1100, Stephen Rothwell wrote: > Hi Andy, > > Today's linux-next merge of the qcom tree got a conflict in: > > arch/arm/configs/multi_v7_defconfig > > between commits: > > b605aded4491 ("ARM: multi_v7_defconfig: Add missing QCOM APQ8064 configs") > cc688

Re: [PATCH] soc: qcom: smd: Correct SMEM items for upper channels

2015-10-12 Thread Andy Gross
On Fri, Oct 09, 2015 at 09:35:37PM -0700, Bjorn Andersson wrote: > Update the SMEM items for the second set of SMD channels, as these where > incorrect. > > Signed-off-by: Bjorn Andersson Nice. Good catch. I verified by counting through the #defines in the codeaurora code. Revie

Re: [PATCH] regulator: qcom-smd: Correct set_load() unit

2015-10-12 Thread Andy Gross
On Mon, Oct 12, 2015 at 05:49:52PM -0700, Bjorn Andersson wrote: > The set_load() op deals with uA while the SMD packets used mA, so > convert as we're building the packet. > > Signed-off-by: Bjorn Andersson > --- Looks fine to me. Thanks for the fix. -- Qualcomm Innovation Center, Inc. The Q

Re: [PATCH] soc: qcom: smd-rpm: Correct the active vs sleep state flagging

2015-10-13 Thread Andy Gross
On Tue, Oct 13, 2015 at 01:57:43PM -0700, Bjorn Andersson wrote: > The BIT() was incorrectly inherited from family A and should not be used > on family B where the state is denoted by an enum. > > Reported-by: Georgi Djakov > Signed-off-by: Bjorn Andersson > --- > drivers/soc/qcom/smd-rpm.c | 2

[PATCH 01/11] soc: qcom: documentation: Update SMD/RPM Docs

2015-09-08 Thread Andy Gross
This patch moves the qcom,smd-rpm.txt to the correct location and splits out the smd and rpm documentation. In addition, a smd-rpm-regulator document is added. Signed-off-by: Andy Gross --- .../devicetree/bindings/soc/qcom,smd-rpm.txt | 117 .../bindings/soc/qcom

[PATCH 06/11] regulator: qcom-smd: Add PM8916 support

2015-09-08 Thread Andy Gross
This patch adds support and documentation for the PM8916 regulators found on MSM8916 platforms. Signed-off-by: Andy Gross --- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++ drivers/regulator/qcom_smd-regulator.c | 64 2 files changed, 82

[PATCH 10/11] regulator: qcom-smd: Add support for PMA8084

2015-09-08 Thread Andy Gross
This patch adds support and documentation for the PMA8084 regulators found on APQ8084 platforms. Signed-off-by: Andy Gross --- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 35 drivers/regulator/qcom_smd-regulator.c | 95 2 files changed, 130

[PATCH 11/11] arm: dts: Add RPM SMD regulator support on MSM8974

2015-09-08 Thread Andy Gross
This patch adds all the nodes required to support the PM8841 and PM8941 PMIC regulators present on MSM8974 platforms. Signed-off-by: Andy Gross --- arch/arm/boot/dts/qcom-msm8974.dtsi | 75 +++ 1 file changed, 75 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 09/11] arm: dts: Add support for PMA8084 on APQ8084

2015-09-08 Thread Andy Gross
This patch adds support for the PMA8084 regulators found on APQ8084 platforms. Signed-off-by: Andy Gross --- arch/arm/boot/dts/qcom-apq8084.dtsi | 52 +++ 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts

[PATCH 08/11] arm: dts: Add RPM/SMD support on APQ8084

2015-09-08 Thread Andy Gross
This patch adds support for RPM and SMD nodes that are present on APQ8084 platforms. Signed-off-by: Andy Gross --- arch/arm/boot/dts/qcom-apq8084.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom

[PATCH 06/11] regulators: qcom-smd: Add PM8916 support

2015-09-08 Thread Andy Gross
This patch adds support and documentation for the PM8916 regulators found on MSM8916 platforms. Signed-off-by: Andy Gross --- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++ drivers/regulator/qcom_smd-regulator.c | 64 2 files changed, 82

[PATCH 07/11] arm: dts: Add APQ8084 SMEM nodes

2015-09-08 Thread Andy Gross
This patch adds all the required nodes to support SMEM on APQ8084 Signed-off-by: Andy Gross --- arch/arm/boot/dts/qcom-apq8084.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi

[PATCH 04/11] arm64: dts: qcom: Add RPM/SMD support on MSM8916

2015-09-08 Thread Andy Gross
Add support for the SMD and RPM devices found on MSM8916 platforms. Signed-off-by: Andy Gross --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi

[PATCH 03/11] arm64: dts: qcom: Add MSM8916 SMEM nodes

2015-09-08 Thread Andy Gross
This patch adds the nodes necessary to support the SMEM driver on MSM8916 platforms. Signed-off-by: Andy Gross --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 36 + 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64

[PATCH 00/11] Add RPM/SMD Support for QCOM platforms

2015-09-08 Thread Andy Gross
for the regulators and their dependencies for all of the platforms which support SMD-RPM regulators. Andy Gross (11): soc: qcom: documentation: Update SMD/RPM Docs soc: qcom: smd-rpm: Add existing platform support arm64: dts: qcom: Add MSM8916 SMEM nodes arm64: dts: qcom: Add RPM/SMD support

[PATCH 05/11] arm64: dts: Add PM8916 support on MSM8916

2015-09-08 Thread Andy Gross
This patch adds the PM8916 regulator nodes found on MSM8916 platforms. Signed-off-by: Andy Gross --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 02/11] soc: qcom: smd-rpm: Add existing platform support

2015-09-08 Thread Andy Gross
This patch adds support for all current Qualcomm platforms which utilize RPM over SMD. This includes both MSM8916 and APQ8084. Signed-off-by: Andy Gross --- .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt |2 ++ drivers/soc/qcom/smd-rpm.c |2 ++ 2 files

[PATCH] ARM: qcom_defconfig: Enable SMD-RPM regulators

2015-09-08 Thread Andy Gross
This patch enables all of the options required to support SMD RPM based regulators. Signed-off-by: Andy Gross --- arch/arm/configs/qcom_defconfig |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig

[PATCH] ARM: multi_v7_defconfig: Enable QCOM SMD/RPM

2015-09-08 Thread Andy Gross
This patch enables all of the options necessary to support the Qualcomm SMD RPM regulator driver. Signed-off-by: Andy Gross --- arch/arm/configs/multi_v7_defconfig |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs

Re: [PATCH 11/11] arm: dts: Add RPM SMD regulator support on MSM8974

2015-09-09 Thread Andy Gross
On Tue, Sep 08, 2015 at 04:35:31PM -0500, Andy Gross wrote: > This patch adds all the nodes required to support the PM8841 and PM8941 > PMIC regulators present on MSM8974 platforms. > > Signed-off-by: Andy Gross > --- This patch dupes work done by Bjorn. So I'll take his in

Re: [PATCH 06/11] regulators: qcom-smd: Add PM8916 support

2015-09-09 Thread Andy Gross
Disregard this one. Dupe with different subject line of the other patch 6 -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH] serial: msm_serial: Make config tristate

2015-10-21 Thread Andy Gross
serial and > then runs a getty on ttyMSM0. This patch should supersede Paul's earlier > patch that removes the module code from this driver. > > drivers/tty/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andy Gross -- Qualcomm Innovation

Re: [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator

2015-10-21 Thread Andy Gross
river anymore, but comes from the board layout, so > that is why it should be in DT anyway. > > Signed-off-by: Georgi Djakov > --- Looks good to me. Reviewed-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora For

Re: [PATCH] firmware: qcom: scm: Convert to platform driver

2015-09-04 Thread Andy Gross
On Thu, Sep 03, 2015 at 02:33:22PM -0700, Stephen Boyd wrote: > On 07/20, Andy Gross wrote: > > This patch creates a platform driver for the SCM so that we can adequately > > manage resources. This removes clients having to carry the necessary > > clocks to use the SCM resou

Re: [PATCH v2 0/8] SMEM/SMD/SMD_RPM big endian support + tidying

2015-09-04 Thread Andy Gross
On Wed, Sep 02, 2015 at 03:46:43PM -0700, Stephen Boyd wrote: > This supersedes the 3 "series" of patches to move smem to big endian, > smd to big endian, and make qcom_smem_get() return a pointer. > > I've moved the qcom_smem_get() returning a pointer part to the beginning > of the series so it c

Re: [PATCH v3 3/4] soc: qcom: smd: Use __ioread32_copy() instead of open-coding it

2015-10-25 Thread Andy Gross
On Fri, Oct 23, 2015 at 01:01:51PM -0700, Stephen Boyd wrote: > Now that we have a generic library function for this, replace the > open-coded instance. > > Cc: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- Acked-by: Andy Gross -- Qualcomm Innovation Center,

Re: [PATCH] ARM: multi_v7_defconfig: Add missing QCOM APQ8064 configs

2015-10-04 Thread Andy Gross
er Baker > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/configs/multi_v7_defconfig | 8 > 1 file changed, 8 insertions(+) Works like a charm. Tested-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Au

Re: [PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-26 Thread Andy Gross
+ olof On Tue, Jul 24, 2018 at 05:59:42PM +0100, Mark Brown wrote: > On Tue, Jul 24, 2018 at 08:43:46AM -0700, Doug Anderson wrote: > > On Tue, Jul 24, 2018 at 8:25 AM, Mark Brown wrote: > > > > There was also some other thing called command DB as well which was a > > > separate series. Ideally

Re: [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver

2018-07-21 Thread Andy Gross
On Thu, Jul 19, 2018 at 12:53:04PM +0200, Nicolas Dechesne wrote: > hi Niklas, > > On Wed, Jul 18, 2018 at 4:53 PM Niklas Cassel > wrote: > > > > Drop legacy suffix for clocks used by MSM DRM driver. > > I had the same patch locally, which I forgot to send.. so thanks for > sending it ;) > > y

Re: [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs

2018-07-21 Thread Andy Gross
On Wed, Jul 18, 2018 at 03:52:26PM +0530, Amit Kucheria wrote: > On Fri, May 25, 2018 at 4:02 PM, Viresh Kumar wrote: > > The OPP properties, like "operating-points", should either be present > > for all the CPUs of a cluster or none. If these are present only for a > > subset of CPUs of a cluster

Re: [PATCH -next] of: platform: fix OF node refcount leak

2018-01-19 Thread Andy Gross
On 19 January 2018 at 09:37, Sudeep Holla wrote: > Hi Andy, > > On 18/01/18 10:43, Sudeep Holla wrote: >> We need to call of_node_put() for device nodes obtained with >> of_find_node_by_path(). >> >> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from >> of_platform_default_populate

Re: [PATCH v3 3/4] soc: qcom: mdt-loader: Return relocation base

2018-01-27 Thread Andy Gross
gt; > Return the adjusted physical base address to the caller. > > Signed-off-by: Bjorn Andersson This looks fine. Acked-by: Andy Gross

Re: [PATCH v3] firmware: qcom: scm: Fix incorrect of_node_put calls in scm_init

2018-01-17 Thread Andy Gross
On Tue, Jan 16, 2018 at 08:45:49AM -0800, Bjorn Andersson wrote: > On Fri 15 Dec 05:40 PST 2017, Loys Ollivier wrote: > > > When using other platform architectures, in the init of the qcom_scm > > driver, of_node_put is called on /firmware if no qcom dt is found. > > This results in a kernel error

Re: [PATCH] soc: qcom: qmi: add CONFIG_NET dependency

2018-03-08 Thread Andy Gross
n > --- > drivers/remoteproc/Kconfig | 1 + > drivers/soc/qcom/Kconfig | 2 +- > samples/Kconfig| 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) Acked-by: Andy Gross

Re: [PATCH ARM-next] ARM: dts: qcom-msm8974: change invalid flag IRQ NONE to valid value

2018-09-26 Thread Andy Gross
On Tue, Sep 25, 2018 at 06:46:51AM -0400, Brian Masney wrote: > The following commits used IRQ_TYPE_NONE since that matched what was > already in the file and I do not have access to the datasheets for > these devices. After these patches were submitted, commit dcf145011400 > ("ARM: dts: qcom-msm89

Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: correct gpios property on magnetometer

2018-11-28 Thread Andy Gross
On Wed, Nov 28, 2018 at 04:53:35AM -0500, Brian Masney wrote: > This patch correctly sets the gpios property for the ak8963 > magnetometer's DRDY pin so that interrupts work properly. > > Signed-off-by: Brian Masney > --- Queued. Thanks for the patch. Andy

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > We need to check the call to cmd_db_read_aux_data() for the error case, > so that we don't continue and use potentially uninitialized values for > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler > warnings: > >

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > We need to check the call to cmd_db_read_aux_data() for the error case, > > so that we don't continue and use potentially uninitialized values for

[PATCH] MAINTAINERS: Remove unused Qualcomm SoC mailing list

2018-11-29 Thread Andy Gross
This patch removes the linux-soc mailing list from the Qualcomm SoC entry. We use the linux-msm and there is no need to have the second one and this clears the list for use by others. Signed-off-by: Andy Gross --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Fri, Nov 30, 2018 at 01:12:01PM +1100, Stephen Rothwell wrote: > Hi Andy, > > On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross wrote: > > > > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wro

Re: [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD

2018-11-15 Thread Andy Gross
On Thu, Nov 15, 2018 at 10:18:11AM -0700, Jeffrey Hugo wrote: > The externally accessible SD card slot on the MTP is driven by SDCC2. > Wire it up for use. > > Signed-off-by: Jeffrey Hugo > --- > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 + > arch/arm64/boot/dts/qcom/msm8998.dts

Re: [PATCH v6 0/2] arm64: dts: add prng-ee nodes

2018-11-15 Thread Andy Gross
On Thu, Nov 15, 2018 at 09:15:18AM +0530, Vinod Koul wrote: > On 01-10-18, 11:51, Vinod Koul wrote: > > This adds prng-ee nodes for msm8996 and sdm845 > > Ping Andy, would appreciate if you can pick these up. Done. I did have to massage the location in dts for both of these patches to keep the a

Re: [PATCH] soc: qcom: Add irq clear handling during SE init

2018-11-14 Thread Andy Gross
On Wed, Oct 03, 2018 at 05:53:50PM +0530, Alok Chauhan wrote: > when the kernel inits a SE, its quite possible we have pending interrupts > from bootloaders which did not handle/clear them. So do this in kernel at > the SE init, to avoid some of it causing bad behavior, while at it also > club all

Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

2018-11-14 Thread Andy Gross
On Mon, Oct 01, 2018 at 11:55:54AM +0200, Niklas Cassel wrote: > The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a > hidden kconfig, so it is not selectable in menuconfig. > > Remove the help text so that it is more clear that this is intentionally > a hidden kconfig. > > Sign

Re: [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

2018-11-14 Thread Andy Gross
On Mon, Nov 12, 2018 at 02:11:24PM -0800, Matthias Kaehlcke wrote: > This series adds a channel for the die temperature to the QCOM SPMI > PMIC5 ADC. It also fixes an example in the DT documentation. > > Matthias Kaehlcke (2): > dt-bindings: iio: vadc: Add unit address to ADC channel node in >

Re: [PATCH v2 22/34] dt-bindings: arm: Convert QCom board/soc bindings to json-schema

2018-12-05 Thread Andy Gross
On Mon, Dec 03, 2018 at 03:32:11PM -0600, Rob Herring wrote: > Convert QCom SoC bindings to DT schema format using json-schema. > > Cc: Andy Gross > Cc: David Brown > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Andy Gross

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add UART nodes

2018-12-05 Thread Andy Gross
On Tue, Dec 04, 2018 at 12:37:18PM -0800, Matthias Kaehlcke wrote: > Hi Andy, > > can this be landed or are any more changes needed? > > Thanks I'll see about adding it to the second pull request. Thank, Andy

Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled

2018-12-05 Thread Andy Gross
On Wed, Dec 05, 2018 at 09:37:21AM -0800, Bjorn Andersson wrote: > + linux-arm-msm > > On Wed 21 Nov 18:32 PST 2018, Jonathan Marek wrote: > > > This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h > > has not been included previously. > > > > Signed-off-by: Jonathan Marek

[GIT PULL] Qualcomm ARM64 DT updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
driver on MSM8996 * Fix issue with xo clk name on MSM8998 * Add cooling maps on MSM8916 * Add UART nodes on SDM845 * Add camera subsystem support on MSM8996 and MSM8916 Andy Gross (1): arm64: dts: qcom: msm8998: Fixup clock to

[GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
The following changes since commit b601f73130a375c912d9f2ec93c5f3cea5d6a3da: drm: msm: Check cmd_db_read_aux_data() for failure (2018-11-29 17:41:53 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-drivers-for-4.21-2 fo

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Mark protected gcc clocks

2018-11-09 Thread Andy Gross
nding clocks protected for the MTP, in order to allow it to boot. > > Cc: Stephen Boyd > Signed-off-by: Bjorn Andersson This looks fine to me. Acked-by: Andy Gross

Re: [GIT PULL] Qualcomm Driver updates for 4.18

2018-05-24 Thread Andy Gross
18 at 11:37:40PM -0500, Andy Gross wrote: > The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: > > Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/agross/linu

Re: [PATCH 1/4] remoteproc: qcom: mdt_loader: Make the firmware authentication optional

2018-06-18 Thread Andy Gross
used > by self-authenticating remoteproc as well. > > Signed-off-by: Sricharan R > Signed-off-by: Bjorn Andersson looks fine to me Acked-by: Andy Gross

Re: [PATCH] arm64: dts: apq8096-db820c: disable uart0 by default

2018-06-13 Thread Andy Gross
On Tue, Jun 12, 2018 at 03:48:06PM +0100, Srinivas Kandagatla wrote: > Access to UART0 is disabled by bootloaders. By leaving it enabled by > default would reboot the board. > Disable this for now, this would alteast give a board which boots. > > Signed-off-by: Srinivas Kandagatla Thanks for thi

Re: [GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-10 Thread Andy Gross
On Mon, Dec 10, 2018 at 02:20:47PM +0200, Stanimir Varbanov wrote: > Hi Andy, > > On 12/8/18 7:13 AM, Andy Gross wrote: > > The following changes since commit b601f73130a375c912d9f2ec93c5f3cea5d6a3da: > > > > drm: msm: Check cmd_db_read_aux_data() for failure (201

Re: [GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-11 Thread Andy Gross
On Mon, Dec 10, 2018 at 11:36:48PM +0200, Stanimir Varbanov wrote: > > > On 10.12.18 г. 21:05 ч., Andy Gross wrote: > >On Mon, Dec 10, 2018 at 02:20:47PM +0200, Stanimir Varbanov wrote: > >>Hi Andy, > >> > >>On 12/8/18 7:13 AM, Andy Gross wrot

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2019-01-07 Thread Andy Gross
On Mon, 7 Jan 2019 at 14:26, Jack Pham wrote: > > Hi Jorge, > > Sorry for the late reply as I was out during the holiday break. > > On Fri, Dec 28, 2018 at 01:38:59PM +0100, Jorge Ramirez wrote: > > On 12/20/18 18:37, Jack Pham wrote: > > >Hi Rob, Jorge, > > > > > >On Thu, Dec 20, 2018 at 11:05:31

Re: [PATCH v1] phy: qcom-ufs: Use iopoll.h readl_poll_timeout macro

2018-12-28 Thread Andy Gross
On Fri, Dec 21, 2018 at 11:13:18AM +0100, Marc Gonzalez wrote: > The private copy of readl_poll_timeout is no longer needed. > Use the implementation in iopoll.h instead. > > Signed-off-by: Marc Gonzalez Reviewed-by: Andy Gross

Re: [GIT PULL] Qualcomm Device Tree updates for 4.20

2018-10-05 Thread Andy Gross
On Tue, Oct 02, 2018 at 11:36:11AM +0200, Arnd Bergmann wrote: > On Sun, Sep 30, 2018 at 8:38 PM Andy Gross wrote: > > > > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > > > Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) > > > &

Re: [GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-10-05 Thread Andy Gross
On Tue, Oct 02, 2018 at 11:30:29AM +0200, Arnd Bergmann wrote: > On Sun, Sep 30, 2018 at 8:38 PM Andy Gross wrote: > > > > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > > > Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) > > > &

Re: [GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-10-25 Thread Andy Gross
On Thu, Oct 25, 2018 at 10:55:32AM +0530, Amit Kucheria wrote: > Andy, > > While you acked the tsens thermal DT patches[1] so they could go > through the thermal tree[2] to avoid a dependency, Eduardo would > prefer the DT changes for tsens to go through the arch tree. > > To avoid a scenario

Re: [PATCH] ASoC: qcom: Fix a uninitialized warning.

2018-09-18 Thread Andy Gross
On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote: > Fix the following compile warning: > > drivers/soc/qcom/cmd-db.c:194:38: warning: ‘ent.addr’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > return ret < 0 ? 0 : le32_to_cpu(ent.addr); > > drivers/soc/qcom/cm

Re: [PATCH] ARM: dts: qcom: Correct IPQ tlmm interrupt

2014-12-05 Thread Andy Gross
On Fri, Dec 05, 2014 at 12:53:33PM -0800, Stephen Boyd wrote: > The interrupt is 16, not 32 (which it would be if we include PPIs > in the count of interrupts). > > Cc: Andy Gross > Signed-off-by: Stephen Boyd This fixed my issue! Reviewed-by: Andy Gross Tested-by: Andy Gross

Re: [Patch v9 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2015-01-22 Thread Andy Gross
On Thu, Jan 22, 2015 at 10:59:14AM -0800, Jack Pham wrote: > Hi Andy, > > On Fri, Sep 12, 2014 at 02:28:08PM -0500, Andy Gross wrote: > > This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on > > some > > Qualcomm platforms. This driver uses the gen

Re: [PATCH] MAINTAINERS: update Qualcomm support entry

2015-01-22 Thread Andy Gross
On Wed, Jan 21, 2015 at 08:46:45PM -0800, Joe Perches wrote: > > +L: linux-...@vger.kernel.org > > S: Maintained > > F: arch/arm/mach-qcom/ > > +F: drivers/soc/qcom > > Please add a terminating / > > F:drivers/soc/qcom/ Noted, will fix. -- Qualcomm Innovation Center, Inc. The Qualcomm In

Re: [PATCH] dmaengine: qcom_bam_dma: Add support for BAM v1.7.0

2015-01-22 Thread Andy Gross
On Thu, Jan 22, 2015 at 12:34:26PM +0530, Archit Taneja wrote: > Add register offset table entry for the newer (v1.7.0) version of the BAM IP > found on MSM8916. Update the DT bindings documentation. > > Signed-off-by: Archit Taneja > --- Looks good. Reviewed-by: Andy Gross

Re: [GIT PULL] qcom SoC changes for v3.18

2015-01-14 Thread Andy Gross
On Wed, Oct 15, 2014 at 10:18:30AM +0200, Kumar Gala wrote: > > On Oct 1, 2014, at 4:41 PM, Arnd Bergmann wrote: > > > On Monday 22 September 2014, Kumar Gala wrote: > >> The following changes since commit > >> 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9: > >> > >> Linux 3.17-rc1 (2014-08-16 10:

[Patch v2 1/2] dmaengine: Add ADM driver

2015-01-07 Thread Andy Gross
Signed-off-by: Andy Gross --- drivers/dma/Kconfig| 10 + drivers/dma/Makefile |1 + drivers/dma/qcom_adm.c | 899 3 files changed, 910 insertions(+) create mode 100644 drivers/dma/qcom_adm.c diff --git a/drivers/dma/Kconfig b

[Patch v2 2/2] dt/bindings: qcom_adm: Fix channel specificers

2015-01-07 Thread Andy Gross
via other means. Signed-off-by: Andy Gross --- Documentation/devicetree/bindings/dma/qcom_adm.txt | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/qcom_adm.txt b/Documentation/devicetree/bindings/dma/qcom_adm.txt index

[Patch v2 0/2] Add Qualcomm ADM dmaengine driver

2015-01-07 Thread Andy Gross
sub burst length transactions. Selection of single or box descriptors depends on the sg length and burst size. - Removed use of crci in the dmas property. CRCI is now designated via the slave_config structure and will be stored in slave_id. Andy Gross (2): dmaengine: Add ADM driveri

Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-01-07 Thread Andy Gross
On Wed, Jan 07, 2015 at 09:26:11PM -0600, Andy Gross wrote: I somehow managed to lose my commit message. I'll fix that in the next set. The rest of the patch is fine. > Signed-off-by: Andy Gross -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [Patch v2 2/2] dt/bindings: qcom_adm: Fix channel specificers

2015-01-08 Thread Andy Gross
On Thu, Jan 08, 2015 at 11:26:30AM -0500, Christopher Covington wrote: > > +DMA clients must use the format descripted in the dma.txt file, using a two > > cell specifier for each channel. > > > > Each dmas request consists of 3 cells: > > Now 2 cells? Good catch. I'll fix in next rev. T

[PATCH 2/2] soc: qcom: Add device tree binding for TCSR

2015-01-08 Thread Andy Gross
Add device tree binding support for the QCOM TCSR driver. Signed-off-by: Andy Gross --- .../devicetree/bindings/soc/qcom/qcom,tcsr.txt | 33 +++ include/dt-bindings/soc/qcom,tcsr.h| 34 2 files changed, 67 insertions(+) create mode

[PATCH 0/2] Add Qualcomm TCSR driver

2015-01-08 Thread Andy Gross
configuration settings for the USB PHY selection and ADM DMA CRCI muxing. Andy Gross (2): soc: qcom: Add TCSR driver soc: qcom: Add device tree binding for TCSR .../devicetree/bindings/soc/qcom/qcom,tcsr.txt | 33 drivers/soc/qcom/Kconfig |7

[PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-08 Thread Andy Gross
controller. Signed-off-by: Andy Gross --- drivers/soc/qcom/Kconfig |7 drivers/soc/qcom/Makefile|1 + drivers/soc/qcom/qcom_tcsr.c | 83 ++ include/soc/qcom/qcom_tcsr.h | 21 +++ 4 files changed, 112 insertions(+) create mode

Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-01-09 Thread Andy Gross
On Fri, Jan 09, 2015 at 10:08:20AM +0530, Archit Taneja wrote: > Hi, > > On 01/08/2015 08:56 AM, Andy Gross wrote: > >Signed-off-by: Andy Gross > > > >+static struct dma_async_tx_descriptor *adm_prep_slave_sg(struct dma_chan > >*chan, > >+struc

Re: [PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-09 Thread Andy Gross
On Thu, Jan 08, 2015 at 03:39:44PM -0800, Stephen Boyd wrote: > On 01/08/2015 02:52 PM, Andy Gross wrote: > > + > > +static struct platform_driver qcom_tcsr_driver = { > > + .driver = { > > + .name = "tcsr", > > + .owner

  1   2   3   4   5   6   7   8   >