RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-27 Thread Andrzej Pietrasiewicz
On Monday, November 26, 2012 5:30 PM Sebastian Andrzej Siewior wrote: > On 11/26/2012 09:35 AM, Andrzej Pietrasiewicz wrote: > > In some parts of the kernel (e.g. planned configfs integration into > > usb > > gadget) there is a need to programmatically create config groups >

RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Andrzej Pietrasiewicz
On Tuesday, November 27, 2012 5:00 PM Sebastian Andrzej Siewior wrote: > On 11/27/2012 09:57 AM, Andrzej Pietrasiewicz wrote: > >> |mkdir -p $FABRIC/naa.6001405c3214b06a/tpgt_1 > >> |mkdir $FABRIC/naa.6001405c3214b06a/tpgt_1/lun/lun_0 > >> |mkdir $FABRIC/naa.600

RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Andrzej Pietrasiewicz
On Wednesday, November 28, 2012 9:39 AM Sebastian Andrzej Siewior wrote: > > > > so that we can create the endpoint directories. > > And now what? What names shall the user use for the endpoint > > directories? Oh, that's simple: just see what the endpoint > > directories' names are. But wait, a

RE: [PATCH] fs/configfs: allow to create groups on demand

2012-11-30 Thread Andrzej Pietrasiewicz
On Thursday, November 29, 2012 5:41 PM Sebastian Andrzej Siewior wrote: > Subject: [PATCH] fs/configfs: allow to create groups on demand > > This patch adds a function add a group to an existing one and its > counterart. The newly created group behaves as it would be created via > default_groups[]

RE: [RFC 0/2] USB gadget - configfs

2012-08-29 Thread Andrzej Pietrasiewicz
Hello Joel, On Monday, August 20, 2012 8:00 AM Joel Becker wrote: > I think what you want here is a symlink. Create a directory high in > the tree called 'ready' or 'available', and when you want to lock the > device in place, symlink it into that directory. This will pin the item. > Yo

Re: [PATCH] Remove VLAIS usage from gadget code - alternate patch

2013-09-25 Thread Andrzej Pietrasiewicz
Hi Mark, Nice to hear from you again; on Saturday LOT's dreamliner was not grounded and I have safely returned home ;) Please see my comments inline. W dniu 24.09.2013 19:56, charl...@gmail.com pisze: From: Mark Charlebois --- linux.orig/drivers/usb/gadget/f_fs.c +++ linux/drivers/usb/gadge

RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-10 Thread Andrzej Pietrasiewicz
Hello Joel, So you are alive, I'm glad to hear from you ;) Thank you for your response. On Saturday, December 08, 2012 12:18 AM Joel Becker wrote: > Subject: Re: [RFC][PATCH] fs: configfs: programmatically create config > groups > > Hey Guys, > Sorry I missed this for a while. I'll make a

RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-10 Thread Andrzej Pietrasiewicz
@Joel in particular: please see my comment in the bottom. On Monday, December 10, 2012 12:57 PM I wrote: > Subject: RE: [RFC][PATCH] fs: configfs: programmatically create config > groups > > Hello Joel, > > So you are alive, I'm glad to hear from you ;) Thank you for your response. > > On Satur

RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-10 Thread Andrzej Pietrasiewicz
On Monday, December 10, 2012 3:34 PM Felipe Balbi wrote: > Subject: Re: [RFC][PATCH] fs: configfs: programmatically create config > groups > > Hi, > > On Mon, Dec 10, 2012 at 03:17:34PM +0100, Andrzej Pietrasiewicz wrote: > > @Joel in particular: please see my comment i

[PATCH 0/8] configfs checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
is ready for submission. Andrzej Pietrasiewicz (8): fs/configfs: checkpatch cleanup fs/configfs: checkpatch cleanup fs/configfs: checkpatch cleanup fs/configfs: checkpatch cleanup fs/configfs: checkpatch cleanup fs/configfs: checkpatch cleanup fs/configfs: checkpatch cleanup fs

[PATCH 3/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Conflicts: fs/configfs/dir.c --- fs/configfs/dir.c | 282 +++- 1 files changed, 146 insertions(+), 136 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 712b10f..afa37d2 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/

[PATCH 2/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- fs/configfs/configfs_internal.h | 54 +- 1 files changed, 30 insertions(+), 24 deletions(-) diff --git a/fs/configfs/configfs_internal.h b/fs/configfs/configfs_internal.h index b5f0a3b..4ef5d4d 100644 --- a/fs/configfs/configfs_internal.h +++ b/fs/configf

[PATCH 5/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- fs/configfs/inode.c | 46 +- 1 files changed, 25 insertions(+), 21 deletions(-) diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c index a9d35b0..087fc73 100644 --- a/fs/configfs/inode.c +++ b/fs/configfs/inode.c @@ -19,7 +19,7 @@ * Boston,

[PATCH 6/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- fs/configfs/item.c | 60 +-- 1 files changed, 29 insertions(+), 31 deletions(-) diff --git a/fs/configfs/item.c b/fs/configfs/item.c index 50cee7f..05a08e1 100644 --- a/fs/configfs/item.c +++ b/fs/configfs/item.c @@ -19,7 +19,7 @@ * Boston,

[PATCH 7/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- fs/configfs/mount.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c index aee0a7e..0815d62 100644 --- a/fs/configfs/mount.c +++ b/fs/configfs/mount.c @@ -19,7 +19,7 @@ * Boston, MA 021110-1307, USA. * * Based o

[PATCH 4/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- fs/configfs/file.c | 112 --- 1 files changed, 61 insertions(+), 51 deletions(-) diff --git a/fs/configfs/file.c b/fs/configfs/file.c index 2b6cb23..18e2823 100644 --- a/fs/configfs/file.c +++ b/fs/configfs/file.c @@ -19,7 +19,7 @@ * Boston,

[PATCH 8/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- fs/configfs/symlink.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c index cc9f254..cb9169d 100644 --- a/fs/configfs/symlink.c +++ b/fs/configfs/symlink.c @@ -19,7 +19,7 @@ * Boston, MA 0211

[PATCH 1/8] fs/configfs: checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
--- include/linux/configfs.h | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/include/linux/configfs.h b/include/linux/configfs.h index 34025df..5d33a25 100644 --- a/include/linux/configfs.h +++ b/include/linux/configfs.h @@ -19,7 +19,7

[PATCH 2/8] fs/configfs: configfs_internal.h checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/configfs_internal.h | 54 +- 1 files changed, 30 insertions(+), 24 deletions(-) diff --git a/fs/configfs/configfs_internal.h b/fs

[PATCH 5/8] fs/configfs: inode.c checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/inode.c | 46 +- 1 files changed, 25 insertions(+), 21 deletions(-) diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c

[PATCH 6/8] fs/configfs: item.c checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/item.c | 60 +-- 1 files changed, 29 insertions(+), 31 deletions(-) diff --git a/fs/configfs/item.c b/fs/configfs/item.c

[PATCH 8/8] fs/configfs: symlink.c checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/symlink.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c index

[PATCH 7/8] fs/configfs: mount.c checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/mount.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c index aee0a7e..0815d62 100644 --- a

[PATCH 4/8] fs/configfs: file.c checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/file.c | 112 --- 1 files changed, 61 insertions(+), 51 deletions(-) diff --git a/fs/configfs/file.c b/fs/configfs/file.c

[PATCH RESEND 0/8] configfs checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
is ready for submission. Andrzej Pietrasiewicz (8): fs/configfs: include/linux/configfs.h checkpatch cleanup fs/configfs: configfs_internal.h checkpatch cleanup fs/configfs: dir.c checkpatch cleanup fs/configfs: file.c checkpatch cleanup fs/configfs: inode.c checkpatch cleanup fs

[PATCH 3/8] fs/configfs: dir.c checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/dir.c | 282 +++- 1 files changed, 146 insertions(+), 136 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c

[PATCH 1/8] fs/configfs: include/linux/configfs.h checkpatch cleanup

2013-01-03 Thread Andrzej Pietrasiewicz
Eliminate checkpatch errors and warnings Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- include/linux/configfs.h | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/include/linux/configfs.h b/include/linux

RE: linux-next: Tree for Jul 15 (usb gadget and rdnis)

2013-07-16 Thread Andrzej Pietrasiewicz
Hello, On Monday, July 15, 2013 5:55 PM Randy Dunlap wrote: > On 07/14/13 20:45, Stephen Rothwell wrote: > > Hi all, > > > > The merge window is closed. Time to clean up all those unclean trees. > > The good among you can just fast forward to v3.11-rc1 ;-) > > > > Changes since 20130712: > > >

[PATCH] tools/usb: adapt ffs-test.c to new layout of includes (UAPI)

2013-03-01 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- tools/usb/ffs-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c index 8674b9e..fe1e66b 100644 --- a/tools/usb/ffs-test.c +++ b/tools/usb/ffs-test.c

RE: [RFC 0/2] USB gadget - configfs

2012-08-16 Thread Andrzej Pietrasiewicz
Hello Joel, Thank you for your reply. Please find comments inline. On Wednesday, August 15, 2012 10:14 AM Joel Becker wrote: > > So, the config item corresponding to the lun becomes depended on during > > the write file operation, the same with undepend. Can this be expressed > > with configfs

RE: [RFC 0/2] USB gadget - configfs

2012-08-17 Thread Andrzej Pietrasiewicz
Hello Sebastian, Hello Joel, On Friday, August 17, 2012 11:22 AM Sebastian Andrzej Siewior wrote: > There is a separation between "setting myself up" and "seeing that a host > wants to talk to me". You are a woman. And if you not done yet done you ignore > the host until you are ready. Can also

RE: [RFC 0/2] USB gadget - configfs

2012-08-20 Thread Andrzej Pietrasiewicz
Hello Joel, Thanks for your reply. On Monday, August 20, 2012 8:00 AM Joel Becker wrote: > > I think what you want here is a symlink. Create a directory > high in the tree called 'ready' or 'available', and when you want to > lock the device in place, symlink it into that directory. This

RE: [RFC 0/2] USB gadget - configfs

2012-08-21 Thread Andrzej Pietrasiewicz
Hello Sebastian, On Monday, August 20, 2012 1:01 PM Sebastian Andrzej Siewior wrote > > That would be something like > >$ ln -s /cfg/usb-function-gadget/G1 \ > /cfg/usb-function-gadget/udcs/udc1/ > > Where we "bind" the complete gadget (G1) including the mass storage > configura

RE: [RFC 0/2] USB gadget - configfs

2012-07-10 Thread Andrzej Pietrasiewicz
Dear Joel, Thank you for your review. @Sebastian, Alan, Felipe: Thank you, too. On Monday, July 02, 2012 11:09 AM Joel Becker wrote: > > > As a prerequisite it adds an operation to configfs. The operation allows > > checking if it is ok to remove a pseudo directory corresponding to a > > con

RE: mmotm 2012-07-10-16-59 uploaded (staging/ccg)

2012-07-12 Thread Andrzej Pietrasiewicz
Dear Andrew, On Thursday, July 12, 2012 12:17 AM Andrew Morton wrote: > On Wed, 11 Jul 2012 15:01:32 -0700 > Randy Dunlap wrote: > > > In file included from drivers/staging/ccg/ccg.c:59:0: > > drivers/staging/ccg/../../usb/gadget/f_fs.c:41:0: warning: "pr_vdebug" > redefined > > drivers/staging

[RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Andrzej Pietrasiewicz
rnel can create_groups at will. I kindly ask for comments. In particular, I would like to discuss if this is the right approach. A counterpart to remove config groups is also required. It is not implemented in this patch, though. What are your opinions? Andrzej Pietrasiewicz (1): fs: configfs: all

[RFC][PATCH] fs: configfs: allow other kernel parts to programmatically create config groups

2012-11-26 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/dir.c|5 +++-- include/linux/configfs.h |2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 7414ae2..42608dc 100644 --- a/fs/configfs

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-20 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 19.06.2017 o 15:50, Thierry Escande pisze: Hi Andrzej, On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote: Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event? Unfortunately, the original commit does not mention any clear use case. I&#x

Re: [PATCH v2 4/6] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-20 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-cor

Re: [PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-21 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Here are my thoughts after consulting the documentation: Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
Mi Marcus, W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: > Chip Card Interface Device (CCID) protocol is a USB protocol that > allows a smartcard device to be connected to a computer via a card > reader using a standard USB interface, without the need for each manufacturer > of smartcards to

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: > Hi Andrzej, > > On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote: >> Mi Marcus, >> >> W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: >>> Chip Card Interface Device (CCID) protocol

[PATCH] Revert "kbuild: create deterministic initramfs directory listings"

2018-08-16 Thread Andrzej Pietrasiewicz
/boot/bzImage \ -append "root=/dev/ram console=ttyS0 rdinit=/busybox-x86_64 init" \ -M q35 -initrd ../initramfs.cpio # find find/ find/ find/me find/me/if find/me/if/you find/me/if/you/can find/me/if/you/can/file.txt / # Signed-off-by: Andrzej Pietrasiewicz --- scripts/gen_init

Re: [PATCH] Revert "kbuild: create deterministic initramfs directory listings"

2018-08-17 Thread Andrzej Pietrasiewicz
Hi Bjørn, W dniu 17.08.2018 o 01:34, Bjørn Forsman pisze: > On Thu, 16 Aug 2018 at 18:18, Andrzej Pietrasiewicz > wrote: >> >> This reverts commit 9e6e0d5f2a2713402cf9dce69b9f9b516e4185d2. >> >> The reverted commit introduces broken builds. Even though the cpio a

[PATCH] kbuild: make sorting initramfs contents independent of locale

2018-08-17 Thread Andrzej Pietrasiewicz
patch makes sorting use the default (LANG=C) locale, which results in correctly laid out initramfs images (parent directories before files). Signed-off-by: Andrzej Pietrasiewicz --- scripts/gen_initramfs_list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts

Re: [PATCH next] usb: gadget: uvc: to_uvcg_control_header() can be static

2015-01-13 Thread Andrzej Pietrasiewicz
; was not declared. Should it be static? drivers/usb/gadget/function/uvc_configfs.c:1793:6: sparse: symbol 'uvcg_mjpeg_drop' was not declared. Should it be static? Signed-off-by: Fengguang Wu Reviewed-by: Andrzej Pietrasiewicz --- uvc_configfs.c | 32 ---

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
W dniu 28.05.2018 o 11:32, Marcus Folkesson pisze: > Hi Andrzej, > > Thank you for reviewing. > > On Mon, May 28, 2018 at 11:12:27AM +0200, Andrzej Pietrasiewicz wrote: >> W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: >>> Hi Andrzej, >>> >>> O

[PATCH] media: uapi: Correct doc comment in H264 uAPI

2021-02-04 Thread Andrzej Pietrasiewicz
struct v4l2_ctrl_h264_pps members obviously match picture parameter syntax, not sequence parameter syntax. Signed-off-by: Andrzej Pietrasiewicz --- include/uapi/linux/v4l2-controls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/v4l2-controls.h b

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-08-03 Thread Andrzej Pietrasiewicz
Hi Dmitry, W dniu 12.06.2020 o 10:17, Hans de Goede pisze: Hi, On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: This is a quick respin of v3, with just two small changes, please see the changelog below. Userspace might want to implement a policy to temporarily disregard input from certain

[PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
of that many milliseconds, e.g.: ws:1000c or r:100eis:1000ub Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 9 drivers/tty/sysrq.c | 82 - include/linux/sysrq.h | 1 + 3 files changed, 91 insertions(+

Re: [PATCH v2 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
W dniu 17.08.2020 o 22:09, kernel test robot pisze: Hi Andrzej, I love your patch! Yet something to improve: [auto build test ERROR on 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5] url: https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/Add-configurable-handler-to-execute-a

[PATCH v3 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-18 Thread Andrzej Pietrasiewicz
-SysRq-. Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 2 ++ drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/tty/sysrq.c | 49 +++-- 3 files changed, 50 insertions(+), 3 deletions(-) diff --git a/Documentation/admin

[PATCH v3 0/2] Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
encoding it (Jiri Slaby) - updated help message of sysrq_drm_fb_helper_restore_op (Jiri Slaby) - used unsigned int for specifying delays (Jiri Slaby) - improved printed messages formatting (Jiri Slaby) Andrzej Pietrasiewicz (2): tty/sysrq: Extend the sysrq_key_table to cover capital letters tty/sys

Re: [PATCH v4 2/7] Input: use input_device_enabled()

2020-12-07 Thread Andrzej Pietrasiewicz
Hi Marek, W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze: Hi Andrzej, On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote: Use the newly added helper in relevant input drivers. Signed-off-by: Andrzej Pietrasiewicz This patch landed recently in linux-next as commit d69f0a43c677 ("

[PATCH] kernel/locking: mutex: simplify access to the first entry in the wait-list

2013-12-12 Thread Andrzej Pietrasiewicz
Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- kernel/locking/mutex.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletion

Re: [PATCH] kernel/locking: mutex: simplify access to the first entry in the wait-list

2013-12-12 Thread Andrzej Pietrasiewicz
W dniu 12.12.2013 10:53, Peter Zijlstra pisze: On Thu, Dec 12, 2013 at 10:45:41AM +0100, Andrzej Pietrasiewicz wrote: Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete. Signed-off-by: Andrzej Pietrasiewi

[PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list

2013-12-12 Thread Andrzej Pietrasiewicz
Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- v1..v2: - corrected the email address in the second Signed-off-by line kern

Re: [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list

2013-12-12 Thread Andrzej Pietrasiewicz
rzej Pietrasiewicz Cc: linux-kernel@vger.kernel.org; Kyungmin Park; Marek Szyprowski; Ingo Molnar Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list On Thu, Dec 12, 2013 at 12:29:32PM +0100, Andrzej Pietrasiewicz wrote: Use list_first_entry instead of explic

[PATCH v3] kernel/locking: mutex: simplify access to the first entry in the wait-list

2013-12-13 Thread Andrzej Pietrasiewicz
Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Kyungmin Park --- v2..v3: - changed Singed-off-by to Reviewed-by: Kyungmin Park v1..v2: - corrected

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2014-01-17 Thread Andrzej Pietrasiewicz
W dniu 16.01.2014 17:29, Eric Dumazet pisze: On Thu, 2014-01-16 at 16:21 +0100, Andrzej Pietrasiewicz wrote: W dniu 10.12.2013 15:25, Eric Dumazet pisze: On Tue, 2013-12-10 at 07:55 +0100, Andrzej Pietrasiewicz wrote: W dniu 09.12.2013 16:31, Eric Dumazet pisze: On Mon, 2013-12-09 at 12:47

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2014-01-17 Thread Andrzej Pietrasiewicz
W dniu 17.01.2014 13:18, Andrzej Pietrasiewicz pisze: W dniu 16.01.2014 17:29, Eric Dumazet pisze: On Thu, 2014-01-16 at 16:21 +0100, Andrzej Pietrasiewicz wrote: W dniu 10.12.2013 15:25, Eric Dumazet pisze: On Tue, 2013-12-10 at 07:55 +0100, Andrzej Pietrasiewicz wrote: W dniu 09.12.2013 16

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Andrzej Pietrasiewicz
Hi Alan, W dniu 03.06.2014 16:48, Alan Stern pisze: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce it with RT kernel. WARNING: at drivers/usb/gadget/composite.c: u

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-05 Thread Andrzej Pietrasiewicz
W dniu 04.06.2014 17:26, Alan Stern pisze: On Wed, 4 Jun 2014, Andrzej Pietrasiewicz wrote: What is the difference in purpose between usb_function and usb_function_instance? I can't tell just by reading the header file. Does one of them get created dynamically when the host set

Re: USB_MUSB_DA8XX with g_multi.ko

2014-06-25 Thread Andrzej Pietrasiewicz
W dniu 25.06.2014 17:13, Jon Ringle pisze: In commit 787f5627bec80094db487bfcb401e9744f181aed usb: musb: make davinci and da8xx glues depend on BROKEN USB_MUSB_DA8XX was marked as BROKEN A few months ago, we updated the linux kernel on our AM1808 SoC based embedded board from Linux 2.6.33 to th

Re: [PATCH trivial] Documentation: fix multiple typo occurences s/KenelVersion/KernelVersion/

2014-01-29 Thread Andrzej Pietrasiewicz
Signed-off-by: Ard Biesheuvel Acked-by: Andrzej Pietrasiewicz Cc: Andrzej Pietrasiewicz --- Documentation/ABI/testing/configfs-usb-gadget | 12 ++-- Documentation/ABI/testing/configfs-usb-gadget-acm | 2 +- Documentation/ABI/testing/configfs-usb-gadget

[PATCH] net: sk == 0xffffffff fix - not for commit

2013-12-09 Thread Andrzej Pietrasiewicz
+0x94/0x98) from [] (start_kernel+0x2b8/0x2c4) [ 54.033299] Code: e3043504 e5845010 e34c3030 e5843064 (e5d53012) Signed-off-by: Andrzej Pietrasiewicz --- net/ipv4/tcp_ipv4.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c

Re: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK

2013-12-09 Thread Andrzej Pietrasiewicz
ommon.c:242:3: error: implicit declaration of function 'blksize_bits' [-Werror=implicit-function-declaration] Signed-off-by: Randy Dunlap Cc: Andrzej Pietrasiewicz Cc: Felipe Balbi --- drivers/usb/gadget/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lnx-313-rc3.o

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2013-12-09 Thread Andrzej Pietrasiewicz
W dniu 09.12.2013 16:31, Eric Dumazet pisze: On Mon, 2013-12-09 at 12:47 +0100, Andrzej Pietrasiewicz wrote: NOT FOR COMMITTING TO MAINLINE. With g_ether loaded the sk occasionally becomes 0x. It happens usually after transferring few hundreds of kilobytes to few tens of megabytes. If

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-10-28 Thread Andrzej Pietrasiewicz
Hi, W dniu 28.10.2014 o 12:33, Neil Zhang pisze: Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab will overflow soon if we bind / unbind usb functions frequently like android does. The problem you are describi

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-04 Thread Andrzej Pietrasiewicz
W dniu 04.11.2014 o 12:05, Neil Zhang pisze: -Original Message- From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] Sent: 2014年10月28日 21:10 To: Neil Zhang; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: ba...@ti.com; gre...@linuxfoundation.org Subject: Re: [PATCH

Re: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-07-23 Thread Andrzej Pietrasiewicz
Hi Changbin, (I assume I address your name properly, if not please excuse) W dniu 23.07.2015 o 14:34, Du, Changbin pisze: From 0a8e0d63a9887735c6782d7b0c15c2c1fdf1952a Mon Sep 17 00:00:00 2001 void composite_disconnect(struct usb_gadget *gadget) { struct usb_composite_dev

Re: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-07-24 Thread Andrzej Pietrasiewicz
Hi, W dniu 24.07.2015 o 06:11, Du, Changbin pisze: Thanks, Pietrasiewicz. From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] W dniu 23.07.2015 o 14:34, Du, Changbin pisze: >From 0a8e0d63a9887735c6782d7b0c15c2c1fdf1952a Mon Sep 17 00:00:00 void composite_disconnect(struct usb_gad

[PATCH] fs: configfs: add allow_drop() to configfs_item_operations

2014-10-08 Thread Andrzej Pietrasiewicz
called _after_ corresponding filesystem entities are torn down. In other words, the semantics of (*drop_link)() is "the final, unconditional cleanup". In order not to break this semantics, a new method is added and its value is checked in fs/configfs/symlink.c:configfs_unlink(). Signed-off-b

Re: linux-next: build warnings after merge of the usb-gadget tree

2015-05-20 Thread Andrzej Pietrasiewicz
W dniu 20.05.2015 o 08:29, Stephen Rothwell pisze: Hi Felipe, After merging the usb-gadget tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: drivers/usb/gadget/function/rndis.c: In function 'rndis_proc_write': drivers/usb/gadget/function/rndis.c:1147:4: warning: pass

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2015-02-02 Thread Andrzej Pietrasiewicz
Hello Pali, W dniu 31.01.2015 o 10:53, Pali Rohár pisze: This patch adds removable mass storage support to g_nokia gadget (for N900). It means that at runtime block device can be exported or unexported. For a hint please see this thread: http://www.spinics.net/lists/linux-usb/msg119669.html -

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-16 Thread Andrzej Pietrasiewicz
W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze: In my opinion all things which you have described are working out-of-box when you use configfs interface. It's mostly ready so you may create equivalent of most legacy gadgets (apart from printer and tcm) and just bind from one udc to another w

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-17 Thread Andrzej Pietrasiewicz
W dniu 17.02.2015 o 22:02, Ruslan Bilovol pisze: Hi Andrzej, On Mon, Feb 16, 2015 at 10:07 AM, Andrzej Pietrasiewicz wrote: W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze: In my opinion all things which you have described are working out-of-box when you use configfs interface. It&#

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-09 Thread Andrzej Pietrasiewicz
Hi Nicholas, W dniu 05.03.2016 o 08:26, Nicholas A. Bellinger pisze: Hi Felipe + usb-gadget folks, On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation http://www.spinics.net/lists/target-devel/msg11777.html usb-gadget/tcm: Co

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-10 Thread Andrzej Pietrasiewicz
Hi Nicholas, W dniu 10.03.2016 o 06:19, Nicholas A. Bellinger pisze: Hi Andrzej, On Wed, 2016-03-09 at 13:53 +0100, Andrzej Pietrasiewicz wrote: Hi Nicholas, Applying the following patch to re-add the missing assingment as a proper alloc_session callback. diff --git a/drivers/usb

Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another

2016-04-18 Thread Andrzej Pietrasiewicz
Hi Michał, W dniu 07.04.2016 o 18:40, Michal Nazarewicz pisze: On Thu, 7 Apr 2016, Michal Nazarewicz wrote: This makes me suspect it’s not possible to link a function instance to the same configuration twice, but now that I think about it, I’m not quite sure what would happen if one did:

Re: Locking issues w/ functionfs gadget and aio?

2015-07-01 Thread Andrzej Pietrasiewicz
W dniu 22.06.2015 o 19:20, John Stultz pisze: On Sat, Jun 20, 2015 at 10:24 PM, Al Viro wrote: On Fri, Jun 12, 2015 at 05:51:12PM -0700, John Stultz wrote: I'm not super sure what the right fix is, but if do something like the following (sorry, whitespace corrupted via copy/paste), I don't se

[PATCH] drm: Fix comment doc for format_modifiers

2019-10-02 Thread Andrzej Pietrasiewicz
but the first words of the comment suggest that it passes an array of structs. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index d6ad60ab0d38.

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-09 Thread Andrzej Pietrasiewicz
Hi John, W dniu 08.05.2019 o 04:18, John Stultz pisze: Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather buffers"), I've been seeing trouble with adb transfers in Android on HiKey960, HiKey and now Dragonboard 845c. Sometimes things crash, but often the transfers just stop w/o

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-20 Thread Andrzej Pietrasiewicz
Hi John, Is there anything else I can try for you? Have you tried compiling FunctionFS with debugging enabled? You do so bu uncommenting: /* #define DEBUG */ /* #define VERBOSE_DEBUG */ at the beginning of drivers/usb/gadget/function/f_fs.c Is there anything suspicious in the kernel log w

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-21 Thread Andrzej Pietrasiewicz
Hi, W dniu 20.05.2019 o 23:52, Yang, Fei pisze: One question that comes to my mind is this: Does the USB One of the problems appears to be that req->num_mapped_sgs was left uninitialized. I made the following change and got a lot more requests completed. However this change is not suffici

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-14 Thread Andrzej Pietrasiewicz
Hi, W dniu 13.05.2019 o 20:09, John Stultz pisze: On Mon, May 13, 2019 at 7:08 AM Andrzej Pietrasiewicz wrote: Do you get "functionfs read size 512 > requested size 24, splitting request into multiple reads" message when problems happen? Unfortunately no. Actually that&

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Andrzej Pietrasiewicz
Hi Russell, W dniu 25.06.2019 o 12:03, Russell King - ARM Linux admin pisze: On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote: It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

2016-11-23 Thread Andrzej Pietrasiewicz
Hi Laurent, Thanks for a reminder. Please see inline. W dniu 22.11.2016 o 18:27, Laurent Pinchart pisze: Hi Andrzej and Julia, Could one of you please submit a patch to fix this ? On Thursday 17 Sep 2015 13:18:04 Andrzej Pietrasiewicz wrote: Hi Julia, W dniu 17.09.2015 o 10:57, Julia

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

2015-09-17 Thread Andrzej Pietrasiewicz
1 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Andrzej Pietrasiewicz Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! uvc_configfs.c |3 +-- 1 file changed, 1 insertio

[FIXED PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled()

2020-06-10 Thread Andrzej Pietrasiewicz
A new helper is available, so use it. Inspecting 'users' member of input_dev requires taking device's mutex. Signed-off-by: Andrzej Pietrasiewicz --- drivers/iio/adc/exynos_adc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/exynos_adc.

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-10 Thread Andrzej Pietrasiewicz
Hi All, W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze: On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: Hi All, On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: This is a quick respin of v3, with just two small changes, please see the changelog below. Userspace might want to

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-10 Thread Andrzej Pietrasiewicz
Hi Hans, W dniu 10.06.2020 o 15:21, Hans de Goede pisze: Hi, On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote: Hi All, W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze: On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: Hi All, On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: This

Re: [PATCH] tty/sysrq: Add alternative SysRq key

2020-06-26 Thread Andrzej Pietrasiewicz
KEY_SYSRQ, but other devices use the alternative SysRq key instead, by default F10. Which key is actually used can be modified with sysrq's module parameter. Signed-off-by: Andrzej Pietrasiewicz So... SysRq was selected because you are not going to press Alt-Printscreen-X by default. This p

Re: [PATCH] tty/sysrq: Add alternative SysRq key

2020-06-26 Thread Andrzej Pietrasiewicz
Hi Jiri, W dniu 22.06.2020 o 08:24, Jiri Slaby pisze: On 19. 06. 20, 18:28, Andrzej Pietrasiewicz wrote: There exist machines which don't have SysRq key at all, e.g. chromebooks. This patch allows configuring an alternative key to act as SysRq. Devices which declare KEY_SYSRQ in their &#

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-12 Thread Andrzej Pietrasiewicz
Hi Hans, W dniu 12.06.2020 o 10:30, Hans de Goede pisze: Hi, On 6/10/20 3:41 PM, Andrzej Pietrasiewicz wrote: Hi Hans, W dniu 10.06.2020 o 15:21, Hans de Goede pisze: Hi, On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote: Hi All, W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze: On Wed

Re: [PATCH v4 7/7] Input: Add "inhibited" property

2020-10-06 Thread Andrzej Pietrasiewicz
Hi Dmitry, W dniu 05.10.2020 o 20:10, Dmitry Torokhov pisze: Hi Andrzej, On Mon, Jun 08, 2020 at 01:22:11PM +0200, Andrzej Pietrasiewicz wrote: @@ -284,8 +284,11 @@ static int input_get_disposition(struct input_dev *dev, case EV_KEY: if (is_event_supported(code, dev

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is easier to pull stuff from :) Anyway, what ever happened

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
W dniu 02.10.2020 o 14:33, Andrzej Pietrasiewicz pisze: W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g. 'w' (show blocked tasks), followed by 's' (sync), followed by 1000 ms delay and then followed by 'c

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.10.2020 o 16:02, Greg Kroah-Hartman pisze: On Fri, Oct 02, 2020 at 03:42:52PM +0200, Andrzej Pietrasiewicz wrote: Hi, W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g

  1   2   >