Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-29 Thread Andrew Lunn
> Now I activated the debug messages in em28xx. From the messages I > see no correlation of the pool exhaustion and lost sync. Also I > cannot see any error messages from the em28xx driver. > I see a lot of init_isoc/stop_urbs (maybe EPG scan?) without > draining the coherent pool (checked with 'ca

Re: [PATCH] power/reset: Remove newly introduced __dev* annotations

2013-01-30 Thread Andrew Lunn
> static struct platform_driver restart_poweroff_driver = { > .probe = restart_poweroff_probe, > - .remove = __devexit_p(restart_poweroff_remove), > + .remove = restart_poweroff_remove, > .driver = { > .name = "poweroff-restart", >

Re: [PATCH] ARM: mv78xx0: correct addr_map_cfg __initdata annotation

2012-10-03 Thread Andrew Lunn
nitialization from incompatible pointer type [enabled by default] > /home/arnd/linux-arm/arch/arm/mach-mv78xx0/addr-map.c:59:2: warning: (near > initialization for 'addr_map_cfg.win_cfg_base') [enabled by default] > > Signed-off-by: Arnd Bergmann > Cc: Jason Cooper > Cc:

Re: [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update

2012-10-24 Thread Andrew Lunn
On Wed, Oct 24, 2012 at 03:49:21PM +0200, Gregory CLEMENT wrote: > From: Lior Amsalem > > Signed-off-by: Gregory CLEMENT > Signed-off-by: Lior Amsalem > --- > arch/arm/boot/dts/armada-370-db.dts |3 +++ > arch/arm/boot/dts/armada-370-xp.dtsi | 10 ++ > arch/arm/boot/dts/armada-x

Re: [PATCH V2 0/4] Adding SATA support for Armada 370/XP

2012-10-26 Thread Andrew Lunn
On Fri, Oct 26, 2012 at 02:30:45PM +0200, Gregory CLEMENT wrote: > Hello, > > this patch set adds the SATA support for Armada 370 and Armada XP. Few > changes have been done since the first version by taking in account > the comments received for the first version. > > The evaluation boards for A

Re: [PATCH V2 0/4] Adding SATA support for Armada 370/XP

2012-10-26 Thread Andrew Lunn
On Fri, Oct 26, 2012 at 02:48:04PM +0200, Thomas Petazzoni wrote: > > On Fri, 26 Oct 2012 14:39:08 +0200, Andrew Lunn wrote: > > > What about the openblocks-ax3? > > Gr??gory does not (yet) have an OpenBlocks AX3, but I'm planning to do > the work for SATA so

Re: [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP

2012-10-26 Thread Andrew Lunn
On Fri, Oct 26, 2012 at 09:31:54AM -0400, Jason Cooper wrote: > On Fri, Oct 26, 2012 at 02:30:47PM +0200, Gregory CLEMENT wrote: > > Signed-off-by: Gregory CLEMENT > > Signed-off-by: Lior Amsalem > > --- > > arch/arm/boot/dts/armada-370-xp.dtsi |9 + > > 1 file changed, 9 insertions(

Re: [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP

2012-10-26 Thread Andrew Lunn
> Now, about white spaces vs tab, I don't know what is the rule for .dts > file. I personally use tabs, but i don't see anything in the Documentation/CodingStyle. Maybe ask on the device tree mailing list? Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 1/1] ARM: dove: DT support for sdhci-dove

2012-07-30 Thread Andrew Lunn
+++ b/Documentation/devicetree/bindings/mmc/sdhci-dove.txt @@ -0,0 +1,12 @@ +* Marvell sdhci-dove controller + +Required properties: +- compatible: Should be "marvell,dove-sdhci". + +Example: + +sdio0: sdio@92000 { + compatible = "marvell,dove-sdhci"; + reg = <0x92000 0x100>; + in

Re: [PATCH 2/6] ARM: dove: Fix tauros2 device tree init

2012-09-24 Thread Andrew Lunn
On Tue, Sep 25, 2012 at 03:22:04AM +0200, Sebastian Hesselbarth wrote: > On 09/25/2012 02:02 AM, Sebastian Hesselbarth wrote: > >During the review process of dove DT patches, Tauros2 cache > >init call was changed and DT support added. This patch fixes > >the call to Tauros2 init and adds a DT node

Re: [PATCH 5/6] ARM: dove: Remove watchdog from DT

2012-09-24 Thread Andrew Lunn
On Tue, Sep 25, 2012 at 02:02:17AM +0200, Sebastian Hesselbarth wrote: > The watchdog on dove requires an interrupt that is not yet > available on DT. Therefore, the watchdog DT node is removed > until the corresponding chained intc is available. Hi Sebastian Just for my understanding: Is the pro

Re: [PATCH 0/6] Dove fixes for arm-soc/for-next

2012-09-24 Thread Andrew Lunn
ertions(+), 21 deletions(-) Its a bit late, Jason has already sent the pull request. But: Acked-by: Andrew Lunn None of my questions should be considered as NACKs for these patches. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH 5/6] ARM: dove: Remove watchdog from DT

2012-09-25 Thread Andrew Lunn
On Tue, Sep 25, 2012 at 11:18:26AM +0200, Thomas Petazzoni wrote: > Dear Sebastian Hesselbarth, > > On Tue, 25 Sep 2012 11:11:42 +0200, Sebastian Hesselbarth wrote: > > > I didn't try to post all the dove on mach-mvebu patches in the current > > release cycle, because mach-mvebu is still evolving

Re: [PATCH 5/6] ARM: dove: Remove watchdog from DT

2012-09-25 Thread Andrew Lunn
On Tue, Sep 25, 2012 at 12:14:39PM +0200, Thomas Petazzoni wrote: > Dear Andrew Lunn, > > On Tue, 25 Sep 2012 11:46:10 +0200, Andrew Lunn wrote: > > > I principle, i agree. However, i'm not too sure about mach-orion5x & > > mach-mv78xx0. orion5x has probably be

Re: [PATCH] arm: mvebu: support for the Globalscale Mirabox MBX0001 board

2012-10-27 Thread Andrew Lunn
> diff --git a/arch/arm/boot/dts/mbx001.dts b/arch/arm/boot/dts/mbx001.dts > new file mode 100644 > index 000..88a5a11 > --- /dev/null > +++ b/arch/arm/boot/dts/mbx001.dts Hi Gregory Maybe it would be good to prefix this with armada-370. It then fits with armada-370-db.dts, and all the kirkwo

[PATCH] Regulator: core: Unregister when gpio request fails.

2012-10-28 Thread Andrew Lunn
If the gpio_request_one() fails, or returns EPROBE_DEFER, the regulator must be device_unregister()ed. When this is not done, there are WARNING: from sysfs: WARNING: at fs/sysfs/file.c:343 sysfs_open_file+0x238/0x268() Signed-off-by: Andrew Lunn --- drivers/regulator/core.c |3 ++- 1 file

Re: [PATCH 1/2] ARM: kirkwood: retain MAC address for DT ethernet

2013-10-03 Thread Andrew Lunn
g/cgit/linux/kernel/git/davem/net.git/commit/?id=569943d0639c85a451ea853087cbd5f738247dd9 > > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Russell King > Cc: Grant Likely > Cc: Benjamin Herrenschmidt > Cc: Jason Gunthorpe > Cc: Ezequiel Garcia > Cc: linux-arm-ker...@lists.infradead.org > Cc:

Re: [PATCH v2 1/2] ARM: kirkwood: retain MAC address for DT ethernet

2013-10-03 Thread Andrew Lunn
> Sebastian, does __clk_enabled work properly for the mvebu clock > provider? I don't see a clk_ops.is_enabled for mvebu.. (don't know > much about clk) Hi Jason It is implemented in drivers/clk/clk-gate.c, which is what mvebu is using. Andrew -- To unsubscribe from this list: send the line "

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-04 Thread Andrew Lunn
; Signed-off-by: Sebastian Hesselbarth Tested-by: Andrew Lunn Andrew > --- > Cc: Mike Turquette > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Grant Likely > Cc: Benjamin Herrenschmidt > Cc: Jason Gunthorpe > Cc: Ezequiel Garcia >

Re: [PATCH RESEND v3] ARM: kirkwood: retain MAC address for DT ethernet

2013-10-04 Thread Andrew Lunn
2->v3: > - make use of new public clk_is_enabled (adds dependency [1]) > - add warning about gated clock && missing MAC property > (Suggested by Jason Gunthorpe) > v1->v2: > - check for gated clock before accessing eth registers > (Suggested by Andrew Lunn) >

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-05 Thread Andrew Lunn
On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wrote: > On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote: > > To determine if a clk has been previously enabled, provide a public > > clk_is_enabled function. This is especially helpful to check the state > > of clk-ga

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Andrew Lunn
On Sun, Oct 06, 2013 at 11:06:09AM +0200, Gerhard Sittig wrote: > On Sat, Oct 05, 2013 at 22:42 +0200, Andrew Lunn wrote: > > > > On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wrote: > > > On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote:

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Andrew Lunn
> Andrew has mentioned, that some bootloaders might disable clocks but > leave the nodes enabled. Reading those registers would lock up > the HW, of course. So we thought about to check clk gate status first, > which this patch is about. > > Of course, we can do clk_enable, read, clk_disable as sa

Re: [PATCH 069/228] cpufreq: kirkwood: Use generic cpufreq routines

2013-09-14 Thread Andrew Lunn
ch uses these generic routines for this driver. > > Cc: Andrew Lunn > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/kirkwood-cpufreq.c | 22 +++--- > 1 file changed, 3 insertions(+), 19 deletions(-) Hi Viresh You can add: Tested-by: Andrew Lunn to [PATCH

Re: [PATCH 195/228] cpufreq: kirkwood: remove calls to cpufreq_notify_transition()

2013-09-13 Thread Andrew Lunn
On Fri, Sep 13, 2013 at 06:32:21PM +0530, Viresh Kumar wrote: > - if (freqs.old != freqs.new) { > - local_irq_disable(); > - > - /* Disable interrupts to the CPU */ > - reg = readl_relaxed(priv.base); > - reg |= CPU_SW_INT_BLK; > - wr

Re: [PATCH 11/26] ARM: dove: remove custom .init_time hook

2013-09-21 Thread Andrew Lunn
t; Cc: Olof Johansson > Cc: Arnd Bergmann > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/mach-dove/board-dt.c | 11 --- > 1 file changed, 11 deletions(-)

Re: [PATCH 15/26] ARM: kirkwood: remove custom .init_time hook

2013-09-21 Thread Andrew Lunn
; Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/mach-kirkwood/board-dt.c |8 > 1 file changed, 8 deletions(-) Hi Sebastian Boot tested on a Kirkwood Topkick

Re: [PATCH 11/26] ARM: dove: remove custom .init_time hook

2013-09-23 Thread Andrew Lunn
On Sun, Sep 22, 2013 at 02:20:28PM +0200, Sebastian Hesselbarth wrote: > On 09/21/2013 02:22 PM, Andrew Lunn wrote: > >On Wed, Sep 18, 2013 at 07:53:44PM +0200, Sebastian Hesselbarth wrote: > >>With arch/arm calling of_clk_init(NULL) from time_init(), we can now > >>rem

Re: [PATCH 3/4 v2] gpio/mvebu: convert to use irq_domain_add_simple()

2012-10-20 Thread Andrew Lunn
kely > Cc: Thomas Petazzoni > Cc: Sebastian Hesselbarth > Cc: Andrew Lunn > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Keep irq_create_mapping() and do not replace with > irq_find_mapping() - if a linear domain is the outcome, > we really need to all

Re: [PATCH] ARM: Orion: Hoist bridge interrupt handling out of the timer

2012-12-08 Thread Andrew Lunn
On Fri, Dec 07, 2012 at 03:55:07PM -0700, Jason Gunthorpe wrote: > The intent of this patch is to expose the other bridge cause > interrupts to users in the kernel. > > - Add orion_bridge_irq_init to create a new edge triggered interrupt > chip based on the bridge cause register > - Remove all i

Re: [PATCH] ARM: Orion: Hoist bridge interrupt handling out of the timer

2012-12-09 Thread Andrew Lunn
On Sat, Dec 08, 2012 at 07:57:48PM -0700, Jason Gunthorpe wrote: > On Sat, Dec 08, 2012 at 12:26:24PM +0100, Andrew Lunn wrote: > > > 1) It should have an IRQ domain, like the other IRQ chips we have. > > 2) It should have a DT binding, like the other IRQ chips we have. >

Re: [PATCH] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-12 Thread Andrew Lunn
On Mon, Nov 12, 2012 at 10:48:02AM +0100, Soeren Moch wrote: > On 11.11.2012 18:22, Andrew Lunn wrote: > > On Thu, Nov 08, 2012 at 07:38:57AM +0100, Marek Szyprowski wrote: > >> dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, > regardless > >> the flag

Re: [PATCH V2 1/4] arm: mvebu: increase atomic coherent pool size for armada 370/XP

2012-11-06 Thread Andrew Lunn
On Tue, Nov 06, 2012 at 10:28:45PM +0100, S?ren Moch wrote: > resent as plain text, sorry. > > > > For Armada 370/XP we have the same problem that for the commit > > cb01b63, so we applied the same solution: "The default 256 KiB > > coherent pool may be too small for some of the Kirkwood devices,

Re: [PATCH] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-11 Thread Andrew Lunn
oni > Signed-off-by: Marek Szyprowski Tested-by: Andrew Lunn I tested this on a Kirkwood QNAP after removing the call to init_dma_coherent_pool_size(). Andrew > --- > mm/dmapool.c | 27 +++ > 1 file changed, 7 insertions(+), 20 deletions(-) >

Re: [PATCH 1/2] clk: mvebu: armada 370/XP add clock gating control provider for DT

2012-11-17 Thread Andrew Lunn
Hi Gregory Nice work On Fri, Nov 16, 2012 at 07:01:59PM +0100, Gregory CLEMENT wrote: > Signed-off-by: Gregory CLEMENT > --- > .../bindings/clock/mvebu-gated-clock.txt | 43 ++ > arch/arm/mach-mvebu/Kconfig|1 + > drivers/clk/mvebu/clk-gating-

Re: [PATCH 1/2] clk: mvebu: armada 370/XP add clock gating control provider for DT

2012-11-17 Thread Andrew Lunn
> > What is the ddr clock for? Does bad things happen if you turn it off? > > Kirkwood has a similar clock, dunit, which i decided not to export, > > since when you turn it off, the whole SoC locks up. > > Well of course if you code run in DDR then it could be a problem. But > I think it could be

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Andrew Lunn
r/0/0x40000500 > > Working with Andrew Lunn we dug in further with full stack traces: > > [ 53.173973] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready > [ 54.191655] BUG: scheduling while atomic: crond/144/0x4300 > [ 54.197537] Modules linked in: rmd160 sha1_gene

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Andrew Lunn
> >> diff -ruN a/drivers/staging/rtl8712/rtl871x_sta_mgt.c > >> b/drivers/staging/rtl8712/rtl871x_sta_mgt.c > >> --- a/drivers/staging/rtl8712/rtl871x_sta_mgt.c 2012-11-05 > >> 03:57:06.0 -0500 > >> +++ b/drivers/staging/rtl8712/rtl871x_sta_mgt.c 2012-11-13 > >> 12:54:28.0 -0500 > >

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Andrew Lunn
On Sun, Nov 18, 2012 at 02:18:37PM -0600, Larry Finger wrote: > On 11/18/2012 12:11 PM, Andrew Lunn wrote: > > > >Just to clarify the issue here: > > > >union pn48 { > > u64 val; > >#if defined(__BIG_ENDIAN) > > struct { > >

Re: [PATCH 1/2] clk: mvebu: armada 370/XP add clock gating control provider for DT

2012-11-19 Thread Andrew Lunn
On Mon, Nov 19, 2012 at 04:46:11PM +0100, Thomas Petazzoni wrote: > Dear Andrew Lunn, > > On Sat, 17 Nov 2012 14:54:35 +0100, Andrew Lunn wrote: > > > > What is the ddr clock for? Does bad things happen if you turn it off? > > > > Kirkwood has a similar clock, dun

Re: [PATCH v4 2/6] clocksource: add Marvell Orion SoC timer

2013-06-10 Thread Andrew Lunn
ll also work on Dove and it is > messing > with shared registers. It has done it before, so I consider it broken > anyway. > I (or somebody else) will take care of proper watchdog later. > - An updated branch can be found on > git://github.com/shesselba/linux-dove.git orion-ir

Re: [PATCH 2/5] arm: mvebu: Select DMA_BOUNCE when LPAE is selected in Kconfig

2013-03-21 Thread Andrew Lunn
On Thu, Mar 21, 2013 at 05:26:15PM +0100, Gregory CLEMENT wrote: > From: Lior Amsalem > > For mvebu IOs are 32 bits and we have 40 bits memory due to LPAE so > make sure we give 32 bits addresses to the IOs. Hi Gregory, Lior I don't really understand what this comment is supposed to mean. I wou

Re: [PATCH 5/5] arm: dts: Convert mvebu device tree files to 64 bits

2013-03-21 Thread Andrew Lunn
> /* > - * 4 GB of plug-in RAM modules by default but only 3GB > - * are visible, the amount of memory available can be > - * changed by the bootloader according the size of the > - * module actually plugged > + * 8 GB o

Re: [PATCH 5/5] arm: dts: Convert mvebu device tree files to 64 bits

2013-03-21 Thread Andrew Lunn
On Thu, Mar 21, 2013 at 09:22:36PM +0100, Thomas Petazzoni wrote: > Dear Andrew Lunn, > > On Thu, 21 Mar 2013 21:15:33 +0100, Andrew Lunn wrote: > > > Could you recommend a document which introduces LPAE. > > > > Only being able to address 7GB seems a bit odd to

Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-21 Thread Andrew Lunn
On Thu, Mar 21, 2013 at 05:12:01PM -0400, Alan Stern wrote: > On Thu, 21 Mar 2013, Alan Stern wrote: > > > On Thu, 21 Mar 2013, Soeren Moch wrote: > > > > > Now I found out what is going on here: > > > > > > In itd_urb_transaction() we allocate 9 iTDs for each URB with > > > number_of_packets =

Re: [PATCH] ARM: kirkwood: make use of DT mvsdio on guruplug board

2013-03-26 Thread Andrew Lunn
reaking nand by configuring mpp0 > to gpio, while used also by nand (nand_io2 on mpp0). > > Signed-off-by: Sebastian Hesselbarth > Tested-by: Soeren Moch Acked-by: Andrew Lunn > --- > Cc: Soeren Moch > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Russell King

Re: [PATCH] ARM: kirkwood: add MACH_GURUPLUG_DT to defconfig

2013-03-26 Thread Andrew Lunn
On Sat, Mar 23, 2013 at 01:58:22PM +0100, Sebastian Hesselbarth wrote: > This patch just adds the missing MACH_GURUPLUG_DT to kirkwood_defconfig. > > Signed-off-by: Sebastian Hesselbarth > Reported-by: Soeren Moch Acked-by: Andrew Lunn > --- > Cc: Soeren Moch > C

Re: [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4

2013-03-26 Thread Andrew Lunn
On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth Acked-

Re: [PATCH -next] mtd: orion_nand: convert to use devm_* APIs

2013-07-17 Thread Andrew Lunn
On Wed, Jul 17, 2013 at 10:09:10AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Convert to use devm_* APIs to avoid resources leak on error handling case. > > Signed-off-by: Wei Yongjun > --- > drivers/mtd/nand/orion_nand.c | 29 + > 1 file changed, 9 insertion

Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-17 Thread Andrew Lunn
T parsing and uses cpu->of_node instead. > > Cc: Andrew Lunn > Cc: Jason Cooper > Acked-by: Viresh Kumar > Signed-off-by: Sudeep KarkadaNagesha > --- > drivers/cpufreq/kirkwood-cpufreq.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > &

Re: [PATCH 4/4] ARM: dove: add initial DT file for Globalscale D2Plug

2013-07-29 Thread Andrew Lunn
On Mon, Jul 29, 2013 at 02:29:06PM +0200, Sebastian Hesselbarth wrote: > This adds an initial DT file for the Globalscale D2Plug with Dove SoC. > Currently, one LED is missing and I have not been able to get SD8787 driver > working. Those will be taken care of later. Hi Sebastion I took a hard lo

Re: [PATCH] ATA: sata_mv: Remove uneeded CONFIG_HAVE_CLK ifdefs

2013-07-29 Thread Andrew Lunn
On Mon, Jul 29, 2013 at 12:21:22PM -0300, Ezequiel Garcia wrote: > If CONFIG_HAVE_CLK is not selected, then all the clk API turn out > into stubs, so there's no need to have the ifdefs. > The only side-effect of this patch is the extra tiny kmalloc, > but that's not enough reason to have such ugly

Re: [PATCH 4/4] ARM: dove: add initial DT file for Globalscale D2Plug

2013-07-30 Thread Andrew Lunn
On Tue, Jul 30, 2013 at 10:03:56AM +0200, Sebastian Hesselbarth wrote: > On 07/29/2013 08:45 PM, Andrew Lunn wrote: > >On Mon, Jul 29, 2013 at 02:29:06PM +0200, Sebastian Hesselbarth wrote: > >>This adds an initial DT file for the Globalscale D2Plug with Dove SoC. > >>Cu

Re: [PATCH 17/35] cpufreq: kirkwood: use cpufreq_table_validate_and_show()

2013-08-08 Thread Andrew Lunn
On Thu, Aug 08, 2013 at 07:18:19PM +0530, Viresh Kumar wrote: > Lets use cpufreq_table_validate_and_show() instead of calling > cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). > > Cc: Andrew Lunn > Signed-off-by: Viresh Kumar > --- > drivers/cpufr

Re: [PATCH v3 12/16] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-23 Thread Andrew Lunn
rsing and uses cpu->of_node instead. > > Cc: Andrew Lunn > Cc: Jason Cooper > Acked-by: Viresh Kumar > Signed-off-by: Sudeep KarkadaNagesha > --- > drivers/cpufreq/kirkwood-cpufreq.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --gi

Re: [PATCH] irqchip: add support for Marvell Orion SoCs

2013-05-02 Thread Andrew Lunn
On Thu, May 02, 2013 at 09:48:50PM +0200, Sebastian Hesselbarth wrote: > On 05/02/2013 09:35 PM, Jason Gunthorpe wrote: > >I have kirkwood HW but I haven't had time to make newer kernels run on > >it, otherwise I'd test it too :( > > I also have kirkwood HW but that will cut me from email as I use

Re: [PATCH v2 2/5] ARM: dove: add DT parsing for legacy mv643xx_eth

2013-05-02 Thread Andrew Lunn
support for mv643xx_eth. > > Signed-off-by: Sebastian Hesselbarth > --- > Changelog: > v1->v2: > - split off DT changes (Suggested by Jason Cooper) > > Cc: Grant Likely > Cc: Rob Herring > Cc: Rob Landley > Cc: Thomas Gleixner > Cc: Russell King > Cc: Arnd

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-21 Thread Andrew Lunn
per-board > basis. > > Signed-off-by: Sebastian Hesselbarth > --- > Changelog: > v3->v4: > - convert to new device tree binding > > Cc: David Miller > Cc: Lennert Buytenhek > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Benjamin Herrenschmid

Re: [PATCH v4 00/12] net: mv643xx_eth DT support and fixes

2013-05-22 Thread Andrew Lunn
On Tue, May 21, 2013 at 06:41:38PM +0200, Sebastian Hesselbarth wrote: > This patch set picks up work by Florian Fainelli bringing full DT > support to mv643xx_eth and Marvell SoCs using it. Hi Sebastian I tested on my QNAP and topkick. Works great. Tested-by: Andrew Lunn Andrew

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Andrew Lunn
> > Why are you not keen on this? It seems like normal device driver > > practice, that is what the data field of of_device_id is typically > > used for.. > > I'm not keen on it because we don't have a document saying "All kirkwood > SoCs need PSC1 set to X after reset." We know it, but have we t

Re: [PATCH] kirkwood: fix coccicheck warnings

2013-03-11 Thread Andrew Lunn
all explicit > error messages can be removed from the failure code paths. > > Signed-off-by: Silviu-Mihai Popescu > --- Acked-by: Andrew Lunn Thanks Andrew > drivers/cpufreq/kirkwood-cpufreq.c |8 +++- > drivers/cpuidle/cpuidle-kirkwood.c |

Re: linux-next: manual merge of the akpm tree with the arm-soc tree

2013-03-11 Thread Andrew Lunn
tree and commit "rtc: > rtc-mv: use devm_rtc_device_register()" from the akpm tree. > > I fixed it up (I think - see below) and can carry the fix as necessary > (no action is required). Hi Stephan Looks O.K. to me. Acked-by: Andrew Lunn > > -- > Cheers

Re: [PATCH 01/11] pinctrl: mvebu: pinctrl driver core

2012-08-25 Thread Andrew Lunn
On Mon, Aug 20, 2012 at 11:09:51AM +0200, Linus Walleij wrote: > On Sat, Aug 11, 2012 at 2:56 PM, Sebastian Hesselbarth > wrote: > > > This patch adds a pinctrl driver core for Marvell SoCs plus DT > > binding documentation. This core driver will be used by SoC family > > specific drivers, i.e. A

Re: [3.6-rc3 regression] sata_mv cannot get optional clkdev breaking boot on QNAP TS-119P+

2012-08-25 Thread Andrew Lunn
On Sat, Aug 25, 2012 at 03:01:33PM +0200, Mikael Pettersson wrote: > My Kirkwood-based QNAP TS-119P+ boots fine with the 3.5 kernel. With > 3.6-rc2 and 3.6-rc3 however sata_mv complains: > > sata_mv sata_mv.0: cannot get optional clkdev > sata_mv sata_mv.0: slots 32 ports 2 > > and then the kern

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-16 Thread Andrew Lunn
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt > @@ -0,0 +1,279 @@ > +* Marvell Kirkwood SoC pinctrl driver for mpp > + > +Please refer to marvell,mvebu-pinctrl.txt in this directory for common > binding > +part and usage. > + > +Required properties: > +- compatible

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-17 Thread Andrew Lunn
> I had a closer look at how kirkwood probes its id. I mentionend kirkwood_id() > earlier but in fact it is kirkwood_pcie_id(). I assume pcie registers are shut > down with pcie clk gated? That would require to have pcie running at least at > boot-time on all boards. > > While it is still possible

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-18 Thread Andrew Lunn
s v3 patch set Since Linus Walleij thinks that autoprobing is not going to happen, Tested-by: Andrew Lunn However, i still think it would be nice to have auto probing. Andrew > Cc: Sebastian Hesselbarth > Cc: Thomas Petazzoni > Cc: Grant Likely > Cc: Rob Herring > Cc: Ro

Re: [PATCH 00/11] pinctrl: mvebu: pinctrl driver

2012-09-20 Thread Andrew Lunn
Hi Thomas > Hum, which patches are stalling the integration into the Marvell tree? l2 cache, I think. The trees Jason built for pull requests in the direction of arm-soc had the l2 cache patch as the very first in the series. Now that these patches have run into some trouble, its blocking all th

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-20 Thread Andrew Lunn
On Thu, Sep 20, 2012 at 03:30:40PM +, Arnd Bergmann wrote: > On Monday 17 September 2012, Linus Walleij wrote: > > You found the weak spot between two consolidation tracks. > > > > Getting rid of a broadcast autodetect functions from say > > is nominally done by passing the data > > to the dr

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-20 Thread Andrew Lunn
> So, wouldn't we need a small, architecture-independent, infrastructure, > through which architecture-specific code could "register" at boot > time which SoC we are running on, and drivers could query this > information from the common infrastructure? > > Of course, the major problem is to figure

Re: [PATCH 1/6] ARM: dove: unify clock setup

2012-08-11 Thread Andrew Lunn
Hi Sebastian > -static void __init clk_init(void) > +static void __init dove_clk_init(void) > { > tclk = clk_register_fixed_rate(NULL, "tclk", NULL, CLK_IS_ROOT, > -get_tclk()); > +dove_tclk); > > orion_clkdev_i

Re: [PATCH v2 2/6] ARM: dove: add clock gating control

2012-08-12 Thread Andrew Lunn
both enabled/disabled at the same time. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Rabeeh Khoury > Cc: Ian Molton >

Re: [PATCH 03/10] ARM: mv78xx0: fix win_cfg_base prototype

2012-08-13 Thread Andrew Lunn
arch/arm/mach-mv78xx0/addr-map.c:59:2: warning: (near initialization for > 'addr_map_cfg.win_cfg_base') [enabled by default] > > Signed-off-by: Arnd Bergmann > Cc: Andrew Lunn > Cc: Michael Walle > Cc: Nicolas Pitre > --- > arch/arm/mach-mv78xx0/addr-map.c |

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Andrew Lunn
On Thu, Jan 17, 2013 at 08:26:45PM +, Arnd Bergmann wrote: > On Thursday 17 January 2013, Soeren Moch wrote: > > On 17.01.2013 11:49, Arnd Bergmann wrote: > > > On Wednesday 16 January 2013, Soeren Moch wrote: > > I will see what I can do here. Is there an easy way to track the buffer > >

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Andrew Lunn
> Please find attached a debug log generated with your patch. > > I used the sata disk and two em28xx dvb sticks, no other usb devices, > no ethernet cable connected, tuners on saa716x-based card not used. > > What I can see in the log: a lot of coherent mappings from sata_mv > and orion_ehci, a

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Andrew Lunn
On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: > On 19.01.2013 19:59, Andrew Lunn wrote: > >>Please find attached a debug log generated with your patch. > >> > >>I used the sata disk and two em28xx dvb sticks, no other usb devices, > >>no ethe

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Andrew Lunn
> >> > > > >Now (in the last hour) stable, occasionally lower numbers: > >3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >3396 3

Re: [PATCH 3/4] Enable ecc-mode selection in the driver

2013-01-15 Thread Andrew Lunn
On Tue, Jan 15, 2013 at 01:13:12PM +0100, Stefan Peter wrote: > In order to be able to use the ecc-mode, add the bch module to the default > settings for the kirwood boards and enable the activation in orin-nand.c > > Signed-off-by: Stefan Peter > --- > diff --git a/arch/arm/configs/kirkwood_defc

Re: power: Add simple poweroff-gpio driver

2012-12-14 Thread Andrew Lunn
On Thu, Dec 13, 2012 at 03:51:59PM -0500, Dave Jones wrote: > On Thu, Dec 13, 2012 at 08:21:57PM +, Linux Kernel wrote: > > Gitweb: > http://git.kernel.org/linus/;a=commit;h=96ff0f5c7efd4a2205c48a76a6a1fcd2731e6128 > > Commit: 96ff0f5c7efd4a2205c48a76a6a1fcd2731e6128 > > Parent:

Re: power: Add simple poweroff-gpio driver

2012-12-14 Thread Andrew Lunn
> > I think it needs to be on the menuconfig, rather than the child options. > > I don't have OF_GPIO, but I still got asked for the former. > > The menuconfig enables a class of drivers (at least theoretically in the > future, when more such drivers turn up), and there's no reason to > believe th

Re: power: Add simple poweroff-gpio driver

2012-12-14 Thread Andrew Lunn
> > Its a generic driver. I know its useful on various Marvell kirkwood > > and orion5x devices. I've also heard it useful on some Tegra boards. > > > > Are you asking i list these boards? > > No, but at least mentioning the architecture might have clued me in > quicker that this wasn't some

Re: [PATCH] gpio: mvebu: Add missing breaks in mvebu_gpio_irq_set_type

2012-09-30 Thread Andrew Lunn
u &= ~(1 << pin); /* rising */ > writel_relaxed(u, mvebu_gpioreg_in_pol(mvchip)); > + break; > } > } > return 0; Hi Axel Good catch, thanks. Acked-by: Andrew Lunn Andrew -- To unsubscribe from this list: send the line &q

Re: [PATCH 3/4] Enable ecc-mode selection in the driver

2013-01-16 Thread Andrew Lunn
On Wed, Jan 16, 2013 at 12:43:57PM +0100, Stefan Peter wrote: > Hi Andrew > > on 15.01.2013 13:51, Andrew Lunn wrote: > > On Tue, Jan 15, 2013 at 01:13:12PM +0100, Stefan Peter wrote: > >> In order to be able to use the ecc-mode, add the bch module to the default >

Re: [PATCH net-next v3 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-19 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 08:45:40PM -0400, Vivien Didelot wrote: > Implement the DSA driver function to configure the bridge ageing time. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr

2016-07-19 Thread Andrew Lunn
top of a physical > switch and ageing time are switch-wide, call the driver function with > the fastest ageing time in use on the chip instead of the requested one. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v3 11/12] net: dsa: mv88e6xxx: add G1 helper for ageing time

2016-07-19 Thread Andrew Lunn
gt; models. E.g. 88E6060, 88E6352 and 88E6390 use respectively 16, 15 and > 3.75 seconds. > > Add a age_time_coeff to the info structure to handle this and a Global 1 > helper to set the default age time of 5 minutes in the setup code. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: > This patch simply moves the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. I think it is a bit early for this. Lets convert all in kernel users to the new binding first. > Signed-off-

Re: [PATCH net-next v2 1/3] net: dsa: mv88e6xxx: remove unused phy_mutex

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:18:34PM -0400, Vivien Didelot wrote: > Only reg_lock is necessary now and phy_mutex is dead. Remove it. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: rework EEPROM access

2016-07-20 Thread Andrew Lunn
| \ > MV88E6XXX_FLAG_G2_EEPROM_ADDR) > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 3/3] net: dsa: mv88e6xxx: kill last locked reg_read

2016-07-20 Thread Andrew Lunn
t Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements

2016-07-21 Thread Andrew Lunn
On Thu, Jul 21, 2016 at 02:43:56PM +0200, Grzegorz Jaszczyk wrote: Hi Grzegorz Some of these patches are missing a commit log entry. Please add at least one line. Andrew

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-21 Thread Andrew Lunn
On Thu, Jul 21, 2016 at 10:46:56AM -0400, Vivien Didelot wrote: > Florian Fainelli writes: > > > Le 20/07/2016 à 17:35, Andrew Lunn a écrit : > >> On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: > >>> This patch simply moves the legac

Re: [PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr()

2016-09-19 Thread Andrew Lunn
On Mon, Sep 19, 2016 at 03:28:00PM +0200, John Crispin wrote: > commit 83c0afaec7b730b ("net: dsa: Add new binding implementation") > has a duplicate invocation of the set_addr() operation callback. Remove one > of them. Upps. My error... > > Signed-off-by: John Cris

Re: [PATCH 0/4] net-next: dsa: set_addr should be optional

2016-09-19 Thread Andrew Lunn
On Mon, Sep 19, 2016 at 03:27:59PM +0200, John Crispin wrote: > The Marvell driver is the only one that actually sets the switches HW > address. All other drivers have an empty stub. fix this by making the > callback optional. Hi John Thanks for doing this, Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Andrew Lunn
Hi Vivien > + do { > + err = _mv88e6xxx_atu_getnext(chip, fid, &next); > + if (err) > + return err; > + > + if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED) > + break; > + > + if (ether_addr_equal(next.mac,

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Andrew Lunn
On Mon, Sep 19, 2016 at 08:29:40PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > Hi Vivien > > > >> + do { > >> + err = _mv88e6xxx_atu_getnext(chip, fid, &next); > >> + if (err) > &

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Andrew Lunn
y for the old port? > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

2016-09-20 Thread Andrew Lunn
On Tue, Sep 20, 2016 at 10:13:14PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-09-20 at 16:00 +0930, Joel Stanley wrote: > > On Aspeed SoC with a direct PHY connection (non-NSCI), we receive > > continual PHYSTS interrupts: > > > >  [   20.28] ftgmac100 1e66.ethernet eth0: [ISR] =

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-20 Thread Andrew Lunn
On Mon, Sep 19, 2016 at 09:07:16PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote: > >> An address can be loaded in the ATU with multiple ports, for instance > >> when

Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses

2016-06-20 Thread Andrew Lunn
rting the (indirect) > Multi-chip Addressing Mode, and a low-level API to access the registers > via SMI. > > Other accesses (like Ethernet management frames) may be added later. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn This series is now ready for merging. Thanks Andrew

  1   2   3   4   5   6   7   8   9   10   >