Re: [PATCH v3] ALSA: aoa: convert bus code to use dev_groups

2015-06-12 Thread Andreas Schwab
Quentin Lambert writes: > The dev_attrs field of struct bus_type is going away, sue dev_groups instead. s/sue/use/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

2015-06-18 Thread Andreas Schwab
we issuing read/write accesses to chip registers? Any name will do as long as the magic constant is not duplicated. It is more important to document the relation between two uses than to have a correct name (which can trivially be updated later). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG

Re: [GIT PULL] siginfo fix for v4.16-rc5

2018-04-03 Thread Andreas Schwab
ed ELF support for m68k-linux I wanted to follow the SVR4 ABI (which has 32-bit alignment), but there were too many UAPI structures (esp. struct stat) that would have become incompatible (it would have made it impossible to run ELF binaries on an a.out kernel or vice-versa), so I had to keep the histo

Re: PCI: Move OF-related PCI functions into PCI core

2018-06-07 Thread Andreas Schwab
OF_PCI is still referenced by drivers/pci/host/Kconfig. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] RISC-V: Handle R_RISCV_32 in modules

2018-06-07 Thread Andreas Schwab
With CONFIG_MODVERSIONS=y the R_RISCV_32 relocation is used by the __kcrctab section. Signed-off-by: Andreas Schwab --- arch/riscv/kernel/module.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c index 5dddba301d

Re: PCI: Move OF-related PCI functions into PCI core

2018-06-07 Thread Andreas Schwab
On Jun 07 2018, Bjorn Helgaas wrote: > On Thu, Jun 7, 2018 at 3:53 AM Andreas Schwab wrote: >> >> OF_PCI is still referenced by drivers/pci/host/Kconfig. > > Do you have a SHA1 for the file you're looking at? I'm lookig at 4.17. Andreas. -- Andreas Schwab, SU

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-12 Thread Andreas Schwab
On Mär 12 2019, Yash Shah wrote: > This patch series adds a PWM driver and DT documentation > for HiFive Unleashed board. The patches are mostly based on > Wesley's patch. Heartbeat trigger still doesn't work for me. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de

Re: [PATCH] arch: riscv: support kernel command line forcing when no DTB passed

2019-02-05 Thread Andreas Schwab
_init_dt_scan returns true if it found a DTB. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v11 0/2] PWM support for HiFive Unleashed

2019-03-26 Thread Andreas Schwab
On Mär 26 2019, Yash Shah wrote: > 'On Mon, Mar 25, 2019 at 9:24 PM Andreas Schwab wrote: >> >> >> I still don't see any improvement. FYI, this is the patch I use for the >> device tree: >> > > I am sharing you my test environment which has b

Re: [PATCH v11 0/2] PWM support for HiFive Unleashed

2019-03-27 Thread Andreas Schwab
? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v3 0/2] tty: serial: add DT bindings and serial driver for the SiFive FU540 UART

2019-04-11 Thread Andreas Schwab
On Apr 11 2019, Paul Walmsley wrote: > On Wed, 6 Mar 2019, Andreas Schwab wrote: > >> Trying to log in on the serial console causes the system to freeze. The >> last message is: >> >> [ 115.597858] sifive-serial 1001.serial: BRKINT/PARMRK flag not >&

Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

2021-02-10 Thread Andreas Schwab
. > > This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. > > Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy > reset") > Cc: sta...@vger.kernel.org > Signed-off-by: Palmer Dabbelt This fixes ethernet on the HiFive Unleashed with 5.10.12.

Re: [PATCH v2 0/3] fix macb phy probe failure if phy-reset is not handled

2021-02-04 Thread Andreas Schwab
b 1009.ethernet: Registered clk switch 'sifive-gemgxl-mgmt' [ 12.784559] macb 10090000.ethernet: GEM doesn't support hardware ptp. [ 12.791629] libphy: MACB_mii_bus: probed [ 12.919728] MACsec IEEE 802.1AE [ 12.984676] macb 1009.ethernet eth0: Cadence GEM rev 0x10070109 at 0x1009 irq 16 (70:b3:d5:92:f1:07) [ 14.030319] Microsemi VSC8541 SyncE 1009.ethernet-:00: phy_poll_reset failed: -110 [ 14.038986] macb 1009.ethernet eth0: Could not attach PHY (-110) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] arch: m68k: include: asm: Reconstruct the sentence in file sun3ints.h

2021-02-05 Thread Andreas Schwab
On Feb 05 2021, Bhaskar Chowdhury wrote: > -/* master list of VME vectors -- don't fuck with this */ > +/* master list of VME vectors -- don't do anything with this */ don't mess with this Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

Re: [PATCH] riscv: fix build warning of missing prototypes

2020-05-31 Thread Andreas Schwab
On Jun 01 2020, Zong Li wrote: > Add the missing header in file, it was losed in original implementation. s/losed/lost/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/4] exec: Change uselib(2) IS_SREG() failure to EACCES

2020-05-19 Thread Andreas Schwab
On Mai 18 2020, Eric W. Biederman wrote: > If it was only libc4 and libc5 that used the uselib system call then it > can probably be removed after enough time. Only libc4 used it, libc5 was already ELF. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB4

Re: [PATCH 1/4] exec: Change uselib(2) IS_SREG() failure to EACCES

2020-05-19 Thread Andreas Schwab
c/libc/libc_5.4.46.orig.tar.gz Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2 3/6] powerpc/32s: Only leave NX unset on segments used for modules

2020-08-20 Thread Andreas Schwab
X <3d20c08b> 3d40c086 9421ffe0 8129106c ---[ end trace 85a98cc836109871 ]--- Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

2020-08-18 Thread Andreas Schwab
> plat->phy_interface = device_get_phy_mode(&pdev->dev); > - if (plat->phy_interface < 0) > + if ((int)plat->phy_interface < 0) > return ERR_PTR(plat->phy_interface); I don't think the conversion to long when passed to ERR_

[PATCH] powerpc/vdso: fix clock_gettime_fallback for vdso32

2021-01-11 Thread Andreas Schwab
from the 32-bit vdso. Signed-off-by: Andreas Schwab --- arch/powerpc/include/asm/vdso/gettimeofday.h | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/include/asm/vdso/gettimeofday.h b/arch/powerpc/include/asm/vdso/gettimeofday.h index 81671aa365b3..a26c12df2c9a 100644

[PATCH] riscv: return -ENOSYS for syscall -1

2020-12-21 Thread Andreas Schwab
Properly return -ENOSYS for syscall -1 instead of leaving the return value uninitialized. This fixes the strace teststuite. Fixes: 5340627e3fe0 ("riscv: add support for SECCOMP and SECCOMP_FILTER") Signed-off-by: Andreas Schwab --- arch/riscv/kernel/entry.S | 9 + 1 file

Re: [PATCH] riscv: Fixed kernel test robot warning

2020-12-08 Thread Andreas Schwab
On Dez 09 2020, Souptick Joarder wrote: > On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: >> >> On Dez 09 2020, Souptick Joarder wrote: >> >> > Kernel test robot throws below warning - >> > >> >arch/riscv/kernel/asm-offsets.c:14:6: warn

Re: [PATCH] riscv: Fixed kernel test robot warning

2020-12-08 Thread Andreas Schwab
> > This patch should fixed it. Or rename it to main, like most other asm-offsets files. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: riscv+KASAN does not boot

2020-12-25 Thread Andreas Schwab
uot; Do you get more output with earlycon=sbi? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is NULL

2020-12-27 Thread Andreas Schwab
le(struct clk *clk) > { > unsigned long flags; > + if (!clk) > + return; That fails to return a value. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-24 Thread Andreas Schwab
Were you able to reproduce the problem? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-25 Thread Andreas Schwab
iscv64.raw.xz Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-19 Thread Andreas Schwab
On Mär 19 2021, Zong Li wrote: > Could you please point me out how to test the ethernet from your side? Please use <https://github.com/openSUSE/kernel-source/blob/stable/config/riscv64/default>. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5

Re: macb broken on HiFive Unleashed

2021-03-19 Thread Andreas Schwab
On Mär 19 2021, Yixun Lan wrote: > what's the exact root cause? and any solution? Try reverting the five commits starting with 732374a0b440d9a79c8412f318a25cd37ba6f4e2. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Andreas Schwab
~ >> mm/kfence/report.c:233:3: note: in expansion of macro 'pr_err' >>233 | pr_err("Invalid free of 0x%p (in kfence-#%zd):\n", (void >> *)address, >>| ^~ >> >> Christophe > > No this is not expected. Is 'signed size_t' != 'long

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-16 Thread Andreas Schwab
40. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-29 Thread Andreas Schwab
to be enabled too late. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-26 Thread Andreas Schwab
hat's exactly the issue. The process is stuck in D. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE

2021-03-26 Thread Andreas Schwab
OMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fi

Re: [PATCH 2/4] exec: remove compat_do_execve

2021-03-26 Thread Andreas Schwab
On Mär 26 2021, Christoph Hellwig wrote: > Just call compat_do_execve instead. ITYM compat_do_execveat here. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

2021-03-28 Thread Andreas Schwab
That doesn't look correct. It reverses the condition without reversing the result, which means the result is probably the opposite than intended. The same expression occurs two more times in this file. Do those need to be changed as well? Andreas. -- Andreas Schwab, sch...@linux-m68k.

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-04-12 Thread Andreas Schwab
NFIG_PM, and the patch > 732374a0b440d9a79c8412f318a25cd37ba6f4e2 added the enable/disable > callback functions, so the gemgxlpll PLL, I have no idea why power > management disable it, I would keep trace it. Does that mean that CONFIG_PM also affects the FU740? Andreas. -- Andreas Schwab, sch...@linux-m68k

Re: macb broken on HiFive Unleashed

2021-03-17 Thread Andreas Schwab
It turned out to be a broken clock driver. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [Y2038][time namespaces] Question regarding CLOCK_REALTIME support plans in Linux time namespaces

2020-11-26 Thread Andreas Schwab
testing; we would test what we ship. seccomp and ptrace does not work with qemu linux-user. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: macb broken on HiFive Unleashed

2021-03-13 Thread Andreas Schwab
On Mär 13 2021, Emil Renner Berthing wrote: > As you can see I haven't updated OpenSBI or u-boot in a while Does it also work if you use the u-boot SPL instead of FSBL? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A

Re: macb broken on HiFive Unleashed

2021-03-10 Thread Andreas Schwab
assing zero to 'PTR_ERR' > 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method > e4e143e26ce8 net: macb: add support for high speed interface Unfortunately, that didn't help. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

macb broken on HiFive Unleashed

2021-03-08 Thread Andreas Schwab
12.753119] macb 1009.ethernet: GEM doesn't support hardware ptp. [ 12.760178] libphy: MACB_mii_bus: probed [ 12.881792] MACsec IEEE 802.1AE [ 12.944426] macb 1009.ethernet eth0: Cadence GEM rev 0x10070109 at 0x1009 irq 16 (70:b3:d5:92:f1:07) Andreas. -- Andreas Schwa

Re: [PATCH] sh: boards: Fix the cacography in irq.c

2021-01-01 Thread Andreas Schwab
On Nov 19 2020, Tang Bin wrote: > The world 'swtich' is wrong, so fix it. s/world/word/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: 3.13-rc1: eth0 hw csum failure on powerpc

2013-11-30 Thread Andreas Schwab
/3.13-rc1/ > > Oh, this has already been reported earlier this week: > > https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-November/113584.html No solution yet, though, 3.13-rc2 is still broken. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53

Re: [patch 1/6] hardirq: Make hardirq bits generic

2013-11-11 Thread Andreas Schwab
filters out the I1 bit, which makes irq level 4 and level 6 look the same (all MFP interrupts are at level 6). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH/RFC] m68k/amiga: Fix specifying multiple debug= parameters

2013-11-25 Thread Andreas Schwab
b. Skip console registration in case of a non-NULL .write() method >> => only the last debug console will be used, >> 3. Atari has a similar issue, with even more (4) debug consoles. 2b is backward compatible. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG

Re: ls -l /proc/1/exe -> Permission denied

2014-07-19 Thread Andreas Schwab
is considered private. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: ls -l /proc/1/exe -> Permission denied

2014-07-20 Thread Andreas Schwab
Joakim Tjernlund writes: > Andreas Schwab wrote on 2014/07/19 22:21:59: >> >> Joakim Tjernlund writes: >> >> > Trying to real /proc//exe I noticed I could not read links not >> > belonging to my user such as: >> > jocke > ls -l /proc/1/

Re: ls -l /proc/1/exe -> Permission denied

2014-07-20 Thread Andreas Schwab
Richard Weinberger writes: > On Sun, Jul 20, 2014 at 12:55 PM, Andreas Schwab > wrote: >> Joakim Tjernlund writes: >> >>> Andreas Schwab wrote on 2014/07/19 22:21:59: >>>> >>>> Joakim Tjernlund writes: >>>> >&g

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-20 Thread Andreas Schwab
Theodore Ts'o writes: > ERRORS > EINVAL The buflen value was invalid. Also on unknown flags? Without that it would be impossible to probe for implemented flags. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D

Re: [PATCH 1/5] m68k: Disable/restore interrupts in hwreg_present()/hwreg_write()

2014-09-28 Thread Andreas Schwab
Geert Uytterhoeven writes: > While most callers run early, before interrupt are disabled, or interrupts are enabled Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And

Re: [PATCH 39/48] powerpc: Replace __get_cpu_var uses

2014-02-15 Thread Andreas Schwab
e to find one that isn't a steaming pile ... :-) Gnus. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] Fixes q40_irq_startup to return -ENXIO

2014-06-30 Thread Andreas Schwab
case 9: > case 11: case 12: case 13: > printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq); > - /* FIXME return -ENXIO; */ > + return -ENXIO; There must be more to it, given the FIXME. Andreas. -- Andreas Schwab, sch.

[PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

2014-06-30 Thread Andreas Schwab
o] Error 1 Makefile:893: recipe for target 'arch/arm64/crypto' failed make: *** [arch/arm64/crypto] Error 2 The $(obj)/aes-glue-%.o rule only creates $(obj)/.tmp_aes-glue-ce.o, it should use if_changed_rule instead of if_changed_dep. Signed-off-by: Andreas Schwab --- arch/arm64/crypt

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

2014-06-30 Thread Andreas Schwab
Ard Biesheuvel writes: > Out of curiosity, how did you trigger this failure? I have build this > code numerous times (and so have others) and I have never seen this > failure. Did you ever start with a clean tree? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fi

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

2014-07-24 Thread Andreas Schwab
Ard Biesheuvel writes: > On 30 June 2014 15:56, Andreas Schwab wrote: >> Ard Biesheuvel writes: >> >>> Out of curiosity, how did you trigger this failure? I have build this >>> code numerous times (and so have others) and I have never seen this >>>

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

2014-07-24 Thread Andreas Schwab
You are not using CONFIG_MODVERSIONS. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

2014-07-24 Thread Andreas Schwab
Ard Biesheuvel writes: > On 24 July 2014 15:26, Andreas Schwab wrote: >> You are not using CONFIG_MODVERSIONS. >> > > I am No, you aren't, since you say that your .cmd contains a command to create aes-glue-ce.o, which with CONFIG_MODVERSIONS it doesn't. Andreas.

Re: Support for netconsole as default tty/console?

2014-03-29 Thread Andreas Schwab
is there an independent > solution to this problem? It should not be hard to add a tty driver to netconsole, there are many examples to borrow from. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something

Re: Support for netconsole as default tty/console?

2014-03-30 Thread Andreas Schwab
Struan Bartlett writes: > Thank you. I've begun investigating the sources in drivers/tty. Am I > correct in thinking that this only needs a tty driver, and not also a > serial driver? See arch/m68k/emu/nfcon.c for a somewhat minimal example (only output). Andreas. -- Andre

Re: Support for netconsole as default tty/console?

2014-03-31 Thread Andreas Schwab
s typically not avaiable. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: Support for netconsole as default tty/console?

2014-03-31 Thread Andreas Schwab
One Thousand Gnomes writes: > It's however implemented and present. The rest is between you and the > relevant Kconfig maintainer. I'm sure you count as an expert ;-) Indeed. http://lists.opensuse.org/opensuse-kernel/2014-03/msg00071.html Andreas. -- Andreas Schwab

Re: [PATCH] powerpc: fix typo 'CONFIG_PMAC'

2014-05-21 Thread Andreas Schwab
ent: Reduce latency of calling > perf_event_do_pending") > Signed-off-by: Paul Bolle > --- > Untested. Needs testing on 32 bit powermac, I guess. > > This typo was introduced in v2.6.36. No one noticed because very few > people still use 32 bit powermacs? How does that bug manifest itself?

Re: [PATCH] powerpc: fix typo 'CONFIG_PMAC'

2014-05-22 Thread Andreas Schwab
Paul Bolle writes: > Do you want to know how to test this patch on a 32 bit powermac? Ie, see > if it has any effect, and whether that effect improves things or make > things worse. Yes. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1

Re: [RFC 01/32] fs: introduce new 'struct inode_time'

2014-05-31 Thread Andreas Schwab
numbers there, but storing a large > positive number will become negative on read out, won't it? Only if the int bitfield is signed. Bitfields are weird, aren't they? :-) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B

Re: [RFC 03/32] fs: introduce sys_utimens64at

2014-05-31 Thread Andreas Schwab
Arnd Bergmann writes: > +asmlinkage long sys_utimens64at(int dfd, const char __user *filename, All existing syscall names have the 64 suffix last, including the *at variants, so sys_utimensat64 would be more in line. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerpr

Re: [RFC 01/32] fs: introduce new 'struct inode_time'

2014-05-31 Thread Andreas Schwab
Geert Uytterhoeven writes: > "int" is signed, right? Or do you mean a bitfield needs an explicit "signed" > keyword to be signed? Yes, see 6.7.2#5. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 2

Re: [PATCH] tell gcc optimizer to never introduce new data races

2014-06-16 Thread Andreas Schwab
Dan Carpenter writes: > Adding "--param allow-store-data-races=0" to the GCC options for the > kernel breaks C=1 because Sparse isn't expecting a GCC option with that > format. Please try --param=allow-store-data-races=0 instead. Andreas. -- Andreas Schwab, SUSE Labs

[PATCH] arm/xen: fix wrong conflict resolution of xen merge

2014-08-12 Thread Andreas Schwab
Remove duplicate definition of arch_gnttab_init. Signed-off-by: Andreas Schwab --- arch/arm/xen/grant-table.c | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm/xen/grant-table.c b/arch/arm/xen/grant-table.c index 2c4041c..e437918 100644 --- a/arch/arm/xen/grant-table.c +++ b/arch

Re: [PATCH v4 1/9] PM / Domains: Change prototype for the ->attach_dev() callback

2014-11-03 Thread Andreas Schwab
Geert Uytterhoeven writes: > From: Ulf Hansson > > Convert the prototype to return and int. This is just an initial step, s/and/an/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for someth

Re: [patch V4] lib: GCD: Use binary GCD algorithm instead of Euclidean

2016-05-07 Thread Andreas Schwab
"George Spelvin" writes: > Your benchmark code doesn't have to have a separate code path if > __x86_64__; rdtsc works on 32-bit code just as well. Take a look at the CC: list. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B

Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64

2016-05-17 Thread Andreas Schwab
t64. And you probably want to alias statfs and statfs64 as well, ie. fs{blk,fil}cnt_t. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 08/10] m68k: Add

2016-05-25 Thread Andreas Schwab
"George Spelvin" writes: > Can you recmmend a better way to comment this? My nose is so deep > in the code it's hard for me to judge. It's probably best to express the effect of the insns in plain C. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerp

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-11 Thread Andreas Schwab
Yury Norov writes: > +#define sys_clock_gettime compat_sys_clock_gettime > +#define sys_clock_settime compat_sys_clock_settime You also need to redirect sys_clock_nanosleep. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-11 Thread Andreas Schwab
Arnd Bergmann writes: > On Wednesday 11 November 2015 18:54:00 Andreas Schwab wrote: >> Yury Norov writes: >> >> > +#define sys_clock_gettime compat_sys_clock_gettime >> > +#define sys_clock_settime compat_sys_clock_settime >> >>

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-12 Thread Andreas Schwab
off_t+off64_t (with split off64_t syscall arguments) or pure 64bit off_t architectures. Since ilp32 now (mostly) has 32bit off_t, but 64bit off_t-like syscalls neither of them fit. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 8

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-12 Thread Andreas Schwab
Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-12 Thread Andreas Schwab
Arnd Bergmann writes: > On Thursday 12 November 2015 10:44:55 Andreas Schwab wrote: >> Arnd Bergmann writes: >> >> > What do you mean with 32-bit off_t? >> >> An ABI with 32-bit off_t, ie. all currently implemented 32-bit ABIs. >> >> > Do yo

Re: [PATCH v6 13/20] arm64: ilp32: share aarch32 syscall wrappers to ilp32

2015-12-17 Thread Andreas Schwab
Yury Norov writes: > From: Jan Dakinevich > > statfs64, fstat64 and mmap_pgoff has wrappers that needed both by aarch32 and Typo: s/fstat64/fstatfs64/ Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 &qu

Re: [PATCH v6 15/19] arm64: ilp32: force IPC_64 in msgctl, shmctl, semctl

2015-11-18 Thread Andreas Schwab
> > I wonder if this would be any simpler by changing compat_ipc_parse_version() This cries for a generic solution. Other archs migrating to separate ipc syscalls will want to avoid the whole IPC_64 business for them, even if they need to retain [compat_]ipc_parse_version for sys_ipc compatibil

Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-19 Thread Andreas Schwab
ass loff_t in a single register? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-12-01 Thread Andreas Schwab
Yury Norov writes: > There's a tricky bug with signal stack, that Andreas also discovered. That was only a confusion about the compat state of sys_rt_sigaction. It just requires making sure glibc uses the correct (64bit layout) struct kernel_sigaction. Andreas. -- Andreas Schwab, S

Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-12-01 Thread Andreas Schwab
Arnd Bergmann writes: > On Tuesday 01 December 2015 10:20:59 Andreas Schwab wrote: >> Yury Norov writes: >> >> > There's a tricky bug with signal stack, that Andreas also discovered. >> >> That was only a confusion about the compat state of sys_rt_s

Re: [PATCH v6 17/21] arm64: ilp32: introduce ilp32-specific handlers for sigframe

2016-02-29 Thread Andreas Schwab
return(struct pt_regs *regs) This function must be defined to return long, lest you truncate the return value of the interrupted syscall. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64

2016-02-29 Thread Andreas Schwab
n little endian mode). You need to add the attached file as sysdeps/unix/sysv/linux/aarch64/bits/stat.h, then you can use the user-space struct stat64 to communicate with the *stat64 syscalls, and __kernel_stat64 is not needed any more. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fin

Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64

2016-02-25 Thread Andreas Schwab
/ilp32/getdents.c so that __getdents64 comes from sysdeps/unix/sysv/linux/generic/getdents64.c. sysdeps/unix/sysv/linux/aarch64/ilp32/*xstat*.c should not set errno, INLINE_SYSCALL already does that, and returns -1 on error. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 019

Re: [PATCH selftest fails!] m68k: Wire up execveat

2014-12-21 Thread Andreas Schwab
s not found, the exit status shall be 127. If the command name is found, but it is not an executable utility, the exit status shall be 126. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something

Re: [PATCH] arm64: Enable CONFIG_COMPAT also for 64k page size

2015-03-11 Thread Andreas Schwab
Alexander Graf writes: > Unfortunately however, the 32bit glibc has a bogus mmap() implementation > that hard codes 4k page size. Which is correct (it's not a page size). Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D

Re: [PATCH] arm64: Enable CONFIG_COMPAT also for 64k page size

2015-03-11 Thread Andreas Schwab
>From 29457829093014f39c7d1c926c9b86b6cb5709db Mon Sep 17 00:00:00 2001 From: Andreas Schwab Date: Mon, 9 Mar 2015 17:27:36 +0100 Subject: [PATCH] arm64: fix implementation of mmap2 compat syscall The arm mmap2 syscall takes the offset in units of 4K, thus with 64K pages the offset needs to

Re: [PATCH] arm64: Enable CONFIG_COMPAT also for 64k page size

2015-03-11 Thread Andreas Schwab
Arnd Bergmann writes: > On Wednesday 11 March 2015 14:35:39 Andreas Schwab wrote: >> +#if PAGE_SIZE > 12 >> +asmlinkage long compat_sys_mmap2_wrapper(void); >> +#else >> +#define compat_sys_mmap2_wrapper sys_mmap_pgoff >> +#endif >> > > PAG

Re: [PATCH] arm64: Enable CONFIG_COMPAT also for 64k page size

2015-03-11 Thread Andreas Schwab
Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

[PATCH] arm64: fix implementation of mmap2 compat syscall

2015-03-12 Thread Andreas Schwab
The arm mmap2 syscall takes the offset in units of 4K, thus with 64K pages the offset needs to be scaled to units of pages. Signed-off-by: Andreas Schwab --- arch/arm64/include/asm/unistd32.h | 2 +- arch/arm64/kernel/entry32.S | 18 ++ arch/arm64/kernel/sys32.c

Re: [RFC PATCH v6 00/17] ILP32 for ARM64

2015-11-05 Thread Andreas Schwab
Yury Norov writes: > v6: > - time_t, __kenel_off_t and other types turned to be 32-bit >for compatibility reasons (after v5 discussion); Are the updated glibc patches available somewhere? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8

Re: [RFC2 PATCH v6 00/19] ILP32 for ARM64

2015-11-23 Thread Andreas Schwab
broken with this incarnation. I'm seeing x30 == 0 on entry to the signal handler. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from

Re: Wiring up direct socket calls on x86_32 Linux?

2015-06-30 Thread Andreas Schwab
Andy Lutomirski writes: > Glibc people: If Linux wired up the syscalls, would glibc use them? Not automatically. It needs to be compatible with the configured minimum kernel version, so runtime probing would needed to be implemented. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG

Re: [RFC PATCH v6 00/17] ILP32 for ARM64

2015-11-09 Thread Andreas Schwab
Yury Norov writes: > This is what I run: > https://github.com/norov/glibc/tree/thunderx-ilp32-32time_toff_t Thanks, rebootstrapping openSUSE Factory now. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 &q

Re: [RFC PATCH v6 00/17] ILP32 for ARM64

2015-11-09 Thread Andreas Schwab
sysdep.h:41:32: error: ‘__NR_fcntl64’ undeclared (first use in this function) Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from thi

Re: [RFC PATCH v6 00/17] ILP32 for ARM64

2015-11-09 Thread Andreas Schwab
Arnd Bergmann writes: > On Monday 09 November 2015 14:23:59 Andreas Schwab wrote: >> Yury Norov writes: >> >> > This is what I run: >> > https://github.com/norov/glibc/tree/thunderx-ilp32-32time_toff_t >> >> That doesn't work for me: >&g

Re: [RFC PATCH v6 00/17] ILP32 for ARM64

2015-11-11 Thread Andreas Schwab
"Zhangjian (Bamvor)" writes: > Hi, Andreas > > On 2015/11/9 18:01, Andreas Schwab wrote: >> Yury Norov writes: >> >>> This is what I run: >>> https://github.com/norov/glibc/tree/thunderx-ilp32-32time_toff_t >> >> Thanks, reboot

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-16 Thread Andreas Schwab
Arnd Bergmann writes: > ino_t seems to be the only other type in 'struct stat' that depends > on _FILE_OFFSET_BITS in glibc. There is also blkcnt_t, and then there is fsblkcnt_t, fsfilcnt_t and fsword_t in struct statfs. Andreas. -- Andreas Schwab, SUSE Labs, sch...

<    1   2   3   4   5   6   >