[PATCH] Pass nr_wake2 to futex_wake_op

2007-07-07 Thread Andreas Schwab
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter. The only user of this operation in glibc is always passing 1, so this bug had no consequences so far. Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> ---

Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO

2007-07-11 Thread Andreas Schwab
+= -g > +AFLAGS += $(call as-option, -gdwarf) The option is officially called -gdwarf-2, and -gdwarf2 is an alias for backward compatibility. But -gdwarf is ambigous and will error out. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, M

Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO

2007-07-11 Thread Andreas Schwab
S is actually passed to $(CC), not $(AS), and -gdwarf works there > (it's an unambiguous prefix of -gdwarf-2). Oh yes, you're right, sorry for the noise. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP k

Re: [PATCH] add a trivial patch style checker

2007-05-27 Thread Andreas Schwab
Andy Whitcroft <[EMAIL PROTECTED]> writes: > @@ -223,7 +236,7 @@ pref("mailnews.display.disable_format_flowed_support", > true); > > > > -7) E-mail size. > +8) E-mail size. > > When sending patches to Linus, always follow step #6. That's

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Andreas Schwab
wn scope. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send

Re: *at syscalls for xattrs?

2007-07-16 Thread Andreas Schwab
Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > This should work: > >fchdir(fd1); >open("file1", O_RDWR | O_CREAT); >fchdir(fd2); >open("file2", O_RDWR | O_CREAT); This is not thread-safe. Andreas. -- Andreas Schwab, SuSE Labs

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > If the code is not exported to userspace (and thus not subject to different > compilers), I think the preferred form is plain `attribute'. That does not exist without underscores. Andreas. -- Andreas Schwab, SuSE Labs, [EMAI

[PATCH] Pass nr_wake2 to futex_wake_op

2007-07-17 Thread Andreas Schwab
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter. The only user of this operation in glibc is always passing 1, so this bug had no consequences so far. Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> ---

Re: sysfs root link count broken in 2.6.22-git5

2007-07-18 Thread Andreas Schwab
es /proc/mounts for something, I can't remember >> what it is right now though, sorry. > > Maybe getmntent(3)? Sure I could use this, but how expensive compared > to a single stat(2). How about comparing the device numbers of /sys and its parent? If they are different then /sys i

Re: Problems (a bug?) with UINT_MAX from kernel.h

2007-06-05 Thread Andreas Schwab
range. It does not know anything about types. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different.&quo

Re: [Patch 04/18] include/linux/logfs.h

2007-06-06 Thread Andreas Schwab
t; 'nopadding' instead of 'packed', then there's no need to emit code to > handle unaligned loads. You can add aligned(N) to increase the alignment again. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg,

Re: how to determine if the noexec stack is defined by an application

2007-06-29 Thread Andreas Schwab
ys "RW" like here, it'll have non-executable stack. If it says > "RWX" or if this line is absent entirely, the stack will be executable. The last part is not true. Some architectures (especially newer ones) default to non-exec stack. The absense of a GNU_STACK header rep

Re: how to determine if the noexec stack is defined by an application

2007-06-29 Thread Andreas Schwab
Arjan van de Ven <[EMAIL PROTECTED]> writes: > (all others default to executable stack) Except ia64. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: [i386] Questions regarding provisional page tables initialization

2007-07-01 Thread Andreas Schwab
y the pde_offset is PAGE_OFFSET >> 20 instead of PAGE_OFFSET >> 22 ? > * 22 to right shift the whole page_shift (12) and pgdir_shift (10) bits. 4 is the element size. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnber

Re: [i386] Questions regarding provisional page tables initialization

2007-07-02 Thread Andreas Schwab
pg0 plus 3 flag bits. Since a page address is always page aligned, the low bits are reused for flags. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > Is there anything we can do about this? Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint =

Re: [PATCH 06/14] kbuild: introduce __init_refok/__initdata_refok to supress section mismatch warnings

2007-05-18 Thread Andreas Schwab
Sam Ravnborg <[EMAIL PROTECTED]> writes: > + * The follwoing markers are used for the cases where the reference to s/follwoing/following/ Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint =

Re: it seems at XFS bug?!

2007-05-20 Thread Andreas Schwab
e NBSP. But __only__ in ISO-8859. It is an invalid > UTF-8 sequence (which is why you may not even "see" the nbsp :-) Actually, in a utf-8 environment you see it much better. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürn

Re: it seems at XFS bug?!

2007-05-20 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > On May 20 2007 11:14, Andreas Schwab wrote: >>Jan Engelhardt <[EMAIL PROTECTED]> writes: >>> On May 19 2007 22:24, Willy Tarreau wrote: >>>>On Sat, May 19, 2007 at 09:50:43PM +0200, oliver pinter wrote: >>

Re: bug in 2.6.22-rc2: loop mount limited to one single iso image

2007-05-20 Thread Andreas Schwab
t; loop* nodes in /lib/udev/devices/, which will be >> copied to /dev/ early on every bootup. >> > > Won't these be removed after "losetup -d"? No, only when you unload the loop module (and then only those that were ever used). Andreas. -- Andreas Schwab, SuSE Labs,

Re: [PATCH] m68k: Enable arbitary speed tty support

2007-05-23 Thread Andreas Schwab
007-04-30 > 10:48:14.0 +0100 > +++ linux-2.6.22-rc1-mm1/include/asm-arm/termbits.h 2007-05-23 > 20:23:25.0 +0100 > @@ -15,6 +15,17 @@ > cc_t c_cc[NCCS];/* control characters */ > }; > > +struct termios_2 { s/_// Andreas. -- A

Re: [PATCH] tty: Turn on arbitary baud rate ioctls for i386 platform

2007-03-08 Thread Andreas Schwab
Arjan van de Ven <[EMAIL PROTECTED]> writes: > should this then really be in include/asm/* ? If everyone needs the same > change I'd think it should go into include/linux/* somewhere. How about asm-generic/ioctls.h? is one of the few ABI headers for glibc. Andreas. -- And

Re: [PATCH] Use more gcc extensions in the Linux headers

2007-03-10 Thread Andreas Schwab
n array. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send

Re: /sys/devices/system/cpu/cpuX/online are missing

2007-03-12 Thread Andreas Schwab
CONFIG_HOTPLUG_CPU enabled. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsu

Re: /sys/devices/system/cpu/cpuX/online are missing

2007-03-13 Thread Andreas Schwab
Heiko Carstens <[EMAIL PROTECTED]> writes: > On Tue, Mar 13, 2007 at 01:39:25AM +0100, Andreas Schwab wrote: >> Giuliano Pochini <[EMAIL PROTECTED]> writes: >> >> > I had a look at arch/powerpc/kernel/smp.c but I'm not familiar at all with >> >

Re: x86_64 system lockup from userspace using setitimer()

2007-03-13 Thread Andreas Schwab
nly x64_64 > seems affected. I can also reproduce it on ia64 with 2.6.20. 2.6.16.42 is ok. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5

Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings

2007-04-15 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > LOW_PAGES = (0x1ULL - __PAGE_OFFSET) >> PAGE_SHIT_asm The assembler does not now anything about ULL. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg,

Re: [PATCH] general: convert "kernel" subdirectory to UTF-8

2007-04-17 Thread Andreas Schwab
"John Anthony Kazos Jr." <[EMAIL PROTECTED]> writes: > I can't get my mail client to send in ISO-8859-1 instead of UTF-8, so the Actually your mail is encoded in iso-8859-15. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeld

Re: Stupid GIT question...

2007-04-18 Thread Andreas Schwab
[EMAIL PROTECTED] writes: > What's the command to get a diff of "what I would merge if I said 'git pull'?" $ git fetch $ git diff master origin Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg,

Re: Wrong free clusters count on FAT32

2007-04-22 Thread Andreas Schwab
anning disk. > + > utf8= -- UTF-8 is the filesystem safe version of Unicode that >is used by the console. It can be enabled for the >filesystem with this option. If 'uni_xlate' gets set, Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTE

Re: Long file names in VFAT broken with iocharset=utf8

2007-05-07 Thread Andreas Schwab
ral repository for this configuration item? A hard- > coded value of 256 somewhere inside the kernel smells like a bug. There is PATH_MAX and there is NAME_MAX, and only the latter (which is 260 for vfat) matters here. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products Gm

Re: Why is /dev on a different filesystem ? [Kernel 2.6.20.3]

2007-03-21 Thread Andreas Schwab
ts, apparently when /dev was mounted /etc/mtab wasn't updated appropriately. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for som

sata-vsc broken on SGI Prism

2007-03-24 Thread Andreas Schwab
ommit 7cbaa86b937b0b1fab95c159989f6a3c00bbcf78 Author: Dan Wolstenholme <[EMAIL PROTECTED]> Date: Tue Jan 9 05:59:21 2007 -0500 [libata] sata_vsc: support PCI MSI Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products Gm

Re: sata-vsc broken on SGI Prism

2007-03-25 Thread Andreas Schwab
Andrew Morton <[EMAIL PROTECTED]> writes: > On Sat, 24 Mar 2007 10:17:24 +0100 Andreas Schwab <[EMAIL PROTECTED]> wrote: > >> I'm getting this panic when loading sata-vsc on a SGI Prism: > > With what kernel? Linus' latest at this point in time. Andreas

Re: sata-vsc broken on SGI Prism

2007-03-26 Thread Andreas Schwab
Andrew Morton <[EMAIL PROTECTED]> writes: > On Sat, 24 Mar 2007 10:17:24 +0100 Andreas Schwab <[EMAIL PROTECTED]> wrote: > >> I'm getting this panic when loading sata-vsc on a SGI Prism: > > With what kernel? It's still the same with 2.6.21-rc5. >>

Re: If not readdir() then what?

2007-04-09 Thread Andreas Schwab
at this is a BUG in GNU coreutils that should be fixed... > > I heard it and accepted that claim without checking it. There is not a single call to telldir/seekdir in the coreutils source. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-25 Thread Andreas Schwab
"linux-os (Dick Johnson)" <[EMAIL PROTECTED]> writes: > I think this works, regardless of the length of the integers: > > #define abs(x) (((x)<0)?-(x):(x)) But it evaluates its argument more than once. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECT

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-25 Thread Andreas Schwab
"linux-os (Dick Johnson)" <[EMAIL PROTECTED]> writes: > The original query was for a macro. A macro that does not evaluate its argument more than once. If you want it to match the behaviour as defined by the C standard then it is not allowed to do so. Andreas. -- Andrea

Re: return negative number for unsigned long function in kernel

2007-03-06 Thread Andreas Schwab
tly passed to user space (it's the guts of the mmap syscall). The glibc wrapper transforms it appropriately so that errno is set and -1 is returned if there is an error. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Ger

Re: updated list of "dead" Makefile CONFIG_ variables

2007-03-31 Thread Andreas Schwab
ot/simple/Makefile:# loaded at. The optimal setting for > entrypoint-$(CONFIG_MACHINE) is the link > ./arch/ppc/boot/simple/Makefile:# misc-$(CONFIG_MACHINE) variable. That looks like a meta variable. It's only a comment anyway. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Li

[PATCH] Fix error handling in HDIO_GETGEO compat wrapper

2007-04-30 Thread Andreas Schwab
Don't clobber error from sys_ioctl in HDIO_GETGEO compat wrapper. Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> --- fs/compat_ioctl.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- linux-2.6.21.orig/fs/compat_ioctl.c 2007-04-26 13:40:52.0 +0200 +++ linu

Re: [PATCH 18/19] arm64:ilp32: add vdso-ilp32 and use for signal return

2016-06-20 Thread Andreas Schwab
struct vm_special_mapping* vdso_spec) > { > int i; > + unsigned long vdso_pages; > + struct page **vdso_pagelist; > > - if (memcmp(&vdso_start, "\177ELF", 4)) { > + if (memcmp(vdso_start, "\177ELF", 4)) { ... because forget

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

2016-06-20 Thread Andreas Schwab
is makes a real difference, ie. where the compiler erroneously reused a value due to the missing barrier. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH 18/27] [AARCH64] Add kernel_sigaction.h for AARCH64 ILP32

2016-06-21 Thread Andreas Schwab
Yury Norov writes: > In ILP32, the sigaction struct is the same as AARCH64 Isn't sys_ilp32.c using the compat calls for sigaction? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for somethi

Re: [PATCH 10/27] [AARCH64] Detect ILP32 in configure scripts.

2016-06-21 Thread Andreas Schwab
then > +libdir='${exec_prefix}/libilp32'; > +# Locale data can be shared between 32-bit and 64-bit libraries. > +libc_cv_localedir='${exec_prefix}/lib/locale' You need to regenerate this file to pick up recent changes in LIBC_SLIBDIR_RTLDDIR. Andreas. -- And

Re: [PATCH 06/27] [AARCH64] Use PTR_REG/PTR_SIZE/PTR_SIZE_LOG in dl-tlsesc.S

2016-06-21 Thread Andreas Schwab
e_rela_fixup ensuring that the load > from [x0,#8] here happens after the initialization of td->arg. */ > ldarxzr, [x0] Likewise. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 24/27] Add support for AT_ARM64_MIDR.

2016-06-21 Thread Andreas Schwab
What does that have to do with ILP32? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-21 Thread Andreas Schwab
__align; > + long long int __align; > } sem_t; Should __SIZEOF_SEM_T be reduced for ILP32? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 23/27] [AARCH64] delouse input arguments in system functions

2016-06-21 Thread Andreas Schwab
the initialization of td->arg. */ > ldarxzr, [x0] > + DELOUSE(0) That needs to be moved before the previous insn, doesn't it? Also, again _dl_tlsdesc_return_lazy is missing. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1

Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32

2016-06-21 Thread Andreas Schwab
\ > __typeof (__vdso_##name) vdsop = __vdso_##name;\ > PTR_DEMANGLE (vdsop); \ That part should have no effect now that __SYSCALL_SLONG_TYPE remains to be long. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.

Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.

2016-06-21 Thread Andreas Schwab
ame, k->d_name, name_len); > + > + u = (char *) u + u->d_reclen; > + k = nk; > + } > + > + return (size_t) u - (size_t) buf; > +} > + > +ssize_t > +__getdents (int fd, char *buf, size_t nbytes) > +{ > + > + struct kernel_dirent64 *k; Unused variable. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 15/27] [AARCH64] Add support to ldconfig for ILP32 and libilp32

2016-06-21 Thread Andreas Schwab
puts (",AArch64", stdout); >break; > +case FLAG_AARCH64_LIB32: > + fputs (",ILP32", stdout); > /* Uses the ARM soft-float ABI. */ Missing break. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 17

Re: [PATCH 22/27] [AARCH64] ILP32: support stat syscall family

2016-06-21 Thread Andreas Schwab
#include > + > +/* Get information about the file FD in BUF. */ > + > +int > +___fxstat64 (int vers, int fd, struct stat64 *buf) > +{ > + int result; > + result = INLINE_SYSCALL (fstat64, 2, fd, buf); > + if (!result) { > + conv_timespec(&buf->st_atim,

Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.

2016-06-21 Thread Andreas Schwab
> + ldr PTR_REG (T), [x##T, #:got_lo12:EXPR]; \ > + OP x##R, [x##T]; I think this needs to be PTR_REG(x). Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed always via 64bit values.

2016-06-21 Thread Andreas Schwab
\ > + _sys_result = (unsigned long long) -1; \ > } \ > (long) _sys_result; }) The cast should be (long long). Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key

Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.

2016-06-21 Thread Andreas Schwab
Andreas Schwab writes: >> +/* Load or store to/from a got-relative EXPR into/from R, using T. >> + Note R and T are register numbers and not register names. */ >> +#define LDST_GLOBAL(OP, R, T, EXPR)\ >> +

Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat)

2016-06-21 Thread Andreas Schwab
pat_thread(task_thread_info(tsk)) ? \ > is_compat_thread takes "struct thread_info *thread" while TASK_SIZE_OF takes > "struct task_struct *tsk"tsk. If that doesn't throw an error does that mean that TASK_SIZE_OF is unused? Andreas. -- Andreas Schwab, SUSE Labs, sch...@su

Re: [PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed always via 64bit values.

2016-06-21 Thread Andreas Schwab
"Zhangjian (Bamvor)" writes: > Hi, > > On 2016/6/21 15:56, Andreas Schwab wrote: >> Yury Norov writes: >> >>> diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h >>> b/sysdeps/unix/sysv/linux/aarch64/sysdep.h >>> index 1ffabc2

Re: Build regressions/improvements in v4.8-rc1

2016-08-08 Thread Andreas Schwab
On Mo, Aug 08 2016, Rich Felker wrote: > Users should leave builtin-DTB off, but allyesconfig turns it on. Perhaps you could inverse the meaning of the config so that y means builtin-DTB off? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1

Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ

2015-10-06 Thread Andreas Schwab
e python3 testsuite wants to put two signal frames in a SIGSTKSZ stack. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send

Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ

2015-10-06 Thread Andreas Schwab
Dave Martin writes: > On Tue, Oct 06, 2015 at 12:59:45PM +0200, Andreas Schwab wrote: >> Arnd Bergmann writes: >> >> > I think it makes sense to stick with the traditional definition >> > of MINSIGSTKSZ == "the minimum amount that you will always need,

Re: [PATCH 5/5] RISC-V: Use fixed width integer types for 32-bit compatible

2018-06-21 Thread Andreas Schwab
pr_err("%s: value %016" PRIxX "out of range for 32-bit field\n", >> me->name, v); >> return -EINVAL; > > But in general Linux uXX and sXX values are always the same underlying > fundamental C type. What is the mismat

Re: [PATCH] riscv: Drop setup_initrd

2018-08-28 Thread Andreas Schwab
d initrd_end are always overwritten, > and -initrd from the qemu command line is always ignored. > > A less invasive fix than mine would be > > - if (__initramfs_size > 0) { > + if (__initramfs_size > 0 && !initrd_start) { > > Any chance you can test that with your setup ? You should just delete the last four lines above. They serve no purpose. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: m68k allmodconfig build errors

2018-07-27 Thread Andreas Schwab
On Jul 27 2018, Finn Thain wrote: > Why doesn't gcc convert strncmp to __builtin_strcmp? It does. In fact, it first converts strncmp to __builtin_strncmp, then optimizes it to __builtin_strcmp. Finally, __bultin_strcmp is expanded to a call to strcmp. Andreas. -- Andreas Sch

Re: m68k allmodconfig build errors

2018-07-20 Thread Andreas Schwab
available. I think the right fix is to use strcmp directly, since strncmp doesn't make sense here. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: m68k allmodconfig build errors

2018-07-24 Thread Andreas Schwab
On Jul 23 2018, Randy Dunlap wrote: > I don't see that all of these string compare fields are null-terminated. That gcc has converted the strncmp calls to strcmp is a pretty strong evidence that they are. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 E

Re: [PATCH v9 00/24] ILP32 for ARM64

2018-07-25 Thread Andreas Schwab
roduce thread flag to control userspace mitigation) (which has been backported to stable). Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: Is there an recommended way to refer to bitkeepr commits?

2017-05-12 Thread Andreas Schwab
ed and fetched. (They are stored in refs/replace, and must be pushed/fetched explicitly.) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Is there an recommended way to refer to bitkeepr commits?

2017-05-13 Thread Andreas Schwab
at refs/heads/*. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: m68k allmodconfig build errors

2018-09-26 Thread Andreas Schwab
On Sep 26 2018, Geert Uytterhoeven wrote: > Isn't gcc-8 just assuming that any char array must contain a valid > NUL-terminated string, unless it is tagged with the nonstring attribute? No, only if you call strncpy on it and make it potentially non-terminated. Andreas. -- Andreas

Re: [RFC PATCH v2 07/14] m68k: atari: Convert to clocksource API

2018-11-20 Thread Andreas Schwab
k for the serial interfaces. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: macb: probe of 10090000.ethernet failed with error -110

2018-11-29 Thread Andreas Schwab
Y_GBIT_FEATURES, .flags = PHY_HAS_INTERRUPT, - .soft_reset = &genphy_soft_reset, + .soft_reset = &vsc8541_soft_reset, .config_init= &vsc85xx_config_init, .config_aneg= &vsc85xx_config_aneg, .aneg_done = &genphy_aneg_do

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
54/0xf2 [<0>] __driver_attach+0xde/0x106 [<0>] bus_for_each_dev+0x4a/0x72 [<0>] driver_attach+0x1a/0x22 [<0>] bus_add_driver+0x1ce/0x212 [<0>] driver_register+0x3a/0xd0 [<0>] __platform_driver_register+0x3a/0x42 [<0>] macb_driver_init+0x20/0x28 [macb] [<0&g

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Nov 19 2018, Andrew Lunn wrote: > On Mon, Nov 19, 2018 at 03:57:17PM +0100, Andreas Schwab wrote: >> On Okt 08 2018, Quentin Schulz wrote: >> >> > The Microsemi PHYs have multiple banks of registers (called pages). >> > Registers can only be accessed fro

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
le, perhaps it needs to be rewritten. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Nov 19 2018, Andrew Lunn wrote: > Could you turn on lockdep and see if it reports a deadlock. How do I "turn on lockdep"? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for so

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Nov 19 2018, Andrew Lunn wrote: > Lock debugging: prove locking correctness 404 Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v2] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-13 Thread Andreas Schwab
On Nov 13 2018, Brian Norris wrote: > + } | grep -qv '^\(.. \)\?scripts/package'; then \? is a GNU extension, so if you want to stay portable you need to switch to ERE. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 25

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-10 Thread Andreas Schwab
status -uno --porcelain >> 2>/dev/null)" >> +if [ $? -eq 0 ]; then >> +if echo "$git_status" | grep -qv '^.. scripts/package'; >> then > > Shouldn't this be: > > if printf '%s' &qu

Re: [PATCH] staging: rtl8723bs: fix comparsion to true/false and brace issues

2018-06-30 Thread Andreas Schwab
> + if (manual) > hal_btcoex_SetManualControl(padapter, true); > - } else{ > + else > hal_btcoex_SetManualControl(padapter, false); > - } aka. hal_btcoex_SetManualControl(padapter, manual); Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

Re: [PATCH v3] m68k: Fix memblock-related crashes

2018-12-13 Thread Andreas Schwab
0x12/0x18 [ 65.390000] [<2934>] syscall+0x8/0xc [ 65.39] [<c016>] bvme6000_gettimeoffset+0xaa/0xe2 [ 65.39] Code: 2d20 012a 2839 005f 5124 226b 0014 7001 0060 6600 0210 4a29 0064 6700 0208 4a8b 6700 0294 2053 2068 0014 2028 002c Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v3] m68k: Fix memblock-related crashes

2018-12-17 Thread Andreas Schwab
On Dez 13 2018, Andreas Schwab wrote: > I'm now getting this Oops: > > [ 65.39] Unable to handle kernel NULL pointer dereference at virtual > address (ptrval) > [ 65.39] Oops: > [ 65.39] Modules linked in: nls_iso8859_1 nls_cp437 vfat fat v

Re: [PATCH v3] m68k: Fix memblock-related crashes

2018-12-17 Thread Andreas Schwab
On Dez 17 2018, Andreas Schwab wrote: > On Dez 13 2018, Andreas Schwab wrote: > >> I'm now getting this Oops: >> >> [ 65.39] Unable to handle kernel NULL pointer dereference at virtual >> address (ptrval) >> [ 65.39] Oops: >>

Re: [for-next][PATCH 23/24] string.h: Add strncmp_prefix() helper macro

2018-12-21 Thread Andreas Schwab
\ >> > + }) >> >> I think all the underscores are unnecessary and confusing. >> > > Well, perhaps I can just remove the ending ones. I get paranoid with > macro variables, and tend to over do it so that there's no question. Why not make it an inline function? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] RISC-V: Fix of_node_* refcount

2019-01-07 Thread Andreas Schwab
f_node_release+0xbe/0xc0 [0.00] [] kobject_put+0xa6/0x1e8 [0.00] [] of_node_put+0x16/0x20 [0.00] [] of_find_node_by_type+0x66/0xa4 [0.00] [] 0xffe028bc [0.00] [] 0xffe026cc [0.000000] [] 0xffe006ec [0.00] [] 0xffe000

[PATCH] RISC-V: fix bad use of of_node_put

2019-01-07 Thread Andreas Schwab
of_find_node_by_type already calls of_node_put, don't call it again. Fixes: 94f9bf118f ("RISC-V: Fix of_node_* refcount") Signed-off-by: Andreas Schwab --- arch/riscv/kernel/smpboot.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/riscv/kernel/s

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Andreas Schwab
& BIT(offset)) ? chip->trigger[offset] : 0; This should use test_bit instead. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Andreas Schwab
On Okt 10 2018, Christoph Hellwig wrote: > On Wed, Oct 10, 2018 at 03:01:29PM +0200, Andreas Schwab wrote: >> On Okt 09 2018, Atish Patra wrote: >> >> > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) >> > +{ >> > + unsigne

Re: O_NOLINK for open()

2007-09-12 Thread Andreas Schwab
his does open up a very > small window of vulnerability if another process is able to chmod > the file and open it before the unlink. Only the owner can chmod a file, so why is that a vulnerability? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeld

Re: O_NOLINK for open()

2007-09-14 Thread Andreas Schwab
ner, so this is not a setuid execution. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscri

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Andreas Schwab
Denys Vlasenko <[EMAIL PROTECTED]> writes: > ELF is not as rigid as old a.out (which had only one text, one data > and one bss segment per .o file IIRC), but size was born in a.out days, > so it sort of "translates" ELF into a.out. Try size -A instead. Andreas. --

Re: [PATCH] Since we have counters in __u64 format we have to print them with %llu macros.

2007-09-26 Thread Andreas Schwab
oluntary", "nonvoluntary", > t->nvcsw, t->nivcsw); __u64 is not always long long. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44

Re: Don't cross the (tty) streams

2007-09-20 Thread Andreas Schwab
ror path that doesn't throw away data on -EIO. Read the thread starting here: <http://lists.gnu.org/archive/html/bug-bash/2007-09/msg00020.html>. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fin

Re: Should parent's WIFSIGNALED(siginfo->si_status) be true EVEN IF the SIGNAL was caught by the child?

2007-09-22 Thread Andreas Schwab
"John Z. Bohach" <[EMAIL PROTECTED]> writes: > if (WIFEXITED(siginfo->si_status)) That does not make any sense. si_status is _not_ a wait status. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nür

Re: Pausing kernel boot messages

2007-08-27 Thread Andreas Schwab
t; These are functions of a shell (like bash), Definitely not. The shell is not a console driver, it only uses it. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D

ADDR_COMPAT_LAYOUT breaks PTRACE_SEIZE

2015-03-22 Thread Andreas Schwab
) { kill (getpid (), SIGSTOP); exit (0); } ptrace (PTRACE_SEIZE, child, NULL, NULL); wait (NULL); ptrace (PTRACE_CONT, child, NULL, NULL); } Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 &quo

Re: [PATCH v2] Fix pointer cast for 32 bits arch

2015-04-12 Thread Andreas Schwab
Peter Senna Tschudin writes: > Sparse compalins about casting void * to u64 on i386. s/compalins/complains/ Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different

Re: [PATCH 6/6] hrtimer: Update hrtimer base offsets each hrtimer_interrupt

2012-07-15 Thread Andreas Schwab
This breaks resume on the iBook G4 (PowerBook6,7). Apparently during or before noirq resume the system is hanging by the same amount of time as the system was sleeping. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5

Re: [PATCH 6/6] hrtimer: Update hrtimer base offsets each hrtimer_interrupt

2012-07-15 Thread Andreas Schwab
Andreas Schwab writes: > This breaks resume on the iBook G4 (PowerBook6,7). Apparently during or > before noirq resume the system is hanging by the same amount of time as > the system was sleeping. The point where the time is wasted actually appears to be _after_ resume (the elapsed

Re: [Regression][Revert request] Excessive delay or hang during resume from system suspend due to a hrtimer commit

2012-07-16 Thread Andreas Schwab
"Rafael J. Wysocki" writes: > On Monday, July 16, 2012, Thomas Gleixner wrote: >> Does the following patch fix the problem for you ? > > Yes, it does, thanks! Works for me as well. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7

<    1   2   3   4   5   6   >