checkpatch complains about three places where a space is prohibited
before the braces for an "#if defined()" check. This patch removes
the spaces.
Signed-off-by: Andreas Ruprecht
---
drivers/staging/lustre/lustre/fid/fid_internal.h | 2 +-
drivers/staging/lustre/lustre/fid/fid_requ
to 'y', requiring the functions at link time.
Is the attached patch sufficient to fix this?
Regards,
Andreas
From 0529c3cbe381338dc3337e07a71e15b3d22a3255 Mon Sep 17 00:00:00 2001
From: Andreas Ruprecht
Date: Thu, 4 Dec 2014 18:28:09 +0100
Subject: [PATCH] net: ethernet: rocker: Add
, if CONFIG_BRIDGE is set to 'y', it can be 'n', 'm' or 'y'.
This also means that the prompt associated with CONFIG_ROCKER will only
show up in menuconfig when CONFIG_BRIDGE has been enabled (either 'm' or
'y').
I've attached an upda
Hi,
On 22.04.2015 20:20, Denys Vlasenko wrote:
> Hi,
>
> Kernel has a growing number of CONFIG items which are not
> user-selectable features of their particular kernel builds,
> but simply booleans controlled by other CONFIGs.
> Example:
>
> I see how this practice originated: "select" statemen
be compiled and
they can both be removed.
Signed-off-by: Andreas Ruprecht
---
This inconsistency was found using the undertaker-checkpatch tool
which is included in the undertaker toolchain.
drivers/firmware/iscsi_ibft.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/firmware/is
be compiled and
they can both be removed.
Signed-off-by: Andreas Ruprecht
---
drivers/firmware/iscsi_ibft.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 071c2c9..60c937f 100644
--- a/drivers/firmware/iscsi_ibft.c
++
Hi Daniel,
your commit bdc728a849a7 ("powerpc: move find_and_init_phbs() to pSeries
specific code") in today's Linux next tree moves a function into the
pSeries specific setup.c file. I noticed it because I'm running an
automated bot on top of linux-next which looks for variability-related
defects
Hi Maxime,
your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
was merged into linux-next today (i.e., next-20150615), and contains the
following piece of code:
[...]
#if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&
defined(CONFIG_MAGIC_SYSRQ)
#define SUPPORT_SYSRQ
#endif
[.
/* CONFIG_8723AU_AP_MODE */ (line 1763)
The inner #ifdefs are unnecessary as they depend on the
same condition as the outer #ifdef and can thus be removed.
Signed-off-by: Andreas Ruprecht
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers
Hi Tadeusz,
your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
implementation") was merged into linux-next today (i.e., next-20150618).
It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
+config CRYPTO_RSA
+ tristate "RSA algorithm"
+ select AKCIPHER
, it is
unnecessary and can be removed.
Signed-off-by: Andreas Ruprecht
---
arch/x86/kernel/apic/x2apic_uv_x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c
b/arch/x86/kernel/apic/x2apic_uv_x.c
index 004f017..8e9dcfd 100644
--- a/arch/x86/kernel/apic
Hi all,
actually the problem isn't that easy... some of the information from the
Kbuild files is not entirely straight-forward to extract.
If you're interested in the former (that is, what config symbols have to
be enabled to have a file compiled), there is a Python tool called
"golem" in the too
Hi,
On 07/07/2015 16:45, Ulf Magnusson wrote:
>
> Did you use the (undocumented, obviously :) REGENERATE_PARSERS option,
> like 'make menuconfig REGENERATE_PARSERS=1'? It's from
> scripts/Makefile.lib.
>
> The following patch works fine for me from some quick experimentation.
> It's against the
gests that this functionality should
also be available for SIBYTE_BCM1x55 and SIBYTE_BCM1x80.
Make it selectable by extending the dependencies of
SIBYTE_BUS_WATCHER in arch/mips/sibyte/Kconfig.
Reported-by: Jonas Rabenstein
Signed-off-by: Andreas Ruprecht
---
I found this inconsistency using the
in a build error due to an undefined reference. This patch adds
the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
Signed-off-by: Andreas Ruprecht
Reported-by: Jim Davis
---
drivers/media/pci/smipcie/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pc
On 21.11.2014 19:13, Mauro Carvalho Chehab wrote:
> Em Fri, 21 Nov 2014 18:51:59 +0100
> Andreas Ruprecht escreveu:
>
>> In smipcie.c, the function i2c_bit_add_bus() is called. This
>> function is defined by the I2C bit-banging interfaces enabled
>> with CONFIG_I2C_ALG
in a build error due to an undefined reference.
This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig
by selecting it when CONFIG_DVB_SMIPCIE is selected.
Signed-off-by: Andreas Ruprecht
Reported-by: Jim Davis
---
drivers/media/pci/smipcie/Kconfig | 1 +
1 file changed, 1 insert
dependency
is added to CONFIG_SND_SOC_ROCKCHIP_I2S. This will make the item
visible only if CONFIG_SND_SOC_ROCKCHIP is enabled.
Signed-off-by: Andreas Ruprecht
Reported-by: Jim Davis
---
sound/soc/rockchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/rockchip
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 21.11.2014 19:58, Mark Brown wrote:
> On Fri, Nov 21, 2014 at 07:35:13PM +0100, Andreas Ruprecht wrote:
>> Currently, CONFIG_SND_SOC_ROCKCHIP_I2S could also be selected
>> without having CONFIG_SND_SOC_ROCKCHIP enabled.
>>
code connected to CONFIG_SND_SOC_ROCKCHIP_I2S
depends on CONFIG_SND_SOC_GENERIC_DMAENGINE_PCM, the dependency
is moved to reflect this more clearly.
Signed-off-by: Andreas Ruprecht
Reported-by: Jim Davis
---
sound/soc/rockchip/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
h
prevents compilation of the rtl8192ee driver unless the
completely unrelated Kconfig option for the rtl8821ae driver
(CONFIG_RTL8821AE) is also enabled.
Andreas Ruprecht (2):
net: wireless: rtlwifi: Do not always include drivers in obj-m
net: wireless: rtlwifi: rtl8192ee: Fix compilation of
In the Makefile for this driver, the wrong Kconfig option is used
to trigger the compilation of the object file. This leads to the
driver only being included into the kernel when both CONFIG_RTL8821AE
and CONFIG_RTL8192AE are set to "y".
Signed-off-by: Andreas Ruprecht
---
drivers/ne
hich leads to a compilation
as a built-in only. Even though this leads to the desired behavior,
the unconditional appearance in obj-m is confusing for someone reading
the Makefile.
This patch removes the superfluous Makefile statements.
Signed-off-by: Andreas Ruprecht
---
drivers/net/wirele
e if at least one of
{CONFIG_NF_NAT_REDIRECT_IPV4, CONFIG_NF_NAT_REDIRECT_IPV6} are enabled.
Additionally it is necessary to provide stubs for the
nf_nat_redirect_ipv{4,6} functions in case the header is included but
the corresponding Kconfig feature is not enabled.
Signed-off-by: Andreas Ruprec
t capitalization for CONFIG_NF_NAT_REDIRECT_IPV4 in comment.
Signed-off-by: Andreas Ruprecht
---
include/net/netfilter/ipv4/nf_nat_redirect.h | 14 ++
include/net/netfilter/ipv6/nf_nat_redirect.h | 13 +
net/netfilter/Kconfig| 2 +-
3 files changed, 28 inser
logic goes for nf_nat_redirect_ipv6().
Hope this helps,
Andreas
On 26.11.2014 11:24, Florian Westphal wrote:
> Andreas Ruprecht wrote:
>> Additionally it is necessary to provide stubs for the
>> nf_nat_redirect_ipv{4,6} functions in case the header is included but
>> the
Hi,
after a lot of staring at the configuration it seems like this boils
down to an issue within the Kconfig constraint description.
Broken down to the important bits:
- CONFIG_VIDEO_TW68 and CONFIG_VIDEO_SAA7134 *select*
CONFIG_VIDEOBUF2_DMA_SG
- Both of these options are set to "*m*" in the c
Hi Jaegeuk,
your commit c863114122ac ("f2fs crypto: add symlink encryption") showed
up in linux-next today (i.e., next-20150521). I noticed it because we
run a daily analysis on linux-next, checking for inconsistencies
regarding #ifdef blocks [0,1].
In the commit, you create nested #ifdef blocks
CONFIG_PM
/* always on / undead */
#else
/* dead */
#endif
[...]
This patch removes the function in the dead #ifdef block and the
unnecessary inner #ifdef. This inconsistency was found using the
undertaker-checkpatch tool.
Signed-off-by: Andreas Ruprecht
---
drivers/usb/core/hub.c | 12 --
*/
#ifdef CONFIG_PM_SLEEP
[...]
#endif
#endif
[...]
#endif
This patch removes the inner "#ifdef CONFIG_PM" block as it will
always be enabled when the outer block is enabled. This inconsistency
was found using the undertaker-checkpatch tool.
Signed-off-by: Andreas Ruprecht
---
drivers/
CONFIG_PM
/* always on / undead */
#else
/* dead */
#endif
[...]
This patch removes unnecessary inner "#ifdef CONFIG_PM" as well as
the corresponding dead #else block. This inconsistency was found using
the undertaker-checkpatch tool.
Signed-off-by: Andreas Ruprecht
---
Changes to v1:
nd adapt the printed error message.
This inconsistency was found with the undertaker tool.
Signed-off-by: Andreas Ruprecht
---
drivers/gpu/drm/i915/i915_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915
]
As this is the module init function, it can (and should) be declared
static.
Signed-off-by: Andreas Ruprecht
---
drivers/staging/lustre/lustre/osc/osc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c
b/drivers/stag
On 02.02.2015 15:16, Al Viro wrote:
> On Mon, Feb 02, 2015 at 02:36:43PM +0100, Andreas Ruprecht wrote:
>> When running sparse on the osc/ subdirectory, it shows the
>> following warning:
>>
>> andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/
/lustre/lustre/osc/
[...]
drivers/staging/lustre/lustre/osc/osc_request.c:3335:12: warning:
symbol 'osc_init' was not declared. Should it be static?
[...]
Signed-off-by: Andreas Ruprecht
---
drivers/staging/lustre/lustre/osc/osc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
rocessor definitions
depending on CONFIG_CPU_MICROMIPS. The #ifdef around them can now
never evaluate to true, so let's remove them altogether.
This inconsistency was found using the undertaker-checkpatch tool.
Signed-off-by: Andreas Ruprecht
---
arch/mips/mm/uasm-micromips.c | 8
In the Makefile, string.o (which is generated from string.S) is
included into the list of objects being built unconditionally
(obj-y) in line 12.
Additionally, if CONFIG_PPC64 is set, it is included again in
line 17.
This patch removes the latter unnecessary inclusion.
Signed-off-by: Andreas
Hi,
On 07/02/2015 11:01, Paul Bolle wrote:
> [Dropped Yann. You already know Yann disappeared.]
>
> On Thu, 2015-07-02 at 10:08 +0200, Valentin Rothberg wrote:
>> commit ed013214afa7 ("ACPI / init: Make it possible to override _REV")
>> is in today's linux-next tree (i.e., next-20150702) adding t
On 07/02/2015 14:10, Paul Bolle wrote:
> [Spoiler: please start at the end of my reply.]
>
> On do, 2015-07-02 at 13:57 +0200, Andreas Ruprecht wrote:
>> On 07/02/2015 11:01, Paul Bolle wrote:
>>> On Thu, 2015-07-02 at 10:08 +0200, Valentin Rothberg wrote:
>>>
On 07/03/2015 10:59, Paul Bolle wrote:
> On vr, 2015-07-03 at 09:33 +0200, Andreas Ruprecht wrote:
>> I tested the behaviour on yesterday's linux-next, but the commit
>> mentioned above will only complain for invalid characters inside the
>> PARAM case and not for COMMA
Hi Jianwei,
your commit 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM
driver") showed up in linux-next today (i.e., next-20150821). I noticed
it because we are running a daily analysis on the newest linux-next tree
as part of our research.
In the source code of fsl_dcu_drm_drv.c, there is
On 07/03/2015 12:46, Ulf Magnusson wrote:
>
> Except for scattered accidents like in the original message, which are
> hopefully pretty rare and easy to fix, the only documented thing that depends
> on that lexer sloppiness is the ---help--- "token".
>
> I'd just add "---help---" as another T_HEL
characters are found
around statements. As the 'help' statement sometimes is written as
'---help---', the '-' character would now also be regarded as
unhandled, this change also adds a special rule for this case.
Reported-by: Valentin Rothberg
Signed-off-by: Andrea
.04 - this
also leads to the big number of changed lines in this patch.
Signed-off-by: Andreas Ruprecht
---
scripts/kconfig/zconf.lex.c_shipped | 453 +---
1 file changed, 313 insertions(+), 140 deletions(-)
diff --git a/scripts/kconfig/zconf.lex.c_shipped
b/scrip
lots of warnings as occasionally '---help---'
is used instead of 'help' (and thus '-' is recognized as an unhandled
character), we need to handle the former separately.
Andreas Ruprecht (2):
kconfig: also warn of unhandled characters in statements
kconfig: Regenerate
; character would now also be regarded
as unhandled and generate a warning. To avoid that, '-' is added to
the list of allowed characters, and the token '---help---' is included
in the zconf.gperf file.
Reported-by: Valentin Rothberg
Signed-off-by: Andreas Ruprecht
lots of warnings as occasionally '---help---'
is used instead of 'help' (and thus '-' is recognized as an unhandled
character), we need to handle '---help---' separately.
Andreas Ruprecht (2):
kconfig: warn of unhandled characters in Kconfig commands
kconfig: R
3.0.4 from
Ubuntu 14.04 - this also leads to the big number of changed lines
in this patch.
Signed-off-by: Andreas Ruprecht
---
scripts/kconfig/zconf.hash.c_shipped | 58 +
scripts/kconfig/zconf.lex.c_shipped | 120 +++
2 files changed, 97 inserti
; character would now also be regarded
as unhandled and generate a warning. To avoid that, '-' is added to
the list of allowed characters, and the token '---help---' is included
in the zconf.gperf file.
Reported-by: Valentin Rothberg
Signed-off-by: Andreas Ruprecht
---
Changes
3.0.4 from
Ubuntu 14.04 - this also leads to the big number of changed lines
in this patch.
Signed-off-by: Andreas Ruprecht
---
scripts/kconfig/zconf.hash.c_shipped | 58 ---
scripts/kconfig/zconf.lex.c_shipped | 325 +--
2 files changed, 192 insertio
it in zconf.l
Changes to v2:
- Do no constify char parameter to warn_ignored_character
- Shorten rule definitions for '.'
Andreas Ruprecht (2):
kconfig: warn of unhandled characters in Kconfig commands
kconfig: Regenerate shipped zconf.{hash,lex}.c files
sc
it in zconf.l
Changes to v2:
- Do no constify char parameter to warn_ignored_character
- Shorten rule definitions for '.'
Changes to v3:
- spaces -> tabs in zconf.gperf
Andreas Ruprecht (2):
kconfig: warn of unhandled characters in Kconfig commands
; character would now also be regarded
as unhandled and generate a warning. To avoid that, '-' is added to
the list of allowed characters, and the token '---help---' is included
in the zconf.gperf file.
Reported-by: Valentin Rothberg
Signed-off-by: Andreas Ruprecht
---
Changes
3.0.4 from
Ubuntu 14.04 - this also leads to the big number of changed lines
in this patch.
Signed-off-by: Andreas Ruprecht
---
scripts/kconfig/zconf.hash.c_shipped | 58 ---
scripts/kconfig/zconf.lex.c_shipped | 325 +--
2 files changed, 192 insertio
Commit-ID: 8091c1f8ea2374695c105591179b1269fb5f2fbb
Gitweb: http://git.kernel.org/tip/8091c1f8ea2374695c105591179b1269fb5f2fbb
Author: Andreas Ruprecht
AuthorDate: Wed, 20 Aug 2014 10:16:01 +0200
Committer: Ingo Molnar
CommitDate: Wed, 20 Aug 2014 15:05:30 +0200
x86/apic/uv: Remove
55 matches
Mail list logo
