[PATCH v4 5/5] dt-bindings: gnss: add lna-supply property

2019-01-23 Thread Andreas Kemnade
Add lna-supply property. Signed-off-by: Andreas Kemnade Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/gnss/gnss.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gnss/gnss.txt b/Documentation/devicetree/bindings/gnss/gnss.txt index

[PATCH v4 4/5] gnss: sirf: add a separate supply for a lna

2019-01-23 Thread Andreas Kemnade
Devices might have a separate lna between antenna input of the gps chip and the antenna which might have a separate supply. Signed-off-by: Andreas Kemnade --- Changes in v4: - cleaned up error checking - was 5/6 earlier Changes in v3: - improved error checking - style cleanup Changes in v2

[PATCH v4 2/5] gnss: sirf: add support for configurations without wakeup signal

2019-01-23 Thread Andreas Kemnade
Some Wi2Wi devices do not have a wakeup output, so device state can only be indirectly detected by looking whether there is communication over the serial lines. This approach requires a report cycle set to a value less than 2 seconds to be reliable. Signed-off-by: Andreas Kemnade --- Changes in

[PATCH v4 0/5] gnss: sirf: add support for w2sg0004 + lna

2019-01-23 Thread Andreas Kemnade
ot; so the initial powerdown patch is unneeded - cleanups Andreas Kemnade (5): gnss: sirf: write data to gnss only when the gnss device is open gnss: sirf: add support for configurations without wakeup signal dt-bindings: gnss: add w2sg0004 compatible string gnss: sirf: add a separate

[PATCH v4 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2019-01-23 Thread Andreas Kemnade
The api forbids writing data there otherwise. Prepare for the serdev_open()/close() being a part of sirf_set_active. Signed-off-by: Andreas Kemnade --- No changes in v4 Changes in v3: - add more locking - style cleanup - mutex *not* renamed since we need a second one Changes in v2: - add

Re: linux-next: Fixes tag needs some work in the mfd-fixes tree

2019-04-04 Thread Andreas Kemnade
Hi Stephen, On Fri, 5 Apr 2019 07:48:43 +1100 Stephen Rothwell wrote: > Hi Lee, > > In commit > > 20bb907f7dc8 ("mfd: twl-core: Disable IRQ while suspended") > > Fixes tag > > Fixes: 6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle > device for suspend") > > has these pro

Re: [PATCH v2] ARM: sun8i: h3: bluetooth for Banana Pi M2 Zero board

2019-04-07 Thread Andreas Kemnade
ping On Fri, 1 Mar 2019 19:52:12 +0100 Andreas Kemnade wrote: > The Banana Pi M2 Zero board has an AP6212 BT+Wifi combo chip > with broadcom internals attached to UART1 and some gpios. > This addition is in line with similar boards > > Signed-off-by: Andreas Kemnade > -

Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

2019-03-30 Thread Andreas Kemnade
On Sun, 24 Mar 2019 07:56:17 +0100 "H. Nikolaus Schaller" wrote: > Hi Linus, > > > Am 24.03.2019 um 05:15 schrieb Linus Walleij : > > > > On Sat, Mar 23, 2019 at 3:40 PM H. Nikolaus Schaller > > wrote: > > > >> (1) c1c04cea13dc gpio: of: Fix logic inversion > >> > >> together with the bas

Re: [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030

2019-06-17 Thread Andreas Kemnade
On Mon, 17 Jun 2019 12:40:48 +0100 Mark Brown wrote: > On Mon, Jun 17, 2019 at 01:03:57PM +0200, Andreas Kemnade wrote: > > Mark Brown wrote: > > > On Sat, Jun 15, 2019 at 06:33:14PM +0200, Andreas Kemnade wrote: > > > > Why is this a good fix and not d

Re: [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030

2019-06-17 Thread Andreas Kemnade
On Mon, 17 Jun 2019 12:40:48 +0100 Mark Brown wrote: > On Mon, Jun 17, 2019 at 01:03:57PM +0200, Andreas Kemnade wrote: > > Mark Brown wrote: > > > On Sat, Jun 15, 2019 at 06:33:14PM +0200, Andreas Kemnade wrote: > > > > Why is this a good fix and not d

Re: [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030

2019-06-17 Thread Andreas Kemnade
On Mon, 17 Jun 2019 18:02:55 +0100 Mark Brown wrote: > On Mon, Jun 17, 2019 at 06:27:43PM +0200, Andreas Kemnade wrote: > > > Citing tps65950 trm page 55: > > > The device contains three switch-mode power supplies (SMPS): > > • VDD1: 1.2-A, buck DC/DC converter

Re: [PATCH v2] arm: dts: gta04: add bluetooth serdev driver flags

2019-01-09 Thread Andreas Kemnade
Hi, On Wed, 9 Jan 2019 18:47:52 +0100 "H. Nikolaus Schaller" wrote: > From: Andreas Kemnade > > gta04a[34] have bluetooth chips which simply understand > h4 protocol. > > Signed-off-by: Andreas Kemnade what about upstreaming the full patch based on mainline

[PATCH RFC] media: omap3isp: Fix high idle current

2019-01-09 Thread Andreas Kemnade
right or not. Signed-off-by: Andreas Kemnade --- drivers/media/platform/omap3isp/isp.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 13f2828d880d..b837ca5604ad

Re: [PATCH v2] phy: phy-twl4030-usb: fix denied runtime access

2019-02-21 Thread Andreas Kemnade
Hi, On Wed, 20 Feb 2019 14:31:32 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180922 09:48]: > > When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, > > the counter will be incremented but the resume callback not called, > > so enumeration and ch

Re: [PATCH v2] phy: phy-twl4030-usb: fix denied runtime access

2019-02-21 Thread Andreas Kemnade
On Thu, 21 Feb 2019 08:48:03 -0800 Tony Lindgren wrote: > * Andreas Kemnade [190221 16:43]: > > Hi, > > > > On Wed, 20 Feb 2019 14:31:32 -0800 > > Tony Lindgren wrote: > > > > > * Andreas Kemnade [180922 09:48]: > > > > When runtime

[PATCH] mfd: twl-core: disable irq while suspended

2019-02-23 Thread Andreas Kemnade
ton or rtc alarm). This goes on for minutes until the system is finally resumed. Disable the irq on suspend and enable it on resume to avoid having i2c access problems when the irq registers are checked. Signed-off-by: Andreas Kemnade --- drivers/mfd/twl-core.c | 23 +++ 1 fi

Re: [PATCH v2 5/5] dt-bindings: gnss: add lna-supply property

2019-01-10 Thread Andreas Kemnade
On Thu, 10 Jan 2019 13:27:57 +0100 Johan Hovold wrote: > On Sun, Dec 09, 2018 at 08:51:50PM +0100, Andreas Kemnade wrote: > > Add lna-supply property. > > > > Signed-off-by: Andreas Kemnade > > --- > > Changes in v2: > > - reordering > > Orig

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-10 Thread Andreas Kemnade
Hi Johan, On Thu, 10 Jan 2019 13:10:38 +0100 Johan Hovold wrote: > Please change the commit summary to something more descriptive like > > gnss: sirf: add support for configurations without wakeup signal > > On Sun, Dec 09, 2018 at 08:51:47PM +0100, Andreas Kemnade wrote:

[PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio

2018-09-24 Thread Andreas Kemnade
Pullup and down settings were missing, so add them to avoid floating pins and make headset detection working. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/omap3-gta04.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm

Re: [PATCH] ARM: dts: gta04: add serial console wakeup irq

2018-09-24 Thread Andreas Kemnade
Hi Tony, On Mon, 24 Sep 2018 15:03:45 -0700 Tony Lindgren wrote: > * Andreas Kemnade [180923 08:12]: > > This enables the possibility to have more aggressive runtime pm > > by providing proper wakeup irq for the serial console. > > Thanks applying to omap-for-v4.20/dt.

Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

2018-09-04 Thread Andreas Kemnade
Hi, On Tue, 4 Sep 2018 16:34:56 +0200 Ulf Hansson wrote: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no re

Re: [PATCH RESEND] twl4030_charger: fix charging current out-of-bounds

2018-09-30 Thread Andreas Kemnade
Hi Pavel, On Sun, 30 Sep 2018 22:16:42 +0200 Pavel Machek wrote: > On Mon 2018-09-17 07:20:35, Andreas Kemnade wrote: > > the charging current uses unsigned int variables, if we step back > > if the current is still low, we would run into negative which > > means setting

[PATCH v2] phy: phy-twl4030-usb: fix denied runtime access

2018-09-22 Thread Andreas Kemnade
device is woken up from suspend by plugging in usb. Signed-off-by: Andreas Kemnade --- Changes in v2: * use pm suspend/resume callback instead of delayed_work as suggested by Dmitry drivers/phy/ti/phy-twl4030-usb.c | 29 + 1 file changed, 29 insertions(+) diff --git a

[PATCH] w1: omap-hdq: fix missing bus unregister at removal

2018-09-22 Thread Andreas Kemnade
] Code: bad PC value [ 128.064697] ---[ end trace af066e33c0e14119 ]--- Cc: Signed-off-by: Andreas Kemnade --- drivers/w1/masters/omap_hdq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index 83fc9aab34e8..3099052e1243 100644

[PATCH] ARM: dts: gta04: add serial console wakeup irq

2018-09-23 Thread Andreas Kemnade
This enables the possibility to have more aggressive runtime pm by providing proper wakeup irq for the serial console. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/omap3-gta04.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot

Re: Regression in next with filesystem context concept

2018-09-07 Thread Andreas Kemnade
Hi, On Fri, 7 Sep 2018 09:10:23 -0700 Tony Lindgren wrote: > * David Howells [180907 08:51]: > > Tony Lindgren wrote: > > > > > Looks like next-20180906 now has a regression where mounting > > > root won't work with commit fd0002870b45 ("vfs: Implement a > > > filesystem superblock creation

[PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

2018-09-02 Thread Andreas Kemnade
at removal. Signed-off-by: Andreas Kemnade Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq") --- drivers/mmc/host/omap_hsmmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsm

Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding

2018-05-03 Thread Andreas Kemnade
On Thu, 3 May 2018 11:35:21 +0200 H. Nikolaus Schaller wrote: > I have realized that the w2sg0004 is an exception (although a Sirf chip) > that it does not provide a WAKEUP signal. And another significant > difference is that we have to keep the serdev UART enabled even if there > is no user-spa

[PATCH 0/3] support for Logilink VG0022a DVB-T2 stick

2017-03-15 Thread Andreas Kemnade
Hi all, here are some patches needed for supporting the Logilink VG0022A DVB-T2 stick. As the combination of chips in that stick is not uncommon, the first two patches might also fix problems for similar hardware. Andreas Kemnade (3): [media] si2157: get chip id during probing [media] af9035

[PATCH 3/3] [media] af9035: add Logilink vg0022a to device id table

2017-03-15 Thread Andreas Kemnade
Ths adds the logilink VG00022a dvb-t dongle to the device table. The dongle contains (checked by removing the case) IT9303 SI2168 214730 Signed-off-by: Andreas Kemnade --- drivers/media/usb/dvb-usb-v2/af9035.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2

[PATCH 2/3] [media] af9035: init i2c already in it930x_frontend_attach

2017-03-15 Thread Andreas Kemnade
i2c bus is already needed when the frontend is probed, so init it already in it930x_frontend_attach That prevents errors like si2168: probe of 6-0067 failed with error -5 Signed-off-by: Andreas Kemnade --- drivers/media/usb/dvb-usb-v2/af9035.c | 43 ++- 1

[PATCH 1/3] [media] si2157: get chip id during probing

2017-03-15 Thread Andreas Kemnade
a symptome of that problem: si2157 7-0063: unknown chip version Si21255-\x\x\x Signed-off-by: Andreas Kemnade --- drivers/media/tuners/si2157.c | 54 ++ drivers/media/tuners/si2157_priv.h | 7 + 2 files changed, 39 insertions

Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-21 Thread Andreas Kemnade
Hi, [...] > > Hm. Why not touching pixel (0,0) on the touch is always pixel (0,0) > > on the screen and touching pixel (639,479) is always (639,479)? > > Important is that there is no 1:1 mapping between input evdev device > and drm/fb output device. These are two independent devices. There is >

Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-18 Thread Andreas Kemnade
Hi Dmitry, On Fri, 17 Feb 2017 12:40:41 -0800 Dmitry Torokhov wrote: [...] > > Let me cite myself: > > > > >> This makes it possible to pre-calibrate the touch so that is > > >> (almost) > > Yes, it allows you to pre-calibrate, I get it. But you still do > properly calibrate later, right? So

Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-19 Thread Andreas Kemnade
Hi, On Sun, 19 Feb 2017 21:57:08 +0100 Pavel Machek wrote: > Hi! > > > > But as said I don't think we need float or fixed point for > > practical systems at all. > > So you are going to loose precision. And if userspace decides to > calibrate it slightly differently from kernel, lost precisio

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-02 Thread Andreas Kemnade
On Tue, 2 Aug 2016 03:33:34 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160729 11:14]: > > The code assumes that omap2430_musb_enable() and > > omap2430_musb_disable() is called in a balanced way. The > > That fact is broken by the fact that musb_in

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-03 Thread Andreas Kemnade
On Tue, 2 Aug 2016 23:30:16 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160802 08:14]: > > On Tue, 2 Aug 2016 03:33:34 -0700 > > Tony Lindgren wrote: > > > > > * Andreas Kemnade [160729 11:14]: > > > > The code assumes that omap2430_musb_enabl

[PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-03 Thread Andreas Kemnade
events phy_power_off() from being called when it is already off. Signed-off-by: Andreas Kemnade --- changes in v2: improved commit message drivers/usb/musb/omap2430.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap

[PATCH v3 4/6] libertas: go back to ps mode without commands pending

2016-01-30 Thread Andreas Kemnade
needed. Signed-off-by: Andreas Kemnade --- changes in v3: corrected paths changes in v2: reordered, was 5/6 drivers/net/wireless/marvell/libertas/cmd.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas

[PATCH v3 1/6] libertas: fix pointer bugs for PS_MODE commands

2016-01-30 Thread Andreas Kemnade
to the command buffer This piece of code was unused since power saving was not enabled. Signed-off-by: Andreas Kemnade --- changes in v3: corrected paths changes in v2: improved commit message drivers/net/wireless/marvell/libertas/cmd.c | 4 ++-- drivers/net/wireless/marvell/libertas/cmdres

[PATCH v3 2/6] libertas: check whether bus can do more than polling

2016-01-30 Thread Andreas Kemnade
If a sdio host does not support sdio irqs, polling is used instead. That has an impact on performance. Some functionality should not be enabled then. This add a variable in libertas_priv to indicate that. Signed-off-by: Andreas Kemnade --- changes in v3: corrected paths drivers/net/wireless

[PATCH v3 0/6] libertas: ieee80211 powersave mode

2016-01-30 Thread Andreas Kemnade
This series makes IEEE 80211 powersave mode work again so that power usage is dramatically reduced when the device is connected. It does not include other power saving methods which are working when the device is not connected (like enabling deep sleep modus) Tested on GTA04 which includes a W2CBW

[PATCH v3 6/6] libertas: add an cfg80211 interface for powersaving

2016-01-30 Thread Andreas Kemnade
conditions. Signed-off-by: Andreas Kemnade --- changes in v3: corrected paths changes in v2: reordered, was 3/6 drivers/net/wireless/marvell/libertas/cfg.c | 38 + 1 file changed, 38 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b

[PATCH v3 5/6] libertas: fix ps-mode related removal problems

2016-01-30 Thread Andreas Kemnade
forever for the command being processed, so disable it. Signed-off-by: Andreas Kemnade --- changes in v3: corrected paths changes in v2: improved commit message, reordered: was 6/6 drivers/net/wireless/marvell/libertas/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 3/6] libertas: do not confirm sleep if commands are pending

2016-01-30 Thread Andreas Kemnade
If the main thread gets one PS AWAKE event and one PS SLEEP event in one iteration over event_fifo there will never be checks for commands to be processed, since psstate will always be PS_STATE_SLEEP or PS_STATE_PRE_SLEEP Signed-off-by: Andreas Kemnade --- changes in v3: corrected paths changes

[PATCH] net/wireless/libertas: do not strip header for PS_MODE commands

2015-12-22 Thread Andreas Kemnade
struct cmd_ds_802_11_ps_mode contains the command header and a pointer to it was initialized with data points to the body which leads to mis-interpretation of the cmd_ds_802_11_ps_mode.action member. Signed-off-by: Andreas Kemnade --- drivers/net/wireless/libertas/cmd.c |4 ++-- drivers

Re: [PATCH RESEND] omap_hdq: fix usecount handling

2016-02-07 Thread Andreas Kemnade
ping... On Tue, 19 Jan 2016 10:13:04 -0800 "gre...@linuxfoundation.org" wrote: > On Tue, Jan 19, 2016 at 07:38:28PM +0300, Evgeniy Polyakov wrote: > > Hi Andreas > > > > >From w1 perspective this doesn't break things :) > > Greg, please pull it into your tree if no one objects. > > > > Acked-b

[PATCH 0/6] wireless:libertas: ieee80211 powersave mode

2016-01-06 Thread Andreas Kemnade
This series makes IEEE 80211 powersave mode work again so that power usage is dramatically reduced when the device is connected. It does not include other power saving methods which are working when the device is not connected (like enabling deep sleep modus) Tested on GTA04 which includes a W2CBW

[PATCH 2/6] wireless:libertas: check whether bus can do more than polling

2016-01-06 Thread Andreas Kemnade
If a sdio host does not support sdio irqs, polling is used instead. That has an impact on performance. Some functionality should not be enabled then. This add a variable in libertas_priv to indicate that. Signed-off-by: Andreas Kemnade --- drivers/net/wireless/libertas/dev.h | 1 + drivers

[PATCH 1/6] wireless:libertas: do not strip header for PS_MODE commands

2016-01-06 Thread Andreas Kemnade
struct cmd_ds_802_11_ps_mode contains the command header and a pointer to it was initialized with data points to the body which leads to mis-interpretation of the cmd_ds_802_11_ps_mode.action member. Signed-off-by: Andreas Kemnade --- drivers/net/wireless/libertas/cmd.c | 4 ++-- drivers

[PATCH 3/6] wireless:libertas: add an cfg80211 interface for powersaving

2016-01-06 Thread Andreas Kemnade
conditions. Signed-off-by: Andreas Kemnade --- drivers/net/wireless/libertas/cfg.c | 38 + 1 file changed, 38 insertions(+) diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c index 8317afd..fd18d03 100644 --- a/drivers/net

[PATCH 5/6] wireless:libertas: go back to ps mode without commands pending

2016-01-06 Thread Andreas Kemnade
needed. Signed-off-by: Andreas Kemnade --- drivers/net/wireless/libertas/cmd.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c index 40467d6..4ddd0e5 100644 --- a

[PATCH 6/6] wireless:libertas: fix suspend problems

2016-01-06 Thread Andreas Kemnade
When the device goes to suspend mode with powersaving enabled, lbs_remove_card tries to exit powersaving state even when already woken up. That command is not processed properly in that situation, so the system hangs at suspend, so disable it. Signed-off-by: Andreas Kemnade --- drivers/net

[PATCH 4/6] wireless:libertas: do not confirm sleep if commands are pending

2016-01-06 Thread Andreas Kemnade
If the main thread gets one PS AWAKE event and one PS SLEEP event in one iteration over event_fifo there will never be checks for commands to be processed, since psstate will always be PS_STATE_SLEEP or PS_STATE_PRE_SLEEP Signed-off-by: Andreas Kemnade --- drivers/net/wireless/libertas

Re: [PATCH RFC] wireless:libertas: enable auto deep sleep

2016-01-20 Thread Andreas Kemnade
On Wed, 20 Jan 2016 14:42:47 +0200 Kalle Valo wrote: > Andreas Kemnade writes: > > > Enables auto deep sleep whenever the interface is up and > > power managament is enabled, so there is also power management > > when there is no connection > > That reduces powe

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-06-29 Thread Andreas Kemnade
Hi, On Sun, 21 Jun 2020 00:39:04 +0200 Jonathan Neuschäfer wrote: > Hi, > > This patchset adds basic support for the embedded controller found on > older ebook reader boards designed by/with the ODM Netronix Inc.[1] and > sold by Kobo or Tolino, for example the Kobo Aura and the Tolino Shine. >

Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-10-06 Thread Andreas Kemnade
On Thu, 1 Oct 2020 21:07:51 -0700 Guenter Roeck wrote: > On 10/1/20 3:22 PM, Andreas Kemnade wrote: > > On Wed, 30 Sep 2020 22:00:09 +0200 > > Arnd Bergmann wrote: > > > >> On Wed, Sep 30, 2020 at 6:44 PM Guenter Roeck wrote: > >>> > >>

Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-10-01 Thread Andreas Kemnade
On Wed, 30 Sep 2020 22:00:09 +0200 Arnd Bergmann wrote: > On Wed, Sep 30, 2020 at 6:44 PM Guenter Roeck wrote: > > > > On Wed, Sep 30, 2020 at 10:54:42AM +0200, Andreas Kemnade wrote: > > > Hi, > > > > > > after the $subject patch I get lots of error

Re: [PATCHv1] power: supply: document current direction

2020-10-02 Thread Andreas Kemnade
On Thu, 27 Aug 2020 16:02:48 +0200 Sebastian Reichel wrote: > Currently the sign for CURRENT_NOW and CURRENT_AVG is a bit > of a mess. There are basically 3 different ways battery fuel > gauges report the current: > > 1. uses negative values for discharging and positive values >for charging

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-25 Thread Andreas Kemnade
On Sun, 16 Aug 2020 14:54:41 +0200 Jonathan Neuschäfer wrote: > On Sat, Aug 15, 2020 at 09:33:36PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equippe

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Andreas Kemnade
On Wed, 26 Aug 2020 19:48:17 +0200 Sebastian Reichel wrote: > Hi, > > Driver looks mostly good. > > On Sat, Aug 15, 2020 at 06:56:09PM +0200, Andreas Kemnade wrote: > > [...] > > +static int rn5t618_battery_current_now(stru

[PATCH v2 0/2] ARM: dts: add Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
This adds a device tree for the Tolino Shine 2 HD Ebook reader. It is equipped with an i.MX6SL SoC. Except for backlight (via an EC) and the EPD, drivers are available and therefore things are defined in the dts. Andreas Kemnade (2): dt-bindings: arm: fsl: add compatible string for Tolino

[PATCH v2 1/2] dt-bindings: arm: fsl: add compatible string for Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
This adds a compatible string for the Tolino Shine 2 HD eBook reader. Signed-off-by: Andreas Kemnade Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation

[PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
XEC driver) - EPD Not working due to unknown reasons: - deep sleep (echo standby >/sys/power/state works), wakeup fails when imx_gpc_pre_suspend(true) was called. Signed-off-by: Andreas Kemnade --- Changes in v2: - better comments about internals - avoid confusion about polarity of wi

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Andreas Kemnade
Hi, On Wed, 26 Aug 2020 23:59:50 +0200 Sebastian Reichel wrote: > Hi, > > On Wed, Aug 26, 2020 at 08:28:34PM +0200, Andreas Kemnade wrote: > > On Wed, 26 Aug 2020 19:48:17 +0200 > > Sebastian Reichel wrote: > > > On Sat, Aug 15, 2020 at 06:56:09P

[REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-09-30 Thread Andreas Kemnade
Hi, after the $subject patch I get lots of errors like this: [ 120.378614] applesmc: send_byte(0x00, 0x0300) fail: 0x40 [ 120.378621] applesmc: LKSB: write data fail [ 120.512782] applesmc: send_byte(0x00, 0x0300) fail: 0x40 [ 120.512787] applesmc: LKSB: write data fail CPU sticks at low spee

[PATCH v2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-27 Thread Andreas Kemnade
which disable the fuel gauge at shutdown. If a kernel is booted without fuel gauge support, after such a driver has been used, the fuel gauge will stay off and decalibrate. If this driver is used after that, it might display wrong values for charge level. Signed-off-by: Andreas Kemnade --- Changes

[PATCH v3] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-28 Thread Andreas Kemnade
which disable the fuel gauge at shutdown. If a kernel is booted without fuel gauge support, after such a driver has been used, the fuel gauge will stay off and decalibrate. If this driver is used after that, it might display wrong values for charge level. Signed-off-by: Andreas Kemnade --- Changes

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-23 Thread Andreas Kemnade
On Sun, 23 Aug 2020 09:42:31 +0800 Shawn Guo wrote: > On Sat, Aug 15, 2020 at 09:33:36PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equippe

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-16 Thread Andreas Kemnade
Hi, On Sun, 16 Aug 2020 17:57:51 +0200 Jonathan Neuschäfer wrote: > On Sun, Aug 16, 2020 at 04:50:58PM +0200, Andreas Kemnade wrote: > > Hi, > > > > Seems that we have different hardware, so the first question is > > first the most interesting thing: how much

Re: [PATCH V2] ARM: dts: omap3: Add cpu trips and cooling map for omap34/36 families

2020-08-17 Thread Andreas Kemnade
On Mon, 17 Aug 2020 08:39:31 -0500 Adam Ford wrote: > The OMAP3530, OMAP3630, and DM3730 all show thresholds of 90C and 105C > depending on commercial or industrial temperature ratings. > > This patch expands the thermal information to include the limits of 90 > and 105C for alert and critical.

Re: [PATCH V2] ARM: dts: omap3: Add cpu trips and cooling map for omap34/36 families

2020-08-17 Thread Andreas Kemnade
On Mon, 17 Aug 2020 15:02:27 -0500 Adam Ford wrote: > On Mon, Aug 17, 2020 at 2:59 PM Andreas Kemnade wrote: > > > > On Mon, 17 Aug 2020 08:39:31 -0500 > > Adam Ford wrote: > > > > > The OMAP3530, OMAP3630, and DM3730 all show thresholds of 90C and 1

Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-31 Thread Andreas Kemnade
Hi, On Thu, 27 Aug 2020 20:33:23 +0200 Jonathan Neuschäfer wrote: > On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equippe

[PATCH] dt-bindings: mfd: Convert rn5t618 to json-schema

2020-09-08 Thread Andreas Kemnade
Convert the RN5T618 binding to DT schema format. Also clearly state which regulators are available. Signed-off-by: Andreas Kemnade --- I have noted myself here as maintainer because I wrote most of the code of the several subdevices, although not of the .txt-binding. Due to its .txt-format

[PATCH 1/2] dt-bindings: arm: fsl: add compatible string for Tolino Shine 2 HD

2020-08-15 Thread Andreas Kemnade
This adds a compatible string for the Tolino Shine 2 HD eBook reader. Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm

[PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-15 Thread Andreas Kemnade
XEC driver) - EPD Not working due to unknown reasons: - deep sleep (echo standby >/sys/power/state works), wakeup fails when imx_gpc_pre_suspend(true) was called. Signed-off-by: Andreas Kemnade --- Reason for RFC: The suspend trouble might be caused by bad devicetree. But as the devicetr

[PATCH 0/2] ARM: dts: add Tolino Shine 2 HD

2020-08-15 Thread Andreas Kemnade
This adds a device tree for the Tolino Shine 2 HD Ebook reader. It is equipped with an i.MX6SL SoC. Except for backlight (via an EC) and the EPD, drivers are available and therefore things are defined in the dts. Andreas Kemnade (2): dt-bindings: arm: fsl: add compatible string for Tolino

[PATCH 0/2] power: supply: RN5T618/RC5T619

2020-08-15 Thread Andreas Kemnade
This series adds support for the RN5T618/RC5T619 charger and fuel gauge. Battery and input power status can be read. Andreas Kemnade (2): power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge mfd: rn5t618: Add a power supply subdevice drivers/mfd/rn5t618.c

[PATCH 2/2] mfd: rn5t618: Add a power supply subdevice

2020-08-15 Thread Andreas Kemnade
The RN5T618 and RC5T619 both have a charger and a fuel gauge, so add a subdevice for it. According to drivers in the wild, things should be at least similar, but since it is not tested, add it only to the RC5T619. Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 1 + 1 file changed, 1

[PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-15 Thread Andreas Kemnade
which disable the fuel gauge at shutdown. If a kernel is booted without fuel gauge support, after such a driver has been used, the fuel gauge will stay off and decalibrate. If this driver is used after that, it might display wrong values for charge level. Signed-off-by: Andreas Kemnade --- drivers

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-16 Thread Andreas Kemnade
Hi, Seems that we have different hardware, so the first question is first the most interesting thing: how much does the hw actually differ, especially do they require different device trees? Can you provide me a photo of your hardware? Or is it a Shine 3? Mine is at https://misc.andi.de1.cc/toli

Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-11-04 Thread Andreas Kemnade
On Tue, 3 Nov 2020 16:56:32 +1100 Brad Campbell wrote: > On 3/11/20 10:56 am, Brad Campbell wrote: > > > > > I've examined the code in VirtualSMC and I'm not convinced we were not > > waiting on the wrong bits. > > > > #define SMC_STATUS_AWAITING_DATA  BIT0  ///< Ready to read data. > > #defi

Re: [PATCH] applesmc: Re-work SMC comms v2

2020-11-05 Thread Andreas Kemnade
ges in the aforementioned commit. > > This patch re-factors the SMC communication to remove the timing > dependencies and restore function with the changes previously committed. > > v2 : Address logic and coding style > > Reported-by: Andreas Kemnade > Fixes: fff2d0f701e6

Re: [PATCH] applesmc: Re-work SMC comms v2

2020-11-05 Thread Andreas Kemnade
On Thu, 5 Nov 2020 08:56:04 +0100 Henrik Rydberg wrote: > Hi Brad, > > Great to see this effort, it is certainly an area which could be > improved. After having seen several generations of Macbooks while > modifying much of that code, it became clear that the SMC communication > got refreshed

[REGRESSION] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER

2020-11-05 Thread Andreas Kemnade
Hi, On the GTA04 (DM3730, devicetree omap3-gta04*) I get my console flooded up with the following: [ 24.517211] cpu cpu0: multiple regulators are not supported [ 24.523040] cpufreq: __target_index: Failed to change cpu frequency: -22 [ 24.537231] [ cut here ] [ 24.5

Re: [PATCH v3] applesmc: Re-work SMC comms

2020-11-09 Thread Andreas Kemnade
factors the SMC communication to remove the timing > dependencies and restore function with the changes previously > committed. > > Tested on : MacbookAir6,2 MacBookPro11,1 iMac12,2, MacBookAir1,1, > MacBookAir3,1 > > Fixes: fff2d0f701e6 ("hwmon: (applesmc) avoid overlong

[PATCH v2] mfd: rn5t618: Make restart handler atomic safe

2020-07-21 Thread Andreas Kemnade
ack(0xd80a5fa8 to 0xd80a5ff0) [ 165.388420] 5fa0: 00406948 fee1dead 28121969 01234567 73299b00 [ 165.396602] 5fc0: 00406948 0058 be91abc8 be91ab60 004056f8 [ 165.404781] 5fe0: 0058 be91aabc b6ed4d45 b6e56746 Signed-off-by: Andreas Kemnade

[PATCH] mfd: rn5t618: Fix caching of battery related registers

2020-07-17 Thread Andreas Kemnade
Battery status changes dynamically, so the corresponding registers need to be considered volatile. Affected registers are: - fuel gauge - battery status - battery interrupt Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH] mfd: rn5t618: Make restart handler atomic safe

2020-07-18 Thread Andreas Kemnade
ack(0xd80a5fa8 to 0xd80a5ff0) [ 165.388420] 5fa0: 00406948 fee1dead 28121969 01234567 73299b00 [ 165.396602] 5fc0: 00406948 0058 be91abc8 be91ab60 004056f8 [ 165.404781] 5fe0: 0058 be91aabc b6ed4d45 b6e56746 Signed-off-by: Andreas Kemnade

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-07-06 Thread Andreas Kemnade
On Sat, 4 Jul 2020 22:58:08 +0200 Jonathan Neuschäfer wrote: > On Tue, Jun 30, 2020 at 10:14:47PM +0200, Andreas Kemnade wrote: > > On Tue, 30 Jun 2020 09:15:23 +0200 > > Jonathan Neuschäfer wrote: > > > > > On Tue, Jun 30, 2020 at 08:40:51A

Re: [PATCH 3/3] ARM: imx_v6_v7_defconfig: Build in CONFIG_GPIO_MXC by default

2020-07-10 Thread Andreas Kemnade
Hi, On Wed, 8 Jul 2020 07:25:23 +0800 Anson Huang wrote: > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC > as built-in manually. > > Signed-off-by: Anson Huang > --- > arch/arm/configs/imx_v6_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > shouldn't this be done als

Re: [PATCH V2 1/2] thermal: ti-soc-thermal: Enable addition power management

2020-09-10 Thread Andreas Kemnade
On Wed, 19 Aug 2020 07:59:23 -0500 Adam Ford wrote: > The bandgap sensor can be idled when the processor is too, but it > isn't currently being done, so the power consumption of OMAP3 > boards can elevated if the bangap sensor is enabled. > > This patch attempts to use some additional power mana

Re: [PATCH V2 1/2] thermal: ti-soc-thermal: Enable addition power management

2020-09-10 Thread Andreas Kemnade
On Thu, 10 Sep 2020 14:33:13 -0500 Adam Ford wrote: > On Thu, Sep 10, 2020 at 2:14 PM Daniel Lezcano > wrote: > > > On 10/09/2020 20:01, Andreas Kemnade wrote: > > > On Wed, 19 Aug 2020 07:59:23 -0500 > > > Adam Ford wrote: > > > > > >&

[PATCH] omap3: enable off mode automatically

2020-09-10 Thread Andreas Kemnade
an indicator that the board is wired correctly for off mode. Signed-off-by: Andreas Kemnade --- An earlier version of this patch was here: https://patchwork.kernel.org/patch/10794121/ A config option was used instead of the suggested devicetree check. arch/arm/mach-omap2/pm.h | 4 arch

[PATCH v2] omap3: enable off mode automatically

2020-09-11 Thread Andreas Kemnade
an indicator that the board is wired correctly for off mode. Signed-off-by: Andreas Kemnade --- An earlier version of this patch was here: https://patchwork.kernel.org/patch/10794121/ A config option was used instead of the suggested devicetree check. Changes in v2: - fix compile without

Re: [PATCH] omap3: enable off mode automatically

2020-09-11 Thread Andreas Kemnade
On Fri, 11 Sep 2020 13:33:37 +0300 Tony Lindgren wrote: > * Andreas Kemnade [200911 09:50]: > > --- a/arch/arm/mach-omap2/pm.h > > +++ b/arch/arm/mach-omap2/pm.h > > @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void) > > extern int omap3_pm_get_suspend_stat

Re: [PATCH v2 04/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC

2020-09-14 Thread Andreas Kemnade
Hi, On Mon, 14 Sep 2020 18:54:43 -0600 Rob Herring wrote: > On Sat, Sep 05, 2020 at 03:32:24PM +0200, Jonathan Neuschäfer wrote: > > The Netronix embedded controller as found in Kobo Aura and Tolino Shine > > supports one PWM channel, which is used to control the frontlight > > brightness on the

Re: [PATCH v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2020-09-23 Thread Andreas Kemnade
On Tue, 22 Sep 2020 19:40:41 -0600 Rob Herring wrote: > On Wed, Sep 16, 2020 at 08:17:57AM +0200, Andreas Kemnade wrote: > > Convert the RN5T618 binding to DT schema format. Also > > clearly state which regulators are available. > > > > Signed-off-by: Andreas Kemnade

Re: [PATCH v2] omap3: enable off mode automatically

2020-09-24 Thread Andreas Kemnade
On Fri, 11 Sep 2020 18:12:09 +0200 Andreas Kemnade wrote: > Enabling off mode was only reachable deeply hidden > in the debugfs. As powersaving is an important feature, > move the option out of its shady place. > The debugfs file can still be used to override the default. > >

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-24 Thread Andreas Kemnade
On Thu, 24 Sep 2020 21:24:53 +0200 Jonathan Neuschäfer wrote: > With this driver, mainline Linux can keep its time and date in sync with > the vendor kernel. > > Advanced functionality like alarm and automatic power-on is not yet > supported. > > Signed-off-by: Jonathan Neuschäfer > --- > > v

<    1   2   3   4   >