Re: [PATCH] regulator: ti-abb: Fix array out of bound read access on the first transition

2020-11-18 Thread Andreas Kemnade
Hi, On Wed, 18 Nov 2020 08:50:09 -0600 Nishanth Menon wrote: > At the start of driver initialization, we do not know what bias > setting the bootloader has configured the system for and we only know > for certain the very first time we do a transition. > > However, since the initial value of th

Re: [BUG] SPI broken for SPI based panel drivers

2020-12-09 Thread Andreas Kemnade
Hi, On Sat, 5 Dec 2020 08:04:25 +0100 "H. Nikolaus Schaller" wrote: > Hi Linus, > > > Am 05.12.2020 um 01:25 schrieb Linus Walleij : > > > > On Fri, Dec 4, 2020 at 5:52 PM H. Nikolaus Schaller > > wrote: > > > >> But what I don't know is if I can omit spi-cs-high and have to keep > >> ACT

Re: [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors

2020-12-09 Thread Andreas Kemnade
On Wed, 9 Dec 2020 14:04:26 -0500 Sven Van Asbroeck wrote: > On Wed, Dec 9, 2020 at 1:16 PM H. Nikolaus Schaller > wrote: > > > > This is also what made me wonder if that is really intended because then > > the whole discussion about the cs-gpio-flags and inversion and the fixes > > would not h

[PATCH] ARM: dts: omap3-gta04: fix twl4030-power settings

2020-11-30 Thread Andreas Kemnade
Things are wired up for powersaving, so lets use the corresponding compatible and also update a deprecated property name. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/omap3-gta04

[PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-04 Thread Andreas Kemnade
t PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.4") Signed-off-by: Andreas Kemnade --- arch/arm/mach-omap2/omap_device.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index fc7bb2c

[PATCH] power: bq27xxx: fix polarity of current_now

2020-12-04 Thread Andreas Kemnade
current_now has to be negative during discharging and positive during charging, the behavior seen is the other way round. Tested on GTA04 with Openmoko battery Signed-off-by: Andreas Kemnade --- drivers/power/supply/bq27xxx_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-04 Thread Andreas Kemnade
On Fri, 4 Dec 2020 07:44:33 -0800 Doug Anderson wrote: > Hi, > > On Fri, Dec 4, 2020 at 1:55 AM Andreas Kemnade wrote: > > > > On the GTA04A5 od->_driver_status was not set to BUS_NOTIFY_BIND_DRIVER > > during probe of the second mmc used for wifi. Therefore >

Re: [Letux-kernel] [BUG] SPI broken for SPI based panel drivers

2020-12-01 Thread Andreas Kemnade
On Tue, 1 Dec 2020 11:10:49 -0500 Sven Van Asbroeck wrote: > Nikolaus, > > On Tue, Dec 1, 2020 at 9:38 AM H. Nikolaus Schaller > wrote: > > > > Let's work on a fix for the fix now. > > > > Are you quite sure the chip-select of the tpo,td028ttec1 panel > is active-high? A quick google produc

[PATCH] ARM: omap2plus_defconfig: enable SPI GPIO

2020-12-01 Thread Andreas Kemnade
GTA04 uses that for controlling the td028ttec1 panel. So for easier testing/bisecting it is useful to have it enabled in the defconfig. Signed-off-by: Andreas Kemnade --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs

[PATCH] ARM: imx_v6_v7_defconfig: enable power driver of RN5T618 PMIC family

2020-12-01 Thread Andreas Kemnade
There is a driver now for the power supply and fuel gauge functionality of that chip family, so enable them, since they are used by various i.MX6 boards, especially ebook-readers. Signed-off-by: Andreas Kemnade --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade Reviewed-by: Jonathan Neuschäfer --- Changes in v3: - remove have_rtc variable - rename subdevices again Changes in v2: - more comments about stacking regmap construction - fix accidential line removal - better naming for

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
On Sat, 13 Mar 2021 12:17:34 +0100 Jonathan Neuschäfer wrote: > On Wed, Mar 10, 2021 at 09:55:45AM +, Lee Jones wrote: > > On Mon, 08 Mar 2021, Andreas Kemnade wrote: > [...] > > > -static const struct mfd_cell ntxec_subdevices[] = { > > > +static cons

[PATCH] mfd: rn5t618: Do not cache various USB related registers

2021-03-14 Thread Andreas Kemnade
These register get reset to their OTP defaults after USB plugging. And while at it, also add a missing register for detecting the charger type. Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 3 +++ include/linux/mfd/rn5t618.h | 1 + 2 files changed, 4 insertions(+) diff --git

Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Andreas Kemnade
On Mon, 15 Mar 2021 08:12:31 + Lee Jones wrote: [...] > > static int ntxec_probe(struct i2c_client *client) > > { > > struct ntxec *ec; > > unsigned int version; > > int res; > > + const struct mfd_cell *subdevs = ntxec_subdev; > > + size_t n_subdevs = ARRAY_SIZE(ntxec_subde

[PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade --- drivers/mfd/ntxec.c | 57 --- include/linux/mfd/ntxec.h | 1 + 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c index

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 20:14:46 +0100 Jonathan Neuschäfer wrote: > Hi, > > (Cc'ing Mark Brown because of the regmap related questions) > > On Sat, Mar 06, 2021 at 07:13:14PM +0100, Andreas Kemnade wrote: > > Add the version of the EC in the Tolino Shine 2 HD > > to

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 21:19:38 +0100 Jonathan Neuschäfer wrote: [...] > > > > + case NTXEC_VERSION_TOLINO_SHINE2: > > > > + has_rtc = false; > > > > + ec->regmap = devm_regmap_init(ec->dev, NULL, > > > > + ec->regmap, > >

[PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-08 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade --- Changes in v2: - more comments about stacking regmap construction - fix accidential line removal - better naming for subdevices drivers/mfd/ntxec.c | 61 +-- include/linux/mfd

Re: [Letux-kernel] BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC

2021-02-06 Thread Andreas Kemnade
On Fri, 5 Feb 2021 16:10:18 +0100 Paul Kocialkowski wrote: > Hey, > > On Tue 02 Feb 21, 16:07, H. Nikolaus Schaller wrote: > > Hi Paul, > > > > > Am 02.02.2021 um 14:42 schrieb Paul Kocialkowski > > > : > > > > > > Hi Nikolaus, > > > > > > On Tue 02 Feb 21, 11:50, H. Nikolaus Schaller wrot

Re: [PATCH] dts: ARM: add kobo glo hd ebook reader

2021-01-26 Thread Andreas Kemnade
Hi, On Tue, 26 Jan 2021 18:31:31 +0100 Armin Preiml wrote: > This patch adds basic support for the kobo glo hd reader. It defines CPU, > memory, UART and storage.Also add pin control settings for i2c and sdhc. > > All values where extracted from the vendor kernel and u-boot sources. > > Sign

Re: [PATCH] dts: ARM: add kobo glo hd ebook reader

2021-01-26 Thread Andreas Kemnade
[resent with some more complete address list, get_maintainer.pl provides more] Hi, On Tue, 26 Jan 2021 18:31:31 +0100 Armin Preiml wrote: > This patch adds basic support for the kobo glo hd reader. It defines CPU, > memory, UART and storage.Also add pin control settings for i2c and sdhc. > >

[PATCH] regulator: core: avoid error messages for deferred probing

2021-01-25 Thread Andreas Kemnade
by DCDC1 [3.877211] vddsoc: bypassed regulator has no supply! [3.882538] vddsoc: failed to get the current voltage: -EPROBE_DEFER [3.888975] vddsoc: supplied by DCDC1 Handle such issues silently. Signed-off-by: Andreas Kemnade --- drivers/regulator/core.c | 8 +++- 1 file

[PATCH] ARM: dts: imx6sl-tolino-shine2hd: Add Netronix embedded controller

2021-01-25 Thread Andreas Kemnade
For now, the driver detects an incompatible version, but since that can be handled by auto-detection, add the controller to the devicetree now. Only PWM seems to be available, there is no RTC in that controller. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 7

Re: [Gta04-owner] [PATCH 10/13] twl4030_charger: add software controlled linear charging mode.

2015-11-24 Thread Andreas Kemnade
mode is still automatically done, but end of charge due to low current not. Note: If linear charging mode is used there should be some method of stopping charging automatically. It is not a so time-critical, but it is the wrong setting for leaving a charger connected for se

Re: [Gta04-owner] [PATCH 10/13] twl4030_charger: add software controlled linear charging mode.

2015-10-29 Thread Andreas Kemnade
tics of a bicycle as a power source are. - the amount of current available changes - 500mA at around 17km/h - you cannot destroy it by electrically overloading If the current is set to e.g. 500mA and that linear charging mode is enabled, the battery gets the maximum current available (upto 500mA) regardless of the speed which is often changing. Regards, Andreas Kemnade signature.asc Description: PGP signature

Re: [Gta04-owner] [PATCH 0/4] UART slave device support - version 4

2016-01-22 Thread Andreas Kemnade
On Fri, 22 Jan 2016 20:12:29 + One Thousand Gnomes wrote: > > I would have expected that the main (and IMO sufficient) reason why > > the kernel should do it is because the particular bus used to connect > > a BT chip to the CPU is a hw detail that a kernel that does its job > > should keep t

[PATCH] omap_hdq: fix usecount handling

2016-01-04 Thread Andreas Kemnade
hdq_usecount was set to zero after a successful read, so omap_hdq_put could not properly free resources which leads e.g. to increasing usecounts in lsmod output Signed-off-by: Andreas Kemnade --- drivers/w1/masters/omap_hdq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/w1/masters

[PATCH] ARM: dts: omap3-gta04: declare backlight in lcd node

2019-02-11 Thread Andreas Kemnade
The lcd display of the gta04 has a backlight but the backlight was not referenced in the lcd node, so screen blanking did not turn off the backlight. Fix that. Signed-off-by: Andreas Kemnade --- the backlight property for the driver was accepted here: https://lore.kernel.org/lkml/a54e7427-ff84

Re: [Letux-kernel] [RFC v2 1/3] cpufreq: ti-cpufreq: add support for omap34xx and omap36xx

2019-09-07 Thread Andreas Kemnade
On Fri, 6 Sep 2019 22:46:49 +0200 "H. Nikolaus Schaller" wrote: > Hi, > > > Am 06.09.2019 um 05:01 schrieb Viresh Kumar : > > > > On 05-09-19, 07:32, Tony Lindgren wrote: > >> * H. Nikolaus Schaller [190904 08:54]: > >>> This adds code and tables to read the silicon revision and > >>> eFus

[PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-08 Thread Andreas Kemnade
add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade --- .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree

[PATCH 0/2] backlight_lm3630a: add enable_gpios property

2019-09-08 Thread Andreas Kemnade
To be able to handle the HWEN pin of the lm3630a, add an enable gpio to the driver and a property. Tested on Kobo Clara HD Andreas Kemnade (2): backlight: lm3630a: add an enable gpio for the HWEN pin dt-bindings: backlight: lm3630a: add enable_gpios .../leds/backlight/lm3630a

[PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-08 Thread Andreas Kemnade
For now just enable it in the probe function to allow i2c access and disable it on remove. Disabling also means resetting the register values to default. Tested on Kobo Clara HD. Signed-off-by: Andreas Kemnade --- drivers/video/backlight/lm3630a_bl.c | 18 ++ 1 file changed, 18

Re: [PATCH v2] regulator: twl: voltage lists for vdd1/2 on twl4030

2019-09-09 Thread Andreas Kemnade
uot;) > > > Cc: sta...@vger.kernel.org > > > Signed-off-by: Andreas Kemnade > > > > Tested-by: Adam Ford #logicpd-torpedo-37xx-devkit > > > > I am not sure who the right maintainer is, but as of today, cpufreq > for users of twl4030 on 5.3-R

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

2019-08-30 Thread Andreas Kemnade
Hi, On Mon, 5 Aug 2019 12:29:19 +0200 Linus Walleij wrote: > On Fri, Jul 26, 2019 at 12:43 AM Rob Herring wrote: > > On Thu, Jul 25, 2019 at 12:23 AM H. Nikolaus Schaller > > wrote: > > > > I tried to convince Linus that this is the right way but he convinced > > > me that a fix that handl

[PATCH v2] regulator: twl: voltage lists for vdd1/2 on twl4030

2019-08-14 Thread Andreas Kemnade
ed_voltage") Cc: sta...@vger.kernel.org Signed-off-by: Andreas Kemnade --- resent because it was rejected by mailing lists, due to technical issues, sorry for the noise. changes in v2: using a proper voltage list instead of misusing the continuous flag subject was regulator: twl: mark vdd

[PATCH] gpio: of: fix Freescale SPI CS quirk handling

2019-08-16 Thread Andreas Kemnade
sion by checking for -EPROBE_DEFER. Fixes: e3023bf80639 ("gpio: of: Handle the Freescale SPI CS") Suggested-by: H. Nikolaus Schaller Signed-off-by: Andreas Kemnade --- drivers/gpio/gpiolib-of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-of.c b/d

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-27 Thread Andreas Kemnade
Hi Marco, On Fri, 27 Sep 2019 11:47:21 +0200 Marco Felsch wrote: > Hi Andreas, > > thanks for the patch. > thanks for the quick review. Most of your comments are clear. [...] > > + wifi_pwrseq: wifi_pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + post-power-on-del

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-30 Thread Andreas Kemnade
On Mon, 30 Sep 2019 10:27:15 +0200 Marco Felsch wrote: [..] > > so you disagree with this pattern: > > in .dtsi > > some_device { > >pinctrl-0 = <&pinctrl_some_device>; > > }; > > > > and in .dts (one I sent with this patch series and the tolino/mx6sl one > > is not ready-cooked yet, will

[PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file

2019-09-30 Thread Andreas Kemnade
PMIC (the kernel misses support for rtc and charger subdevices). - Backlight via lm3630a - Wifi sdio chip detection (mmc-powerseq and stuff) It is based on vendor kernel but heavily reworked due to many changed bindings. Signed-off-by: Andreas Kemnade --- Changes in v2: - reordered, was 1/3

[PATCH v2 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD

2019-09-30 Thread Andreas Kemnade
This adds a devicetree for the Kobo Clara HD Ebook reader. It is on based on boards called "e60k02". It is equipped with an imx6sll SoC. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx6sll-kobo-clarahd

[PATCH v2 0/3] dts: ARM: add Kobo Clara HD eBook reader

2019-09-30 Thread Andreas Kemnade
-clara/kernel.tar.bz2 but things need to be heavily reworked due to incompatible bindings and to prepare for Tolino Shine 3 Changes in v2: - reordered patches - various cleanups as suggested by Marco Felsch Andreas Kemnade (3): dt-bindings: arm: fsl: add compatible string for Kobo Clara HD ARM

[PATCH v2 1/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD

2019-09-30 Thread Andreas Kemnade
This adds a compatible string for the Kobo Clara HD eBook reader. Signed-off-by: Andreas Kemnade --- Changes in v2: reordered, was 2/3 Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b

Re: [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-09 Thread Andreas Kemnade
nt things on the i2c busses without proper bindings. That might help to find allies. I will send a v3 with correct memory, better name for GLED and the above-mentioned comments. Regards, Andreas > A few comments and questions below. > > On Mon, Sep 30, 2019 at 09:43:31PM +0200, And

Re: [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-06 Thread Andreas Kemnade
Hi Jonathan, On Mon, 7 Oct 2019 00:38:48 +0200 Jonathan Neuschäfer wrote: > Thanks for CCing me on this patchset. Nice to see more e-book reader > related work! > > A few comments and questions below. > > On Mon, Sep 30, 2019 at 09:43:31PM +0200, Andreas Kemnade wrote: >

Re: [PATCH] drm: panels: fix spi aliases of former omap panels

2019-10-07 Thread Andreas Kemnade
On Mon, 7 Oct 2019 19:04:46 +0200 Sebastian Reichel wrote: > Hi, > > On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote: > > When the panels were moved from omap/displays/ to panel/ > > omapdss prefix was stripped, which cause spi modalias > > to no

[PATCH 2/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD

2019-09-26 Thread Andreas Kemnade
This adds a compatible string fro the Kobo Clara HD eBook reader. Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm

[PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-26 Thread Andreas Kemnade
support for rtc and charger subdevices). - Backlight via lm3630a - Wifi sdio chip detection (mmc-powerseq and stuff) It is based on vendor kernel but heavily reworked due to many changed bindings. Signed-off-by: Andreas Kemnade --- backligt dependencies: module autoloading: https

[PATCH 0/3] dts: ARM: add Kobo Clara HD eBook reader

2019-09-26 Thread Andreas Kemnade
-clara/kernel.tar.bz2 but things need to be heavily reworked due to incompatible bindings and to prepare for Tolino Shine 3 Andreas Kemnade (3): ARM: dts: add Netronix E60K02 board common file dt-bindings: arm: fsl: add compatible string for Kobo Clara HD ARM: dts: imx: add devicetree for Kobo

[PATCH 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD

2019-09-26 Thread Andreas Kemnade
This adds a devicetree for the Kobo Clara HD Ebook reader. It is on based on boards called "e60k02". It is equipped with an imx6sll SoC. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx6sll-kobo-clarahd

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

2019-09-20 Thread Andreas Kemnade
On Fri, 20 Sep 2019 16:54:18 +0200 "H. Nikolaus Schaller" wrote: > > Am 20.09.2019 um 16:20 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [190920 09:19]: > >>> Am 20.09.2019 um 10:55 schrieb Linus Walleij : > >>> I suggest to go both way: > >>> apply this oneliner and tag for stable

[PATCH v3 0/3] dts: ARM: add Kobo Clara HD eBook reader

2019-10-10 Thread Andreas Kemnade
devices Andreas Kemnade (3): dt-bindings: arm: fsl: add compatible string for Kobo Clara HD ARM: dts: add Netronix E60K02 board common file ARM: dts: imx: add devicetree for Kobo Clara HD .../devicetree/bindings/arm/fsl.yaml | 1 + arch/arm/boot/dts/Makefile| 3

[PATCH v3 1/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD

2019-10-10 Thread Andreas Kemnade
This adds a compatible string for the Kobo Clara HD eBook reader. Signed-off-by: Andreas Kemnade --- Changes in v2: reordered, was 2/3 Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b

[PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-10 Thread Andreas Kemnade
PMIC (the kernel misses support for rtc and charger subdevices). - Backlight via lm3630a - Wifi sdio chip detection (mmc-powerseq and stuff) It is based on vendor kernel but heavily reworked due to many changed bindings. Signed-off-by: Andreas Kemnade --- Changes in v3: - better led name

[PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD

2019-10-10 Thread Andreas Kemnade
This adds a devicetree for the Kobo Clara HD Ebook reader. It is on based on boards called "e60k02". It is equipped with an imx6sll SoC. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx6sll-kobo-clarahd

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-11 Thread Andreas Kemnade
On Fri, 11 Oct 2019 08:56:09 +0200 Marco Felsch wrote: > Hi Andreas, > > On 19-10-10 21:23, Andreas Kemnade wrote: > > The Netronix board E60K02 can be found some several Ebook-Readers, > > at least the Kobo Clara HD and the Tolino Shine 3. The board > > is e

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-11 Thread Andreas Kemnade
On Fri, 11 Oct 2019 09:29:27 -0500 Rob Herring wrote: > On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote: > > On Fri, 11 Oct 2019 08:56:09 +0200 > > Marco Felsch wrote: > > > > > Hi Andreas, > > > > > > On 19-10-10 21:23, And

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-11 Thread Andreas Kemnade
On Fri, 11 Oct 2019 17:22:14 +0200 Marco Felsch wrote: > On 19-10-11 17:05, Andreas Kemnade wrote: > > On Fri, 11 Oct 2019 09:29:27 -0500 > > Rob Herring wrote: > > > > > On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote: > > &g

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-13 Thread Andreas Kemnade
On Fri, 11 Oct 2019 18:56:33 +0200 Marco Felsch wrote: > On 19-10-11 18:19, Andreas Kemnade wrote: > > On Fri, 11 Oct 2019 17:22:14 +0200 > > Marco Felsch wrote: > > > > > On 19-10-11 17:05, Andreas Kemnade wrote: > > > > On Fri, 11 Oct 2019

[PATCH 1/5] mfd: rn5t618: prepare for irq handling

2019-10-20 Thread Andreas Kemnade
rn5t618 currently lacks irq handling. To prepare implementation in a rn5t618-irq.c, move main file to rn5t618-core.c Signed-off-by: Andreas Kemnade --- drivers/mfd/Makefile | 2 ++ drivers/mfd/{rn5t618.c => rn5t618-core.c} | 0 2 files changed, 2 insertions(+) ren

[PATCH 3/5] mfd: rn5t618: add rtc related registers

2019-10-20 Thread Andreas Kemnade
Defines for some rtc related registers were missing, also they were not included in the volatile register list Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618-core.c | 2 ++ include/linux/mfd/rn5t618.h | 11 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/mfd

[PATCH 2/5] mfd: rn5t618: add irq support

2019-10-20 Thread Andreas Kemnade
This adds support for irq handling in the rc5t619 which is required for properly implementing subdevices like rtc. For now only definitions for the variant rc5t619 are included. Signed-off-by: Andreas Kemnade --- drivers/mfd/Kconfig | 1 + drivers/mfd/Makefile| 2 +- drivers

[PATCH 0/5] Add rtc support for rn5t618 mfd

2019-10-20 Thread Andreas Kemnade
. Andreas Kemnade (5): mfd: rn5t618: prepare for irq handling mfd: rn5t618: add irq support mfd: rn5t618: add rtc related registers mfd: rn5t618: add more subdevices rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver drivers/mfd/Kconfig | 1 + drivers/mfd/Makefile

[PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-20 Thread Andreas Kemnade
Add an RTC driver for the RTC device on Ricoh MFD rc5t619, which is implemented as a variant of rn5t618 Signed-off-by: Andreas Kemnade --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-rc5t619.c | 476 ++ 3

[PATCH 4/5] mfd: rn5t618: add more subdevices

2019-10-20 Thread Andreas Kemnade
The rc5t619 has a rtc which are missing in the rn5t618. Add it as subdevice to prepare for their implementation Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618-core.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rn5t618-core.c b/drivers/mfd

Re: [PATCH 2/5] mfd: rn5t618: add irq support

2019-10-21 Thread Andreas Kemnade
On Mon, 21 Oct 2019 11:07:10 +0200 Alexandre Belloni wrote: > Hi, > > On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote: > > +#if 0 > > +/* > > + * REVISIT when implementing charger: > > + * according to some other implementation it needs special treatment,

Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Andreas Kemnade
On Mon, 21 Oct 2019 15:50:28 +0200 Alexandre Belloni wrote: > On 21/10/2019 15:19:09+0200, Stefan Agner wrote: > > On 2019-10-21 07:41, Andreas Kemnade wrote: > > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619, > > > which is implemented as a variant of

Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Andreas Kemnade
Hi, On Mon, 21 Oct 2019 12:15:28 +0200 Alexandre Belloni wrote: > Hi, > > The subject line is weird, how is it related to rc5t583? > well, yes, rc5t583 driver source was opened next to the window where I wrote the commit message... > On 21/10/2019 07:41:04+0200, Andrea

Re: [PATCH v2 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-14 Thread Andreas Kemnade
Hi, On Fri, 8 Feb 2019 11:13:33 +0200 Tomi Valkeinen wrote: > On 05/02/2019 08:38, Andreas Kemnade wrote: > > This panel has a backlight, so add a property describing that and > > add the code to use that. > > This makes things like xset dpms force off > > also turn

Re: [PATCH v3 0/3] mach-omap2: handle autoidle denial

2019-02-09 Thread Andreas Kemnade
On Mon, 21 Jan 2019 11:58:03 -0800 Tony Lindgren wrote: > * Andreas Kemnade [190116 14:04]: > > On the gta04 with a dm3730 omap_hdq does not work properly when the > > device enters lower power states. Idling uart1 and 2 is enough > > to show up that problem, if ther

Re: [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-21 Thread Andreas Kemnade
Hi, On Mon, 21 Jan 2019 09:07:43 -0800 Tony Lindgren wrote: > * Tero Kristo [190121 07:13]: > > On 18/01/2019 21:45, Tony Lindgren wrote: > > > * Andreas Kemnade [190118 19:39]: > > > > Hi, > > > > > > > > On Fri, 1

Re: [PATCH 0/3] gnss: sirf: fixes and cleanup

2019-01-22 Thread Andreas Kemnade
Hi Johan, On Tue, 22 Jan 2019 18:22:52 +0100 Johan Hovold wrote: > These patches fixes an issue where the sirf wakeup interrupt was > prematurely enabled during probe. As Andreas suggested, we should also > make sure that the receiver is indeed suspended at probe (to avoid > wasting power until

[PATCH v2] arm: dts: gta04: add gps support

2019-01-29 Thread Andreas Kemnade
The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable which one is mounted so use the compatibility entry for w2sg0004 for all which will work for both. Signed-off-by: Andreas Kemnade --- Changes in v2: - some s/gps/gnss/ - not added vcc-supply because the regulator is not modelled in

[PATCH v3 0/6] gnss: sirf: add support for w2sg0004 + lna

2019-01-16 Thread Andreas Kemnade
- better regulator error handling - timeout logic cleaned up and problems documented - initial power off sorted out as a separate patch - renamed patch gnss: sirf: power on logic for devices without wakeup signal Andreas Kemnade (6): gnss: sirf: write data to gnss only when the gnss

[PATCH v3 5/6] gnss: sirf: add a separate supply for a lna

2019-01-16 Thread Andreas Kemnade
Devices might have a separate lna between antenna input of the gps chip and the antenna which might have a separate supply. Signed-off-by: Andreas Kemnade --- Changes in v3: - improved error checking - style cleanup Changes in v2: - handle lna also if there is no on-off gpio - rebase on

[PATCH v3 1/6] gnss: sirf: write data to gnss only when the gnss device is open

2019-01-16 Thread Andreas Kemnade
The api forbids writing data there otherwise. Prepare for the serdev_open()/close() being a part of sirf_set_active. Signed-off-by: Andreas Kemnade --- Changes in v3: - add more locking - style cleanup - mutex *not* renamed since we need a second one Changes in v2: - add locking drivers

[PATCH v3 3/6] gnss: sirf: add support for configurations without wakeup signal

2019-01-16 Thread Andreas Kemnade
Some Wi2Wi devices do not have a wakeup output, so device state can only be indirectly detected by looking whether there is communitcation over the serial lines. This approach requires a report cycle set to a low value to be reliable. Signed-off-by: Andreas Kemnade --- Changes in v3: - was 2/5

[PATCH v3 2/6] gnss: sirf: set power state initially off

2019-01-16 Thread Andreas Kemnade
justified Signed-off-by: Andreas Kemnade --- - was part of 2/5 in v2 drivers/gnss/sirf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c index b21e14351b82..c7706b91f6f0 100644 --- a/drivers/gnss/sirf.c +++ b/drivers/gnss/sirf.c @@ -367,6 +367,13

[PATCH v3 6/6] dt-bindings: gnss: add lna-supply property

2019-01-16 Thread Andreas Kemnade
Add lna-supply property. Signed-off-by: Andreas Kemnade --- Changes in v3: - moved to gnss.txt Documentation/devicetree/bindings/gnss/gnss.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gnss/gnss.txt b/Documentation/devicetree/bindings/gnss/gnss.txt

[PATCH v3 4/6] dt-bindings: gnss: add w2sg0004 compatible string

2019-01-16 Thread Andreas Kemnade
Add w2sg0004 compatible string since devices without wakeup pins are now supported. Signed-off-by: Andreas Kemnade Reviewed-by: Rob Herring Reviewed-by: Johan Hovold --- Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v3 1/3] clk: ti: add a usecount for autoidle

2019-01-16 Thread Andreas Kemnade
Multiple users might deny autoidle on a clock. So we should have some counting here, also according to the comment in _setup_iclk_autoidle(). Also setting autoidle regs is not atomic, so there is another reason for locking. Signed-off-by: Andreas Kemnade --- Change since v2: - rebase on top of

[PATCH v3 2/3] clk: ti: check clock type before doing autoidle ops

2019-01-16 Thread Andreas Kemnade
Code might use autoidle api with clocks not being omap2 clocks, so check if clock type is really omap2. Signed-off-by: Andreas Kemnade --- v3: replace CLK_IS_BASIC check New in v2 drivers/clk/ti/autoidle.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a

[PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-16 Thread Andreas Kemnade
_setup_iclk_autoidle. dss_ick is an example for that. Signed-off-by: Andreas Kemnade --- Comments to v1 to this patch were worked into a new 2/3 --- arch/arm/mach-omap2/omap_hwmod.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v3 0/3] mach-omap2: handle autoidle denial

2019-01-16 Thread Andreas Kemnade
of mutexes - invert counter logic - check whether clock type is basic Depends on: clk: ti: get rid of CLK_IS_BASIC Andreas Kemnade (3): clk: ti: add a usecount for autoidle clk: ti: check clock type before doing autoidle ops arm: omap_hwmod disable ick autoidling when a hwmod requires that

Re: [PATCH v2 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2019-01-13 Thread Andreas Kemnade
On Thu, 10 Jan 2019 13:02:28 +0100 Johan Hovold wrote: > On Sun, Dec 09, 2018 at 08:51:46PM +0100, Andreas Kemnade wrote: > > The api forbids writing data there otherwise. Prepare for the > > serdev_open()/close() being a part of runtime pm. > > > > Sig

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-14 Thread Andreas Kemnade
On Mon, 14 Jan 2019 11:51:29 +0100 Johan Hovold wrote: here is a second part of a reply. [...] > > > In pseudo code we have: > > > > > > activate: > > >- toggle on-off > > >- wait(data-received, ACTIVATE_TIMEOUT + REPORT_CYCLE) > > > - reception: success > > > > Note: we can

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-15 Thread Andreas Kemnade
On Mon, 14 Jan 2019 11:51:29 +0100 Johan Hovold wrote: > On Thu, Jan 10, 2019 at 11:02:23PM +0100, Andreas Kemnade wrote: > > Hi Johan, > > > > On Thu, 10 Jan 2019 13:10:38 +0100 > > Johan Hovold wrote: > > > > On Sun, Dec 09, 2018 at

Re: [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread Andreas Kemnade
Hi, On Fri, 18 Jan 2019 07:48:07 -0800 Tony Lindgren wrote: > Hi, > > * Andreas Kemnade [190116 22:04]: > > Deny autoidle for hwmods with the OCPIF_SWSUP_IDLE flag, > > that makes hwmods working properly which cannot handle > > autoidle properly in lower power

Re: [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread Andreas Kemnade
Hi, On Fri, 18 Jan 2019 10:36:30 -0800 Tony Lindgren wrote: [...] > til the next workaround. > > > That flags also causes the iclk being enabled/disabled > > manually. > > Yes but SWSUP_IDLE for the interface clock to me currently > just means: > > "manually enable and disable ocp interface

Re: [Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread Andreas Kemnade
On Fri, 18 Jan 2019 20:38:47 +0100 Andreas Kemnade wrote: > Hi, > > On Fri, 18 Jan 2019 10:36:30 -0800 > Tony Lindgren wrote: > > [...] > > til the next workaround. > > > > > That flags also causes the iclk being enabled/disabled > > > m

Re: [Letux-kernel] [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2019-01-18 Thread Andreas Kemnade
On Sat, 19 Jan 2019 12:09:48 +0530 "J, KEERTHY" wrote: > On 1/19/2019 1:18 AM, Tony Lindgren wrote: > > * Andreas Kemnade [190118 19:42]: > >> On Fri, 18 Jan 2019 20:38:47 +0100 > >> Andreas Kemnade wrote: > >> > >>> Hi, > >

[PATCH 2/2] dt-bindings: panel: td028ttec1: add backlight property

2019-01-19 Thread Andreas Kemnade
This add an additional backlight property as described in panel-common.txt Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1

[PATCH 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-01-19 Thread Andreas Kemnade
This panel has a backlight, so add a property describing that and add the code to use that. This makes things like xset dpms force off also turn off the backlight, so we do not need to rely on additional userspace programs to do that. Andreas Kemnade (2): drm/omap: panel-tpo-td028ttec1: add

[PATCH 1/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-01-19 Thread Andreas Kemnade
This panel has a backlight, so fetch it from devicetree using the as documented in panel-common.txt. It is implemented the same way as in panel-dpi.c This ensures the backlight is also disabled when the display is turned off like when doing xset dpms force off. Signed-off-by: Andreas Kemnade

Re: [PATCH 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-01 Thread Andreas Kemnade
ping On Sat, 19 Jan 2019 19:21:29 +0100 Andreas Kemnade wrote: > This panel has a backlight, so add a property describing that and > add the code to use that. > This makes things like xset dpms force off > also turn off the backlight, so we do not need to rely on additional > use

Re: [PATCH v3 2/2] arm: dts: gta04: add gps support

2019-02-01 Thread Andreas Kemnade
On Fri, 1 Feb 2019 11:04:16 +0100 Johan Hovold wrote: > On Thu, Jan 31, 2019 at 07:06:40PM +0100, Andreas Kemnade wrote: > > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable > > which one is mounted so use the compatibility entry for w2sg0004 > > for all whi

[PATCH] omap3: give off mode enable a more prominent place

2019-02-01 Thread Andreas Kemnade
Enabling off mode was only reachable deeply hidden in the debugfs. As powersaving is an important feature, move the option out of its shady place. The debugfs file can still be used to override the default. Signed-off-by: Andreas Kemnade --- arch/arm/mach-omap2/Kconfig| 8 arch/arm

Re: [PATCH] omap3: give off mode enable a more prominent place

2019-02-01 Thread Andreas Kemnade
On Sat, 2 Feb 2019 06:58:27 +0100 Andreas Kemnade wrote: > Enabling off mode was only reachable deeply hidden > in the debugfs. As powersaving is an important feature, > move the option out of its shady place. > The debugfs file can still be used to override the default. oops, th

Re: [PATCH 1/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-04 Thread Andreas Kemnade
Hi, On Mon, 4 Feb 2019 10:13:46 +0200 Tomi Valkeinen wrote: > Hi, > > On 19/01/2019 20:21, Andreas Kemnade wrote: > > This panel has a backlight, so fetch it from devicetree using the > > as documented in panel-common.txt. It is implemented the same way as in > >

Re: [PATCH] omap3: give off mode enable a more prominent place

2019-02-04 Thread Andreas Kemnade
On Mon, 4 Feb 2019 07:56:04 -0800 Tony Lindgren wrote: > * Andreas Kemnade [190202 06:01]: > > Enabling off mode was only reachable deeply hidden > > in the debugfs. As powersaving is an important feature, > > move the option out of its shady place. > > How abou

[PATCH v4 3/5] dt-bindings: gnss: add w2sg0004 compatible string

2019-01-23 Thread Andreas Kemnade
Add w2sg0004 compatible string since devices without wakeup pins are now supported. Signed-off-by: Andreas Kemnade Reviewed-by: Rob Herring Reviewed-by: Johan Hovold --- Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

<    1   2   3   4   >