Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-08-31 Thread Andreas Dannenberg
> > + chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); > > > + if (!chip) > > > + return -ENOMEM; > > > + > > > + chip->client = client; > > > + if (client->dev.platform_data) > > > + chip->pdat

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-01 Thread Andreas Dannenberg
On Tue, Sep 01, 2015 at 06:20:54PM +, Pallala, Ramakrishna wrote: > Hi Andreas, > I will resubmit the patch by this weekend. I Hope this works for you. > > Thanks, > Ram Sounds good, thanks. -- Andreas Dannenberg Texas Instruments Inc -- To unsubscribe from this list

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-08 Thread Andreas Dannenberg
the default being the charger properties being made read-only) - this way giving the best of both worlds. However then when I updated the bq24157_charger.c driver I ended up not really needing and implementing this feature. Out of curiosity, if it against best-practice to expose non hardware p

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-09 Thread Andreas Dannenberg
On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: > On 09.09.2015 11:26, Andreas Dannenberg wrote: > > Krzysztof, good observation! In bq2425x_charger.c (formerly known as > > bq24257_charger.c :) that I worked on the unit used was uA. At that time > > I

[PATCH] ASoC: pcm186x: Fix device reset-registers trigger value

2018-11-15 Thread Andreas Dannenberg
ne Le Provost Signed-off-by: Andreas Dannenberg --- sound/soc/codecs/pcm186x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm186x.h b/sound/soc/codecs/pcm186x.h index 2c6ba55bf394..bb3f0c42a1cd 100644 --- a/sound/soc/codecs/pcm186x.h +++ b/sound/soc/c

Re: [PATCH 0/8] Add support for additional bq27xxx devices

2015-07-23 Thread Andreas Dannenberg
lidation after all I might be able to broaden the scope of my work. This being said I welcome additional ideas/suggestions here but for this we should probably start a new thread. Regards, -- Andreas Dannenberg Texas Instruments Inc. -- To unsubscribe from this list: send the line "uns

[PATCH] power: bq24190_charger: Fix charge type sysfs property

2015-08-03 Thread Andreas Dannenberg
present in the driver. Signed-off-by: Andreas Dannenberg --- The current driver incorrectly tries to declare the charge type property using POWER_SUPPLY_PROP_TYPE which is the wrong declaration for this (actually POWER_SUPPLY_PROP_TYPE itself has been superseeded by power_supply.type and isn't

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-08-18 Thread Andreas Dannenberg
*client, > + const struct i2c_device_id *id) > +{ > + struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); > + struct power_supply_config charger_cfg = {}; > + struct bq24261_charger *chip; > + int ret; > + enum bq242

[PATCH v4 0/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
Minor update to driver for TI's TAS5720L/M digital audio amplifiers incorporating previous feedback (thanks Mark Brown and Andrew F Davis), see below change log for details. Also re-tested different aspects of the driver to make sure it still builds/works. -- Andreas Dannenberg Texas Instru

[PATCH v4 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- sound/soc/codecs/Kconfig | 8 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas5720.c | 620 + sound/soc/codecs/tas5720.h | 90 +++ 4 files changed, 720 insertions(+) create mode 100644 sound

[PATCH v4 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-04-26 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- .../devicetree/bindings/sound/tas5720.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-05-13 Thread Andreas Dannenberg
Mark, please see below... On Fri, May 13, 2016 at 12:55:40PM +0100, Mark Brown wrote: > On Tue, Apr 26, 2016 at 01:01:05PM -0500, Andreas Dannenberg wrote: > > On Tue, Apr 26, 2016 at 06:29:36PM +0100, Mark Brown wrote: > > > > Is the device actually going to mess u

Re: [PATCH 2/2] power: Add support for TI BQ24261 charger

2015-11-18 Thread Andreas Dannenberg
> + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) { > + dev_err(&client->dev, > + "I2C adapter %s doesn'tsupport BYTE DATA transfer\n", > + adapter->name); > + return

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-09 Thread Andreas Dannenberg
Hi Ram, thanks for submitting this, please see some feedback inlined... On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based

Re: [PATCH 0/2] power: Add support for TI BQ24261 charger

2016-01-05 Thread Andreas Dannenberg
On Mon, Dec 07, 2015 at 07:03:41AM +, Pallala, Ramakrishna wrote: > Hi Sebastian, > > > On Thu, Oct 29, 2015 at 10:07:03PM +0530, Ramakrishna Pallala wrote: > > > This patch series adds the support for TI BQ24261 charger driver. > > > > > > TI BQ24261 charger driver relies on extcon notificati

[PATCH 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-03-18 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas5720.c | 733 + sound/soc/codecs/tas5720.h | 90 ++ 4 files changed, 835 insertions(+) create mode 100644 sound

[PATCH 0/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-03-18 Thread Andreas Dannenberg
e brought to its knees (again, even with an empty threaded handler) was a bit of a surprise to me. -- Andreas Dannenberg Texas Instruments Inc Andreas Dannenberg (2): ASoC: codecs: add TA5720 digital amplifier DT bindings ASoC: codecs: add support for TAS5720 digital amplifier .../de

[PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-03-18 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- .../devicetree/bindings/sound/tas5720.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b

[PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-04-25 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- .../devicetree/bindings/sound/tas5720.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b

[PATCH v3 0/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-25 Thread Andreas Dannenberg
carry forward Rob Herring's earlier Acked-by because of said change. -- Andreas Dannenberg Texas Instruments Inc Changes since v2: - Switched fault handling from using interrupts to polling mode - Remove interrupt related description from DT bindings doc - Remove unlikely() to simplify an

[PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-25 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas5720.c | 638 + sound/soc/codecs/tas5720.h | 90 +++ 4 files changed, 740 insertions(+) create mode 100644 sound

Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-04-26 Thread Andreas Dannenberg
On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote: > On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote: > > > +Optional properties: > > + > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry > > +- pvdd-supply : phandle

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
Hi Mark, thanks for the continued feedback, please see below... On Tue, Apr 26, 2016 at 04:43:13PM +0100, Mark Brown wrote: > On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote: > > This looks mostly good, a few small things below. > > > + switch (width)

Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-04-26 Thread Andreas Dannenberg
On Tue, Apr 26, 2016 at 05:50:06PM +0100, Mark Brown wrote: > On Tue, Apr 26, 2016 at 11:14:25AM -0500, Andreas Dannenberg wrote: > > On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote: > > > On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote: &g

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
On Tue, Apr 26, 2016 at 12:19:05PM -0500, Andrew F. Davis wrote: > On 04/25/2016 03:17 PM, Andreas Dannenberg wrote: > > The Texas Instruments TAS5720L/M device is a high-efficiency mono > > Class-D audio power amplifier optimized for high transient power > > capability to

Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-26 Thread Andreas Dannenberg
On Tue, Apr 26, 2016 at 06:29:36PM +0100, Mark Brown wrote: > On Tue, Apr 26, 2016 at 11:22:40AM -0500, Andreas Dannenberg wrote: > > On Tue, Apr 26, 2016 at 04:43:13PM +0100, Mark Brown wrote: > > > > If the driver doesn't do anything just remove the code. > > &

Re: [PATCH v2 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-03-29 Thread Andreas Dannenberg
Hi Mark, thanks for taking time reviewing the driver. Some comments below... On Mon, Mar 28, 2016 at 08:01:43PM +0100, Mark Brown wrote: > On Mon, Mar 21, 2016 at 12:08:27PM -0500, Andreas Dannenberg wrote: > > > +static int tas5720_set_dai_sysclk(struct snd_soc_dai *dai

Re: [PATCH v2 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-04-01 Thread Andreas Dannenberg
Hi Mark, thanks for the continued feedback - please see below. On Wed, Mar 30, 2016 at 08:38:53AM -0700, Mark Brown wrote: > On Tue, Mar 29, 2016 at 09:53:18PM -0500, Andreas Dannenberg wrote: > > On Mon, Mar 28, 2016 at 08:01:43PM +0100, Mark Brown wrote: > > > On Mon, Mar 21,

Re: [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support

2015-09-15 Thread Andreas Dannenberg
gs according to exactly what the bq27xxx will trigger on to ensure the corresponding GPIO module is always configured properly. While we are at it, was the platform-data based initialization in conjunction with interrupts tested? Regards, -- Andreas Dannenberg

[PATCH] ASoC: davinci-mcasp: Fix TDM slot rx/tx mask associations

2015-11-09 Thread Andreas Dannenberg
serial port uses for transmit. Before that, this scenario would incorrectly rely on the rx_mask for this. Signed-off-by: Andreas Dannenberg --- sound/soc/davinci/davinci-mcasp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc

Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-03-21 Thread Andreas Dannenberg
t; this binding. So I'd just document "interrupts" here as that is what > most docs do, and that implies interrupts-extended could be used. Hi Rob, Good point. Will remove it for v2. Regards, -- Andreas Dannenberg Texas Instruments Inc

[PATCH v2 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

2016-03-21 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- .../devicetree/bindings/sound/tas5720.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b

[PATCH v2 0/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-03-21 Thread Andreas Dannenberg
e brought to its knees (again, even with an empty threaded handler) was a bit of a surprise to me. -- Andreas Dannenberg Texas Instruments Inc Changes since v1: - Simplified DT interrupt documentation (Thanks Rob Herring) - Fixed potential race condition during codec probe where deferred work that

[PATCH v2 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

2016-03-21 Thread Andreas Dannenberg
bus. Signed-off-by: Andreas Dannenberg --- sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas5720.c | 734 + sound/soc/codecs/tas5720.h | 90 ++ 4 files changed, 836 insertions(+) create mode 100644 sound

Re: [PATCH v8 0/4] generic TEE subsystem

2016-03-02 Thread Andreas Dannenberg
the continued work on this. I've recently starting testing/experimenting with this in the context of Kernel 4.4 (will try latest Kernel as a next step) and have not found any issues so far. This is an ongoing effort and I'll provide feedback as I encounter anything notable. But I also wante

Re: [PATCH v2] iio: mcp4xxx_dpot: Driver for Microchip digital potentiometers

2015-09-22 Thread Andreas Dannenberg
+# > +# Potentiometer drivers > +# > +# When adding new entries keep the list in alphabetical order > + > +menu "Digital potentiometers" > + > +config MCP4XXX_DPOT > + tristate "Microchip MCP45xx/MCP46xx Digital Potentiometer driver" > + depends o

Re: [PATCH v2 1/3] iio: light: opt3001: extract int. time constants

2016-01-29 Thread Andreas Dannenberg
On Sat, Jan 16, 2016 at 05:14:36PM +0100, Alexander Koch wrote: > Extract integration times as #define constants. This prepares using them > for delay/timeout length determination. > > Signed-off-by: Alexander Koch > Signed-off-by: Michael Hornung Tested-by: Andreas Dannenberg

Re: [PATCH v2 2/3] iio: light: opt3001: trivial type refactoring

2016-01-29 Thread Andreas Dannenberg
t; > Signed-off-by: Alexander Koch > Signed-off-by: Michael Hornung Tested-by: Andreas Dannenberg > --- > drivers/iio/light/opt3001.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c &

Re: [PATCH v2 3/3] iio: light: opt3001: enable operation w/o IRQ

2016-01-29 Thread Andreas Dannenberg
> This change is transparent as behaviour defaults to using the interrupt > method if an interrupt no. is configured via device tree. Interrupt-less > operation mode is performed when no valid interrupt no. is given. > > Signed-off-by: Alexander Koch > Signed-off-by: Michael Horn

Re: [PATCH v2 0/3] iio: light: opt3001: Enable operation w/o IRQ

2016-01-29 Thread Andreas Dannenberg
On Sat, Jan 16, 2016 at 05:14:35PM +0100, Alexander Koch wrote: > This patch series aims at enabling IRQ-less operation for the TI OPT3001 light > sensor. Jon, I was checking to see if the DT bindings have been updated to reflect the interrupt-less operation however I can't seem to find it in the