Re: [PATCH net 0/3] SLCAN/SLIP fixes and performance

2013-09-14 Thread Andre Naujoks
On 14.09.2013 12:45, Marc Kleine-Budde wrote: On 09/13/2013 07:37 PM, Andre Naujoks wrote: Hi Dave, these are some loosely related patches, that fix an ancient locking problem in the slip and slcan drivers, add general ASCII-HEX to bin functions for uppercase ASCII, fix the handling of CAN RTR

Re: [PATCH net 1/3] slip/slcan: added locking in wakeup function

2013-09-19 Thread Andre Naujoks
On 19.09.2013 11:36, schrieb Marc Kleine-Budde: > On 09/13/2013 07:37 PM, Andre Naujoks wrote: >> The locking is needed, since the the internal buffer for the CAN >> frames is changed during the wakeup call. This could cause buffer >> inconsistencies under high loads, especi

[PATCH net 0/3] SLCAN/SLIP fixes and performance

2013-09-13 Thread Andre Naujoks
patches mainly contain fixes for the slip/slcan drivers that require a tty layer fix included in 3.11, I would suggest to get the patches in via the net tree for the 3.12 cycle. They should apply properly on the latest net and mainline tree. Best regards, Andre Andre Naujoks (3): slip/slcan: added

[PATCH net 2/3] lib: introduce upper case hex ascii helpers

2013-09-13 Thread Andre Naujoks
To be able to use the hex ascii functions in case sensitive environments the array hex_asc_upper[] and the needed functions for hex_byte_pack_upper() are introduced. Signed-off-by: Andre Naujoks --- include/linux/kernel.h | 11 +++ lib/hexdump.c | 2 ++ 2 files changed, 13

[PATCH net 3/3] slcan: rewrite of slc_bump and slc_encaps

2013-09-13 Thread Andre Naujoks
and not the kernel sprintf. Together with this rewrite an issue with sending and receiving of RTR frames has been fixed by Oliver for the cases that the DLC is not zero. Signed-off-by: Andre Naujoks Tested-by: Oliver Hartkopp --- drivers/net/can/slcan.c | 136

[PATCH net 1/3] slip/slcan: added locking in wakeup function

2013-09-13 Thread Andre Naujoks
"5ede52538ee2b2202d9dff5b06c33bfde421e6e4 tty: Remove extra wakeup from pty write() path", which removed the direct callback to the wakeup function from the tty layer. As slcan.c is based on slip.c the issue in the original code is fixed, too. Signed-off-by: Andre Naujoks --- drivers/net/can/slcan.c | 3 +++ driver

[PATCH] kernel panic, pty.c: remove direct call to tty_wakup in pty_write

2013-07-01 Thread Andre Naujoks
d to the list. If I can provide any more information, I will be glad to do so. This is the patch. It applies to the current linux master branch: >From 9f67139bebb938026406a66c1411e0b50628a238 Mon Sep 17 00:00:00 2001 From: Andre Naujoks Date: Mon, 1 Jul 2013 15:45:13 +0200 Subject: [PATCH 1/2

Re: [PATCH] kernel panic, pty.c: remove direct call to tty_wakup in pty_write

2013-07-02 Thread Andre Naujoks
On 02.07.2013 11:39, schrieb Dean Jenkins: > On 01/07/13 15:49, Andre Naujoks wrote: >> Hello. >> >> This patch removes the direct call to tty_wakeup in pty_write. I have >> not noticed any drawbacks with this but I am not familiar with the pty >> driver at all. I

Re: [PATCH] kernel panic, pty.c: remove direct call to tty_wakup in pty_write with better commit message

2013-07-02 Thread Andre Naujoks
Thanks for the pointer. Since your patch is from April, does that mean, that we cannot expect it to hit 3.11? From 6cbfeb6cb9bbe7455cddbf162a7b158e1debd578 Mon Sep 17 00:00:00 2001 From: Andre Naujoks Date: Tue, 2 Jul 2013 22:11:33 +0200 Subject: [PATCH] Remove the tty_wakeup call inside

Re: [PATCH] kernel panic, pty.c: remove direct call to tty_wakup in pty_write

2013-07-02 Thread Andre Naujoks
On 02.07.2013 20:59, Peter Hurley wrote: On 07/01/2013 10:49 AM, Andre Naujoks wrote: Hello. This patch removes the direct call to tty_wakeup in pty_write. I have not noticed any drawbacks with this but I am not familiar with the pty driver at all. I think what happens is a recursive loop

[RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

2018-04-11 Thread Andre Naujoks
5 Mon Sep 17 00:00:00 2001 From: Andre Naujoks Date: Wed, 11 Apr 2018 12:38:28 +0200 Subject: [PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version The socket option will be enabled by default to ensure current behaviour is not changed. This is the same for the IPv4 versio

Re: [PATCH 2/2] slcan: Port write_wakeup deadlock fix from slip

2014-06-17 Thread Andre Naujoks
On 16.06.2014 04:23, schrieb Tyler Hall: > The commit "slip: Fix deadlock in write_wakeup" fixes a deadlock caused > by a change made in both slcan and slip. This is a direct port of that > fix. I don't know if it is still needed, but for the slcan part, you can add my:

Re: [PATCH] net: can: Increase tx queue length

2019-03-09 Thread Andre Naujoks
On 3/9/19 3:07 PM, Appana Durga Kedareswara rao wrote: > While stress testing the CAN interface on xilinx axi can > in loopback mode getting message "write: no buffer space available" > Increasing device tx queue length resolved the above mentioned issue. No need to patch the kernel: $ ip link se

Re: [PATCH] net: can: Increase tx queue length

2019-03-09 Thread Andre Naujoks
On 3/9/19 3:40 PM, Appana Durga Kedareswara Rao wrote: > Hi Andre, > > >> >> On 3/9/19 3:07 PM, Appana Durga Kedareswara rao wrote: >>> While stress testing the CAN interface on xilinx axi can in loopback >>> mode getting message "write: no buffer space available" >>> Increasing device tx queue

[PATCH 0/1] add IPV6_MULTICAST_ALL sockopt

2018-09-10 Thread Andre Naujoks
The patch applies to the current net-next tree. I tried to keep the impact of this to a minimum and to replicate the behaviour of IP_MULTICAST_ALL. Andre Naujoks (1): ipv6: Add sockopt IPV6_MULTICAST_ALL analogue to IP_MULTICAST_ALL include/linux/ipv6.h | 3 ++- include/uapi/linux/in6.h