ac_hash[mac_hash];
> rcu_read_lock();
> - hlist_for_each_entry_rcu(entry, n, bucket,
> hlist) {
> + hlist_for_each_entry_rcu(entry, bucket, hlist) {
> if (ether_addr_equal_64bits(entry->
On 26/08/2013 09:03, Eliezer Tamir wrote:
> On 26/08/2013 00:30, Amir Vadai wrote:
>> I'm on vacation, will test and have some inputs later this week when I be
>> back.
>>
> Hello Amir,
>
> Ping me when you get back and I will send you my latest so you can
>
On 30/05/2013 14:41, Eliezer Tamir wrote:
> diff --git a/fs/select.c b/fs/select.c
> index 8c1c96c..f116bf0 100644
> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -27,6 +27,7 @@
> #include
> #include
> #include
> +#include
>
> #include
>
> @@ -400,6 +401,7 @@ int do_select(int n, fd_set_b
Acked-By: Amir Vadai
Nice work Eliezer :)
On 03/06/2013 11:01, Eliezer Tamir wrote:
> David,
>
> Here is v8 with yet more fixes.
>
> Please consider applying.
>
> Thanks to everyone for their input.
>
> -Eliezer
>
> change log:
> v8
> - split out ud
On 03/06/2013 11:01, Eliezer Tamir wrote:
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index 741db5fc..ae98c95 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
>
> stat
On 11/06/2013 17:26, Eliezer Tamir wrote:
> Add lls socket option support to sockperf.
> Right now we always get the option before set to show the option is
> working properly. We should probably remove that in an official release.
> use --lls (value in usecs) to override global setting.
> ---
>
>
This fix introduced a bug in SRIOV.
Should squash into it, the upstream commit:
f74d525bc973f2003b55b1f71f377e31fb5d3c8b - "net/mlx4_en: Disable RFS in
SRIOV virtual functions"
Thanks,
Amir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ma
/cpu_rmap.c| 63 +
3 files changed, 62 insertions(+), 19 deletions(-)
Acked-by: Amir Vadai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordo
/cpu_rmap.c| 63 +
3 files changed, 62 insertions(+), 19 deletions(-)
Acked-by: Amir Vadai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordo
On 1/6/2015 4:54 AM, David Decotigny wrote:
> This patch series increases the width of the supported/advertising
> ethtool masks from 32 bits to 48. This should allow to breathe for a
> couple more years (or... months?).
Hi,
Nice work.
What worries me is that it is going to be for weeks more than
On 1/6/2015 7:36 PM, David Decotigny wrote:
> Interesting. It seems that the band-aid I was proposing is already
> obsolete. We could still use the remaining reserved 16 bits to encode
> 5 more bits per mask (that is: 53 bits / mask total). But if I
> understand you, it would allow us to survive on
On Thu, Apr 30, 2015 at 1:59 AM, Benjamin Poirier wrote:
> Signed-off-by: Benjamin Poirier
> Fixes: 9e311e7 ("net/mlx4_en: Use affinity hint")
> ---
Good catch.
Acked-by: Amir Vadai
Thanks,
Amir
--
To unsubscribe from this list: send the line "unsubscribe linux-
ould it be static?
CC: net...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Eugenia Emantayev
Signed-off-by: Fengguang Wu
Signed-off-by: Amir Vadai
---
drivers/net/ethernet/mellanox/mlx4/en_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mel
On 10/12/13 14:44 +0100, Gerald Schaefer wrote:
> Hi,
>
> During network stress test with CONFIG_DMA_API_DEBUG=y we get the following
> message on the server side:
>
> [57523.955982] mlx4_core :00:00.0: DMA-API: device driver tries to sync
> DMA memory it has not allocated [device address=0x
On 13/01/14 11:13 -0800, David Miller wrote:
> From: Paul Bolle
> Date: Tue, 07 Jan 2014 14:00:22 +0100
>
> > 0) These two patches are very similar. They both clean up a function to
> > help GCC understand the codeflow. Both help silence a warning.
> >
> > 1) Compile tested only (on 32 bits x86)
anox/mlx4/en_main.c | 17 +++--
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 ++--
> 2 files changed, 9 insertions(+), 12 deletions(-)
Thanks Joe.
Acked-By: Amir Vadai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to major
Bhargava
CC: Govindarajulu Varadarajan
Signed-off-by: Amir Vadai
---
include/linux/interrupt.h | 9
kernel/irq/manage.c | 58 +++
2 files changed, 67 insertions(+)
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index
: Amir Vadai
---
drivers/infiniband/hw/mlx4/main.c | 2 +-
drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 +-
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 30 ++
drivers/net/ethernet/mellanox/mlx4/eq.c| 14 +++-
drivers/net/ethernet
NULL on error
Changes from V0:
- Fixed small style issues
Amir Vadai (1):
irq: Utility function to get affinity_hint by policy
Yuval Atias (1):
net/mlx4_en: Use affinity hint
drivers/infiniband/hw/mlx4/main.c | 2 +-
drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 ++-
d
ot stopped, variable 'port_up' is left uninitialized and the behaviour is
undetermined. Detected by Coverity - CID 751497.
Signed-off-by: Christian Engelmayer
---
Acked-By: Amir Vadai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
SMP
configuration.
Fixes: 2eacc23 ("net/mlx4_core: Enforce irq affinity changes
immediatly")
Signed-off-by: Eyal Perry
Signed-off-by: Amir Vadai
---
include/linux/interrupt.h | 46 ++
1 file changed, 26 insertions(+), 20 deletions(-)
di
> interfaces.
>
> Signed-off-by: Alexander Gordeev
> Cc: Jeff Kirsher
> Cc: Jesse Brandeburg
> Cc: Bruce Allan
> Cc: e1000-de...@lists.sourceforge.net
> Cc: net...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> ---
Acked-By: Amir Vadai
--
To unsubscribe from t
On 18/02/14 14:01 +0200, Amir Vadai wrote:
> On 18/02/14 11:11 +0100, Alexander Gordeev wrote:
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these two interfaces need to be updat
Hi,
I'm working for Mellanox on mlx4_en NIC driver.
We need to be able to be notified on irq affinity changes.
This is because, during non-stop full bandwidth traffic, napi will poll
constantly and no interrupt will be fired. Because of that, even if the
user changes the irq affinity, polling
On 5/25/2014 3:15 PM, Amir Vadai wrote:
Hi,
I'm working for Mellanox on mlx4_en NIC driver.
We need to be able to be notified on irq affinity changes.
This is because, during non-stop full bandwidth traffic, napi will poll
constantly and no interrupt will be fired. Because of that, even i
Changes from V1:
- Patch 1/2: net: Utility function to get affinity_hint by policy
- Fixed error flow to return -EINVAL on error (thanks govind)
- Patch 2/2: net/mlx4_en: Use affinity hint
- Set ring->affinity_hint to NULL on error
Changes from V0:
- Fixed small style issues
Amir Vadai (1):
multi queue networking devices to
calculate the irq affinity mask, such that as many local cpu's as
possible will be utilized to handle the mq device irq's.
Signed-off-by: Amir Vadai
---
include/linux/cpumask.h | 2 ++
lib/cpumask.c | 64 ++
cores
close to it. To accomplish this, we use cpumask_set_cpu_local_first(), that
sets the affinity hint according the following policy:
First it maps IRQs to “close” numa cores. If these are exhausted, the
remaining IRQs are mapped to “far” numa cores.
Signed-off-by: Yuval Atias
Signed-off-by: Amir
On 5/26/2014 2:15 PM, Thomas Gleixner wrote:
On Sun, 25 May 2014, Amir Vadai wrote:
In order to do that, I need to add a new irq affinity notification
callback (In addition to the existing cpu_rmap notification). For
that I would like to extend irq_set_affinity_notifier() to have a
notifier
On 5/26/2014 2:34 PM, Thomas Gleixner wrote:
On Mon, 26 May 2014, Amir Vadai wrote:
On 5/26/2014 2:15 PM, Thomas Gleixner wrote:
On Sun, 25 May 2014, Amir Vadai wrote:
In order to do that, I need to add a new irq affinity notification
callback (In addition to the existing cpu_rmap
On 5/26/2014 3:39 PM, Thomas Gleixner wrote:
[...]
The rmap _IS_ instantiated by the driver, and both the driver and the
networking core know about it.
So it's not completely different consumers. Just because it's a
library does not mean it's disjunct from the code which uses it.
Aside of th
y_wqe_gid is "
-"enforced on this ib port\n");
+ mlx4_err(dev, "phy_wqe_gid is enforced on this ib
port\n");
err = -EPROTONOSUPPORT;
goto out;
}
[...]
Acked-By: Amir Vadai
Thanks,
Amir
-
On 6/2/2014 8:13 AM, Eric Dumazet wrote:
On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote:
Indeed you have to provide a dummy version for a non-SMP build etc.
I'm reverting.
Hi David. I think your revert took one wrong commit.
# git show ee39facbf82e73e468c504d2b40e83e2d223c28c | dif
> interfaces.
>
> Signed-off-by: Alexander Gordeev
> ---
> drivers/net/ethernet/mellanox/mlx4/main.c | 19 ---
> 1 files changed, 4 insertions(+), 15 deletions(-)
>
Acked By: Amir Vadai
--
To unsubscribe from this list: send the line "unsubscribe
On 27/12/13 14:48 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
>
> Cc: Amir Vadai
> Signed-off-by: Ding Tianhong
> ---
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 4 ++--
> drivers/net/ethernet/mellanox
t; intentionally declared but not used here. I could not come up
> with a nicer workaround, but this seems to do the trick.
>
> Signed-off-by: Arnd Bergmann
> Fixes: aad7e08d39bd ("net/mlx5e: Hardware offloaded flower filter statistics
> support")
> Fixes: 00175aec941e
dy->bits[i]);
> + kvfree(buddy->bits[i]);
>
> kfree(buddy->bits);
> kfree(buddy->num_free);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.o
On 5/5/2015 5:53 PM, Thomas Gleixner wrote:
> On Tue, 5 May 2015, Amir Vadai wrote:
>
>> On Mon, May 4, 2015 at 6:10 PM, Thomas Gleixner wrote:
>>> On Mon, 4 May 2015, Amir Vadai wrote:
>>>
>>>> On Mon, May 4, 2015 at 6:15 AM, Jiang Liu
>>>&g
On Mon, May 4, 2015 at 5:00 PM, Jiang Liu wrote:
> On 2015/5/4 20:10, Amir Vadai wrote:
>> On Mon, May 4, 2015 at 6:15 AM, Jiang Liu wrote:
>>> The field 'affinity' in irq_desc won't change once the irq_desc data
>>> structure is created. So cache irq_de
On Mon, May 4, 2015 at 6:10 PM, Thomas Gleixner wrote:
> On Mon, 4 May 2015, Amir Vadai wrote:
>
>> On Mon, May 4, 2015 at 6:15 AM, Jiang Liu wrote:
>> > The field 'affinity' in irq_desc won't change once the irq_desc data
>> > structure is cr
On Mon, May 4, 2015 at 6:15 AM, Jiang Liu wrote:
> The field 'affinity' in irq_desc won't change once the irq_desc data
> structure is created. So cache irq_desc->affinity instead of irq_desc.
> This also helps to hide struct irq_desc from device drivers.
Hi Jiang,
I might not understand the new
41 matches
Mail list logo
