Re: [PATCH v7 5/8] mm: Device exclusive memory access

2021-03-31 Thread Alistair Popple
On Thursday, 1 April 2021 11:48:13 AM AEDT Jason Gunthorpe wrote: > On Thu, Apr 01, 2021 at 11:45:57AM +1100, Alistair Popple wrote: > > On Thursday, 1 April 2021 12:46:04 AM AEDT Jason Gunthorpe wrote: > > > On Thu, Apr 01, 2021 at 12:27:52AM +1100, Alistair Popple wrote: >

Re: [PATCH v7 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-03-31 Thread Alistair Popple
On Wednesday, 31 March 2021 10:57:46 PM AEDT Jason Gunthorpe wrote: > On Wed, Mar 31, 2021 at 03:15:47PM +1100, Alistair Popple wrote: > > On Wednesday, 31 March 2021 2:56:38 PM AEDT John Hubbard wrote: > > > On 3/30/21 3:56 PM, Alistair Popple wrote: > > > ... > &

Re: [PATCH v2] kernel/resource: Fix locking in request_free_mem_region

2021-03-31 Thread Alistair Popple
On Thursday, 1 April 2021 3:56:05 PM AEDT Muchun Song wrote: > External email: Use caution opening links or attachments > > > On Fri, Mar 26, 2021 at 9:22 AM Alistair Popple wrote: > > > > request_free_mem_region() is used to find an empty range of physical >

[PATCH v5 1/3] kernel/resource: Allow region_intersects users to hold resource_lock

2021-04-19 Thread Alistair Popple
Introduce a version of region_intersects() that can be called with the resource_lock already held. This is used in a future fix to __request_free_mem_region(). Signed-off-by: Alistair Popple --- kernel/resource.c | 52 --- 1 file changed, 31

[PATCH v5 3/3] kernel/resource: Fix locking in request_free_mem_region

2021-04-19 Thread Alistair Popple
arn("Unaddressable device %s %pR conflicts with %pR", conflict->name, conflict, res); These unexpected failures can be corrected by holding resource_lock across the two calls. This also requires memory allocation to be performed prior to taking the lock. Signed-

[PATCH v5 2/3] kernel/resource: Refactor __request_region to allow external locking

2021-04-19 Thread Alistair Popple
Refactor the portion of __request_region() done whilst holding the resource_lock into a separate function to allow callers to hold the lock. Signed-off-by: Alistair Popple --- kernel/resource.c | 52 +-- 1 file changed, 32 insertions(+), 20 deletions

Re: [PATCH v4] kernel/resource: Fix locking in request_free_mem_region

2021-04-19 Thread Alistair Popple
On Friday, 16 April 2021 2:19:18 PM AEST Dan Williams wrote: > The revoke_iomem() change seems like something that should be moved > into a leaf helper and not called by __request_free_mem_region() > directly. Ok. I have split this up but left the call to revoke_iomem() in __request_free_mem_regi

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-22 Thread Alistair Popple
On Friday, 19 February 2021 8:47:41 PM AEDT Christoph Hellwig wrote: > > page = migration_entry_to_page(swpent); > > else if (is_device_private_entry(swpent)) > > page = device_private_entry_to_page(swpent); > > + else if (is_device_excl

[PATCH] drm/nouveau/svm: Only map migrating pages

2020-11-30 Thread Alistair Popple
uired. Fixes: e3d8b0890469 ("drm/nouveau/svm: map pages after migration") Signed-off-by: Alistair Popple --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/

Re: [PATCH v5 1/8] mm: Remove special swap entry functions

2021-03-11 Thread Alistair Popple
On Tuesday, 9 March 2021 11:49:49 PM AEDT Matthew Wilcox wrote: > On Tue, Mar 09, 2021 at 11:14:58PM +1100, Alistair Popple wrote: > > -static inline struct page *migration_entry_to_page(swp_entry_t entry) > > -{ > > - struct page *p = pfn_to_page(swp_offset(entry)); >

[PATCH v6 1/8] mm: Remove special swap entry functions

2021-03-12 Thread Alistair Popple
Remove the migration and device private entry_to_page() and entry_to_pfn() inline functions and instead open code them directly. This results in shorter code which is easier to understand. Signed-off-by: Alistair Popple Reviewed-by: Ralph Campbell --- v6: * Removed redundant compound_page

[PATCH v6 0/8] Add support for SVM atomics in Nouveau

2021-03-12 Thread Alistair Popple
n tested using the latest upstream Mesa userspace with a simple OpenCL test program which checks the results of atomic GPU operations on a SVM buffer whilst also writing to the same buffer from the CPU. Alistair Popple (8): mm: Remove special swap entry functions mm/swapops: Rework swap entry mani

[PATCH v6 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-03-12 Thread Alistair Popple
rather than overload try_to_unmap_one() with unrelated behaviour split this out into it's own function and remove the flag. Signed-off-by: Alistair Popple Reviewed-by: Ralph Campbell --- Christoph - I didn't add your Reviewed-by from v3 because removal of the extra VM_LOCKED check in

[PATCH v6 2/8] mm/swapops: Rework swap entry manipulation code

2021-03-12 Thread Alistair Popple
-by: Alistair Popple Reviewed-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Ralph Campbell --- include/linux/swapops.h | 56 ++--- mm/debug_vm_pgtable.c | 12 - mm/hmm.c| 2 +- mm/huge_memory.c| 26

[PATCH v6 4/8] mm/rmap: Split migration into its own function

2021-03-12 Thread Alistair Popple
try_to_migrate() for PageAnon or try_to_unmap(). Signed-off-by: Alistair Popple Reviewed-by: Christoph Hellwig Reviewed-by: Ralph Campbell --- v5: * Added comments about how PMD splitting works for migration vs. unmapping * Tightened up the flag check in try_to_migrate() to be explicit about

[PATCH v6 5/8] mm: Device exclusive memory access

2021-03-12 Thread Alistair Popple
original mapping. This results in MMU notifiers being called which a driver uses to update access permissions such as revoking atomic access. After notifiers have been called the device will no longer have exclusive access to the region. Signed-off-by: Alistair Popple --- v6: * Fixed a bisectablity

[PATCH v6 6/8] mm: Selftests for exclusive device memory

2021-03-12 Thread Alistair Popple
Adds some selftests for exclusive device memory. Signed-off-by: Alistair Popple Acked-by: Jason Gunthorpe Tested-by: Ralph Campbell Reviewed-by: Ralph Campbell --- lib/test_hmm.c | 124 ++ lib/test_hmm_uapi.h| 2 + tools/testing

[PATCH v6 8/8] nouveau/svm: Implement atomic SVM access

2021-03-12 Thread Alistair Popple
to proceed. Signed-off-by: Alistair Popple --- v4: * Check that page table entries haven't changed before mapping on the device --- drivers/gpu/drm/nouveau/include/nvif/if000c.h | 1 + drivers/gpu/drm/nouveau/nouveau_svm.c | 100 -- drivers/gpu/drm/nouveau

[PATCH v6 7/8] nouveau/svm: Refactor nouveau_range_fault

2021-03-12 Thread Alistair Popple
Call mmu_interval_notifier_insert() as part of nouveau_range_fault(). This doesn't introduce any functional change but makes it easier for a subsequent patch to alter the behaviour of nouveau_range_fault() to support GPU atomic operations. Signed-off-by: Alistair Popple --- drivers/gp

Re: [PATCH v3 1/8] mm: Remove special swap entry functions

2021-03-01 Thread Alistair Popple
On Tuesday, 2 March 2021 4:46:42 AM AEDT Jason Gunthorpe wrote: > > I wish you could come up with a more descriptive word that special > here > > What I understand is this is true when the swap_offset is a pfn? Correct, and that points to a better name. Maybe is_pfn_swap_entry()? In which case

Re: [PATCH v3 1/8] mm: Remove special swap entry functions

2021-03-02 Thread Alistair Popple
On Saturday, 27 February 2021 2:59:09 AM AEDT Christoph Hellwig wrote: > > - struct page *page = migration_entry_to_page(entry); > > + struct page *page = pfn_to_page(swp_offset(entry)); > > I wonder if keeping a single special_entry_to_page() helper would still > me a useful.

Re: [PATCH v3 5/8] mm: Device exclusive memory access

2021-03-02 Thread Alistair Popple
On Tuesday, 2 March 2021 11:05:59 AM AEDT Jason Gunthorpe wrote: > On Fri, Feb 26, 2021 at 06:18:29PM +1100, Alistair Popple wrote: > > > +/** > > + * make_device_exclusive_range() - Mark a range for exclusive use by a device > > + * @mm: mm_struct of assoicated targe

Re: [PATCH v3 6/8] mm: Selftests for exclusive device memory

2021-03-02 Thread Alistair Popple
On Tuesday, 2 March 2021 10:14:56 AM AEDT Ralph Campbell wrote: > > From: Alistair Popple > > Sent: Thursday, February 25, 2021 11:19 PM > > To: linux...@kvack.org; nouv...@lists.freedesktop.org; > > bske...@redhat.com; a...@linux-foundation.org > > Cc: linux-...

Re: [PATCH v3 1/8] mm: Remove special swap entry functions

2021-03-02 Thread Alistair Popple
On Tuesday, 2 March 2021 7:52:53 PM AEDT Alistair Popple wrote: > On Saturday, 27 February 2021 2:59:09 AM AEDT Christoph Hellwig wrote: > > > - struct page *page = migration_entry_to_page(entry); > > > + struct page *page = pfn_to_page(swp_offset(entry));

Re: [PATCH v4 4/8] mm/rmap: Split migration into its own function

2021-03-08 Thread Alistair Popple
On Tuesday, 9 March 2021 5:58:12 AM AEDT Ralph Campbell wrote: > > On 3/3/21 10:16 PM, Alistair Popple wrote: > > Migration is currently implemented as a mode of operation for > > try_to_unmap_one() generally specified by passing the TTU_MIGRATION flag > > or in the

Re: [PATCH v4 5/8] mm: Device exclusive memory access

2021-03-08 Thread Alistair Popple
On Tuesday, 9 March 2021 6:44:41 AM AEDT Ralph Campbell wrote: > > On 3/3/21 10:16 PM, Alistair Popple wrote: > > Some devices require exclusive write access to shared virtual > > memory (SVM) ranges to perform atomic operations on that memory. This > > requires CPU page

[PATCH v5 0/8] Add support for SVM atomics in Nouveau

2021-03-09 Thread Alistair Popple
l swap entries instead of device private pages. Alistair Popple (8): mm: Remove special swap entry functions mm/swapops: Rework swap entry manipulation code mm/rmap: Split try_to_munlock from try_to_unmap mm/rmap: Split migration into its own function mm: Device exclusive memory access

[PATCH v5 1/8] mm: Remove special swap entry functions

2021-03-09 Thread Alistair Popple
Remove the migration and device private entry_to_page() and entry_to_pfn() inline functions and instead open code them directly. This results in shorter code which is easier to understand. Signed-off-by: Alistair Popple Reviewed-by: Ralph Campbell --- v4: * Added pfn_swap_entry_to_page

[PATCH v5 2/8] mm/swapops: Rework swap entry manipulation code

2021-03-09 Thread Alistair Popple
-by: Alistair Popple Reviewed-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Ralph Campbell --- include/linux/swapops.h | 56 ++--- mm/debug_vm_pgtable.c | 12 - mm/hmm.c| 2 +- mm/huge_memory.c| 26

[PATCH v5 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-03-09 Thread Alistair Popple
rather than overload try_to_unmap_one() with unrelated behaviour split this out into it's own function and remove the flag. Signed-off-by: Alistair Popple Reviewed-by: Ralph Campbell --- Christoph - I didn't add your Reviewed-by from v3 because removal of the extra VM_LOCKED check in

[PATCH v5 5/8] mm: Device exclusive memory access

2021-03-09 Thread Alistair Popple
original mapping. This results in MMU notifiers being called which a driver uses to update access permissions such as revoking atomic access. After notifiers have been called the device will no longer have exclusive access to the region. Signed-off-by: Alistair Popple --- v5: * Renamed range

[PATCH v5 4/8] mm/rmap: Split migration into its own function

2021-03-09 Thread Alistair Popple
try_to_migrate() for PageAnon or try_to_unmap(). Signed-off-by: Alistair Popple Reviewed-by: Christoph Hellwig Reviewed-by: Ralph Campbell --- v5: * Added comments about how PMD splitting works for migration vs. unmapping * Tightened up the flag check in try_to_migrate() to be explicit about

[PATCH v5 6/8] mm: Selftests for exclusive device memory

2021-03-09 Thread Alistair Popple
Adds some selftests for exclusive device memory. Signed-off-by: Alistair Popple Acked-by: Jason Gunthorpe Tested-by: Ralph Campbell Reviewed-by: Ralph Campbell --- lib/test_hmm.c | 126 +- lib/test_hmm_uapi.h| 2 + tools/testing

[PATCH v5 8/8] nouveau/svm: Implement atomic SVM access

2021-03-09 Thread Alistair Popple
to proceed. Signed-off-by: Alistair Popple --- v4: * Check that page table entries haven't changed before mapping on the device --- drivers/gpu/drm/nouveau/include/nvif/if000c.h | 1 + drivers/gpu/drm/nouveau/nouveau_svm.c | 102 -- drivers/gpu/drm/nouveau

[PATCH v5 7/8] nouveau/svm: Refactor nouveau_range_fault

2021-03-09 Thread Alistair Popple
Call mmu_interval_notifier_insert() as part of nouveau_range_fault(). This doesn't introduce any functional change but makes it easier for a subsequent patch to alter the behaviour of nouveau_range_fault() to support GPU atomic operations. Signed-off-by: Alistair Popple --- drivers/gp

Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-23 Thread Alistair Popple
On Fri, 21 Feb 2014 15:16:52 Arnd Bergmann wrote: > On Friday 21 February 2014 17:31:29 Alistair Popple wrote: > > +static const struct of_device_id ohci_of_match[] = { > > + { .compatible = "usb-ohci", }, > > + {}, > > +}; > > + >

Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-23 Thread Alistair Popple
On Fri, 21 Feb 2014 10:41:50 Alan Stern wrote: > On Fri, 21 Feb 2014, Alistair Popple wrote: > > Currently the ppc-of driver uses the compatibility string > > "usb-ehci". This means platforms that use device-tree and implement an > > EHCI compatible interface have

Re: [PATCH 1/7] IBM Akebono: Add a SDHCI platform driver

2014-02-23 Thread Alistair Popple
On Fri, 21 Feb 2014 15:14:30 Arnd Bergmann wrote: > On Friday 21 February 2014 17:31:27 Alistair Popple wrote: > > +config MMC_SDHCI_OF_476GTR > > + tristate "SDHCI OF support for the IBM PPC476GTR SoC" > > + depends on MMC_SDHCI_PLTFM > > + depends

Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-02-23 Thread Alistair Popple
On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote: > On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote: [...] > > > + /* Check for RGMII flags */ > > + if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL)) > > + d

Re: [PATCH 7/7] powerpc: Added PCI MSI support using the HSTA module

2014-02-24 Thread Alistair Popple
On Sat, 22 Feb 2014 07:41:26 Benjamin Herrenschmidt wrote: > On Fri, 2014-02-21 at 15:33 +0100, Arnd Bergmann wrote: [...] > > Should we (provided it's possible in HW) create two ranges instead ? One > covering RAM and one covering MSIs ? To avoid stray DMAs whacking random > HW registers in the

[PATCH 3/5] IBM Currituck: Clean up board specific code before adding Akebono code

2014-03-05 Thread Alistair Popple
. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/44x/Makefile| 2 +- arch/powerpc/platforms/44x/currituck.c | 233 - arch/powerpc/platforms/44x/ppc476.c| 233 + 3 files changed, 234 insertions(+), 234 deletions

[PATCH 0/5] V2 IBM Akebono/PPC46GTR Support

2014-03-05 Thread Alistair Popple
The IBM Akebono board is a development board for the new PPC476GTR system on chip (SoC). This version of the series updates the device tree and drops the USB patches as the equivalent functionality is already in linux-next. It also addresses feedback from the previous submission. Alistair Popple

[PATCH 5/5] powerpc: Added PCI MSI support using the HSTA module

2014-03-05 Thread Alistair Popple
allow PCI devices write access to the HSTA module. Signed-off-by: Alistair Popple --- .../devicetree/bindings/powerpc/4xx/hsta.txt | 19 ++ arch/powerpc/boot/dts/akebono.dts | 46 - arch/powerpc/boot/treeboot-akebono.c | 15 -- arch/powerpc/platforms/44x

[PATCH 4/5] IBM Akebono: Add the Akebono platform

2014-03-05 Thread Alistair Popple
This patch adds support for the IBM Akebono board. Signed-off-by: Alistair Popple --- .../devicetree/bindings/powerpc/4xx/akebono.txt| 54 +++ arch/powerpc/boot/Makefile | 3 + arch/powerpc/boot/dcr.h| 4 + arch/powerpc/boot/dts

[PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-03-05 Thread Alistair Popple
. Signed-off-by: Alistair Popple Acked-by: Benjamin Herrenschmidt --- .../devicetree/bindings/powerpc/4xx/emac.txt | 9 + drivers/net/ethernet/ibm/emac/Kconfig | 4 + drivers/net/ethernet/ibm/emac/Makefile | 1 + drivers/net/ethernet/ibm/emac/core.c

[PATCH 1/5] SDHCI: Add a generic registration to the SDHCI platform driver

2014-03-05 Thread Alistair Popple
This patch adds a generic platform driver registration to the exiting SDHCI platform driver using the devicetree compatibility string "generic-sdhci". Signed-off-by: Alistair Popple --- .../devicetree/bindings/mmc/sdhci-pltfm.txt| 16 + drivers/mmc/host/sdh

[PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-02-20 Thread Alistair Popple
. Signed-off-by: Alistair Popple Acked-by: Benjamin Herrenschmidt Cc: "David S. Miller" --- .../devicetree/bindings/powerpc/4xx/emac.txt |9 + drivers/net/ethernet/ibm/emac/Kconfig |4 + drivers/net/ethernet/ibm/emac/Makefile |1 + drivers/net/et

[PATCH 6/7] IBM Akebono: Add the Akebono platform

2014-02-20 Thread Alistair Popple
This patch adds support for the IBM Akebono board. Signed-off-by: Alistair Popple --- .../devicetree/bindings/powerpc/4xx/akebono.txt| 54 +++ arch/powerpc/boot/Makefile |3 + arch/powerpc/boot/dcr.h|4 + arch/powerpc/boot/dts

[PATCH 7/7] powerpc: Added PCI MSI support using the HSTA module

2014-02-20 Thread Alistair Popple
allow PCI devices write access to the HSTA module. Signed-off-by: Alistair Popple --- arch/powerpc/boot/dts/akebono.dts | 46 +-- arch/powerpc/boot/treeboot-akebono.c | 15 --- arch/powerpc/platforms/44x/Kconfig|2 + arch/powerpc/sysdev/Kconfig |6 + arch/powerpc

[PATCH 5/7] IBM Currituck: Clean up board specific code before adding Akebono code

2014-02-20 Thread Alistair Popple
. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/44x/Makefile|2 +- arch/powerpc/platforms/44x/currituck.c | 233 arch/powerpc/platforms/44x/ppc476.c| 233 3 files changed, 234 insertions(+), 234 deletions

[PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-20 Thread Alistair Popple
iver is removed and the 440EPX specific quirks are added to the ehci-platform driver. Signed-off-by: Alistair Popple --- drivers/usb/host/Kconfig |7 +- drivers/usb/host/ehci-hcd.c |5 - drivers/usb/host/ehci-platform.c | 87 +- drivers/u

[PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-20 Thread Alistair Popple
reasonable defaults if no platform data is present. This is similar to what is currently done in ehci-platform.c. Signed-off-by: Alistair Popple Acked-by: Alan Stern --- drivers/usb/host/ohci-platform.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 0/7] IBM Akebono/PPC476GTR Support

2014-02-20 Thread Alistair Popple
The IBM Akebono board is a development board for the new PPC476GTR system on chip (SoC). This is just a resubmission of the previous patches rebased on kernel v3.13. Ben H has indicated the subsystem specific changes should be merged via the appropriate kernel trees. Alistair Popple (7): IBM

[PATCH 1/7] IBM Akebono: Add a SDHCI platform driver

2014-02-20 Thread Alistair Popple
This patch adds a SDHCI platform driver for the new IBM PPC476GTR SoC which is on the Akebono board. Signed-off-by: Alistair Popple --- drivers/mmc/host/Kconfig | 12 drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-of-476gtr.c | 60

Re: [PATCH] powerpc: Fix build failure

2014-09-15 Thread Alistair Popple
Thanks for fixing these! Acked-by: Alistair Popple On Thu, 21 Aug 2014 09:04:31 Pranith Kumar wrote: > Fix the following build failure > > drivers/built-in.o: In function `nhi_init': > nhi.c:(.init.text+0x63390): undefined reference to `ehci_init_driver' > &g

Re: [PATCH] powerpc: Fix build failure when CONFIG_USB=y

2014-09-15 Thread Alistair Popple
Thanks for fixing these! Acked-by: Alistair Popple On Thu, 21 Aug 2014 09:16:04 Pranith Kumar wrote: > We are enabling USB unconditionally which results in following build failure > > drivers/built-in.o: In function `tb_drom_read': > (.text+0x1b62b70): undefined reference to

[PATCH 2/5 V2] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-03-10 Thread Alistair Popple
. Signed-off-by: Alistair Popple Acked-by: Benjamin Herrenschmidt --- This version just fixes the coding style as suggested by David M. .../devicetree/bindings/powerpc/4xx/emac.txt | 9 + drivers/net/ethernet/ibm/emac/Kconfig | 4 + drivers/net/ethernet/ibm/emac/Makefile

Re: [4/5] IBM Akebono: Add the Akebono platform

2014-05-01 Thread Alistair Popple
Paul, On Thu, 1 May 2014 11:27:27 Paul Bolle wrote: > On Thu, 2014-03-06 at 14:52 +1100, Alistair Popple wrote: [...] > > This patch adds support for the IBM Akebono board. > > + select IBM_EMAC_RGMII_WOL > > The patch that added this symbol (and the related driver) was

Re: [PATCH 2/5 V2] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-05-01 Thread Alistair Popple
take this through his tree (with your Ack)? Regards, Alistair On Tue, 11 Mar 2014 11:44:33 Alistair Popple wrote: > The IBM PPC476GTR SoC that is used on the Akebono board uses a > different ethernet PHY interface that has wake on lan (WOL) support > with the IBM emac. This patch adds

[PATCH] IBM Akebono: Remove obsolete config select

2014-05-02 Thread Alistair Popple
the obsolete symbol selection. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/44x/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 8beec7d..908bf11 100644 --- a/arch/powerpc/platforms/44x/Kconfig

Re: [PATCH] IBM Akebono: Remove obsolete config select

2014-06-19 Thread Alistair Popple
Hi Ben, It looks like we may have missed this trivial fix? Can you please apply it to your tree? Regards, Alistair On Fri, 13 Jun 2014 13:56:32 Paul Bolle wrote: > On Fri, 2014-05-02 at 18:06 +1000, Alistair Popple wrote: > > The original implementation of MMC support for Akebono int

[PATCH] powerpc/iommu: Fix initialisation of DART iommu table

2014-01-28 Thread Alistair Popple
updated. This commit initialises the it_page_shift field to 4K for the DART iommu. Signed-off-by: Alistair Popple --- arch/powerpc/sysdev/dart_iommu.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/dart_iommu.c b/arch/powerpc/sysdev/dart_iommu.c index bd968a4..62c47bb

Re: [PATCH] IBM Akebono: Remove obsolete config select

2014-09-04 Thread Alistair Popple
On Fri, 5 Sep 2014 00:20:42 Paul Bolle wrote: > > On Fri, 13 Jun 2014 13:56:32 Paul Bolle wrote: > > > On Fri, 2014-05-02 at 18:06 +1000, Alistair Popple wrote: > > > > The original implementation of MMC support for Akebono introduced a > > > > new co

Re: [PATCH kernel v4 11/11] powerpc/powernv/npu: Enable NVLink pass through

2016-05-05 Thread Alistair Popple
On Thu, 5 May 2016 15:49:18 Alexey Kardashevskiy wrote: > On 05/04/2016 12:08 AM, Alistair Popple wrote: > > Hi Alexey, > > > > On Fri, 29 Apr 2016 18:55:24 Alexey Kardashevskiy wrote: > >> IBM POWER8 NVlink systems come with Tesla K40-ish GPUs each of which > &

Re: [PATCH kernel v4 10/11] powerpc/powernv/npu: Rework TCE Kill handling

2016-05-05 Thread Alistair Popple
On Thu, 5 May 2016 14:23:20 Alexey Kardashevskiy wrote: > On 05/03/2016 05:37 PM, Alistair Popple wrote: > > On Fri, 29 Apr 2016 18:55:23 Alexey Kardashevskiy wrote: > >> The pnv_ioda_pe struct keeps an array of peers. At the moment it is only > >> used to link

Re: [PATCH kernel v4 08/11] powerpc/powernv/ioda2: Export debug helper pe_level_printk()

2016-05-02 Thread Alistair Popple
There's one call to pr_warn() in pnv_npu_disable_bypass() that could arguably be converted to pe_warn(), but we can clean that up later as the patch looks fine and I'm assuming subsequent patches make use of these. Reviewed-By: Alistair Popple On Fri, 29 Apr 2016 18:55:21 Alexey Kar

Re: [PATCH kernel v4 08/11] powerpc/powernv/ioda2: Export debug helper pe_level_printk()

2016-05-02 Thread Alistair Popple
On Tue, 3 May 2016 15:46:33 Alistair Popple wrote: > There's one call to pr_warn() in pnv_npu_disable_bypass() that could arguably > be converted to pe_warn(), but we can clean that up later as the patch looks > fine and I'm assuming subsequent patches make use of these.

Re: [PATCH kernel v4 09/11] powerpc/powernv/npu: Add set/unset window helpers

2016-05-02 Thread Alistair Popple
pu_pe->tce32_table as we always use > @@ -248,6 +289,10 @@ static int pnv_npu_dma_set_bypass(struct pnv_ioda_pe *npe) > if (phb->type != PNV_PHB_NPU || !npe->pdev) > return -EINVAL; > > + rc = pnv_npu_unset_window(npe); As noted in the commit mess

Re: [PATCH kernel v4 10/11] powerpc/powernv/npu: Rework TCE Kill handling

2016-05-03 Thread Alistair Popple
needed anymore. Happy to see it go. I'm not too familiar with iommu groups but based on the code and what you have described to me both here and offline everything looks good to me. One pretty minor style comment below. Reviewed-By: Alistair Popple > While we are here, add TCE cach

Re: [PATCH kernel v4 11/11] powerpc/powernv/npu: Enable NVLink pass through

2016-05-03 Thread Alistair Popple
>private_data; > + if (phb->type != PNV_PHB_NPU) > + return 0; > + > + *ptmppe = &phb->ioda.pe_array[pdn->pe_number]; > + > + return 1; > +} > + > +/* > + * This returns PE of associated NPU. > +

[PATCH v4 1/9] powerpc/powernv: Reorder OPAL subsystem initialisation

2015-05-14 Thread Alistair Popple
opal_init. Signed-off-by: Alistair Popple Cc: Mahesh Jagannath Salgaonkar --- arch/powerpc/include/asm/opal.h | 3 +++ arch/powerpc/platforms/powernv/opal-async.c | 3 +-- arch/powerpc/platforms/powernv/opal-hmi.c | 3 +-- arch/powerpc/platforms/powernv/opal

[PATCH v4 0/9] Convert OPAL notifier events to an irqchip

2015-05-14 Thread Alistair Popple
host (eg. mambo) Changes from v2: - Addressed comments by Neelesh Gupta - Fixed soft-lockup bug reported by Neelesh in the opal-dump driver - Rebased on v4.1-rc1 Alistair Popple (9): powerpc/powernv: Reorder OPAL subsystem initialisation powerpc/powernv: Add a virtual irqchip for opal events

[PATCH v4 9/9] opal: Remove events notifier

2015-05-14 Thread Alistair Popple
All users of the old opal events notifier have been converted over to the irq domain so remove the event notifier functions. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal-irqchip.c | 16 ++--- arch/powerpc/platforms/powernv/opal.c | 84

[PATCH v4 6/9] powernv/opal: Convert opal message events to opal irq domain

2015-05-14 Thread Alistair Popple
This patch converts the opal message event to use the new opal irq domain. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch

[PATCH v4 8/9] powernv/opal-dump: Convert to irq domain

2015-05-14 Thread Alistair Popple
Convert the opal dump driver to the new opal irq domain. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal-dump.c | 56 +- 1 file changed, 17 insertions(+), 39 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc

[PATCH v4 3/9] ipmi/powernv: Convert to irq event interface

2015-05-14 Thread Alistair Popple
Convert the opal ipmi driver to use the new irq interface for events. Signed-off-by: Alistair Popple Acked-by: Corey Minyard Cc: Corey Minyard Cc: openipmi-develo...@lists.sourceforge.net --- drivers/char/ipmi/ipmi_powernv.c | 39 ++- 1 file changed, 22

[PATCH v4 7/9] powernv/elog: Convert elog to opal irq domain

2015-05-14 Thread Alistair Popple
This patch converts the elog code to use the opal irq domain instead of notifier events. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal-elog.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH v4 5/9] powernv/eeh: Update the EEH code to use the opal irq domain

2015-05-14 Thread Alistair Popple
The eeh code currently uses the old notifier method to get eeh events from OPAL. It also contains some logic to filter opal events which has been moved into the virtual irqchip. This patch converts the eeh code to the new event interface which simplifies event handling. Signed-off-by: Alistair

[PATCH v4 4/9] hvc: Convert to using interrupts instead of opal events

2015-05-14 Thread Alistair Popple
Convert the opal hvc driver to use the new irqchip to register for opal events. As older firmware versions may not have device tree bindings for the interrupt parent we just use a hardcoded hwirq based on the event number. Signed-off-by: Alistair Popple --- drivers/tty/hvc/hvc_opal.c | 33

[PATCH v4 2/9] powerpc/powernv: Add a virtual irqchip for opal events

2015-05-14 Thread Alistair Popple
via the standard interrupt APIs by adding a new interrupt chip and domain. Drivers can then register for the appropriate events using standard kernel calls such as irq_of_parse_and_map(). Signed-off-by: Alistair Popple --- arch/powerpc/include/asm/opal.h | 3 + arch/powerpc

[PATCH v3 3/8] hvc: Convert to using interrupts instead of opal events

2015-05-06 Thread Alistair Popple
Convert the opal hvc driver to use the new irqchip to register for opal events. As older firmware versions may not have device tree bindings for the interrupt parent we just use a hardcoded hwirq based on the event number. Signed-off-by: Alistair Popple --- drivers/tty/hvc/hvc_opal.c | 33

[PATCH v3 5/8] powernv/opal: Convert opal message events to opal irq domain

2015-05-06 Thread Alistair Popple
This patch converts the opal message event to use the new opal irq domain. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch

[PATCH v3 4/8] powernv/eeh: Update the EEH code to use the opal irq domain

2015-05-06 Thread Alistair Popple
The eeh code currently uses the old notifier method to get eeh events from OPAL. It also contains some logic to filter opal events which has been moved into the virtual irqchip. This patch converts the eeh code to the new event interface which simplifies event handling. Signed-off-by: Alistair

[PATCH v3 7/8] powernv/opal-dump: Convert to irq domain

2015-05-06 Thread Alistair Popple
Convert the opal dump driver to the new opal irq domain. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal-dump.c | 56 +- 1 file changed, 17 insertions(+), 39 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc

[PATCH v3 6/8] powernv/elog: Convert elog to opal irq domain

2015-05-06 Thread Alistair Popple
This patch converts the elog code to use the opal irq domain instead of notifier events. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal-elog.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH v3 8/8] opal: Remove events notifier

2015-05-06 Thread Alistair Popple
All users of the old opal events notifier have been converted over to the irq domain so remove the event notifier functions. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/opal-irqchip.c | 16 ++--- arch/powerpc/platforms/powernv/opal.c | 84

[PATCH v3 1/8] powerpc/powernv: Add a virtual irqchip for opal events

2015-05-06 Thread Alistair Popple
via the standard interrupt APIs by adding a new interrupt chip and domain. Drivers can then register for the appropriate events using standard kernel calls such as irq_of_parse_and_map(). Signed-off-by: Alistair Popple --- Changes from v2: - Addressed comments by Neelesh Gupta - Fixed soft-lockup

[PATCH v3 2/8] ipmi/powernv: Convert to irq event interface

2015-05-06 Thread Alistair Popple
Convert the opal ipmi driver to use the new irq interface for events. Signed-off-by: Alistair Popple Cc: Corey Minyard Cc: openipmi-develo...@lists.sourceforge.net --- Corey, If this looks ok can you please ack it? Michael Ellerman will then take the whole series via the powerpc tree. Thanks

Re: [PATCH v4 4/9] hvc: Convert to using interrupts instead of opal events

2015-05-18 Thread Alistair Popple
On Tue, 19 May 2015 14:33:39 Michael Ellerman wrote: > On Fri, 2015-05-15 at 14:06 +1000, Alistair Popple wrote: > > Convert the opal hvc driver to use the new irqchip to register for > > opal events. As older firmware versions may not have device tree > > bindings for the int

Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL

2014-12-22 Thread Alistair Popple
Hi Paul, These days I've been made maintainer of the PPC4XX tree so maybe adding Acked- by: Alistair Popple might help? Jiri, if you would rather this go via the main PPC tree please let us know and we'll see if Michael Ellerman (added to CC) would be willing to take it (he has

Re: [BUG] RCU stall in cursor_timer_handler

2015-10-08 Thread Alistair Popple
Hi Scot, On Sat, 3 Oct 2015 05:12:15 Scot Doyle wrote: > On Sat, 3 Oct 2015, Alistair Popple wrote: > > Hi, > > > > We have been intermittently seeing the below RCU stall at boot on a > > PPC64LE 4.2.1 kernel which has been preventing the system from booting. > >

Re: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes

2016-10-20 Thread Alistair Popple
Hi Reza, On Thu, 6 Oct 2016 01:36:32 PM Reza Arbab wrote: > Respect the standard dt "status" property when scanning memory nodes in > early_init_dt_scan_memory(), so that if the node is unavailable, no > memory will be added. What happens if a kernel without this patch is booted on a system with

[PATCH 3/3] powerpc/powernv: Introduce address translation services for Nvlink2

2017-03-21 Thread Alistair Popple
when a device should stop issuing address translation requests (ATRs). It also adds a fault handler to allow device drivers to demand fault pages in. Signed-off-by: Alistair Popple --- arch/powerpc/include/asm/book3s/64/mmu.h | 6 + arch/powerpc/include/asm/opal-api.h| 5

[PATCH 2/3] powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev

2017-03-21 Thread Alistair Popple
. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/npu-dma.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c index 1c383f3..050bd5d 100644 --- a/arch/powerpc/platforms/powernv/npu

[PATCH 1/3] drivers/of/base.c: Add of_property_read_u64_index

2017-03-21 Thread Alistair Popple
There is of_property_read_u32_index but no u64 variant. This patch adds one similar to the u32 version for u64. Signed-off-by: Alistair Popple --- drivers/of/base.c | 31 +++ include/linux/of.h | 3 +++ 2 files changed, 34 insertions(+) diff --git a/drivers/of

[PATCH 1/2] mm/migrate: Fixup setting UFFD_WP flag

2020-08-24 Thread Alistair Popple
ion of the swap offset if the original PTE has the uffd_wp flag set. Fixes: f45ec5ff16a75 ("userfaultfd: wp: support swap and page migration") Signed-off-by: Alistair Popple Cc: sta...@vger.kernel.org --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] mm/rmap: Fixup copying of soft dirty and uffd ptes

2020-08-24 Thread Alistair Popple
Fixes: f45ec5ff16a7 ("userfaultfd: wp: support swap and page migration") Signed-off-by: Alistair Popple Cc: sta...@vger.kernel.org --- mm/migrate.c | 6 -- mm/rmap.c| 9 +++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index ddb

Re: [PATCH 2/2] mm/rmap: Fixup copying of soft dirty and uffd ptes

2020-08-24 Thread Alistair Popple
On Tuesday, 25 August 2020 1:43:59 AM AEST Peter Xu wrote: > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -2427,9 +2427,11 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > > > > entry = make_migration_entry(page, mpfn & > > > >

[PATCH v2 2/2] mm/rmap: Fixup copying of soft dirty and uffd ptes

2020-08-24 Thread Alistair Popple
Fixes: f45ec5ff16a7 ("userfaultfd: wp: support swap and page migration") Signed-off-by: Alistair Popple Cc: sta...@vger.kernel.org --- mm/migrate.c | 15 +++ mm/rmap.c| 9 +++-- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/mm/migrate.c b/m

[PATCH v2 1/2] mm/migrate: Fixup setting UFFD_WP flag

2020-08-24 Thread Alistair Popple
ion of the swap offset if the original PTE has the uffd_wp flag set. Fixes: f45ec5ff16a75 ("userfaultfd: wp: support swap and page migration") Signed-off-by: Alistair Popple Reviewed-by: Peter Xu Cc: sta...@vger.kernel.org --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

<    1   2   3   >