[PATCH] iio: accel: bma180: use iio helper function to guarantee direct mode

2016-07-19 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_claim_direct_mode() which does same. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- Peter: I was not clear if we want to keep the data->mutex lock in addition to claiming direct mode. I see that l

[PATCH] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-07-21 Thread Alison Schofield
Triggered buffer support uses the HDC100X's dual acquisition mode to read both humidity and temperature in one shot. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/humidity/Kconfig | 2 + drivers/iio/humidity/hdc100x.c | 144 +++

[PATCH v2] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-07-21 Thread Alison Schofield
Triggered buffer support uses the HDC100X's dual acquisition mode to read both humidity and temperature in one shot. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- Changes in v2: Thanks for the review Peter - switched endianness from IIO_CPU to IIO_BE - use only one buffer i

Re: [PATCH v2] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-07-22 Thread Alison Schofield
On Thu, Jul 21, 2016 at 10:31:46PM -0700, Alison Schofield wrote: > Triggered buffer support uses the HDC100X's dual acquisition mode > to read both humidity and temperature in one shot. > > Signed-off-by: Alison Schofield > Cc: Daniel Baluta > --- Reviewing mysel

[PATCH] iio: magnetometer: mag3110: claim direct mode during raw reads

2016-08-01 Thread Alison Schofield
Driver was checking for direct mode but not locking it. Use claim/release helper functions to guarantee the device stays in direct mode during raw reads. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/magnetometer/mag3110.c | 21 + 1 file changed, 13

[PATCH v3] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-09-01 Thread Alison Schofield
Triggered buffer support uses the HDC100X's dual acquisition mode to read both humidity and temperature in one shot. This patch depends on 447136effbf4 ("iio: humidity: hdc100x: fix sensor data reads of temp and humidity") Signed-off-by: Aliso

Re: [PATCH v3] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-09-02 Thread Alison Schofield
ll-known) commit your patch series was > built on] > [Check https://git-scm.com/docs/git-format-patch for more information] > > url: > https://github.com/0day-ci/linux/commits/Alison-Schofield/iio-humidity-hdc100x-add-triggered-buffer-support-for-HDC100X/20160902-055115 > :

[PATCH v4] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-09-02 Thread Alison Schofield
Triggered buffer support uses the HDC100X's dual acquisition mode to read both humidity and temperature in one shot. This patch depends on 447136effbf4 ("iio: humidity: hdc100x: fix sensor data reads of temp and humidity") Signed-off-by: Aliso

Re: A potential race in drivers/iio/adc/vf610_adc.ko

2016-09-02 Thread Alison Schofield
On Fri, Sep 02, 2016 at 11:05:09AM +0300, Pavel Andrianov wrote: > > Hi! > > There is a potential race in drivers/iio/adc/vf610_adc.ko. > Handlers vf610_set_conversion_mode and vf610_write_raw are called via > device_attibute interface, but they are related to different attributes, so > may be ex

Re: [PATCH v2] iio: adc: ltc2485: add support for Linear Technology LTC2485 ADC

2016-09-02 Thread Alison Schofield
On Mon, Aug 29, 2016 at 05:01:14PM +0100, Jonathan Cameron wrote: > On 25/08/16 06:48, Alison Schofield wrote: > > Adds basic support for the LTC2485 ADC - a delta-sigma analog-to-digital > > converter with an I2C interface that operates in single shot conversion > > mode

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-04 Thread Alison Schofield
> > > bits used for the measurement, the 8 most significant bits are correct, > > > > the lower 6 are not. > > > > > > > > None of the smbus read protocols follow the pattern this device > > requires > > > > (S Addr Rd [A

Re: [PATCH] iio: humidity: hdc100x: use i2c_master_recv to read sensor data

2016-08-04 Thread Alison Schofield
On Thu, Aug 04, 2016 at 03:21:13PM -0700, Matt Ranostay wrote: > On Thu, Aug 4, 2016 at 8:35 AM, Alison Schofield wrote: > > On Wed, Aug 03, 2016 at 10:50:54PM -0700, Matt Ranostay wrote: > >> On Wed, Aug 3, 2016 at 10:19 PM, Peter Meerwald-Stadler > >> wrote: > &g

[PATCH v2] iio: humidity: hdc100x: fix sensor data reads of temp and humidity

2016-08-08 Thread Alison Schofield
effect is that of the 14 bits used for the measurement, the 8 most significant bits are correct, the lower 6 are not. None of the smbus read protocols follow the pattern this device requires (S Addr Rd [A] Data [A] Data NA P), hence the switch to an i2c receive transaction. Signed-off-by: Alison

Re: [PATCH] iio: adc: ltc2485: add support for Linear Technology LTC2485 ADC

2016-08-23 Thread Alison Schofield
> [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for > convenience) to record what (public, well-known) commit your patch series was > built on] > [Check https://git-scm.com/docs/git-format-patch for more information] > > url: > https://github.com/

[PATCH v2] iio: adc: ltc2485: add support for Linear Technology LTC2485 ADC

2016-08-24 Thread Alison Schofield
ates in 1x speed mode. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- Changes in v2: - changed the wait conversion time function to use monotonic rather than real time and to use milliseconds rather than nanoseconds. - made conv time a constant int. Same notes as in v1: Reviewers

Re: [PATCHv5 10/19] x86/mm: Implement page_keyid() using page_ext

2018-07-23 Thread Alison Schofield
On Mon, Jul 23, 2018 at 12:45:17PM +0300, Kirill A. Shutemov wrote: > On Wed, Jul 18, 2018 at 04:38:02PM -0700, Dave Hansen wrote: > > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > > > Store KeyID in bits 31:16 of extended page flags. These bits are unused. > > > > I'd love a two sentence re

Re: [PATCH v2] x86,sched: allow topologies where NUMA nodes share an LLC

2018-03-23 Thread Alison Schofield
On Thu, Mar 22, 2018 at 05:42:41PM -0700, Tim Chen wrote: > On 03/22/2018 01:49 PM, Alison Schofield wrote: > > > > +*/ > > + if (!topology_same_node(c, o) && > > + (c->x86_vendor == X86_VENDOR_INTEL && > > +c->x86_model

Re: [PATCH v2] x86,sched: allow topologies where NUMA nodes share an LLC

2018-03-26 Thread Alison Schofield
On Thu, Mar 22, 2018 at 04:30:29PM -0700, Luck, Tony wrote: > On Thu, Mar 22, 2018 at 01:49:22PM -0700, Alison Schofield wrote: > > + if (!topology_same_node(c, o) && > > + (c->x86_vendor == X86_VENDOR_INTEL && > > +c->x86_model == IN

Re: [PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-06 Thread Alison Schofield
On Wed, Apr 04, 2018 at 12:00:45PM -0700, Alison Schofield wrote: > On Wed, Apr 04, 2018 at 11:42:11AM -0700, Tim Chen wrote: > > On 04/04/2018 10:38 AM, Alison Schofield wrote: > > > On Wed, Apr 04, 2018 at 10:24:49AM -0700, Tim Chen wrote: > > >> On 04/03/2018 02

[PATCH v5] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-06 Thread Alison Schofield
From: Alison Schofield Intel's Skylake Server CPUs have a different LLC topology than previous generations. When in Sub-NUMA-Clustering (SNC) mode, the package is divided into two "slices", each containing half the cores, half the LLC, and one memory controller and each slice i

[PATCH v2] x86,sched: allow topologies where NUMA nodes share an LLC

2018-03-22 Thread Alison Schofield
From: Alison Schofield Intel's Skylake Server CPUs have a different LLC topology than previous generations. When in Sub-NUMA-Clustering (SNC) mode, the package is divided into two "slices", each containing half the cores, half the LLC, and one memory controller and each slice i

[PATCH] selftests/vm/gup_benchmark.c: match gup struct to kernel

2018-12-07 Thread Alison Schofield
An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c. Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL. Signed-off-by: Alison Schofield --- tools/testing/selftests/vm

Re: [PATCH v7 1/5] dax/bus.c: replace driver-core lock usage by a local rwsem

2024-01-26 Thread Alison Schofield
tion and dax device configuration. As a result of this > conversion, no device_lock() usage remains in dax/bus.c. > Reviewed-by: Alison Schofield > Cc: Dan Williams > Reported-by: Greg Kroah-Hartman > Signed-off-by: Vishal Verma >

Re: [PATCH v7 2/5] dax/bus.c: replace several sprintf() with sysfs_emit()

2024-01-26 Thread Alison Schofield
; sysfs_emit() in this file. > Reviewed-by: Alison Schofield > Cc: Dan Williams > Reported-by: Greg Kroah-Hartman > Signed-off-by: Vishal Verma > --- > drivers/dax/bus.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > > d

Re: [PATCH v7 5/5] dax: add a sysfs knob to control memmap_on_memory behavior

2024-01-26 Thread Alison Schofield
hmem is set to 'false' - i.e. no memmap_on_memory semantics, to > preserve legacy behavior. For dax devices via CXL, the default is on. > The sysfs control allows the administrator to override the above > defaults if needed. Reviewed-by: Alison Schofield > > Cc: David Hil

Re: [PATCH] tracing: Add __string_src() helper to help compilers not to get confused

2024-03-15 Thread Alison Schofield
dev() as a string") being applied, as passing > the qdisc_dev() into __string_src() will give an error. > > Link: https://lore.kernel.org/all/ZfNmfCmgCs4Nc+EH@aschofie-mobl2/ Reviewed-by: Alison Schofield > > Reported-by: Alison Schofield > Signed-off-by: Steven Rosted

Re: [PATCH][next] dax: remove redundant assignment to variable rc

2024-04-15 Thread Alison Schofield
s/dax/bus.c:1207:2: warning: Value stored to 'rc' is never > read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Reviewed-by: Alison Schofield > --- > drivers/dax/bus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dax/bus.c b/drivers

Re: [PATCH] nvdimm/pmem: Set dax flag for all 'PFN_MAP' cases

2024-08-08 Thread Alison Schofield
XT4-fs (pmem7): DAX unsupported by block device. Tested-by: Alison Schofield > > Fixes: f467fee48da4 ("block: move the dax flag to queue_limits") > Signed-off-by: Zhihao Cheng > --- > drivers/nvdimm/pmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

Re: [PATCH] nvdimm: check for null return of devm_kmalloc in nd_pfn_probe

2023-02-26 Thread Alison Schofield
On Sun, Feb 26, 2023 at 01:56:15PM +0800, Kang Chen wrote: > devm_kmalloc may fails, pfn_sb might be null and will cause > null pointer dereference later. > > Signed-off-by: Kang Chen > --- > drivers/nvdimm/pfn_devs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvdimm/pfn

Re: [PATCH] nvdimm: Replace the usage of a variable by a direct function call in nd_pfn_validate()

2023-04-14 Thread Alison Schofield
On Fri, Apr 14, 2023 at 12:12:37PM +0200, Markus Elfring wrote: > Date: Fri, 14 Apr 2023 12:01:15 +0200 > > The address of a data structure member was determined before > a corresponding null pointer check in the implementation of > the function “nd_pfn_validate”. > > Thus avoid the risk for unde

Re: [PATCH] nvdimm: Replace the usage of a variable by a direct function call in nd_pfn_validate()

2023-04-14 Thread Alison Schofield
On Fri, Apr 14, 2023 at 06:50:59PM +0200, Markus Elfring wrote: > >> The address of a data structure member was determined before > >> a corresponding null pointer check in the implementation of > >> the function “nd_pfn_validate”. > >> > >> Thus avoid the risk for undefined behaviour by replacing

Re: [PATCH] dax/kmem: Pass valid argument to memory_group_register_static

2023-06-20 Thread Alison Schofield
On Tue, Jun 20, 2023 at 07:33:32PM +0530, Tarun Sahu wrote: > memory_group_register_static takes maximum number of pages as the argument > while dev_dax_kmem_probe passes total_len (in bytes) as the argument. This sounds like a fix. An explanation of the impact and a fixes tag may be needed. Also,

Re: [PATCH] ACPI: NFIT: add helper to_nfit_mem() to take device to nfit_mem

2023-07-05 Thread Alison Schofield
On Mon, Jul 03, 2023 at 02:17:29PM +0100, Ben Dooks wrote: > Add a quick helper to just do struct device to the struct nfit_mem > field it should be referencing. This reduces the number of code > lines in some of the followgn code as it removes the intermediate > struct nvdimm. > Hi Ben, This a u

Re: [PATCH] x86, sched: Allow NUMA nodes to share an LLC on Intel platforms

2021-02-16 Thread Alison Schofield
On Tue, Feb 16, 2021 at 12:29:02PM +0100, Peter Zijlstra wrote: > On Wed, Feb 10, 2021 at 02:11:34PM -0800, Alison Schofield wrote: > > > This is equivalent to determining if x86_has_numa_in_package. > > Do you think there is an opportunity to set x86_has_numa_in_package >

[PATCH v2] x86,sched: Update the Intel SNC CPU list that allows shared LLCs

2021-02-16 Thread Alison Schofield
e, Ice Lake and Sapphire Rapids servers will no longer emit this warning: sched: CPU #3's llc-sibling CPU #0 is not on the same node! [node: 1 != 0]. Ignoring dependency. Acked-by: Dave Hansen Signed-off-by: Alison Schofield Cc: Dave Hansen Cc: Tony Luck Cc: Tim Chen Cc: "H. P

Re: [PATCH v3] x86, sched: Treat Intel SNC topology as default, COD as exception

2021-04-08 Thread Alison Schofield
Ping - any feedback? Thanks! On Wed, Mar 10, 2021 at 11:02:33AM -0800, Alison Schofield wrote: > Commit 1340ccfa9a9a ("x86,sched: Allow topologies where NUMA nodes > share an LLC") added a vendor and model specific check to never > call topology_sane() for Intel Skylake Server

[PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-03 Thread Alison Schofield
From: Alison Schofield Intel's Skylake Server CPUs have a different LLC topology than previous generations. When in Sub-NUMA-Clustering (SNC) mode, the package is divided into two "slices", each containing half the cores, half the LLC, and one memory controller and each slice i

Re: [PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-04 Thread Alison Schofield
On Wed, Apr 04, 2018 at 10:24:49AM -0700, Tim Chen wrote: > On 04/03/2018 02:12 PM, Alison Schofield wrote: > > > + > > + /* > > +* topology_sane() considers LLCs that span NUMA nodes to be > > +* insane and will display a warning message. Bypass the ca

Re: [PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-04 Thread Alison Schofield
On Wed, Apr 04, 2018 at 11:42:11AM -0700, Tim Chen wrote: > On 04/04/2018 10:38 AM, Alison Schofield wrote: > > On Wed, Apr 04, 2018 at 10:24:49AM -0700, Tim Chen wrote: > >> On 04/03/2018 02:12 PM, Alison Schofield wrote: > >> > >>> + > >>> + /*

[PATCH v3] x86,sched: allow topologies where NUMA nodes share an LLC

2018-03-28 Thread Alison Schofield
From: Alison Schofield Intel's Skylake Server CPUs have a different LLC topology than previous generations. When in Sub-NUMA-Clustering (SNC) mode, the package is divided into two "slices", each containing half the cores, half the LLC, and one memory controller and each slice i

[PATCH] acpi/hmat: Update acpi_hmat_type enum with ACPI_HMAT_TYPE_PROXIMITY

2019-04-17 Thread Alison Schofield
um type to match the subtable and structure naming. Signed-off-by: Alison Schofield --- drivers/acpi/hmat/hmat.c | 4 ++-- include/acpi/actbl1.h| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c index b7824a0309f7..3e321

Re: [PATCH] x86, sched: Allow NUMA nodes to share an LLC on Intel platforms

2021-02-10 Thread Alison Schofield
On Wed, Feb 10, 2021 at 08:38:42PM +0100, Peter Zijlstra wrote: > On Wed, Feb 10, 2021 at 07:22:03AM -0800, Dave Hansen wrote: > > On 2/10/21 12:05 AM, Peter Zijlstra wrote: > > >> +if (IS_ENABLED(CONFIG_NUMA)) > > >> +set_cpu_bug(c, X86_BUG_NUMA_SHARES_LLC); > > >> } > > >

[PATCH] x86, sched: Allow NUMA nodes to share an LLC on Intel platforms

2021-02-09 Thread Alison Schofield
ke and Sapphire Rapids CPUs exhibit the same topology. Rather than maintain the quirk list, define a synthetic flag that directs the scheduler to allow this topology without warning for all Intel CPUs when NUMA is configured. Acked-by: Dave Hansen Signed-off-by: Alison Schofield Cc: Dave Hansen Cc

[PATCH v3] x86, sched: Treat Intel SNC topology as default, COD as exception

2021-03-10 Thread Alison Schofield
eption. In SNC mode, Sky Lake, Ice Lake, and Sapphire Rapids servers do not emit this warning: sched: CPU #3's llc-sibling CPU #0 is not on the same node! [node: 1 != 0]. Ignoring dependency. Acked-by: Dave Hansen Suggested-by: Peter Zijlstra (Intel) Signed-off-by: Alison Schofield Cc: st

[PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

2016-05-20 Thread Alison Schofield
hdc100x supports Texas Instruments HDC1000 and HDC1008 relative humidity and temperature sensors. Add these product names to Kconfig and to the drivers device id structure to enable finding the product by name and using it to add a device. Signed-off-by: Alison Schofield Cc: Daniel Baluta

[PATCH] iio: humidity: hdc100x: correct humidity integration time mask

2016-05-20 Thread Alison Schofield
Apply the correct mask to enable all available humidity integration times. Currently, the driver defaults to 6500 and all is okay with that. However, if 3850 is selected we get a stuck bit and can't change back to 6500 or select 2500. (Verified with HDC1008) Signed-off-by: Alison Schofiel

[PATCH 0/7] iio: adc: clean up claims on direct mode in ad7* drivers

2016-05-24 Thread Alison Schofield
(7476,7887,7923,799x) were already locking so these are migrations to the claim/release helper functions. Worth noting: This does not clean up all mlock (ab-)uses in ad799x. This driver is still using mlock in a few other places not associated with locking down direct mode. Alison Schofield (7): iio: adc

[PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read

2016-05-24 Thread Alison Schofield
Driver was checking for direct mode but not locking it down. Use iio_device_claim_direct_mode() to guarantee device stays in direct mode. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad7266.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[PATCH 2/7] iio: adc: ad7791: claim direct mode when writing frequency

2016-05-24 Thread Alison Schofield
Driver was checking for direct mode and trying to lock it, but left a gap where mode could change before the desired operation. Use iio_device_claim_direct_mode() to guarantee device stays in direct mode. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad7791.c | 15

[PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency

2016-05-24 Thread Alison Schofield
Driver was checking for direct mode and trying to lock it, but left a gap where mode could change before the desired operation. Use iio_device_claim_direct_mode() to guarantee device stays in direct mode. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad7793.c | 13

[PATCH 4/7] iio: adc: ad7476: use iio helper function to guarantee direct mode

2016-05-24 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_claim_direct_mode() which does same. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad7476.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc

[PATCH 5/7] iio: adc: ad7887: use iio helper function to guarantee direct mode

2016-05-24 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_claim_direct_mode() which does same. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad7887.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc

[PATCH 6/7] iio: adc: ad7923: use iio helper function to guarantee direct mode

2016-05-24 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_claim_direct_mode() which does same. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad7923.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc

[PATCH 7/7] iio: adc: ad799x: use iio helper function to guarantee direct mode

2016-05-24 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_claim_direct_mode() which does same. Signed-off-by: Alison Schofield Cc: Daniel Baluta --- drivers/iio/adc/ad799x.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a

[PATCH] iio: light: jsa1212: remove unneeded i2c check functionality test

2016-05-15 Thread Alison Schofield
This driver does not call i2c_smbus_read|write_byte_data(), so remove the corresponding functionality test. It uses regmap to handle byte transfers transparently. Signed-off-by: Alison Schofield --- Found & fixed by inspection based on same defect recently fixed in light/tpl0102 dr

[PATCH v2] scsi: gdth: replace struct timeval with ktime_get_real_seconds()

2015-11-24 Thread Alison Schofield
iece itself doesn't warrant an alternative, but if we do introduce a new structure & ioctl with u64 timestamps, this would change accordingly. Signed-off-by: Alison Schofield --- Changes in v2: - remove unnecessary ktime.h includes - add comment in code to explain elapsed time calcu

[RESEND PATCH v2] scsi: gdth: replace struct timeval with ktime_get_real_seconds()

2016-02-17 Thread Alison Schofield
iece itself doesn't warrant an alternative, but if we do introduce a new structure & ioctl with u64 timestamps, this would change accordingly. Signed-off-by: Alison Schofield Reviewed-by: Arnd Bergmann --- Changes in v2: - remove unnecessary ktime.h includes - add comment in code to

[RESEND PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps

2016-02-17 Thread Alison Schofield
, start_usec. Signed-off-by: Alison Schofield Reviewed-by: Arnd Bergmann --- Changes in v3: - use elapsed time since system boot in place of elapsed time since module load - commit message updated - changelog updated Changes in v2: - switched to monotonic time - removed the unused

[RFC PATCH v2 0/2] iio: introduce iio_device_{claim|release}_direct_mode()

2016-03-09 Thread Alison Schofield
refix for new functions o replace EINVAL with EBUSY on failure to claim direct mode o update commit msg & changelog to reflect new prefix Alison Schofield (2): iio: core: implement iio_device_{claim|release}_direct_mode() staging: iio: ad7192: use iio_device_{claim|release}_direct_mode()

[RFC PATCH v2 1/2] iio: core: implement iio_device_{claim|release}_direct_mode()

2016-03-09 Thread Alison Schofield
. iio_device_release_direct_mode() Release the claim. Device is no longer guaranteed to stay in direct mode. Signed-off-by: Alison Schofield --- drivers/iio/industrialio-core.c | 39 +++ include/linux/iio/iio.h | 2 ++ 2 files changed

[RFC PATCH v2 2/2] staging: iio: ad7192: use iio_device_{claim|release}_direct_mode()

2016-03-09 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_{claim|release}_direct_mode() which does same. Signed-off-by: Alison Schofield --- drivers/staging/iio/adc/ad7192.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a

Re: [RFC PATCH 1/2] iio: core: implement iio_{claim|release}_direct_mode()

2016-03-09 Thread Alison Schofield
On Sat, Mar 05, 2016 at 06:02:36PM +, Jonathan Cameron wrote: > On 02/03/16 13:28, Lars-Peter Clausen wrote: > > On 03/01/2016 08:02 PM, Alison Schofield wrote: > >> It is often the case that the driver wants to be sure a device stays > >> in direct mode while it is

[PATCH] staging: wilc1000: move initialization of the config values

2016-04-07 Thread Alison Schofield
et it, then the lock isn't needed. If another thread can get it, it could find it before the mutex is initialized. Make it safe and simple by setting the config values and initializing their mutex before the kthread is started. No lock/unlock needed. Signed-off-by: Alison Schofield ---

[PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/accel/bmc150-accel-core.c | 99

[PATCH v2 2/5] iio: accel: mxc4005: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/accel/mxc4005.c | 26 +++--- 1 file

[PATCH v2 0/5] iio: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
line of _probe gets regmap from parent accel: bmc150 gyro: bmg160 Keep: regmap passed into _probe from i2c,spi_probe where it was initialized for this device accel: mxc4005 health: afe4403 health: afe4404 Keep: regmap initialized in _probe for this device Alison S

[PATCH v2 3/5] iio: health: afe4403: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4403.c | 36

[PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4404.c | 38

[PATCH v2 5/5] iio: gyro: bmg160: use regmap to retrieve struct device

2016-04-10 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/gyro/bmg160_core.c | 86

Re: [PATCH] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

2016-04-05 Thread Alison Schofield
On Sun, Apr 03, 2016 at 10:09:13AM +0100, Jonathan Cameron wrote: > On 01/04/16 17:53, Alison Schofield wrote: > > Two instances are moved to the new claim/release API: > > > > In the first instance, the driver was using mlock followed by > > iio_buffer_enabled(). Rep

[PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

2016-04-05 Thread Alison Schofield
Replace the code that guarantees the device stays in direct mode with iio_device_{claim|release}_direct_mode() which does same. Signed-off-by: Alison Schofield --- Changed in v2: - removed improper application of claim/release from intr handler - updated changelog drivers/staging/iio/adc

[PATCH 1/9] iio: adc: exynos_adc: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/adc/exynos_adc.c | 18 +- 1 file changed, 9

[PATCH 0/9] iio: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Coccinelle plus hand edits for whitespace and one local var naming collision. Alison Schofield (9): iio: adc: exynos_adc: use regmap to retrieve struct device iio: adc: qcom-spmi-iadc: use regmap to retrieve struct device iio: adc: qcom-spmi-vadc: use regmap to retrieve struct device iio

[PATCH 4/9] iio: accel: bmc150: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/accel/bmc150-accel-core.c | 99

[PATCH 3/9] iio: adc: qcom-spmi-vadc: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/adc/qcom-spmi-vadc.c | 37

[PATCH 2/9] iio: adc: qcom-spmi-iadc: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/adc/qcom-spmi-iadc.c | 32

[PATCH 5/9] iio: accel: mma7455: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/accel/mma7455_core.c | 5 ++--- 1 file changed, 2

[PATCH 6/9] iio: accel: mxc4005: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/accel/mxc4005.c | 26 +++--- 1 file

[PATCH 7/9] iio: health: afe4403: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4403.c | 36

[PATCH 9/9] iio: gyro: bmg160_core: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/gyro/bmg160_core.c | 86

[PATCH 8/9] iio: health: afe4404: use regmap to retrieve struct device

2016-04-05 Thread Alison Schofield
Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Patch created using Coccinelle plus manual edits. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4404.c | 38

Re: [PATCH 1/9] iio: adc: exynos_adc: use regmap to retrieve struct device

2016-04-06 Thread Alison Schofield
On Wed, Apr 06, 2016 at 09:03:00AM +0200, Marek Szyprowski wrote: > Hello, > > On 2016-04-06 07:15, Alison Schofield wrote: > >Driver includes struct regmap and struct device in its global data. > >Remove the struct device and use regmap API to retrieve device info. >

Re: [PATCH v2 4/5] iio: health: afe4404: use regmap to retrieve struct device

2016-04-17 Thread Alison Schofield
On Sun, Apr 17, 2016 at 01:07:52PM -0500, Andrew F. Davis wrote: > On 04/16/2016 02:22 PM, Jonathan Cameron wrote: > > On 10/04/16 20:07, Alison Schofield wrote: > >> Driver includes struct regmap and struct device in its global data. > >> Remove the struct device and

[PATCH] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

2016-04-01 Thread Alison Schofield
not using mlock to hold the device in direct mode, but should have been. Here we introduce the new API to guarantee direct mode. This is a change in driver behavior. Signed-off-by: Alison Schofield --- drivers/staging/iio/adc/ad7606_core.c | 15 --- 1 file changed, 8 insertions

[PATCH v3] scsi: pmcraid: replace struct timeval with ktime_get_real_seconds()

2015-11-09 Thread Alison Schofield
c64 ts; ktime_get_real_ts64(&ts); timestamp = ts.tv_sec * MSEC_PER_SEC + ts.tv_nsec / NSEC_PER_MSEC; MAINTAINER: Please request alternate change if preferred. Signed-off-by: Alison Schofield --- Change in v3: * move alternative change proposal above the '---' to save Changes in v2: * ad

Re: [PATCH, RFC 48/62] selftests/x86/mktme: Test the MKTME APIs

2019-05-08 Thread Alison Schofield
Please ignore this patch. It includes an outdated draft from early testing. Other than showing our intent to deliver selftests, it is not out for review. Alison

Re: [PATCH] acpi/hmat: Update acpi_hmat_type enum with ACPI_HMAT_TYPE_PROXIMITY

2019-04-19 Thread Alison Schofield
On Thu, Apr 18, 2019 at 05:07:12PM +0200, Rafael J. Wysocki wrote: > On Thu, Apr 18, 2019 at 5:02 PM Keith Busch wrote: > > > > On Wed, Apr 17, 2019 at 11:13:10AM -0700, Alison Schofield wrote: > > > ACPI 6.3 changed the subtable "Memory Subsystem Address Rang

Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload

2019-08-05 Thread Alison Schofield
On Mon, Aug 05, 2019 at 07:58:19AM -0400, Ben Boeckel wrote: > On Wed, Jul 31, 2019 at 18:07:39 +0300, Kirill A. Shutemov wrote: > > From: Alison Schofield > > +/* Make sure arguments are correct for the TYPE of key requested */ > > +static int mktme_check_options(u32 *p

Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

2019-08-05 Thread Alison Schofield
On Mon, Aug 05, 2019 at 07:58:37AM -0400, Ben Boeckel wrote: > On Wed, Jul 31, 2019 at 18:08:11 +0300, Kirill A. Shutemov wrote: > > + key = add_key("mktme", "name", "no-encrypt", strlen(options_CPU), > > + KEY_SPEC_THREAD_KEYRING); > > Should this be `type=no-encrypt` here? Also

Re: [PATCH v3] x86,sched: allow topologies where NUMA nodes share an LLC

2018-03-30 Thread Alison Schofield
On Wed, Mar 28, 2018 at 05:00:24PM -0700, Alison Schofield wrote: > From: Alison Schofield > > Intel's Skylake Server CPUs have a different LLC topology than previous > generations. When in Sub-NUMA-Clustering (SNC) mode, the package is > divided into two "slices",

[PATCH] iio: trigger: free trigger resource correctly

2017-01-17 Thread Alison Schofield
Using iio_trigger_put() to free a trigger leads to release of a resource we never held. Replace with iio_trigger_free(). Signed-off-by: Alison Schofield --- Patches to use devm_* funcs are ready to follow this for the interrupt & bfin-timer triggers. drivers/iio/trigger/iio-trig-interru

Re: [PATCH] iio: trigger: free trigger resource correctly

2017-01-18 Thread Alison Schofield
On Wed, Jan 18, 2017 at 12:56:29PM +0300, Dan Carpenter wrote: > On Tue, Jan 17, 2017 at 07:00:28PM -0800, Alison Schofield wrote: > > Using iio_trigger_put() to free a trigger leads to release of > > a resource we never held. Replace with iio_trigger_free(). > > They&

[PATCH] iio: health: afe4404: retrieve a valid iio_dev in suspend/resume

2017-01-14 Thread Alison Schofield
The suspend/resume functions were using dev_to_iio_dev() to get the iio_dev. That only works on IIO dev's. Replace it with i2c functions to get the correct iio_dev. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4404.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume

2017-01-14 Thread Alison Schofield
The suspend/resume functions were using dev_to_iio_dev() to get the iio_dev. That only works on IIO dev's. Replace it with spi functions to get the correct iio_dev. Signed-off-by: Alison Schofield --- drivers/iio/health/afe4403.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] iio: bmi160: use variable names for sizeof() operator

2017-01-15 Thread Alison Schofield
Replace the types with the actual variable names when using the sizeof() operator. This is kernel preferred style as it protects against future changes to variable type. Signed-off-by: Alison Schofield --- drivers/iio/imu/bmi160/bmi160_core.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume

2017-01-16 Thread Alison Schofield
On Mon, Jan 16, 2017 at 10:38:27AM -0600, Andrew F. Davis wrote: > On 01/14/2017 09:51 PM, Alison Schofield wrote: > > The suspend/resume functions were using dev_to_iio_dev() to get > > the iio_dev. That only works on IIO dev's. Replace it with spi > > functions

Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume

2017-01-16 Thread Alison Schofield
On Mon, Jan 16, 2017 at 12:22:03PM -0600, Andrew F. Davis wrote: > On 01/16/2017 12:10 PM, Alison Schofield wrote: > > On Mon, Jan 16, 2017 at 10:38:27AM -0600, Andrew F. Davis wrote: > >> On 01/14/2017 09:51 PM, Alison Schofield wrote: > >>> The suspend/resume funct

[PATCH] iio: adc: palmas_gpadc: retrieve a valid iio_dev in suspend/resume

2017-01-16 Thread Alison Schofield
The suspend/resume functions were using dev_to_iio_dev() to get the iio_dev. That only works on IIO dev's. Use dev_get_drvdata() for a platform device to get the correct iio_dev. Signed-off-by: Alison Schofield --- drivers/iio/adc/palmas_gpadc.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH v2] iio: trigger: free trigger resource correctly

2017-01-19 Thread Alison Schofield
emove path (not so rare). Tested with the sysfs trigger driver. The bfin & interrupt drivers were build tested & inspected only. Signed-off-by: Alison Schofield --- Changes in v2: Renamed probe jump label to say free instead of put. Added further explanation to commit log. Note from v1:

[PATCH] iio: pressure: ms5611: claim direct mode during oversampling changes

2017-01-20 Thread Alison Schofield
conflicting direct mode access of the state data. Signed-off-by: Alison Schofield --- drivers/iio/pressure/ms5611_core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c index 6bd53e7..2a77a2f

  1   2   3   >