Re: [PATCH bpf-next v3 3/3] xsk: build skb by page

2021-01-22 Thread Alexander Lobakin
From: Xuan Zhuo Date: Fri, 22 Jan 2021 23:39:15 +0800 > On Fri, 22 Jan 2021 13:55:14 +0100, Magnus Karlsson > wrote: > > On Fri, Jan 22, 2021 at 1:39 PM Alexander Lobakin wrote: > > > > > > From: Magnus Karlsson > > > Date: Fri, 22 Jan 2021 13:18:47 +

[PATCH v4 net-next 2/2] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

2021-01-22 Thread Alexander Lobakin
ence. This keeps the current behaviour and is generally more optimal for now, as the number of NICs with hardware USO offload is relatively small. Signed-off-by: Alexander Lobakin --- net/ipv4/udp_offload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/udp_

[PATCH v4 net-next 1/2] net: introduce a netdev feature for UDP GRO forwarding

2021-01-22 Thread Alexander Lobakin
Introduce a new netdev feature, NETIF_F_GRO_UDP_FWD, to allow user to turn UDP GRO on and off for forwarding. Defaults to off to not change current datapath. Suggested-by: Paolo Abeni Signed-off-by: Alexander Lobakin --- include/linux/netdev_features.h | 4 +++- net/ethtool/common.c

[PATCH v4 net-next 0/2] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

2021-01-22 Thread Alexander Lobakin
forwarding. [0] https://lore.kernel.org/netdev/20210112211536.261172-1-aloba...@pm.me [1] https://lore.kernel.org/netdev/20210113103232.4761-1-aloba...@pm.me [2] https://lore.kernel.org/netdev/20210118193122.87271-1-aloba...@pm.me Alexander Lobakin (2): net: introduce a netdev feature for UDP

Re: [PATCH bpf-next v3 3/3] xsk: build skb by page

2021-01-22 Thread Alexander Lobakin
From: Magnus Karlsson Date: Fri, 22 Jan 2021 19:37:06 +0100 > On Fri, Jan 22, 2021 at 6:26 PM Alexander Lobakin wrote: > > > > From: Xuan Zhuo > > Date: Fri, 22 Jan 2021 23:39:15 +0800 > > > > > On Fri, 22 Jan 2021 13:55:14 +0100, Magnus Karlsson > >

Re: Old platforms: bring out your dead

2021-02-05 Thread Alexander Lobakin
From: Arnd Bergmann Date: Fri, 8 Jan 2021 23:55:06 +0100 > After v5.10 was officially declared an LTS kernel, I had a look around > the Arm platforms that look like they have not seen any patches from > their maintainers or users that are actually running the hardware for > at least five years (2

Re: [PATCH net] net: gro: do not keep too many GRO packets in napi->rx_list

2021-02-05 Thread Alexander Lobakin
al packets. > > > > > > Fixes: c80794323e82 ("net: Fix packet reordering caused by GRO and > > > listified RX cooperation") > > > Signed-off-by: Eric Dumazet > > > Bisected-by: John Sperbeck > > > Tested-by: Jian Yang > > > Cc: Maxim

[PATCH mips-fixes] MIPS: compressed: fix build with enabled UBSAN

2021-02-08 Thread Alexander Lobakin
0x9c): more undefined references to `__ubsan_handle_shift_out_of_bounds' follow Add UBSAN_SANITIZE := n to mips/boot/compressed/Makefile to exclude it from instrumentation scope and fix this issue. Fixes: 1e35918ad9d1 ("MIPS: Enable Undefined Behavior Sanitizer UBSAN") Cc: sta...@vger.

Re: [PATCH bpf-next v3 3/3] xsk: build skb by page

2021-01-25 Thread Alexander Lobakin
From: Xuan Zhuo Date: Mon, 25 Jan 2021 11:10:43 +0800 > On Fri, 22 Jan 2021 16:24:17 +0000, Alexander Lobakin wrote: > > From: Xuan Zhuo > > Date: Fri, 22 Jan 2021 23:36:29 +0800 > > > > > On Fri, 22 Jan 2021 12:08:00 +, Alexander Lobakin > > >

Re: [PATCH bpf-next v3 3/3] xsk: build skb by page

2021-01-25 Thread Alexander Lobakin
From: Xuan Zhuo Date: Mon, 25 Jan 2021 22:57:07 +0800 > On Mon, 25 Jan 2021 13:25:45 +0000, Alexander Lobakin wrote: > > From: Xuan Zhuo > > Date: Mon, 25 Jan 2021 11:10:43 +0800 > > > > > On Fri, 22 Jan 2021 16:24:17 +, Alexander Lobakin > &

[PATCH net-next 0/3] net: constify page_is_pfmemalloc() and its users

2021-01-25 Thread Alexander Lobakin
page_is_pfmemalloc() is used mostly by networking drivers. It doesn't write anything to the struct page itself, so constify its argument and a bunch of callers and wrappers around this function in drivers. In Page Pool core code, it can be simply inlined instead. Alexander Lobakin (3):

[PATCH net-next 1/3] mm: constify page_is_pfmemalloc() argument

2021-01-25 Thread Alexander Lobakin
The function only tests for page->index, so its argument should be const. Signed-off-by: Alexander Lobakin --- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ecdf8a8cd6ae..078633d43af9 100644 --- a/incl

[PATCH net-next 3/3] net: page_pool: simplify page recycling condition tests

2021-01-26 Thread Alexander Lobakin
pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, this function is just a redundant wrapper over page_is_pfmemalloc(), so Inline it into its sole call site. Signed-off-by: Alexander Lobakin --- net/core/page_pool.c | 14 -- 1 file changed, 4 insertions(+), 10

[PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup

2021-01-04 Thread Alexander Lobakin
This series hunts the problems discovered after manual enabling of ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA() section affecting VDSO placement (marked for stable). Compile and runtime tested on MIPS32R2 CPS board with no issues. Alexander Lobakin (4): MIPS: vmlinux.lds.S

[PATCH mips-next 2/4] MIPS: vmlinux.lds.S: add ".rel.dyn" to DISCARDS

2021-01-04 Thread Alexander Lobakin
discard it from the final vmlinux as kernel doesn't use or support dynamic relocations. Misc: sort DISCARDS section entries alphabetically. Signed-off-by: Alexander Lobakin --- arch/mips/kernel/vmlinux.lds.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/mips/ke

[PATCH mips-next 3/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-04 Thread Alexander Lobakin
7; mips-alpine-linux-musl-ld: warning: orphan section `.gnu.attributes' from `init/main.o' being placed in section `.gnu.attributes' Signed-off-by: Alexander Lobakin --- arch/mips/kernel/vmlinux.lds.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kernel/vmlinux.lds

[PATCH mips-next 4/4] MIPS: select ARCH_WANT_LD_ORPHAN_WARN

2021-01-04 Thread Alexander Lobakin
Now, after that all the sections are explicitly described and declared in vmlinux.lds.S, we can enable ld orphan warnings to prevent from missing any new sections in future. Signed-off-by: Alexander Lobakin --- arch/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips

[PATCH mips-next 1/4] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section

2021-01-04 Thread Alexander Lobakin
xes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") Cc: sta...@vger.kernel.org # 4.4+ Signed-off-by: Alexander Lobakin --- arch/mips/kernel/vmlinux.lds.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S index 5e97e9d02f98.

[PATCH mips-next] MIPS: UAPI: unexport unistd_nr_{n32,n64,o32}.h

2021-01-04 Thread Alexander Lobakin
-off-by: Alexander Lobakin --- arch/mips/include/asm/Kbuild | 4 arch/mips/include/uapi/asm/Kbuild | 3 --- arch/mips/kernel/syscalls/Makefile | 16 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm

RE: [PATCH net] udp: ipv4: manipulate network header of NATed UDP GRO fraglist

2021-01-15 Thread Alexander Lobakin
From: Dongseok Yi Date: Fri, 15 Jan 2021 20:21:06 +0900 > On 2021-01-15 19:51, Alexander Lobakin wrote: >> From: Steffen Klassert >> Date: Fri, 15 Jan 2021 10:27:52 +0100 >> >>> On Fri, Jan 15, 2021 at 05:55:22PM +0900, Dongseok Yi wrote: >>>> O

Re: [PATCH net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too

2021-01-15 Thread Alexander Lobakin
From: Eric Dumazet Date: Fri, 15 Jan 2021 15:28:37 +0100 > On Fri, Jan 15, 2021 at 12:55 AM Alexander Lobakin wrote: >> >> Commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for >> tiny skbs") ensured that skbs with data size lower than 1025 bytes

[PATCH v2 net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too

2021-01-15 Thread Alexander Lobakin
to handle this case too. Since v1 [0]: - fix "Fixes:" tag; - refine commit message (mention copybreak usecase). [0] https://lore.kernel.org/netdev/20210114235423.232737-1-aloba...@pm.me Fixes: a1c7fff7e18f ("net: netdev_alloc_skb() use build_skb()") Signed-off-by: Alexander

Re: [PATCH net v2] udp: ipv4: manipulate network header of NATed UDP GRO fraglist

2021-01-15 Thread Alexander Lobakin
/ > I was trying to write a quick fix, but it was not easy to forward > segmented list. Currently, assuming DNAT only. > > v2: > Per Steffen Klassert request, move the procedure from > udp4_ufo_fragment to __udp_gso_segment_list and support SNAT. > > To Alexander Lobakin, I'v

[PATCH net-next] mdio, phy: fix -Wshadow warnings triggered by nested container_of()

2021-01-16 Thread Alexander Lobakin
rom linux/{mdio,phy}.h to static inlines to avoid self-shadowing and potentially improve bug-catching. No functional changes implied. Signed-off-by: Alexander Lobakin --- include/linux/mdio.h | 23 ++- include/linux/phy.h | 7 +-- 2 files changed, 23 insertions(+), 7 d

[PATCH pci-next] PCI: dwc: put struct dw_pcie::{ep,pp} into a union to reduce its size

2021-01-16 Thread Alexander Lobakin
ff-by: Alexander Lobakin --- drivers/pci/controller/dwc/pcie-designware.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 5d979953800d..924ebeaa3885 100644 --- a/driver

[PATCH mips-next 0/2] MIPS: optimize relocations processing

2021-01-16 Thread Alexander Lobakin
code size. Tested on MIPS32 R2 with GCC 10.2 and LLVM 11.0 with -O2. Alexander Lobakin (2): MIPS: module: optimize module relocations processing MIPS: relocatable: optimize the relocation process arch/mips/kernel/module.c | 109 +--- arch/mips/kernel

[PATCH mips-next 2/2] MIPS: relocatable: optimize the relocation process

2021-01-16 Thread Alexander Lobakin
, After=16, chg -82.61% add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0) RO Data old new delta Total: Before=0, After=0, chg +0.00% All functions were collapsed into the main one, relocate_kernel(). Signed-off-by: Alexander Lobakin --- arch/mips/kernel/

[PATCH mips-next 1/2] MIPS: module: optimize module relocations processing

2021-01-16 Thread Alexander Lobakin
Data old new delta reloc_handlers 248 --248 Total: Before=248, After=0, chg -100.00% All functions were collapsed into a single one that is called directly by $(srctree)/kernel/module.c. Signed-off-by: Alexander Lobakin --- arch/mips/k

[PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites

2021-01-25 Thread Alexander Lobakin
Constify "page" argument for page_is_pfmemalloc() users where applicable. Signed-off-by: Alexander Lobakin --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +

Re: [PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites

2021-01-25 Thread Alexander Lobakin
From: David Rientjes Date: Mon, 25 Jan 2021 10:19:48 -0800 (PST) > On Mon, 25 Jan 2021, Alexander Lobakin wrote: > > > Constify "page" argument for page_is_pfmemalloc() users where applicable. > > > > Signed-off-by: Alexander Lobakin > > --- > > d

[PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage

2021-01-27 Thread Alexander Lobakin
an be reused/recycled (David Rientjes); - collect autographs for Page Pool bits (Jesper Dangaard Brouer, Ilias Apalodimas). [0] https://lore.kernel.org/netdev/20210125164612.243838-1-aloba...@pm.me Alexander Lobakin (4): mm: constify page_is_pfmemalloc() argument skbuff: con

[PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument

2021-01-27 Thread Alexander Lobakin
The function only tests for page->index, so its argument should be const. Signed-off-by: Alexander Lobakin --- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ecdf8a8cd6ae..078633d43af9 100644 --- a/incl

[PATCH v2 net-next 2/4] skbuff: constify skb_propagate_pfmemalloc() "page" argument

2021-01-27 Thread Alexander Lobakin
The function doesn't write anything to the page struct itself, so this argument can be const. Misc: align second argument to the brace while at it. Signed-off-by: Alexander Lobakin --- include/linux/skbuff.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/

[PATCH v2 net-next 4/4] net: page_pool: simplify page recycling condition tests

2021-01-27 Thread Alexander Lobakin
pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, this function is just a redundant wrapper over page_is_pfmemalloc(), so Inline it into its sole call site. Signed-off-by: Alexander Lobakin Acked-by: Jesper Dangaard Brouer Reviewed-by: Ilias Apalodimas --- net/core

[PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

2021-01-27 Thread Alexander Lobakin
eliminate all functions-duplicates from drivers. Suggested-by: David Rientjes Signed-off-by: Alexander Lobakin --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 10 ++ drivers/net/ethernet/intel/fm10k/fm10k_main.c | 9 ++--- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 15

Re: [PATCH net-next 0/3] net: constify page_is_pfmemalloc() and its users

2021-01-27 Thread Alexander Lobakin
From: Alexander Lobakin Date: Mon, 25 Jan 2021 16:46:48 + > page_is_pfmemalloc() is used mostly by networking drivers. It doesn't > write anything to the struct page itself, so constify its argument and > a bunch of callers and wrappers around this function in drivers. >

[PATCH v2 mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup

2021-01-06 Thread Alexander Lobakin
LLD may produce it (Nathan); - check for unwanted sections to be zero-sized instead of discarding (Fangrui). [0] https://lore.kernel.org/linux-mips/20210104121729.46981-1-aloba...@pm.me Alexander Lobakin (4): MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section MIPS: vmlinux.lds.S

[PATCH v2 mips-next 2/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-06 Thread Alexander Lobakin
7; mips-alpine-linux-musl-ld: warning: orphan section `.gnu.attributes' from `init/main.o' being placed in section `.gnu.attributes' Misc: sort DISCARDS section entries alphabetically. Signed-off-by: Alexander Lobakin --- arch/mips/kernel/vmlinux.lds.S | 3 ++- 1 file changed, 2

[PATCH v2 mips-next 3/4] MIPS: vmlinux.lds.S: catch bad .got, .plt and .rel.dyn at link time

2021-01-06 Thread Alexander Lobakin
`.rel.dyn' ld.lld: warning: :(.got) is being placed in '.got' Adopted from x86/kernel/vmlinux.lds.S. Reported-by: Nathan Chancellor # .got Suggested-by: Fangrui Song # .rel.dyn Signed-off-by: Alexander Lobakin --- arch/mips/kernel/vmlinux.lds.S | 35 +

[PATCH v2 mips-next 4/4] MIPS: select ARCH_WANT_LD_ORPHAN_WARN

2021-01-06 Thread Alexander Lobakin
Now, after that all the sections are explicitly described and declared in vmlinux.lds.S, we can enable ld orphan warnings to prevent from missing any new sections in future. Signed-off-by: Alexander Lobakin --- arch/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips

[PATCH v2 mips-next 1/4] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section

2021-01-06 Thread Alexander Lobakin
xes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") Cc: sta...@vger.kernel.org # 4.4+ Signed-off-by: Alexander Lobakin --- arch/mips/kernel/vmlinux.lds.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S index 5e97e9d02f98.

Re: [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup

2021-01-06 Thread Alexander Lobakin
From: Nathan Chancellor Date: Mon, 4 Jan 2021 17:09:36 -0700 > On Mon, Jan 04, 2021 at 12:18:10PM +0000, Alexander Lobakin wrote: >> This series hunts the problems discovered after manual enabling of >> ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA() >> s

Re: [PATCH v2 mips-next 3/4] MIPS: vmlinux.lds.S: catch bad .got, .plt and .rel.dyn at link time

2021-01-06 Thread Alexander Lobakin
From: Nathan Chancellor Date: Wed, 6 Jan 2021 13:23:24 -0700 On Wed, Jan 06, 2021 at 08:08:29PM +, Alexander Lobakin wrote: >> Catch any symbols placed in .got, .got.plt, .plt, .rel.dyn >> or .rela.dyn and check for these sections to be zero-sized >> at link time. >>

[PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-06 Thread Alexander Lobakin
'net_header' is not used outside of this function, so can be moved from BSS onto the stack. Declarations of one-element arrays are discouraged, and there's no need to store 'empty' in BSS. Simply allocate it from heap at init. Signed-off-by: Alexander Lobakin -

Re: [PATCH v2 mips-next 2/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-06 Thread Alexander Lobakin
From: Kees Cook Date: Wed, 6 Jan 2021 14:07:07 -0800 > On Wed, Jan 06, 2021 at 08:08:19PM +0000, Alexander Lobakin wrote: >> Discard GNU attributes at link time as kernel doesn't use it at all. >> Solves a dozen of the following ld warnings (one per every file): >> &g

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-07 Thread Alexander Lobakin
From: Jakub Kicinski Date: Wed, 6 Jan 2021 16:30:56 -0800 > On Wed, 06 Jan 2021 20:40:28 +0000 Alexander Lobakin wrote: >> 'net_header' is not used outside of this function, so can be moved >> from BSS onto the stack. >> Declarations of one-element arrays are disc

Re: [PATCH net-next,v5 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-22 Thread Alexander Lobakin
From: Pablo Neira Ayuso Date: Fri, 20 Nov 2020 13:49:12 +0100 > Hi, > > The following patchset augments the Netfilter flowtable fastpath to > support for network topologies that combine IP forwarding, bridge and > VLAN devices. > > This v5 includes updates for: > > - Patch #2: fix incorrect xm

Re: [PATCH net-next,v5 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-22 Thread Alexander Lobakin
From: Pablo Neira Ayuso Date: Sun, 22 Nov 2020 12:42:19 +0100 > On Sun, Nov 22, 2020 at 10:26:16AM +0000, Alexander Lobakin wrote: >> From: Pablo Neira Ayuso >> Date: Fri, 20 Nov 2020 13:49:12 +0100 > [...] >>> Something like this: >>>

[PATCH net-next1/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-10 Thread Alexander Lobakin
including gro_cells and mac80211 users. Signed-off-by: Alexander Lobakin --- net/core/dev.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 8bc3dce71fc0..a33f56b439ce 100644 --- a/net/

[PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-10 Thread Alexander Lobakin
remains configurable via sysctl anyway, so may be fine-tuned for each hardware. Signed-off-by: Alexander Lobakin --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index a33f56b439ce..4f60444bb766 100644 --- a/net/core/dev.c

[PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-10 Thread Alexander Lobakin
yet mainlined driver): * no batching (5.4-rc2): ~450/450 Mbit/s * with gro_normal_batch == 8: ~480/480 Mbit/s * with gro_normal_batch == 16: ~500/500 Mbit/s Applies on top of net-next. Thanks. Alexander Lobakin (2): net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() net: core: increase

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-11 Thread Alexander Lobakin
Hi Edward, Edward Cree wrote 10.10.2019 21:16: On 10/10/2019 15:42, Alexander Lobakin wrote: Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs") have introduced a sysctl variable gro_normal_batch for defining a limit for listified Rx of GRO_NORMAL skbs. The ini

Re: [PATCH net-next1/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-11 Thread Alexander Lobakin
Edward Cree wrote 10.10.2019 21:23: On 10/10/2019 15:42, Alexander Lobakin wrote: Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL skbs") made use of listified skb processing for the users of napi_gro_frags(). The same technique can be used in a way m

Re: [PATCH net-next1/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-11 Thread Alexander Lobakin
Edward Cree wrote 11.10.2019 12:20: On 10/10/2019 15:42, Alexander Lobakin wrote: Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL skbs") made use of listified skb processing for the users of napi_gro_frags(). The same technique can be used in a way m

Re: [PATCH net-next 0/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-11 Thread Alexander Lobakin
Hi Ilias, Ilias Apalodimas wrote 11.10.2019 15:23: Hi Alexander, On Thu, Oct 10, 2019 at 05:42:24PM +0300, Alexander Lobakin wrote: Hi Dave, This series was written as a continuation to commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs"), and also takes an ad

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-12 Thread Alexander Lobakin
Alexander Lobakin wrote 11.10.2019 10:23: Hi Edward, Edward Cree wrote 10.10.2019 21:16: On 10/10/2019 15:42, Alexander Lobakin wrote: Commit 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs") have introduced a sysctl variable gro_normal_batch for defining a

Re: [PATCH net-next 2/2] net: core: increase the default size of GRO_NORMAL skb lists to flush

2019-10-12 Thread Alexander Lobakin
Hi Eric, Eric Dumazet wrote 12.10.2019 14:18: On Sat, Oct 12, 2019 at 2:22 AM Alexander Lobakin wrote: I've generated an another solution. Considering that gro_normal_batch is very individual for every single case, maybe it would be better to make it per-NAPI (or per-netdevice) var

[PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-14 Thread Alexander Lobakin
uration and might be tuned in manual order to achieve an optimal performance. Signed-off-by: Alexander Lobakin Acked-by: Edward Cree --- net/core/dev.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/net/core/dev.c b/

Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()

2019-10-16 Thread Alexander Lobakin
David Miller wrote 16.10.2019 04:16: From: Alexander Lobakin Date: Mon, 14 Oct 2019 11:00:33 +0300 Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL skbs") made use of listified skb processing for the users of napi_gro_frags(). The same technique can be used in

[PATCH net] net: qed: prevent buffer overflow when collecting debug data

2020-07-03 Thread Alexander Lobakin
s, so userland parsers could handle it. Fixes: c965db444629 ("qed: Add support for debug data collection") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed.h | 2 ++ drivers/net/ethernet/qlogic/qed/qed_debug.c | 13 -

Re: [PATCH net] net: qed: prevent buffer overflow when collecting debug data

2020-07-03 Thread Alexander Lobakin
From: David Miller Date: Fri, 03 Jul 2020 12:59:33 -0700 (PDT) > From: Alexander Lobakin > Date: Fri, 3 Jul 2020 12:02:58 +0300 > > > When generating debug dump, driver firstly collects all data in binary > > form, and then performs per-feature formatting to human-

[PATCH net] net: atlantic: fix ip dst and ipv6 address filters

2020-07-08 Thread Alexander Lobakin
ilter definitions") Signed-off-by: Dmitry Bogdanov Signed-off-by: Mark Starovoytov Signed-off-by: Alexander Lobakin --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c| 4 ++-- .../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh_internal.h | 2 +- 2 files changed, 3 insert

[PATCH] mailmap: add entries for Alexander Lobakin

2020-06-19 Thread Alexander Lobakin
My D-Link and Yandex addresses don't exist anymore, map them to my private box. Signed-off-by: Alexander Lobakin --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index c69d9c734fb5..86eb59ad4c54 100644 --- a/.mailmap +++ b/.mailmap @@ -18,6 +18,8 @@ Al

[PATCH net 0/9] net: qed/qede: various stability fixes

2020-06-22 Thread Alexander Lobakin
This set addresses several near-critical issues that were observed and reproduced on different test and production configurations. Alexander Lobakin (9): net: qed: fix left elements count calculation net: qed: fix async event callbacks unregistering net: qede: stop adding events on an

[PATCH net 9/9] net: qed: fix "maybe uninitialized" warning

2020-06-22 Thread Alexander Lobakin
d; ^ ...under W=1+. Fix this by initializing it with zero. Fixes: 79284adeb99e ("qed: Add llh ppfid interface and 100g support for offload protocols") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers

[PATCH net 5/9] net: qed: fix excessive QM ILT lines consumption

2020-06-22 Thread Alexander Lobakin
This is likely a copy'n'paste mistake. The amount of ILT lines to reserve for a single VF was being multiplied by the total VFs count. This led to a huge redundancy in reservation and potential lines drainouts. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexa

[PATCH net 4/9] net: qed: fix NVMe login fails over VFs

2020-06-22 Thread Alexander Lobakin
tick configuration, hence atomic udelays for consistency. Also add explicit DMA barriers since 'done' always comes from a shared request-response DMA pool, and note that in the comment nearby. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-o

[PATCH net 6/9] net: qede: fix PTP initialization on recovery

2020-06-22 Thread Alexander Lobakin
: ccc67ef50b90 ("qede: Error recovery process") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_ptp.c | 31 drivers/net/ethernet/q

[PATCH net 8/9] net: qed: reset ILT block sizes before recomputing to fix crashes

2020-06-22 Thread Alexander Lobakin
Sizes of all ILT blocks must be reset before ILT recomputing when disabling clients, or memory allocation may exceed ILT shadow array and provoke system crashes. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-

[PATCH net 7/9] net: qede: fix use-after-free on recovery and AER handling

2020-06-22 Thread Alexander Lobakin
Set edev->cdev pointer to NULL after calling remove() callback to avoid using of already freed object. Fixes: ccc67ef50b90 ("qede: Error recovery process") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers/net/etherne

[PATCH net 3/9] net: qede: stop adding events on an already destroyed workqueue

2020-06-22 Thread Alexander Lobakin
Set rdma_wq pointer to NULL after destroying the workqueue and check for it when adding new events to fix crashes on driver unload. Fixes: cee9fbd8e2e9 ("qede: Add qedr framework") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- d

[PATCH net 2/9] net: qed: fix async event callbacks unregistering

2020-06-22 Thread Alexander Lobakin
qed_spq_unregister_async_cb() should be called before qed_rdma_info_free() to avoid crash-spawning uses-after-free. Instead of calling it from each subsystem exit code, do it in one place on PF down. Fixes: 291d57f67d24 ("qed: Fix rdma_info structure allocation") Signed-off-by: Alexand

[PATCH net 1/9] net: qed: fix left elements count calculation

2020-06-22 Thread Alexander Lobakin
of this bug. Misc: replace open-coded constants with common defines. Fixes: a91eb52abb50 ("qed: Revisit chain implementation") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- include/linux/qed/qed_chain.h | 26

Re: [PATCH v2 net 0/3] net: ethtool: netdev_features_strings[] cleanup

2020-06-23 Thread Alexander Lobakin
Hi Dave, Michal, On Tuesday, 23 June 2020, 2:34, David Miller wrote: > From: Alexander Lobakin > Date: Sun, 21 Jun 2020 09:55:50 + > > This little series adds the last forgotten feature string for > > NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such lo

[PATCH v3 net] net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM

2020-06-23 Thread Alexander Lobakin
manual configuration. v3: - decouple from "netdev_features_strings[] cleanup" series; - no functional changes. v2: - don't split the "Fixes:" tag across lines; - no functional changes. Fixes: e585f2363637 ("udp: Changes to udp_offload to support remote checksu

[PATCH resend] virtio: virtio_console: add missing MODULE_DEVICE_TABLE() for rproc serial

2020-06-23 Thread Alexander Lobakin
itself. Fixes: 1b6370463e88 ("virtio_console: Add support for remoteproc serial") Cc: # v3.8+ Signed-off-by: Alexander Lobakin Reviewed-by: Amit Shah --- drivers/char/virtio_console.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/virtio_console.c b/dr

Re: [PATCH net 9/9] net: qed: fix "maybe uninitialized" warning

2020-06-23 Thread Alexander Lobakin
From: Jakub Kicinski Date: Mon, 22 Jun 2020 14:44:37 -0700 > On Mon, 22 Jun 2020 14:14:13 +0300 Alexander Lobakin wrote: > > Variable 'abs_ppfid' in qed_dev.c:qed_llh_add_mac_filter() always gets > > printed, but is initialized only under 'ref_cnt == 1&#

[PATCH v2 net 0/9] net: qed/qede: various stability fixes

2020-06-23 Thread Alexander Lobakin
This set addresses several near-critical issues that were observed and reproduced on different test and production configurations. v2: - don't split the "Fixes:" tag across several lines in patch 9; - no functional changes. Alexander Lobakin (9): net: qed: fix left elements co

[PATCH v2 net 1/9] net: qed: fix left elements count calculation

2020-06-23 Thread Alexander Lobakin
of this bug. Misc: replace open-coded constants with common defines. Fixes: a91eb52abb50 ("qed: Revisit chain implementation") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- include/linux/qed/qed_chain.h | 26

[PATCH v2 net 7/9] net: qede: fix use-after-free on recovery and AER handling

2020-06-23 Thread Alexander Lobakin
Set edev->cdev pointer to NULL after calling remove() callback to avoid using of already freed object. Fixes: ccc67ef50b90 ("qede: Error recovery process") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers/net/etherne

[PATCH v2 net 4/9] net: qed: fix NVMe login fails over VFs

2020-06-23 Thread Alexander Lobakin
tick configuration, hence atomic udelays for consistency. Also add explicit DMA barriers since 'done' always comes from a shared request-response DMA pool, and note that in the comment nearby. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-o

[PATCH v2 net 9/9] net: qed: fix "maybe uninitialized" warning

2020-06-23 Thread Alexander Lobakin
d; ^ ...under W=1+. Fix this by initializing it with zero. Fixes: 79284adeb99e ("qed: Add llh ppfid interface and 100g support for offload protocols") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers

[PATCH v2 net 5/9] net: qed: fix excessive QM ILT lines consumption

2020-06-23 Thread Alexander Lobakin
This is likely a copy'n'paste mistake. The amount of ILT lines to reserve for a single VF was being multiplied by the total VFs count. This led to a huge redundancy in reservation and potential lines drainouts. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexa

[PATCH v2 net 3/9] net: qede: stop adding events on an already destroyed workqueue

2020-06-23 Thread Alexander Lobakin
Set rdma_wq pointer to NULL after destroying the workqueue and check for it when adding new events to fix crashes on driver unload. Fixes: cee9fbd8e2e9 ("qede: Add qedr framework") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- d

[PATCH v2 net 8/9] net: qed: reset ILT block sizes before recomputing to fix crashes

2020-06-23 Thread Alexander Lobakin
Sizes of all ILT blocks must be reset before ILT recomputing when disabling clients, or memory allocation may exceed ILT shadow array and provoke system crashes. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-

[PATCH v2 net 2/9] net: qed: fix async event callbacks unregistering

2020-06-23 Thread Alexander Lobakin
qed_spq_unregister_async_cb() should be called before qed_rdma_info_free() to avoid crash-spawning uses-after-free. Instead of calling it from each subsystem exit code, do it in one place on PF down. Fixes: 291d57f67d24 ("qed: Fix rdma_info structure allocation") Signed-off-by: Alexand

[PATCH v2 net 6/9] net: qede: fix PTP initialization on recovery

2020-06-23 Thread Alexander Lobakin
: ccc67ef50b90 ("qede: Error recovery process") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_ptp.c | 31 drivers/net/ethernet/q

[PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread Alexander Lobakin
*at least* equal to one of the values (depending on XDP prog presence). So, fix the check to align the value up. This satisfies both hardware/driver and network stack requirements. Fixes: ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") Signed-off-by: Alexander Lobak

[PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-30 Thread Alexander Lobakin
R2 router board with a WIP NIC driver in VLAN NAT: 20 Mbps baseline, 1 Gbps / link speed with this patch. Signed-off-by: Alexander Lobakin --- include/linux/netdev_features.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdev_features.h b/inc

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
On Saturday, 31 October 2020, 2:12, Willem de Bruijn wrote: Hi Willem, > On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: > > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support > > for fraglist UDP L4 and fraglist GS

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Alexander Lobakin Date: Sat, 31 Oct 2020 10:31:31 + > On Saturday, 31 October 2020, 2:12, Willem de Bruijn > wrote: > > Hi Willem, > >> On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: >> >>> Commit 9fd1ff5d2ac7 ("udp

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Alexander Lobakin Date: Sat, 31 Oct 2020 14:17:03 + > From: Alexander Lobakin > Date: Sat, 31 Oct 2020 10:31:31 + > >> On Saturday, 31 October 2020, 2:12, Willem de Bruijn >> wrote: >> >> Hi Willem, >> >>> On Fri, Oct 30, 2020 a

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Willem de Bruijn Date: Sat, 31 Oct 2020 11:26:24 -0400 I think it is fine to reenable this again, now that UDP sockets will segment unexpected UDP GSO packets that may have looped. We previously added general software support in commit 83aa025f535f ("udp: add gso support

[PATCH v2 net-next 0/2] net: allow virtual netdevs to forward UDP L4 and fraglist GSO skbs

2020-11-01 Thread Alexander Lobakin
elxemg8vsi...@cp3-web-020.plabs.ch Alexander Lobakin (2): net: add GSO UDP L4 and GSO fraglists to the list of software-backed types net: bonding, dummy, ifb, team: advertise NETIF_F_GSO_SOFTWARE drivers/net/bonding/bond_main.c | 11 +-- drivers/net/dummy.c |

[PATCH v2 net-next 2/2] net: bonding, dummy, ifb, team: advertise NETIF_F_GSO_SOFTWARE

2020-11-01 Thread Alexander Lobakin
Virtual netdevs should use NETIF_F_GSO_SOFTWARE to forward GSO skbs as-is and let the final drivers deal with them when supported. Also remove NETIF_F_GSO_UDP_L4 from bonding and team drivers as it's now included in the "software" list. Suggested-by: Willem de Bruijn Signed-of

[PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types

2020-11-01 Thread Alexander Lobakin
l/virtual netdevs to forward these types of skbs up to the real drivers. Signed-off-by: Alexander Lobakin --- include/linux/netdev_features.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 0b17c4322b09.

[PATCH mips-next 0/2] mips: boot: add support for self-extracting FIT images (vmlinuz.itb)

2020-11-01 Thread Alexander Lobakin
second part involves some scenarios duplication, but I think it can be a subject for another series (for constifying and unifying FIT Images rules across the architectures). Alexander Lobakin (2): mips: boot: clean up self-extracting targets scenarios mips: boot: add support for self-extractin

[PATCH mips-next 1/2] mips: boot: clean up self-extracting targets scenarios

2020-11-01 Thread Alexander Lobakin
ll be properly accounted by Kbuild. This also allows to remove redundant $(clean-files) (which were missing uzImage BTW). 3. Prefix all targets with $(obj)/$(objtree), depending on their locations. Misc: fix the identation of the 'STRIP' quiet message. Signed-off-by: Alexander Lobakin

[PATCH mips-next 2/2] mips: boot: add support for self-extracting FIT images (vmlinuz.itb)

2020-11-01 Thread Alexander Lobakin
ge (only legacy uzImages). Add a target for this named "vmlinuz.itb", which will consist of vmlinuz.bin and selected DT blobs. It will allow to have the advantages of both UHI and self-extracting images. Signed-off-by: Alexander Lobakin --- arch/mips/Makefile | 1 + arch/mips

Re: [PATCH v4 net] net: udp: fix Fast/frag0 UDP GRO

2020-11-11 Thread Alexander Lobakin
From: Willem de Bruijn Date: Tue, 10 Nov 2020 13:49:56 -0500 > On Mon, Nov 9, 2020 at 7:29 PM Alexander Lobakin wrote: >> >> From: Alexander Lobakin >> Date: Tue, 10 Nov 2020 00:17:18 + >> >>> While testing UDP GSO fraglists forwarding throug

<    1   2   3   4   5   6   >