[PATCH v2 RESEND 08/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Lukasz Dorau Cc: Maciej Patelczyk Cc: Dave Jiang Cc: intel-linux-...@intel.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/isci/init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/isci

[PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: James Smart Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/lpfc/lpfc_init.c | 38 +- 1 files changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi

[PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix()

2014-04-14 Thread Alexander Gordeev
There is no need to call pci_disable_msix() in case the previous call to pci_enable_msix() failed Signed-off-by: Alexander Gordeev Cc: Naresh Kumar Inna Cc: Arvind Bhushan Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/csiostor/csio_isr.c |4 +--- 1 files

[PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Hiral Patel Cc: Suma Ramars Cc: Brian Uchino Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/fnic/fnic_isr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi

[PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Naresh Kumar Inna Cc: Arvind Bhushan Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/csiostor/csio_hw.h |2 +- drivers/scsi/csiostor/csio_isr.c | 22 +- 2 files changed, 10 insertions(+), 14 deletions

[PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once

2014-04-14 Thread Alexander Gordeev
Function pci_enable_msix() should not be called in case it threw a negative errno from a previous call. Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa

[PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Jayamohan Kallickal Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b

[PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/bfa/bfad.c | 20 ++-- 1 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi

[PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
...@vmware.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (23): be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() bfa: Do not call pci_enable_msix() after it failed once bfa: Cleanup bfad_setup_intr() function bfa: Use pci_enable_msix_exact

[PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function

2014-04-14 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers

Re: [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-04-14 Thread Alexander Gordeev
On Mon, Apr 14, 2014 at 09:14:07AM +0200, Alexander Gordeev wrote: > @@ -1244,7 +1241,7 @@ static inline void pcie_set_ecrc_checking(struct > pci_dev *dev) { } > static inline void pcie_ecrc_get_policy(char *str) { } > #endif > > -#define pci_enable_msi(pdev) pci_enable

[PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-04-14 Thread Alexander Gordeev
: Alexander Gordeev Cc: linux-m...@linux-mips.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-s...@vger.kernel.org Cc: x...@kernel.org Cc: linux-...@vger.kernel.org --- drivers/pci/msi.c | 79 +- include/linux/pci.h |5 +-- 2 files changed, 34

Re: [PATCH v2 RESEND 2/4] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
On Wed, Mar 12, 2014 at 09:56:34PM -0600, Bjorn Helgaas wrote: > On Thu, Mar 06, 2014 at 09:11:22PM +0100, Alexander Gordeev wrote: > > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > using these two

[PATCH] crypto/ccp: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-15 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Tom Lendacky Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/crypto/ccp/ccp-pci.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/c

[PATCH] qlcnic: Fix MSI-X initialization code

2014-04-15 Thread Alexander Gordeev
ned issues. Cc: Shahed Shaikh Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 28 - 1 files changed, 16 insertions(+), 12 deletions(-) di

Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:05PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:09PM +0200, Alexander Gordeev wrote: > There is no need to call pci_disable_msix() in case > the previous call to pci_enable_msix() failed Hi Naresh, Arvind, Could you please review csiostor patches in this series? Thanks! > Signed-off-by: Alexander Gord

Re: [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:11PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:12PM +0200, Alexander Gordeev wrote: > Currently the driver falls back to INTx mode when MSI-X > initialization failed. This is a suboptimal behaviour > for chips that also support MSI. This update changes that > behaviour and falls back to MSI mode in cas

Re: [PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:16PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:17PM +0200, Alexander Gordeev wrote: > Currently the driver fails to analize MSI-X re-enablement > status on resuming and always assumes the success. This > update checks the MSI-X initialization result and fails > to resume if MSI-Xs re-enablement faile

Re: [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:19PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:22PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:24PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 21/23] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:25PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev
On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

[PATCH 2/2] PCI/MSI: Remove arch_msi_check_device()

2014-07-12 Thread Alexander Gordeev
-off-by: Alexander Gordeev --- drivers/pci/msi.c | 49 + include/linux/msi.h |3 --- 2 files changed, 13 insertions(+), 39 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 13f3d30..19ac058 100644 --- a/drivers/pci/msi.c

[PATCH 0/2] PCI/MSI: Remove arch_msi_check_device()

2014-07-12 Thread Alexander Gordeev
Hello, This is a cleanup effort to get rid of useless arch_msi_check_device(). I am not sure what were the reasons for its existence in the first place, but at the moment it appears totally unnecessary. Thanks! Cc: linuxppc-...@lists.ozlabs.org Cc: linux-...@vger.kernel.org Alexander Gordeev

[PATCH 1/2] PCI/MSI/PPC: Remove arch_msi_check_device()

2014-07-12 Thread Alexander Gordeev
arch_setup_msi_irqs() makes code more readable and allows getting rid of unnecessary hook arch_msi_check_device(). Cc: linuxppc-...@lists.ozlabs.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- arch/powerpc/include/asm/machdep.h |2 - arch/powerpc/kernel/msi.c

Re: [PATCH 2/2] PCI/MSI: Remove arch_msi_check_device()

2014-07-14 Thread Alexander Gordeev
etup_msi_irqs(struct pci_dev *dev, int nvec, int type); > > void arch_teardown_msi_irqs(struct pci_dev *dev); > > -int arch_msi_check_device(struct pci_dev* dev, int nvec, int type); > > void arch_restore_msi_irqs(struct pci_dev *dev); > > > > void default_teardown_msi_irqs(struct pci_de

Re: [PATCH] misc/GenWQE: fix pci_enable_msi usage

2014-07-09 Thread Alexander Gordeev
t) > int rc; > struct pci_dev *pci_dev = cd->pci_dev; > > - rc = pci_enable_msi_exact(pci_dev, count); > - if (rc == 0) > - cd->flags |= GENWQE_FLAG_MSI_ENABLED; > - return rc; > + rc = pci_enable_msi_range(pci_dev, 1, count); > + if (r

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-10 Thread Alexander Gordeev
urner until it actually becomes a > problem. I plan to try get rid of arch_msi_check_device() hook. Should I repost this series afterwards? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed

2014-07-16 Thread Alexander Gordeev
Currently the driver fails to analize MSI-X re-enablement status on resuming and always assumes the success. This update checks the MSI-X initialization result and fails to resume if MSI-Xs re-enablement failed. Signed-off-by: Alexander Gordeev --- drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Hiral Patel Cc: Suma Ramars Cc: Brian Uchino Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/fnic/fnic_isr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi

[PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev --- drivers/scsi/be2iscsi/be_main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 56467df..1f63169 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi

[PATCH v2 RESEND 21/23] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
message code 0x00c6 preserved, although it is reported after successful call to pci_enable_msix_range(), not before possibly unsuccessful call to pci_enable_msix(). Consumers of the error code should not notice the difference. Signed-off-by: Alexander Gordeev Cc: qla2xxx-upstr...@qlogic.com Cc

[PATCH v2 RESEND 19/23] pmcraid: Get rid of a redundant assignment

2014-07-16 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev Cc: Anil Ravindranath Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/pmcraid.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index be8ce54..c06af7f 100644

[PATCH v2 RESEND 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Anil Ravindranath Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/pmcraid.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index c06af7f..6d0f208

[PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Vikas Chaudhary Cc: iscsi-dri...@qlogic.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-By: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_nx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx

[PATCH v2 RESEND 11/23] lpfc: Remove superfluous call to pci_disable_msix()

2014-07-16 Thread Alexander Gordeev
There is no need to call pci_disable_msix() in case the previous call to pci_enable_msix() failed Signed-off-by: Alexander Gordeev Cc: James Smart Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c |9 ++--- 1 files

[PATCH v2 RESEND 10/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Lukasz Dorau Cc: Maciej Patelczyk Cc: Dave Jiang Cc: intel-linux-...@intel.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Artur Paszkiewicz --- drivers/scsi/isci/init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH v2 RESEND 14/23] megaraid: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Neela Syam Kolli Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/megaraid/megaraid_sas_base.c | 20 +++- 1 files changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b

[PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: James Smart Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/lpfc/lpfc_init.c | 38 +- 1 files changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi

[PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
...@vmware.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (23): be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() bfa: Do not call pci_enable_msix() after it failed once bfa: Cleanup bfad_setup_intr() function bfa: Use

[PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once

2014-07-16 Thread Alexander Gordeev
Function pci_enable_msix() should not be called in case it threw a negative errno from a previous call. Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa

[PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad.c | 20 ++-- 1 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/scsi

[PATCH v2 RESEND 23/23] vmw_pvscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Arvind Kumar Cc: pv-driv...@vmware.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Arvind Kumar --- drivers/scsi/vmw_pvscsi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers

[PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-16 Thread Alexander Gordeev
When a call to request_irq() failed pm8001_setup_msix() still returns the success. This udate fixes the described misbehaviour. Signed-off-by: Alexander Gordeev Cc: xjtu...@gmail.com Cc: lindar_...@usish.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Jack Wang

[PATCH v2 RESEND 16/23] mpt3sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Nagalakshmi Nandigama Cc: Sreekanth Reddy Cc: supp...@lsi.com Cc: dl-mptfusionli...@lsi.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/mpt3sas/mpt3sas_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Nagalakshmi Nandigama Cc: Sreekanth Reddy Cc: supp...@lsi.com Cc: dl-mptfusionli...@lsi.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/mpt2sas/mpt2sas_base.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix()

2014-07-16 Thread Alexander Gordeev
There is no need to call pci_disable_msix() in case the previous call to pci_enable_msix() failed Signed-off-by: Alexander Gordeev Cc: Naresh Kumar Inna Cc: Arvind Bhushan Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/csiostor/csio_isr.c |4 +--- 1 files

[PATCH v2 RESEND 09/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
: "Stephen M. Cameron" Cc: iss_storage...@hp.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/scsi/hpsa.c | 27 --- 1 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function

2014-07-16 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Naresh Kumar Inna Cc: Arvind Bhushan Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/csiostor/csio_hw.h |2 +- drivers/scsi/csiostor/csio_isr.c | 22 +- 2 files changed, 10 insertions(+), 14 deletions

[PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed

2014-07-16 Thread Alexander Gordeev
Currently the driver falls back to INTx mode when MSI-X initialization failed. This is a suboptimal behaviour for chips that also support MSI. This update changes that behaviour and falls back to MSI mode in case MSI-X mode initialization failed. Signed-off-by: Alexander Gordeev Cc: "Step

[PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: xjtu...@gmail.com Cc: lindar_...@usish.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/pm8001/pm8001_init.c | 39 +++-- 1 files changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers

Re: [PATCH 2/2] PCI/MSI: Remove arch_msi_check_device()

2014-07-17 Thread Alexander Gordeev
time to fix it. Maybe > "pci_msi_supported()" or something? What about pci_can_enable_msi() or pci_msi_can_enable() or msi_can_enable()? > I *love* the idea of getting rid of this much code! > > Bjorn -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-04 Thread Alexander Gordeev
On Wed, Jul 02, 2014 at 02:22:01PM -0600, Bjorn Helgaas wrote: > On Tue, Jun 10, 2014 at 03:10:30PM +0200, Alexander Gordeev wrote: > > There are PCI devices that require a particular value written > > to the Multiple Message Enable (MME) register while aligned on > > power o

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-04 Thread Alexander Gordeev
On Thu, Jul 03, 2014 at 09:20:52AM +, David Laight wrote: > From: Bjorn Helgaas > > On Tue, Jun 10, 2014 at 03:10:30PM +0200, Alexander Gordeev wrote: > > > There are PCI devices that require a particular value written > > > to the Multiple Message Enable (MME

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-04 Thread Alexander Gordeev
MSI vector makes a PCI host to raise interrupt on a CPU. I might be inaccurate in details, but the scenario you described is impossible AFAICT. > David > > > -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-07 Thread Alexander Gordeev
take those apply or have me resend all of them or just 'be2iscsi' and 'hpsa'? Thanks! > Bjorn -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-07 Thread Alexander Gordeev
continues exactly as it has been. All archs besides x86 just ignore it. And x86 change is fairly small as well - all necessary functionality is already in. Thus, at the moment it is only AHCI of concern. And no, AHCI can not do MSI-X.. Thanks! > Bjorn -- Regards, Alexander Gordeev agor

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-08 Thread Alexander Gordeev
I also do not like the fact the arch interface is getting complicated, so I happily leave it to your judgement ;) Well, it is low-level and hidden from drivers at least. Thanks! > Bjorn -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "u

[PATCH v2 2/2] ahci: Use pci_enable_msi_exact() instead of pci_enable_msi_range()

2014-04-17 Thread Alexander Gordeev
The driver calls pci_enable_msi_range() function with the range of [nvec..nvec] which what pci_enable_msi_exact() function is for. Signed-off-by: Alexander Gordeev Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 0/2] ahci: Tweaks to the driver's PCI function

2014-04-17 Thread Alexander Gordeev
Changes since v1: - ahci_is_mrsm() open-coded inside ahci_init_interrupt() - changelog elaborated Cc: linux-...@vger.kernel.org Alexander Gordeev (2): ahci: Ensure "MSI Revert to Single Message" mode is not enforced ahci: Use pci_enable_msi_exact()

[PATCH v2 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced

2014-04-17 Thread Alexander Gordeev
to intx; - nvec = pci_msi_vec_count(pdev); + nvec = 8; if (nvec < 0) goto intx; Signed-off-by: Alexander Gordeev Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c | 11 ++- drivers/ata/ahci.h |1 + 2 files changed, 11 insertions(+), 1 deletions(-) diff -

Re: [PATCH 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced

2014-04-17 Thread Alexander Gordeev
n. Yes, I think it needs to go to -stable. > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH v2 0/2] ahci: Tweaks to the driver's PCI function

2014-04-17 Thread Alexander Gordeev
On Thu, Apr 17, 2014 at 09:28:06AM -0400, Tejun Heo wrote: > On Thu, Apr 17, 2014 at 02:13:48PM +0200, Alexander Gordeev wrote: > > Changes since v1: > > - ahci_is_mrsm() open-coded inside ahci_init_interrupt() > > - changelog elaborated > > > &

[PATCH 1/1] ahci: Do not receive interrupts sent by dummy ports

2014-04-17 Thread Alexander Gordeev
and prevents the described issue. Signed-off-by: Alexander Gordeev Cc: Tejun Heo Cc: David Milburn Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 44d40c7

[PATCH 0/1] ahci: Do not receive interrupts sent by dummy ports

2014-04-17 Thread Alexander Gordeev
Tejun, David, I would expect handle_bad_irq()->print_irq_desc() gets called if dummy port interrupt arrived. Could be a spurious interrupt complain as well. Cc: Tejun Heo Cc: David Milburn Cc: linux-...@vger.kernel.org Alexander Gordeev (1): ahci: Do not receive interrupts sent by du

Re: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Fri, Mar 07, 2014 at 01:35:34PM +, Bounine, Alexandre wrote: > > From: Alexander Gordeev [mailto:agord...@redhat.com] > > Sent: Thursday, March 06, 2014 3:11 PM > > To: linux-kernel@vger.kernel.org > > Cc: Alexander Gordeev; Matt Porter; Bounine, Alexandre; linux-

Re: [PATCH v2] kvm: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Sat, Feb 22, 2014 at 09:58:10AM +0100, Paolo Bonzini wrote: > Il 22/02/2014 09:50, Alexander Gordeev ha scritto: > >Commit d158fc7 ("Merge tag 'pci-v3.14-fixes-1'") in Linus's tree has it. > > > >pci_enable_msix() is going to be removed

Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi

[PATCH v2 RESEND] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org --- drivers/pci/pcie/portdrv_core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 986f8ea..0b1efb2 100644 --- a

[PATCH RESEND 0/2] : block: Use pci_enable_msix_exact()

2014-04-21 Thread Alexander Gordeev
Alexander Gordeev (2): skd: Use pci_enable_msix_exact() instead of pci_enable_msix_range() cciss: Use pci_enable_msix_exact() instead of pci_enable_msix() drivers/block/cciss.c|6 +- drivers/block/skd_main.c |7 +++ 2 files changed, 4 insertions(+), 9 deletions(-) -- 1.7.7.6

[PATCH RESEND 2/2] cciss: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Mike Miller Cc: iss_storage...@hp.com Cc: Jens Axboe Cc: linux-...@vger.kernel.org --- drivers/block/cciss.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 73894ca..4595c22 100644

[PATCH RESEND 1/2] skd: Use pci_enable_msix_exact() instead of pci_enable_msix_range()

2014-04-21 Thread Alexander Gordeev
Function pci_enable_msix_exact() is a variation of pci_enable_msix_range() that allows a device driver to request a particular number of MSI-X interrupts, rather than any number within a specified range. Signed-off-by: Alexander Gordeev Cc: Jens Axboe Cc: Bartlomiej Zolnierkiewicz Cc: Kyungmin

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-04-22 Thread Alexander Gordeev
On Wed, Mar 26, 2014 at 02:34:22PM +0100, Alexander Gordeev wrote: > But other systems (more dense?) showed increased cache-hit rate > up to 20%, i.e. this one: Hello Gentlemen, Any feedback on this? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from thi

Re: [PATCH] blk-mq: bitmap tag: fix potential unwakeable sleep in bt_get()

2014-07-22 Thread Alexander Gordeev
On Mon, Jul 21, 2014 at 11:11:44AM +0200, Alexander Gordeev wrote: > > My bad, was looking at the wrong sources. What is the race? If the > > clear and wakeup come in after the prepare_to_wait() but before the > > io_schedule(), the io_schedule() will be a no-op and it wont

Re: blk-mq: bitmap tag: performance degradation?

2014-06-05 Thread Alexander Gordeev
bitmap tags on a 48 CPU box with NVMe device indeed shows almost the same performance/cache rate as the stock kernel. -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

[PATCH 3/3] AHCI: Use pci_enable_msi_partial() to conserve on 10/16 MSIs

2014-06-10 Thread Alexander Gordeev
-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 6070781..0c7a0f3 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1194,7 +1194,7 @@ static

[PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-06-10 Thread Alexander Gordeev
c: xen-de...@lists.xenproject.org Cc: io...@lists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 36 ++-- arch/mips/pci/msi-octeon.c |2 +- arch/powerpc/kernel/msi.c

[PATCH 0/3] Add pci_enable_msi_partial() to conserve MSI-related resources

2014-06-10 Thread Alexander Gordeev
-...@lists.ozlabs.org Cc: linux-s...@vger.kernel.org Cc: x...@kernel.org Cc: xen-de...@lists.xenproject.org Cc: io...@lists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (3): PCI/MSI: Add pci_enable_msi_partial() PCI/MSI/x86: Support

[PATCH 2/3] PCI/MSI/x86: Support pci_enable_msi_partial()

2014-06-10 Thread Alexander Gordeev
ists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- arch/x86/include/asm/pci.h |3 ++- arch/x86/include/asm/x86_init.h |3 ++- arch/x86/kernel/apic/io_apic.c |2 +- arch/x86/kernel/x86_init.c |2 +- arch/x86

[PATCH 1/3] blk-mq: bitmap tag: fix races on shared ::wake_index fields

2014-06-12 Thread Alexander Gordeev
Fix racy updates of shared blk_mq_bitmap_tags::wake_index and blk_mq_hw_ctx::wake_index fields. Cc: Ming Lei Cc: Jens Axboe Signed-off-by: Alexander Gordeev --- block/blk-mq-tag.c | 32 +--- block/blk-mq-tag.h |2 +- include/linux/blk-mq.h |2

[PATCH 2/3] blk-mq: bitmap tag: fix race on blk_mq_bitmap_tags::wake_cnt

2014-06-12 Thread Alexander Gordeev
t expected. The follow-up assignment in [3] overwrites the invalid value with the batch value (and likely prevents the issue from being severe) which is still incorrect and should be a lesser. Cc: Ming Lei Cc: Jens Axboe Signed-off-by: Alexander Gordeev --- block/blk-mq-tag.c | 14 -

[PATCH 0/3] blk-mq: bitmap tag: Fix few races

2014-06-12 Thread Alexander Gordeev
Hi Jens, This series is against for-3.16/blk-mq-tagging branch. Cc: Ming Lei Cc: Jens Axboe Alexander Gordeev (3): blk-mq: bitmap tag: fix races on shared ::wake_index fields blk-mq: bitmap tag: fix race on blk_mq_bitmap_tags::wake_cnt blk-mq: bitmap tag: clean-up bt_get() function

[PATCH 3/3] blk-mq: bitmap tag: clean-up bt_get() function

2014-06-12 Thread Alexander Gordeev
r_tag() function; Cc: Ming Lei Cc: Jens Axboe Signed-off-by: Alexander Gordeev --- block/blk-mq-tag.c | 27 +++ 1 files changed, 7 insertions(+), 20 deletions(-) diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index 5579fae..dc1f684 100644 --- a/block/blk-mq-

Re: [PATCH v2 0/2] block: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-03-31 Thread Alexander Gordeev
On Thu, Mar 13, 2014 at 06:36:56PM +0100, Alexander Gordeev wrote: > Oh-oh, cciss patch #2 requires commit 3ce4e86 ("PCI/MSI: Add > pci_enable_msi_exact() and pci_enable_msix_exact()") which was > pulled to 3.14-rc4 only. Sorry for failing to clarify that :( > > And I

Re: [PATCH v2 0/2] block: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-03-31 Thread Alexander Gordeev
On Mon, Mar 31, 2014 at 02:12:48PM -0600, Jens Axboe wrote: > On 03/31/2014 01:52 PM, Alexander Gordeev wrote: > >On Thu, Mar 13, 2014 at 06:36:56PM +0100, Alexander Gordeev wrote: > >>Oh-oh, cciss patch #2 requires commit 3ce4e86 ("PCI/MSI: Add > >>pci_enable_msi_e

Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-28 Thread Alexander Gordeev
On Tue, May 27, 2014 at 05:19:50PM -0600, Bjorn Helgaas wrote: > I assume this is being handled by Matt and/or Alexandre (listed in > MAINTAINERS). Let me know if I should do anything. Hi Bjorn, No worries, the patch is in Andrew's tree already. -- Regards, Alexander Go

Re: [PATCH v1.1 2/16 update 2] arcmsr: Adding code to support MSI-X interrupt

2014-05-06 Thread Alexander Gordeev
MessageUnit_A __iomem *reg = acb->pmuA; > > - uint32_t intmask_org; > > - intmask_org = arcmsr_disable_outbound_ints(acb); > > writel(ARCMSR_SIGNATURE_SET_CONFIG, \ > > ®-&g

blk-mq: bitmap tag: performance degradation?

2014-06-04 Thread Alexander Gordeev
1,127,037,813 cache-misses:k 69.446112553 seconds time elapsed Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-06-16 Thread Alexander Gordeev
OK, will add them. I'm planning to base the scsi-misc tree on -rc3 once > we have our current crop of fixes upstream. Hi James, If I need to repost the series to get it into you tree? Thanks! > James > -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this

Re: [PATCH 0/3] blk-mq: bitmap tag: Fix few races

2014-06-17 Thread Alexander Gordeev
nus's tree and could go in without patch 3/3. I'll post v2 of 3/3. > -- > Jens Axboe > -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

[PATCH v2 3/3] blk-mq: bitmap tag: fix races in bt_get() function

2014-06-17 Thread Alexander Gordeev
x27;bt_wait_state::wait_cnt' counter update is redundant, since it also gets reset in bt_clear_tag() function; Cc: Christoph Hellwig Cc: Ming Lei Cc: Jens Axboe Signed-off-by: Alexander Gordeev --- block/blk-mq-tag.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) dif

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-06-23 Thread Alexander Gordeev
Hi Bjorn, Any feedback? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

[PATCH 07/14] NVMe: Make returning value consistent across all functions

2014-01-28 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index f03f123..e004c09 100644 --- a/drivers/block/nvme-core.c +++ b/drivers/block/nvme-core.c

[PATCH 13/14] NVMe: Factor out nvme_setup_interrupts()

2014-01-28 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c | 33 ++--- 1 files changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index 39868be..83d57b3 100644 --- a/drivers/block/nvme-core.c +++ b

[PATCH 14/14] NVMe: Rework "NVMe: Disable admin queue on init failure" commit

2014-01-28 Thread Alexander Gordeev
This update partially reverts commit c5dc919 ("NVMe: Disable admin queue on init failure") to roll back easy readable nvme_free_queues() function. Commit's c5dc919 functionality aimed to free admin queue IRQ on init failure is preserved. Signed-off-by: Alexander Gordeev --- dri

<    3   4   5   6   7   8   9   10   11   12   >