[PATCH RFC 11/77] benet: Return -ENOSPC when not enough MSI-Xs available

2013-10-02 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/net/ethernet/emulex/benet/be_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 100b528..3e2c834 100644 --- a/drivers/net

[PATCH RFC 34/77] ioat: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Alexander Gordeev
As result of recent re-design of the MSI/MSI-X interrupts enabling pattern this driver has to be updated to use the new technique to obtain a optimal number of MSI/MSI-X interrupts required. Signed-off-by: Alexander Gordeev --- drivers/dma/ioat/dma.c | 10 +++--- 1 files changed, 7

[PATCH RFC 58/77] qib: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Alexander Gordeev
As result of recent re-design of the MSI/MSI-X interrupts enabling pattern this driver has to be updated to use the new technique to obtain a optimal number of MSI/MSI-X interrupts required. Signed-off-by: Alexander Gordeev --- drivers/infiniband/hw/qib/qib_pcie.c |4 1 files changed

[PATCH RFC 44/77] lpfc: Make MSI-X initialization routine more readable

2013-10-02 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/scsi/lpfc/lpfc_init.c | 23 +++ 1 files changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 0ec8008..0cfaf20 100644 --- a/drivers/scsi/lpfc/lpfc_init.c

[PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-02 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/pci/msi.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index d5f90d6..b43f391 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -719,7 +719,7 @@ static int

Re: [PATCH RFC 50/77] mlx5: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Alexander Gordeev
On Thu, Oct 03, 2013 at 10:14:33AM +0300, Eli Cohen wrote: > On Wed, Oct 02, 2013 at 12:49:06PM +0200, Alexander Gordeev wrote: > > > > + err = pci_msix_table_size(dev->pdev); > > + if (err < 0) > > + return err; > > + > >

Re: [PATCH RFC 34/77] ioat: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Alexander Gordeev
le_msix() will never return a positive value. Therefore if the driver is not updated it will fallback to single MSI if device->common.chancnt MSI-X vectors were not allocated while it used to fallback to a single MSI-X in the same situation. Not to mention 'if (err > 0)' dead code.

Re: [PATCH RFC 06/77] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-10-03 Thread Alexander Gordeev
On Thu, Oct 03, 2013 at 10:52:54PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote: > > #ifndef CONFIG_PCI_MSI > > +static inline int pci_get_msi_cap(struct pci_dev *dev) > > +{ > > + return -1; > [...] > > Shouldn&#

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-04 Thread Alexander Gordeev
On Thu, Oct 03, 2013 at 11:49:45PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote: > > This update converts pci_enable_msix() and pci_enable_msi_block() > > interfaces to canonical kernel functions and makes them return a > > error co

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-04 Thread Alexander Gordeev
pci_enable_msix(nvec2) where nvec1 < nvec2? > David -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-05 Thread Alexander Gordeev
On Fri, Oct 04, 2013 at 10:29:16PM +0100, Ben Hutchings wrote: > On Fri, 2013-10-04 at 10:29 +0200, Alexander Gordeev wrote: > All I can see there is that Tejun didn't think that the global limits > and positive return values were implemented by any architecture. I would say more

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-05 Thread Alexander Gordeev
On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > Signed-off-by: Alexander Gordeev > > --- > > drivers/ntb/ntb_hw.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > &

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-05 Thread Alexander Gordeev
On Sun, Oct 06, 2013 at 08:46:26AM +1100, Benjamin Herrenschmidt wrote: > On Sat, 2013-10-05 at 16:20 +0200, Alexander Gordeev wrote: > > So my point is - drivers should first obtain a number of MSIs they *can* > > get, then *derive* a number of MSIs the device is fine wit

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-06 Thread Alexander Gordeev
On Sun, Oct 06, 2013 at 05:19:46PM +1100, Benjamin Herrenschmidt wrote: > On Sun, 2013-10-06 at 08:02 +0200, Alexander Gordeev wrote: > > In fact, in the current design to address the quota race decently the > > drivers would have to protect the *loop* to prevent the quota chang

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-11 Thread Alexander Gordeev
On Wed, May 22, 2013 at 07:03:05PM +0200, Jens Axboe wrote: > On Wed, May 22 2013, Alexander Gordeev wrote: > > On Wed, May 22, 2013 at 08:50:03AM +0900, Tejun Heo wrote: > > > Hmm. I'd normally apply this patch but block layer is just > > > growing multi-qu

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-12 Thread Alexander Gordeev
On Thu, Jul 11, 2013 at 04:00:37PM -0700, Nicholas A. Bellinger wrote: > On Thu, 2013-07-11 at 12:26 +0200, Alexander Gordeev wrote: > > On Wed, May 22, 2013 at 07:03:05PM +0200, Jens Axboe wrote: > > > On Wed, May 22 2013, Alexander Gordeev wrote: > > > > On Wed, Ma

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-16 Thread Alexander Gordeev
On Mon, Sep 09, 2013 at 05:20:44PM +0200, Alexander Gordeev wrote: > On Fri, Sep 06, 2013 at 05:32:05PM -0600, Bjorn Helgaas wrote: > > I propose that you rework it that way, and at least find out what > > (if anything) would break if we do that. Or maybe we just give up > >

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-18 Thread Alexander Gordeev
ize() */ rc = pci_get_msix_limit(pdev); if (rc < 0) return rc; /* * nvec = min(rc, nvec); */ for (i = 0; i < nvec; i++) msix_entry[i].entry = i; rc = pci_enable_msix(pdev, msix_entry,

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-18 Thread Alexander Gordeev
xity. Being Captain Obvious here, but it is up to the device driver to handle a failure. There could be no such option as single MSI mode after all :) > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-20 Thread Alexander Gordeev
! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-09-20 Thread Alexander Gordeev
ap_queue(q, ctx->cpu); } @@ -1317,6 +1317,9 @@ struct request_queue *blk_mq_init_queue(struct blk_mq_reg *reg, reg->queue_depth = BLK_MQ_MAX_DEPTH; } + reg->queue_depth++; + reg->reserved_tags++; + ctx = alloc_percpu(struct blk_mq_ctx);

Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-04 Thread Alexander Gordeev
On Tue, Sep 03, 2013 at 02:27:31PM -0400, Tejun Heo wrote: > Hello, > > On Tue, Sep 03, 2013 at 06:19:06PM +0200, Alexander Gordeev wrote: > > We must enable maximum possible number of MSIs - the one reported in > > Multiple Message Capable register. Otherwise ICH device will

Re: [PATCH 0/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-04 Thread Alexander Gordeev
On Tue, Sep 03, 2013 at 12:24:11PM -0400, Tejun Heo wrote: > Hello, > > On Tue, Sep 03, 2013 at 04:57:19PM +0200, Alexander Gordeev wrote: > > Multiple MSI support enables threaded IRQ handling, because at the time of > > posting I did not want to intrude into the existin

Re: [PATCH 0/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-04 Thread Alexander Gordeev
ctivate(), which BTW should probably be renamed > to ahci_host_activate_mmsi(). Hmm.. that is actually a great idea. What I am not sure about whether is a dummy port still can send (spurious?) interrupts? The hardware interrupt handler would have to be reworked then. Seems as a yet another topic to me

[PATCH v2 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-04 Thread Alexander Gordeev
Make use of the new pci_enable_msi_block_part() interface and conserve on othewise wasted interrupt resources for 10 of 16 unused MSI vectors on Intel chipsets. Signed-off-by: Alexander Gordeev diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index db4380d..41f9c08 100644 --- a/drivers

Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-04 Thread Alexander Gordeev
On Wed, Sep 04, 2013 at 10:55:59AM -0400, Tejun Heo wrote: > Hello, > > On Wed, Sep 04, 2013 at 09:22:57AM +0200, Alexander Gordeev wrote: > > I think a general approach that will cover it all (including ICH and > > undesired > > sharing of interrupt vectors) - start

Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-04 Thread Alexander Gordeev
i_block_part() in a loop may seem not that terrible if you think of the original interface - pci_enable_msi_block(). If we were to enable multiple MSIs using that one we still had to use it pretty much the same way ;) Anyway. I will send a version which reads MMC out. > Thanks. > > --

[PATCH v2 1/6] PCI/MSI: Introduce pci_enable_msi_block_part() interface

2013-09-05 Thread Alexander Gordeev
7; argument which is then written to the MME register while the value of 'nvec' is still used to setup as many interrupts as requested. Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 56 arch/mips/pci/msi-octeon.c |2 +-

[PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-05 Thread Alexander Gordeev
Factor out the operation of retrieving the number of MSI vectors the device requested, that is a value encoded in the Multiple Message Capable register. This change is a prerequisite for the forthcoming update of the AHCI device driver. Signed-off-by: Alexander Gordeev --- Documentation/PCI

[PATCH v2 4/6] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-05 Thread Alexander Gordeev
Make use of the new pci_enable_msi_block_part() interface and conserve on othewise wasted interrupt resources for 10 of 16 unused MSI vectors on Intel chipsets. Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c | 46 +++--- 1 files changed, 27

[PATCH v2 3/6] MSI/x86: Support pci_enable_msi_block_part() interface

2013-09-05 Thread Alexander Gordeev
This change is a prerequisite for the forthcoming update of the AHCI device driver to conserve 10/16 MSIs on Intel chipsets. The update makes use of 'nvec_mme' parameter for pci_enable_msi_block_part() interface. Signed-off-by: Alexander Gordeev --- drivers/iommu/irq_remappin

[PATCH v2 5/6] AHCI: Check MRSM bit when multiple MSIs enabled

2013-09-05 Thread Alexander Gordeev
Do not trust the hardware and always check if MSI Revert to Single Message mode was enforced. Fall back to the single MSI mode in case it did. Not doing so might screw up the interrupt handling. Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c | 16 drivers/ata/ahci.h

[PATCH v2 6/6] PCI/MSI: Get rid of pci_enable_msi_block_auto() interface

2013-09-05 Thread Alexander Gordeev
There are no consumers of pci_enable_msi_block_auto() interface have left. Eliminate it for now. Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 42 +++--- drivers/pci/msi.c | 22 include/linux/pci.h

[PATCH v2 0/6] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-05 Thread Alexander Gordeev
- patch 4/6 MMC reg. value used to initialize multiple MSIs; Fallback to single MSI mode is simplified - patch 5/6 sanity check for MRSM bit added Alexander Gordeev (6): 1/6 PCI/MSI: Introduce pci_enable_msi_block_part() interface 2/6 PCI/MSI: Factor out

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-05 Thread Alexander Gordeev
On Thu, Sep 05, 2013 at 09:09:02AM -0400, Tejun Heo wrote: > Hello, Alexander. > > On Thu, Sep 05, 2013 at 02:52:47PM +0200, Alexander Gordeev wrote: > One curiosity - with the above factored out, is > pci_enable_msi_block_part() returning positive number still necessary? >

Re: [PATCH v2 4/6] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-05 Thread Alexander Gordeev
owever, conserving on x86 interrupt vector space is always a good idea IMO. Also, PPC pSeries has a concept of MSI quota, so.. > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2 5/6] AHCI: Check MRSM bit when multiple MSIs enabled

2013-09-05 Thread Alexander Gordeev
On Thu, Sep 05, 2013 at 09:11:49AM -0400, Tejun Heo wrote: > On Thu, Sep 05, 2013 at 02:54:17PM +0200, Alexander Gordeev wrote: > The patch should probably be re-sequenced to the head of the series > and cc sta...@vger.kernel.org. Not checking MRSM is scary. Will resend v3.

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-05 Thread Alexander Gordeev
0 or -errno, which is a lot simpler. No? As I mentioned in my other note, at least PPC has a concept of MSI quota, so exceeding it would be the very case, I believe. > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: se

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-05 Thread Alexander Gordeev
moment I still prefer pci_enable_msi_block_part() to be similar to pci_enable_msi_block(). I do agree the fallback logic is error-prone, but I would not dare to scrap it all right away. Bjorn? > > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsu

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-06 Thread Alexander Gordeev
On Thu, Sep 05, 2013 at 05:40:41PM +0200, Alexander Gordeev wrote: > On Thu, Sep 05, 2013 at 11:04:42AM -0400, Tejun Heo wrote: > > The thing is, do we even have cases where arch code returns positive > > return to indicate possible partial allocation? If not, the whole &

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-09 Thread Alexander Gordeev
return quota; return 0; > Bjorn -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH 1/9] PCI/MSI/PPC: Fix wrong RTAS error code reporting

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/powerpc/platforms/pseries/msi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/pseries/msi.c b/arch/powerpc/platforms/pseries/msi.c index 6d2f0ab..009ec73 100644 --- a/arch/powerpc/platforms/pseries

[PATCH 2/9] PCI/MSI/PPC: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/powerpc/kernel/msi.c|2 +- arch/powerpc/platforms/pseries/msi.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/msi.c b/arch/powerpc/kernel/msi.c index 8bbc12d..36d70b9 100644 --- a/arch

[PATCH 3/9] PCI/MSI/x86: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/x86/kernel/apic/io_apic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 9ed796c..4a95d9a 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel

[PATCH 2/9] PCI/MSI/PPC: Make return values only 0/-errno when MSIs allocated[PATCH 5/9] PCI/MSI/s390: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/s390/pci/pci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index f17a834..c79c6e4 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -427,6 +427,8 @@ int

[PATCH 4/9] PCI/MSI/MIPS: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/mips/pci/msi-octeon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/mips/pci/msi-octeon.c b/arch/mips/pci/msi-octeon.c index d37be36..0ee5f4d 100644 --- a/arch/mips/pci/msi-octeon.c +++ b/arch/mips/pci/msi-octeon.c

[PATCH 6/9] PCI/MSI/s390: Remove superfluous check of MSI type

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/s390/pci/pci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index c79c6e4..61a3c2c 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -425,8 +425,6 @@ int

[PATCH 5/9] PCI/MSI/s390: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/s390/pci/pci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index f17a834..c79c6e4 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -427,6 +427,8 @@ int

[PATCH 7/9] PCI/MSI/s390: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/s390/pci/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index 61a3c2c..45a1875 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -426,7 +426,7 @@ int

[PATCH 8/9] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/pci/msi.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index aca7578..21e6471 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -702,7 +702,7 @@ static int

[PATCH 9/9] PCI/MSI: Make return values only 0/-errno when MSIs allocated

2013-09-09 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- drivers/pci/msi.c | 87 +++-- 1 files changed, 31 insertions(+), 56 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 21e6471..f5fcb74 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci

scrap this one

2013-09-09 Thread Alexander Gordeev
-- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-09 Thread Alexander Gordeev
On Mon, Sep 09, 2013 at 11:37:54AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Sep 09, 2013 at 05:20:44PM +0200, Alexander Gordeev wrote: > > The series is what it seems a direction to take. > > It can definitely use better descriptions explaining why this is > h

Re: [PATCH 5/9] PCI/MSI/s390: Make return values only 0/-errno when MSIs allocated

2013-09-10 Thread Alexander Gordeev
On Tue, Sep 10, 2013 at 04:42:17PM +0400, Sergei Shtylyov wrote: >This contradicts to the patch subject. Sorry, Sergei et al. I screwed this series is bit. The second 5/9 fixes that. > WBR, Sergei > -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this l

Re: [PATCH 0/3] blk-mq: Avoid effects of a weird queue depth

2013-09-12 Thread Alexander Gordeev
Hi Jens, Could you consider patches 4 and 5, please? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-10-07 Thread Alexander Gordeev
in interrupt [ 181.185483] drm_kms_helper: panic occurred, switching back to text console -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Alexander Gordeev
On Mon, Oct 07, 2013 at 09:50:57AM -0700, Jon Mason wrote: > On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: > > On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > > > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > >

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-08 Thread Alexander Gordeev
On Tue, Oct 08, 2013 at 03:33:30PM +1100, Michael Ellerman wrote: > On Wed, Oct 02, 2013 at 12:29:04PM +0200, Alexander Gordeev wrote: > > This technique proved to be confusing and error-prone. Vast share > > of device drivers simply fail to follow the described guidelines. >

Re: [PATCH RFC 07/77] PCI/MSI: Re-design MSI/MSI-X interrupts enablement pattern

2013-10-08 Thread Alexander Gordeev
On Mon, Oct 07, 2013 at 02:17:49PM -0400, Tejun Heo wrote: > Hello, > > On Wed, Oct 02, 2013 at 12:48:23PM +0200, Alexander Gordeev wrote: > > +static int foo_driver_enable_msi(struct foo_adapter *adapter, int nvec) > > +{ > > + rc = pci_get_msi_cap(adapter

Re: [PATCH RFC 05/77] PCI/MSI: Convert pci_msix_table_size() to a public interface

2013-10-08 Thread Alexander Gordeev
On Mon, Oct 07, 2013 at 02:10:43PM -0400, Tejun Heo wrote: > On Wed, Oct 02, 2013 at 12:48:21PM +0200, Alexander Gordeev wrote: > > Make pci_msix_table_size() to return a error code if the device > > does not support MSI-X. This update is needed to facilitate a > > forthcomin

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-08 Thread Alexander Gordeev
w pci_enable_msix() then we could first update pci/msi, then drivers (in few stages possibly) and finally remove the old implementation. > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-08 Thread Alexander Gordeev
t is available and try to allocate with than number. -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-09 Thread Alexander Gordeev
the quota getting increased inbetween? That would entail.. kind of pci_get_msi_limit() :), but IMHO it is not worth it. > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord..

Re: scsi-mq updated to latest linux-block/new-queue

2013-10-09 Thread Alexander Gordeev
ches to include in your tree? I would suggest to consider this one https://lkml.org/lkml/2013/8/9/90 if it fits. -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-10 Thread Alexander Gordeev
eturn value seems odd, but I can not help to make it consistent with the first two. (Sorry if you see this message twice - my MUA seems struggle with one of CC). > Cheers, > Ben. > > -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-10 Thread Alexander Gordeev
On Thu, Oct 10, 2013 at 09:28:27AM -0700, H. Peter Anvin wrote: > On 10/10/2013 03:17 AM, Alexander Gordeev wrote: > > On Wed, Oct 09, 2013 at 03:24:08PM +1100, Benjamin Herrenschmidt wrote: > > > > Ok, this suggestion sounded in one or another form by several people. &

Re: scsi-mq updated to latest linux-block/new-queue

2013-10-10 Thread Alexander Gordeev
h applied will fail. Yep, makes sense. Thanks for pointing out. -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

[PATCH 0/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-02 Thread Alexander Gordeev
This series is aimed to conserve on othewise wasted interrupt resources for 10 of 16 unused MSI vectors for AHCI devices on Intel chipsets. Alexander Gordeev (4): PCI/MSI: Introduce pci_enable_msi_block_part() interface MSI/x86: Support pci_enable_msi_block_part() interface AHCI: Conserve

[PATCH 1/4] PCI/MSI: Introduce pci_enable_msi_block_part() interface

2013-09-02 Thread Alexander Gordeev
7; argument which is then written to the MME register while the value of 'nvec' is still used to setup as many interrupts as requested. Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 56 arch/mips/pci/msi-octeon.c |2 +-

[PATCH 4/4] PCI/MSI: Get rid of pci_enable_msi_block_auto() interface

2013-09-02 Thread Alexander Gordeev
There are no consumers of pci_enable_msi_block_auto() interface have left. Eliminate it for now. Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 12 ++-- drivers/pci/msi.c | 25 - include/linux/pci.h |7

[PATCH 2/4] MSI/x86: Support pci_enable_msi_block_part() interface

2013-09-02 Thread Alexander Gordeev
This update is a prerequisite for the forthcoming update of the AHCI device driver to conserve 10/16 MSIs on Intel chipsets. The update makes use of 'nvec_mme' parameter for pci_enable_msi_block_part() interface. Signed-off-by: Alexander Gordeev --- drivers/iommu/irq_remappin

[PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-02 Thread Alexander Gordeev
Make use of the new pci_enable_msi_block_part() interface and conserve on othewise wasted interrupt resources for 10 of 16 unused MSI vectors on Intel chipsets. Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c | 48 +--- 1 files changed, 29

[PATCH v2 4/4] PCI/MSI: Get rid of pci_enable_msi_block_auto() interface

2013-09-03 Thread Alexander Gordeev
There are no consumers of pci_enable_msi_block_auto() interface have left. Eliminate it for now. Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 40 ++ drivers/pci/msi.c | 25 include/linux

Re: [PATCH 0/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-03 Thread Alexander Gordeev
On Tue, Sep 03, 2013 at 09:55:41AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Sep 02, 2013 at 10:59:07AM +0200, Alexander Gordeev wrote: > > This series is aimed to conserve on othewise wasted interrupt > > resources for 10 of 16 unused MSI vectors for AHCI devices

Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface

2013-09-03 Thread Alexander Gordeev
On Tue, Sep 03, 2013 at 10:18:24AM -0400, Tejun Heo wrote: > On Mon, Sep 02, 2013 at 11:00:28AM +0200, Alexander Gordeev wrote: > > + if (hpriv->flags & AHCI_HFLAG_NO_MSI) > > + goto intx; > > + > > + rc = pci_enable_msi_block_part(pdev, n_port

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-26 Thread Alexander Gordeev
On Wed, Sep 25, 2013 at 05:00:16PM -0400, Tejun Heo wrote: > Hello, > > On Wed, Sep 25, 2013 at 10:58:05PM +0200, Alexander Gordeev wrote: > > Unfortunately, pSeries is a shows-topper here :( It seems we have to > > introduce pci_get_msi{,x}_limit() interfaces to honour th

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-26 Thread Alexander Gordeev
return 0; single_msi: ... } > David -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-26 Thread Alexander Gordeev
system for MSIs") All other archs do not have MSI vector space limitations. > David -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-26 Thread Alexander Gordeev
On Thu, Sep 26, 2013 at 08:32:53AM -0400, Mark Lord wrote: > On 13-09-18 05:48 AM, Alexander Gordeev wrote: > > The last pattern makes most of sense to me and could be updated with a more > > clear sequence - a call to (bit modified) pci_msix_table_size() followed > > by a ca

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-26 Thread Alexander Gordeev
le-MSI'ed devices happened to be a high-performance HBA hitting a degraded performance that alone would force (IBM) to introduce the quotas. Now, if the same/another device happened does not support the legacy interrupt mode and no MSI resources have left in the platform firmware at all... > te

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-10-01 Thread Alexander Gordeev
rs have became clearer as result of this change (and messy ones are still messy). > cheers -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-25 Thread Alexander Gordeev
On Wed, Sep 25, 2013 at 12:02:20PM -0600, Bjorn Helgaas wrote: > On Fri, Sep 20, 2013 at 07:27:36AM -0500, Tejun Heo wrote: > > On Fri, Sep 20, 2013 at 10:24:59AM +0200, Alexander Gordeev wrote: > > > * Make pci_enable_msix() return 0/-errno > > > > My choice would

[PATCH v4 -tip 0/3] x86, MSI, AHCI: Support multiple MSIs

2012-10-06 Thread Alexander Gordeev
loops 'for (; i; i--)' changed to 'for (i--; i >= 0; i--)'; 3/3:ahci_host_activate() failure path tested; ahci_port_priv::lock field commented; Alexander Gordeev (3): 1/3 x86, MSI: Support multiple MSIs in presense

[PATCH v4 -tip 1/3] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-06 Thread Alexander Gordeev
IRQ remapping and lets devices take advantage of multiple queues and per-IRQ affinity assignments. Signed-off-by: Alexander Gordeev --- arch/x86/kernel/apic/io_apic.c | 165 include/linux/irq.h|5 + kernel/irq/chip.c | 30

[PATCH v4 -tip 2/3] PCI, MSI: Enable multiple MSIs with pci_enable_msi_block_auto()

2012-10-06 Thread Alexander Gordeev
MSIs to allocate as a input parameter, pci_enable_msi_block_auto() could be used by device drivers to obtain the number of assigned MSIs and the number of MSIs the device supports. Signed-off-by: Alexander Gordeev Acked-by: Bjorn Helgaas --- Documentation/PCI/MSI-HOWTO.txt | 37

[PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-10-06 Thread Alexander Gordeev
strategy anyway - MRSM bit gets set even if the number of allocated MSIs exceeds the number of implemented ports). Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c| 93 +-- drivers/ata/ahci.h|6 +++ drivers/ata/libahci.c | 118

Re: [PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-11-09 Thread Alexander Gordeev
On Thu, Oct 25, 2012 at 11:36:26AM +0200, Alexander Gordeev wrote: > On Thu, Oct 25, 2012 at 11:25:55AM +0200, Alexander Gordeev wrote: > > On Thu, Oct 25, 2012 at 11:09:57AM +0200, Ingo Molnar wrote: > > > Has Jeff acked this patch? > > > > Yep, > > http://lkm

[PATCH v4 -tip 0/3] x86, MSI, AHCI: Support multiple MSIs

2012-11-19 Thread Alexander Gordeev
by Bjorn, no changes since 3/3:- ahci_host_activate() failure path fixed and tested; - ahci_port_priv::lock field commented; - multi-line comments fixed; v3 acked by Jeff Alexander Gordeev (3): x86, MSI: Support multiple MSIs in pre

[PATCH v4 -tip 1/3] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-11-19 Thread Alexander Gordeev
IRQ remapping and lets devices take advantage of multiple queues and per-IRQ affinity assignments. Signed-off-by: Alexander Gordeev --- arch/x86/kernel/apic/io_apic.c | 165 include/linux/irq.h|5 + kernel/irq/chip.c | 30

[PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-11-19 Thread Alexander Gordeev
strategy anyway - MRSM bit gets set even if the number of allocated MSIs exceeds the number of implemented ports). Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c| 93 +-- drivers/ata/ahci.h|6 +++ drivers/ata/libahci.c | 118

[PATCH v4 -tip 2/3] PCI, MSI: Enable multiple MSIs with pci_enable_msi_block_auto()

2012-11-19 Thread Alexander Gordeev
MSIs to allocate as a input parameter, pci_enable_msi_block_auto() could be used by device drivers to obtain the number of assigned MSIs and the number of MSIs the device supports. Signed-off-by: Alexander Gordeev Acked-by: Bjorn Helgaas --- Documentation/PCI/MSI-HOWTO.txt | 37

Re: [PATCH RFC -tip 0/6] perf: IRQ-bound performance events

2013-06-04 Thread Alexander Gordeev
n IRQ handlers, they'll pretty much always miss l1 > cache. The emphasis was on the fact it indeed could be measured for a particular ISR ;) -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-04 Thread Alexander Gordeev
mapping.c patch? If so, I can > merge that branch into -next for v3.11. Konrad, Sebastian, Any chance to take a look and patch 2/2? Thanks! > Bjorn -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-06 Thread Alexander Gordeev
On Wed, Jun 05, 2013 at 10:56:38PM +0200, Sebastian Andrzej Siewior wrote: > On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: > > Note, although the existing 'msi_desc::multiple' field might seem > > redundant, in fact in does not. In general case the

[PATCH] powerpc/pseries: Request FW for power of two MSI-Xs only

2013-05-31 Thread Alexander Gordeev
before. This update sticks to the idea the firmware can only allocate power of two MSI-X interrupts and makes the logic bit more straight. Signed-off-by: Alexander Gordeev --- arch/powerpc/platforms/pseries/msi.c | 43 - 1 files changed, 21 insertions(+), 22

[PATCH] irqdomain: Do not reuse existing mappings

2013-05-31 Thread Alexander Gordeev
() to complain loudly and bail out if an unexpected mapping detected. Signed-off-by: Alexander Gordeev --- Documentation/IRQ-domain.txt|7 +++ arch/powerpc/platforms/44x/currituck.c |1 + arch/powerpc/platforms/maple/pci.c |2 ++ arch/powerpc/platforms/pasemi

Re: [PATCH] irqdomain: Do not reuse existing mappings

2013-06-02 Thread Alexander Gordeev
On Fri, May 31, 2013 at 11:30:24PM +0100, Grant Likely wrote: > On Fri, 31 May 2013 14:59:11 +0200, Alexander Gordeev > wrote: > What exactly is the problem that you're trying to solve with this patch? > It's not clear from the description. Hi Grant, Thanks for

Re: [PATCH] irqdomain: Do not reuse existing mappings

2013-06-03 Thread Alexander Gordeev
On Sun, Jun 02, 2013 at 05:52:21PM +0100, Grant Likely wrote: > On Sun, Jun 2, 2013 at 12:56 PM, Alexander Gordeev > wrote: > > On Fri, May 31, 2013 at 11:30:24PM +0100, Grant Likely wrote: > >> On Fri, 31 May 2013 14:59:11 +0200, Alexander Gordeev > >> wrote: &g

[PATCH RFC -tip 2/6] perf/x86: IRQ-bound performance events

2013-06-03 Thread Alexander Gordeev
Generic changes to x86 performance framework to further enable implementations of IRQ-bound performance events. Signed-off-by: Alexander Gordeev --- arch/x86/kernel/cpu/perf_event.c | 33 +-- arch/x86/kernel/cpu/perf_event.h |5 arch/x86/kernel

[PATCH RFC -tip 5/6] perf/x86/Intel PMU: IRQ-bound performance events

2013-06-03 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev --- arch/x86/kernel/cpu/perf_event_intel.c| 74 + arch/x86/kernel/cpu/perf_event_intel_ds.c |5 +- 2 files changed, 68 insertions(+), 11 deletions(-) diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu

<    1   2   3   4   5   6   7   8   9   10   >