[PATCH] resend, 8250 woraround for buggy uart

2005-02-15 Thread Alex Williamson
tly with a LCR value of 0xBF). Can we get this into the queue once 2.6.12 opens? I'd be happy to test any modifications on this solution. Thanks, Alex [1] http://marc.theaimsgroup.com/?l=linux-kernel&m=110297697227569 -- Signed-off-by: Alex Williamson <[EMAIL PROTECTED]&

Re: [patch] Add insmod option to force the use of the backup timer.

2007-03-05 Thread Alex Williamson
of the UART at that point may be a clue how to detect the problem. UARTs often seem to be the most troubling part of a system, so I'm not opposed to a boot/module option, but auto-detection provides a much better user experience. Thanks, Alex -- Alex Williamson

[PATCH] tpm_infineon: add support for devices in mmio space

2007-03-07 Thread Alex Williamson
The patch below adds support for devices living in MMIO space to the Infineon TPM driver. These can be found on some of the newer HP ia64 systems. Thanks, Alex Signed-off-by: Alex Williamson <[EMAIL PROTECTED]> --- diff -r c8e6d6d04971 -r 5e0fb1be86e6 drivers/ch

Re: [PATCH] tpm_infineon: add support for devices in mmio space

2007-03-07 Thread Alex Williamson
On Wed, 2007-03-07 at 13:33 -0800, Andrew Morton wrote: > > tpm_inf_pnp_probe() leaks resources all over the place if something goes > wrong. Good point, here's an update that cleans up after itself a bit better. Thanks, Alex Signed-off-by: Alex Williamson <

[PATCH] vfio-pci: Virtualize PCIe & AF FLR

2016-09-22 Thread Alex Williamson
ting into bad states with userspace drivers, like dpdk, running inside a VM. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci_config.c | 82 ++-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_con

[PATCH] vfio-pci: Disable INTx after MSI/X teardown

2016-09-22 Thread Alex Williamson
The MSI/X shutdown path can gratuitously enable INTx, which is not something we want to happen if we're dealing with broken INTx device. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci_intrs.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/vfi

[GIT PULL] VFIO updates for v4.8-rc1

2016-07-28 Thread Alex Williamson
Hi Linus, The following changes since commit 33688abb2802ff3a230bd2441f765477b94cc89e: Linux 4.7-rc4 (2016-06-19 21:30:02 -0700) are available in the git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v4.8-rc1 for you to fetch changes up to 0991bbdbf5b85bd14a26e783f087b0

Re: [PATCH v2 1/2] vfio : resume notifier

2016-07-29 Thread Alex Williamson
On Tue, 19 Jul 2016 15:52:45 +0800 Zhou Jie wrote: > From: Chen Fan An empty commit log is unacceptable for all but the most trivial patches. There's also no sign-off on this patch. I also don't know why we need this since you previously found that for QEMU, ordering of error versus resume no

Re: [Qemu-devel] [PATCH v2 2/2] vfio : add aer process

2016-07-29 Thread Alex Williamson
On Tue, 19 Jul 2016 15:32:43 +0800 Zhou Jie wrote: > From: Chen Fan > > During aer err occurs and resume do following to > protect device from being accessed. > 1. Make config space read only. > 2. Disable INTx/MSI Interrupt. > 3. Do nothing for bar regions. > > Signed-off-by: Zhou Jie > ---

Re: [Qemu-devel] [PATCH v2 2/2] vfio : add aer process

2016-08-01 Thread Alex Williamson
On Mon, 1 Aug 2016 10:14:06 +0800 Zhou Jie wrote: > Hi, Alex > > On 2016/7/30 1:12, Alex Williamson wrote: > > On Tue, 19 Jul 2016 15:32:43 +0800 > > Zhou Jie wrote: > > > >> From: Chen Fan > >> > >> During aer err occurs and resume d

Re: [PATCH] vfio: platform: mark symbols static where possible

2016-09-13 Thread Alex Williamson
On Thu, 1 Sep 2016 19:15:35 +0800 Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/vfio/platform/vfio_platform_common.c:76:5: warning: no previous > prototype for 'vfio_platform_acpi_call_reset' [-Wmissing-prototypes] > drivers/vfio/platform/vfio_platform_commo

Re: [RFC PATCH v5 0/5] vfio-pci: Add support for mmapping MSI-X table

2017-08-16 Thread Alex Williamson
On Wed, 16 Aug 2017 10:35:49 +1000 Benjamin Herrenschmidt wrote: > On Tue, 2017-08-15 at 10:37 -0600, Alex Williamson wrote: > > Of course I don't think either of those are worth imposing a > > performance penalty where we don't otherwise need one. However, if we > &

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-17 Thread Alex Williamson
On Thu, 17 Aug 2017 10:14:23 +0200 Jan Glauber wrote: > If a PCI device supports neither function-level reset, nor slot > or bus reset then refuse to probe it. A line is printed to inform > the user. But that's not what this does, this requires that the device is on a reset-able bus. This is a

Re: [PATCH 00/13] Introduce IOMMU-API TLB Flushing Interface

2017-08-17 Thread Alex Williamson
On Thu, 17 Aug 2017 14:56:23 +0200 Joerg Roedel wrote: > Hi, > > here is a patch-set to introduce an explicit interface to > the IOMMU-API to flush IOMMU and device IO/TLBs. Currently > the iommu_map(), iommu_map_sg(), and iommu_unmap() functions > have to make sure all IO/TLBs in the system are

Re: [PATCH 00/13] Introduce IOMMU-API TLB Flushing Interface

2017-08-17 Thread Alex Williamson
On Thu, 17 Aug 2017 16:43:08 +0200 Joerg Roedel wrote: > Hi Alex, > > On Thu, Aug 17, 2017 at 08:35:20AM -0600, Alex Williamson wrote: > > Wouldn't it be much more friendly to downstreams and out-of-tree > > drivers to introduce new functions for the async semantics

Re: [RFC PATCH v5 0/5] vfio-pci: Add support for mmapping MSI-X table

2017-08-17 Thread Alex Williamson
On Thu, 17 Aug 2017 10:56:35 + David Laight wrote: > From: Alex Williamson > > Sent: 16 August 2017 17:56 > ... > > Firmware pissing match... Processors running with 8k or less page size > > fall within the recommendations of the PCI spec for register alignment &g

[PATCH] vfio: Stall vfio_del_group_dev() for container group detach

2017-08-17 Thread Alex Williamson
of the group attached to the container can result in errors as the next driver configures DMA for the device. Wait for the group to be detached from the IOMMU backend before allowing the bus driver remove callback to complete. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20

Re: [PATCH v2 2/9] kvm-vfio: Decouple only when we match a group

2017-06-19 Thread Alex Williamson
On Tue, 20 Jun 2017 12:34:57 +1000 Alexey Kardashevskiy wrote: > On 20/06/17 03:14, Alex Williamson wrote: > > Unset-KVM and decrement-assignment only when we find the group in our > > list. Otherwise we can get out of sync if the user triggers this for > > groups that ar

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-20 Thread Alex Williamson
On Tue, 20 Jun 2017 12:57:36 +0200 Gerd Hoffmann wrote: > On Tue, 2017-06-20 at 08:41 +, Zhang, Tina wrote: > > Hi, > > > > Thanks for all the comments. Here are the summaries: > > > > 1. Modify the structures to make it more general. > > struct vfio_device_gfx_plane_info { > > __u64 st

[PATCH v3 1/9] vfio: Fix group release deadlock

2017-06-20 Thread Alex Williamson
ct to release this reference asynchronously. Signed-off-by: Alex Williamson Reviewed-by: Eric Auger Cc: sta...@vger.kernel.org --- drivers/vfio/vfio.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c

[PATCH v3 3/9] vfio: New external user group/file match

2017-06-20 Thread Alex Williamson
file to a group to facilitate this. Given a file and group, report if they match. Thus the caller needs to already have a group reference to match to the file. This allows the deletion of a group without acquiring a new reference. Signed-off-by: Alex Williamson Reviewed-by: Eric Auger Reviewed

[PATCH v3 4/9] iommu: Add driver-not-bound notification

2017-06-20 Thread Alex Williamson
The driver core supports a BUS_NOTIFY_DRIVER_NOT_BOUND notification sent if a driver fails to bind to a device. Extend IOMMU group notifications to include a version of this. Signed-off-by: Alex Williamson Acked-by: Joerg Roedel Reviewed-by: Eric Auger --- drivers/iommu/iommu.c |3

[PATCH v3 7/9] vfio: Use driver_override to avert binding to compromising drivers

2017-06-20 Thread Alex Williamson
ve in allowing empty groups to finish cleanup. Signed-off-by: Alex Williamson Reviewed-by: Eric Auger Tested-by: Eric Auger --- drivers/vfio/vfio.c | 145 +-- 1 file changed, 138 insertions(+), 7 deletions(-) diff --git a/drivers/vfio/vfio.c b/dr

[PATCH v3 0/9] vfio: Fix release ordering races and use driver_override

2017-06-20 Thread Alex Williamson
in the latter 4 patches of this series, minding that we need to allow re-binding to non-compromising drivers, and also noting that a small synchronization stall is effective in eliminating the need for this blocking in the more common singleton device group case. Reviews, comments, and acks

[PATCH v3 5/9] vfio: Create interface for vfio bus drivers to register

2017-06-20 Thread Alex Williamson
vfio compatible during a bind operation. For devices on buses with driver_override support, we can use this linkage to block non-vfio drivers from binding to devices where the iommu group state would trigger a BUG to avoid host/user integrity issues. Signed-off-by: Alex Williamson Reviewed-by: Eric

[PATCH v3 8/9] amba: Export amba_bustype

2017-06-20 Thread Alex Williamson
This allows modules to match struct device.bus to amba_bustype for the purpose of casting the device to an amba_device with to_amba_device(). Signed-off-by: Alex Williamson Reported-by: Eric Auger Cc: Russell King --- drivers/amba/bus.c |1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v3 9/9] vfio: Add AMBA driver_override support

2017-06-20 Thread Alex Williamson
AMBA also supports driver_override, but amba_bustype was not exported to be able to identify an amba device. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 20e57fecf652

[PATCH v3 6/9] vfio: Register pci, platform, amba, and mdev bus drivers

2017-06-20 Thread Alex Williamson
Hook into vfio bus driver register/unregister support. Signed-off-by: Alex Williamson Reviewed-by: Eric Auger Cc: Baptiste Reynal Cc: Kirti Wankhede --- drivers/vfio/mdev/vfio_mdev.c | 13 - drivers/vfio/pci/vfio_pci.c |7 +++ drivers/vfio/platform

[PATCH v3 2/9] kvm-vfio: Decouple only when we match a group

2017-06-20 Thread Alex Williamson
Unset-KVM and decrement-assignment only when we find the group in our list. Otherwise we can get out of sync if the user triggers this for groups that aren't currently on our list. Signed-off-by: Alex Williamson Reviewed-by: Alexey Kardashevskiy Cc: Paolo Bonzini Cc: Eric Auger Cc

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-20 Thread Alex Williamson
On Tue, 20 Jun 2017 23:01:53 + "Zhang, Tina" wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, June 20, 2017 11:00 PM > > To: Gerd Hoffmann > > Cc: Zhang, Tina ; intel-...@li

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-21 Thread Alex Williamson
On Wed, 21 Jun 2017 13:03:31 +0200 Gerd Hoffmann wrote: > On Wed, 2017-06-21 at 09:20 +, Zhang, Tina wrote: > > Thanks for all the comments. I'm planning to cook the next version of > > this patch set > > How about posting only this patch instead of the whole series until > we've settled t

Re: [PATCH] PCI: Make SR-IOV capable GPU working on the SR-IOV incapable platform

2017-05-26 Thread Alex Williamson
-Original Message- > From: Cheng, Collins > Sent: Wednesday, May 24, 2017 4:56 PM > To: 'Alex Williamson' > Cc: Alexander Duyck ; Bjorn Helgaas > ; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org; Deucher, Alexander ; > Zytaruk, Kelly ; Yinghai Lu &g

Re: [PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-05-26 Thread Alex Williamson
ci/probe.c | 44 > include/linux/pci.h | 13 +++-- > 3 files changed, 56 insertions(+), 43 deletions(-) Looks reasonable to me. Reviewed-by: Alex Williamson > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index b01bd5b..7

Re: [PATCH 0/2] PCI: Workaround for bus reset on Cavium cn8xxx root ports

2017-05-30 Thread Alex Williamson
On Mon, 29 May 2017 23:30:52 -0400 Jon Masters wrote: > Following up on this thread... > > On 05/23/2017 06:15 PM, Alex Williamson wrote: > > On Tue, 23 May 2017 14:22:01 -0700 > > David Daney wrote: > > > >> On 05/23/2017 02:04 PM, Alex Williamson wrot

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-24 Thread Alex Williamson
On Tue, 24 Oct 2017 13:04:26 -0700 Jeff Kirsher wrote: > From: Liang-Min Wang > > When a SR-IOV supported device is bound with vfio-pci, the driver > could not create SR-IOV instance through /sys/bus/pci/devices/... > /sriov_numvfs. This patch re-activates this capability for a PCIe > device t

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-24 Thread Alex Williamson
On Tue, 24 Oct 2017 21:49:15 + "Wang, Liang-min" wrote: > Just like any PCIe devices that supports SR-IOV. There are restrictions set > for VF. Also, there is a concept of trust VF now available for PF to manage > certain features that only selected VF could exercise. Are you saying all the

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-25 Thread Alex Williamson
On Tue, 24 Oct 2017 22:29:00 + "Wang, Liang-min" wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, October 24, 2017 6:07 PM > > To: Wang, Liang-min > > Cc: Kirsher, Jef

Re: [PATCH] PCI: rework error checking in the reset path

2017-10-25 Thread Alex Williamson
On Wed, 25 Oct 2017 08:45:11 -0500 Bjorn Helgaas wrote: > [+cc Alex] > > On Mon, Oct 23, 2017 at 05:36:48PM -0400, Sinan Kaya wrote: > > The return codes from various reset types are not consistent. The code is > > assuming that all reset types will return -ENOTTY when things go wrong. > > Inste

Re: [PATCH v10] vfio: platform: reset: Add Broadcom FlexRM reset module

2017-10-25 Thread Alex Williamson
On Wed, 25 Oct 2017 11:19:21 +0530 Anup Patel wrote: > On Tue, Oct 3, 2017 at 10:57 AM, Anup Patel wrote: > > This patch adds Broadcom FlexRM low-level reset for > > VFIO platform. > > > > It will do the following: > > 1. Disable/Deactivate each FlexRM ring > > 2. Flush each FlexRM ring > > > >

Re: [PATCH] iommu/amd: remove unused variable flush_addr

2017-10-25 Thread Alex Williamson
On Sun, 22 Oct 2017 13:49:45 +0200 Colin King wrote: > From: Colin Ian King > > Variable flush_addr is being assigned but is never read; it > is redundant and can be removed. Cleans up the clang warning: > > drivers/iommu/amd_iommu.c:2388:2: warning: Value stored to 'flush_addr' > is never rea

Re: Parental Leave and IOMMU Maintenance

2017-10-25 Thread Alex Williamson
On Sun, 22 Oct 2017 15:06:05 +0200 Joerg Roedel wrote: > Hi, > > after the birth of my second son last week I am taking a parental leave > until the end of the year. During this time Alex Williamson will take > over the maintenance of the IOMMU-code in the Linux kernel. > &

Re: [PATCH] PCI: rework error checking in the reset path

2017-10-25 Thread Alex Williamson
On Wed, 25 Oct 2017 17:10:46 -0500 Bjorn Helgaas wrote: > On Wed, Oct 25, 2017 at 11:28:05PM +0200, Alex Williamson wrote: > > On Wed, 25 Oct 2017 08:45:11 -0500 > > Bjorn Helgaas wrote: > > > > > [+cc Alex] > > > > > > On Mon, Oc

Re: [PATCH] iommu: Limit the IOVA page range to the specified addresses

2017-10-26 Thread Alex Williamson
On Tue, 17 Oct 2017 16:22:01 -0500 Gary R Hook wrote: > From: amd > > The extent of pages specified when applying a reserved region should > include up to the last page of the range, but not the page following > the range. > > Signed-off-by: Gary R Hook > --- > drivers/iommu/amd_iommu.c |

[GIT PULL] IOMMU updates for v4.15

2017-11-13 Thread Alex Williamson
lbacks * Fix sleeping lock with preemption disabled for RT * Dual MMU support for TI DRA7xx DSPs * Optional flush option on IOVA allocation avoiding overhead when caller can try other options ---- Alex Williamson (2): iommu/amd:

[GIT PULL] VFIO updates for v4.15

2017-11-13 Thread Alex Williamson
ockups on SPAPR when clearing TCE * Broadcom FlexRM platform device support * Samples driver cleanup & type1 integer overflow fix ---- Alex Williamson (3): vfio/pci: Virtualize Maximum Payload Size vfio/pci: Virtualize M

Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-05 Thread Alex Williamson
o save > the decoded plane information to avoid look up while need the plane > info. (Gerd) > > Signed-off-by: Tina Zhang > Cc: Gerd Hoffmann > Cc: Alex Williamson > Cc: Daniel Vetter > --- > include/uapi/linux/vfio.h | 68 > +

Re: [PATCH v2] iommu/iova: Use raw_cpu_ptr() instead of get_cpu_ptr() for ->fq

2017-11-06 Thread Alex Williamson
[cc +robin] On Thu, 2 Nov 2017 18:33:50 +0100 Sebastian Andrzej Siewior wrote: > On 2017-09-21 17:21:40 [+0200], Sebastian Andrzej Siewior wrote: > > get_cpu_ptr() disabled preemption and returns the ->fq object of the > > current CPU. raw_cpu_ptr() does the same except that it not disable > > p

Re: [PATCH -next] iommu/ipmmu-vmsa: Fix return value check in ipmmu_find_group_dma()

2017-11-06 Thread Alex Williamson
On Tue, 17 Oct 2017 12:11:22 + Wei Yongjun wrote: > In case of error, the function iommu_group_get() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 3ae47292024f ("iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops

Re: [PATCH v2] iommu/iova: Use raw_cpu_ptr() instead of get_cpu_ptr() for ->fq

2017-11-06 Thread Alex Williamson
On Mon, 6 Nov 2017 16:45:11 + Robin Murphy wrote: > On 06/11/17 15:43, Alex Williamson wrote: > > [cc +robin] > > > > On Thu, 2 Nov 2017 18:33:50 +0100 > > Sebastian Andrzej Siewior wrote: > > > >> On 2017-09-21 17:21:40 [+0200], Sebastian

Re: [PATCH v5 00/09] iommu/ipmmu-vmsa: r8a7795 support V5

2017-11-06 Thread Alex Williamson
On Mon, 16 Oct 2017 21:29:14 +0900 Magnus Damm wrote: > iommu/ipmmu-vmsa: r8a7795 support V5 > > [PATCH v5 01/09] iommu/ipmmu-vmsa: Introduce features, break out alias > [PATCH v5 02/09] iommu/ipmmu-vmsa: Add optional root device feature > [PATCH v5 03/09] iommu/ipmmu-vmsa: Enable multi context

Re: [PATCH] iommu/mediatek: Fix driver name

2017-11-06 Thread Alex Williamson
On Mon, 30 Oct 2017 12:37:55 +0100 Matthias Brugger wrote: > There exist two Mediatek iommu drivers for the two different > generations of the device. But both drivers have the same name > "mtk-iommu". This breaks the registration of the second driver: > > Error: Driver 'mtk-iommu' is already re

Re: [PATCH 1/3] iommu/vt-d: Missing checks for pasid tables if allocation fails

2017-11-06 Thread Alex Williamson
On Thu, 19 Oct 2017 08:39:14 +0800 Lu Baolu wrote: > intel_svm_alloc_pasid_tables() might return an error but never be > checked by the callers. Later when intel_svm_bind_mm() is called, > there are no checks for valid pasid tables before enabling them. > > Signed-off-by: Ashok Raj > Signed-off

Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-06 Thread Alex Williamson
On Mon, 06 Nov 2017 10:05:34 +0100 Gerd Hoffmann wrote: > Hi, > > > > I thought we had agreed to make this behave similar to > > > VFIO_GROUP_GET_DEVICE_FD, the ioctl would take a __u32 dmabuf_id > > > and > > > return the file descriptor as the ioctl return value.  Thanks, > > > > If we fo

[PATCH] iommu/amd: Fix alloc_irq_index() increment

2017-10-18 Thread Alex Williamson
was found to be unallocated. Fixes: 37946d95fc1a ('iommu/amd: Add align parameter to alloc_irq_index()') Signed-off-by: Alex Williamson --- drivers/iommu/amd_iommu.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iomm

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-27 Thread Alex Williamson
On Fri, 27 Oct 2017 21:50:43 + "Wang, Liang-min" wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, October 24, 2017 6:07 PM > > To: Wang, Liang-min > > Cc: Kirsher, Jef

Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support

2015-10-06 Thread Alex Williamson
On Tue, 2015-10-06 at 18:23 +0300, Avi Kivity wrote: > > On 10/06/2015 05:56 PM, Michael S. Tsirkin wrote: > > On Tue, Oct 06, 2015 at 05:43:50PM +0300, Vlad Zolotarov wrote: > >> The only "like VFIO" behavior we implement here is binding the MSI-X > >> interrupt notification to eventfd descriptor

Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support

2015-10-06 Thread Alex Williamson
On Tue, 2015-10-06 at 22:32 +0100, Stephen Hemminger wrote: > On Tue, 06 Oct 2015 12:51:20 -0600 > Alex Williamson wrote: > > > Of course this is entirely unsafe and this no-iommu driver should taint > > the kernel, but it at least standardizes on one userspace API and you

Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support

2015-10-07 Thread Alex Williamson
On Wed, 2015-10-07 at 09:52 +0300, Avi Kivity wrote: > > On 10/06/2015 09:51 PM, Alex Williamson wrote: > > On Tue, 2015-10-06 at 18:23 +0300, Avi Kivity wrote: > >> On 10/06/2015 05:56 PM, Michael S. Tsirkin wrote: > >>> On Tue, Oct 06, 2015 at 05:43:50PM +0300,

Re: [PATCH v3 04/10] VFIO: platform: add vfio_platform_set_automasked

2015-08-31 Thread Alex Williamson
On Mon, 2015-08-31 at 13:43 +0200, Antonios Motakis wrote: > > On 18-Aug-15 19:44, Alex Williamson wrote: > > On Mon, 2015-08-17 at 17:38 +0200, Eric Auger wrote: > >> On 08/12/2015 08:56 PM, Alex Williamson wrote: > >>> On Mon, 2015-08-10 at 15:20 +0200, Eric

Re: [RFC PATCH 2/2] vfio: Include no-iommu mode

2015-10-12 Thread Alex Williamson
On Mon, 2015-10-12 at 08:56 -0700, Stephen Hemminger wrote: > On Fri, 09 Oct 2015 12:41:10 -0600 > Alex Williamson wrote: > > > There is really no way to safely give a user full access to a PCI > > without an IOMMU to protect the host from errant DMA. There is also >

Re: [RFC PATCH 2/2] vfio: Include no-iommu mode

2015-10-12 Thread Alex Williamson
On Mon, 2015-10-12 at 19:27 +0300, Michael S. Tsirkin wrote: > On Mon, Oct 12, 2015 at 08:56:07AM -0700, Stephen Hemminger wrote: > > On Fri, 09 Oct 2015 12:41:10 -0600 > > Alex Williamson wrote: > > > > > There is really no way to safely give a user full access t

Re: [RFC PATCH 2/2] vfio: Include no-iommu mode

2015-10-12 Thread Alex Williamson
On Mon, 2015-10-12 at 11:46 -0600, Alex Williamson wrote: > On Mon, 2015-10-12 at 19:27 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 12, 2015 at 08:56:07AM -0700, Stephen Hemminger wrote: > > > On Fri, 09 Oct 2015 12:41:10 -0600 > > > Alex Williamson wrote: > &

Re: [RFC PATCH v4 1/3] vfio: platform: add device properties skeleton and user API

2015-09-09 Thread Alex Williamson
On Wed, 2015-09-09 at 11:17 +0200, Baptiste Reynal wrote: > From: Antonios Motakis > > This patch introduces an API that allows to return device properties (OF > or ACPI) of a device bound to the vfio-platform/vfio-amba driver and the > skeleton of the implementation for VFIO_PLATFORM. Informatio

Re: [RFC PATCH v4 2/3] vfio: platform: access device property as a list of strings

2015-09-09 Thread Alex Williamson
On Wed, 2015-09-09 at 11:17 +0200, Baptiste Reynal wrote: > From: Antonios Motakis > > Certain device properties (e.g. the device node name, the compatible > string), are available as a list of strings (separated by the null > terminating character). Let the VFIO user query this type of propertie

Re: [RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers

2015-09-09 Thread Alex Williamson
On Wed, 2015-09-09 at 11:17 +0200, Baptiste Reynal wrote: > From: Antonios Motakis > > Certain properties of a device are accessible as an array of unsigned > integers, either u64, u32, u16, or u8. Let the VFIO user query this > type of device properties. > > Signed-off-by: Antonios Motakis > S

[RFC PATCH v2] vfio: Include No-IOMMU mode

2015-10-14 Thread Alex Williamson
rt for the vfio-pci bus driver only. Signed-off-by: Alex Williamson --- v2: Less code, more features. We don't really need to register an iommu_ops for a bus, we can get away with creating an IOMMU group on-demand when we're running in noiommu mode. That also let's us have a me

Re: [PATCH] VFIO: platform: AMD xgbe reset module

2015-10-15 Thread Alex Williamson
On Thu, 2015-10-15 at 16:46 +0200, Eric Auger wrote: > Hi Arnd, > On 10/15/2015 03:59 PM, Arnd Bergmann wrote: > > On Thursday 15 October 2015 14:12:28 Christoffer Dall wrote: > >>> > >>> enum vfio_platform_op { > >>> VFIO_PLATFORM_BIND, > >>> VFIO_PLATFORM_UNBIND, > >>> VFIO_PLAT

Re: [PATCH] VFIO: platform: AMD xgbe reset module

2015-10-15 Thread Alex Williamson
On Thu, 2015-10-15 at 21:42 +0200, Christoffer Dall wrote: > On Thu, Oct 15, 2015 at 10:53:17AM -0600, Alex Williamson wrote: > > On Thu, 2015-10-15 at 16:46 +0200, Eric Auger wrote: > > > Hi Arnd, > > > On 10/15/2015 03:59 PM, Arnd Bergmann wrote: > > > &g

[RFC PATCH] vfio/type1: Do not support IOMMUs that allow bypass

2015-10-15 Thread Alex Williamson
We can only provide isolation if DMA is forced through the IOMMU aperture. Don't allow type1 to be used if this is not the case. Signed-off-by: Alex Williamson --- Eric, I see a number of IOMMU drivers enable this, do the ones you care about for ARM set geometry.force_aperture? Thanks,

[PATCH] vfio/pci: Use kernel VPD access functions

2015-10-15 Thread Alex Williamson
with access through sysfs, but the window of opportunity is much smaller. Signed-off-by: Alex Williamson Acked-by: Mark Rustad --- I posted this about a month ago as an RFC and it got positive feedback as a thing we should do. Therefore, officially proposing it for v4.4. drivers/vfio/pci

Re: [RFC PATCH] vfio/type1: Do not support IOMMUs that allow bypass

2015-10-16 Thread Alex Williamson
On Fri, 2015-10-16 at 16:03 +0200, Eric Auger wrote: > Hi Alex, > On 10/15/2015 10:52 PM, Alex Williamson wrote: > > We can only provide isolation if DMA is forced through the IOMMU > > aperture. Don't allow type1 to be used if this is not the case. > > >

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-21 Thread Alex Williamson
On Wed, 2015-10-21 at 21:45 +0300, Or Gerlitz wrote: > On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: > > This patchset is to propose a new solution to add live migration support > > for 82599 SRIOV network card. > > > In our solution, we prefer to put all device specific operation into VF an

Re: [Qemu-devel] [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-22 Thread Alex Williamson
On Thu, 2015-10-22 at 15:32 +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 01:20:27PM -0600, Alex Williamson wrote: > > The trouble here is that the VF needs to be unplugged prior to the start > > of migration because we can't do effective dirty page tracking whi

Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release

2015-10-22 Thread Alex Williamson
On Thu, 2015-10-22 at 16:23 +0200, Eric Auger wrote: > On 10/22/2015 04:10 PM, Arnd Bergmann wrote: > > On Thursday 22 October 2015 15:26:55 Eric Auger wrote: > @@ -181,6 +182,8 @@ static int vfio_platform_open(void *device_data) > if (ret) > g

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-22 Thread Alex Williamson
On Thu, 2015-10-22 at 18:58 +0300, Or Gerlitz wrote: > On Wed, Oct 21, 2015 at 10:20 PM, Alex Williamson > wrote: > > > This is why the typical VF agnostic approach here is to using bonding > > and fail over to a emulated device during migration, so performance > &g

Re: [PATCH 1/4] vfio: platform: add capability to register a reset function

2015-10-19 Thread Alex Williamson
On Sun, 2015-10-18 at 18:00 +0200, Eric Auger wrote: > In preparation for subsequent changes in reset function lookup, > lets introduce a dynamic list of reset combos (compat string, > reset module, reset function). The list can be populated/voided with > two new functions, vfio_platform_register/u

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-23 Thread Alex Williamson
On Fri, 2015-10-23 at 11:36 -0700, Alexander Duyck wrote: > On 10/21/2015 09:37 AM, Lan Tianyu wrote: > > This patchset is to propose a new solution to add live migration support > > for 82599 > > SRIOV network card. > > > > Im our solution, we prefer to put all device specific operation into VF a

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

2015-10-26 Thread Alex Williamson
On Mon, 2015-10-26 at 18:20 -0700, Yunhong Jiang wrote: > An option to force VFIO PCI MSI/MSI-X handler as non-threaded IRQ, > even when CONFIG_IRQ_FORCED_THREADING=y. This is uselful when > assigning a device to a guest with low latency requirement since it > reduce the context switch to/from the

Re: [PATCH] vfio: Mark expected switch fall-throughs

2018-08-07 Thread Alex Williamson
On Mon, 9 Jul 2018 17:53:09 -0500 "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/vfio/pci/vfio_pci.c | 2 +- > drivers/vfio/vfio_iommu_type1

[PATCH v4 0/3] PCI: NVMe reset quirks

2018-08-09 Thread Alex Williamson
needing similar behavior can also use. Thanks, Alex --- Alex Williamson (3): PCI: Export pcie_has_flr() PCI: Samsung SM961/PM961 NVMe disable before FLR quirk PCI: Intel DC P3700 NVMe delay after FLR quirk drivers/pci/pci.c|3 + drivers/pci/

[PATCH v4 1/3] PCI: Export pcie_has_flr()

2018-08-09 Thread Alex Williamson
pcie_flr() suggests pcie_has_flr() to ensure that PCIe FLR support is present prior to calling. pcie_flr() is exported while pcie_has_flr() is not. Resolve this. Signed-off-by: Alex Williamson --- drivers/pci/pci.c |3 ++- include/linux/pci.h |1 + 2 files changed, 3 insertions

[PATCH v4 3/3] PCI: Intel DC P3700 NVMe delay after FLR quirk

2018-08-09 Thread Alex Williamson
with a device specific reset quirk to add an additional, heuristically determined, delay after the FLR completes. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1592654 Signed-off-by: Alex Williamson --- drivers/pci/quirks.c | 22 ++ 1 file changed, 22 insertions(+) diff

[PATCH v4 2/3] PCI: Samsung SM961/PM961 NVMe disable before FLR quirk

2018-08-09 Thread Alex Williamson
controller) prior to FLR. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1542494 Signed-off-by: Alex Williamson --- drivers/pci/quirks.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index

Re: [PATCH] vfio/pci: Fix potential Spectre v1

2018-07-18 Thread Alex Williamson
On Tue, 17 Jul 2018 12:39:00 -0500 "Gustavo A. R. Silva" wrote: > info.index can be indirectly controlled by user-space, hence leading > to a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > drivers/vfio/pci/vfio_pci.c:734 v

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-18 Thread Alex Williamson
On Thu, 19 Jul 2018 00:05:18 +0530 Srinath Mannam wrote: > Hi Alex, > > On Tue, Jul 17, 2018 at 8:52 PM, Alex Williamson > wrote: > > On Fri, 13 Jul 2018 10:26:17 +0530 > > Srinath Mannam wrote: > > > >> By default all BARs map with VMA acce

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-19 Thread Alex Williamson
On Thu, 19 Jul 2018 20:17:11 +0530 Srinath Mannam wrote: > HI Alex, > > On Thu, Jul 19, 2018 at 2:55 AM, Alex Williamson > wrote: > > On Thu, 19 Jul 2018 00:05:18 +0530 > > Srinath Mannam wrote: > > > >> Hi Alex, > >> > >> On

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-20 Thread Alex Williamson
On Thu, 19 Jul 2018 21:49:48 +0530 Srinath Mannam wrote: > HI Alex, > > On Thu, Jul 19, 2018 at 8:42 PM, Alex Williamson > wrote: > > On Thu, 19 Jul 2018 20:17:11 +0530 > > Srinath Mannam wrote: > > > >> HI Alex, > >> > >> On

[GIT PULL] VFIO fixes for v4.18-rc6

2018-07-20 Thread Alex Williamson
Hi Linus, The following changes since commit 9d3cce1e8b8561fed5f383d22a4d6949db4eadbe: Linux 4.18-rc5 (2018-07-15 12:49:31 -0700) are available in the Git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v4.18-rc6 for you to fetch changes up to 0e714d27786ce1fb3efa9aac58ab

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-08-01 Thread Alex Williamson
On Wed, 1 Aug 2018 23:28:53 +0530 Srinath Mannam wrote: > Hi Alex, > > In user space UIO driver (DPDK) implementation, sysfs interface > "/sys/devices/pci/.../resource0_wc" is used to map prefetchable PCI > resources as WC. > Platforms which support write-combining maps of PCI resources have > a

[PATCH 1/2] PCI: Export pcie_has_flr()

2018-07-23 Thread Alex Williamson
pcie_flr() suggests pcie_has_flr() to ensure that PCIe FLR support is present prior to calling. pcie_flr() is exported while pcie_has_flr() is not. Resolve this. Signed-off-by: Alex Williamson --- drivers/pci/pci.c |3 ++- include/linux/pci.h |1 + 2 files changed, 3 insertions

[PATCH 0/2] PCI: NVMe reset quirk

2018-07-23 Thread Alex Williamson
o get reliable behavior from them for device assignment and any other users of the PCI subsystem reset interface. Patches against current PCI next branch. Thanks, Alex --- Alex Williamson (2): PCI: Export pcie_has_flr() PCI: NVMe device specific reset quirk drivers/pci/pci.c|

[PATCH 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
PCIe FLR support, we can apply this quirk to all devices with matching class code. Signed-off-by: Alex Williamson --- drivers/pci/quirks.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index

Re: [PATCH 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
On Mon, 23 Jul 2018 16:45:08 -0600 Keith Busch wrote: > On Mon, Jul 23, 2018 at 04:24:31PM -0600, Alex Williamson wrote: > > Take advantage of NVMe devices using a standard interface to quiesce > > the controller prior to reset, including device specific delays before > >

Re: [PATCH 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
On Mon, 23 Jul 2018 17:45:33 -0500 Bjorn Helgaas wrote: > On Mon, Jul 23, 2018 at 04:24:31PM -0600, Alex Williamson wrote: > > Take advantage of NVMe devices using a standard interface to quiesce > > the controller prior to reset, including device specific delays before > >

[PATCH v2 1/2] PCI: Export pcie_has_flr()

2018-07-23 Thread Alex Williamson
pcie_flr() suggests pcie_has_flr() to ensure that PCIe FLR support is present prior to calling. pcie_flr() is exported while pcie_has_flr() is not. Resolve this. Signed-off-by: Alex Williamson --- drivers/pci/pci.c |3 ++- include/linux/pci.h |1 + 2 files changed, 3 insertions

[PATCH v2 0/2] PCI: NVMe reset quirk

2018-07-23 Thread Alex Williamson
reset quirk for all NVMe class devices so that we can try to get reliable behavior from them for device assignment and any other users of the PCI subsystem reset interface. Patches against current PCI next branch. Thanks, Alex --- Alex Williamson (2): PCI: Export pcie_has_flr() PCI:

[PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
PCIe FLR support, we can apply this quirk to all devices with matching class code. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1592654 Signed-off-by: Alex Williamson --- drivers/pci/quirks.c | 118 ++ 1 file changed, 118 insertions(+) diff

Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
On Mon, 23 Jul 2018 17:40:02 -0700 Sinan Kaya wrote: > On 7/23/2018 5:13 PM, Alex Williamson wrote: > > + * The NVMe specification requires that controllers support PCIe FLR, but > > + * but some Samsung SM961/PM961 controllers fail to recover after FLR (-1 > > + * con

Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
On Mon, 23 Jul 2018 19:20:41 -0700 Sinan Kaya wrote: > On 7/23/18, Alex Williamson wrote: > > On Mon, 23 Jul 2018 17:40:02 -0700 > > Sinan Kaya wrote: > > > >> On 7/23/2018 5:13 PM, Alex Williamson wrote: > >> > + * The NVMe specification

[PATCH v3 2/3] PCI: Samsung SM961/PM961 NVMe disable before FLR quirk

2018-07-24 Thread Alex Williamson
controller) prior to FLR. Signed-off-by: Alex Williamson --- drivers/pci/quirks.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index e72c8742aafa..3899cdd2514b 100644 --- a/drivers/pci/quirks.c

<    2   3   4   5   6   7   8   9   10   11   >