Hello.
> I'm getting the following with randconfig testing in kvm, config is
> .attached.
I acknowledge this is a bug of mine, and your .config shows your are
testing v3.11.
I posted the fix on Jul 16th 2013, and it is now in master as
v3.11-rc2-11-g783c2fb. However it is not an ancestor of v3.
Hello.
Thank you for the report.
I'm at a conference and I fear I won't be able to test myself in the
next days, but I think this is already fixed (it is part of
the "misc_register" call path, so it's the same problem).
The fix is commit v3.11-rc2-11-g783c2fb
783c2fb FMC: fix locking in sampl
>> --- a/drivers/fmc/fmc-chardev.c
>> +++ b/drivers/fmc/fmc-chardev.c
>> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc)
>> fc->misc.fops = &fc_fops;
>> fc->misc.name = kstrdup(dev_name(&fmc->dev), GFP_KERNEL);
>>
>> -spin_lock(&fc_lock);
>> ret = misc_register(
> This 444 should have been octal.
Right, my fault. We are not using the sysfs interface for module
parameters, so I didn't notice.
> Signed-off-by: Joe Perches
Acked-by: Alessandro Rubini
thanks
/alessandro, with two other minor fmc fixes to submit soon
--
To unsubscribe fro
The code reported wrong addresses in the sdb dumps. All sdb addresses
are relative, but the code was adding the base address twice. Bug
exposed by a gateware image with two bridge levels.
Thanks David for reporting the problem.
Signed-off-by: Alessandro Rubini
Reported-by: Juan David Gonzalez
ommit fixes one such checks and removes the other, so to
actually accept slots with no mezzanines. That's because the carrier
may offer some support anyways (the SPEC does), and working on the
carrier with no mezzanine-specific driver is common during
development.
Signed-off-by: Alessan
Acked-by: Alessandro Rubini
Hello.
drivers/fmc is going to be removed from the official kernel (removal
is queued by Linus Walleij, with approval by fmc authors).
So this patch should be dropped.
thanks
/alessandro
Hello.
Thank you Pat for taking care of these patches.
> Federico Vaga (5):
> drivers/fmc: remove unused variable
> drivers/fmc: hide fmc operations behind helpers
> drivers/fmc: The only way to dump the SDB is from debugfs
> drivers/fmc: change registration prototype
> drivers/fmc: car
> This is not how the "From:" line works, please read SubmittingPatches
> for the correct usage...
I'm submitting V3 with the correct From line, and my acked-by, since
now I managed to actually test them. It will happen later today.
Thanks greg for considering the patches.
/alessandro
From: Federico Vaga
Signed-off-by: Federico Vaga
Tested-by: Pat Riehecky
Acked-by: Alessandro Rubini
---
V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
V2 (Pat): added Tested-by and incorrect From line
V1 (Pat): picked from ohwr.org repo, where most fmc users
From: Federico Vaga
The initial FPGA may require programming before it is useful.
Signed-off-by: Federico Vaga
Tested-by: Pat Riehecky
Acked-by: Alessandro Rubini
---
V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
V2 (Pat): added Tested-by and incorrect From
From: Federico Vaga
This gave us more freedom to change/add/remove operations without
recompiling all device driver.
Typically, Carrier board implement the fmc operations, so they will not
use these helpers.
Signed-off-by: Federico Vaga
Tested-by: Pat Riehecky
Acked-by: Alessandro Rubini
From: Federico Vaga
Driver should not call fmc_sdb_dump() anymore. (actually they can but the
operation is not supported, so it will print an error message)
Signed-off-by: Federico Vaga
Tested-by: Pat Riehecky
Acked-by: Alessandro Rubini
---
V3 (Alessandro): fixed From line in patch, added
From: Federico Vaga
Permit use of either fmc_device_register_n or fmc_device_register_n_gw
depending on the type of device in use.
Signed-off-by: Federico Vaga
Tested-by: Pat Riehecky
Acked-by: Alessandro Rubini
---
V3 (Alessandro): fixed From line in patch, added alessandro's acked-b
GA on registration
Upstream git repo:
http://www.ohwr.org/projects/fmc-bus/repository/show?rev=fmc-bus-v2017-06
FMC maintainer: Alessandro Rubini
Initial approver of FMC: Greg KH
Federico Vaga (5):
drivers/fmc: remove unused variable
drivers/fmc: hide fmc operations behind helpers
drivers/fmc: The
> Again, I do not like to take patches without any changelog text at all
> :(
Sorry, I added this after the "---" line. I thought it was this one the
missing item:
V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
V2 (Pat): added Tested-by and incorrect From line
V1 (Pat
> Ah, sorry, wrong "changelog". I meant the area that shows up in git
> about what this patch does. There's no description of it other than the
> Subject line.
Yes. Ok, I'll add a longer commit message for V4 of the whole
set. Tomorrow (/me leaving now to a client).
> So move the include to the one and only driver to use these macros and
> ensure we keep setting the proper example in include/linux headers.
>
> Cc: Alessandro Rubini
> Signed-off-by: Paul Gortmaker
Thanks.
Acked-by: Alessandro Rubini
101 - 119 of 119 matches
Mail list logo
