Re: [PATCH 4/8] FMC: add documentation for the core

2013-02-23 Thread Alessandro Rubini
> Acked-by: Rob Landley Thanks. > What is this *note thingy:: syntax? It recurs a lot. Some sort of > reference into the PDF you started out with a link to, maybe? My documentation is texinfo and this is the ASCII output, manually split into different files. I fixed some of the internal refer

tip/x86/amba

2013-02-19 Thread Alessandro Rubini
Hello Peter and maintainers. I wonder what are the plans for the branch x86/amba, part of the tip repository. Of the 7 patches in that branch, 2 are already upstream and the other 5 rebase perfectly (only conflicts are in the header stanzas). This is the reverse log from next to my current workin

Re: tip/x86/amba

2013-02-20 Thread Alessandro Rubini
>> I wonder what are the plans for the branch x86/amba, part of the tip >> repository. Of the 7 patches in that branch, 2 are already upstream >> and the other 5 rebase perfectly (only conflicts are in the header >> stanzas). This is the reverse log from next to my current working tree: >> >> 0

[PATCH V5 1/5] DMA: PL330: use prefix in reg names to build under x86

2013-02-20 Thread Alessandro Rubini
be built by randomconfig after ARM_AMBA appears within x86. No other technical changes have been performed. The patch was build-tested only. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Signed-off-by: Davide Ciminaghi Acked-by: Jassi Brar Signed-off-by: H. Peter Anvin --- @Jassi: I

[PATCH V5 0/5] x86: a bridge from PCI to AMBA

2013-02-20 Thread Alessandro Rubini
ived on the mailing list are not in the patch set because they are missing from tip::x86/amba which is authoritative. Alessandro Rubini (5): DMA: PL330: use prefix in reg names to build under x86 watchdog: sp805_wdt depends on ARM mmc: Use the new drivers/amba: add support for a PC

[PATCH V5 3/5] mmc: Use the new

2013-02-20 Thread Alessandro Rubini
For portability, use . Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Acked-by: David Brown Signed-off-by: H. Peter Anvin --- @David: I repost this after rebasing, on hpa's suggestion. drivers/mmc/host/mmci.c |2 +- drivers/mmc/host/msm_sdcc.c |2 +- driver

[PATCH V5 2/5] watchdog: sp805_wdt depends on ARM

2013-02-20 Thread Alessandro Rubini
The SP805 driver is only used by the Spear machines, and uses writel_relaxed, which is not available on all architectures. The dependency from CONFIG_ARM avoids compilation problems under randomconfig when CONFIG_ARM_AMBA is enabled for x86 builds. Signed-off-by: Alessandro Rubini Acked-by

[PATCH V5 5/5] x86: add CONFIG_ARM_AMBA, selected by STA2X11

2013-02-20 Thread Alessandro Rubini
The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number of amba drivers and needs to activate core bus support. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Signed-off-by: H. Peter Anvin --- arch/x86/Kconfig |4 1 files changed, 4 insertions(+), 0

[PATCH V5 4/5] drivers/amba: add support for a PCI bridge

2013-02-20 Thread Alessandro Rubini
This is a PCI driver that registers AMBA devices for the range of supported devices. It is currently used by STA2X11, which exports AMBA peripherals under PCIe. The original AMBA drivers work with no changes or minimal ones. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Cc

[PATCH V6 0/5] x86: a bridge from PCI to AMBA

2013-02-20 Thread Alessandro Rubini
lkml message, which I removed as it is not current by the time this message exists. Alessandro Rubini (5): DMA: PL330: use prefix in reg names to build under x86 watchdog: sp805_wdt depends on ARM mmc: Use the new drivers/amba: add support for a PCI bridge x86: add CONFIG_ARM_AMBA, sel

[PATCH V6 2/5] watchdog: sp805_wdt depends on ARM

2013-02-20 Thread Alessandro Rubini
The SP805 driver is only used by the Spear machines, and uses writel_relaxed, which is not available on all architectures. The dependency from CONFIG_ARM avoids compilation problems under randomconfig when CONFIG_ARM_AMBA is enabled for x86 builds. Signed-off-by: Alessandro Rubini Acked-by

[PATCH V6 3/5] mmc: Use the new

2013-02-20 Thread Alessandro Rubini
For portability, use . Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Acked-by: David Brown Acked-by: Linus Walleij Acked-by: Viresh Kumar Signed-off-by: H. Peter Anvin --- @David, Viresh, Linus: I repost this after rebasing, on hpa's suggestion. Viresh' ack: http:

[PATCH V6 1/5] DMA: PL330: use prefix in reg names to build under x86

2013-02-20 Thread Alessandro Rubini
be built by randomconfig after ARM_AMBA appears within x86. No other technical changes have been performed. The patch was build-tested only. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Signed-off-by: Davide Ciminaghi Acked-by: Jassi Brar Acked-by: Linus Walleij Acked-by: Vinod Koul

[PATCH V6 4/5] drivers/amba: add support for a PCI bridge

2013-02-20 Thread Alessandro Rubini
This is a PCI driver that registers AMBA devices for the range of supported devices. It is currently used by STA2X11, which exports AMBA peripherals under PCIe. The original AMBA drivers work with no changes or minimal ones. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Cc

[PATCH V6 5/5] x86: add CONFIG_ARM_AMBA, selected by STA2X11

2013-02-20 Thread Alessandro Rubini
The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number of amba drivers and needs to activate core bus support. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Signed-off-by: H. Peter Anvin --- arch/x86/Kconfig |4 1 files changed, 4 insertions(+), 0

Re: [PATCH V5 4/5] drivers/amba: add support for a PCI bridge

2013-02-20 Thread Alessandro Rubini
[meanwhile I posted V6 with the acked-by of linusw and others, that were missing in V5] rmk: >> I'm happy to take it through my tree if everyone is now happy with this. hpa: > I am okay with that, although I would like to make sure we do a bunch of > x86 randconfigs on it before pushing it to Li

[PATCH RFC 0/8] drivers/fmc: bus support for ANSI-VITA 57.1

2013-02-21 Thread Alessandro Rubini
onfig-space.git' and what is used in this project lives in the sdbfs subdirectory in there. Alessandro Rubini (8): FMC: create drivers/fmc and toplevel Kconfig question FMC: add needed headers FMC: add core bus driver FMC: add documentation for the core FMC: add a software carrier

[PATCH 1/8] FMC: create drivers/fmc and toplevel Kconfig question

2013-02-21 Thread Alessandro Rubini
This commit creates the drivers/fmc directory and puts the necessary hooks for kbuild and kconfig. The code is currently a placeholder that only registers an empty bus. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias

[PATCH 2/8] FMC: add needed headers

2013-02-21 Thread Alessandro Rubini
This set of headers comes from commit 55812ecd (current master of the project on ohwr.org). They define the basic data structures for FMC and its SDB support. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez

[PATCH 4/8] FMC: add documentation for the core

2013-02-21 Thread Alessandro Rubini
This is selected sections of the current manual for fmc-bus, as developed outside of the kernel before submission. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/00-INDEX|2

[PATCH 5/8] FMC: add a software carrier driver

2013-02-21 Thread Alessandro Rubini
: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX|3 + Documentation/fmc/fmc-fakedev.txt | 30 drivers/fmc/Kconfig | 11 ++ drivers/fmc/Makefile

[PATCH 6/8] FMC: add a software mezzanine driver

2013-02-21 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00

[PATCH 8/8] FMC: add a char-device mezzanine driver

2013-02-21 Thread Alessandro Rubini
This driver exports the memory area associated with the mezzanine card as a misc device, so users can access registers. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX

[PATCH 7/8] FMC: add a driver to write mezzanine EEPROM

2013-02-21 Thread Alessandro Rubini
This driver allows to reprogram the EEPROM in a mezzanine, to store its own identifiers during manufacturing or to save other useful data. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc

[PATCH 3/8] FMC: add core bus driver

2013-02-21 Thread Alessandro Rubini
FPGA, and dumping it for diagnostics. SDB is not mandatory. Files in this commit correspond to commit 55812ecd in the master branch of the project hosted on ohwr.org. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias

[PATCH] x86: fix warning for sta2x11

2013-02-22 Thread Alessandro Rubini
() without passing "attrs", like others do. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi --- NOTE: The real solution, in my opinion, would be adding "attrs" as argument to the exported swiotlb_free_coherent() and remove this new empty function for sta2x11

[PATCH] mfd: trivially fix build warning in sta2x11-mfd

2013-02-22 Thread Alessandro Rubini
This driver cannot be a module, so "remove" is never called. The mishap is mine, and back then there was no warning due to __devexit(). Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi --- drivers/mfd/sta2x11-mfd.c | 11 --- 1 files changed, 0 insertions(+), 11

Re: [PATCH] debugfs: more tightly restrict default mount mode

2012-08-28 Thread Alessandro Rubini
> Since the debugfs is mostly only used by root, make the default mount > mode 0700. Most system owners do not need a more permissive value, > but they can choose to weaken the restrictions via their fstab. But if the default is strict, file-completion won't work and most people will run a full ro

Re: [PATCH 3/3] i2c: nomadik: Add Device Tree support to the Nomadik I2C driver

2012-09-04 Thread Alessandro Rubini
> Alessandro Rubini is actively working on bridging this (and > other amba_device primecells) to PCI, that is the reason why it > was recently converted to an amba_device. Yes, I've been inactive for a while but I'm on it right now. > How is he then supposed to get the prop

Re: [PATCH 12/16] ARM: nomadik: move platform_data definitions

2012-09-11 Thread Alessandro Rubini
> Platform data for device drivers should be defined in > include/linux/platform_data/*.h, not in the architecture > and platform specific directories. > > This moves such data out of the nomadik include directories Acked-by: Alessandro Rubini -- To unsubscribe from this list

Re: [PATCH v2 00/10] sta2x11-mfd patches

2012-10-24 Thread Alessandro Rubini
> this is v2 of a patchset already submitted on 2012/09/12 Thanks Davide. For the whole series: Acked-by: Alessandro Rubini /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32()

2012-10-27 Thread Alessandro Rubini
>> This function is only used (twice) by the author of it, and the >> 'prefix' feature is never used. I introduced it to shrink some internal code that had a lot of repetition in the debugfs files implementation. In that context I use the prefix string. Some of the code had later been submitted,

amba pl011: where to submit a fix for x86 builds

2013-06-07 Thread Alessandro Rubini
Hello. This is cc'd to $(get_maintainer.pl -f drivers/tty/serial/amba-pl011.c) and x86 maintainers too. While working on the pci-to-amba bridge driver (to be resubmitted in the next days) I have to deal with the problem of pl011 not building, after phys_to_page was introduced, by Chanho Min (Cc: h

Re: [PATCH 1/8] FMC: create drivers/fmc and toplevel Kconfig question

2013-06-17 Thread Alessandro Rubini
> Nice job :) thanks! > Want me to take this through my char/misc git tree to get to Linus for > 3.11? Would be great. As for the license issue, shall I send the two patches alone or the whole set? thanks /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 2/8] FMC: add needed headers

2013-06-17 Thread Alessandro Rubini
> Any way you can use MODULE_DEVICE_TABLE() for these devices to get > proper module auto-loading for your drivers? It's the next step. We are not doing that in our installations because it is not a trivial addition to running kernels -- we are plugging FMC devices in already-deployed kernel vers

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-17 Thread Alessandro Rubini
>> + * Released according to the GNU GPL, version 2 or any later version. > > I have to ask, do you really mean "or any later version"? Yes, it was intended. I don't think it's an issue for merging, but I understand you've seen so many such undesired copy-paste errors. >> +EXPORT_SYMBOL(fmc_driv

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-18 Thread Alessandro Rubini
> Alessandro, care to respin the patches that I didn't apply and resend > them so that I can? Yes, ASAP. But, according to the later message by David, I'll respin with the BSD license for demo code and EXPORT_SYMBOL (no GPL-only clause): https://lkml.org/lkml/2013/6/18/119 "As mentioned, CER

[PATCH V2 0/2] FMC: resend sample drivers

2013-06-18 Thread Alessandro Rubini
g the distribution policies. I rebased to next-20130617 and rebuilt, with no conflicts. In any of the patches of the original series. [1] https://lkml.org/lkml/2013/6/17/772: "Just redo those two patches and send them as 'v2'") Alessandro Rubini (2): FMC: add a software ca

[PATCH V2 1/2] FMC: add a software carrier driver

2013-06-18 Thread Alessandro Rubini
are bigger things and are not part of this submission. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX|3 + Documentation/fmc/fmc-fakedev.txt | 36 drivers/fmc

[PATCH V2 2/2] FMC: add a software mezzanine driver

2013-06-18 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00

Re: [PATCH V2 0/2] FMC: resend sample drivers

2013-06-18 Thread Alessandro Rubini
> Did I only not apply 2 patches? I thought there should be some more > that I'm missing here. Can you resend _everything_ that I need to apply > that I haven't already? Ok. I wondered which magic tools of yours would use "v2" to rebuild the series in the same order. Sneding the whole 6-lot in a

[PATCH V3 0/6] FMC: resending unapplied patches

2013-06-18 Thread Alessandro Rubini
Six patches from the series I initially sent on Jun 12. Changes in V3: all 6 yet unapplied by greg are resent, in correct order. Changes in V2: turned a generic "public domain" note for code to be reused into a proper BSD-like license, but I only resent affected patches, in error.

[PATCH V3 1/6] FMC: add core bus driver

2013-06-18 Thread Alessandro Rubini
FPGA, and dumping it for diagnostics. SDB is not mandatory. Files in this commit correspond to commit ab23167f in the master branch of the project hosted on ohwr.org. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias

[PATCH V3 3/6] FMC: add a software carrier driver

2013-06-18 Thread Alessandro Rubini
are bigger things and are not part of this submission. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX|3 + Documentation/fmc/fmc-fakedev.txt | 36 drivers/fmc

[PATCH V3 5/6] FMC: add a driver to write mezzanine EEPROM

2013-06-18 Thread Alessandro Rubini
This driver allows to reprogram the EEPROM in a mezzanine, to store its own identifiers during manufacturing or to save other useful data. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc

[PATCH V3 2/6] FMC: add documentation for the core

2013-06-18 Thread Alessandro Rubini
This is selected sections of the current manual for fmc-bus, as developed outside of the kernel before submission. Like the other patches in this set, it corresponds to commit ab23167f of the repository at ohwr.org Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by

[PATCH V3 4/6] FMC: add a software mezzanine driver

2013-06-18 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00

[PATCH V3 6/6] FMC: add a char-device mezzanine driver

2013-06-18 Thread Alessandro Rubini
This driver exports the memory area associated with the mezzanine card as a misc device, so users can access registers. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX

Re: [PATCH 2/8] FMC: add needed headers

2013-06-19 Thread Alessandro Rubini
> The use of the 'readl' and 'writel' identifiers here causes build errors on > architectures where those are macros. This renames the fields to > read32/write32 > to avoid the problem. Thanks. I'll apply the same to my repo and related drivers. Acked-by:

Re: [patch] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
> If we don't allocate "arr" then the cleanup path will dereference it and > oops. You are right, thanks (acked). How is the procedure here? I don't have my own git tree on kernel.org for pull requests. Can this go through the janitors? (if it makes sense, I can try the procedure to have a tree,

Re: [patch -next] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
>> +arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL); >> +arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL); > n comes from the hardware no? Yes. Length of hardware description array. > Maybe make these kcalloc too. I'm not a fan of kcalloc. I think it removes

Re: [patch] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
> Apparently these are going through Greg K-H. I'll resend, with Greg > CC'd so he can pick it up from the mailing list. > > Could you add an entry to the MAINTAINERS file so that Greg will be > CC'd automatically using get_maintainer.pl? Ok. Added to my todo list. > Is there a dedicated list

Re: [patch] FMC: fix error handling in probe() function

2013-06-20 Thread Alessandro Rubini
> The call to kzalloc() wasn't checked. > The dev_info() message dereferenced freed memory on error. > > Signed-off-by: Dan Carpenter Acked-by: Alessandro Rubini Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: FMC: BUG: scheduling while atomic on boot

2013-06-20 Thread Alessandro Rubini
Hello. > I compiled FMC in to test it out, but when booting with it I get: Thank you for your report. I'll take a look tomorrow. I admit I only use it as a module (I'm on it even now, working on an ADC FMC board). Thanks again, I'll have a fix ASAP /alessandro -- To unsubscribe from this list

[PATCH 2/8] FMC: add needed headers

2013-06-12 Thread Alessandro Rubini
This set of headers comes from commit ab23167f (current master of the project on ohwr.org). They define the basic data structures for FMC and its SDB support. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez

[PATCH 0/8] Support for FMC carriers and mezzanines

2013-06-12 Thread Alessandro Rubini
n make good use of it. SDB itself is developed in the fpga-config-space OHWR project. The link to the repository is `git://ohwr.org/hdl-core-lib/fpga-config-space.git' and what is used in this project lives in the sdbfs subdirectory in there. Alessandro Rubini (8): FMC: create drivers/fmc

[PATCH 1/8] FMC: create drivers/fmc and toplevel Kconfig question

2013-06-12 Thread Alessandro Rubini
This commit creates the drivers/fmc directory and puts the necessary hooks for kbuild and kconfig. The code is currently a placeholder that only registers an empty bus. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias

[PATCH 5/8] FMC: add a software carrier driver

2013-06-12 Thread Alessandro Rubini
are bigger things and are not part of this submission. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX|3 + Documentation/fmc/fmc-fakedev.txt | 36 drivers/fmc

[PATCH 4/8] FMC: add documentation for the core

2013-06-12 Thread Alessandro Rubini
This is selected sections of the current manual for fmc-bus, as developed outside of the kernel before submission. Like the other patches in this set, it corresponds to commit ab23167f of the repository at ohwr.org Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by

[PATCH 3/8] FMC: add core bus driver

2013-06-12 Thread Alessandro Rubini
FPGA, and dumping it for diagnostics. SDB is not mandatory. Files in this commit correspond to commit ab23167f in the master branch of the project hosted on ohwr.org. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias

[PATCH 6/8] FMC: add a software mezzanine driver

2013-06-12 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00

[PATCH 8/8] FMC: add a char-device mezzanine driver

2013-06-12 Thread Alessandro Rubini
This driver exports the memory area associated with the mezzanine card as a misc device, so users can access registers. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX

[PATCH 7/8] FMC: add a driver to write mezzanine EEPROM

2013-06-12 Thread Alessandro Rubini
This driver allows to reprogram the EEPROM in a mezzanine, to store its own identifiers during manufacturing or to save other useful data. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc

Re: [FMC] BUG: scheduling while atomic: swapper/1/0x10000002

2013-07-03 Thread Alessandro Rubini
Hello. > I got the below dmesg and the first bad commit is > > commit 4debfe409b6e550032bfef9733e9f6f7c5613617 > Author: Alessandro Rubini > Date: Tue Jun 18 23:48:07 2013 +0200 > > FMC: add a char-device mezzanine driver thank you for your report. I already got

[PATCH] FMC: fix locking in sample chardev driver

2013-07-16 Thread Alessandro Rubini
s own list. Reported-by: Sasha Levin Reported-by: Fengguang Wu Signed-off-by: Alessandro Rubini --- drivers/fmc/fmc-chardev.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/fmc/fmc-chardev.c b/drivers/fmc/fmc-chardev.c index cc031db..ace6ef2 100644 --- a/drive

[PATCH 01/26] x86: fix warning for sta2x11

2013-08-07 Thread Alessandro Rubini
() without passing "attrs". The real solution, in my opinion, would be adding "attrs" as argument to swiotlb_free_coherent() and remove this new empty function as well as the identical ones found in other 6 files within arch. Signed-off-by: Alessandro Rubini Acked-by: Gianca

[PATCH 03/26] mmc: Use the new

2013-08-07 Thread Alessandro Rubini
For portability, use . Signed-off-by: Alessandro Rubini Link: http://lkml.kernel.org/r/1355146956-6009-6-git-send-email-cimina...@gnudd.com Acked-by: Giancarlo Asnaghi Acked-by: David Brown Signed-off-by: H. Peter Anvin --- drivers/mmc/host/mmci.c |2 +- drivers/mmc/host/msm_sdcc.c

[PATCH 04/26] x86: add CONFIG_ARM_AMBA, selected by STA2X11

2013-08-07 Thread Alessandro Rubini
The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number of amba drivers and needs to activate core bus support. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi --- arch/x86/Kconfig |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/x86

[PATCH 05/26] drivers/amba: add support for a PCI bridge

2013-08-07 Thread Alessandro Rubini
This is a PCI driver that registers AMBA devices for the range of supported devices. It is currently used by STA2X11, which exports AMBA peripherals under PCIe. The original AMBA drivers work with no changes or minimal ones. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Cc

[PATCH 02/26] DMA: PL330: use prefix in reg names to build under x86

2013-08-07 Thread Alessandro Rubini
be built by randomconfig after ARM_AMBA appears within x86. No other technical changes have been performed. The patch was build-tested only. Signed-off-by: Alessandro Rubini Link: http://lkml.kernel.org/r/1355146956-6009-2-git-send-email-cimina...@gnudd.com Acked-by: Giancarlo Asnaghi [Davide Cimin

[PATCH 00/26] STA2X11 devicetree support for amba/pci

2013-08-07 Thread Alessandro Rubini
g all the autodetection of PCI, and is very difficult to pass over in the x86 world. On the other hand platform data is denied by x86 maintainers. So the question is: what is the right way (and the right dts structure) to deal with a hotplug bus that instantiates AMBA devices, without killing del

Re: [PATCH 26/26] pinctrl: add support for sta2x11 (via pinctrl-nomadik)

2013-08-07 Thread Alessandro Rubini
> Maybe you could add a commit message? Ack (Davide is holidays, I grant that for him). > Apart from that it looks like a straight-forward plug-in to the > Nomadik pin controller, so I'd happily apply it, but I guess it > will go in through the x86 tree? It's part of a bigger series, that adds d

Re: [PATCH 00/26] STA2X11 devicetree support for amba/pci

2013-08-07 Thread Alessandro Rubini
[stripped list of issues from my original message follows] >> Some of the problems he found are: >> >> * Passing a dtb to the kernel: we use a modified kexec at present >> * Passing correct irq numbers to the AMBA drivers >> * Switching to a new gpio driver with devicetree support >

Re: [fmc] BUG: scheduling while atomic: swapper/0/1/0x00000002

2013-08-12 Thread Alessandro Rubini
> On 08/11/2013 09:52 PM, Fengguang Wu wrote: >> FYI, the bug still exists in the upstream and linux-next kernels. Strange. Greg approved the patch I sent. I see it in next-20130809 but also next-20130801 and other ones with the same hash: 783c2fb FMC: fix locking in sample chardev driver How

Re: [PATCH] FMC: Staticize local symbols

2013-08-12 Thread Alessandro Rubini
> This local symbol is used only in this file. > Fix the following sparse warnings: Thanks! Acked-by: Alessandro Rubini /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v4 0/7] enable support for AMBA drivers under x86

2013-05-05 Thread Alessandro Rubini
> Did this got fixed in some tree in the meantime? Because I still see it on > current Linus + tip/master: > > arch/x86/pci/sta2x11-fixup.c:186:2: warning: initialization from incompatible > pointer type [enabled by default] > arch/x86/pci/sta2x11-fixup.c:186:2: warning: (near initialization for

Re: [PATCH v4 0/7] enable support for AMBA drivers under x86

2013-05-06 Thread Alessandro Rubini
Petkov > Cc: Alessandro Rubini , h...@zytor.com, > cimina...@gnudd.com, jaswinder.si...@linaro.org, will.dea...@arm.com, > li...@arm.linux.org.uk, t...@linutronix.de, mi...@redhat.com, > d...@fb.com, vinod.k...@intel.com, grant.lik...@secretlab.ca,

Re: [PATCH 02/14] MAINTAINERS: remove arch/arm/plat-nomadik/

2013-03-07 Thread Alessandro Rubini
> In fact, the ARM/Ux500 ARM ARCHITECTURE block has patterns for files > named "nomadik" too. The patterns in this pair of MAINTAINER blocks > really need a review from the respective maintainters. Thanks! Acked-by: Alessandro Rubini -- To unsubscribe from this list: send th

Re: [PATCH 13/24] ARM: nomadik: use __iomem pointers for MMIO

2012-09-15 Thread Alessandro Rubini
at happened to NAND_NO_READRDY lately. If this hunk is desired and not just something else that slipped in, then Acked-by: Alessandro Rubini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 0/8 RESEND] sta2x11-mfd patches

2012-09-16 Thread Alessandro Rubini
> Davide Ciminaghi (8): For the whole set: Acked-by: Alessandro Rubini (original committer of the mfd driver) /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 0/2] x86, pci: sta2x11-fixup clock related patches

2012-09-20 Thread Alessandro Rubini
> the following two patches are needed for the sta2x11 common clock > framework (to be submitted shortly) to deal with the possibility > of multiple instances of the connext chip on the same machine. Thanks you very much for your clock work, Davide. For both: Acked-by: Alessand

Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

2012-11-23 Thread Alessandro Rubini
My patch: >> This driver would not compile if ARM_AMBA is selected under x86, >> because "CS" and "DS" are already defined there. But AMBA >> is used in the x86 world by a PCI-to-AMBA bridge, to be submitted. >> >> The patch just adds the "PL330_" prefix to all register and bit fields, >> so it ca

Re: [PATCH v4 0/7] enable support for AMBA drivers under x86

2012-12-13 Thread Alessandro Rubini
Hello. > Build failure: > > o.i386-allconfig/make.log:make[4]: *** [drivers/gpio/gpio-pl061.o] Error 1 > o.i386-allconfig/make.log:make[3]: *** [drivers/gpio] Error 2 This happens because the pl061 is not in this checkout. I also got a message from the "kbuild test robot", which results from th

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Alessandro Rubini
> I think this would be less controversial if the run-time default were > to disable the feature. Yes, that's the common sensible path to new little-tested features. As you say, it may become enabled by default over time. Then, I think it would be good to have a specific sub-structure for this st

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Alessandro Rubini
Thank you Jonathan for replying, I apologize for the delay. >> I wonder if IIO config symbols should have IIO_ in their name, [...] > I have no particular problem with this for new drivers, but > obviously it is an interface change for older ones that may > cause some issues. Yes, that's right.

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Alessandro Rubini
>> I wonder if IIO config symbols should have IIO_ in their name, so >> people looking at config files knows what they actually are. >> Actually, all USB drivers have USB in their config name, which is >> useful even if e.g. "PL2303" cannot be but USB. >> >> On the other hand, AD7923 and all the o

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Alessandro Rubini
Thank you Lars for you constructive attitude. See you at fosdem /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at h

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-06 Thread Alessandro Rubini
> The problem is that on the sta2x11 architecture only the first > 512MB are available through the PCI bus, but the allocator can allocate > memory > for DMA above this limit. By using GFP_DMA flags the allocation take place > under the 16MB so it works. Still, you are not running the upstream

Re: [PATCH] IIO ADC support for AD7923

2013-01-08 Thread Alessandro Rubini
> +config AD7923 I wonder if IIO config symbols should have IIO_ in their name, so people looking at config files knows what they actually are. Actually, all USB drivers have USB in their config name, which is useful even if e.g. "PL2303" cannot be but USB. On the other hand, AD7923 and all the o

[patch] khttpd doesn't detach from the files of its parent

2000-10-18 Thread Alessandro Rubini
Hi all. While looking at kHTTPd (linux-2.4.0-test9) I found what looks like a bug to me. The daemon doesn't detach itself from the files structure of the parent process. Therefore, when it is run as a module, the files opened by "insmod" (or whatever loads it) remain open. Besides "aesthetica

Re: [patch] khttpd doesn't detach from the files of its parent

2000-10-18 Thread Alessandro Rubini
> shouldn't this be exit_files() ? Yes, definitely. Arjan already replied (privately) to say the same. Thanks /alessandro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] khttpd doesn't detach from the files of its parent

2000-10-18 Thread Alessandro Rubini
>> Yes, definitely. > > It should, unless you want to open any files in the thread itself. Yes. I realized that just before getting your message (after looking at kernel/exit.c). I should never say "definitely" :) /alessandro - To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [patch] khttpd doesn't detach from the files of its parent

2000-10-18 Thread Alessandro Rubini
> put_files_struct() is a destructor, so it won't help here. The following > patch may be of use [...] It's "create an empty > files_struct and replace the task->files with it" - thing we can't do via > clone() and may want to (khttpd does). Sorry, what's wrong with just closing the files? It's

Re: why CURRENT->sector is zero??

2005-03-17 Thread Alessandro Rubini
Hello. > I downloaded sbull.c (for LDD 2nd Edition) from Please note that sbull is a block device not hosting partitions. > of req->sector in sbull_transfer function). The observations are as follows: > File System req->sector > msdos 0 > vfat 0 > ext2 2 > ex

Re: [patch 0/3] PS3 Storage Drivers for 2.6.23, take 5

2007-07-18 Thread Alessandro Rubini
Hello. > I didn't hear anything from the misc device maintainer (for the FLASH ROM > Storage Driver). Actually, I am not acting as a maintainer. I'm not active enough nor up to date with all the structure of kernel maintainance. So please don't wait for me. Actually, I tried a pair of times to

Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code

2018-12-07 Thread Alessandro Rubini
> Subject: [PATCH] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Acked-by: Alessandro Rubini > Alessandro, Davide - you can find additional context regarding why we > are making these changes in the [00/22] e-mail that can be found here: > https://lore.kernel.org/lkm

Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true

2018-10-16 Thread Alessandro Rubini
Me: >> > OTOH I admit you can compare any value with -EINVAL, after PTR_ERR. >> > But in general you first detect the error condition and then split >> > among error (or print a message according to the exact value. Al Viro: >> >> if (IS_ERR(p) && PTR_ERR(p) == -ENOENT) >> instead of >>

Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true

2018-10-15 Thread Alessandro Rubini
Hello. > during a review I claimed that PTR_ERR should only be used if IS_ERR was > already checked. The rationale isn't obvious though and Thierry > suggested to keep the code as is and not introduce an IS_ERR check. The rationale is the same ch11 you linked to: "any other value is a valid point

[PATCH 2/2] FMC: show_sdb_tree: dump synthesis/commit ID info

2014-02-22 Thread Alessandro Rubini
'spec_top_fmc_adcmc-projects/fmc-adc-100m14b4cha.git' \ synthesized 20140116 by mcattin (ISE version 133), commit f0a539dffe6d Signed-off-by: Tomasz Wlostowski Acked-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas --- drivers/fmc/fmc-sdb.

[PATCH 1/2] FMC: make eeprom attribute writable

2014-02-22 Thread Alessandro Rubini
This allows easier modification to the eeprom than loading the fmc-write-eeprom module. The carrier driver will refuse writing if the FPGA is not running the golden gateware image, so writing in practice is only available at manufacture/development time. Signed-off-by: Alessandro Rubini Acked

  1   2   >