[git pull] device-mapper fixes for 3.9

2013-03-20 Thread Alasdair G Kergon
Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm tags/dm-3.9-fixes to get the following device-mapper fixes for 3.9. Thanks, Alasdair A set of device-mapper fixes for 3.9. Fix reported data loss with

[git pull] device-mapper fixes for 3.9-rc6

2013-04-05 Thread Alasdair G Kergon
Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm tags/dm-3.9-fixes-2 to get the following device-mapper fixes for 3.9. Thanks, Alasdair A pair of patches to fix the writethrough mode of the device-m

[git pull] Further device-mapper fixes for 3.8

2013-01-31 Thread Alasdair G Kergon
WRITE SAME support. Alasdair G Kergon (1): dm: fix write same requests counting Mike Snitzer (1): dm thin: fix queue limits stacking drivers/md/dm-thin.c | 13 + drivers/md/dm.c |6 -- 2 files

Re: [dm-devel] linux-next: Tree for Feb 28 (dm-cache)

2013-02-28 Thread Alasdair G Kergon
On Thu, Feb 28, 2013 at 10:51:48AM -0800, Randy Dunlap wrote: > Also, drivers/md/Kconfig contains "select DM_PRISON" but there is no > DM_PRISON defined anywhere that I can find... Thanks! Hopefully fixed now: It's DM_BIO_PRISON. Alasdair -- To unsubscribe from this list: send the line "unsubsc

Re: [dm-devel] [PATCH linux-next] DM RAID: validate_raid_redundancy: Silence uninitialized variable warning

2013-02-21 Thread Alasdair G Kergon
On Wed, Feb 20, 2013 at 01:31:18PM -0700, Tim Gardner wrote: > drivers/md/dm-raid.c: In function 'raid_ctr': > drivers/md/dm-raid.c:453:53: warning: 'rebuilds_per_group' may be used > uninitialized in this function [-Wuninitialized] > drivers/md/dm-raid.c:383:11: note: 'rebuilds_per_group' was dec

Re: linux-next: error importing the device-mapper quilt series

2013-03-14 Thread Alasdair G Kergon
On Fri, Mar 15, 2013 at 10:14:41AM +1100, Stephen Rothwell wrote: > The patch in question has no commit message or headers at all ... Now fixed. It escaped before I'd finished it... Alasdair -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [dm-devel] [PATCH v7 9/9] block: Avoid deadlocks with bio allocation by stacking drivers

2012-08-29 Thread Alasdair G Kergon
On Wed, Aug 29, 2012 at 08:57:59AM -0400, Vivek Goyal wrote: > I would say keep all the bio splitting patches and any fixes w.r.t > deadlocks in a seprate series. As this is little complicated and a lot > of is just theoritical corner cases. If you limit this series to just > bio_set related cleanu

Re: [dm-devel] [PATCH v7 9/9] block: Avoid deadlocks with bio allocation by stacking drivers

2012-08-29 Thread Alasdair G Kergon
On Wed, Aug 29, 2012 at 09:50:06AM -0700, Kent Overstreet wrote: > The other thing we could do is make the rescuer thread per block device > (which arguably makes more sense than per bio_set anyways), then > associate bio_sets with specific block devices/rescuers. For dm, it's equivalent - alread

Re: [dm-devel] [PATCH v7 9/9] block: Avoid deadlocks with bio allocation by stacking drivers

2012-08-29 Thread Alasdair G Kergon
On Wed, Aug 29, 2012 at 10:13:45AM -0700, Kent Overstreet wrote: > Only on allocation failure. Which as you already said assumes wrapping together the other mempools in the submission path first... Alasdair -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing

2012-09-14 Thread Alasdair G Kergon
On Thu, Sep 06, 2012 at 03:34:55PM -0700, Kent Overstreet wrote: > With the old code, when you allocate a bio from a bio pool you have to > implement your own destructor that knows how to find the bio pool the > bio was originally allocated from. > > This adds a new field to struct bio (bi_pool) a

Re: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing

2012-09-14 Thread Alasdair G Kergon
On Thu, Sep 06, 2012 at 03:34:55PM -0700, Kent Overstreet wrote: > With the old code, when you allocate a bio from a bio pool you have to > implement your own destructor that knows how to find the bio pool the > bio was originally allocated from. > This adds a new field to struct bio (bi_pool) and

Re: [dm-devel] [PATCH v10 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-09-14 Thread Alasdair G Kergon
On Fri, Sep 07, 2012 at 01:44:01PM -0700, Kent Overstreet wrote: > Previously, dm_rq_clone_bio_info needed to be freed by the bio's > destructor to avoid a memory leak in the blk_rq_prep_clone() error path. > This gets rid of a memory allocation and means we can kill > dm_rq_bio_destructor. > > Th

Re: [dm-devel] [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-09-14 Thread Alasdair G Kergon
On Thu, Sep 06, 2012 at 03:35:02PM -0700, Kent Overstreet wrote: > Previously, there was bio_clone() but it only allocated from the fs bio > set; as a result various users were open coding it and using > __bio_clone(). Explain in the header the reasoning behind the change to dm-crypt so that it n

Re: > You may find that you need to update your lvm userspace tools.

2008-02-05 Thread Alasdair G Kergon
On Mon, Feb 04, 2008 at 09:53:04PM -0800, Andrew Morton wrote: > Could someone in dm-devel land please get involved? Vague reports like this are sadly a regular occurrence, and they usually happen when people don't update their initrd after updating their kernel. As well as the obvious problems f

Re: [PATCH] Implement barrier support for single device DM devices

2008-02-15 Thread Alasdair G Kergon
On Fri, Feb 15, 2008 at 01:08:21PM +0100, Andi Kleen wrote: > Implement barrier support for single device DM devices Thanks. We've got some (more-invasive) dm patches in the works that attempt to use flushing to emulate barriers where we can't just pass them down like that. Alasdair -- [EMAIL

Re: [dm-devel] Re: [PATCH] Implement barrier support for single device DM devices

2008-02-15 Thread Alasdair G Kergon
On Fri, Feb 15, 2008 at 03:20:10PM +0100, Andi Kleen wrote: > On Fri, Feb 15, 2008 at 04:07:54PM +0300, Michael Tokarev wrote: > > I wonder if it's worth the effort to try to implement this. My personal view (which seems to be in the minority) is that it's a waste of our development time *except*

[git pull] device-mapper updates for 3.6

2012-07-30 Thread Alasdair G Kergon
allocation failures; - Numerous small changes and cleanups to the code. Alasdair G Kergon (5): dm thin: reduce endio_hook pool size dm snapshot: remove redundant assignment in merge fn dm crypt: store crypt_config

Re: [dm-devel] [RFC] dm-lc: plan to go to staging

2013-08-28 Thread Alasdair G Kergon
On Wed, Aug 28, 2013 at 07:05:55PM -0700, Greg KH wrote: > For staging drivers, I need a TODO file that lists > what needs to be done to the code to get it into a mergable state for > the "real" part of the kernel, Two simple requirements before putting your proof-of-concept into staging if you wa

Re: [dm-devel] [PATCH] MAINTAINERS: dm-de...@redhat.com is a list

2013-07-08 Thread Alasdair G Kergon
On Tue, Jul 02, 2013 at 05:01:47PM +0200, Yann Droneaud wrote: > This patch changes type of dm-de...@redhat.com > The output of ./scripts/get_maintainer.pl is > modified to report dm-de...@redhat.com as a list: > DEVICE-MAPPER (LVM) > M: Alasdair Kergon > -M: dm-de...@redhat.com > L: d

Re: [dm-devel] [PATCH] MAINTAINERS: dm-de...@redhat.com is a list

2013-07-08 Thread Alasdair G Kergon
On Mon, Jul 08, 2013 at 10:21:43AM -0700, Joe Perches wrote: > I think this Q entry isn't as useful as it could be > because it doesn't show the status of any patch. When kernel.org patchwork was unavailable for many months we migrated over to a private instance - and we still haven't moved back!

[git pull] device-mapper changes for 3.11

2013-07-10 Thread Alasdair G Kergon
as a device-mapper maintainer. A few more clean-ups and fixes. Alasdair G Kergon (2): dm flakey: correct ctr alloc failure mesg dm: update maintainers Hannes Reinecke (1): dm mpath: fix ioctl deadlock when no

Re: linux-next: rebase of the device-mapper quilt series

2013-07-10 Thread Alasdair G Kergon
On Thu, Jul 11, 2013 at 10:31:16AM +1000, Stephen Rothwell wrote: > Why have you just rebased the device-mapper series I was confirming there weren't any unexpected conflicts or other issues to deal with from a point after the block tree went in before generating the pull request. Alasdair -- To

Re: linux-next: rebase of the device-mapper quilt series

2013-07-10 Thread Alasdair G Kergon
On Thu, Jul 11, 2013 at 10:31:16AM +1000, Stephen Rothwell wrote: > You have > just invalidated your testing On the contrary, it is part of my testing. > Your whole series was already > based after v3.10 (i.e. released or rebased after the merge window > opened), so why move it again? I usuall

Re: [dm-devel] [git pull] device-mapper changes for 3.11

2013-07-11 Thread Alasdair G Kergon
On Thu, Jul 11, 2013 at 04:20:40PM +1000, Stephen Rothwell wrote: > Alistair, is there some reason that you cannot maintain some relatively > stable git tree for me to fetch (instead of the quilt series). Well Mike Snitzer is becoming a joint maintainer and this also requires changes to the work

Re: [dm-devel] [RFC] dm-lc: plan to go to staging

2013-08-30 Thread Alasdair G Kergon
On Fri, Aug 30, 2013 at 09:33:29PM +0900, Akira Hayakawa wrote: > I have three candidates on my mind. > I am thinking of removing the dm- prefix as bcache and enhanceio do. Yes, that's fine for the general way of referring to this. (Within the codebase, the filename and module name would still ne

Re: [dm-devel] [PATCH v10 4/8] block: Add bio_reset()

2012-09-07 Thread Alasdair G Kergon
As I indicated already in this discussion, dm started to use merge_bvec_fn as a cheap way of avoiding splitting and this improved overall efficiency. Often it's better to pay the small price of calling that function to ensure the bio is created the right size in the first place so it won't have to

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote: > On Mon, Sep 10, 2012 at 02:56:33PM -0700, Kent Overstreet wrote: > > commit df7e63cbffa3065fcc4ba2b9a93418d7c7312243 > > Author: Kent Overstreet > > Date: Mon Sep 10 14:33:46 2012 -0700 > > > > block: Avoid deadlocks with bio allo

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: > IIUC, Kent posted a patch which converts all of them to use front-pad The only patch I saw posted here only handles one of the easier cases so far. The others are a bit trickier and probably involve a decision about which way to change

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 04:35:02PM -0700, Tejun Heo wrote: > debug. Would it be difficult to convert dm drivers to collect size > requirements and use front-pad for all per-bio data? I can't give a quick answer because a single bio may require a variable number (depending on the bio content) of

[git pull] 3.8 device-mapper updates

2012-12-21 Thread Alasdair G Kergon
ing if discards are misused. - Prevent userspace from interfering with the ioctl parameters and use kmalloc for the data buffer if it's small instead of vmalloc. - Throttle some annoying error messages when I/O fails. -------- Alasdair G

Re: [dm-devel] [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors.

2013-06-20 Thread Alasdair G Kergon
On Thu, Jun 20, 2013 at 02:21:00PM -0700, Geremy Condra wrote: > With this change and config option, dm-verity errors > will cause uevents to be sent to userspace, notifying > it that an error has occurred and potentially > triggering recovery actions. > +config DM_VERITY_ERROR_NOTIFY > + tri

Re: [dm-devel] [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors.

2013-06-20 Thread Alasdair G Kergon
On Thu, Jun 20, 2013 at 06:12:07PM -0700, Geremy Condra wrote: > Assuming nobody currently using DM_UEVENT minds it doesn't cause any > problems for me. Any current users object? DM_UEVENT toggles uevents on or off across the whole of device-mapper. If there is no particular need for verity *not

Re: [dm-devel] [PATCH] dm: dm-cache fails to write the cache device in writethrough mode

2013-03-22 Thread Alasdair G Kergon
On Fri, Mar 22, 2013 at 01:11:51PM -0700, Darrick J. Wong wrote: > The new writethrough strategy for dm-cache issues a bio to the origin device, > remaps the bio to the cache device, and issues the bio to the cache device. > However, the block layer modifies bi_sector and bi_size, so we need to >

Re: [dm-devel] dm: dm-cache fails to write the cache device in writethrough mode

2013-03-22 Thread Alasdair G Kergon
On Fri, Mar 22, 2013 at 11:27:16PM -0400, Mike Snitzer wrote: > So the big difference is the thinp-test-suite uses intermediate linear > DM layers above the slower sd device (spindle/data) -- whereas in your > setup the origin device is direct to sd (8:0). I would think the difference is because

Re: [dm-devel] dm: dm-cache fails to write the cache device in writethrough mode

2013-03-23 Thread Alasdair G Kergon
On Fri, Mar 22, 2013 at 10:15:49PM -0700, Darrick J. Wong wrote: > Interesting ... if I set up this: > # echo "0 67108864 linear /dev/sda 0" | dmsetup create origin > And then repeat the test, but using /dev/mapper/origin as the origin instead > of /dev/sda, the problem goes away. So that looks l

Re: [dm-devel] dm-crypt performance

2013-03-26 Thread Alasdair G Kergon
[Adding dm-crypt + linux-kernel] On Mon, Mar 25, 2013 at 11:47:22PM -0400, Mikulas Patocka wrote: > I performed some dm-crypt performance tests as Mike suggested. > > It turns out that unbound workqueue performance has improved somewhere > between kernel 3.2 (when I made the dm-crypt patches) an

Re: [PATCH] dm cache: Avoid conflicting remove_mapping() in mq policy

2013-08-16 Thread Alasdair G Kergon
On Fri, Aug 16, 2013 at 01:31:18AM -0700, Guenter Roeck wrote: > Is this patch going anyhere ? The problem breaks the sparc32:allmodconfig > build, > so it would be useful to get it fixed. We're pulling together a batch of patches today, including this one. Alasdair -- To unsubscribe from this

Re: [dm-devel] [PATCH] dm: Make MIN_IOS, et al, tunable via sysctl.

2013-08-17 Thread Alasdair G Kergon
On Fri, Aug 16, 2013 at 03:55:21PM -0700, Frank Mayhar wrote: > This patch fixes that by changing the hardcoded MIN_IOS (and certain > other) #defines in dm-crypt, dm-io, dm-mpath, dm-snap and dm itself to > sysctl-modifiable values. This lets us change the size of these pools > on the fly, we can

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-08-12 Thread Alasdair G Kergon
On Mon, Aug 12, 2013 at 04:52:34AM -0700, Christoph Hellwig wrote: > lvm is mostly about the Linux specific formats. If you want to create > a separate userspace consumer for device mapper that's probably also > fine, but if you need support for complex layours device mapper is the > way to go, an

[git pull] device-mapper updates for 3.9

2013-03-01 Thread Alasdair G Kergon
gets streamlined, more mempool reliance is reduced and there are a few other bug fixes and tidy-ups. Alasdair G Kergon (6): dm: remove CONFIG_EXPERIMENTAL dm: clean up clone_bio dm: rename request variables to bios

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Alasdair G Kergon
On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: > @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, > struct dm_verity_io *io) > hash_block_end = v->hash_blocks - 1; > } > no_prefetch_cluster: > - dm_bufio

[git pull] device-mapper updates for 3.10

2013-05-10 Thread Alasdair G Kergon
thin provisioning target to be extended easily; allow WRITE SAME on multipath devices; an assortment of little fixes and clean-ups. Alasdair G Kergon (3): dm: document iterate_devices dm cache policy: fix description of

Re: [dm-devel] [git pull] device-mapper updates for 3.10

2013-05-10 Thread Alasdair G Kergon
On Fri, May 10, 2013 at 11:20:29AM +0100, Alasdair G Kergon wrote: > Please pull from: > git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm > tags/dm-3.10-changes And the kbuild test robot just spotted that I lost a line from one of the patches which meant the thin

[git pull] device-mapper fix for 3.10

2013-05-19 Thread Alasdair G Kergon
devices. Alasdair G Kergon (1): dm thin: fix metadata dev resize detection drivers/md/dm-thin.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [dm-devel] [PATCH 2] dm: Use bioset's front_pad for dm_target_io

2012-09-14 Thread Alasdair G Kergon
On Wed, Sep 12, 2012 at 06:31:53PM -0400, Mikulas Patocka wrote: > This is the patch based on this tree. I've pulled this into the dm tree for now. Alasdair -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [dm-devel] [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-09-18 Thread Alasdair G Kergon
On Mon, Sep 17, 2012 at 01:42:27PM -0700, Kent Overstreet wrote: > Previously, it was open coding __bio_clone(), that's what the setting > bi_idx to 0 was from. With the change to bio_clone_bioset() that's no > longer necessary (and dangerous, since bi_idx needs to be consistent > with bi_sector/bi

Re: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing

2012-09-18 Thread Alasdair G Kergon
On Mon, Sep 17, 2012 at 01:51:39PM -0700, Kent Overstreet wrote: > That isn't a very good patch - it says it's clearing bi_end_io as a > precaution, but as a precaution to what? As a precaution against the endio function being called an extra time by mistake if a stray reference remains after the

Re: [dm-devel] [PATCH v2 2/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Alasdair G Kergon
On Thu, Aug 09, 2012 at 12:40:23AM +, Wesley Miaw wrote: > This isn't as polished because I pretty much just added support to do what I > needed. I'm not sure if the LKML is the right place to post, so let me know if > I should send this somewhere else. cryptsetup patches are best sent to the

Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Alasdair G Kergon
On Thu, Aug 09, 2012 at 12:40:22AM +, Wesley Miaw wrote: > Apologies if the version increment is incorrect; I was not sure if the minor > or patch number should be incremented. I assume the different version number > is > what would be used to detect if the data offset option is supported. Tha

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-18 Thread Alasdair G Kergon
On Sat, Feb 16, 2008 at 11:37:37PM +0100, Jiri Slaby wrote: > # CONFIG_SYSFS_DEPRECATED is not set IMHO That should be *set* by default until everyone has had time to update their userspace software to cope with the changed sysfs layout. Alasdair -- [EMAIL PROTECTED] -- To unsubscribe from this

Re: [PATCH] Implement barrier support for single device DM devices

2008-02-18 Thread Alasdair G Kergon
On Fri, Feb 15, 2008 at 04:07:54PM +0300, Michael Tokarev wrote: > Alasdair G Kergon wrote: > > On Fri, Feb 15, 2008 at 01:08:21PM +0100, Andi Kleen wrote: > >> Implement barrier support for single device DM devices > > Thanks. We've got some (more-invasive)

Re: [dm-devel] Re: [PATCH] Implement barrier support for single device DM devices

2008-02-18 Thread Alasdair G Kergon
On Mon, Feb 18, 2008 at 08:52:10AM -0500, Ric Wheeler wrote: > I understand that. Most of the time, dm or md devices are composed of > uniform components which will uniformly support (or not) the cache flush > commands used by barriers. As a dm developer, it's "almost none of the time" because

Re: [dm-devel] Re: [PATCH] Implement barrier support for single device DM devices

2008-02-18 Thread Alasdair G Kergon
On Tue, Feb 19, 2008 at 09:16:44AM +1100, David Chinner wrote: > Surely any hardware that doesn't support barrier > operations can emulate them with cache flushes when they receive a > barrier I/O from the filesystem My complaint about having to support them within dm when more than one devic

[git pull] device-mapper update for 2.6.25

2008-02-07 Thread Alasdair G Kergon
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git to get the following device-mapper update for 2.6.25: Alasdair G Kergon (5): dm: mark function lists static dm ioctl: remove lock_kernel dm: targets no longer experimental dm mpath: add

Re: [git pull] device-mapper update for 2.6.25

2008-02-07 Thread Alasdair G Kergon
On Thu, Feb 07, 2008 at 07:04:47PM -0800, Andrew Morton wrote: > On Fri, 8 Feb 2008 02:45:32 +0000 Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > > > dm: move deferred bio flushing to workqueue > > To my unpracticed eye this one looks fairly fundamental. Unfor

Re: [PATCH 2/2] mirror throttling

2013-02-14 Thread Alasdair G Kergon
On Wed, Jan 09, 2013 at 12:44:38AM -0500, Mikulas Patocka wrote: > We maintain a history of kcopyd usage in variables io_period and > total_period. The actual kcopyd activity is "(100 * io_period / > total_period)" percent of time. If we exceed user-defined percentage > threshold, we sleep. Well,

[git pull] 3.7 device-mapper changes

2012-10-12 Thread Alasdair G Kergon
Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm tags/dm-3.7-changes to get the following device-mapper changes for 3.7. Thanks, Alasdair Remove the power-of-2 block size constraint on discards in d

[git pull] 3.6 device-mapper fixes

2012-09-26 Thread Alasdair G Kergon
Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm tags/dm-3.6-fixes to get the following device-mapper fixes. A few fixes for problems discovered during the 3.6 cycle. Of particular note, are fixes t

Re: linux-next: import of the device-mapper series failed

2012-10-01 Thread Alasdair G Kergon
On Mon, Oct 01, 2012 at 01:22:46PM +1000, Stephen Rothwell wrote: > Trying to import the device-mapper series produce this error: > $ git am > ../quilt/device-mapper/dm-thin-support-discard-with-non-power-of-two-block-size.patch > Applying: Support discards when the pool's block size is not a powe

Re: [dm-devel] [PATCH v2.1 0/1] dm-integrity: integrity protection device-mapper target

2013-01-15 Thread Alasdair G Kergon
On Tue, Jan 15, 2013 at 10:35:56PM +0200, Dmitry Kasatkin wrote: > I addressed all comments I got so far. Can it be now added to the DM tree? Mikulas will review the latest version with this in mind. Alasdair -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: Bcache v. whatever

2013-01-15 Thread Alasdair G Kergon
On Tue, Jan 15, 2013 at 03:33:47PM -0800, Kent Overstreet wrote: > I haven't been active on dm-devel, besides the occasional cross > posting... not sure what activity you're referring to on the dm list, A caching framework based on dm has been proposed by Joe Thornber (the original author of dm).

Re: [dm-devel] Re: device mapper not reporting no-barrier-support?

2008-02-25 Thread Alasdair G Kergon
On Mon, Feb 25, 2008 at 03:20:50PM -0800, Andrew Morton wrote: > On Mon, 25 Feb 2008 14:26:15 +0100 Anders Henke <[EMAIL PROTECTED]> wrote: > > I'm currently stuck between Kernel LVM and DRBD, as I'm using Kernel > > 2.6.24.2 with DRBD 8.2.5 on top of an LVM2 device (LV). > > -LVM2/device mapper do

[PATCH] device-mapper: [1/4] Fix deadlocks in core

2005-07-11 Thread Alasdair G Kergon
Some code tidy-ups in preparation for the next patches. Change dm_table_pre/postsuspend_targets to accept NULL. Use dm_suspended() throughout. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm.c2005-07-11 22:52:16.0 +0100 +++ source/drivers/m

[PATCH] device-mapper: [4/4] Fix deadlocks in core

2005-07-11 Thread Alasdair G Kergon
Oh - the 4th patch is empty now:-) The remaining changes all ended up in the 3rd one. Alasdair - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

[PATCH] device-mapper: [2/4] Fix deadlocks in core

2005-07-11 Thread Alasdair G Kergon
Avoid another bdget_disk which can deadlock. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm.c2005-07-11 22:52:10.0 +0100 +++ source/drivers/md/dm.c 2005-07-11 22:57:58.0 +0100 @@ -825,18 +825,13 @@ wake_up(&

[PATCH] device-mapper: [3/4] Fix deadlocks in core

2005-07-11 Thread Alasdair G Kergon
dm_swap_table() so that these functions cannot run concurrently: there's no requirement for that and it added complexity. DMF_FS_LOCKED becomes redundant: DMF_SUSPENDED provides adequate protection. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm.

Re: 2.6.13-rc2-mm2

2005-07-12 Thread Alasdair G Kergon
On Tue, Jul 12, 2005 at 08:16:14PM +0200, Felipe Alfaro Solana wrote: > I'm seeing this oops with 2.6.13-rc2-mm2: > EIP is at suspend_targets+0x6/0x47 [dm_mod] > Doesn't happen with 2.6.13-rc2-mm1, however. What's your device-mapper/lvm configuration and what 'lvm' command did you run to trigge

Re: 2.6.13-rc2-mm2 : oops in dm_mod

2005-07-12 Thread Alasdair G Kergon
On Tue, Jul 12, 2005 at 08:52:39PM +0200, Laurent Riffard wrote: > I just got this oops. > EIP is at suspend_targets+0x8/0x42 [dm_mod] I fear the empty patch the script gave me yesterday wasn't meant to be empty... [Yes, I'm going to switch to quilt just as soon as I can make time to convert

[PATCH] device-mapper: Fix target suspension oops.

2005-07-12 Thread Alasdair G Kergon
This section got lost while refactoring the 'Fix deadlocks in core' set of patches I sent yesterday. Without it, you'll have problems activating any device-mapper devices. The NULL detection is moved inside the functions instead of every caller having to do it. --- drivers/md/dm-table.c

[PATCH] device-mapper multipath: Barriers not supported

2005-07-08 Thread Alasdair G Kergon
dm multipath will report barriers as not supported with this patch. Signed-off-by: Lars Marowsky-Bree <[EMAIL PROTECTED]> Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm-mpat

[PATCH] device-mapper multipath: Fix pg initialisation races

2005-07-08 Thread Alasdair G Kergon
Skip process_queued_ios if the queue is empty so that we only trigger a pg_init if there's I/O. Signed-off-by: Lars Marowsky-Bree <[EMAIL PROTECTED]> Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm-mpath.c 2005-07-08 20:24:55.0 +0100 +++ source

[PATCH] device-mapper snapshots: Handle origin extension

2005-07-08 Thread Alasdair G Kergon
Handle writes to a snapshot-origin device that has been extended since the snapshot was taken. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm-snap.c 2005-07-08 19:01:41.0 +0100 +++ source/drivers/md/dm-snap.c 2005-07-08 19:41:00.0 +0100 @@

[PATCH] device-mapper multipath: Avoid possible suspension deadlock

2005-07-08 Thread Alasdair G Kergon
he process, save the previous queueing state and leave userspace to restore if it wishes. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm-mpath.c 2005-07-08 19:21:18.0 +0100 +++ source/drivers/md/dm-mpath.c2005-07-08 19:21:37.0 +010

[PATCH] device-mapper: Fix dm_swap_table error cases

2005-07-08 Thread Alasdair G Kergon
Fix dm_swap_table() __bind error cases: a missing unlock, and EINVAL preferable to EPERM. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm.c2005-07-08 19:21:37.0 +0100 +++ source/drivers/md/dm.c 2005-07-08 19:36:03.0 +0100 @@ -966,23 +

[PATCH] device-mapper multipath: Flush workqueue when destroying

2005-07-08 Thread Alasdair G Kergon
The multipath destructor must flush its workqueue. Otherwise items that reference the destroyed object could remain. From: "goggin, edward" <[EMAIL PROTECTED]> Signed-off-by: Lars Marowsky-Bree <[EMAIL PROTECTED]> Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Alasdair G Kergon
On Wed, Jan 09, 2008 at 02:12:40PM -0600, Matt Mackall wrote: > You'll need to change the prototype, the unlocked version doesn't take > an inode. And you'll need to make sure that nothing in the function uses > the inode, which I think Andi forgot to mention. This old chestnut again. Perhaps we

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Alasdair G Kergon
On Wed, Jan 09, 2008 at 11:46:03PM +0100, Andi Kleen wrote: > struct inode *inode = file->f_dentry->d_inode; And oops if that's not defined? Alasdair -- [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Alasdair G Kergon
er allowing a regular file to be treated as a block device. Signed-off-by: Bryn Reeves <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> --- drivers/md/Kconfig |9 drivers/md/Makefile |1 drivers/md/dm-loop.c | 1036 +++

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Alasdair G Kergon
On Wed, Jan 09, 2008 at 04:58:46PM -0600, Chris Friesen wrote: > Alasdair G Kergon wrote: > >On Wed, Jan 09, 2008 at 11:46:03PM +0100, Andi Kleen wrote: > >>struct inode *inode = file->f_dentry->d_inode; > >And oops if that's not defined? > Isn't this b

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Alasdair G Kergon
On Thu, Jan 10, 2008 at 12:43:19AM +0100, [EMAIL PROTECTED] wrote: > oh, nice to see that this is still alive. > at least i got no crashes and was able to mount and acess more than 300 > iso-images with that. > were there fixes/chances since then? Little has changed for some time - mostly code

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Alasdair G Kergon
On Wed, Jan 09, 2008 at 03:31:00PM -0800, Vadim Lobanov wrote: > From 2.6.23's fs/ioctl.c - do_ioctl(): Ah - you're talking about struct file_operations of course; I was talking about struct block_device_operations. Alasdair -- [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-10 Thread Alasdair G Kergon
On Thu, Jan 10, 2008 at 01:49:15AM -0800, Daniel Phillips wrote: > So what stops you from changing to unlocked_ioctl for the main device > mapper ctl_ioctl? Nothing - patches to do this are queued for 2.6.25: http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/dm-ioctl-rem

Re: [dm-devel] Re: 2.6.24-rc4-mm1

2007-12-06 Thread Alasdair G Kergon
On Thu, Dec 06, 2007 at 11:04:12PM +0100, Kay Sievers wrote: > A fix for LVM to handle symlinks instead of directories is in the LVM > CVS tree, but there wasn't a release since August. I released it yesterday:-) Alasdair -- [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "uns

[git pull 00/06] device-mapper fixes for 2.6.24-rc*

2007-12-13 Thread Alasdair G Kergon
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git to get the following device-mapper fixes for 2.6.24: Alasdair G Kergon (1): dm: trigger change uevent on rename Jun'ichi Nomura (1): dm: table detect io beyond device Milan Broz (2):

[2.6.24 PATCH 01/06] dm: table detect io beyond device

2007-12-13 Thread Alasdair G Kergon
mapper/${MAP} bs=${SIZE} count=1 & echo "Wait til dd push some I/O" sleep 5 dmsetup resume ${MAP} -- Cc: [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> Signed-off-by: Alasdair

[2.6.24 PATCH 02/06] dm mpath: hp requires scsi

2007-12-13 Thread Alasdair G Kergon
f-by: Paul Mundt <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> --- drivers/md/Kconfig |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.24-rc5/drivers/md/Kconfig === --- l

[2.6.24 PATCH 03/06] dm crypt: fix write endio

2007-12-13 Thread Alasdair G Kergon
From: Milan Broz <[EMAIL PROTECTED]> Fix BIO_UPTODATE test for write io. Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Milan Broz <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> --- drivers/md/dm-crypt.c |7 --- 1 files changed,

[2.6.24 PATCH 04/06] dm: trigger change uevent on rename

2007-12-13 Thread Alasdair G Kergon
From: Alasdair G Kergon <[EMAIL PROTECTED]> Insert a missing KOBJ_CHANGE notification when a device is renamed. Cc: Scott James Remnant <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> --- drivers/md/dm-ioctl.c |2 ++ drivers/md/dm.c |7 +

[2.6.24 PATCH 05/06] dm: merge max_hw_sector

2007-12-13 Thread Alasdair G Kergon
From: Neil Brown <[EMAIL PROTECTED]> Make sure dm honours max_hw_sectors of underlying devices We still have no firm testing evidence in support of this patch but believe it may help to resolve some bug reports. - agk Signed-off-by: Neil Brown <[EMAIL PROTECTED]> Signed-off-by

[2.6.24 PATCH 06/06] dm crypt: use bio_add_page

2007-12-13 Thread Alasdair G Kergon
ns too) instead of constructing own biovec. All versions of dm-crypt are affected by this bug. Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Milan Broz <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> --- drivers/md/dm-crypt.c | 24 +++

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-22 Thread Alasdair G Kergon
On Fri, Jan 18, 2008 at 11:01:11AM -0800, Martin Knoblauch wrote: > At least, rc1-rc5 have shown that the CCISS system can do well. Now > the question is which part of the system does not cope well with the > larger IO sizes? Is it the CCISS controller, LVM or both. I am open to > suggestions on h

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-22 Thread Alasdair G Kergon
On Tue, Jan 22, 2008 at 07:25:15AM -0800, Martin Knoblauch wrote: > [EMAIL PROTECTED] ~]# dmsetup table > VolGroup00-LogVol02: 0 350945280 linear 104:2 67109248 > VolGroup00-LogVol01: 0 8388608 linear 104:2 418054528 > VolGroup00-LogVol00: 0 67108864 linear 104:2 384 The IO should pass straight

Re: [dm-devel] [PATCH 0/2] dm-band: The I/O bandwidth controller: Overview

2008-01-23 Thread Alasdair G Kergon
On Wed, Jan 23, 2008 at 09:53:50PM +0900, Ryo Tsuruta wrote: > Dm-band gives bandwidth to each job according to its weight, > which each job can set its own value to. > At this time, a job is a group of processes with the same pid or pgrp or uid. It seems to rely on 'current' to classify bios and

Re: [dm-devel] [PATCH] device-mapper: fix bd_mount_sem corruption

2007-10-09 Thread Alasdair G Kergon
On Mon, Oct 08, 2007 at 07:31:49PM -0400, Jun'ichi Nomura wrote: > This patch fixes a bd_mount_sem counter corruption bug in device-mapper. [summary of follow-up] Affects 2.6.16 (and 2.6.15.5) upwards if someone removes a suspended device (which shouldn't happen during normal lvm2 operation). Al

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-20 Thread Alasdair G Kergon
On Tue, Nov 20, 2007 at 03:40:30PM +0100, Milan Broz wrote: > (Note comment in code "It is permissible to free the struct > work_struct from inside the function that is called from it".) I don't understand yet how lockdep behaves if the work struct gets reused and the reused one finishes first.

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Alasdair G Kergon
Also io->pending may need better protection - atomic, but missing memory barriers? (May be getting away without sometimes due to side-effects of other function calls, but needs doing properly.) [BTW Other device-mapper atomic_t usage also needs reviewing.] Alasdair -- [EMAIL PROTECTED] - To uns

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Alasdair G Kergon
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote: > ... or I just don't see the bug. See my earlier post in this thread: there's a race in the write loop where a work struct could be used twice on the same queue. (Needs data structure change to fix that, which nobody has attempted t

Re: 2.6.24-rc2-mm1: kcryptd vs lockdep

2007-11-23 Thread Alasdair G Kergon
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote: > Before the cleanup *all* calls to crypt_dec_pending() was via crypt_endio(). > Now there is an additional call to crypt_dec_pending() to balance the > additional ref placed into crypt_write_io_process(). And that one is > not called

Re: [PATCH] debug_check_no_locks_freed: fix in_range() checks

2007-11-24 Thread Alasdair G Kergon
On Sat, Nov 24, 2007 at 01:18:35PM +0100, Torsten Kaiser wrote: > I will reapply agk-dm-dm-crypt-move-bio-submission-to-thread.patch and > this patch and boot several times OK for a test system, but until the write loop problem is addressed I believe there's a risk of data corruption under low mem

Re: [dm-devel] [RFC] A SCSI fault injection framework using SystemTap.

2008-01-15 Thread Alasdair G Kergon
On Tue, Jan 15, 2008 at 12:04:09PM +0900, K.Tanaka wrote: > -dm-mirror's redundancy doesn't work. A read error from the disk consisting >the array will be directory passed to the userspace, without reading from >the other mirror. >(It turns out that this issue is a known issue, but th

  1   2   3   >