[PATCH - BUGFIX] Smack: Check for 'struct socket' with NULL sk

2008-02-11 Thread Ahmed S. Darwish
ar checks in inode_{get/set}security(). Cheating from SELinux post_create_socket(), it does the same. Casey, Thoughts ? Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 1c11e42..eb04278 100644 --- a/security/smack/smack_ls

[PATCH BUGFIX 25-rc1] Smack: Don't fail against Nulled sk sockets

2008-02-12 Thread Ahmed S. Darwish
Hi!, Appropriately handle sockets with sk = NULL. This is usually the socket case when starting kernel nfsd. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Acked-by: Casey Schaufler <[EMAIL PROTECTED]> Tested-by: Joerg Platte <[EMAIL PROTECTED]> -- diff --git a/security/s

Linux i386 clone(): %ebx 'frobbing' ?

2008-02-15 Thread Ahmed S. Darwish
be popped to child 'in the ebx frobbing below'. But what does that mean ? Thanks in advance -- Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: Linux i386 clone(): %ebx 'frobbing' ?

2008-02-15 Thread Ahmed S. Darwish
Hi Andreas, On Fri, Feb 15, 2008, Andreas Schwab wrote: > "Ahmed S. Darwish" <[EMAIL PROTECTED]> writes: > > > I don't understand how the `fn' argument reached the child thread > > in the %ebx register. It's said in the comment that `fn'

Re: Linux i386 clone(): %ebx 'frobbing' ?

2008-02-15 Thread Ahmed S. Darwish
On Sat, Feb 16, 2008 at 12:28:11AM +0100, Andreas Schwab wrote: > "Ahmed S. Darwish" <[EMAIL PROTECTED]> writes: > > > Hi Andreas, > > > > On Fri, Feb 15, 2008, Andreas Schwab wrote: > >> "Ahmed S. Darwish" <[EMAIL PROTECTED]> writ

[PATCH x86] i8259A_32: Remove redundant irq_desc[NR_IRQ] initialization

2008-02-17 Thread Ahmed S. Darwish
Hi all, Remove redundant irq_desc[NR_IRQS] element initialization in init_ISA_irqs(). irq_desc[NR_IRQS] is already statically initialized with the same values in kernel/irq/handle.c . Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- i8259_32.c | 26 ++

[PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ahmed S. Darwish
Hi all, Avoid duplicating __tasklet_schedule() and __tasklet_hi_schedule() code in tasklet_action() and tasklet_hi_action() respectively. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- This also saves a few bytes of image space: textdata bss dec hex filename

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ahmed S. Darwish
On Tue, Feb 19, 2008 at 04:52:52PM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > - local_irq_disable(); > > - t->next = __get_cpu_var(tasklet_vec).list; > > -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ahmed S. Darwish
On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > > > - local_irq_disable(); > > > > - t->next = __get_cpu_var(tasklet_vec).list; > > > &g

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ahmed S. Darwish
On Wed, Feb 20, 2008 at 03:20:52PM +0100, Dmitry Adamushko wrote: > On 20/02/2008, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: > > > > > > * Ahmed S.

[Lguest/x86]: Clash with ioremap_nocache() + _PAGE_PWT

2008-02-06 Thread Ahmed S. Darwish
oid __iomem *p = __ioremap(phys_addr, size, _PAGE_PCD | _PAGE_PWT); if (!p) return p; Thanks, [*]: latest pull calls set_memory_uc() which also sets the _PWT flag. -- Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com -- To unsubs

[PATCH] lguest: Accept guest _PAGE_PWT page table entries

2008-02-06 Thread Ahmed S. Darwish
On Thu, Feb 07, 2008 at 12:59:23AM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > > Beginning from commit 4138cc3418f5, ioremap_nocache() sets the _PAGE_PWT > > flag. > > > > Lguest doesn'

[BUG + PATCH/Bugfix] x86/lguest: fix pgdir pmd index calculation

2008-02-24 Thread Ahmed S. Darwish
just made the problem appear ? [2]: The patch: [PATCH] lguest: fix pgdir pmd index cacluation Remove an error in index calculation which leads to removing a not existing shadow page table (leading to a Null dereference). Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/

Re: [BUG + PATCH/Bugfix] x86/lguest: fix pgdir pmd index calculation

2008-02-24 Thread Ahmed S. Darwish
On Sun, Feb 24, 2008 at 05:18:14PM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > I am not sure why the division over four existed in the first place. > > It seems bogus, maybe the Xen patch just made the problem appear ? > >

Re: [BUG + PATCH/Bugfix] x86/lguest: fix pgdir pmd index calculation

2008-02-24 Thread Ahmed S. Darwish
On Sun, Feb 24, 2008 at 06:26:53PM +0200, Ahmed S. Darwish wrote: > On Sun, Feb 24, 2008 at 05:18:14PM +0100, Ingo Molnar wrote: > > > I've picked up your patch into x86.git#testing (until Rusty picks it > > up), you can track it the following way: > > > >

Re: 2.6.25-rc3: Reported regressions from 2.6.24

2008-02-25 Thread Ahmed S. Darwish
4/136 and a patch in the same report. It's not yet approved by Rusty, but Ingo thinks it's fine. Regards, -- "Better to light a candle, than curse the darkness" Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com -- To uns

[PATCH RFC 1/2] IRQ: Modularize the setup_irq code (1)

2007-10-04 Thread Ahmed S. Darwish
. Thanks, ==> (Description for Logs) Introduce can_add_irqaction_on_allocated_irq and warn_about_irqaction_mismatch methods to support setup_irq() code modularity. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- manage

[PATCH RFC 2/2] IRQ: Modularize the setup_irq code (2)

2007-10-04 Thread Ahmed S. Darwish
Introduce irq_desc_match_fist_irqaction() to support setup_irq() code modularity. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Any ideas for a better method name ? manage.c | 89 --- 1 file changed, 51 insertions(

[Oops] on 2.6.23-rc9 sysRq Show Tasks (t)

2007-10-06 Thread Ahmed S. Darwish
r+0x7/0x14 [ 226.331090] === And So on for every task. Thanks, -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [E

Re: [Oops] on 2.6.23-rc9 sysRq Show Tasks (t)

2007-10-06 Thread Ahmed S. Darwish
s a known problem ? > Shame, This is not an Oops at all. Really sorry. /me wondering about my look now posting a normal message as an Ooops a day before the stable release :(. -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com - To unsubscrib

Re: [Oops] on 2.6.23-rc9 sysRq Show Tasks (t)

2007-10-07 Thread Ahmed S. Darwish
On Sun, Oct 07, 2007 at 01:12:38AM +0400, Alexey Dobriyan wrote: > On Sat, Oct 06, 2007 at 10:14:06PM +0200, Ahmed S. Darwish wrote: > > Pressing sysRq+T always produce an Oops for every running system task (94 > > Oopses, that's a record ;)). > > uh-oh. For ev

Re: PROBLEM: kernel 2.6.22.9-cfs-v22 compile warnings

2007-10-08 Thread Ahmed S. Darwish
vers/pci/search.c:434: warning: 'pci_find_device' is deprecated > (declared at drivers/pci/search.c:241) > drivers/pci/search.c:434: warning: 'pci_find_device' is deprecated > (declared at drivers/pci/search.c:241) > False positives from function definition and from

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-09 Thread Ahmed S. Darwish
ference between char *c = "msg" and char c[] = "msg" is that the first is a non-const pointer to a const char array while the second is a modifiable char array ? If so, what's the point of the patch ? Thanks, -- Ahmed S. Darwish HomePage: http://darwish.07.googlepag

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Ahmed S. Darwish
man getcwd char *getcwd(char *buf, size_t size); As an extension to the POSIX.1 standard, Linux (libc4, libc5, glibc) getcwd() allocates the buffer dynamically using malloc() if buf is NULL on call. Shouldn't "srctree" be free()ed in case getenv("SRCTREE")

Re: [PATCH -mm] fix wrong /proc/cpuinfo output

2007-10-09 Thread Ahmed S. Darwish
patch in lkml.org: http://lkml.org/lkml/2007/9/24/394 -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majo

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote: > On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote: > > > Hi Rob, > > > > On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote: > > [...] > > > FILE * infile; > > > +

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 10:24:03AM -0700, Randy Dunlap wrote: > Ahmed S. Darwish wrote: > >On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote: > >>On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote: > >> > >>>Hi Rob, > >>> > &g

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 08:33:59PM +0200, Philipp Matthias Hahn wrote: > Hello! > > On Tue, Oct 09, 2007 at 02:40:35PM +0200, Ahmed S. Darwish wrote: > > On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote: > > > The patch below contains a small code clean-up

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser(2)

2007-11-10 Thread Ahmed S. Darwish
ent. > Maximum value label_len could reach is "SMK_MAXLEN". The subjectstr and objectstr arrays are of "SMK_MAXLEN + 1" length. So I think no danger is here. Yes, this deserved a comment. > ... > > + case access: > > + if (*pr

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser(2)

2007-11-11 Thread Ahmed S. Darwish
have noticed, but to stop any objections not related to the core smack code, Casey decided to let the parsing be done in a user-space utility that sends the rules to the kernel in a predefined strict format. You can find how the whole story in the smackv11 announcement here: http://article.gmane.org

Re: [PATCH 2/2] Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel

2007-10-27 Thread Ahmed S. Darwish
s in cipso_seq_start and BUG in case cipso_seq_show was passed a non-cipso label. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- smackv8-omit-noncipso-in-seq-start.patch diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 55ba2dc..b061cd0 100644 --- a/security/sma

Re: [PATCH 2/2] Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel

2007-10-27 Thread Ahmed S. Darwish
return -EINVAL if write()'s count field > 80, or if input contains no \n or more than one. Any Ideas ?. Casey, I can begin modifying cipso_write() and writing this small user-space utility now if you agree on this. Regards, -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com

Re: [PATCH 2/2] Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel

2007-10-28 Thread Ahmed S. Darwish
On 10/28/07, Al Viro <[EMAIL PROTECTED]> wrote: > On Sat, Oct 27, 2007 at 11:01:12AM +0200, Ahmed S. Darwish wrote: > > The problem here (As discussed in private mails) is that the for loop > > assumes that the beginning of given user-space buffer is the beginning > &g

[PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-01 Thread Ahmed S. Darwish
} + rc = count; +out: kfree(data); return rc; } @@ -251,7 +359,7 @@ static const struct file_operations smk_load_ops = { .read = seq_read, .llseek = seq_lseek, .write = smk_write_load, - .release= seq_release +

Re: [PATCH] Version 8 (2.6.23) Smack: Simplified Mandatory Access Control Kernel

2007-10-19 Thread Ahmed S. Darwish
rotected by the smk_cipsolock spinlock. We don't need a lock in the reading side since we don't do a write operation depending on that read, right ?. -- Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com - To unsubscribe from this lis

[PATCH] Smackv8: Omit non-cipso labels in cipso_seq_start

2007-10-20 Thread Ahmed S. Darwish
Hi!, [Casey, sending patches in public to get an early review] Omit non-cipso labels in cipso_seq_start(). Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- stopping seq_show() if smk_cipso = NULL only fixes the bug symptom. We'll issue a BUG() in that case cause it signal

[PATCH] Smackv8: Safe lockless {cipso,load} read operation

2007-10-20 Thread Ahmed S. Darwish
Hi, Utilizing Al's concers about using smack_cipso_count without locking, here's a patch that remove smack_cipso_count and uses simple list traversing in read() without any counting mechanism. CC: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]&

Rule parsing from a virtual FS write() syscall

2007-10-24 Thread Ahmed S. Darwish
st way to parse a rule in such hard coditions? Regards, -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majord

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Ahmed S. Darwish
On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote: > Hi Ahmed, > Hi :), > On 10/12/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: > > > > > > Signed-off-by: Bryan Wu <[EM

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Ahmed S. Darwish
t; +ad7142_probe(struct i2c_adapter *adap, int addr, int kind) > +{ > + struct i2c_client *client; > + int rc; > + > + client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL); > + if (!client) > + return -ENOMEM; > + memset(client, 0, sizeof(struc

Re: 2.6.23-git2 buid failure

2007-10-14 Thread Ahmed S. Darwish
[drivers/mmc/core/host.o] Error 1 > make[2]: *** [drivers/mmc/core] Error 2 > make[1]: *** [drivers/mmc] Error 2 > make: *** [drivers] Error 2 > You can fix it using this patch: http://lkml.org/lkml/2007/10/12/380 Or the patch titled: mmc-fix-compile-without-led-triggers.patch Regards, -- Ahmed

Re: [PATCH] Version 7 (2.6.23) Smack: Simplified Mandatory Access Control Kernel

2007-10-14 Thread Ahmed S. Darwish
4417 > host-196.218.207.17.tedata.net.domain: 49202+[|domain] --> 22:51:26.105443 IP DOKKI-R03C-GZ-EG > host-196.218.207.18.tedata.net: ICMP parameter problem - octet 20, length 48 Best Regards, -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com Blog: http://darwish-

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Ahmed S. Darwish
ot; case. Why using it in a different context while workqueues was created for a similar situation to ad7142 one (non-irq context bottom-half) ? Regards, -- Ahmed S. Darwish HomePage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com - To unsubscribe from this list: send the lin

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-16 Thread Ahmed S. Darwish
On Tue, Oct 16, 2007 at 02:08:04PM +0800, Bryan Wu wrote: > On 10/16/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > On Mon, Oct 15, 2007 at 11:48:17AM -0400, Dmitry Torokhov wrote: > > > Hi Bryan, > > > > > > On 10/15/07, Bryan Wu <[EMAIL PRO

Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-02 Thread Ahmed S. Darwish
On 11/1/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Nov 1 2007 17:54, Ahmed S. Darwish wrote: > >+ > >+static inline int isblank(char c) > >+{ > >+ return (c == ' ' || c == '\t'); > >+} > > Use isspace(). >

[PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-03 Thread Ahmed S. Darwish
ich needs more testing): A Smack Rule in an "egrep" format is: "^[:space:]*Subject[:space:]+Object[:space:]+[rwxaRWXA-]+[:space:]*\n" where Subject/Object strings are in the form: "^[^/[:space:][:cntrl:]]{1,SMK_MAXLEN}$" Signed-off-by: Ahmed S. Darwish <[EMAIL P

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-03 Thread Ahmed S. Darwish
On 11/3/07, Kyle Moffett <[EMAIL PROTECTED]> wrote: > On Nov 03, 2007, at 12:43:06, Ahmed S. Darwish wrote: > > Bashv3 builtin "echo" behaves very strangely to -EINVAL. It sends > > all the buffers that causes -EINVAL again in subsequent echo > > invocations

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-04 Thread Ahmed S. Darwish
for a user-space utility. > > > +static inline int isblank(char c) > > +{ > > + return (c == ' ' || c == '\t'); > > +} > > This sounds like enough for 'NAK'. > Would you please show the reason for the NAK so I can modify the cod

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-04 Thread Ahmed S. Darwish
On 11/3/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > static int smk_open_load(struct inode *inode, struct file *file) > { > - return seq_open(file, &load_seq_ops); > + if ((file->f_flags & O_ACCMODE) == O_RDONLY) > + ret

[PATCH] Smackv10: Smack rules grammar + their stateful parser(2)

2007-11-04 Thread Ahmed S. Darwish
On Sat, Nov 03, 2007 at 06:43:06PM +0200, Ahmed S. Darwish wrote: > On Fri, Nov 02, 2007 at 01:50:55PM -0700, Casey Schaufler wrote: > > > > Still to come: > > > > - Final cleanup of smack_load_write and smack_cipso_write. > > Hi All, > > After agreeing

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-05 Thread Ahmed S. Darwish
On Sun, Nov 04, 2007 at 12:28:48PM +, Pavel Machek wrote: > Hi! > > > > Still to come: > > > > > > - Final cleanup of smack_load_write and smack_cipso_write. > > > > Hi All, > > > > After agreeing with Casey on the "load" input grammar yesterday, here's > > the final grammar and its parse

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-05 Thread Ahmed S. Darwish
On 11/5/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Mon, 5 Nov 2007, Ahmed S. Darwish wrote: > > > On Sun, Nov 04, 2007 at 12:28:48PM +, Pavel Machek wrote: > > > > > > Can we avoid string parsers in the kernel? > > > > > &g

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-06 Thread Ahmed S. Darwish
table characters or the '/' (slash) character. and in write(): if (!isascii(c) return -EINVAL; if (!isspace(c) && !isgraph(c)) return -EINVAL; This satisfy above customized labels rule, right ? Regards, -- Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: htt

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-06 Thread Ahmed S. Darwish
On 11/6/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Tue, Nov 06, 2007 at 01:34:05PM +0200, Ahmed S. Darwish wrote: > > Hi, > > > > On Tue, Nov 06, 2007 at 09:56:51AM +0100, Adrian Bunk wrote: > > > On Tue, Nov 06, 2007 at 03:26:12AM -0500, Kyle Moffett wrot

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-06 Thread Ahmed S. Darwish
On Tue, Nov 06, 2007 at 02:34:46PM +0100, Adrian Bunk wrote: > On Tue, Nov 06, 2007 at 07:49:26AM -0500, Kyle Moffett wrote: > > On Nov 06, 2007, at 07:23:36, Ahmed S. Darwish wrote: > >> On 11/6/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > >>> On Tue, Nov 0

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

2007-11-06 Thread Ahmed S. Darwish
On 11/6/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Tue, Nov 06, 2007 at 04:05:13PM +0200, Ahmed S. Darwish wrote: > > > > Great, To summarize the discussion. Will there be a problem in > > accepting ASCII and the UTF-8 ASCII _subset_ _only_ and return >

[PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Ahmed S. Darwish
Substitue intel_rng magic PCI IDs values used in the IDs table with the macros defined in pci_ids.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- I've used a small script to generate this patch then manually tried to make sure it's (hopefully) correct. #!/bin/bash

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Ahmed S. Darwish
On Mon, Jan 15, 2007 at 06:31:01AM +1100, Dave Airlie wrote: > On 1/15/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > >On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > >> Substitue intel_rng magic PCI IDs values used in the IDs table > >> wit

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-14 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 09:37:21AM -0800, Arjan van de Ven wrote: > On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > > Hi, > > > hmm this i

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-15 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote: > On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > Why not use the PCI_DEVICE() macro too

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-15 Thread Ahmed S. Darwish
ro. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- I've used a script to generate that patch, then checked the results manually to make sure that it's (hopefully) correct. #!/bin/bash INTEL_RNG_FILE=drivers/char/hw_random/intel-rng.c TMP_FILE=$(mktemp) # File to hold

Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

2007-01-15 Thread Ahmed S. Darwish
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote: > On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > Why not use the PCI_DEVICE() macro too

[PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Ahmed S. Darwish
Use ARRAY_SIZE macro in pvrusb2-hdw.c file Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c index d200496..f66f7c6 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c +++ b/drivers

[PATCH 2.6.20-rc5 3/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Ahmed S. Darwish
Use ARRAY_SIZE macro in pvrusb2-std.c file Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c index f95c598..677f126 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-std.c +++ b/drivers

[PATCH 2.6.20-rc5 4/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Ahmed S. Darwish
Use ARRAY_SIZE macro in miscellaneous pvrusb2 files found Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- This patch ofcourse don't include previous patches in the set. I've just included the remaining modifications in one patch/mail cause every file touched here has

[PATCH 2.6.20-rc5 1/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Ahmed S. Darwish
Hi all, A cleanup series for the pvrusb2 code to use the ARRAY_SIZE macro. Since The size of the patch is big, I've splitted it to 4 pieces according to the files they touch. PATCH 1/4: Use ARRAY_SIZE in pvrusb2-encoder.c Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- d

[PATCH 2.6.20-rc5] DVB: Use ARRAY_SIZE macro when appropriate

2007-01-16 Thread Ahmed S. Darwish
Hi all, Patch uses the ARRAY_SIZE macro defined in kernel.h instead of reemplementing it. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- bt8xx/dvb-bt8xx.c |2 +- frontends/cx24110.c |4 ++-- frontends/cx24123.c |6 +++--- 3 files changed, 6 insertions(+), 6 del

[PATCH 2.6.20-rc5] isdn/capi: use ARRAY_SIZE when appropriate

2007-01-16 Thread Ahmed S. Darwish
Hi all, A trivial patch to use ARRAY_SIZE macro defined in kernel.h instead of reimplementing it. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- capi.c|4 ++-- capidrv.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/isdn/capi/capi.c b/d

Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Ahmed S. Darwish
On Tue, Jan 16, 2007 at 03:36:16AM -0500, Robert P. J. Day wrote: > On Tue, 16 Jan 2007, Ahmed S. Darwish wrote: > > > Use ARRAY_SIZE macro in pvrusb2-hdw.c file > > > > Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> > > ... snip ... > > i'm

Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Ahmed S. Darwish
On Tue, Jan 16, 2007 at 10:16:33AM -0800, Randy Dunlap wrote: > On Tue, 16 Jan 2007 03:36:16 -0500 (EST) Robert P. J. Day wrote: > > > On Tue, 16 Jan 2007, Ahmed S. Darwish wrote: > > > > > Use ARRAY_SIZE macro in pvrusb2-hdw.c file > > > > > > Sign

Re: after effects of a kernel API change

2007-01-17 Thread Ahmed S. Darwish
volunteers like me can help in this exercise? See the /APIchanges in the Kernel Janitors TODO list http://kernelnewbies.org/KernelJanitors/Todo Also: Documentation/stable_api_nonsense.txt -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscri

Re: after effects of a kernel API change

2007-01-18 Thread Ahmed S. Darwish
tem" works. Also check: $KERNEL_TREE/Documentation/HOWTO $KERNEL_TREE/Documentation/SubmittingPatches $KERNEL_TREE/Documentation/CodingStyle -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

/sbin/depmod Segmentation fault (Reproducable)

2007-01-03 Thread Ahmed S. Darwish
1.60 Console-tools 0.2.3 Sh-utils 5.93 udev 079 wireless-tools 28 -- Ahmed S. Darwish .config.gz Description: Binary data

Video GL rendering worked only between 2.6.20 and 2.6.21-rc1

2007-02-23 Thread Ahmed S. Darwish
m/i810_*.c drivers/video/i810/* Any more probably responsible files? Thanks, -- Ahmed S. Darwish http://darwish.07.googlepages.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: A CodingStyle suggestion

2007-02-04 Thread Ahmed S. Darwish
if (ret) { >/* deal with error */ > } Thanks for all the replies, A patch will be sent in a new thread. Regards -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

[PATCH 00] A series of patches to use ARRAY_SIZE macro under arch/

2007-02-04 Thread Ahmed S. Darwish
hanged, 49 insertions(+), 48 deletions(-) Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please r

[PATCH 2.6.20] arch CRIS: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked since I have no CRIS machine at hand. diff --git a/arch/cris/arch-v10/drivers/axisflashmap.c b/arch/cris/arch-v10/drivers/axi

[PATCH 2.6.20] arch AVR32: Use ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi Haavard, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no AVR32 machine at hand. Thanks, diff --git a/arch/avr32/kernel/setup.c b/arch/avr32/kernel/setup.c in

[PATCH 2.6.20] arch M68KNOMMU: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no M68KNOMMU board at hand. Thanks, diff --git a/arch/m68knommu/kernel/ptrace.c b/arch/m68knommu/kernel/ptr

[PATCH 2.6.20] arch MIPS: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no MIPS board at hand. Thanks, diff --git a/arch/mips/jmr3927/rbhma3100/setup.c b/arch/mips/jmr3927/rbhma3100/se

[PATCH 2.6.20] arch V850: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no V850 board at hand. Thanks, diff --git a/arch/v850/kernel/anna.c b/arch/v850/kernel/anna.c index 40892d3..0e4

[PATCH 2.6.20] arch PowerPC: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no PowerPC machine at hand. Thanks, diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c index 57bf9

[PATCH 2.6.20] arch PPC: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no PowerPC machine at hand. Thanks, diff --git a/arch/ppc/lib/rheap.c b/arch/ppc/lib/rheap.c index 31e5118..d40

[PATCH 2.6.20] arch M68K: user ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked since I have no m68k machine at hand. diff --git a/arch/m68k/kernel/ptrace.c b/arch/m68k/kernel/ptrace.c index ef89060..7fd

[PATCH 2.6.20] arch ARM: Use ARRAY_SIZE macro when appropriate

2007-02-04 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile checked cause I have no ARM machine at hand. Thanks, diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c index 71257e3..f1c

[PATCH 00] A series of patches to use ARRAY_SIZE under video subtree

2007-02-05 Thread Ahmed S. Darwish
+++--- tvp5150.c |3 ++- usbvideo/quickcam_messenger.c |2 +- 11 files changed, 32 insertions(+), 30 deletions(-) Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH 2.6.20] pvrusb2: use ARRAY_SIZE macro when appropriate (2)

2007-02-05 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE already defined in kernel.h. This patch is a complementry (and does not include) the one sent one week earlier. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- It seems that the earlier grep expression I used to produce the first patch didn'

[PATCH 2.6.20] misc-video: use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro in miscellaneous video drivers found with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patches are compile tested. diff --git a/drivers/media/video/cpia2/cpia2_v4l.c b/drivers/media/video/cpia2/cpia2_v4l.c index d

[PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c index fb96c87..d21706e 100644 --- a/drivers/net

[PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers

2007-02-05 Thread Ahmed S. Darwish
+- zorro8390.c|2 +- 27 files changed, 50 insertions(+), 42 deletions(-) Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[PATCH 01/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- [PATCH 01/02] is compile tested. [PATCH 02/02] isn't compile tested cause of missing hard

[PATCH 02/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile-tested due to missing hardware. diff --git a/drivers/net/apne.c b/

[PATCH 2.6.20] misc-wireless: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous wireless drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c

[PATCH 2.6.20] hostap: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro in the Host AP wireless driver. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/wireless/hostap/hostap.h b/drivers/net/wireless/hostap/hostap.h index e89c890..ef37a75 100644 --- a/drivers/net/wi

[PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ixgb/ixgb_param.c b/drivers/net/ixgb/ixgb_param.c index b27442a..26031fe 100644 --- a/drivers/net/ixgb/ixgb_param.c +++ b/drivers/ne

[PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A trivial patch to use ARRAY_SIZE macro. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/wavelan.p.h b/drivers/net/wireless/wavelan.p.h index 72b646c..fe12c77 100644 --- a/drivers/net/wireless/wavelan.p.h +++ b/drivers/net/wireless/wavel

[PATCH 2.6.20] ipw2100: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c index b85857a..a9d944a 100644 --- a/drivers/net/wireless/ipw

[PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile-tested cause I don't have the needed hardware. diff --git a/drivers/net/ibm_emac/ibm_emac_debug.c b/drivers/net/ibm_emac/ibm_emac_debug

Re: [PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 11:17:09PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 05, 2007 at 07:00:44PM +0200, Ahmed S. Darwish wrote: > > A trivial patch to use ARRAY_SIZE macro. > > You're supposed to remove it ans use ARRAY_SIZE where old macro is used. > > &g

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: > Alexey Dobriyan wrote: > >On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: > >>A patch to use ARRAY_SIZE macro already defined in kernel.h. > > > >Remove it and use ARRAY_SIZE instead.

  1   2   3   4   5   6   >