slab cache question

2008-02-02 Thread Adrian McMenamin
I have been having problems with the slab cache (using slub) in my maple bus driver (eg see http://lkml.org/lkml/2008/1/28/74). I have now switched to using SLAB_POISON in kmem_cache_create and instead of fatal oops, I get what follows - could someone tell me the likely causes I should be lookin

[PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-03 Thread Adrian McMenamin
From: Adrian McMenamin This patch fixes the regression noted here: http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the previous commit of this driver and the memory leaks noted here: http://lkml.org/lkml/2008/2/2/143 (as well as one or two other minor cleanups). Signed off by

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > On Sun, Feb 03, 2008 at 08:00:47PM +0000, Adrian McMenamin wrote: > > From: Adrian McMenamin > > > > This patch fixes the regression noted here: > > http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 10:10 +0900, Paul Mundt wrote: > On Sun, Feb 03, 2008 at 08:00:47PM +0000, Adrian McMenamin wrote: > > From: Adrian McMenamin > > > This is useless if you are submitting the patch, especially if you're > missing a mail address. > >From Docu

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: > My previous commit was directly from _your_ patch, given that your > patches have a history of whitespace damage, this doesn't seem like much > of a stretch. It's true I neglected to run it through checkpatch, I'll be > more careful with that i

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, February 4, 2008 9:59 am, Paul Mundt wrote: > On Mon, Feb 04, 2008 at 09:35:11AM -0000, Adrian McMenamin wrote: >> On Mon, February 4, 2008 9:02 am, Paul Mundt wrote: >> > My previous commit was directly from _your_ patch, given that your >> > patches have a h

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 22:37 +, Adrian McMenamin wrote: > > The hardware is very flaky. If I add in delays to the bus start, it will > detect the devices, but it's not brilliant. Registering an empty device > got round that problem, at the price of testing for the earli

Re: [PATCH] SH/Dreamcast - fix regressions, whitespace and memory leaks in Maple Bus driver

2008-02-04 Thread Adrian McMenamin
On Mon, 2008-02-04 at 08:14 -0800, Greg KH wrote: > On Mon, Feb 04, 2008 at 08:27:55AM +0000, Adrian McMenamin wrote: > > > > On Sun, 2008-02-03 at 21:29 -0800, Greg KH wrote: > > > On Sun, Feb 03, 2008 at 08:00:47PM +, Adrian McMenamin wrote: > &

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-11 Thread Adrian McMenamin
On Mon, February 11, 2008 4:25 pm, Dmitry Torokhov wrote: > On Mon, Feb 11, 2008 at 11:19:22AM -0500, Mike Frysinger wrote: >> On Monday 11 February 2008, Adrian McMenamin wrote: >> > On Mon, February 11, 2008 12:22 am, Mike Frysinger wrote: >> > > no remove fu

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-11 Thread Adrian McMenamin
On Mon, February 11, 2008 12:22 am, Mike Frysinger wrote: > > no remove function ? looks like the probe() forces a connect, but there's > no > remove() to force a disconnect ... Removing these devices (or any other plugged directly into the maple ports) is a quick way to destroy your Dreamcast:

Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
Will seek to bisect this, but I have just updated my sources to the latest git and it is not booting at all on the Dreamcast. With early printk on, I get nothing more than this before an instant reboot: [0.00] Linux version 2.6.25-rc2-10953-g52065cd ([EMAIL PROTECTED]) (gcc version 3.4.6)

Re: Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: > Will seek to bisect this, but I have just updated my sources to the > latest git and it is not booting at all on the Dreamcast. > > With early printk on, I get nothing more than this before an instant > reboot: >

Re: Current git very broken on the Dreamcast

2008-02-16 Thread Adrian McMenamin
On Sat, 2008-02-16 at 19:48 +, Adrian McMenamin wrote: > On Sat, 2008-02-16 at 18:38 +0000, Adrian McMenamin wrote: > > Will seek to bisect this, but I have just updated my sources to the > > latest git and it is not booting at all on the Dreamcast. > > > [EMAIL PRO

[PATCH] maple: remove unused variable

2008-02-16 Thread Adrian McMenamin
Remove an unused variable from the definition of struct maple_device Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN a/include/linux/maple.h b/include/linux/maple.h --- a/include/linux/maple.h 2008-02-16 20:52:09.0 + +++ b/include/linux/maple.h 2008-02

[PATCH] maple: allow removal and reinsertion of keyboard driver module

2008-02-16 Thread Adrian McMenamin
Allow the removal (and subsequent reinsertion) of the maple_keyb (maple keyboard) driver by adding a working removal function. Also tidy long lines. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_

[PATCH] maple: add driver for Sega Dreamcast controller

2008-02-16 Thread Adrian McMenamin
Add support for the SEGA Dreamcast controller as a joystick device. Based on Yaegashi Takeshi's old 2.4 driver (never in mainline) with the addition of functioning removal (and reinsertion) code. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN a/drivers/inp

Re: Current git very broken on the Dreamcast

2008-02-18 Thread Adrian McMenamin
On Mon, 2008-02-18 at 17:57 +0900, Magnus Damm wrote: > Hi Adrian, > > [fixed up Matsubara-sans address] > > On Feb 17, 2008 4:48 AM, Adrian McMenamin > <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: > > > Wi

[PATCH 1/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
This patch is fundamentally about fixing up the whitespace problems introduced by my previous patch (that brought the code into mainline). A second patch will follow that will fix memory leaks. The two need to be applied sequentially. Signed-off by: Adrian McMenamin <[EMAIL PROTEC

[PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index 3f341dc..60eeb92 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@ -30,6 +30,7 @@ #include #include #include +#include MODULE_AUTHOR("Yaegshi Ta

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
On Wed, 2008-02-06 at 15:01 -0800, Greg KH wrote: > On Wed, Feb 06, 2008 at 10:53:51PM +0000, Adrian McMenamin wrote: > > - dev->function = function; > > - dev->dev.bus = &maple_bus_type; > > - dev->dev.parent = &maple_bus; > > - dev->dev.

Re: [PATCH 2/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Adrian McMenamin
function in any way). Also now removes redundant registration checking. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c index 3f341dc..fbca7f8 100644 --- a/drivers/sh/maple/maple.c +++ b/drivers/sh/maple/maple.c @@

[PATCH] - SH/Dreamcast - additional patch to maple.h

2008-02-06 Thread Adrian McMenamin
This patch removes the now unneeded registration check variable from struct maple_device. (This patch assumes the include/linux/maple.h file has already been patched for whitespace errors by http://lkml.org/lkml/2008/2/6/327) Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff -

[PATCH] 8139too fix for Dreamcast

2008-02-08 Thread Adrian McMenamin
Updates the 8139too driver to work with recently added (a724605cb7a66d423a494a395f9a8ba871b8a1eb) declared coherent memory patch for the Dreamcast. Jeff - I am assuming you are still the maintainer and I guess Paul should also ack this as it is SH related. Signed-off-by: Adrian McMenamin <[EM

[PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-10 Thread Adrian McMenamin
Adds support for the Dreamcast control pad. This is a port of the 2.4 driver (never in mainline) by Yaegashi Takeshi. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> == --- /dev/null 2007-10-16 19:02:41.0 +0100 +++ drivers/input/joystick/maplecontrol.c 2008-02-10

[PATCH 2/2] SH/Dreamcast - joystick (controlpad)

2008-02-10 Thread Adrian McMenamin
Changes to the Kconfig and Makefile needed to build the Maple controlpad code. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> == diff --combined drivers/input/joystick/Kconfig index 7c662ee,7c662ee..3566fa2 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/K

[PATCH 1/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: support maple mouse on Dreamcast Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig index 7bbea09..d171336 100644 --- a/drivers/input/mouse/Kconfig +++ b/drivers/input/mouse/Kconfig @@ -232,4 +232,16 @@

[PATCH 2/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: update Makefile to support maple mouse on Dreamcast Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile index 9e6e363..5d35939 100644 --- a/drivers/input/mouse/Makefile +++ b/drivers/input/mouse/Ma

[PATCH 3/3] input: support maple mouse on Dreamcast

2008-02-24 Thread Adrian McMenamin
input: add support for maple mouse on Dreamcast Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/drivers/input/mouse/maplemouse.c b/drivers/input/mouse/maplemouse.c new file mode 100644 index 000..08cfb6f --- /dev/null +++ b/drivers/input/mouse/maplemouse.c @@ -0,0

[PATCH] input: support maple controller on SEGA Dreamcast

2008-02-24 Thread Adrian McMenamin
This is a port of the old (never in mainline) 2.4 driver. (It also fixes some issues with earlier patches which should be discarded for this) Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN ./a/drivers/input/joystick/Kconfig ./b/drivers/input/joystick/Kconfig --- ./a/d

[PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
) now ensures that devices are properly detected again. (A previous attempt to fix this by delaying initialisation only partially fixed this - as became apparent when the bus was fully loaded) Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN ./a/drivers/sh/maple/maple

lkml.org

2008-02-24 Thread Adrian McMenamin
At the risk of pointing out the obvious (though I cannot find anyone else who has commented), this appears to be broken at the moment...(ie not picking up new messages) ...which is a pity as it is a great site Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: > The maple bus driver that went into the kernel mainline in September 2007 > contained some bugs which were revealed by the update of the kobj code for > the current release series. Unfortunately those bugs also helped ens

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Sun, 2008-02-24 at 21:50 +, Adrian McMenamin wrote: > On Sun, 2008-02-24 at 14:30 +0000, Adrian McMenamin wrote: > > The maple bus driver that went into the kernel mainline in September 2007 > > contained some bugs which were revealed by the update of the kobj code for

Re: [PATCH] input: support maple controller on SEGA Dreamcast

2008-02-24 Thread Adrian McMenamin
Add support for the Dreamcast maple controller (as a joystick). Earlier patches caused subdevice detection headaches. Please use this one. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff -ruN ./a/drivers/input/joystick/Kconfig ./b/drivers/input/joystick/Kconfig --- ./a/d

Re: [PATCH] maple: fix device detection

2008-02-24 Thread Adrian McMenamin
On Mon, 2008-02-25 at 14:33 +0900, Paul Mundt wrote: > On Sun, Feb 24, 2008 at 10:32:53PM +0000, Adrian McMenamin wrote: > > On Sun, 2008-02-24 at 21:50 +0000, Adrian McMenamin wrote: > > > On Sun, 2008-02-24 at 14:30 +, Adrian McMenamin wrote: > > > > The maple

[PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-10 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's

rq_for_each_bio

2007-12-08 Thread Adrian McMenamin
I have tried to search through the mailing list and it is not entirely clear, but it looks like this has gone from the kernel: not least because my driver reports: drivers/sh/gdrom/gdrom.c:665: error: implicit declaration of function 'rq_for_each_bio' I am not arguing for a stable ABI/API, I get

[PATCH] SG - fix SH Kconfig

2008-01-20 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> Remove reference to board deleted in commit 758e06ded4c48024835ef0a14627afcde2e25929 Submitted-by: Adrian McMenamin <[EMAIL PROTECTED]> --- diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 85bd9ac..e94430b 100644 --- a/arch/sh/Kconfi

Re: [PATCH] SG - fix SH Kconfig

2008-01-20 Thread Adrian McMenamin
On Sun, 2008-01-20 at 11:54 -0800, Randy Dunlap wrote: > On Sun, 20 Jan 2008 18:18:29 +0000 Adrian McMenamin wrote: > > > From: Adrian McMenamin <[EMAIL PROTECTED]> > > > > > > Remove reference to board deleted in commit > > 758e06ded4c48024835e

[PATCH] Fix SH DMA API so it works with PVR cascade

2007-10-02 Thread Adrian McMenamin
(at least for the PVR) so that code is removed. Submitted-by: Adrian McMenamin <[EMAIL PROTECTED]> --- arch/sh/drivers/dma/dma-sh.c2007/09/22 18:34:42 1.1 +++ arch/sh/drivers/dma/dma-sh.c2007/09/22 18:37:28 1.2 @@ -150,6 +150,13 @@ static void sh_dmac_disable_dma(st

[PATCH] Fix up SH DMAC code to correctly handle PVR DMA

2007-10-02 Thread Adrian McMenamin
a division by 32 before the xfer function is called * Currently the code supports reading and writing, but the hardware only supports writing Signed-off by Adrian McMenamin <[EMAIL PROTECTED]> --- arch/sh/drivers/dma/dma-sh.c2007/09/22 18:34:42 1.1 +++ arch/sh/drivers/dma/dm

Re: [PATCH] Fix SH DMA API so it works with PVR cascade

2007-10-02 Thread Adrian McMenamin
On Tue, 2007-10-02 at 19:15 +0100, Adrian McMenamin wrote: > This patch - hope it is not too late for 2.6.24 queue - gets the SH DMA > API to work properly for the PVR2 DMA cascade. > Please ignore this - sent in error - and look at http://lkml.org/lkml/2007/10/2/276 - To unsubscribe

[PATCH] Fix SH DMAC code to handle PVR2 cascade

2007-10-02 Thread Adrian McMenamin
Fix SH DMAC code to correctly handle PVR2 cascade DMA. This updates http://lkml.org/lkml/2007/10/2/276 (I decided it was better to have the true size of the transfer put in via the API and refactor this here. And calc_xmit_shift(chan) should return 5 but only returns 3 so I've not used it here)

Re: [PATCH] Fix SH DMAC code to handle PVR2 cascade

2007-10-03 Thread Adrian McMenamin
On Wed, October 3, 2007 7:18 am, Paul Mundt wrote: > On Tue, Oct 02, 2007 at 10:09:27PM +0100, Adrian McMenamin wrote: >> Fix SH DMAC code to correctly handle PVR2 cascade DMA. >> >> This updates http://lkml.org/lkml/2007/10/2/276 >> >> (I decided it was be

Re: [PATCH] Fix SH DMAC code to handle PVR2 cascade

2007-10-04 Thread Adrian McMenamin
On Thu, October 4, 2007 11:01 am, Paul Mundt wrote: > So for PVR2 cascade, what does the CHCR value work out to? Both > CHCR_TS_MASK and CHCR_TS_SHIFT haven't changed for SH7750, so this > suggests that either the CHCR value is just wrong or we've had a > long-standing bug with the CHCR.TS mask. >

[PATCH] Fix SH4 DMAC API

2007-10-06 Thread Adrian McMenamin
This patch fixes the DMA cascade by masking the correct bits. Tested and working with Dreamcast PVR2 DMA. With this patch applied the existing mainline code in arch/sh/drivers/dma/dma-sh.c works, whereas before I was patching that to get round this problem. Signed-off by: Adrian McMenamin

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-20 Thread Adrian McMenamin
On 16/12/2007, Paul Mundt <[EMAIL PROTECTED]> wrote: > > Also, __devinit/__devexit annotations? > Is there any difference between __init and __devint? I am using __init/__exit already > > +static struct platform_driver gdrom_driver = { > > + .probe = probe_gdrom, > > + .remove = remove_g

[PATCH - SH/Dreamcast] Add support for GD-Rom device

2007-12-20 Thread Adrian McMenamin
or almost all the suggestions/change requests made last time. But grateful for all comments. This is targetted at Paul Mundt's 2.6.25 queue, but should also compile against 2.6.24-rc5 I am using it play mp3s off CD even as I write this and it seems to work pretty well :) Signed-off by:

Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

2007-12-20 Thread Adrian McMenamin
On 20/12/2007, Adrian McMenamin <[EMAIL PROTECTED]> wrote: > This patch adds support for the CD Rom device (called a "GD Rom") on > the SEGA Dreamcast.This device has a command block similar to a > standard ATA-3 device, though implements Sega's proprietary packet >

Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

2007-12-21 Thread Adrian McMenamin
On Fri, December 21, 2007 2:22 pm, Jens Axboe wrote: > On Fri, Dec 21 2007, Adrian McMenamin wrote: >> On 21/12/2007, Jens Axboe <[EMAIL PROTECTED]> wrote: >> > >> > Your design is also heavily geared towards there just being a single >> > CDROM, I'

Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

2007-12-21 Thread Adrian McMenamin
On 21/12/2007, Jens Axboe <[EMAIL PROTECTED]> wrote: > > Your design is also heavily geared towards there just being a single > CDROM, I'm assuming this wont be a problem given your hw (it sets a bad > example for others to follow though, lots of violations against normal > programming practice for

Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

2007-12-21 Thread Adrian McMenamin
On Fri, 2007-12-21 at 13:14 +0100, Jens Axboe wrote: > > What is pages doing in gdrom_request()? > As the device doesn't do scatter-gather I've set blk_queue_max_segment_size to 1 and am not bothering with pages - is that wrong? -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

2007-12-21 Thread Adrian McMenamin
On Fri, 2007-12-21 at 20:35 +0100, Jens Axboe wrote: > backing_dev_info Sorry, I know what you mean now ... left over from an earlier experiments with read ahead. Will delete it now: didn't realise it was still lurking there) -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Correct use of __init and __devinit

2007-12-23 Thread Adrian McMenamin
Could someone here help settle this argument? I have written a driver (for the CD Rom on the Sega Dreamcast). I have marked various initialisation functions - including probe() and the functions that it, and only it, calls, as __init. Other developers tell me I should mark them as __devinit. How

[PATCH - SH/Dreamcast] CD-Rom (GD-Rom) support for the SEGA Dreamcast

2007-12-23 Thread Adrian McMenamin
the issue of __init versus __devinit - see http://lkml.org/lkml/2007/12/23/130 but I think otherwise it has dealt with most people's suggestions. The one exception is that Jens suggested using sector_div, though I found that did not work. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED

Re: [PATCH - SH/Dreamcast] CD-Rom (GD-Rom) support for the SEGA Dreamcast

2007-12-23 Thread Adrian McMenamin
On 23/12/2007, Adrian McMenamin <[EMAIL PROTECTED]> wrote: > This patch adds support for the CD-Rom (the so-called "GD-Rom") on the > SEGA Dreamcast. > > The GD-Rom is based on the ATA-3 standard but implements a proprietary > packet interface - the so-called

[PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-26 Thread Adrian McMenamin
new driver, not a modified version of previous drivers. This is the fourth iteration of this patch - which should work with both 2.6-24-rc5 and Paul Mundt's 2.6.25 queue. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff -rupN linux-2.6-orig/drivers/block/Kconfig linux-2.6/

Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-27 Thread Adrian McMenamin
On Thu, 2007-12-27 at 17:18 +0900, Paul Mundt wrote: > On Thu, Dec 27, 2007 at 01:26:47AM +0000, Adrian McMenamin wrote: > > > + /* now seek to take the request spinlock > > +* before handling ending the request */ > > +

[PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-27 Thread Adrian McMenamin
new driver, not a modified version of previous drivers. This is the fifth iteration of this patch - which should work with both 2.6-24-rc5 and Paul Mundt's 2.6.25 queue. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff -rupN linux-2.6-orig/drivers/block/Kconfig linux-2.6/

Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-27 Thread Adrian McMenamin
On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote: > This patch adds support for the CD-Rom drive on the SEGA Dreamcast. > > The SEGA Dreamcast has a built in CD-Rom drive, electrically similar > to an ATA-3 drive, but implementing a proprietary packet interface - > the

Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-29 Thread Adrian McMenamin
On Fri, 2007-12-28 at 17:57 -0800, Joe Perches wrote: > > Perhaps (uncompiled/untested): > > Remove unnecessary parenthesis > Remove GDROM: prefix from sense_texts > Add function gdrom_data_request > Check sense_key against sense_text array size > > Signed-off-by: Joe Perches <

Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-29 Thread Adrian McMenamin
On Sat, 2007-12-29 at 12:03 +, Adrian McMenamin wrote: > On Fri, 2007-12-28 at 17:57 -0800, Joe Perches wrote: > > > > > Perhaps (uncompiled/untested): > > > > Remove unnecessary parenthesis > > Remove GDROM: prefix from sense_texts >

Re: [PATCH] Fix broken ip= parsing

2007-12-29 Thread Adrian McMenamin
fer <[EMAIL PROTECTED]> > --- > This patch certainly fixes the problem I was having with NFS root - I had a working setup that stopped (though at the same time as I updated my Busybox setup so I thought this was my mistake). Please apply. Tested by: Adrian McMenamin <[EMAIL PROTECTE

Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-30 Thread Adrian McMenamin
On Thu, 2007-12-27 at 14:58 -0800, Joe Perches wrote: > On Thu, 2007-12-27 at 16:52 +0000, Adrian McMenamin wrote: > > This patch adds support for the CD-Rom drive on the SEGA Dreamcast. > > Because it was already so close, might as well make it checkpatch clean. > > I

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-11 Thread Adrian McMenamin
On Thu, 2008-01-10 at 23:25 +, Adrian McMenamin wrote: > From: Adrian McMenamin <[EMAIL PROTECTED]> > > This patch adds support for the GD-Rom drive, SEGA's proprietary > implementation of an IDE CD Rom for the SEGA Dreamcast. This driver > implements Sega

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-12 Thread Adrian McMenamin
On Sat, 2008-01-12 at 05:36 -0800, Andrew Morton wrote: > On Fri, 11 Jan 2008 21:56:49 +0000 Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > > > > On Thu, 2008-01-10 at 23:25 +, Adrian McMenamin wrote: > > > From: Adrian McMenamin <[EMAIL PROTECTED]> &

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-13 Thread Adrian McMenamin
On 12/01/2008, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 12 Jan 2008 14:14:01 +0000 Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > > > > > > + spin_command->cmd[0] = 0x70; > > > > + spin_command->cmd[2] = 0x1f; > &

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-14 Thread Adrian McMenamin
On Mon, 2008-01-14 at 23:00 +, Adrian McMenamin wrote: > From: Adrian McMenamin <[EMAIL PROTECTED]> > > This patch adds support for the GD-Rom drive, SEGA's proprietary > implementation of an IDE CD Rom for the SEGA Dreamcast. This driver > implements Sega

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-14 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-15 Thread Adrian McMenamin
On 15/01/2008, Paul Mundt <[EMAIL PROTECTED]> wrote: > On Mon, Jan 14, 2008 at 11:17:15PM +0000, Adrian McMenamin wrote: > > > +static bool gdrom_data_request(void) > > +{ > > + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8; > > +} > > + >

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-16 Thread Adrian McMenamin
On Mon, 2008-01-14 at 23:17 +, Adrian McMenamin wrote: > On Mon, 2008-01-14 at 23:00 +0000, Adrian McMenamin wrote: > > From: Adrian McMenamin <[EMAIL PROTECTED]> > > > > This patch adds support for the GD-Rom drive, SEGA's proprietary > > implem

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-17 Thread Adrian McMenamin
From: Adrian McMenamin <[EMAIL PROTECTED]> This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's

[PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
This has been tested against the latest git in Paul Mundt's 2.6.25 queue as well as 2.6.24-rc5 Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mo

[PATCH 1/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
diff -ruN ./linux-2.6-orig/drivers/block/Kconfig ./linux-2.6/drivers/block/Kconfig --- ./linux-2.6-orig/drivers/block/Kconfig 2007-12-15 22:23:47.0 + +++ ./linux-2.6/drivers/block/Kconfig 2007-12-15 22:18:28.0 + @@ -105,6 +105,18 @@ "MicroSolutions backpack

[PATCH 3/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
diff -ruN ./linux-2.6-orig/drivers/sh/Makefile ./linux-2.6/drivers/sh/Makefile --- ./linux-2.6-orig/drivers/sh/Makefile2007-12-15 22:23:59.0 + +++ ./linux-2.6/drivers/sh/Makefile 2007-12-15 22:18:45.0 + @@ -4,3 +4,4 @@ obj-$(CONFIG_SUPERHYWAY) += superhy

Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
On Sun, 2007-12-16 at 00:20 +, Adrian McMenamin wrote: > (Apologies if you've already had this. I sent it to lkml etc an hour > ago but it just disappeated into the ether - trying it in smaller > packets this time.) > vger/lkml's spam filtering is trapping the main par

[PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
the SEGA Dreamcast + * copyright Adrian McMenamin, 2007 + * With thanks to Marcus Comstedt and Nathan Keynes + * for work in reversing PIO and DMA + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by

Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-16 Thread Adrian McMenamin
On Sun, 2007-12-16 at 13:13 +0900, Paul Mundt wrote: > On Sun, Dec 16, 2007 at 12:20:54AM +0000, Adrian McMenamin wrote: > > This device is electrically compatible with ATA-3 IDE CD drives but > > implements a proprietary packet interface. There have been previous > > Dreamc

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-16 Thread Adrian McMenamin
On Sun, 2007-12-16 at 18:50 +0900, Paul Mundt wrote: > Ok, I don't know anything about the CD-ROM layer, so I've just commented > on the general and SH-specific stuff. Hopefully someone with a clue > in this area (ie, not me) can offer input on the rest of the bits. > > > +static char gdrom_exec

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-16 Thread Adrian McMenamin
On Sun, 2007-12-16 at 18:50 +0900, Paul Mundt wrote: > > +static int gdrom_readdisk_dma(int block, int block_cnt, char *buffer) > > +{ > > + int err; > > + struct packet_command *read_command; > > + /* release the spin lock but check later > > +* we're not in the middle of some dma */ >

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-16 Thread Adrian McMenamin
On Mon, 2007-12-17 at 06:59 +0900, Paul Mundt wrote: > > While I realize that this is all undocumented and based entirely on > reverse engineering, you should at least verify that that's precisely > what is going on, and that this is not just a precaution for flushing > posted writes. You can te

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-17 Thread Adrian McMenamin
On Mon, December 17, 2007 2:06 pm, Jens Axboe wrote: > On Sun, Dec 16 2007, Adrian McMenamin wrote: > > Few notes: Thanks for these, very helpful. > > - Compare rq_data_dir() with WRITE, don't just assume that any non-zero > will be a write. > > - You need to off

kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
Greg, Just updated my git to the latest sources and get these (seemingly non-fatal) oops with the Dreamcast maple bus. I'll investigate further, but they may mean something to out out of the box. Adrian dreamy:~# [0.00] Linux version 2.6.24-gf0ea9c3d-dirty ([EMAIL PROTECTED]) (gcc

Re: kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
On 26/01/2008, Adrian McMenamin <[EMAIL PROTECTED]> wrote: > Greg, > > Just updated my git to the latest sources and get these (seemingly non-fatal) > oops with the Dreamcast maple bus. I'll investigate further, but they may > mean something to out out of the box. &

Re: kobject oops with maple bus

2008-01-26 Thread Adrian McMenamin
On Sat, 2008-01-26 at 12:44 -0800, Greg KH wrote: > On Sat, Jan 26, 2008 at 07:53:20PM +0000, Adrian McMenamin wrote: > > Greg, > > > > Just updated my git to the latest sources and get these (seemingly > > non-fatal) oops with the Dreamcast maple bus. I'll in

Re: kobject oops with maple bus

2008-01-28 Thread Adrian McMenamin
On Sat, January 26, 2008 8:44 pm, Greg KH wrote: > On Sat, Jan 26, 2008 at 07:53:20PM +0000, Adrian McMenamin wrote: >> Greg, >> >> Just updated my git to the latest sources and get these (seemingly >> non-fatal) oops with the Dreamcast maple bus. I'll investiga

Race in setup_irq?

2007-11-11 Thread Adrian McMenamin
I am writing a device driver for the Dreamcast CD Drive (the "GD Rom") and I am hitting what looks like some sort of race in kernel/irq/manage.c. Can anybody point me in the right direction or is there a bug here? This never seems to return in setup_irq: spin_unlock_irqrestore(&desc->lock

Re: Race in setup_irq?

2007-11-11 Thread Adrian McMenamin
On 11/11/2007, Dmitry Adamushko <[EMAIL PROTECTED]> wrote: > On 11/11/2007, Adrian McMenamin <[EMAIL PROTECTED]> wrote > > I am writing a device driver for the Dreamcast CD Drive (the "GD Rom") > > and I am hitting what looks like some sort of race in > >

[PATCH - SH] Clean up maple bus code to supress compiler warning

2007-10-28 Thread Adrian McMenamin
The API for uevent has changed for 2.6.24 and this patch makes a consequential clean up. (Apols to linux-sh list users seeing this for the second time, I should have included lkml first time round for completeness) Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/driv

[PATCH] Dreamcast AICA sound - Get rid of annoying compiler warning

2007-10-28 Thread Adrian McMenamin
This patch supresses an annoying compiler warning that the variable err may be used uninitialised. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/sound/sh/aica.c b/sound/sh/aica.c index 88dc840..8861d2f 100644 --- a/sound/sh/aica.c +++ b/sound/sh/aica.c @@ -237,6

[PATCH] Fix Dreamcast DMA

2007-07-19 Thread Adrian McMenamin
Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/sh/drivers/dma/dma-api.c index cf8e119..0c9b3bc 100644 --- a/arch/sh/drivers/dma/dma-api.c +++ b/arch/sh/drivers/dma/dma-api.c @@ -31,8 +31,8 @@ struct dma_info *get_dma_info(unsigned in

Re: [PATCH] Fix DMA on Dreamcast

2007-07-21 Thread Adrian McMenamin
On 20/07/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Thu, 19 Jul 2007 20:30:34 +0100 "Adrian McMenamin" <[EMAIL PROTECTED]> wrote: > I think my first attempt to post this may have got lost in space somewhere. > > Signed-off by: Adrian McMenamin <[E

Re: [PATCH] Fix DMA on Dreamcast

2007-07-21 Thread Adrian McMenamin
On 21/07/07, Peter Bortas <[EMAIL PROTECTED]> wrote: Sidenote: Does Linux handle the Dreamcast DMA errata? You need to explain what you mean (at least to me!). If you mean will it degrade gracefully - not without this patch if set to the (correct) defconfig. With iffy settings it will. - To

Problems with framebuffer in 2.6.22-git17

2007-07-22 Thread Adrian McMenamin
I ma having problems with the pvr2 fb on the Dreamcast in 2.6.22-git17 - when the code is executed it appears to lock the Dreamcast up. The problem seems to be: fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event); In drivers/video/fbmem.c This hasn't been an issue before, so are there any r

Re: Problems with framebuffer in 2.6.22-git17

2007-07-22 Thread Adrian McMenamin
On 22/07/07, Adrian McMenamin <[EMAIL PROTECTED]> wrote: I ma having problems with the pvr2 fb on the Dreamcast in 2.6.22-git17 - when the code is executed it appears to lock the Dreamcast up. The problem seems to be: fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event); In dri

Lots of scheduling bugs (?) with -rc1

2007-07-22 Thread Adrian McMenamin
Lots of this on the Dreamcast (nb the first pvr2fb oops is a different issue) eg Starting network... Starting dropbear sshd: [ 16.689047] BUG: scheduling while atomic: dropbear/0x1001/722 [ 16.694675] Stack: (0x8c3f7e58 to 0x8c3f8000) [ 16.699143] 7e40: 8c15a80c 1000 [ 16.7076

Re: Problems with framebuffer in 2.6.22-git17

2007-07-23 Thread Adrian McMenamin
(Apologies to those getting this a second time: resending as text/plain only) On 23/07/07, Adrian McMenamin <[EMAIL PROTECTED]> wrote: On 7/23/07, Antonino A. Daplas <[EMAIL PROTECTED]> wrote: > On Sun, 2007-07-22 at 19:41 +0100, Adrian McMenamin wrote: > > I ma hav

[PATCH] Fix Dreamcast DMA issues

2007-07-23 Thread Adrian McMenamin
m and consequently fixes the sound driver to ensure it continues to function. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/sh/drivers/dma/dma-api.c index cf8e119..76ed816 100644 --- a/arch/sh/drivers/dma/dma-api.c +++ b/arch/sh/drivers/dma/dma-api

Re: Problems with framebuffer in 2.6.22-git17

2007-07-24 Thread Adrian McMenamin
On 23/07/07, Antonino A. Daplas <[EMAIL PROTECTED]> wrote: On Sun, 2007-07-22 at 19:41 +0100, Adrian McMenamin wrote: > I ma having problems with the pvr2 fb on the Dreamcast in 2.6.22-git17 > - when the code is executed it appears to lock the Dreamcast up. > > The p

[PATCH] Patch pvr2 driver to allow development of maple bus driver

2007-08-31 Thread Adrian McMenamin
rs to the VBLANK). This has no impact on the performance of the PVR2. Signed-off by Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c index 7d6c298..13de07f 100644 --- a/drivers/video/pvr2fb.c +++ b/drivers/video/pvr2fb.c @@ -890,7 +890,7 @@

  1   2   >