Re: Version number policy!

2013-04-05 Thread Adrian Chadd
On 5 April 2013 01:19, Luis R. Rodriguez wrote: > This is better than anything we had drafted before for 802.11 open > firmware design rules. Cc'ing a few lists for wider review given that > what we had written before for rules was for 802.11 and Bluetooth [0] > and it was very Linux specific. We

Re: Version number policy!

2013-04-05 Thread Adrian Chadd
The point here is that once we hit a new major version, all the previous version checks can go away. So, if we decide to change some WMI message formats, it'll be in 2.x rather than 1.x. For example, has talked about killing off rate control in the NIC and doing it on the host. I'm happy with tha

Re: Version number policy!

2013-04-06 Thread Adrian Chadd
On 5 April 2013 22:52, Kalle Valo wrote: > Eugene Krasnikov writes: > >> Good point regarding timestamp. >> >> When it comes to feature bitmap do you have an example of such a >> bitmap from carl9170? Why not to rely always on major version? > > I'm with Christian here. In ath6kl we switched to f

Re: [PATCH] ath5k: Remove AHB bus support.

2013-05-13 Thread Adrian Chadd
... is anyone using this on openwrt? Adrian On 13 May 2013 08:03, Paul Bolle wrote: > AHB bus support was added in v2.6.38, through commit a0b907ee2a ("ath5k: > Add AHB bus support."). That code can only be build if the Kconfig > symbol ATHEROS_AR231X is set. But that symbol has never been ad

Re: [PATCH] ath5k: Remove AHB bus support.

2013-05-13 Thread Adrian Chadd
On 13 May 2013 09:39, Jonathan Bither wrote: >> ... is anyone using this on openwrt? >> > I am. > I am also reworking AR2131X drivers and will submit a patch to linux-mips > shortly. Sweet. Someone say NACK then? :) Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: Version number policy!

2013-04-08 Thread Adrian Chadd
On 8 April 2013 08:33, Christian Lamparter wrote: > On Monday, April 08, 2013 11:10:30 AM Eugene Krasnikov wrote: >> It’s a good idea to pack bitmap into the tail/header of the firmware >> binary to get capabilities even before fw loading. The plan is to add >> 8 bytes for caps and also add time s

Re: Version number policy!

2013-04-08 Thread Adrian Chadd
I'm a FreeBSD user. I know what it's like to have an alternate, out of linux implementation of ext2/3 that doesn't implement all of the features. I also know what kinds of crap happens when you try mounting a more recent extX filesystem on an earlier kernel. Ie, it doesn't necessarily end well. :-

Re: Version number policy!

2013-04-08 Thread Adrian Chadd
On 8 April 2013 17:37, Theodore Ts'o wrote: > There shouldn't be any crap; just a an error message indicating that > "the file system has features which this implementation doesn't > understand". At least, if the implementation was competently > coded (ext2/3/4 has feature bitmasks that make

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-17 Thread Adrian Chadd
On Thu, 17 May 2018 at 16:16, Niklas Cassel wrote: > diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c > index cda164f6e9f6..1d3b2d2c3fee 100644 > --- a/drivers/net/wireless/ath/ath10k/txrx.c > +++ b/drivers/net/wireless/ath/ath10k/txrx.c > @@ -95,6 +95,

Re: Question on kzalloc and GFP_DMA32

2016-10-06 Thread Adrian Chadd
On 28 September 2016 at 16:37, Ben Greear wrote: > On 09/28/2016 02:11 PM, David Rientjes wrote: [snip] >> >> I suppose it's failing sometimes because the BUG() will trigger when >> trying to allocate new slab or CONFIG_ZONE_DMA32 isn't configured. That >> shouldn't panic the kernel anymore sin

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-10 Thread Adrian Chadd
On 9 February 2017 at 23:37, Joe Perches wrote: > On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > >> If there >> were accessors for the skb data / len fields (like we do for mbufs) >> then porting the code would've involved about 5,000 less changed >>

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-09 Thread Adrian Chadd
On 9 February 2017 at 23:03, Valo, Kalle wrote: > Ben Greear writes: > >> On 02/07/2017 01:14 AM, Valo, Kalle wrote: >>> Adrian Chadd writes: >>> >>>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>>> FreeBSD

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-02 Thread Adrian Chadd
hiya, Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) -adrian

Re: [PATCH] ath10k: fix core PCI suspend when WoWLAN is supported but disabled

2017-10-11 Thread Adrian Chadd
fwiw - I did this on my in progress ath10k port to freebsd, and I've tested it on Rome and Peregrine. It seems to be the right thing to do during suspend to at least cleanly shut things down. -adrian On 11 October 2017 at 17:38, Brian Norris wrote: > Ping? Any comments? I know there's more tha