Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue

2017-02-17 Thread Adan Hawthorn
Thank you, Joe. Please remove this patch at this time; it was sent in error. On Fri, Feb 17, 2017 at 6:04 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: >> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is >> usually wrong: see Documentation/pro

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

2017-02-17 Thread Adan Hawthorn
Thanks, Joe. Is this to say that scripts/checkpatch.pl should be updated to some higher column limit? I have made these cleanup changes before in a like manner. On Fri, Feb 17, 2017 at 8:17 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: >> Fix checkpatch.pl war

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

2017-02-17 Thread Adan Hawthorn
Ok, I personally like that better anyhow. Also, there was mention of the line limit even exceeding 100 characters (130ish?) and that was being tossed around at one point (if I remember correctly). On Fri, Feb 17, 2017 at 8:38 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 20:32 -0500, A

Re: [PATCH 09/35] x86: Convert remaining uses of pr_warning to pr_warn

2017-02-20 Thread Adan Hawthorn
On Fri, Feb 17, 2017 at 2:11 AM, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for arch/x86 > > Prior to this patch, there were 46 uses of pr_warning and > 122 uses of pr_warn in arch/x86 > > Miscellanea: > > o Coalesce a few formats and realig

Re: [PATCH v4 01/17] x86/mpx: Do not use SIB index if index points to R/ESP

2017-02-24 Thread Adan Hawthorn
On Thu, Feb 23, 2017 at 9:33 PM, Joe Perches wrote: > On Thu, 2017-02-23 at 14:17 -0800, Ricardo Neri wrote: >> On Thu, 2017-02-23 at 08:24 +0100, Peter Zijlstra wrote: >> > On Wed, Feb 22, 2017 at 10:36:50PM -0800, Ricardo Neri wrote: >> > > + /* >> > > + * A nega