[PATCH V2] staging: ion: replace ion_phys_addr_t with phys_addr_t

Looks like phys_addr_t's are fully plumbed in the kernel. Signed-off-by: Tomas Winkler --- V2: remove one more comment regarding ion_phys_addr_t drivers/staging/android/ion/ion.c | 2 +- drivers/staging/android/ion/ion.h | 12 +++- drivers/staging/an

[char-misc-next 00/11] mei fixes and cleanups

Alexander Usyskin (4): mei: hbm: revamp client connect and disconnection status mei: fix potential read outside of array bounds mei: use helper function to find me client by id mei: make return values consistent across the driver Tomas Winkler (7): mei: add mei_hbuf_acquire wrapper

[char-misc-next 03/11] mei: Remove all bus devices from the mei_dev list when stopping the MEI

When stopping the MEI, we should remove and potentially unregister all bus devices queued on the mei_dev linked list. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 16 drivers/misc/mei/init.c| 2 ++ drivers/misc/mei/mei_dev.h | 1 + drivers/misc/mei/nfc.c

[char-misc-next 09/11] mei: don't of list_for_each_entry_safe when not deleting

We can use simply list_for_each_entry if there is no entry removal Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c| 12 +--- drivers/misc/mei/bus.c | 4 ++-- drivers/misc/mei/client.c| 23 +++ drivers/misc/mei/hbm.c | 9

[char-misc-next 04/11] mei: hbm: revamp client connect and disconnection status

. Change response status enum to have MEI_CL_ prefix 4. Add function to translate response status to a string for more readable logging Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 13 - drivers/misc/mei/hbm.c| 67

[char-misc-next 11/11] mei: wd: fix stop completion failure

close system call so instead of using wait_event_interruptible_timeout we can use wait_event_timeout with reasonable 10 msecs timeout. Reported-by: Prarit Bhargava Signed-off-by: Tomas Winkler --- drivers/misc/mei/interrupt.c | 2 +- drivers/misc/mei/wd.c| 32

[char-misc-next 07/11] mei: use helper function to find me client by id

From: Alexander Usyskin We already have a helper to find me client by id, let's use it in all relevant places. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 62 +++ drivers/misc/mei/hbm.c

[char-misc-next 10/11] mei: wd: simplify wd_send command

Add reduce credits to wd_send to remove code repetition and simplify error handling Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/interrupt.c | 7 +++--- drivers/misc/mei/wd.c| 52 +++- 2 files changed, 30

[char-misc-next 05/11] mei: wd and amthif use mei_cl_ api for dis/connection

Connect wd and amthif through regular mei_cl_connect API as there is no reason to connect in asynchronous mode. Also use mei_cl_is_connected in order to protect flows instead of depending on wd_pending and amthif_timer Now we can remove all the special handling in hbm layer Signed-off-by: Tomas

[char-misc-next 08/11] mei: make return values consistent across the driver

From: Alexander Usyskin 1. Propagate ENOTTY to user space if the client is not present in the system 2. Use ETIME consistently on timeouts 3. Return EIO on write failures 4. Return ENODEV on recoverable device failures such as resets Signed-off-by: Alexander Usyskin Signed-off-by: Tomas

[char-misc-next 06/11] mei: fix potential read outside of array bounds

From: Alexander Usyskin Drop not-very-useful check and with this fix read on index that can be after array end. Cleanup search function as byproduct. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 23 ++- 1 file changed, 10

[char-misc-next 02/11 RESEND] mei: revamp writing slot counting

Since txe use doorbell and not circular buffer we have to cheat in write slot counting, txe always consume all the slots upon write. In order for it to work we need to track slots using mei_hbuf_empty_slots() instead of tracking it in mei layer Signed-off-by: Tomas Winkler --- drivers/misc/mei

[char-misc-next 00/11] mei fixes and cleanups

Alexander Usyskin (4): mei: hbm: revamp client connect and disconnection status mei: fix potential read outside of array bounds mei: use helper function to find me client by id mei: make return values consistent across the driver Tomas Winkler (7): mei: add mei_hbuf_acquire wrapper

[char-misc-next 01/11 RESEND] mei: add mei_hbuf_acquire wrapper

A client has to acquire host buffer before writing, we add lock like wrapper to replace the code snippet if (dev->hbuf_is_ready) dev->hbuf_is_ready = false; Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c| 7 +- drivers/misc/mei/client.c

[char-misc-next 1/2] mei: me: put pm callbacks under PM_SLEEP ifdef

not used [-Wunused-function] static int mei_me_pci_resume(struct device *device) Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/pci-me.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci

[char-misc-next 2/2] mei: txe: put pm callbacks under PM_SLEEP ifdef

PCI suspend resume callbacks should be defined under CONFIG_PM_SLEEP Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/pci-txe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/pci-txe.c b/drivers/misc/mei/pci-txe.c

[char-misc-next 0/3] mei support more devices

There is a new use case to support secondary head on mei devices hence we replace misc devices with char. Alexander Usyskin (2): mei: move from misc to char device mei: add WPT second mei interface Tomas Winkler (1): mei: sysfs: add Documentation mei class attributes Documentation/ABI

[char-misc-next 3/3] mei: add WPT second mei interface

From: Alexander Usyskin Add WPT second mei interface. In order for correct device numbering we add mei device interface id to to mei_cfg structure Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/hw-me.c | 5

[char-misc-next 2/3] mei: sysfs: add Documentation mei class attributes

Add sysfs attributes Documentation entries for /sys/class/mei Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- Documentation/ABI/testing/sysfs-class-mei | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-mei

[char-misc-next 1/3] mei: move from misc to char device

From: Alexander Usyskin We need to support more then one mei interface hence the simple misc devices is not longer an option. We use char device now with to not break application space we preserve /dev/mei for the first interface. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler

[char-misc 0/3] mei: me hw reset fixes

Tomas Winkler (3): mei: me: fix hw ready reset flow mei: me: drop harmful wait optimization mei: me: read H_CSR after asserting reset drivers/misc/mei/hw-me.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) -- 1.9.0 -- To unsubscribe from this list

[char-misc 1/3] mei: me: fix hw ready reset flow

We cleared H_RST for H_CSR on spurious interrupt generated when ME_RDY while cleared and not while ME_RDY is set. The spurious interrupt is not delivered on all platforms in this case the driver may fail to initialize. Cc: sta...@vger.kernel.org Signed-off-by: Tomas Winkler Signed-off-by

[char-misc-next 3/3] mei: me: read H_CSR after asserting reset

According the spec the host should read H_CSR again after asserting reset H_RST to ensure that reset was read by the firmware Cc: sta...@vger.kernel.org Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/hw-me.c | 12 1 file changed, 12 insertions

[char-misc 2/3] mei: me: drop harmful wait optimization

It my take time till ME_RDY will be cleared after the reset, so we cannot check the bit before we got the interrupt Cc: sta...@vger.kernel.org Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/hw-me.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[char-misc-next 1/2] mei: add per device configuration

From: Alexander Usyskin Add mei_cfg structure that holds per device configuration data and hooks, as the first step we add firmware status register offsets Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 34 ++-- drivers/misc/mei

[char-misc-next 2/2] mei: me: move probe quirk to cfg structure

Move quirk FW type detector to cfg structure Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 37 drivers/misc/mei/hw-me.h | 2 ++ drivers/misc/mei/mei_dev.h | 2 ++ drivers/misc/mei/pci-me.c | 47

[char-misc-next] mei: me: do not load the driver if the FW doesn't support MEI interface

FW type by examining Host FW status registers in order to unbind the driver. In this patch we are adding check for ME on Cougar Point, Lynx Point Devices Cc: stable # 3.10+ Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 5 + drivers/misc/mei/pci-me.c | 30

[char-misc-next 0/5] mei: corner cases bug fixes

Set of fixes that covers few corner cases Alexander Usyskin (5): mei: reset client connection state on timeout mei: start disconnect request timer consistently mei: don't schedule suspend in pm idle mei: nfc: clean nfc internal struct on host exit mei: fix return value on disconnect time

[char-misc-next 1/2] mei: extract fw status registers

From: Alexander Usyskin Fetch FW status registers, as they are important in in understanding of FW reset reasons Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 55 ++ drivers/misc/mei/hw-txe-regs.h

[char-misc-next 2/2] mei: make return values consistent across the driver

From: Alexander Usyskin Follow-up for bits missed in commit 7ca96aa278f8b9983184e318b06a0ed9ad0297b8 mei: make return values consistent across the driver Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c| 2 +- drivers/misc/mei/client.c | 5 ++--- 2

[char-misc] mei: ignore client writing state during cb completion

already written to the HW and we can safely complete it. Same pays for wait in poll handler, we do not have to check the state wake is done after completion list processing. Cc: sta...@vger.kernel.org Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/interrupt.c

[char-misc] mei: fix memory leak of mei_clients array

we never freed the mei_clients array on driver shutdown only on reset add mei_hbm_reset function that wraps the hbm cleanup Signed-off-by: Tomas Winkler --- This should go to stable but it doesn't apply cleanly using 'git am' so separate patches will be published drivers/misc/

[char-misc-next 3/3 V2] mei: add WPT second mei interface

From: Alexander Usyskin Add WPT second mei interface. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: use default pch configuration drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei

[char-misc-next 1/3 V2] mei: move from misc to char device

From: Alexander Usyskin We need to support more then one mei interface hence the simple misc devices is not longer an option In order not break the user space a device with pci function 0 need to be linked to /dev/mei Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: use

[char-misc-next 2/3 V2] mei: sysfs: add Documentation mei class attributes

Add sysfs attributes Documentation entries for /sys/class/mei Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V2: remove default device Documentation/ABI/testing/sysfs-class-mei | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/ABI

[char-misc-next 0/3 V2] mei support more devices

There is a new use case to support secondary head on mei devices hence we replace misc devices with char. V2: use dynamic minor number allocation Alexander Usyskin (2): mei: move from misc to char device mei: add WPT second mei interface Tomas Winkler (1): mei: sysfs: add Documentation

[char-misc 0/2] mei: memory leak fixes

A memory leak was detected in the mei driver, here are two fixes that should address that. I suggest this goes to stable as well Alexander Usyskin (2): mei: clear write cb from waiting list on reset mei: don't unset read cb ptr on reset drivers/misc/mei/client.c | 11 +-- 1 file ch

[char-misc 1/2] mei: clear write cb from waiting list on reset

From: Alexander Usyskin Clear write callbacks sitting in write_waiting list on reset. Otherwise these callbacks are left dangling and cause memory leak. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 10 +- 1 file changed, 9 insertions

[char-misc 2/2] mei: don't unset read cb ptr on reset

kmemleak_alloc+0x3c/0xa0 [] __kmalloc+0xe7/0x1d0 [] mei_io_cb_alloc_resp_buf+0x2e/0x60 [] mei_cl_read_start+0x12c/0x360 [] mei_read+0x103/0x4e0 [] vfs_read+0x89/0x160 [] SyS_read+0x4f/0x80 [] syscall_call+0x7/0xb [] 0x Signed-off-by: Alexander Usyskin Signed-off-by: To

[char-misc-next 4/8] mei: wd: host_init propagate error codes from called functions

Propagate error codes from called functions, they are correct. Signed-off-by: Tomas Winkler --- drivers/misc/mei/wd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/misc/mei/wd.c b/drivers/misc/mei/wd.c index b892143..9e35421 100644 --- a/drivers/misc

[char-misc-next 8/8] mei: print correct device state during unexpected reset

From: Alexander Usyskin Move the unexpected state print to the beginning of mei_reset, thus printing right state. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/init.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc

[char-misc-next 3/8] mei: nfc: fix memory leak in error path

The flow may reach the err label without freeing cl and cl_info cl and cl_info weren't assigned to ndev->cl and cl_info so they weren't freed in mei_nfc_free called on error path Cc: # 3.10+ Cc: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/nfc.c | 10 +

[char-misc-next 5/8] mei: bus: propagate error code returned by mei_me_cl_by_id

no need to change error code value returned by mei_me_cl_by_id, just propagate it on Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index cd2033c..4bc7d62 100644 --- a

[char-misc-next 7/8] mei: replace stray pr_debug with dev_dbg

From: Alexander Usyskin Driver better use dev_dbg, not pr_debug. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/pci-me.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c index 1bf300e

[char-misc-next 6/8] mei: mei_cl_link remove duplicated check for open_handle_count

Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 0ccc22c..87c96e4 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -299,12 +299,6 @@ int

[char-misc-next 1/8] mei: debugfs: validate dev is not null

make static analyzer happy and validate dev argument before dereferencing Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c index e3870f2..9162491

[char-misc-next 0/8] mei security fixes and cleanups

Tomas Winkler (6): mei: debugfs: validate dev is not null mei: hbm: validate client index is not exceeding allocated array size mei: nfc: fix memory leak in error path mei: wd: host_init propagate error codes from called functions mei: bus: propagate error code returned by mei_me_cl_by_id

[char-misc-next 2/8] mei: hbm: validate client index is not exceeding allocated array size

Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c index 9b3a0fb..0f5e8ca 100644 --- a/drivers/misc/mei/hbm.c +++ b/drivers/misc/mei/hbm.c @@ -228,8 +228,6 @@ static int

[char-misc-next] mei: fix compilation error with missing WATCHDOG_CORE

Kconfig is not transitive so INTEL_ME_TXE has to depend on WATCHDOG_CORE as well ERROR: "watchdog_unregister_device" [drivers/misc/mei/mei.ko] undefined! ERROR: "watchdog_register_device" [drivers/misc/mei/mei.ko] undefined! Reported-by: Fengguang Wu Signed-off-by: Tomas W

[char-misc-next] mei: add 9 series PCH mei device ids

And Lynx Point H Refresh and Wildcat Point LP device ids. Signed-off-by: Tomas Winkler --- V2: remove duplicated LPT entry drivers/misc/mei/hw-me-regs.h | 5 - drivers/misc/mei/pci-me.c | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/hw-me

[char-misc-next 06/14] mei: add mei_me_cl_by_uuid_id function

When handling dynamic clients there might be a race scenario in which two me clients with the same me address would be linked in the me clients list, therefore we need to search by both uuid and me address. Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 1 + drivers/misc/mei

[char-misc-next 04/14] mei: use list for me clients book keeping

To support dynamic addition/remove of clients it is more convenient to use list instead of static array Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 34 ++--- drivers/misc/mei/debugfs.c | 19 drivers/misc/mei/hbm.c | 116

[char-misc-next 03/14] mei: me_client lookup function to return me_client object

In order to support dynamic addition/removal of me clients we cannot It is incontinent to use static array and we can use list. As the first step we change the lookup function to return me client address instead of the index. Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 29

[char-misc-next 02/14] mei: use wrapper for simple hbm client message

Reduce few code lines by using wrappers for sending simple hbm client messages Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/misc/mei/hbm.c b/drivers/misc

[char-misc-next 03/14 V2] mei: me_client lookup function to return me_client object

: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/amthif.c | 29 +++-- drivers/misc/mei/bus.c| 10 +- drivers/misc/mei/client.c | 43 --- drivers/misc/mei/client.h | 5 +++-- drivers/misc/mei/hbm.c| 23

[char-misc-next 04/10] mei: debugfs: adjust print buffer

From: Alexander Usyskin In case of many me clients (15 and more) 1K buffer is not enough for full information print. Calculate buffer size according to real clients number. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 22

[char-misc-next 01/10] mei: enable adding more IOCTL handlers

Handle ioctls in a switch statement so we can add more commands easily Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 53 ++--- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei

[char-misc-next 03/10] mei: add hbm and pg state in devstate debugfs print

From: Alexander Usyskin Add hbm state, pg enablement and state to devstate file in debugfs (/mei/devstate) Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 7 ++- drivers/misc/mei/hbm.c | 16 drivers/misc/mei/hbm.h

[char-misc-next 09/10] mei: kill error message for allocation failure

There is no need to log memory allocation errors as this is already done by the memory subsystem. Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c| 4 +--- drivers/misc/mei/interrupt.c | 1 - drivers/misc/mei/main.c | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff

[char-misc-next 10/10] mei: move mei_hbm_hdr function from hbm.h the hbm.c

mei_hbm_hder helper function is only used in hbm.c so there is no need to define it in a header file Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 16 drivers/misc/mei/hbm.h | 9 - 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/misc

[char-misc-next 08/10] mei: nfc: fix style warning

fix style warning: void function return statements are not generally useful Signed-off-by: Tomas Winkler --- drivers/misc/mei/nfc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/mei/nfc.c b/drivers/misc/mei/nfc.c index 2888e6f..8cc93e4 100644 --- a/drivers/misc/mei/nfc.c +++ b

[char-misc-next 05/10] mei: debugfs: add single buffer indicator

Add indication whether the client operates in single buffer mode Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c index ca2a12d..be16c4b 100644 --- a

[char-misc-next 07/10] mei: fix style warning: Missing a blank line after declarations

fix new style warning: Missing a blank line after declarations Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 1 + drivers/misc/mei/client.c | 1 + drivers/misc/mei/debugfs.c | 1 + drivers/misc/mei/hbm.c | 5 + drivers/misc/mei/hw-me.c | 12 drivers

[char-misc-next 06/10] mei: pg: fix cat and paste error in comments

Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/hw-me.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index 498bd42..241eae5 100644 --- a/drivers/misc/mei/hw-me.c +++ b/drivers/misc

[char-misc-next 02/10] mei: use connect_data on the stack

There is no need for dynamic allocation for connect_data. We can use variable on the stack and make code less error prone and simple Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/misc

[char-misc-next 10/10] mei: move mei_hbm_hdr function from hbm.h the hbm.c

mei_hbm_hder helper function is only used in hbm.c so there is no need to define it in a header file Signed-off-by: Tomas Winkler --- V2: fix kdoc drivers/misc/mei/hbm.c | 16 drivers/misc/mei/hbm.h | 9 - 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a

[char-misc-next 01/14] mei: use consistently me_addr in the hbm structures

Use consistently me_addr name in hbm protocol structures to represent in firmware client address Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/hbm.c | 6 +++--- drivers/misc/mei/hw.h | 5 ++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a

[char-misc-next 13/14] mei: enable adding more IOCTL handlers

Handle ioctls in a switch statement so we can add more commands easily Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 53 ++--- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei

[char-misc-next 10/14] mei: wait for hbm start non-interruptible

Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 26 -- drivers/misc/mei/hbm.h | 6 -- drivers/misc/mei/init.c| 2 +- drivers/misc/mei/mei_dev.h | 2 +- 4 files changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/misc/mei

[char-misc-next 11/14] mei: simplify handling of hbm client events

Add mei_hbm_cl_find_by_cmd handler to retrieve the destination client Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 74 +- 1 file changed, 43 insertions(+), 31 deletions(-) diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c

[char-misc-next 08/14] mei: use disconnect name consistently

Rename mei_cl_irq_close to mei_cl_irq_disconnect and MEI_FOP_CLOSE to MEI_FOP_DISCONNECT Remove unused MEI_FOP_OPEN Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c| 3 ++- drivers/misc/mei/interrupt.c | 8 drivers/misc/mei/mei_dev.h | 6 ++ 3 files changed, 8

[char-misc-next 12/14] mei: extract supported features from the hbm version

extract supported hbm features and commands from the hbm version Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 25 - drivers/misc/mei/hw-me.c | 6 +- drivers/misc/mei/mei_dev.h | 4 3 files changed, 29 insertions(+), 6 deletions(-) diff

[char-misc-next 14/14] mei: use connect_data on the stack

There is no need for dynamic allocation for connect_data. We can use variable on the stack and make code less error prone and simple Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/misc

[char-misc-next 09/14] mei: revamp connect and disconnect response handling

Both responses have same flow only the client status update is different. We introduce handler mei_hbm_cl_res() that handles both responses Also we use per client wait queue (cl->wait) rather then global dev->wait_recvd_msg Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c

[char-misc-next 05/14] mei: add me client remove functions

To support dynamic addition/remove we add wrappers for removal of me clients Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 22 +- drivers/misc/mei/client.h | 2 ++ drivers/misc/mei/hbm.c| 21 +++-- 3 files changed, 38 insertions(+), 7

[char-misc-next 07/14] mei: add hbm commands return status values

HBM uses global list of status values from which the values of particular commands are derived Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 22 -- drivers/misc/mei/hw.h | 39 +-- 2 files changed, 53 insertions(+), 8 deletions

[char-misc-next 0/6] mei: remove pci dependency from mei module

In order to support testing hw module we remove dependency on pci from mei module Tomas Winkler (6): mei: push all standard settings into mei_device_init mei: get rid of most of the pci dependencies in mei mei: move fw_status back to hw ops handlers mei: remove the reference to pdev from

[char-misc-next 4/6] mei: remove the reference to pdev from mei_deivce

For purpose of adding testing HW we would like to get rid of pci dependency in generic mei code. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 3 +-- drivers/misc/mei/hw-txe.c | 3 +-- drivers/misc/mei/mei_dev.h | 2 -- drivers/misc/mei/pci-me.c | 2 +- drivers/misc/mei/pci

[char-misc-next 6/6] mei: remove include to pci header from mei module files

Remove inclusion of linux/pci.h in mei layer however we need to include the headers that before got included implicitly from linux/pci.h. Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c| 2 +- drivers/misc/mei/bus.c | 1 - drivers/misc/mei/client.c| 2 +- drivers/misc

[char-misc-next 3/6] mei: move fw_status back to hw ops handlers

fw status retrieval has pci specific implementation so we push it back to the hw layer Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 28 drivers/misc/mei/hw-txe.c | 30 ++ drivers/misc/mei/init.c| 21

[char-misc-next 1/6] mei: push all standard settings into mei_device_init

Setting of hw_ops and device has should be in mei_device_init. We add reference to the parent device and remove pci dependent cfg Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/hw-me.c | 6 ++ drivers/misc/mei/hw-txe.c | 5 ++--- drivers/misc/mei

[char-misc-next 5/6] mei: push pci cfg structure me hw

Device specific configurations are currently only needed by me hw so we can remove it from txe Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 7 +-- drivers/misc/mei/hw-me.h | 26 +- drivers/misc/mei/hw-txe.c | 22 +++--- drivers

[char-misc-next 2/6] mei: get rid of most of the pci dependencies in mei

For purpose of adding testing HW we would like to get rid of pci dependency in generic mei code This patch provides only straight forward changes FW status and prob quirks need to be handled separately Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c| 68

[char-misc-next] mei: me: wait for hw ready non-interruptible

From: Alexander Usyskin We cannot handle user interrupt in context of hw initialization so we only wait for time out which is reasonably short Also we don't need to check error from wait, only flag value. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/m

[char-misc-next 0/2] mei: amthif simplifications

Alexander Usyskin (2): mei: amthif: use service function to flush amthif queue mei: amthif: don't check amthif client identity on amthif queues drivers/misc/mei/amthif.c| 37 +++-- drivers/misc/mei/client.c| 2 +- drivers/misc/mei/client.h| 2 ++

[char-misc-next 1/2] mei: amthif: use service function to flush amthif queue

From: Alexander Usyskin Replace open coded loop with an existing service function: mei_io_list_flush Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c| 2 +- drivers/misc/mei/client.h| 2 ++ drivers/misc/mei/interrupt.c | 13

[char-misc-next 2/2] mei: amthif: don't check amthif client identity on amthif queues

From: Alexander Usyskin Amthif has its own queues therefore it is redundant to check the client type when processing the queues Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 37 +++-- 1 file changed, 15

[char-misc 3.10 backport] mei: bus: fix possible boundaries violation

operations. Replace strncpy with strlcpy. Cc: sta...@vger.kernel.org # 3.10 Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Signed-off-by: Greg Kroah-Hartman --- drivers/misc/mei/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/dr

[char-misc V4 3.18] mei: nfc: clean nfc internal struct on host exit

NFC internal structure cleaning was dropped by commit commit 487056932d372cc4f6c636f21a928d6667b151d7 Author: Tomas Winkler Date: Mon Feb 17 15:13:19 2014 +0200 mei: Remove all bus devices from the mei_dev list when stopping the MEI When stopping the MEI, we should remove and

[char-misc-next] mei: fix hbm MEI_HBM_STARTED ambiguity

We have MEI_HBM_STARTED in two contexts one after start message was received and second after enumeration was completed. Because after start message reception we move immediately to the enumeration state, we need only the later meaning. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c

[char-misc V5 3.18] mei: nfc: clean nfc internal struct on host exit

NFC internal structure cleaning was dropped by commit commit 487056932d372cc4f6c636f21a928d6667b151d7 Author: Tomas Winkler Date: Mon Feb 17 15:13:19 2014 +0200 mei: Remove all bus devices from the mei_dev list when stopping the MEI When stopping the MEI, we should remove and

[char-misc V5 3.18] mei: nfc: clean nfc internal struct on host exit

NFC internal structure cleaning was dropped by commit commit 487056932d372cc4f6c636f21a928d6667b151d7 Author: Tomas Winkler Date: Mon Feb 17 15:13:19 2014 +0200 mei: Remove all bus devices from the mei_dev list when stopping the MEI When stopping the MEI, we should remove and

[char-misc-next] mei: hbm: use client specific print functions

From: Alexander Usyskin We have host client in connect/disconnect response processors, so use client print functions to simplify and unify code. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 16 1 file changed, 8 insertions(+), 8

[char-misc-next] mei: debugfs: display also connectionless clients

meiX/meclients: display also fixed/connectionless clients Use better name for fixed client field: fixed_address is boolean and indicates whether a client is fixed or dynamic. Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[char-misc-next] mei: add reference counting for me clients

To support dynamic addition/remove we add reference counter. Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 14 +++--- drivers/misc/mei/bus.c | 39 +-- drivers/misc/mei/client.c | 122 - drivers/misc/mei/client.h

[char-misc-next V2] mei: add reference counting for me clients

To support dynamic addition/remove we add reference counter. Signed-off-by: Tomas Winkler --- V2: code style and documentation fixes drivers/misc/mei/amthif.c | 14 ++--- drivers/misc/mei/bus.c | 39 -- drivers/misc/mei/client.c | 126

[char-misc-next V2] mei: nfc: clean nfc internal struct on host exit

NFC internal structure cleaning was dropped by commit commit 5ad1550a15cd5b75ed8aa3009e162822f720375e Author: Tomas Winkler Date: Sun Jan 26 11:53:06 2014 +0200 mei: Remove all bus devices from the mei_dev list when stopping the MEI We allocate nfc_dev and free it across the reset so we

[char-misc-next 1/2] mei: drop unneeded client NULL check in cb structure

From: Alexander Usyskin The pointer to client in the callback structure (cb->cl) can't be NULL with current locking. We can drop check and warnings as in some cases this just uselessly complicates the code flow. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- driv

[char-misc-next 2/2] mei: use local cl variables in wd and amthif

Use local cl variable instead of dev->iamthif_cl and dev->wd_cl as the first step to use dynamic allocation of these clients as their are not supported on all platforms Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 10 ++ drivers/misc/mei/wd.c | 9 ++--- 2

[char-misc-next V3] mei: add reference counting for me clients

To support dynamic addition/remove we add reference counter. Signed-off-by: Tomas Winkler --- V2: code style and documentation fixes V3: 1. Use refcounter also in mei_me_cl_rm_all, 2. Replace mei_me_cl_rm_by_id with mei_me_cl_rm_by_uuid_id 3. Few more doc fixes drivers/misc

<    3   4   5   6   7   8   9   10   11   12   >