[char-misc-next] mei: txe: reduce suspend/resume time

2015-04-14 Thread Tomas Winkler
HW has to be in known state before the initialisation sequence is started. The polling step for settling aliveness was set to 200ms while in practise this can be done in up to 30msecs. Cc: #3.18+ Signed-off-by: Tomas Winkler Signed-off-by: Barak Yoresh --- drivers/misc/mei/hw-txe.c | 20

[char-misc-next] mei: trace: remove unused TRACE_SYSTEM_STRING

2015-04-13 Thread Tomas Winkler
: warning: "TRACE_SYSTEM_STRING" redefined Cc: Stephen Rothwell Reported-by: Stephen Rothwell Signed-off-by: Tomas Winkler --- drivers/misc/mei/mei-trace.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/mei/mei-trace.h b/drivers/misc/mei/mei-trace.h index 5f

[char-misc-next] mei: use module_pci_driver

2012-07-17 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 39 +-- 1 files changed, 1 insertions(+), 38 deletions(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 0d98c2e..0923302 100644 --- a/drivers/misc/mei/main.c +++ b/drivers

[char-misc-next] mei: use module_pci_driver

2012-07-17 Thread Tomas Winkler
Change-Id: I960feed4157ad1b178f68f4a0b3968e185ed0b36 Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 39 +-- 1 files changed, 1 insertions(+), 38 deletions(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 0d98c2e..0923302

[char-misc-next V2] mei: use module_pci_driver

2012-07-18 Thread Tomas Winkler
use module_pci_driver() macro to wrap standard pci module registration into a single line Signed-off-by: Tomas Winkler --- V2: verboser commit message drivers/misc/mei/main.c | 39 +-- 1 files changed, 1 insertions(+), 38 deletions(-) diff --git a/drivers

[char-misc] mei: me: wait for power gating exit confirmation

2015-06-12 Thread Tomas Winkler
: https://bugzilla.kernel.org/show_bug.cgi?id=86241 Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770397 Tested-by: Gabriele Mazzotta Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 2 +- drivers/misc/mei/hw-me.c | 59

[char-misc] mei: reset flow control on the last client disconnection

2015-06-13 Thread Tomas Winkler
From: Alexander Usyskin The FW resets the flow control for single buffer clients when the last host client disconnects, also the driver has to follow this policy and zero the flow control counter in such case. Cc: #4.1 Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler

[char-misc-next 05/17] mei: bus: move driver api functions at the start of the file

2015-06-13 Thread Tomas Winkler
To make the file more organize move mei client driver api to the start of the file and add Kdoc There are no functional changes in this patch Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 798 +++-- 1 file changed, 443 insertions(+), 355

[char-misc-next 04/17] mei: bus: rename nfc.c to bus-fixup.c

2015-06-13 Thread Tomas Winkler
In nfc.c we just create device name on the mei client bus we make it more generic in the following patches Signed-off-by: Tomas Winkler --- drivers/misc/mei/Makefile | 2 +- drivers/misc/mei/{nfc.c => bus-fixup.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename driv

[char-misc-next 02/17] mei: bus: fix drivers and devices names confusion

2015-06-13 Thread Tomas Winkler
the variables of type mei_cl_device are now cldev the variables of type mei_cl_driver are now cldrv the variables of type mei_device are now bus in the bus layer context Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 272 ++--- drivers/misc

[char-misc-next 00/17] revamp mei bus

2015-06-13 Thread Tomas Winkler
MEI bus was designed around nfc and was hard to extend. Instead of hard coded way of adding the devices on the mei bus we scan whole me client list and create a device for each eligible me client Tomas Winkler (17): MAINTAINERS: mei: add mei_cl_bus.h to maintained file list mei: bus: fix

[char-misc-next 03/17] mei: bus: rename device_list to simple devices

2015-06-13 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 4 ++-- drivers/misc/mei/init.c| 2 +- drivers/misc/mei/mei_dev.h | 5 ++--- drivers/misc/mei/nfc.c | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index

[char-misc-next 01/17] MAINTAINERS: mei: add mei_cl_bus.h to maintained file list

2015-06-13 Thread Tomas Winkler
mei_cl_bus.h was overlooked when we added the mei bus Signed-off-by: Tomas Winkler --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f6ba62c3db82..c58e2f0612e7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5279,6 +5279,7 @@ M:Tomas

[char-misc-next 07/17] mei: bus: don't enable events implicitly in device enable

2015-06-13 Thread Tomas Winkler
Always call mei_cl_register_event_cb explicitly so the events are enabled only when needed. The nfc driver is already using it that way so no need for further changes. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/misc/mei

[char-misc-next 09/17] mei: bus: simplify device matching

2015-06-13 Thread Tomas Winkler
mei_cl_device_match now calls mei_cl_device_find that returns the matching device id in the device id table Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 63 +++--- 1 file changed, 44 insertions(+), 19 deletions(-) diff --git a/drivers

[char-misc-next 08/17] mei: bus: report if event registration failed

2015-06-13 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 9069d89b93d7..5bd16d4417bb 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -255,6 +255,8

[char-misc-next 13/17] mei: bus: enable running fixup routines before device registration

2015-06-13 Thread Tomas Winkler
ff-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 30 +++ drivers/misc/mei/bus.c | 91 drivers/misc/mei/mei_dev.h | 2 +- include/linux/mei_cl_bus.h | 4 ++ 4 files changed, 111 insertions(+), 16 deletions(-) diff --git a/dr

[char-misc-next 12/17] mei: bus: add me client device list infrastructure

2015-06-13 Thread Tomas Winkler
appropriate mei_cl_device was already created and is_added flag to mei_cl_device to track if it was already added to the list across the bus rescans Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 1 + drivers/misc/mei/init.c| 1 + drivers/misc/mei/mei_dev.h | 6 -- include

[char-misc-next 11/17] mei: bus: add reference to bus device in struct mei_cl_client

2015-06-13 Thread Tomas Winkler
Add reference to the bus device (mei_device) for easier access. To ensures that referencing cldev->bus is valid during cldev life time we increase the bus ref counter on a client device creation and drop it on the device release. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c |

[char-misc-next 14/17] mei: bus: blacklist clients by number of connections and nfc info client

2015-06-13 Thread Tomas Winkler
Currently we support only clients with single connection and fixed address clients so all other clients are blacklisted Blacklist nfc info client which is only used for retrieval of the NFC radio version Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 42

[char-misc-next 10/17] mei: bus: revamp probe and remove functions

2015-06-13 Thread Tomas Winkler
Instead of generating device id on the fly during probing we find the matching id entry on the device id table. Get bus the module reference counter so it cannot be unloaded after the driver has bounded to the client device Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 41

[char-misc-next 17/17] mei: bus: link client devices instead of host clients

2015-06-13 Thread Tomas Winkler
address clients. NFC radio name detection is run as a fixup routine The patch replaces handling the device list based on struct me_cl to device list based on me_cl_devices. The creating a connection is pushed from the device creation time to device enablement. Signed-off-by: Tomas Winkler --- drivers

[char-misc-next 15/17] mei: bus: simplify how we build nfc bus name

2015-06-13 Thread Tomas Winkler
we will need this simplification when name build will be just part of the fixup rutine Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 116 --- drivers/misc/mei/bus.c | 2 +- drivers/misc/mei/mei_dev.h | 2 +- 3 files changed

[char-misc-next 06/17] mei: bus: add kdoc for device attribute functions

2015-06-13 Thread Tomas Winkler
1. Rename uevent handler to mei_cl_device_uevent 2. Add kdoc for uevent and mod alias functions Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/bus.c b

[char-misc-next 16/17] mei: bus: also unregister the driver when removing the device

2015-06-13 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index fa3eff216eff..33898bed6209 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers

[char-misc-next 14/15 V2] mei: bus: simplify how we build nfc bus name

2015-06-15 Thread Tomas Winkler
Remove the dependency on struct ndev from the nfc device name creation function so it is possible to use it in a fixup routine Signed-off-by: Tomas Winkler --- V2: Fix the commit message drivers/misc/mei/bus-fixup.c | 115 --- drivers/misc/mei/bus.c

[char-misc-next 12/15] mei: bus: blacklist the nfc info client

2015-06-15 Thread Tomas Winkler
Blacklist nfc info client which is only used for retrieval of the NFC radio version Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus

[char-misc-next 09/15 V2] mei: bus: add reference to bus device in struct mei_cl_client

2015-06-15 Thread Tomas Winkler
Add reference to the bus device (mei_device) for easier access. To ensures that referencing cldev->bus is valid during cldev life time we increase the bus ref counter on a client device creation and drop it on the device release. Signed-off-by: Tomas Winkler --- V2: resend drivers/misc/

[char-misc-next 05/15 V2] mei: bus: don't enable events implicitly in device enable

2015-06-15 Thread Tomas Winkler
-off-by: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 63bd9ad24380..3756f4687292 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -331,9 +331,6

[char-misc-next 01/15 V2] mei: bus: fix drivers and devices names confusion

2015-06-15 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/bus.c | 272 ++--- drivers/misc/mei/mei_dev.h | 12 +- drivers/misc/mei/nfc.c | 80 ++--- 3 files changed, 182 insertions(+), 182 deletions(-) diff --git a

[char-misc-next 15/15 V2] mei: bus: link client devices instead of host clients

2015-06-15 Thread Tomas Winkler
address clients. NFC radio name detection is run as a fixup routine The patch replaces handling the device list based on struct me_cl to device list based on me_cl_devices. The creating a connection is pushed from the device creation time to device enablement. Signed-off-by: Tomas Winkler --- V2

[char-misc-next 13/15] mei: bus: blacklist clients by number of connections

2015-06-15 Thread Tomas Winkler
Currently we support only clients with single connection and fixed address clients so all other clients are blacklisted Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers

[char-misc-next 11/15 V2] mei: bus: enable running fixup routines before device registration

2015-06-15 Thread Tomas Winkler
at the end the device won't be registered on the bus. Signed-off-by: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/bus-fixup.c | 30 +++ drivers/misc/mei/bus.c | 91 drivers/misc/mei/mei_dev.h | 2 +- include/

[char-misc-next 00/15 V2] revamp mei bus

2015-06-15 Thread Tomas Winkler
bring substantial changes. Split few patches to follow single change per patch policy. Tomas Winkler (15): mei: bus: fix drivers and devices names confusion mei: bus: rename nfc.c to bus-fixup.c mei: bus: move driver api functions at the start of the file mei: bus: rename uevent handl

[char-misc-next 10/15 V2] mei: bus: add me client device list infrastructure

2015-06-15 Thread Tomas Winkler
appropriate mei_cl_device was already created and is_added flag to mei_cl_device to track if it was already added to the device list across the bus rescans Signed-off-by: Tomas Winkler --- V2: Resend drivers/misc/mei/bus.c | 1 + drivers/misc/mei/init.c| 1 + drivers/misc/mei/mei_dev.h | 6

[char-misc-next 07/15 V2] mei: bus: revamp device matching

2015-06-15 Thread Tomas Winkler
mei_cl_device_match now calls mei_cl_device_find that returns the matching device id in the device id table. We will utilize the mei_cl_device_find during probing to locate the matching entry. Signed-off-by: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/bus.c | 63

[char-misc-next 03/15 V2] mei: bus: move driver api functions at the start of the file

2015-06-15 Thread Tomas Winkler
To make the file more organize move mei client driver api to the start of the file and add Kdoc. There are no functional changes in this patch. Signed-off-by: Tomas Winkler --- V2: Resend drivers/misc/mei/bus.c | 798 +++-- 1 file changed, 443

[char-misc-next 06/15 V2] mei: bus: report if event registration failed

2015-06-15 Thread Tomas Winkler
If event registeration has failed, the caller should know about it. Signed-off-by: Tomas Winkler --- V2: fix the commit message drivers/misc/mei/bus.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 3756f4687292

[char-misc-next 04/15] mei: bus: rename uevent handler to mei_cl_device_uevent

2015-06-15 Thread Tomas Winkler
Rename mei_cl_uevent to mei_cl_device_uevent to match the naming convention of mei_cl_bus_type functions Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c

[char-misc-next 08/15 V2] mei: bus: revamp probe and remove functions

2015-06-15 Thread Tomas Winkler
Instead of generating device id on the fly during probing we find the matching id entry on the device id table. Get bus the module reference counter so it cannot be unloaded after the driver has bounded to the client device Signed-off-by: Tomas Winkler --- V2: Resend drivers/misc/mei/bus.c | 41

[char-misc-next 02/15 V2] mei: bus: rename nfc.c to bus-fixup.c

2015-06-15 Thread Tomas Winkler
The bus-fixup.c will be a place for fixups and quirks for all types of me client devices. As for now it contians only the fixup for setting the nfc device name on the me client bus. Signed-off-by: Tomas Winkler --- drivers/misc/mei/Makefile | 2 +- drivers/misc/mei/{nfc.c =>

[char-misc-next 2/2] mei: disconnect on connection request timeout

2015-06-16 Thread Tomas Winkler
From: Alexander Usyskin For the FW with HBM version >= 2.0 we don't need to reset the whole device in case of a particular client failing to connect, it is enough to send disconnect a request to bring the device to the stable state. Signed-off-by: Alexander Usyskin Signed-off-b

[char-misc-next 1/2] mei: support for dynamic clients

2015-06-16 Thread Tomas Winkler
allow_add field in enum_req 2. A new client is added upon reception of MEI_HBM_ADD_CLIENT_REQ_CMD 3. A client is removed in a lazy manner when connection request respond with MEI_HBMS_CLIENT_NOT_FOUND status Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 2 + drivers/misc/mei/hbm.c

[char-misc-next 3/9] mei: enable async event notifications only from hbm version 2.0

2015-06-24 Thread Tomas Winkler
Only FW version 2.0 and newer support the async event notification. For backward compatibility block the feature if the FW version is older then 2.0 Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/debugfs.c | 2 ++ drivers/misc/mei/hbm.c | 4 drivers

[char-misc-next 5/9] mei: add a handler that waits for notification on event

2015-06-24 Thread Tomas Winkler
mei_cl_notify_get is to be called by a host client to wait, receive, and ack the event notification. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/client.c | 51 ++ drivers/misc/mei/client.h | 1 + drivers/misc

[char-misc-next 4/9] mei: add mei_cl_notify_request command

2015-06-24 Thread Tomas Winkler
Add per client notification request infrastructure that allows client to enable or disable async event notification. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/client.c| 143 +++ drivers/misc/mei/client.h

[char-misc-next 7/9] mei: support polling for event notification

2015-06-24 Thread Tomas Winkler
Polling on priority events is translated on waiting for event notification. One need to enable notification prior for calling select or poll system call otherwise process will not wait. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/main.c | 8 1

[char-misc-next 9/9] mei: bus: add and call callback on notify event

2015-06-24 Thread Tomas Winkler
From: Alexander Usyskin Enable drivers on mei client bus to subscribe to asynchronous event notifications. Introduce events_mask to the existing callback infrastructure so it is possible to handle both RX and event notification. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler

[char-misc-next 8/9] mei: implement fasync for event notification

2015-06-24 Thread Tomas Winkler
A process can be informed about client notification also via SIGIO with POLL_PRI event. Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 28 drivers/misc/mei/client.h | 1 + drivers/misc/mei/hbm.c | 7 ++- drivers/misc/mei/main.c| 21

[char-misc-next 6/9] mei: add async event notification ioctls

2015-06-24 Thread Tomas Winkler
Add ioctl IOCTL_MEI_NOTIFY_SET for enabling and disabling async event notification. Add ioctl IOCTL_MEI_NOTIFY_GET for receiving and acking an event notification. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- Documentation/ioctl/ioctl-number.txt | 2 ++ Documentation

[char-misc-next 2/9] mei: implement async notification hbm messages

2015-06-24 Thread Tomas Winkler
Implement sending and reception handlers for the async event notification hbm commands. Add client notification book keeping data required for the messages notify_en to indicate whether notification is enabled notify_ev to indicate whether an event is pending Signed-off-by: Tomas Winkler

[char-misc-next 0/9] mei: support for async event notifications

2015-06-24 Thread Tomas Winkler
space to enable/disable and consume the event notifications. The asynchronous nature is provided via poll and fasync. Alexander Usyskin (1): mei: bus: add and call callback on notify event Tomas Winkler (8): mei: define async notification hbm commands mei: implement async notificatio

[char-misc-next 1/9] mei: define async notification hbm commands

2015-06-24 Thread Tomas Winkler
o the event notification via designated HBM commands, and also the notification is carried on a new HBM command. This patch adds definitions of asynchronous notification HBM commands. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 62 +++ 1

[char-misc] mei: prevent unloading mei hw modules while the device is opened.

2015-06-18 Thread Tomas Winkler
chrdev_open() increases reference counter on cdev->owner. Instead of assigning the owner to mei subsystem, the owner has to be set to the underlaying HW module (mei_me or mei_txe), so once the device is opened the HW module cannot be unloaded. Cc: #3.17+ Signed-off-by: Tomas Winkler Signed-

[PATCH 1/2 v6] tpm: cmd_ready command can be issued only after granting locality

2018-03-01 Thread Tomas Winkler
dling. The issue is only visible on devices that support multiple localities. Fixes: 877c57d0d0ca ("tpm_crb: request and relinquish locality 0") Signed-off-by: Tomas Winkler --- V2: 1. Poll for locality relinquish completion. V3: 1. Print error message upon locality relinquish failu

[char-misc 1/2] mei: remove unused MEI_IAMTHIF_STALL_TIMER define

2018-06-06 Thread Tomas Winkler
From: Alexander Usyskin MEI_IAMTHIF_STALL_TIMER is unused now and can be safely removed. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h index

[char-misc 2/2] mei: discard messages from not connected client during power down.

2018-06-06 Thread Tomas Winkler
flow") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199541 Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/interrupt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.

[char-misc 0/2] mei; updates for 4.18-rc2

2018-06-06 Thread Tomas Winkler
A bug for long lasting regression and trivial cleanup. Hope this can make its way to 4.18. Alexander Usyskin (2): mei: remove unused MEI_IAMTHIF_STALL_TIMER define mei: discard messages from not connected client during power down. drivers/misc/mei/hw.h| 2 -- drivers/misc/mei/interru

[PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-16 Thread Tomas Winkler
ready command can be issued only after granting locality) Signed-off-by: Tomas Winkler --- V2:resent V3:resent V4: 1. Use tpm_pm_suspend/resume in tpm_crb 2. Drop cmd_ready/go_idle around tpm_chip_register, as there is no usage counter like in runtime_pm. V5: 1. add tpm_cmd_ready and tpm_go

[char-misc-next 1/2] mei: bus: block send with vtag on non-conformat FW

2021-02-08 Thread Tomas Winkler
From: Alexander Usyskin Block data send with vtag if either transport layer or FW client are not supporting vtags. Cc: # v5.10+ Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc

[char-misc-next 2/2] mei: use sysfs_emit() in tx_queue_limit_show sysfs

2021-02-08 Thread Tomas Winkler
Using of snprintf is discouraged in sysfs use the new sysfs_emit() API. Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 9f6682033ed7..28937b6e7e0c 100644 --- a

[PATCH] mtd: mtdcore: constify name param in mtd_bdi_init

2021-02-25 Thread Tomas Winkler
The bdi name is not modified by the function, it should be const. Signed-off-by: Tomas Winkler --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index db5167eacaa4..80fb69453ebe 100644 --- a/drivers/mtd

[char-misc-next] MAINTAINERS: Fix maintainer entry for mei driver

2020-07-29 Thread Tomas Winkler
mei driver has sub modules, those are not listed via scripts/get_maintainer.pl when using asterisk: drivers/misc/mei/* The correct notation is: drivers/misc/mei/ Cc: Joe Perches Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1

[char-misc-next] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-29 Thread Tomas Winkler
. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/hdcp/mei_hdcp.c | 38 ++-- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index d1d3e025ca0e..0e8f12e38494 100644 --- a/drivers

[char-misc-next V2] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-30 Thread Tomas Winkler
: Replace one-element array with flexible-array member) Cc: Ramalingam C Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- V2: Check for allocation failure. drivers/misc/mei/hdcp/mei_hdcp.c | 40 +++- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a

[char-misc-next V3] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-30 Thread Tomas Winkler
of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: 0a1af1b5c18d ("misc/mei/hdcp: Verify M_prime") Cc: "Gustavo A. R. Silva" Cc: Ramalingam C Cc: v5.1+ Signed-off-by: Tomas Winkler --- V3: 1. Fix commit mes

[char-misc-next] mei: hdcp: fix mei_hdcp_verify_mprime() input parameter

2020-07-30 Thread Tomas Winkler
of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: commit 0a1af1b5c18d ("misc/mei/hdcp: Verify M_prime") Cc: "Gustavo A. R. Silva" Cc: Ramalingam C Cc: v5.1+ Signed-off-by: Tomas Winkler --- V4: 1.

[char-misc-next V4] mei: hdcp: fix mei_hdcp_verify_mprime() input parameter

2020-07-30 Thread Tomas Winkler
of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: commit 0a1af1b5c18d ("misc/mei/hdcp: Verify M_prime") Cc: "Gustavo A. R. Silva" Cc: Ramalingam C Cc: v5.1+ Signed-off-by: Tomas Winkler --- V4: 1.

[char-misc V5] mei: hdcp: fix mei_hdcp_verify_mprime() input parameter

2020-08-18 Thread Tomas Winkler
of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: 0a1af1b5c18d (misc/mei/hdcp: Verify M_prime) Cc: # v5.1+: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Signed-off-by: Tomas Winkler Reviewed

[char-misc-next 00/13] mei: add support for virtual tags

2020-08-18 Thread Tomas Winkler
ioctl Tomas Winkler (3): mei: add support for mei extended header. mei: docs: add vtag ioctl documentation mei: virtio: virtualization frontend driver Documentation/ABI/testing/sysfs-bus-mei | 7 + Documentation/driver-api/mei/mei.rst| 37 + drivers/misc/mei/Kconfig

[char-misc-next 01/13] mei: hbm: add capabilities message

2020-08-18 Thread Tomas Winkler
requested capability is supported. Bump copyright year in affected files. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 1 + drivers/misc/mei/hbm.c | 72 ++ drivers/misc/mei/hbm.h | 2 ++ drivers/misc

[char-misc-next 03/13] mei: add vtag support bit in client properties

2020-08-18 Thread Tomas Winkler
@@ Contact: Tomas Winkler Description: Stores mei client fixed address, if any Format: %d +What: /sys/bus/mei/devices/.../vtag +Date: Nov 2020 +KernelVersion: 5.9 +Contact: Tomas Winkler +Description: Stores mei client vtag support status

[char-misc-next 02/13] mei: restrict vtag support to hbm version 2.2

2020-08-18 Thread Tomas Winkler
the series bisectable. Everything will be enabled when driver HBM version is set to 2.2. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 1 + drivers/misc/mei/hbm.c | 15 +++ drivers/misc/mei/hw.h | 9 + drivers/misc

[char-misc-next 07/13] mei: add a vtag map for each client

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Vtag map is a list of tuples of vtag and file pointer (struct mei_cl_vtag) associated with a particular me host client. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 168 - drivers

[char-misc-next 05/13] mei: bump hbm version to 2.2

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Bump HBM version to 2.2 to indicate vtag support. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h index

[char-misc-next 13/13] mei: virtio: virtualization frontend driver

2020-08-18 Thread Tomas Winkler
each mei vritio device. The backend service is available in ACRN device-model at github. For more information, please refer to https://projectacrn.org The ACRN virtio sub device id for MEI is is 0x8602. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Signed-off-by: Wang Yu Signed

[char-misc-next 11/13] mei: add connect with vtag ioctl

2020-08-18 Thread Tomas Winkler
parameter is the properties of the FW client Clients that do not support tagged connection will respond with -EOPNOTSUPP Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 210 --- include/uapi/linux/mei.h | 49

[char-misc-next 10/13] mei: bus: unconditionally enable clients with vtag support

2020-08-18 Thread Tomas Winkler
: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 07ba16d46690..4e30fa98fe7d 100644 --- a/drivers/misc/mei/bus-fixup.c +++ b/drivers/misc/mei

[char-misc-next 12/13] mei: docs: add vtag ioctl documentation

2020-08-18 Thread Tomas Winkler
Add structured documenation for the new vtag ioctl Signed-off-by: Tomas Winkler --- Documentation/driver-api/mei/mei.rst | 37 1 file changed, 37 insertions(+) diff --git a/Documentation/driver-api/mei/mei.rst b/Documentation/driver-api/mei/mei.rst index

[char-misc-next 09/13] mei: bus: use zero vtag for bus clients.

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The zero vtag is required for the read flow to work also for devices on the mei client bus. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 72 +- 1 file changed, 71 insertions(+), 1

[char-misc-next 04/13] mei: add support for mei extended header.

2020-08-18 Thread Tomas Winkler
only supported extension is the vtag. From the HW perspective the extended headers is already part of the payload. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/client.c| 189 --- drivers/misc/mei/hbm.c | 14

[char-misc-next 06/13] mei: add a spin lock to protect rd_completed queue

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin In order to support vtags we need to access read completed queue out of driver big lock. Add a spin lock to protect rd_completed queue. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6 ++--- drivers/misc/mei/client.c

[char-misc-next 08/13] mei: handle tx queue flushing for vtag connections

2020-08-18 Thread Tomas Winkler
. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 3904fce18261..d5c3f7d54634 100644 --- a/drivers

[watchdog] watchdog: mei_wdt: request stop on unregister

2021-01-07 Thread Tomas Winkler
From: Alexander Usyskin Send the stop command to the firmware on watchdog unregister to eleminate false event on suspend. Cc: Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/watchdog/mei_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog

[PATCH] mtd: intel-spi: add is_protected and is_bios_locked knobs

2021-03-30 Thread Tomas Winkler
manufacturing will need the both files in order to validate that the device is properly sealed. Cc: Mika Westerberg Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler Reviewed-by: Mika Westerberg --- .../ABI/testing/sysfs-devices-intel-spi | 16 MAINTAINERS

[PATCH v2] mtd: intel-spi: add is_protected and is_bios_locked knobs

2021-03-31 Thread Tomas Winkler
manufacturing will need the both files in order to validate that the device is properly sealed. Cc: Joe Perches Cc: Mika Westerberg Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler Reviewed-by: Mika Westerberg --- V2: Add a newline to the string format in sysfs_emit() (Joe Perches

[char-misc-next] mei: me: add Alder Lake P device id.

2021-04-13 Thread Tomas Winkler
Add Alder Lake P device ID. Cc: Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index 14be76d4c2e6..cb34925e10f1 100644 --- a

[PATCH] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-01 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- .../ABI/testing/sysfs-platform-intel-pmc | 11 +++ MAINTAINERS | 1 + drivers/platform/x86/intel_pmc_core.c | 95 +++ drivers/platform/x86/intel_pmc_core.h | 6 ++ 4 files changed, 113

[PATCH v2] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) .../ABI/testing/sysfs-platform-intel-pmc | 11 +++ MAINTAINERS | 1 + drivers/platform/x86/intel_pmc_core.c | 95

[PATCH v3] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend .../ABI/testing/sysfs-platform-intel-pmc | 11 +++ MAINTAINERS | 1 + drivers/platform/x86/intel_pmc_core.c | 97

[PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler --- 2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend v4: 1. Fix return statement (Andy) 2. Specify manufacturing process (Enrico) .../ABI/testing/sysfs-platform-intel-pmc | 11

[char-misc-next] mei: allow map and unmap of client dma buffer only for disconnected client

2021-03-17 Thread Tomas Winkler
Allow map and unmap of the client dma buffer only when the client is not connected. The functions return -EPROTO if the client is already connected. This is to fix the race when traffic may start or stop when buffer is not available. Cc: #v5.11+ Signed-off-by: Tomas Winkler --- drivers/misc

[PATCH v5] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

2021-04-11 Thread Tomas Winkler
PCHs. Cc: Hans de Goede Cc: David E Box Reviewed-by: Andy Shevchenko Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend v4: 1. Fix return statement (Andy) 2. Specify manufacturing

[PATCH v6] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

2021-04-11 Thread Tomas Winkler
PCHs. Cc: Hans de Goede Cc: David E Box Reviewed-by: Andy Shevchenko Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend v4: 1. Fix return statement (Andy) 2. Specify manufacturing

[PATCH v3] mtd: intel-spi: add is_protected and is_bios_locked knobs

2021-04-11 Thread Tomas Winkler
manufacturing will need the both files in order to validate that the device is properly sealed. Cc: Joe Perches Cc: Mika Westerberg Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler Reviewed-by: Mika Westerberg --- V2: Add a newline to the string format in sysfs_emit() (Joe Perches ) V3

[char-misc-next 2/6] mei: allow clients on bus to communicate in remove callback

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Introduce new intermediate state to allow the clients on the bus to communicate with the firmware from the remove handler. This is to enable to perform a clean shutdown. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6

[char-misc-next 1/6] mei: use sprintf in tx_queue_limit_show sysfs

2021-02-06 Thread Tomas Winkler
Using of snprintf is discouraged in sysfs. For simple u8 it is safe to use sprintf. Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 9f6682033ed7..24a05f45b639

[char-misc-next 4/6] mei: hbm: add client dma hbm messages

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Define structures for client DMA HBM protocol. The protocol requires passing dma buffer address and the buffer id. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 53 +++ 1 file changed

[char-misc-next 5/6] mei: implement client dma setup.

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Implement HBM message protocol to setup and tear down DMA buffer on behalf of an client. On top there DMA buffer allocation and its life time management. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c| 286

[char-misc-next 3/6] mei: add support for client dma capability

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Client DMA capability indicates whether the firmware supports setting up a direct DMA channel between the host and me client. The DMA capabilities are supported from firmware HBM version 2.2 and newer. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler

<    1   2   3   4   5   6   7   8   9   10   >