[PATCH 1/2] HID: intel-ish-hid: add printf attribute to print_log()

format parameter a const pointer as print_log() is not supposed to modify it. Signed-off-by: Nicolas Iooss --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 ++- drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/intel

[PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

odified, introduce a "%s" format parameter in order to silent this -Wformat-security warning and make clang able to detect at compile time real bugs related to string formatting. Signed-off-by: Nicolas Iooss --- drivers/scsi/qla2xxx/qla_isr.c | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH 2/2] scsi: qla2xxx: make msix_entries const

msix_entries and qla82xx_msix_entries arrays are never modified in drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data. Signed-off-by: Nicolas Iooss --- drivers/scsi/qla2xxx/qla_isr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi

[PATCH 1/1] [media] v4l: rcar_fdp1: use %4.4s to format a 4-byte string

mat specifier "%4.4s" is also used by other media drivers to print pixelformat value. Signed-off-by: Nicolas Iooss --- drivers/media/platform/rcar_fdp1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/pla

[PATCH 1/1] drm/i915/gvt: verify functions types in new_mmio_info()

e-mismatch] info->write = write ? write : intel_vgpu_default_mmio_write; ^ ~ ~ This allows the compiler to detect that sbi_ctl_mmio_write() returns a "bool" value instead of an expected "int" one. Fix

[PATCH 1/1] Coccinelle: memdup: fix the report mode

ge of some semantic patches") Signed-off-by: Nicolas Iooss --- scripts/coccinelle/api/memdup.cocci | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/coccinelle/api/memdup.cocci b/scripts/coccinelle/api/memdup.cocci index 3d1aa71b7579..8fd6437beda8 100644 ---

[PATCH] [media] am437x-vpfe: always assign bpp variable

has been found by compiling the kernel with clang. Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver support for AM437X") Cc: sta...@vger.kernel.org Signed-off-by: Nicolas Iooss --- drivers/media/platform/am437x/am437x-vpfe.c | 2 +- 1 file changed, 1 insertion(+

[PATCH v3 1/1] x86, relocs: add printf attribute to die()

e file is included by relocs_64.c, these expressions are 64-bit unsigned integers. Introduce a PRIuELF macro to define the right format to use when printing sh_size and sh_offset values. While at it, constify the format attribute of die(). Signed-off-by: Nicolas Iooss --- I sent the first ver

Uninitialized variable in bfad_im_bsg_els_ct_request

ode and dereferencing self-initialized local variables looks black magic to me, could you please describe why this code is valid? It has recently been introduced by commit 01e0e15c8b3b ("scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly"). Thanks, Nicolas Iooss [1] https://

Uninitialized variable in bfad_im_bsg_els_ct_request

ode and dereferencing self-initialized local variables looks black magic to me, could you please describe why this code is valid? It has recently been introduced by commit 01e0e15c8b3b ("scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly"). Thanks, Nicolas Iooss [1] https://

[PATCH 1/1] x86/platform/intel/quark: add printf attribute to imr_self_test_result()

the attribute. Signed-off-by: Nicolas Iooss --- arch/x86/platform/intel-quark/imr_selftest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c index f5bad40936ac..b8f562049cad 100644

[PATCH 1/1] xfs: silent -Wformat-security warning

silent the warning by calling xfs_warn with "%s" format string. Signed-off-by: Nicolas Iooss --- fs/xfs/xfs_log_recover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index 4a98762ec8b4..9208296e9f15

Re: [PATCH v4 1/1] x86, relocs: add printf attribute to die()

On Tue, Mar 7, 2017 at 10:16 AM, Ingo Molnar wrote: > > * Nicolas Iooss wrote: > >> Adding such an attribute helps to detect errors in the format string at >> build time. After doing this, the compiler complains about some issues: >> >> arch/x86/tools/relocs

[PATCH 1/1] ALSA: es1688: Use strcpy() instead of sprintf()

There is no point in using sprintf() without a format string when strcpy() can perform the same operation. Signed-off-by: Nicolas Iooss --- sound/isa/es1688/es1688_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688

[PATCH 1/1] gconfig: remove misleading parentheses around a condition

ned-off-by: Nicolas Iooss --- scripts/kconfig/gconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c index 26d208b435a0..cfb9c9d7 100644 --- a/scripts/kconfig/gconf.c +++ b/scripts/kconfig/gconf.c @@ -91

[PATCH 1/1] selinux: include sys/socket.h in host programs to have PF_MAX

h. Therefore host programs have to rely on the definition from libc's /usr/include/bits/socket.h, included by . Fix the issue by using sys/socket.h in mdp and genheaders. When classmap.h is included by security/selinux/avc.c, it uses the kernel definition of PF_MAX, which makes the test cons

[PATCH 1/1] apparmor: use SHASH_DESC_ON_STACK

aa_calc_profile_hash(). Signed-off-by: Nicolas Iooss --- security/apparmor/crypto.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/security/apparmor/crypto.c b/security/apparmor/crypto.c index de8dc78b6144..136f2a047836 100644 --- a/securi

[PATCH v4 1/1] x86, relocs: add printf attribute to die()

e file is included by relocs_64.c, these expressions are 64-bit unsigned integers. Add casts to unsigned long long, which length is always 64-bit, and use %llu to format sec->shdr.sh_size and sec->shdr.sh_offset in relocs.c. While at it, constify the format attribute of

[PATCH 1/1] drm/amdgpu: initialize amdgpu_cgs_acpi_eval_object result value

the variable 'result' to silence this warning int result; ^ = 0 Fixes: 3f1d35a03b3c ("drm/amdgpu: implement new cgs interface for acpi function") Signed-off-by: Nicolas Iooss Cc: sta...@vger.kernel.org --- drivers/g

[PATCH 1/1] staging: iio: initialize data pointer before using it

ad7606_spi_read_block() reads SPI big-endian data into a buffer which is then converted to CPU byte-order with a second variable. This variable, data, has been left unitialized after commit 87787e5ef727 ("Staging: iio: Fix sparse endian warning"). Signed-off-by: Nicolas Io

Re: [PATCH 1/1] staging: iio: initialize data pointer before using it

On 06/19/2016 11:41 AM, Lars-Peter Clausen wrote: > On 06/18/2016 11:12 PM, Nicolas Iooss wrote: >> ad7606_spi_read_block() reads SPI big-endian data into a buffer which is >> then converted to CPU byte-order with a second variable. This variable, >> data, has been left uni

[PATCH 1/1] ceph: do not modify fi->frag in need_reset_readdir()

ry offset") Cc: sta...@vger.kernel.org # 4.7.x Signed-off-by: Nicolas Iooss --- fs/ceph/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index c64a0b794d49..df4b3e6fa563 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -597,7 +597,7 @@ static b

[PATCH 1/1] ARM: add printf format attribute to early_print()

Adding such an attribute is helpful to detect errors related to printf formats at compile-time. Signed-off-by: Nicolas Iooss --- arch/arm/include/asm/setup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index

[PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call

f filling the newly-allocated memory (which pointer is hold by *data). Fix this by using *data in the memcpy() call. Fixes: 60dc8dbacb00 ("ASoC: Intel: sst: Add some helper functions") Cc: sta...@vger.kernel.org # 3.19.x Signed-off-by: Nicolas Iooss --- sound/soc/intel/atom/sst/sst_pv

Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call

On 28/08/16 20:17, Joe Perches wrote: > On Sun, 2016-08-28 at 19:39 +0200, Nicolas Iooss wrote: >> In sst_prepare_and_post_msg(), when a response is received in "block", >> the following code gets executed: >> >> *data = kzalloc(block->size, GFP_KER

Re: Misuses of ** ? (was Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call)

On 28/08/16 19:50, Joe Perches wrote: > On Sun, 2016-08-28 at 19:39 +0200, Nicolas Iooss wrote: >> In sst_prepare_and_post_msg(), when a response is received in "block", >> the following code gets executed: >> >> *data = kzalloc(block->size, GFP_KER

[PATCH v2 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call

f filling the newly-allocated memory (which pointer is hold by *data). Fix this by merging kzalloc+memcpy into a single kmemdup() call. Thanks Joe Perches for suggesting using kmemdup() Fixes: 60dc8dbacb00 ("ASoC: Intel: sst: Add some helper functions") Cc: sta...@vger.kernel.org # 3.19.x

[PATCH 1/1] i40iw: do not print unitialized variables in error message

i40iw_create_cqp() printed the contents of variables maj_err and min_err in an error message before they could be initialized (by calling dev->cqp_ops->cqp_create). Signed-off-by: Nicolas Iooss --- drivers/infiniband/hw/i40iw/i40iw_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCH 1/1] usb: dwc2: add printf attribute to cat_printf()

As cat_printf() uses printf format strings in its parameters, adding __printf attribute allows the compiler to detect at compile-time some errors related to format strings (with -Wformat warning flag). Signed-off-by: Nicolas Iooss --- drivers/usb/dwc2/hcd_queue.c | 3 ++- 1 file changed, 2

[PATCH 1/1] iommu/amd: initialize devid variable before using it

Commit 2a0cb4e2d423 ("iommu/amd: Add new map for storing IVHD dev entry type HID") added a call to DUMP_printk in init_iommu_from_acpi() which used the value of devid before this variable was initialized. Signed-off-by: Nicolas Iooss --- drivers/iommu/amd_iommu_init.c | 2 +- 1 file

[PATCH 1/2] drm/vmwgfx: make vmw_kms_helper_dirty return an initialized value

In vmw_kms_helper_dirty(), local variable ret is never initialized before begin used in a return statement when vmw_fifo_reserve() fails. Instead of returning an uninitialized value, return -ENOMEM here and remove the useless variable. Signed-off-by: Nicolas Iooss --- drivers/gpu/drm/vmwgfx

[PATCH 2/2] drm/vmwgfx: make vmw_cotable_unbind return an initialized value

In vmw_cotable_unbind(), local variable ret is never initialized before being used in a return statement at the end of the function. Fix this by directly returning zero and removing the variable. Signed-off-by: Nicolas Iooss --- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 +-- 1 file changed

[PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer

:2399:9: warning: shift count >= width of type [-Wshift-count-overflow] opcode >>= 24; ^ ~~ All of this lead to the point that opcode may have been designed to be a 32-bit integer instead of an 8-bit one. Therefore make this variable u32. Signed-off-by: Nico

[PATCH 1/2] [media] c8sectpfe: initialize err in load_slim_core_fw

load_slim_core_fw() uses a for loop with !err in its condition without first initializing err. Fix this by setting err to 0 in its definition. Signed-off-by: Nicolas Iooss --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] [media] c8sectpfe: forward err instead of returning an uninitialized variable

the caller of load_c8sectpfe_fw_step1(). Signed-off-by: Nicolas Iooss --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe

[PATCH] crypto: crc32c-pclmul: use .rodata instead of .rotata

Module crc32c-intel uses a special read-only data section named .rotata. This section is defined for K_table, and its name seems to be a spelling mistake for .rodata. Fixes: 473946e674eb ("crypto: crc32c-pclmul - Shrink K_table to 32-bit words") Signed-off-by: Nicolas Iooss --- arch/

[PATCH] ACPI: fix acpi_debugfs_init prototype

eturn type from int to void without updating the declaration. Fix this inconsistency by updating acpi_debugfs_init prototype. While at it, include internal.h in debugfs.c so that the compiler can check that the declaration and definition remain compatible. Signed-off-by: Nicolas Iooss --- dr

[PATCH] drm/amdgpu: increment queue when iterating on this variable.

ed in loop condition not modified in loop body [-Werror,-Wloop-analysis] for (queue = 0; queue < 8; i++) { ^ Fix this by incrementing variable queue instead of i in this loop. Signed-off-by: Nicolas Iooss --- drivers/gpu/drm/amd/amdgpu/g

[PATCH] NFC: st21nfca,st-nci: fix use of uninitialized variables in error path

ation") Signed-off-by: Nicolas Iooss --- As I haven't got the hardware needed to perform tests, I only compile-tested this patch. Moreover I may then have missed something important for example in the way the memory is managed (I did not understand why skb_pipe_info was not freed

[PATCH] KVM: x86: remove data variable from kvm_get_msr_common

host_initiated to functions that read MSRs") Signed-off-by: Nicolas Iooss --- arch/x86/kvm/x86.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index ac165c2fb8e5..bbaf44e8f0d3 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x

[PATCH] mtd: r852: make ecc_reg 32-bit in r852_ecc_correct

ift-count-overflow] ecc_reg >>= 16; ^ ~~ Fix this by making ecc_reg 32-bit, like the return type of r852_read_reg_dword(). Signed-off-by: Nicolas Iooss --- As I haven't got the hardware to test this patch, it is only compile-tested. dr

[PATCH] mm: kmemleak: mark kmemleak_init prototype as __init

with clang -Wsection, because kmemleak_init() is declared in section .ref.text but defined in .init.text. Fix this by marking kmemleak_init() prototype __init. Signed-off-by: Nicolas Iooss --- include/linux/kmemleak.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/km

[PATCH 1/2] include, lib: add __printf attributes to several function prototypes

clude/linux/ and lib/. These functions were mostly found by using gcc's -Wsuggest-attribute=format flag. Signed-off-by: Nicolas Iooss --- As most of these files are not matched by any pattern in MAINTAINERS, it was quite difficult to build the list of recipients. If you didn't want to

[PATCH 2/2] configfs: fix kernel infoleak through user-controlled format string

me() in drivers/net/netconsole.c. To fix this, update every caller of config_item_set_name to use "%s" when operating on untrusted input. This issue was found using -Wformat-security gcc flag, once a __printf attribute has been added to config_item_set_name(). Signed-off-by: Nicolas I

[PATCH v2 1/2] drm: make drm_dev_set_unique() not use a format string

79266b1 ("configfs: fix kernel infoleak through user-controlled format string"). False positives which do not bring an extra value make the work of finding real bugs harder. Therefore remove the format-string feature from drm_dev_set_unique(). Signed-off-by: Nicolas Iooss --- v2: updat

[PATCH v2 2/2] drm: use dev_name as default unique name in drm_dev_alloc()

ecember/096441.html, the unique name of a new DRM device can be set as dev_name(parent_dev) when parent_dev is not NULL (vgem is a special case). Signed-off-by: Nicolas Iooss Acked-by: Boris Brezillon --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 drivers/gpu/drm/dr

Re: [PATCH v4 1/1] x86, relocs: add printf attribute to die()

On Tue, Mar 7, 2017 at 1:37 PM, Nicolas Iooss wrote: > On Tue, Mar 7, 2017 at 10:16 AM, Ingo Molnar wrote: >> >> * Nicolas Iooss wrote: >> >>> Adding such an attribute helps to detect errors in the format string at >>> build time. After doing this, t

Re: [PATCH 1/1] apparmor: use SHASH_DESC_ON_STACK

Hello, I sent the following patch three weeks ago and have not got any reply. Could you please review it? Thanks, Nicolas On Sun, Mar 5, 2017 at 3:30 PM, Nicolas Iooss wrote: > When building the kernel with clang, the compiler fails to build > security/apparmor/crypto.c with the following

Pointer type of _arp in __skb_flow_dissect()

Hello, Linux 4.11-rc4 contains the following code in function __skb_flow_dissect(), file net/core/flow_dissector.c: const struct arphdr *arp; struct arphdr *_arp; arp = __skb_header_pointer(skb, nhoff, sizeof(_arp), data, hlen, &_arp);

[PATCH 1/1] drm/sti: use seq_puts to display a string

t a string literal and no format arguments [-Wformat-security] seq_printf(s, gdp_format_to_str[i].name); ^ Silence this warning by using seq_puts() instead. Signed-off-by: Nicolas Iooss --- drivers/gpu/drm/sti/sti_gdp.c | 2 +- 1 file changed, 1

[PATCH 1/1] pcmcia: remove left-over %Z format

Commit 5b5e0928f742 ("lib/vsprintf.c: remove %Z support") removed some usages of format %Z but forgot "%.2Zx". This makes clang 4.0 reports a -Wformat-extra-args warning because it does not know about %Z. Replace %Z with %z. Cc: sta...@vger.kernel.org # v4.11+ Signed-o

[PATCH 1/1] printk: add __printf attributes to internal functions

When compiling with -Wsuggest-attribute=format, gcc complains that some functions in kernel/printk/printk_safe.c transmit their argument to printf-like functions without having a printf attribute. Silence these warnings by adding relevant __printf attributes. Signed-off-by: Nicolas Iooss

[PATCH 2/2] pcmcia: nsp_cs: add __printf attribute to logging functions

Adding __printf attributes helps to detect errors in printf format strings at build time. Signed-off-by: Nicolas Iooss --- drivers/scsi/pcmcia/nsp_cs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index

[PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions

x27;, but argument 6 has type 'pm_message_t {aka struct pm_message}' [-Werror=format=] nsp32_msg(KERN_INFO, "pci-suspend: pdev=0x%p, state=%ld, slot=%s, host=0x%p", pdev, state, pci_name(pdev), host); Fix all format string errors which were report

[PATCH 1/1] genksyms: add printf format attribute to error_with_pos()

=format] vfprintf(stderr, fmt, args); ^~~~ This would allow catching printf-format errors at compile time in callers to error_with_pos(). Add this attribute. Signed-off-by: Nicolas Iooss --- I am sending this to the maintainers listed in section "KERNEL BUILD + files below sc

[PATCH v2 1/1] printk: add __printf attributes to internal functions

When compiling with -Wsuggest-attribute=format, gcc complains that some functions in kernel/printk/printk_safe.c transmit their argument to printf-like functions without having a printf attribute. Silence these warnings by adding relevant __printf attributes. Signed-off-by: Nicolas Iooss Acked

Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format

On Mon, Dec 11, 2017 at 11:22 PM, Bart Van Assche wrote: > > On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote: > > fnic_fcpio_icmnd_cmpl_handler() displays the value of sc with: > > > > FNIC_SCSI_DBG(KERN_INFO... > > "...

[PATCH 1/1] RAS/CEC: use the right length of "cec_disable"

parse_cec_param() compares a string with "cec_disable" using only 7 characters of the 11-character-long string. Fix the length. Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector") Signed-off-by: Nicolas Iooss --- drivers/ras/cec.c | 2 +- 1 file changed, 1 inse

[PATCH 1/1] dax: initialize variable pfn before using it

inode, vmf, length, pfn, ret); ^~~ Signed-off-by: Nicolas Iooss --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index ab925dc6647a..20e6d76d6fff 100644 --- a/fs/dax.c +++ b

[PATCH 1/1] x86/xen: fix section of xen_init_time_ops() in header

is initialized") Signed-off-by: Nicolas Iooss --- arch/x86/xen/xen-ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h index 0d5004477db6..b2a5d48a2c2a 100644 --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@

[PATCH 1/1] drm/amd/powerplay: initialize a variable before using it

support (v5)") Signed-off-by: Nicolas Iooss --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c index 197174e562d2..c8d28f78c

[PATCH 1/1] staging/atomisp: fix header guards

#ifndef. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Nicolas Iooss --- .../css2400/css_2400_system/hrt/input_formatter_subsystem_defs.h| 2 +- .../css2400/css_2401_csi2p_system/hrt/input_formatter_subsystem_defs.h | 2 +- .

Re: [PATCH v4 1/1] x86, relocs: add printf attribute to die()

at 11:06 PM, Nicolas Iooss wrote: > On Tue, Mar 7, 2017 at 1:37 PM, Nicolas Iooss > wrote: >> On Tue, Mar 7, 2017 at 10:16 AM, Ingo Molnar wrote: >>> >>> * Nicolas Iooss wrote: >>> >>>> Adding such an attribute helps to detect errors in the form

Re: [PATCH 1/2] RAS/CEC: Use the right length for "cec_disable"

On Tue, Oct 3, 2017 at 11:04 AM, Borislav Petkov wrote: > On Mon, Oct 02, 2017 at 05:42:56PM +0200, Thomas Gleixner wrote: >> On Mon, 2 Oct 2017, Borislav Petkov wrote: >> > From: Nicolas Iooss >> > >> > parse_cec_param() compares a string with "cec_dis

[PATCH 1/1] scsi: fnic: add a space after %p in printf format

a space. Signed-off-by: Nicolas Iooss --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 242e2ee494a1..8cbd3c9f0b4c 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/s

[PATCH 1/1] staging: rtl8723bs: make memcmp() calls consistent

sscanf(extra+4, "%u", &mode); The space between the key ("lps" and "ips") and the equal sign seems suspicious. Remove it in order to make the calls to memcmp() consistent. Signed-off-by: Nicolas Iooss --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4

[PATCH 1/1] rtlwifi: always initialize variables given to RT_TRACE()

~~ drivers/net/wireless/realtek/rtlwifi/base.c:1671:4: note: uninitialized use occurs here reject_agg, ctrl_agg_size, agg_size); ^~ Fixes: 2635664e6e4a ("rtlwifi: Add rx ampdu cfg for btcoexist.") Signed-off-by: Nicolas Iooss --- dr

[PATCH 1/1] [media] mb86a20s: always initialize a return value

. Signed-off-by: Nicolas Iooss --- drivers/media/dvb-frontends/mb86a20s.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c index 41325328a22e..eca07432645e 100644 --- a/drivers/media/dvb-frontends/mb86a20s.c +++ b

[PATCH 1/1] [media] ite-cir: initialize use_demodulator before using it

based ite-cir driver for several ITE CIRs") Signed-off-by: Nicolas Iooss --- drivers/media/rc/ite-cir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c index 0f301903aa6f..63165d324fff 100644 --- a/drivers/media/rc/ite-cir.c +++

[PATCH 1/1] x86: do not skip PKRU register if debug registers are not used

when debug registers are in their default state. Signed-off-by: Nicolas Iooss --- arch/x86/kernel/process_64.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 63236d8f84bf..a21068e49dac 100644 --- a/arch/

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dsi: silence a warning about uninitialized return value

On 08/09/16 16:31, Dave Gordon wrote: > On 08/09/16 00:02, Nicolas Iooss wrote: >> On 07/09/16 18:03, Dave Gordon wrote: >>> On 06/09/16 21:36, Nicolas Iooss wrote: >>>> On 06/09/16 12:21, Dave Gordon wrote: >>>>> On 04/09/16 19:58, Nicolas Iooss wrot

[PATCH 1/1] staging: rtl8192u: do not use undefined $(TOPDIR) in Makefile

drivers/staging/rtl8192u/ieee80211/Makefile uses $(TOPDIR) to configure an include directory, without defining this variable first. The path which is configured is therefore "/drivers/net/wireless", which does not seem to be the intended path. Remove the offending line. Signed-off-b

[PATCH 1/1] x86, relocs: add function attributes to die()

signed long') [-Werror,-Wformat] sec->shdr.sh_offset, strerror(errno)); ^~~ To support both 32-bit and 64-bit modes, add casts to long types and use %lu and %ld to format the numbers. Signed-off-by: Nicolas Iooss --- arch/x86/tools/relocs

Re: [PATCH 1/1] x86, relocs: add function attributes to die()

On 03/09/16 17:16, Nilay Vaish wrote: > On 3 September 2016 at 09:50, Nicolas Iooss > wrote: >> >> arch/x86/tools/relocs.c:460:5: error: format specifies type 'int' >> but the argument has type 'Elf64_Xword' (a

[PATCH v2 1/1] x86, relocs: add function attributes to die()

expressions are 64-bit unsigned integers. Introduce a PRIuELF macro to define the right format to use when printing these expressions. Signed-off-by: Nicolas Iooss --- arch/x86/tools/relocs.c| 14 +++--- arch/x86/tools/relocs.h| 3 ++- arch/x86/tools/relocs_32.c

[PATCH 1/1] drm/i915/dsi: silence a warning about uninitialized return value

^~~~ As intel_dsi->dcs_backlight_ports seems to be always initialized to a non-null value, the content of the for loop is always executed and there is no bug in the current code. Nevertheless the compiler has no way of knowing that assumption, so initialize variable 'data'

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

Hello, After I sent the following patch a few weeks ago, I have not received any feedback. Could you please review it and tell me what I may have done wrong? Thanks, Nicolas On 05/08/16 22:34, Nicolas Iooss wrote: > The struct cfg80211_pmksa defines its bssid field as: > > const

Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

Hello, After I sent the following patch a few weeks ago, I have not received any feedback. Could you please review it? Thanks, Nicolas On 06/08/16 11:58, Nicolas Iooss wrote: > asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format > some of its arguments. Adding a __

Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

On 22/08/16 15:13, Takashi Iwai wrote: > On Mon, 22 Aug 2016 15:06:05 +0200, > Nicolas Iooss wrote: >> >> Hello, >> >> After I sent the following patch a few weeks ago, I have not received >> any feedback. Could you please review it? > > This is about ASoC

[PATCH 2/2] MAINTAINERS: document ASoC header files

include/sound/simple_card_utils.h is handled by ASoC maintainers, as stated in https://lkml.org/lkml/2016/8/22/307, and include/sound/simple_card.h seems to be an ASoC file too. Signed-off-by: Nicolas Iooss --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b

[PATCH 1/2] ASoC: simple-card-utils: add __printf attribute

asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format some of its arguments. Adding a __printf attribute to this function makes it possible to detect at compile-time errors related to format strings. Signed-off-by: Nicolas Iooss --- include/sound/simple_card_utils.h | 1 + 1

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

On 22/08/16 21:38, Arend Van Spriel wrote: > On 22-8-2016 15:03, Nicolas Iooss wrote: >> On 05/08/16 22:34, Nicolas Iooss wrote: [...] >>> Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code") >>> Cc: sta...@ger.kernel.org > > Ah, so you d

[PATCH v2 1/1] brcmfmac: fix pmksa->bssid usage

("brcmfmac: Cleanup pmksa cache handling code") Cc: sta...@vger.kernel.org Signed-off-by: Nicolas Iooss --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfma

Re: [PATCH 2/2] MAINTAINERS: document ASoC header files

On 23/08/16 12:09, Kuninori Morimoto wrote: > Hi Nicolas > >> include/sound/simple_card_utils.h is handled by ASoC maintainers, as >> stated in https://lkml.org/lkml/2016/8/22/307, and >> include/sound/simple_card.h seems to be an ASoC file too. >> &

[PATCH 1/1] usb: usbip: vudc: fix left shift overflow

equires 35 bits to represent, but 'int' only has 32 bits [-Wshift-overflow] urb_p->urb->pipe &= ~(11 << 30); ~~ ^ ~~ Fixes: 79c02cb1fd5c ("usbip: vudc: Add vudc_rx") Signed-off-by: Nicolas Iooss --- drivers

[PATCH 1/1] printk: fix parsing of "brl=" option

ly updated to memcmp(*str, "brl,", 4) but not memcmp(str, "brl=", 4). Update the code to make "brl=" option work again. Fixes: bbeddf52adc1 ("printk: move braille console support into separate braille.[ch] files") Signed-off-by: Nicolas Iooss --- kerne

Re: [PATCH 1/1] printk: fix parsing of "brl=" option

On 23/08/16 18:25, Joe Perches wrote: > On Tue, 2016-08-23 at 17:47 +0200, Nicolas Iooss wrote: >> Commit bbeddf52adc1 ("printk: move braille console support into separate >> braille.[ch] files") moved the parsing of braille-related options into >> _braille_consol

[PATCH v2 1/1] printk: fix parsing of "brl=" option

upport into separate braille.[ch] files") Signed-off-by: Nicolas Iooss --- kernel/printk/braille.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/printk/braille.c b/kernel/printk/braille.c index 276762f3a460..d5760c42f042 100644 --- a/kernel/printk/brail

Re: [PATCH 1/1] Bluetooth: add printf format attribute to hci_set_[fh]w_info()

Hello, After I sent the following patch a few weeks ago, I have not received any feedback. Could you please review it? Thanks, Nicolas On 29/07/16 13:28, Nicolas Iooss wrote: > Commit 5177a83827cd ("Bluetooth: Add debugfs fields for hardware and > firmware info") introduced hci_s

[tip:mm/pkeys] x86/mm/pkeys: Do not skip PKRU register if debug registers are not used

Commit-ID: 19ab2b679c4af895ac0f3e79eea14952a6b2b2ce Gitweb: http://git.kernel.org/tip/19ab2b679c4af895ac0f3e79eea14952a6b2b2ce Author: Nicolas Iooss AuthorDate: Sat, 10 Sep 2016 20:30:45 +0200 Committer: Thomas Gleixner CommitDate: Tue, 13 Sep 2016 15:12:17 +0200 x86/mm/pkeys: Do not

[tip:mm/pkeys] x86/mm/pkeys: Do not skip PKRU register if debug registers are not used

Commit-ID: ba6d018e3d2f6a0fad58a668cadf66b2d1f80f59 Gitweb: http://git.kernel.org/tip/ba6d018e3d2f6a0fad58a668cadf66b2d1f80f59 Author: Nicolas Iooss AuthorDate: Sat, 10 Sep 2016 20:30:45 +0200 Committer: Thomas Gleixner CommitDate: Tue, 13 Sep 2016 15:52:28 +0200 x86/mm/pkeys: Do not

[tip:x86/boot] x86/boot: Remove unused 'is_big_kernel' variable

Commit-ID: 25b4caf7c50e8c501310e8c515d8518b1850c948 Gitweb: http://git.kernel.org/tip/25b4caf7c50e8c501310e8c515d8518b1850c948 Author: Nicolas Iooss AuthorDate: Sun, 14 Feb 2016 13:35:58 +0100 Committer: Ingo Molnar CommitDate: Tue, 16 Feb 2016 09:16:58 +0100 x86/boot: Remove unused

[tip:x86/urgent] x86/platform/intel/quark: Add printf attribute to imr_self_test_result()

Commit-ID: 9120cf4fd9ae77245ce9137869bcbd16575cc633 Gitweb: http://git.kernel.org/tip/9120cf4fd9ae77245ce9137869bcbd16575cc633 Author: Nicolas Iooss AuthorDate: Mon, 19 Dec 2016 14:21:44 +0100 Committer: Ingo Molnar CommitDate: Tue, 20 Dec 2016 09:37:24 +0100 x86/platform/intel/quark

[tip:x86/urgent] x86/mm/kaslr: Fix -Wformat-security warning

Commit-ID: 62d16b5a3fca4d186e13215e0d7d2f6d36191796 Gitweb: http://git.kernel.org/tip/62d16b5a3fca4d186e13215e0d7d2f6d36191796 Author: Nicolas Iooss AuthorDate: Sat, 6 Aug 2016 12:20:39 +0200 Committer: Ingo Molnar CommitDate: Thu, 11 Aug 2016 10:58:12 +0200 x86/mm/kaslr: Fix -Wformat

[tip:ras/urgent] RAS/CEC: Use the right length for "cec_disable"

Commit-ID: 69a330007091ea8a801dd9fcd897ec52f9529586 Gitweb: https://git.kernel.org/tip/69a330007091ea8a801dd9fcd897ec52f9529586 Author: Nicolas Iooss AuthorDate: Mon, 2 Oct 2017 11:28:35 +0200 Committer: Thomas Gleixner CommitDate: Thu, 5 Oct 2017 14:23:06 +0200 RAS/CEC: Use the right

<    1   2