Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

2014-01-05 Thread Josh Triplett
minates the following warning in debugfs.c: > > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for > > ‘acpi_debugfs_init’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > --- > > drivers/acpi

Re: [PATCH] drivers: Remove unused devm_*_put functions

2014-01-06 Thread Josh Triplett
On Mon, Jan 06, 2014 at 04:48:39PM +0900, Alexandre Courbot wrote: > On Sat, Jan 4, 2014 at 5:22 AM, Josh Triplett wrote: > > On Fri, Jan 03, 2014 at 08:07:22PM +0900, Alexandre Courbot wrote: > >> On Thu, Jan 2, 2014 at 10:07 PM, Linus Walleij > >> wrote: > >

#pragma once?

2014-01-06 Thread Josh Triplett
[CCing build-system folks and others likely to know about potential issues.] Does anyone have any objection to the use of "#pragma once" instead of the usual #ifndef-#define-...-#endif include guard? GCC, LLVM/clang, and the latest Sparse all support either method just fine. (I added support to

Re: #pragma once?

2014-01-06 Thread Josh Triplett
On Mon, Jan 06, 2014 at 01:00:03PM -0800, Andrew Morton wrote: > On Mon, 6 Jan 2014 12:47:07 -0800 Josh Triplett wrote: > > > Does anyone have any objection to the use of "#pragma once" instead of > > the usual #ifndef-#define-...-#endif include guard? > > S

Re: checkpatch.pl error might be false positive

2013-12-20 Thread Josh Triplett
On Fri, Dec 20, 2013 at 01:23:52AM -0800, Joe Perches wrote: > On Fri, 2013-12-20 at 01:16 -0800, Josh Triplett wrote: > > Duplicating the regex seems awful. Could you put it in a variable? > > awful is a strong word and I don't have any > issue with the duplication. Usi

Re: [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c

2013-12-21 Thread Josh Triplett
s prototype for > ‘smtcfb_setmode’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/sm7xxfb/sm7xxfb.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c &

Re: [PATCH] drivers: sbe-2t3e3: Mark functions as static in ctrl.c

2013-12-21 Thread Josh Triplett
totype for > ‘t3e3_port_del_stats’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/sbe-2t3e3/ctrl.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/sbe-2t3e3/ctrl.c

Re: [PATCH] drivers: dwc2: Mark function as static in core.c

2013-12-21 Thread Josh Triplett
vious prototype for > ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/dwc2/core.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dwc2/core.c b

Re: [PATCH] drivers: dgnc: Include appropriate header file in dgnc_trace.c

2013-12-21 Thread Josh Triplett
ce.c: > drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for > ‘dgnc_tracer_free’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/dgnc/dgnc_trace.c |1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c

2013-12-21 Thread Josh Triplett
ce.c: > drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for > ‘dgap_tracer_free’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/dgap/dgap_trace.c |1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c

2013-12-21 Thread Josh Triplett
p/dgap_parse.c:1252:7: warning: no previous prototype for > ‘dgap_create_config_string’ [-Wmissing-prototypes] > drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for > ‘dgap_get_config_letters’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by:

Re: [PATCH 1/2] drivers: bcm: Mark functions as static in Qos.c

2013-12-21 Thread Josh Triplett
s’ > [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/bcm/Qos.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c > index 1609a2

Re: [PATCH 2/2] drivers: bcm: Remove unused function in nvm.c

2013-12-21 Thread Josh Triplett
rototype for > ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/staging/bcm/nvm.c | 61 > - > 1 file changed, 61 deletions(-) > > diff --git a/drivers/staging/bcm/nvm.c

[PATCH 1/7] mtd: denali: Drop print of build date/time

2013-12-23 Thread Josh Triplett
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by: Josh Triplett --- drivers/mtd/nand/denali_pci.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 5/7] staging: wlags49_h2: Drop debug macro recording build date/time

2013-12-23 Thread Josh Triplett
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by: Josh Triplett --- drivers/staging/wlags49_h2/wl_version.h | 4 1 file chang

[PATCH 4/7] staging: rts5139: Drop print of build time

2013-12-23 Thread Josh Triplett
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __TIME__, which makes the build non-deterministic. (And, without __DATE__, __TIME__ provided little useful information to begin with.) Signed-off-by: Josh Tri

[PATCH 6/7] x86: math-emu: Drop already-disabled print of build date

2013-12-23 Thread Josh Triplett
ned-off-by: Josh Triplett --- arch/x86/math-emu/errors.c | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c index 59d353d..a544908 100644 --- a/arch/x86/math-emu/errors.c +++ b/arch/x86/math-emu/errors.c @@ -330,11 +330,6 @@ asmli

[PATCH 3/7] staging: rtl8188eu: Drop print of build date/time

2013-12-23 Thread Josh Triplett
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by: Josh Triplett --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 - 1 file chang

[PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

2013-12-23 Thread Josh Triplett
(optionally) records this information at build time in a single place; other kernel code should not duplicate that. Signed-off-by: Josh Triplett --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 14d592c..188eea7 100644 --- a/Makefile +++ b/Makefile

[PATCH 2/7] net: wireless: brcm80211: Drop debug version with build date/time

2013-12-23 Thread Josh Triplett
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by: Josh Triplett --- drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c | 7 --- 1

Re: [PATCH 1/5] checkpatch: Add tests for function pointer style misuses

2013-12-26 Thread Josh Triplett
ry space after function pointer > name\n" . $herecurr); > + } > + > +# unnecessary space "type (*funcptr) (args...)" > + if (defined $pre_args_space && > + $pre_args_space =~ /^\s/) { > +

Re: [PATCH 2/5] checkpatch: Add a --fix-inplace option

2013-12-26 Thread Josh Triplett
On Thu, Dec 26, 2013 at 11:20:29AM -0800, Joe Perches wrote: > Add the ability to fix and overwrite existing files/patches instead > of creating a new file ".EXPERIMENTAL-checkpatch-fixes". > > Suggested-by: Manfred Spraul > Signed-off-by: Joe Perches Reviewed-by: J

Re: [PATCH 4/5] checkpatch: check for if's with unnecessary parentheses

2013-12-26 Thread Josh Triplett
if so. > > Signed-off-by: Joe Perches Reviewed-by: Josh Triplett > scripts/checkpatch.pl | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index db72b88..c12234e 100755 > --- a/scripts/checkpatch.

Re: [PATCH 1/5] checkpatch: Add tests for function pointer style misuses

2013-12-26 Thread Josh Triplett
On Thu, Dec 26, 2013 at 12:07:23PM -0800, Josh Triplett wrote: > On Thu, Dec 26, 2013 at 11:20:28AM -0800, Joe Perches wrote: > > Kernel style uses function pointers in this form: > > "type (*funcptr)(args...)" > > > > Emit warnings when

Re: [PATCH 6/9] drm: use c99 initializers in structures

2014-08-23 Thread Josh Triplett
// > > Signed-off-by: Julia Lawall For this patch, I think it would make sense to drop initializations of preferred/quirks/modes to 0, since a designated initializer may skip fields to leave them initialized to 0. With that change: Reviewed-by: Josh Triplett &

Re: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures

2014-08-23 Thread Josh Triplett
> // > > Signed-off-by: Julia Lawall One comment below about formatting. With that addressed: Reviewed-by: Josh Triplett > --- a/drivers/video/fbdev/aty/aty128fb.c > +++ b/drivers/video/fbdev/aty/aty128fb.c > @@ -324,14 +324,57 @@ struct aty128_meminfo { > }; > > /* va

Re: [PATCH 0/9] use c99 initializers in structures

2014-08-23 Thread Josh Triplett
0 or NULL, > where some of the fields already use labels, and where there are nested > structures. I responded to patches 6 and 8 with comments; for the rest (1-5, 7, 9): Reviewed-by: Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures

2014-08-23 Thread Josh Triplett
On Sat, Aug 23, 2014 at 05:32:37PM +0200, Julia Lawall wrote: > On Sat, 23 Aug 2014, Josh Triplett wrote: > > On Sat, Aug 23, 2014 at 01:20:30PM +0200, Julia Lawall wrote: > > > From: Julia Lawall > > > > > > Use c99 initializers for structures. > > >

Re: [PATCH 8/9 v2] video: fbdev: aty: use c99 initializers in structures

2014-08-23 Thread Josh Triplett
t; identifier i1,fld; > type T; > field list[n] fs; > @@ > > struct i1 { > fs > T fld; > ...}; > > @bad@ > identifier decl.i1,i2; > expression e; > initializer list[decl.n] is; > @@ > > struct i1 i2 = { is, > + .fld = e > - e > ,...}; > /

Re: [PATCH 1/7] mtd: denali: fix the format of comment blocks

2014-09-08 Thread Josh Triplett
e code is clear enough such as: > > /* clear interrupts */ > clear_interrupts(denali); > > Signed-off-by: Masahiro Yamada All of the cases seem to match the preferred style; seems reasonable. And thanks for applying the additional cleanup of removing entirely unnecessary comments

Re: [PATCH 5/7] mtd: denali: remove a set-but-unused variable

2014-09-08 Thread Josh Triplett
On Mon, Sep 08, 2014 at 05:10:11PM +0900, Masahiro Yamada wrote: > The variable "retry" in wait_for_irq() is set, but not referenced. > > Signed-off-by: Masahiro Yamada Sure enough. Reviewed-by: Josh Triplett > > drivers/mtd/nand/denali.c | 2 -- > 1 file chang

Re: [PATCH 6/7] mtd: denali: remove unnecessary parentheses

2014-09-08 Thread Josh Triplett
dence of the relevant operators is always clear. Reviewed-by: Josh Triplett > > drivers/mtd/nand/denali.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c > index d37c2e1..ed37b76 1

Re: [PATCH 7/7] mtd: denali: fix indentations and other trivial things

2014-09-08 Thread Josh Triplett
pr_err("Your NAND chip OOB is not large enough to " > +"contain 8bit ECC correction codes"); Likewise. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] mtd: denali: fix include guard and license block of denali.h

2014-08-29 Thread Josh Triplett
ff-by: Masahiro Yamada Looks sensible, since the header above the first diff hunk is the same modulo filename. (Side note: could we get checkpatch to complain about comment headers containing the name of the file they appear in? They're always either redundant or wrong.) Review

Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice

2014-08-29 Thread Josh Triplett
e itself doesn't need to be visible if there are no items > selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. > > Signed-off-by: Stefan Hengelein > Signed-off-by: Andreas Ruprecht Makes sense; nice cleanup. Reviewed-by: Josh Triplett > init/Kconfig | 6 +++---

Re: [PATCH] mtd: denali: fix include guard and license block of denali.h

2014-08-31 Thread Josh Triplett
On Sat, Aug 30, 2014 at 07:09:26AM -0700, Joe Perches wrote: > On Fri, 2014-08-29 at 11:30 -0700, Josh Triplett wrote: > > (Side note: could we get checkpatch to complain about comment headers > > containing the name of the file they appear in? They're always either &g

Re: [PATCH] efi-bgrt: Add error handling; inform the user when ignoring the BGRT

2014-08-05 Thread Josh Triplett
On Mon, Aug 04, 2014 at 01:19:59PM +0100, Matt Fleming wrote: > On Fri, 01 Aug, at 09:11:54AM, Josh Triplett wrote: > > > > The original bug report was about an allocation failure for a fairly > > reasonable BGRT size. We can certainly prohibit absurdly huge ones (for >

[PATCH] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-06 Thread Josh Triplett
his provides a better baseline for embedded systems or efforts to reduce kernel size. Signed-off-by: Josh Triplett --- arch/x86/Makefile| 6 ++ arch/x86/configs/tiny.config | 5 + 2 files changed, 11 insertions(+) create mode 100644 arch/x86/configs/tiny.config diff --git

Re: [PATCH] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-06 Thread Josh Triplett
On Wed, Aug 06, 2014 at 03:06:11PM -0700, David Rientjes wrote: > On Wed, 6 Aug 2014, Josh Triplett wrote: > > Since commit 5d2acfc7b974bbd3858b4dd3f2cdc6362dd8843a ("kconfig: make > > allnoconfig disable options behind EMBEDDED and EXPERT") in 3.15-rc1, > > &q

[PATCH 1/2] x86, platform, kconfig: move kvmconfig functionality to a helper

2014-08-06 Thread Josh Triplett
path. Signed-off-by: Josh Triplett --- Hopefully the above changelog message makes the origin of this patch clear; it didn't seem appropriate to keep a Signed-off-by when modifying the patch, but I wanted to preserve the credit. arch/x86/Makefile | 10 +++--- 1 file changed, 7 inser

[PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-06 Thread Josh Triplett
his provides a better baseline for embedded systems or efforts to reduce kernel size. Signed-off-by: Josh Triplett --- v2: Based this on Luis's helper, added in patch 1/2, which eliminates the previously duplicated implementation from kvmconfig. arch/x86/Makefile| 5 + arch/x

Re: [PATCH 1/2] x86, platform, kconfig: move kvmconfig functionality to a helper

2014-08-06 Thread Josh Triplett
On Wed, Aug 06, 2014 at 03:33:45PM -0700, David Rientjes wrote: > On Wed, 6 Aug 2014, Josh Triplett wrote: > > The new mergeconfig helper makes it easier to add other partial > > configurations similar to kvmconfig. > > > > Based on a patch by Luis R. Rodriguez . &

Re: [PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-06 Thread Josh Triplett
On Wed, Aug 06, 2014 at 03:38:56PM -0700, David Rientjes wrote: > On Wed, 6 Aug 2014, Josh Triplett wrote: > > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > > index 1568678..2b5ca16 100644 > > --- a/arch/x86/Makefile > > +++ b/arch/x86/Makefile > > @@ -25

Re: [PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-06 Thread Josh Triplett
On Wed, Aug 06, 2014 at 04:37:54PM -0700, David Rientjes wrote: > On Wed, 6 Aug 2014, Josh Triplett wrote: > > On Wed, Aug 06, 2014 at 03:38:56PM -0700, David Rientjes wrote: > > > On Wed, 6 Aug 2014, Josh Triplett wrote: > > > > diff --git a/arch/x86/Makefile b/a

Re: [PATCH 1/1] bug: Add unreachable() to generic BUG() to silence warnings

2014-08-06 Thread Josh Triplett
On Thu, Aug 07, 2014 at 03:13:41AM +0200, Nick Krause wrote: > Architectures which use generic BUG() have warnings like > > kernel/sched/core.c:2692:1: warning: control reaches end of non-void function > [-Wreturn-type] > net/core/ethtool.c:236:1: warning: control reaches end of non-void functio

Re: [PATCH] sh: bug: add unreachable() to silence warnings

2014-08-06 Thread Josh Triplett
(), this one doesn't call panic() or anything else flagged as __noreturn, so it seems reasonable to add a call to unreachable() here to tell the compiler that the assembly will trap and not return. Reviewed-by: Josh Triplett > arch/sh/include/asm/bug.h | 1 + > 1 file changed, 1 ins

Re: [PATCH 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-07 Thread Josh Triplett
On Thu, Aug 07, 2014 at 06:03:52PM +0200, Sam Ravnborg wrote: > On Wed, Aug 06, 2014 at 03:31:54PM -0700, Josh Triplett wrote: > > Since commit 5d2acfc7b974bbd3858b4dd3f2cdc6362dd8843a ("kconfig: make > > allnoconfig disable options behind EMBEDDED and EXPERT") in 3.15-r

[PATCH v3 1/2] x86, platform, kconfig: move kvmconfig functionality to a helper

2014-08-08 Thread Josh Triplett
, and factor out more of the common file path. Signed-off-by: Josh Triplett --- Note that this leaves kvm_guest.config in arch/x86/configs/ . A KVM expert is welcome to follow up with a patch splitting the options in kvm_guest.config between arch/x86/configs/ and kernel/configs/ . arch/x86

[PATCH v3 2/2] x86: Add "make tinyconfig" to configure the tiniest possible kernel

2014-08-08 Thread Josh Triplett
his provides a better baseline for embedded systems or efforts to reduce kernel size. Signed-off-by: Josh Triplett --- Any architecture with architecture-specific tinification options just needs to create arch/${arch}/configs/tiny.config, and "make tinyconfig" will automatically

Re: [RFC PATCH 0/9] Add ACPI _DSD and unified device properties support

2014-08-16 Thread Josh Triplett
I noticed with the series: the new read functions, when given an integer type, don't appear to do any range-checking to make sure the returned value falls within the range of that type. They should do so, and return -EOVERFLOW if so. And the documentation of the new functions should note tha

Re: [PATCH] efi-bgrt: Add error handling; inform the user when ignoring the BGRT

2014-08-01 Thread Josh Triplett
On Fri, Aug 01, 2014 at 10:19:49AM +0100, Matt Fleming wrote: > (Including akpm, the __GFP_NOWARN police) Andrew suggested __GFP_NOWARN here in the first place. > On Thu, 31 Jul, at 09:11:33AM, Josh Triplett wrote: > > > > I started to add an explicit limit, but any reaso

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
I'll take the series through the tiny tree when it's ready > > to merge. > > I think it's rather pointless - there is very little sendfile code, > so you'd rather want to disable splice. That's the plan, but since sendfile depends on some of the splice bits, s

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
On Tue, Oct 21, 2014 at 02:13:56AM -0700, Christoph Hellwig wrote: > On Tue, Oct 21, 2014 at 02:04:22AM -0700, Josh Triplett wrote: > > That's the plan, but since sendfile depends on some of the splice bits, > > sendfile needs to be optional as well; SENDFILE_SYSC

Re: [PATCH] init: Remove CONFIG_INIT_FALLBACK

2014-10-21 Thread Josh Triplett
ad" > > - default y > > - help > > The above is not in mainline, nor in -next? > Seems it only exists in a patch series you sent yourself? > > Confused... See the previous thread. The previous patch adds this config option to make the current default behavior o

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
On Wed, Oct 29, 2014 at 08:12:49PM +0100, Geert Uytterhoeven wrote: > On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett wrote: > > Document several common practices and conventions regarding conditional > > compilation, most notably the preference for ifdefs in headers rather &g

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
On Wed, Oct 29, 2014 at 05:35:02PM -0700, Randy Dunlap wrote: > On 10/29/14 12:12, Geert Uytterhoeven wrote: > > On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett > > wrote: > >> Document several common practices and conventions regarding conditional > >> compila

Re: [PATCH 3.18] tiny: rename ENABLE_DEV_COREDUMP to ALLOW_DEV_COREDUMP

2014-10-30 Thread Josh Triplett
e it to ALLOW_DEV_COREDUMP to better capture its semantics. > > Signed-off-by: Johannes Berg Seems reasonable. The original "DISABLE" was really "FORCE_DISABLE" (even if used), and the inverse of "FORCE_DISABLE" is not "ENABLE", it's "ALLOW

Re: [PATCH tip/core/rcu 1/6] torture: Run Linux-kernel binary out of results directory

2014-10-30 Thread Josh Triplett
ater builds. This commit therefore runs > the kernel out of the results directory so that less hand-editing is > required to re-run a previous test. > > Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett > tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 4 ++

Re: [PATCH v2] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
; I had attached one in local tree for a while. or even sent it before > several years ago. I don't think we need the full generality of printf in the decompression stub. I prefer Kees' patch, though I'd still like to see __puthex made conditional. - Josh Triplett -- To unsubs

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
er, for size-constrained systems that have nowhere for the output to go at all, it still makes sense to compile all of the printing infrastructure out of the decompression stub, especially since that code itself does not get compressed and thus has a higher impact than code in vmlinux. - Josh Triple

Re: [PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

2014-11-01 Thread Josh Triplett
On Wed, Oct 29, 2014 at 10:00:54PM +0100, Thomas Gleixner wrote: > On Wed, 29 Oct 2014, Josh Triplett wrote: > > v3: Eliminated several #ifdefs, and in particular almost all #ifdefs in > > .c files, by adding a macro INIT_SET_IOPL_MASK to use in place of > >

[PATCH v4 00/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-02 Thread Josh Triplett
, as requested by Thomas Gleixner. I've verified that this compiles after each patch. Josh Triplett (10): x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling x86: tss: Eliminate fragile calculation of TSS segment limit x86: processor.h: Introduce macros to initiali

[PATCH v4 01/10] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling

2014-11-02 Thread Josh Triplett
; move the resulting identical code to a static inline in a common header. Signed-off-by: Josh Triplett Acked-by: Kees Cook --- arch/x86/kernel/process-io.h | 22 ++ arch/x86/kernel/process_32.c | 28 arch/x86/kernel/process_64.c | 25

[PATCH v4 03/10] x86: processor.h: Introduce macros to initialize IO fields of thread and TSS

2014-11-02 Thread Josh Triplett
No functional change, just splitting out parts of the existing INIT_THREAD and INIT_TSS macros. This will simplify making those fields optional later. Signed-off-by: Josh Triplett --- arch/x86/include/asm/processor.h | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions

[PATCH v4 04/10] x86: paravirt: Wrap initialization of set_iopl_mask in a macro

2014-11-02 Thread Josh Triplett
This will allow making set_iopl_mask optional later. Signed-off-by: Josh Triplett --- arch/x86/include/asm/paravirt_types.h | 1 + arch/x86/kernel/paravirt.c| 2 +- arch/x86/xen/enlighten.c | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch

[PATCH v4 02/10] x86: tss: Eliminate fragile calculation of TSS segment limit

2014-11-02 Thread Josh Triplett
That then removes the last use of IO_BITMAP_OFFSET, so delete it. Signed-off-by: Josh Triplett Acked-by: Alexander van Heukelum --- arch/x86/include/asm/desc.h | 11 +-- arch/x86/include/asm/processor.h | 4 +++- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/x

[PATCH v4 06/10] x86: process: Introduce helper to clear a thread's IO bitmap

2014-11-02 Thread Josh Triplett
This will make it easier to make the io_bitmap_ptr field optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 5 + arch/x86/kernel/process_32.c | 4 ++-- arch/x86/kernel/process_64.c | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/x86

[PATCH v4 07/10] x86: process: Introduce helper to switch iopl mask

2014-11-02 Thread Josh Triplett
This simplifies __switch_to a bit, and will make it easier to make iopl optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 13 + arch/x86/kernel/process_32.c | 9 + 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel

[PATCH v4 05/10] x86: cpu: Add helper function unifying 32-bit and 64-bit IO init in cpu_init

2014-11-02 Thread Josh Triplett
-related fields optional later. Signed-off-by: Josh Triplett --- arch/x86/include/asm/processor.h | 14 ++ arch/x86/kernel/cpu/common.c | 12 ++-- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h

[PATCH v4 10/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-02 Thread Josh Triplett
8576 384 -8192 Signed-off-by: Josh Triplett --- arch/x86/Kconfig | 10 ++ arch/x86/include/asm/paravirt.h | 2 ++ arch/x86/include/asm/paravirt_types.h | 4 arch/x86/include/asm/processor.h | 19 ++- arch/x86/include/asm

[PATCH v4 09/10] x86: process: Introduce helper to switch IO bitmap

2014-11-02 Thread Josh Triplett
This simplifies __switch_to_xtra, and will make it easier to make IO optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 23 +++ arch/x86/kernel/process.c| 14 +- 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a

[PATCH v4 08/10] x86: process: Introduce helper for IO-related bits of exit_thread

2014-11-02 Thread Josh Triplett
This makes the two major functions of exit_thread (IO and FPU) more obvious, and will make it easier to make IO optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 20 arch/x86/kernel/process.c| 20 +++- 2 files changed, 23

Re: [PATCH 3/3] x86_64,vsyscall: Make vsyscall emulation configurable

2014-10-28 Thread Josh Triplett
ny amount of core mm code that supports a gate area, > and possibly 4k for a wasted pagetable. The latter is because the > vsyscall addresses are misaligned and fit poorly in the fixmap. > > Signed-off-by: Andy Lutomirski One minor nit below, but with or without that change, Re

Re: linux-next: manual merge of the tiny tree with the tip tree

2014-10-29 Thread Josh Triplett
On Tue, Sep 23, 2014 at 10:36:03AM +0200, Ingo Molnar wrote: > * Josh Triplett wrote: > > I've dropped tiny/no-io from tiny/next; I'll poke at it further > > and resubmit for the x86 tree later, likely not for the next > > merge window at this point. > > &

[PATCH v3 2/3] x86: tss: Eliminate fragile calculation of TSS segment limit

2014-10-29 Thread Josh Triplett
That then removes the last use of IO_BITMAP_OFFSET, so delete it. Signed-off-by: Josh Triplett Acked-by: Alexander van Heukelum --- v3: No changes in this patch, only in patch 3/3. arch/x86/include/asm/desc.h | 11 +-- arch/x86/include/asm/processor.h | 4 +++- 2 files changed, 4

[PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

2014-10-29 Thread Josh Triplett
257-107 __switch_to_xtra 234 123-111 sys_ioperm 240 --240 init_tss8576 384 -8192 Signed-off-by: Josh Triplett --- v3: Eliminated several #ifdefs, and in particular almost all

[PATCH v3 1/3] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling

2014-10-29 Thread Josh Triplett
; move the resulting identical code to a static inline in a common header. Signed-off-by: Josh Triplett Acked-by: Kees Cook --- v3: No changes in this patch, only in patch 3/3. arch/x86/kernel/process-io.h | 22 ++ arch/x86/kernel/process_32.c | 28

[PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
Document several common practices and conventions regarding conditional compilation, most notably the preference for ifdefs in headers rather than .c files. Signed-off-by: Josh Triplett --- I found myself explaining a few of these unwritten rules in patch feedback, so I figured I'd doc

Re: [PATCH 2/5] fs/anon_inodes.c: Simplify control flow in anon_inode_getfd()

2014-10-12 Thread Josh Triplett
fine IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) ... static inline bool __must_check IS_ERR(__force const void *ptr) { return IS_ERR_VALUE((unsigned long)ptr); } So unless GCC fails to propagate expected-value handling through static inline functions, you should never need t

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-15 Thread Josh Triplett
a way to > > switch off DEV_COREDUMP regardless if any drivers select > > WANT_DEV_COREDUMP. > > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to > > 'n' (as in allnconfig or tinyconfig) will effectively disable device > >

[PATCH 1/2] init/Kconfig: Hide printk log config if CONFIG_PRINTK=n

2014-10-03 Thread Josh Triplett
The buffers sized by CONFIG_LOG_BUF_SHIFT and CONFIG_LOG_CPU_MAX_BUF_SHIFT do not exist if CONFIG_PRINTK=n, so don't ask about their size at all. Signed-off-by: Josh Triplett --- Posting for review. I can upstream this through the tiny tree. init/Kconfig | 2 ++ 1 file changed, 2 inser

[PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
on FUTEX. With this change, the subsequent items display as part of the EXPERT menu again; the EMBEDDED menu now appears as the next top-level item in the General Setup menu, which makes General Setup much shorter and more usable. Signed-off-by: Josh Triplett --- Posting for review. I can upstr

Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: > On 10/03/14 16:31, Josh Triplett wrote: > > commit 03b8c7b623c80af264c4c8d6111e5c6289933666 ("futex: Allow > > architectures to skip futex_atomic_cmpxchg_inatomic() test") added the > > HAVE_FUTEX_C

Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
On Fri, Oct 03, 2014 at 05:00:18PM -0700, Randy Dunlap wrote: > On 10/03/14 16:47, Josh Triplett wrote: > > On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: > >> On 10/03/14 16:31, Josh Triplett wrote: > >>> commit 03b8c7b623c80af264c4c8d61

[GIT PULL 3.17] tinification: Kconfig bugfixes for 3.17

2014-10-03 Thread Josh Triplett
han waiting for 3.18. Josh Triplett (2): init/Kconfig: Hide printk log config if CONFIG_PRINTK=n init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu init/Kconfig | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe lin

[GIT PULL 3.18] tinification for 3.18

2014-10-03 Thread Josh Triplett
-- Tinification for 3.18 ---- Josh Triplett (10): x86, platform, kconfig: move kvmconfig functionality to a helper x86: Add "make tinyconfig" to configure the tiniest possible kernel x86

Re: [PATCH] rcutorture: Remove obsolete kversion param in kvm.sh

2014-10-04 Thread Josh Triplett
On Sat, Oct 04, 2014 at 01:04:15PM -0400, Pranith Kumar wrote: > Now that we have removed configs based on kernel version, we can also remove > the > kversion parameter in kvm.sh. > > Signed-off-by: Pranith Kumar Reviewed-by: Josh Triplett > .../selftests/rcutorture/bin

[GIT PULL 3.18] tinification for 3.18

2014-10-05 Thread Josh Triplett
n' into tiny/next (2014-09-22 23:14:40 -0700) Tinification for 3.18 ---- Josh Triplett (10): x86, platform, kconfig: move kvmconfig functionality to a helper x86: Add "make tinyconfig" to co

Re: [PATCH net] bpf: split eBPF out of NET

2014-10-23 Thread Josh Triplett
On Thu, Oct 23, 2014 at 06:41:08PM -0700, Alexei Starovoitov wrote: > introduce two configs: > - hidden CONFIG_BPF to select eBPF interpreter that classic socket filters > depend on > - visible CONFIG_BPF_SYSCALL (default off) that tracing and sockets can use > > that solves several problems: >

Re: [PATCH net] bpf: split eBPF out of NET

2014-10-24 Thread Josh Triplett
On Thu, Oct 23, 2014 at 10:32:50PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 23, 2014 at 8:23 PM, Josh Triplett wrote: > > On Thu, Oct 23, 2014 at 06:41:08PM -0700, Alexei Starovoitov wrote: > >> introduce two configs: > >> - hidden CONFIG_BPF to select eBPF inte

Re: [PATCH] lib/flex_array: make build optional

2014-11-06 Thread Josh Triplett
e this to the user via Kconfig? > > > > > > No sane person would even turn it on if they don't need it. > > > > IOW, I think you should just make it: > > > > config FLEX_ARRAY > > def_bool n > > Joe Pershes complained on a similar patc

Re: [PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Josh Triplett
es to the MAINTAINERS file (perhaps in the same entry as get_maintainer.pl), so that get_maintainer.pl does not fall back to git history for them? - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] scripts/ksize: Add kernel build size report

2014-11-08 Thread Josh Triplett
; > Signed-off-by: Darren Hart > Cc: Josh Triplett One comment below; with that addressed: Reviewed-by: Josh Triplett > +def main(argv): > +try: > +opts, args = getopt.getopt(argv[1:], "dh", ["help"]) > +except getopt.GetoptError

Re: [PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Josh Triplett
On Sat, Nov 08, 2014 at 12:49:29PM -0800, Joe Perches wrote: > On Sat, 2014-11-08 at 11:01 -0800, Josh Triplett wrote: > > On Sat, Nov 08, 2014 at 08:37:27PM +0200, Oded Gabbay wrote: > > > CREDITS | 7 +++ > > > MAINTAINERS | 10 ++ > >

Re: linux-next: build failure after merge of the tiny tree

2014-11-09 Thread Josh Triplett
d catch, thanks. Not clear why that build failure didn't show up on x86. Looks like the two compat syscalls need cond_syscall lines as well. I'll add those to the patch. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH v4 10/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-03 Thread Josh Triplett
On Mon, Nov 03, 2014 at 12:10:49PM +, One Thousand Gnomes wrote: > On Sun, 2 Nov 2014 09:33:01 -0800 > Josh Triplett wrote: > > > On the vast majority of modern systems, no processes will use the > > userspsace IO syscalls, iopl and ioperm. Add a new config option, >

Re: [PATCH] compiler: Correct macro parameter expansion problem

2014-11-03 Thread Josh Triplett
gt; > Signed-off-by: Mark Rustad > Tested-by: Aaron Brown > Signed-off-by: Jeff Kirsher Good catch. Reviewed-by: Josh Triplett > include/linux/compiler.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/compiler.h b/include/li

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-11-03 Thread Josh Triplett
On Mon, Nov 03, 2014 at 09:47:40AM -0800, Joe Perches wrote: > On Mon, 2014-11-03 at 11:46 -0500, Jonathan Corbet wrote: > > On Wed, 29 Oct 2014 11:15:17 -0700 > > Josh Triplett wrote: > > > > > Document several common practices and conventions regarding condi

Re: [PATCH] kernel: make rcu/tree_trace.c explicitly non-modular

2015-08-25 Thread Josh Triplett
8780f96b54a2 (""Tree RCU": scalable > classic RCU implementation") since it is not needed here either. > > We leave some tags like MODULE_AUTHOR for documentation purposes. > > Cc: "Paul E. McKenney" > Cc: Josh Triplett > Cc: Steven Rostedt > Cc:

Re: [PATCH] x86/mm, efi: Check for valid image type

2015-07-29 Thread Josh Triplett
from early_ioremap. We need to never follow the pointer in the > > first place after a kexec, unless we have some way to know that it's > > actually valid. > > So you assume that the information from ACPI is always correct then? > The pointer is correct, the information it po

<    5   6   7   8   9   10   11   12   13   14   >