Re: [PATCH v2 1/1] drm/prime: Use sg_dma_len() macro to get sg's length

2019-01-07 Thread Daniel Vetter
h needs to be used here instead of for_each_sg (which is only valid for iterating over the cpu side mapping/struct page). -Daniel > - len = sg->length; > + len = sg_dma_len(sg); > page = sg_page(sg); > addr = sg_dma_address(sg); > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 3/3] drm/dp_mst: Add __must_check to drm_dp_mst_topology_mgr_resume()

2019-01-08 Thread Daniel Vetter
the driver should do > * a full MST reprobe, in case we were undocked. > */ > -int drm_dp_mst_topology_mgr_resume(struct drm_dp_mst_topology_mgr *mgr) > +int __must_check I think you need the must_check only in the header. With that fixed: Reviewed-by: Daniel Vetter > +drm_dp_mst_topolo

Re: [PATCH v2 1/2] drm/fb-helper: Partially bring back workaround for bugs of SDL 1.2

2019-01-08 Thread Daniel Vetter
; > - info->var.blue.length = 5; > - info->var.transp.offset = 0; > - break; > - case 24: > - info->var.red.offset = 16; > - info->var.green.offset = 8; > - info->var.blue.offset = 0; > - info->var.red.length = 8; > - info->var.green.length = 8; > - info->var.blue.length = 8; > - info->var.transp.offset = 0; > - info->var.transp.length = 0; > - break; > - case 32: > - info->var.red.offset = 16; > - info->var.green.offset = 8; > - info->var.blue.offset = 0; > - info->var.red.length = 8; > - info->var.green.length = 8; > - info->var.blue.length = 8; > - info->var.transp.offset = 24; > - info->var.transp.length = 8; > - break; > - default: > - break; > - } > + drm_fb_helper_fill_pixel_fmt(&info->var, fb->format->depth); > > info->var.xres = fb_width; > info->var.yres = fb_height; > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: linux-next: build failure after merge of the drm-misc tree

2019-01-08 Thread Daniel Vetter
quot;) > > from Linus' tree (merged during the merge window). > > Its not obvious how to fix this up, so I have used the drm-misc tree > from next-20190107 for today. https://cgit.freedesktop.org/drm-tip/tree/fixups/drm-misc-next.patch?h=rerere-cache is the fixup you want. Should get baked into drm-next any moment, since the first drm-misc-next pull is already out. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit

2018-12-24 Thread Daniel Vetter
afael's acpi pull for v4.21. > > Usually such fixes go through the same tree as the offending commit, > so I'd expect Raphael to pick up the whole series and forward it to > Linus in the second half of the merge window. I'm not sure if that's > how it'll play out

Re: [PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-24 Thread Daniel Vetter
h. It's a bad pattern to introduce dead code as a placeholder for > some future work, though. This code has been in the tree for three major > kernel releases (v4.{18,19,20}) without providing any useful functionality. Getting PSR enabled by default on at least a few platforms took years. Insisting that we do not ever merge such code also doesn't work. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] dma-buf: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-12-24 Thread Daniel Vetter
w(&s, NULL); > > for (i = 0; i < s.count; i += DUMP_CHUNK) { > if ((s.count - i) > DUMP_CHUNK) { > -- > 2.17.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH][next] drm: fix null pointer dereference on null state pointer

2018-12-24 Thread Daniel Vetter
tate_put(state); > > +out_drop_locks: > drm_modeset_drop_locks(&ctx); > drm_modeset_acquire_fini(&ctx); > > -- > 2.19.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v3 9/9] MAINTAINERS: Add maintainer for arm komeda driver

2018-12-24 Thread Daniel Vetter
iviu Dudau > > M: Brian Starkey > > -- > > 2.17.1 > > > > -- > > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --- > ¯\_(ツ)_/¯ -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] drm/drm_drv.c: Remove duplicate header

2018-12-27 Thread Daniel Vetter
ot;drm_legacy.h" > #include "drm_internal.h" > -#include "drm_crtc_internal.h" > > /* > * drm_debug: Enable debug output. > -- > 2.17.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org

Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Daniel Vetter
var.blue.length = 5; > - info->var.transp.offset = 0; > - break; > - case 24: > - info->var.red.offset = 16; > - info->var.green.offset = 8; > - info->var.blue.offset = 0; > - info->var.red.length = 8; > - info->var.green.length = 8; > - info->var.blue.length = 8; > - info->var.transp.offset = 0; > - info->var.transp.length = 0; > - break; > - case 32: > - info->var.red.offset = 16; > - info->var.green.offset = 8; > - info->var.blue.offset = 0; > - info->var.red.length = 8; > - info->var.green.length = 8; > - info->var.blue.length = 8; > - info->var.transp.offset = 24; > - info->var.transp.length = 8; > - break; > - default: > - break; > - } > + drm_fb_helper_fill_pixel_fmt(&info->var, fb->format->depth); > > info->var.xres = fb_width; > info->var.yres = fb_height; > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v1 1/7] drm: move DRM_IF_VERSION to drm_internal.h

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 10:03:47PM +0100, Sam Ravnborg wrote: > Move DRM_IF_VERSION out of drmP.h to allow users > to get rid of the drmP include. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc:

Re: [PATCH v1 2/7] drm: move DRM_SWITCH_POWER defines to drm_device.h

2018-12-27 Thread Daniel Vetter
nes to the file where > drm_device.switch_power_state is defined. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- > include/drm/drmP.h | 5 - > include/drm/drm_d

Re: [PATCH v1 3/7] drm: move drm_can_sleep() to drm_util.h

2018-12-27 Thread Daniel Vetter
gt; > Add include of drm_util.h to all users. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David

Re: [PATCH v3 9/9] MAINTAINERS: Add maintainer for arm komeda driver

2018-12-28 Thread Daniel Vetter
On Fri, Dec 28, 2018 at 12:15 PM james qian wang (Arm Technology China) wrote: > > On Mon, Dec 24, 2018 at 02:05:43PM +0100, Daniel Vetter wrote: > > On Mon, Dec 24, 2018 at 1:33 PM Liviu Dudau wrote: > > > > > > On Fri, Dec 21, 2018 at 10:01:06AM +, j

Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-28 Thread Daniel Vetter
On Fri, Dec 28, 2018 at 04:26:56AM +0500, Ivan Mironov wrote: > On Thu, 2018-12-27 at 13:00 +0100, Daniel Vetter wrote: > > > + /* > > > + * Workaround for SDL 1.2, which is known to be setting all pixel format > > > + * fields values to zero in some cases

Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2018-12-28 Thread Daniel Vetter
return -EINVAL; > > + if (var->pixclock != 0) { > + DRM_DEBUG("fbdev emulation doesn't support changing the pixel > clock, value of pixclock is ignored\n"); > + var->pixclock = 0; > + } > + > if ((drm_format_info_block_width(fb->format, 0) > 1) || > (drm_format_info_block_height(fb->format, 0) > 1)) > return -EINVAL; > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/vc4: Allow fb modifiers early enough to fill IN_FORMATS property

2018-12-28 Thread Daniel Vetter
itializes the structure), before binding > > the components of the driver. > > This makes me wonder if the flag could be removed and replaced with "did > non-NULL modifiers get supplied to plane init?" I think I've tripped > over this flag in other KMS hacking,

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-28 Thread Daniel Vetter
info->var.blue.offset = 0; > - info->var.red.length = 5; > - info->var.green.length = 6; > - info->var.blue.length = 5; > - info->var.transp.offset = 0; > - break; > - case 24: > - info->var.red.offset = 16; > - info->var.green.offset = 8; > - info->var.blue.offset = 0; > - info->var.red.length = 8; > - info->var.green.length = 8; > - info->var.blue.length = 8; > - info->var.transp.offset = 0; > - info->var.transp.length = 0; > - break; > - case 32: > - info->var.red.offset = 16; > - info->var.green.offset = 8; > - info->var.blue.offset = 0; > - info->var.red.length = 8; > - info->var.green.length = 8; > - info->var.blue.length = 8; > - info->var.transp.offset = 24; > - info->var.transp.length = 8; > - break; > - default: > - break; > - } > + drm_fb_helper_fill_pixel_fmt(&info->var, fb->format->depth); > > info->var.xres = fb_width; > info->var.yres = fb_height; > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-10-11 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 09:57:52PM +0530, Souptick Joarder wrote: > Hi Laurent, > On Mon, Oct 1, 2018 at 6:12 PM Noralf Trønnes wrote: > > > > > > Den 01.10.2018 13.56, skrev Laurent Pinchart: > > > Hi Daniel, > > > > > > On Monday, 1 October 20

Re: [PATCH] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-11 Thread Daniel Vetter
*/ > > Then I thought that EOPNOTSUPP could better describe this situation. I think either is an ok choice. EINVAL since afaik upstream never supported this flag, so it's not different from any other flag with on meaning - just another userspace programming bug. > > > + return -EOPNOTSUPP; > > > > &g

Re: [PATCH v7 1/5] drm/atomic_helper: Disallow new modesets on unregistered connectors

2018-10-11 Thread Daniel Vetter
t were just > > removed from the system, without preventing userspace from disabling > > DPMS on those connectors. > > > > Changes since v5: > > - Fix typo in comment, nothing else > > > > Signed-off-by: Lyude Paul > > Reviewed-by: Daniel Vette

Re: [PATCH] drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors

2018-10-11 Thread Daniel Vetter
ion with vsyrjala, we decided the best course of > > action would be to just move the unregistered connector checks out of > > update_connector_routing() and into drm_atomic_set_crtc_for_connector(). > > The reason for this being that legacy modesetting isn't going to be > >

Re: [PATCH -next] drm: Use PTR_ERR_OR_ZERO in drm_fb_cma_fbdev_init()

2018-10-11 Thread Daniel Vetter
urn PTR_ERR(fbdev_cma); > - > - return 0; > + return PTR_ERR_OR_ZERO(fbdev_cma); > } > EXPORT_SYMBOL_GPL(drm_fb_cma_fbdev_init); > > > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > h

Re: [PATCH] Add a skeleton Travis-CI config

2018-10-04 Thread Daniel Vetter
s.yml | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100644 .travis.yml > > diff --git a/.travis.yml b/.travis.yml > new file mode 100644 > index ..ba1e59dd44f6 > --- /dev/null > +++ b/.travis.yml > @@ -0,0 +1,23 @@ > +language: c

Re: [PATCH] Add a skeleton Travis-CI config

2018-10-04 Thread Daniel Vetter
On Thu, Oct 4, 2018 at 9:11 PM Rob Herring wrote: > > On Thu, Oct 4, 2018 at 3:33 AM Daniel Vetter wrote: > > > > On Thu, Oct 4, 2018 at 12:27 AM Rob Herring wrote: > > > > > > It's convenient to use Travis-CI for doing kernel builds. Doing so > >

Re: [Ksummit-discuss] [PATCH 1/2] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-07 Thread Daniel Vetter
he legal situation, if you get a bug report through a private channel, or at least a channel that hides private address information (like Bugzilla does, albeit sloppily), then you do have to ask for explicit consent to publishing that information. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Ksummit-discuss] [PATCH 0/2] code of conduct fixes

2018-10-07 Thread Daniel Vetter
w. This would give us the time to discuss all the details properly and with all due deliberation. I'm travelling next week, so not the right guy to push this, but I'd be happy to ack such a patch (or something along the same lines). I also believe that this statement is undisputed enough

Re: [Ksummit-discuss] [PATCH 0/2] code of conduct fixes

2018-10-07 Thread Daniel Vetter
On Sun, Oct 7, 2018 at 7:40 PM James Bottomley wrote: > > On Sun, 2018-10-07 at 19:11 +0200, Daniel Vetter wrote: > > Hi James, > > > > On Sat, Oct 6, 2018 at 11:36 PM James Bottomley > > wrote: > > > We've had several threads discussing potential ch

Re: [PATCH] kthread: finer-grained lockdep/cross-release completion

2018-10-18 Thread Daniel Vetter
On Fri, Mar 16, 2018 at 12:26 AM Byungchul Park wrote: > > On 3/15/2018 9:41 PM, Peter Zijlstra wrote: > > On Thu, Mar 15, 2018 at 11:31:57AM +0100, Daniel Vetter wrote: > >> Is there any progress on getting cross-release enabled again? > > > > Not yet, I'

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-16 Thread Daniel Vetter
Daniel > > -Kees > > > Cc: Kees Cook > > Cc: Andy Lutomirski > > Cc: Will Drewry > > Cc: Andrew Morton > > Cc: Dave Airlie > > Cc: Daniel Vetter > > Cc: Lucas Stach > > Cc: Rasmus Villemoes > > Cc: Cyrill Gorcunov

Re: DMA-buf and uncached system memory

2021-02-16 Thread Daniel Vetter
If you do want to solve this at the dma-buf level I can try and point you at the respective i915 and amdgpu code that makes the magic work - I've had to fix it a few times in the past. I'm not sure whether we'd need to pass the dynamic nature through though, i.e. whether

Re: [PATCH] mutex: nuke mutex_trylock_recursive

2021-02-16 Thread Daniel Vetter
On Tue, Feb 16, 2021 at 09:21:46AM +0100, Christian König wrote: > The last user went away in the 5.11 cycle. > > Signed-off-by: Christian König Nice. Reviewed-by: Daniel Vetter I think would be good to still stuff this into 5.12 before someone resurrects this zombie

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-04-08 Thread Daniel Vetter
On Mon, Mar 29, 2021 at 10:31:01AM -0300, Jason Gunthorpe wrote: > On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > > Both kvm (in bd2fae8da794 ("KVM: do not assume PTE is writable after > > follow_pfn")) and vfio (in 07956b6269d3 ("vfio/type1: Use

Re: linux-next: build warning after merge of the drm-intel-fixes tree

2021-04-08 Thread Daniel Vetter
t; > > Introduced by commit > > > > > > 8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic") > > > > This warning now exists in Linus' tree. > > > > -- > > Cheers, > > Stephen Rothwell > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/drm_internal.h: Remove repeated struct declaration

2021-04-08 Thread Daniel Vetter
t drm_file *file_priv, > struct drm_gem_object *obj, > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 0/8] drm/msm: Swappable GEM objects

2021-04-08 Thread Daniel Vetter
; dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock

2021-04-08 Thread Daniel Vetter
unt = 0;/* Currently no users */ > dev_priv->suspended = false;/* And not suspended */ > - spin_lock_init(&power_ctrl_lock); > mutex_init(&power_mutex); > > if (dev_priv->ops->init_pm) > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv

2021-04-08 Thread Daniel Vetter
fig ui tends to suck. If you want to change this, we need automatic conflict resolution like apt and other package managers have, with suggestions how to fix the config if you want to enable a driver, but some of its requirements are missing. The current approach of hiding driver symbols complete if any of their dependencies are off is really not great. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/syncobj: use newly allocated stub fences

2021-04-08 Thread Daniel Vetter
ay_free(syncobjs, args->count_handles); > > diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h > index 9f12efaaa93a..6ffb4b2c6371 100644 > --- a/include/linux/dma-fence.h > +++ b/include/linux/dma-fence.h > @@ -587,6 +587,7 @@ static inline signed long dma_fence_wait(struct dma_fence > *fence, bool intr) > } > > struct dma_fence *dma_fence_get_stub(void); > +struct dma_fence *dma_fence_allocate_private_stub(void); > u64 dma_fence_context_alloc(unsigned num); > > #define DMA_FENCE_TRACE(f, fmt, args...) \ > -- > 2.31.0.208.g409f899ff0-goog > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 01:40:59PM +0200, Paolo Bonzini wrote: > On 08/04/21 12:05, Daniel Vetter wrote: > > On Mon, Mar 29, 2021 at 10:31:01AM -0300, Jason Gunthorpe wrote: > > > On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > > > > Both kvm (in bd2

Re: [RFC 1/4] dma-buf: Add constraints sharing information

2014-12-10 Thread Daniel Vetter
On Wed, Dec 10, 2014 at 07:01:16PM +0530, Sumit Semwal wrote: > Hi Daniel, > > Thanks a bunch for your review comments! A few comments, post our > discussion at LPC; > > On 12 October 2014 at 00:25, Daniel Vetter wrote: > > On Sat, Oct 11, 2014 at 01:37:55AM +0530, Sum

Re: [drm-intel:topic/core-stuff 32/37] drivers/gpu/drm/drm_crtc.c:4472 drm_mode_crtc_set_gamma_size() warn: double check that we're allocating correct size: 2 vs 6

2014-12-10 Thread Daniel Vetter
Forgotten to add mailing lists. -Daniel On Wed, Dec 10, 2014 at 3:53 PM, Daniel Vetter wrote: > On Wed, Dec 10, 2014 at 3:03 PM, Dan Carpenter > wrote: >> From a style prespective this should be: >> >> crtc->gamma_store = kcalloc(gamm

Re: [PATCH RFC v7 16/21] drm: panel: Add support for Himax HX8369A MIPI DSI panel

2015-01-05 Thread Daniel Vetter
ple don't have to go through all the invidual patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org M

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
On Wed, Dec 03, 2014 at 11:07:08AM -0800, John Stultz wrote: > On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter wrote: > > On Tue, Dec 02, 2014 at 08:54:13AM -0800, John Stultz wrote: > >> On Tue, Dec 2, 2014 at 8:35 AM, Chris Wilson > >> wrote: > >> > O

[PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
sions. Signed-off-by: Thomas Gleixner Acked-by: Daniel Vetter Signed-off-by: John Stultz So fix this up by reinstating our handrolled _timeout function. While at it bother with handling MAX_JIFFIES. v2: Convert to usecs (we don't care about the accuracy anyway) first to avoid overf

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
On Thu, Dec 4, 2014 at 6:42 PM, John Stultz wrote: > On Thu, Dec 4, 2014 at 2:42 AM, Daniel Vetter wrote: >> On Wed, Dec 03, 2014 at 11:07:08AM -0800, John Stultz wrote: >>> On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter wrote: >>> > On Tue, Dec 02, 2014 at 08:54

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread Daniel Vetter
On Thu, Dec 4, 2014 at 7:16 PM, John Stultz wrote: > On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter wrote: >> On Thu, Dec 4, 2014 at 6:42 PM, John Stultz wrote: >>> Sigh. So you're going to make me write a separate patch that moves it over? >> >> We've wri

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-05 Thread Daniel Vetter
On Thu, Dec 04, 2014 at 12:35:44PM -0800, John Stultz wrote: > On Thu, Dec 4, 2014 at 10:51 AM, Daniel Vetter wrote: > > On Thu, Dec 4, 2014 at 7:16 PM, John Stultz wrote: > >> On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter > >> wrote: > >>> On T

Re: [Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Daniel Vetter
0; i < NUM_L3_SLICES(dev); i++) > i915_gem_l3_remap(&dev_priv->ring[RCS], i); > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41

Re: [Intel-gfx] [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM

2014-12-05 Thread Daniel Vetter
one a quick read-through of just the i915 bits too, same comment. I guess this is just the first RFC and the redesign we've discussed about already with xengt is in progress somewhere? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.f

Re: [Intel-gfx] [PATCH] drm/i915: release struct_mutex on the i915_gem_init_hw fail path

2014-12-05 Thread Daniel Vetter
9eeaf64718434242bb7c76 > > Author: Daniel Vetter > > Date: Thu Nov 20 00:33:07 2014 +0100 > > > > drm/i915: Only init engines once > > > > Reported-by: Wei Yongjun > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/

Re: [PATCH] gpu: drm: i915: intel_display.c: Remove unused function

2014-12-08 Thread Daniel Vetter
r 3.20, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [Intel-gfx] [ANNOUNCE][RFC] KVMGT - the implementation of Intel GVT-g(full GPU virtualization) for KVM

2014-12-08 Thread Daniel Vetter
ntroller setting and for some display stuff. But neither of that really applies to paravirtualized hw. And if there's any case like that we should patch it out (like we do with some of the runtime pm code already). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://

Re: [PATCH] gpu: drm: i915: intel_dp.c: Remove unused function

2014-12-08 Thread Daniel Vetter
drv.h > index ba71522..6ad239d 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -941,7 +941,6 @@ void intel_edp_panel_on(struct intel_dp *intel_dp); > void intel_edp_panel_off(struct intel_dp *intel_dp); > void intel_edp_psr_enable(struct inte

Re: [PATCH 7/20] drm/i915: fix misspelling of current function in string

2014-12-08 Thread Daniel Vetter
ded to refer > > to the function in which the problem is detected. > > Hmm, DRM_DEBUG prints __func__ too. We've killed the pin ioctl for 3.20 hence didn't even bother to come up with an opinion ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 36

Re: [Intel-gfx] [PATCH] gpu: drm: i915: intel_display.c: Remove unused function

2014-12-08 Thread Daniel Vetter
On Mon, Dec 08, 2014 at 10:32:49AM -0200, Paulo Zanoni wrote: > 2014-12-08 6:42 GMT-02:00 Daniel Vetter : > > On Sun, Dec 07, 2014 at 07:29:17PM +0100, Rickard Strandqvist wrote: > >> Remove the function intel_output_name() that is not used anywhere. > >> > >>

Re: [Intel-gfx] [BUG, bisect] drm/i915: mouse pointer lags and overshoots

2015-01-24 Thread Daniel Vetter
On Fri, Jan 23, 2015 at 10:57:32PM -0800, Jeremiah Mahler wrote: > all, > > On Tue, Jan 20, 2015 at 06:48:42AM +0100, Daniel Vetter wrote: > > On Mon, Jan 19, 2015 at 08:40:24AM -0800, Matt Roper wrote: > > > On Mon, Jan 19, 2015 at 11:04:04AM +, Chris Wilson wrote

Re: [PATCH] next: drm/atomic: Use copy_from_user to copy 64 bit data from user space

2015-01-14 Thread Daniel Vetter
___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: sen

Re: [PATCH 2/2] drm/msm/mdp5: Add hardware cursor support

2015-01-14 Thread Daniel Vetter
*mdp5_crtc_init(struct drm_device *dev, > mdp5_crtc->lm = GET_LM_ID(id); > > spin_lock_init(&mdp5_crtc->lm_lock); > + spin_lock_init(&mdp5_crtc->cursor.lock); > > mdp5_crtc->vblank.irq = mdp5_crtc_vblank_irq; > mdp5_crtc->err.irq = mdp5_cr

Re: [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Daniel Vetter
t;> From: Chris Wilson >> >> commit f96de58fc7e7d3d717c7c63975c3b896c906b5e3 upstream. >> >> Signed-off-by: Chris Wilson >> Reviewed-by: Jani Nikula >> Signed-off-by: Daniel Vetter >> Signed-off-by: Luis Henriques > > Should this also be applied to any older stable

Re: [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Daniel Vetter
On Mon, Jan 12, 2015 at 6:43 PM, Luis Henriques wrote: > On Mon, Jan 12, 2015 at 06:20:22PM +0100, Daniel Vetter wrote: >> On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings wrote: >> > On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote: >> >> 3.16.7-ckt3 -stabl

Re: [PATCH v2 1/2] drm: Drop superfluous "select VT_HW_CONSOLE_BINDING"

2015-01-12 Thread Daniel Vetter
ose this option if you have a Rockchip soc chipset. > -- > 1.9.1 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0

Re: [PATCH 2/2] drm/msm/mdp5: Add hardware cursor support

2015-01-16 Thread Daniel Vetter
On Thu, Jan 15, 2015 at 08:46:46AM -0500, Rob Clark wrote: > On Wed, Jan 14, 2015 at 7:55 PM, Daniel Vetter wrote: > > On Tue, Jan 13, 2015 at 05:18:04PM -0500, Stephane Viau wrote: > >> From: Beeresh Gopal > >> > >> This patch implements the hardware acce

Re: [Intel-gfx] [BUG, bisect] drm/i915: mouse pointer lags and overshoots

2015-01-19 Thread Daniel Vetter
On 19/01/2015 10:08, Ville Syrjälä wrote: On Sat, Jan 17, 2015 at 02:06:35AM -0800, Jeremiah Mahler wrote: Matt, all, Commit ea2c67bb4aff introduces a bug which causes the mouse to move in a very unusual way, as if it has a lot of inertia. It will lag behind and then overshoot the expected pos

Re: [PATCH 2/2] drm/msm/mdp5: Add hardware cursor support

2015-01-19 Thread Daniel Vetter
On Sat, Jan 17, 2015 at 08:46:05AM -0500, Rob Clark wrote: > On Fri, Jan 16, 2015 at 11:06 PM, Daniel Vetter wrote: > > On Thu, Jan 15, 2015 at 08:46:46AM -0500, Rob Clark wrote: > >> On Wed, Jan 14, 2015 at 7:55 PM, Daniel Vetter wrote: > >> > On Tue, Jan 13, 2015

Re: [Intel-gfx] [BUG, bisect] drm/i915: mouse pointer lags and overshoots

2015-01-19 Thread Daniel Vetter
On Mon, Jan 19, 2015 at 08:40:24AM -0800, Matt Roper wrote: > On Mon, Jan 19, 2015 at 11:04:04AM +, Chris Wilson wrote: > > On Mon, Jan 19, 2015 at 11:51:43AM +0100, Daniel Vetter wrote: > > > There's also an issue in (most) X drivers which exaberates this > >

Re: [Intel-gfx] [PATCH] drivers: gpu: drm: i915: intel_fifo_underrun.c: Fix a typo in comment

2015-01-27 Thread Daniel Vetter
this typo in comment. > > > > Signed-off-by: Kumar Amit Mehta > > Reviewed-by: Jani Nikula Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] drm/layerscape: Add fsl dcu DRM driver

2015-03-19 Thread Daniel Vetter
fsl_dev->regmap, DCU_CTRLDESCLN_4(index), > + DCU_CTRLDESCLN_4_EN | > + DCU_CTRLDESCLN_4_TRANS(alpha) | > + DCU_CTRLDESCLN_4_BPP(bpp) | > + DCU_CTRLDESCLN_4_AB(2)); > + regmap_write(fsl_dev->regmap, DCU

Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-23 Thread Daniel Vetter
On Fri, Mar 20, 2015 at 11:14:40AM +, Javi Merino wrote: > We have grown a number of different implementations of > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > kernel.h so that it can be reused. > > Cc: Daniel Vetter > Cc: Jani Nikula > C

Re: [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

2015-03-23 Thread Daniel Vetter
On Mon, Mar 23, 2015 at 07:25:27AM +0100, Sedat Dilek wrote: > Hi, > > I did my weekly update of the Linux RC (here: v4.0-rc5) and fell over > some warning in the drm area. > > Please have a look... Just to confirm: Both are new in -rc5 and haven't been around in -rc4? Also can you pls give -ni

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-06 Thread Daniel Vetter
ave almost everything there: For the writeback framebuffer we only need a new "WRITEBACK" property (which takes an fb id) and the small extension to create v4l-backed framebuffers. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from

Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-23 Thread Daniel Vetter
; > > Feel free to submit a new patch. > > > > > > > > Regards, > > > > Yongjun Wei > > > > > > > > *From:* John Hunter [mailto:zhjw...@gmail.com] > > *Sent:* 2015年4月22日 10:30 > > *To:* weiyj...@163.com; Daniel Vetter; Jani Nikula; D

Re: [Intel-gfx] [PATCH v2] drm/i915: cope with large i2c transfers

2015-04-23 Thread Daniel Vetter
st repacking for my vacation so probably shouldn't touch git branches right now ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c

2015-04-16 Thread Daniel Vetter
ude > -#include "intel_drv.h" > #include "i915_drv.h" > > /** > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter

Re: [PATCH] Add virtio gpu driver.

2015-03-30 Thread Daniel Vetter
support (drm_irq.c is a mess) hence why the core helpers don't support async flips yet. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-08 Thread Daniel Vetter
7;s consent, > > so no need to reinvent anything there. And with atomic we already have > > almost everything there: For the writeback framebuffer we only need a new > > "WRITEBACK" property (which takes an fb id) and the small extension to > > create v4l-backe

[PATCH] vt: Don't check KD_GRAPHICS when binding/unbinding

2015-04-13 Thread Daniel Vetter
works again reliably, something in the recent fedora upgrades broke things. Cc: Greg Kroah-Hartman Cc: Antonino A. Daplas Cc: David Herrmann Cc: Peter Hurley Cc: Imre Deak Signed-off-by: Daniel Vetter --- drivers/tty/vt/vt.c | 22 ++ 1 file changed, 2 insertions(+), 20 del

[pull] drm-intel-next

2012-07-13 Thread Daniel Vetter
-- Ben Widawsky (1): drm/i915: linuxify create_hw_context() Chris Wilson (2): drm/i915: Group the GT routines together in both code and vtable drm/i915: Implement w/a for sporadic read failures on waking from rc6 Daniel Vetter (15): drm

Re: 3.5-rc6 fb hw inteldrmfb

2012-07-14 Thread Daniel Vetter
27;d be interesting, just to check whether the "removing generic driver" which is new in -rc6 is the cause of this or whether we have a bigger problem with the i915 driver crashing in 3.5-rc. Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ff

Re: 3.5-rc6 fb hw inteldrmfb

2012-07-14 Thread Daniel Vetter
you. Can you please to that? Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [Linaro-mm-sig] [PATCH] device: add dma_params->max_segment_count

2012-07-19 Thread Daniel Vetter
n 0; > + } else > + return -EIO; > +} > + > + > static inline unsigned long dma_get_seg_boundary(struct device *dev) > { > return dev->dma_parms ? > -- > 1.7.9.5 > > > ___ > Linaro-mm-sig mailing list > linaro-mm-...@lists.linaro.org &

Re: [PATCH] treewide: Fix typo compatability -> compatibility

2015-05-27 Thread Daniel Vetter
| 2 +- > 6 files changed, 7 insertions(+), 7 deletions(-) > > I can split this into one patch per subsystem, but that seems a bit overkill. > Can someone take it ? Acked-by: Daniel Vetter for the atomic_helper.c part. -Daniel > > diff --git a/arch/metag/include/asm/elf.h b/ar

Re: [Intel-gfx] [BUG, bisect] Re: drm/i915: WARN_ON(dev_priv->mm.busy)

2015-06-14 Thread Daniel Vetter
Time to read-read 128x128:40.097µs 21.366µs > Time to read-read 256x256:77.087µs 42.608µs > Time to read-read 512x512: 281.999µs 181.155µs > Time to read-read 1024x1024:1196.141µs 1118.223µs > Time to read-read 2048x20

Re: [PATCH] Fixes: 9697dffb098d ("drm: Turn off Legacy Context Functions")

2015-06-17 Thread Daniel Vetter
> *file); > +int drm_legacy_ctxbitmap_cleanup(struct drm_device *dev); > +int drm_legacy_ctxbitmap_free(struct drm_device *dev, int ctx_handle); > +int drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file > *file); > > int drm_legacy_resctx(struct drm_devic

Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-22 Thread Daniel Vetter
ge. -Daniel > > > -- > Best regards, > Varka Bhadram. > > ___________ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: Linux 4.1 WARNING in drm_ioctl.c

2015-06-22 Thread Daniel Vetter
l behaviour, but maybe the report could be > interesting for maintainers. > > Sorry if this has already been reported; if more information is needed just > let me know (please CC: me as I'm not subscribed to lists.) Which drm driver are you using? I didn't spot anyt

Re: Linux 4.1 WARNING in drm_ioctl.c

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 08:27:13AM +0100, Daniel Stone wrote: > Hi, > > On 23 June 2015 at 07:39, Daniel Vetter wrote: > > Which drm driver are you using? I didn't spot anything in your module list > > but might have missed it. Booting with drm.debug=0xe and grabbing

Re: Linux 4.1 WARNING in drm_ioctl.c

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 12:46:09PM +0200, Fabio Coatti wrote: > In data martedì 23 giugno 2015 11:48:47, Daniel Vetter ha scritto: > > On Tue, Jun 23, 2015 at 08:27:13AM +0100, Daniel Stone wrote: > > > Hi, > > > > > > On 23 June 2015 at 07:39, Daniel Vetter

Re: [PATCH] drm/i915: enable BIOS hang workaround for Lenovo T60 too

2015-06-19 Thread Daniel Vetter
for Lenovo ... Anyway this needs Cc: sta...@vger.kernel.org and is for Jani to pick up. Thanks for figuring out what's been broken here. -Daniel > pci_set_power_state(drm_dev->pdev, PCI_D3hot); > > return 0; > -- > 2.1.4 > > _

Re: [RESEND PATCH v2 v4.1-rc8 0/2] drm: prime: Allow exported dma-bufs to be mapped

2015-06-19 Thread Daniel Vetter
d, 7 insertions(+), 7 deletions(-) > > -- > 2.4.3 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [RESEND PATCH v2 v4.1-rc8 2/2] drm: prime: Document gem_prime_mmap

2015-06-19 Thread Daniel Vetter
dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [RESEND PATCH v2 v4.1-rc8 1/2] drm: prime: Honour O_RDWR during prime-handle-to-fd

2015-06-19 Thread Daniel Vetter
_RDWR O_RDWR > #define DRM_CLOEXEC O_CLOEXEC > struct drm_prime_handle { > __u32 handle; > -- > 2.4.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drm/gma500: Remove VLA

2018-05-23 Thread Daniel Vetter
+ u8 buf[MAX_ARG_LEN*2 + 2], status; > > + struct i2c_msg msgs[MAX_ARG_LEN + 3]; > > int i, ret; > > > > + if (args_len > MAX_ARG_LEN) { > > + DRM_ERROR("Need to increase arg length\n"); > > + return false; > > + } > > + > > psb_intel_sdvo_debug_write(psb_intel_sdvo, cmd, args, args_len); > > > > for (i = 0; i < args_len; i++) { > > -- > > 2.14.3 > > > > > > -- > Kees Cook > Pixel Security -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCHv2] drm/i2c: tda998x: Remove VLA usage

2018-05-23 Thread Daniel Vetter
n't add anything further to my git tree > for tda998x development, as that would change what was sent to David > back in April. > > The alternative would be for drm-misc to take it - I don't think it > will conflict with anything I've already asked David to take, so t

Re: [PATCH v2] gpu: drm: udl: Adding new typedef vm_fault_t

2018-05-23 Thread Daniel Vetter
gt;> > >> @@ -114,17 +113,7 @@ int udl_gem_fault(struct vm_fault *vmf) > >> return VM_FAULT_SIGBUS; > >> > >> page = obj->pages[page_offset]; > >> - ret = vm_insert_page(vma, vmf->address, page); > >> - switch (ret) { > >> - case -EAGAIN: > >> - case 0: > >> - case -ERESTARTSYS: > >> - return VM_FAULT_NOPAGE; > >> - case -ENOMEM: > >> - return VM_FAULT_OOM; > >> - default: > >> - return VM_FAULT_SIGBUS; > >> - } > >> + return vmf_insert_page(vma, vmf->address, page); > >> } > >> > >> int udl_gem_get_pages(struct udl_gem_object *obj) > >> -- > >> 1.9.1 > >> > > > > Any comment on this patch ? > > If no comment, we would like to get this patch in queue > for 4.18. 4.18 is done already, queued up for 4.19 in drm-misc-next. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v8 3/3] drm: writeback: Add client capability for exposing writeback connectors

2018-05-24 Thread Daniel Vetter
; */ > > > #define DRM_CLIENT_CAP_ATOMIC3 > > > > > > +/** > > > + * DRM_CLIENT_CAP_WRITEBACK_CONNECTORS > > > + * > > > + * If set to 1, the DRM core will expose special connectors to be used > > > for > > > + * writing back to memory the scene setup in the commit. Depends on > > > client > > > + * also supporting DRM_CLIENT_CAP_ATOMIC > > > + */ > > > +#define DRM_CLIENT_CAP_WRITEBACK_CONNECTORS 4 > > > + > > > /** DRM_IOCTL_SET_CLIENT_CAP ioctl argument type */ > > > struct drm_set_client_cap { > > > __u64 capability; > > > > ~Maarten > > > > -- > > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --- > ¯\_(ツ)_/¯ > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-03 Thread Daniel Vetter
On Thu, Mar 29, 2018 at 01:34:24PM +0200, Christian König wrote: > Am 29.03.2018 um 08:57 schrieb Daniel Vetter: > > On Sun, Mar 25, 2018 at 12:59:56PM +0200, Christian König wrote: > > > Add a peer2peer flag noting that the importer can deal with device > > > resour

Re: [PATCH] drm/atmel-hlcdc: add command line option to specify preferred depth

2018-04-03 Thread Daniel Vetter
t; >> @@ -658,7 +664,7 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) > >> > >>platform_set_drvdata(pdev, dev); > >> > >> - drm_fb_cma_fbdev_init(dev, 24, 0); > >> + drm_fb_cma_fbdev_init(dev, atmel_hlcdc_preferred_depth, 0); > >> > >>drm_kms_helper_poll_init(dev); > >> > >> @@ -756,6 +762,16 @@ static int atmel_hlcdc_dc_drm_probe(struct > >> platform_device *pdev) > >>struct drm_device *ddev; > >>int ret; > >> > >> + switch (atmel_hlcdc_preferred_depth) { > >> + case 0: /* driver default */ > >> + case 8: > >> + case 16: > >> + case 24: > >> + break; > >> + default: > >> + return -EINVAL; > >> + } > >> + > >>ddev = drm_dev_alloc(&atmel_hlcdc_dc_driver, &pdev->dev); > >>if (IS_ERR(ddev)) > >>return PTR_ERR(ddev); > > > > > > > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 1/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-03 Thread Daniel Vetter
't assume that an sgt is struct page backed. And you probably want to check this at import/attach time. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

<    3   4   5   6   7   8   9   10   11   12   >