[PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

2013-04-11 Thread Daniel Vetter
.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8809813..457a0a0 100644 --- a/drive

Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

2013-04-11 Thread Daniel Vetter
On Thu, Apr 11, 2013 at 08:17:42PM +0100, Chris Wilson wrote: > On Thu, Apr 11, 2013 at 08:22:50PM +0200, Daniel Vetter wrote: > > It will be only consistent once we've restored all the crtcs. Since a > > bunch of other callers also want to just restore a single crtc, add a &g

[pull] drm-intel-next

2013-04-15 Thread Daniel Vetter
olVfFArbitrationPriority Chris Wilson (1): drm/i915: Resurrect ring kicking for semaphores, selectively Damien Lespiau (1): drm/i915: Remove platforms in the preliminary_hw_support description Daniel Vetter (4): drm/i915: gen2 has no tv out support Merge tag 'v3.9-rc3&#

Re: [pull] drm-intel-next

2013-04-15 Thread Daniel Vetter
On Mon, Apr 15, 2013 at 09:56:29AM +0200, Daniel Vetter wrote: > Hi Dave, > > Since I expect Linus to open the merge window in about a week I guess this > is the last i915 feature pull for 3.10. Highlights: > Updated testing tree for -next. Highlights: > - Corner case fixes disc

Re: [Intel-gfx] pipe_off wait timed out

2013-05-21 Thread Daniel Vetter
; [] ? kthread_create_on_node+0x150/0x150 > > _______ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - htt

Re: [Intel-gfx] pipe_off wait timed out

2013-05-22 Thread Daniel Vetter
On Wed, May 22, 2013 at 1:24 AM, Dave Jones wrote: > On Wed, May 22, 2013 at 01:10:36AM +0200, Daniel Vetter wrote: > > On Wed, May 22, 2013 at 1:01 AM, Dave Jones wrote: > > > This is new to me as of 3.10-rc2. > > > > If this is an ironlake with a DP output

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-22 Thread Daniel Vetter
en added in the >> next patch. >> - Updated documentation slightly. >> Changes since v2: >> - Renamed everything to ww_mutex. (mlankhorst) >> - Added ww_acquire_ctx and ww_class. (mlankhorst) >> - Added a lot of checks for wrong api usage. (mlankhorst)

Re: [PATCH] drm/i915: Cocci spatch "memdup.spatch"

2013-05-22 Thread Daniel Vetter
On Wed, May 22, 2013 at 11:07:09PM +0200, Thomas Meyer wrote: > > Signed-off-by: Thomas Meyer Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send th

Re: [Linaro-mm-sig] [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-23 Thread Daniel Vetter
hink a bit what to do, and I don't there's much we can do in the implementation (beside all the existing debug support we have) to help. So now I'm leaning more towards dropping the _slow variants to avoid interface proliferation. -Daniel -- Daniel Vetter Software Engineer, Intel Corpor

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Daniel Vetter
r now I suppose the 'global' atomic is ok, if/when we find > it hurts performance we can revisit. I was just spewing ideas :-) We could do a simple ctx->stamp = (local_clock() << nr_cpu_shift) | local_processor_id() to work around any bad luck in grabbing the ticket. Wit

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Daniel Vetter
On Mon, May 27, 2013 at 4:47 PM, Daniel Vetter wrote: > On Mon, May 27, 2013 at 10:21 AM, Peter Zijlstra wrote: >> On Wed, May 22, 2013 at 07:24:38PM +0200, Maarten Lankhorst wrote: >>> >> +static inline void ww_acquire_init(struct ww_acquire_ctx *ctx, >>> >&g

Re: [PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Daniel Vetter
On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -ENOMEM in the kmap() error handling case > instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Queued for -next, thanks for the patch. -Daniel

Re: [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-28 Thread Daniel Vetter
needed_slow, FAILURE, LOCKTYPE_WW); > + printk("\n"); > + > + print_testname("using two ww contexts"); > + dotest(ww_test_two_contexts, FAILURE, LOCKTYPE_WW); > + printk("\n"); > + > + print_testname("finish ww context twice"); > + dote

[PULL] drm-intel-next for 3.11

2013-05-28 Thread Daniel Vetter
to pipe scalers drm/i915: Add platform information to implemented workarounds drm/i915: Add references to some workaround we implement drm/i915: Compute WR PLL dividers dynamically drm/i915: Add missing platform tags to FBC workaround comments Daniel Vetter (56): drm/i915:

Re: [Linaro-mm-sig] [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-29 Thread Daniel Vetter
l/success tests for lock_slow acquiring the right lock. >> >> Otherwise I didn't spot anything that seems missing in these self-tests >> here. >> > Yes it would be nice, doing so is left as an excercise for the reviewer, who > failed to raise this point sooner. ;

Re: [Intel-gfx] [PATCH 0/2] lib/scatterlist: sg_page_iter: support for memory w/o backing pages

2013-03-26 Thread Daniel Vetter
page_iter: support sg lists w/o backing pages > > Revert "drm/i915: set dummy page for stolen objects" > > Both patches are Reviewed-by: Damien Lespiau Both patches merged, with Imre's missing sob line rectified on the 2nd one. -Daniel -- Daniel Vetter Software Engi

Re: [PATCH 0/2] lib/scatterlist: sg_page_iter: support for memory w/o backing pages

2013-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2013 at 12:57:42PM -0700, Andrew Morton wrote: > On Tue, 26 Mar 2013 15:50:20 +0100 Daniel Vetter wrote: > > > On Tue, Mar 26, 2013 at 03:14:17PM +0200, Imre Deak wrote: > > > When adding sg_page_iter I haven't thought properly through the use case >

Re: [ 74/75] Revert "drm/i915: enable irqs earlier when resuming"

2013-03-27 Thread Daniel Vetter
opposed to rc6 on snb+) not know to do anything good like safe power And so disabled by default. So I hope that regression is bearable, feel free to beat the drm/i915 guys as usual for their failings ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http:/

Re: [PATCH] dummy-irq: introduce a dummy IRQ handler driver (was Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-r

2013-04-01 Thread Daniel Vetter
On Sun, Mar 31, 2013 at 9:55 PM, Jiri Kosina wrote: > On Thu, 21 Mar 2013, Daniel Vetter wrote: > >> Indeed, this is pretty useful and allowed me to quickly reproduce that >> phantom irq on my gm45. Thanks to module reloading we can even reset the >> kernel's ir

Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped

2013-03-11 Thread Daniel Vetter
remove the #if 0 clause? I guess we could just put this into a comment explaining where stolen memory for the gfx devices is at on gen2. But tbh I don't mind if we just keep the #if 0 code around. For all newer platforms we can get at that offset through mch bar registers, so I don't rea

Re: [PATCH] gpu: don't cast kzalloc() return value

2013-03-11 Thread Daniel Vetter
On Sun, Mar 10, 2013 at 02:22:48PM +0200, Mihnea Dobrescu-Balaur wrote: > Signed-off-by: Mihnea Dobrescu-Balaur Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this l

Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Daniel Vetter
NPCR_MASK) >> GEN6_MBC_SNPCR_SHIFT; > > - return simple_read_from_buffer(ubuf, max, ppos, buf, len); > + return 0; > } > > -static ssize_t > -i915_cache_sharing_write(struct file *filp, > - const char __user *ubuf, > - size_

Re: [PATCH v2] drm/i915: clarify reasoning for the access_ok call

2013-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2013 at 02:37:35PM -0700, Kees Cook wrote: > This clarifies the comment above the access_ok check so a missing > VERIFY_READ doesn't alarm anyone. > > Signed-off-by: Kees Cook > Cc: Daniel Vetter > --- > v2: > - rewrote comment, thanks to Chris Wil

Re: [PATCH] drm/i915: restrict kernel address leak in debugfs

2013-03-11 Thread Daniel Vetter
..@vger.kernel.org Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-08-05 Thread Daniel Vetter
eady merged a similar patch from Alan Cox for -fixes, should land in 3.6 soonish. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] drm: ignore disconnected <-> unknown status changes

2012-08-05 Thread Daniel Vetter
at we need to avoid these, for the current kms locking would stall the cursor for a while, which is not acceptable to do every 10s. Until the kms locking is fixed, we hence can't drop the unknown state. > Reviewed-by: Alex Deucher Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: dan...@f

Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-05 Thread Daniel Vetter
s > at all. I like this approach more - the only other solution I see is to ask the currently active driver (i.e. radeon) at bootime for the right mode. Which sounds much more hellish and fragile ... -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe fro

Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-05 Thread Daniel Vetter
On Sun, Aug 05, 2012 at 10:18:38PM +0100, Matthew Garrett wrote: > On Sun, Aug 05, 2012 at 11:14:12PM +0200, Daniel Vetter wrote: > > > I like this approach more - the only other solution I see is to ask the > > currently active driver (i.e. radeon) at bootime for the right mode

Re: i915 regression on 3.6-rc1: lid blanks screen

2012-08-06 Thread Daniel Vetter
Capabilities: [a4] PCI Advanced Features >> > AFCap: TP+ FLR+ >> > AFCtrl: FLR- >> > AFStatus: TP- >> > Kernel driver in use: i915 >> > >> > Bisection led to this commit, and reverting indeed gets my screen back:

[PATCH 0/2] console_lock debug improvements

2012-08-21 Thread Daniel Vetter
[1]: https://lkml.org/lkml/2012/8/21/36 Daniel Vetter (2): console: use might_sleep in console_lock console: implement lockdep support for console_lock kernel/printk.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) -- 1.7.10.4 -- To unsubscribe from this list: sen

[PATCH 2/2] console: implement lockdep support for console_lock

2012-08-21 Thread Daniel Vetter
ueue)); *** DEADLOCK *** Cc: Dave Airlie Cc: Thomas Gleixner Signed-off-by: Daniel Vetter --- kernel/printk.c |9 + 1 file changed, 9 insertions(+) diff --git a/kernel/printk.c b/kernel/printk.c index ed9af6a..ab2ab24 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -87,6 +

[PATCH 1/2] console: use might_sleep in console_lock

2012-08-21 Thread Daniel Vetter
d I think the upside of catching more potential issues is worth the risk of getting a might_sleep backtrace that would have been save (and then dealing with that fallout). Cc: Dave Airlie Cc: Thomas Gleixner Signed-off-by: Daniel Vetter --- kernel/printk.c |3 ++- 1 file changed

Re: [RFC patch 4/4] Re: dma-buf-mgr: multiple dma-buf synchronization (v3)

2012-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2012 at 02:52:10PM +0200, Thomas Hellstrom wrote: > Hi, Maarten, > please see some comments inline. > > On 08/22/2012 01:50 PM, Maarten Lankhorst wrote: > >Hey Dan, > > > >Op 16-08-12 01:12, Daniel Vetter schreef: > >>Hi Maarten, >

Re: [ 04/16] drm/i915: correctly order the ring init sequence

2012-08-23 Thread Daniel Vetter
1db backported also need b7884eb45ec98c0d34c7f49005ae9d4b4b4e38f6 (to fix a regression introduce by the former). Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] i915: use alloc_ordered_workqueue() instead of explicit UNBOUND w/ max_active = 1

2012-08-23 Thread Daniel Vetter
hris Wilson Acked-by: Daniel Vetter for merging through any tree that pleases you (if it makes merging easier for WQ_NON_REENTRANT removal). Or should I just merge this through drm-intel-next? -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this li

Re: [PATCH] i915: use alloc_ordered_workqueue() instead of explicit UNBOUND w/ max_active = 1

2012-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2012 at 12:22:27PM -0700, Tejun Heo wrote: > Hello, > > On Thu, Aug 23, 2012 at 10:43:25AM +0200, Daniel Vetter wrote: > > On Thu, Aug 23, 2012 at 08:56:37AM +0100, Chris Wilson wrote: > > > On Wed, 22 Aug 2012 16:40:57 -0700, Tejun Heo wrote: >

Re: [PATCH] i915: Quirk no_lvds on Gigabyte GA-D525TUD ITX motherboard

2012-08-24 Thread Daniel Vetter
}, > }, > + { > + .callback = intel_no_lvds_dmi_callback, > + .ident = "Gigabyte GA-D525TUD", > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., > Ltd."), > + DM

Re: [PATCH drm-next 3/3] drm/i915/contexts: Fixup merge with commit b6c7488df68a

2012-08-26 Thread Daniel Vetter
ret = i915_switch_context(ring, NULL, DEFAULT_CONTEXT_ID); > if (ret) > return ret; > > -- > 1.7.9.5 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/m

Re: [PATCH drm-next 2/3] drm/i915: Remove reference to drm_display_info raw_edid field

2012-08-26 Thread Daniel Vetter
; - connector->display_info.raw_edid = NULL; > kfree(edid); > > return ret; > -- > 1.7.9.5 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/d

Re: [PATCH] drm/i915: Remove __GFP_NO_KSWAPD

2012-08-27 Thread Daniel Vetter
;mm: remove __GFP_NO_KSWAPD") > and commit b6beae2c2014 ("mm: remove __GFP_NO_KSWAPD fixes") in > linux-next (next-20120824). > > Fix this by removing __GFP_NO_KSWAPD from drm/i915 driver. > > Signed-off-by: Sedat Dilek Queued for -next, thanks for the patch. -Dani

[PATCH 1/2] [RESEND] console: use might_sleep in console_lock

2012-09-17 Thread Daniel Vetter
d I think the upside of catching more potential issues is worth the risk of getting a might_sleep backtrace that would have been save (and then dealing with that fallout). Cc: Dave Airlie Cc: Thomas Gleixner Cc: Alan Cox Cc: Peter Zijlstra Signed-off-by: Daniel Vetter --- kernel/printk.

[PATCH 2/2] [RESEND] console: implement lockdep support for console_lock

2012-09-17 Thread Daniel Vetter
queue)); *** DEADLOCK *** Cc: Dave Airlie Cc: Thomas Gleixner Cc: Alan Cox Cc: Peter Zijlstra Signed-off-by: Daniel Vetter --- kernel/printk.c |9 + 1 file changed, 9 insertions(+) diff --git a/kernel/printk.c b/kernel/printk.c index ed9af6a..ab2ab24 100644 --- a/kernel/printk

Re: [pull] drm-intel-next

2012-09-17 Thread Daniel Vetter
On Thu, Sep 13, 2012 at 04:18:41PM +0200, Daniel Vetter wrote: > Hi Dave, > > The big ticket item here is the new i915 modeset infrastructure. > Shockingly it didn't not blow up all over the place (i.e. I've managed to > fix the ugly issues before merging). 1-2 smalle

Re: [PATCH 2/2] [RESEND] console: implement lockdep support for console_lock

2012-09-19 Thread Daniel Vetter
On Tue, Sep 18, 2012 at 10:33:28AM +0300, Jani Nikula wrote: > On Tue, 18 Sep 2012, Daniel Vetter wrote: > > +#ifdef CONFIG_LOCKDEP > > +struct lockdep_map console_lock_dep_map = { > > + .name = "console_lock" > > +}; > > +#endif > > static?

Re: [PATCH] dma-buf: add reference counting for exporter module

2012-08-08 Thread Daniel Vetter
ank you for spotting this. > I didn'y know that try_get_module returned true is module was NULL. > > BTW. Is it worth to add ".owner = THIS_MODULE," to all dma_buf > exporters in this patch? Yeah, I think that makes sense. Otherwise it might get lost somewhere

[PATCH] drm/i915: ingore eDP bpc settings

2012-08-10 Thread Daniel Vetter
H Cc: sta...@vger.kernel.org Signed-off-by: Daniel Vetter -- Testing feedback highgly welcome, and thanks for Benoit for finding out that the bpc computations are busted. -Daniel --- drivers/gpu/drm/i915/intel_display.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gp

Re: null pointer dereference while loading i915

2012-08-10 Thread Daniel Vetter
e. gmbus should not be enable on 3.2 nor 3.0, since exactly this issue might happen. We've re-enabled gmbus again on 3.5 after having fixed this bug. Are you sure that this is plain 3.2 you're running? Yours, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog

Re: i915 regression on 3.6-rc1: lid blanks screen

2012-08-10 Thread Daniel Vetter
On Fri, Aug 10, 2012 at 1:59 PM, Takashi Iwai wrote: > At Mon, 6 Aug 2012 11:25:30 -0700 (PDT), > Hugh Dickins wrote: >> >> On Mon, 6 Aug 2012, Daniel Vetter wrote: >> > On Mon, Aug 6, 2012 at 6:21 AM, Hugh Dickins wrote: >> > > On Sun, 5 Aug 2012, Takashi

Re: null pointer dereference while loading i915

2012-08-10 Thread Daniel Vetter
On Fri, Aug 10, 2012 at 6:05 PM, Mihai Moldovan wrote: > * On 10.08.2012 12:10 PM, Daniel Vetter wrote: >> On Wed, Aug 8, 2012 at 6:50 AM, Mihai Moldovan wrote: >>> Hi Daniel, hi list >>> >>> ever since version 3.2.0 (maybe even earlier, but 3.0.2 is sti

Re: [Linaro-mm-sig] [PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER

2012-08-10 Thread Daniel Vetter
g at runtime. > > Signed-off-by: Maarten Lankhorst I've botched it more than once to update these when creating new dma-buf code. Hence Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line "unsubscri

Re: [Linaro-mm-sig] [PATCH 3/4] dma-seqno-fence: Hardware dma-buf implementation of fencing (v2)

2012-08-10 Thread Daniel Vetter
the software fallback. > > I extended the original patch by Rob Clark. > > v1: Original > v2: Renamed from bikeshed to seqno, moved into dma-fence.c since > not much was left of the file. Lots of documentation added. > > Signed-off-by: Maarten Lankhorst Patch look

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-10 Thread Daniel Vetter
re. > + */ > + I think we need to specify the calling contexts of these two. > +struct dma_fence_ops { > + int (*enable_signaling)(struct dma_fence *fence); I think we should mandate that enable_signalling can be called from atomic context, but not irq context (since I don't see a

Re: [PATCH v2] drm/i915: Fix blank panel at reopening lid

2012-08-11 Thread Daniel Vetter
d. > > This patch fixes the problem by moving the call of the function setting > BLC_PWM_CPU_CTL after enabling other two registers. > > Reported-and-tested-by: Hugh Dickins > Signed-off-by: Takashi Iwai > --- > v1->v2: add comments, fixed changelog Picked up for -fixes, t

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-11 Thread Daniel Vetter
On Sat, Aug 11, 2012 at 10:14:40AM -0500, Rob Clark wrote: > On Fri, Aug 10, 2012 at 3:29 PM, Daniel Vetter wrote: > > On Fri, Aug 10, 2012 at 04:57:52PM +0200, Maarten Lankhorst wrote: > >> + > >> + if (!ret) { > >> + cb->base.flag

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-11 Thread Daniel Vetter
On Sat, Aug 11, 2012 at 06:00:46PM +0200, Maarten Lankhorst wrote: > Op 11-08-12 17:14, Rob Clark schreef: > > On Fri, Aug 10, 2012 at 3:29 PM, Daniel Vetter wrote: > >>> +/** > >>> + * dma_fence_signal - signal completion of a fence > >>> + * @fence

Re: [Intel-gfx] [PATCH] drm/i915: ingore eDP bpc settings

2012-08-11 Thread Daniel Vetter
On Fri, Aug 10, 2012 at 12:24:29PM +0200, Benoit Gschwind wrote: > > Hello, > > I confirm this patch work apply to kernel 3.6-rc1 Ok, I've picked this up for -fixes, with the commit message a bit improved. Let's see whether this blows up anywhere. -Daniel -- Daniel Vetter

Re: [Linaro-mm-sig] [PATCH 2/4] dma-fence: dma-buf synchronization (v8 )

2012-08-12 Thread Daniel Vetter
t have the capability for hw->hw > + * signaling, they can implement this op to enable the necessary > + * irqs, or insert commands into cmdstream, etc. This is called > + * in the first wait() or add_callback() path to let the fence > + * implementation know that there is another driver wai

Re: 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Daniel Vetter
> Any thoughts? Any patch I can try out? http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-fixes&id=770c12312ad617172b1a65b911d3e6564fc5aca8 which is already merged to drm-intel-fixes. Thanks, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

Re: [Intel-gfx] 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 11:48:02AM -0700, Greg KH wrote: > On Sun, Aug 12, 2012 at 11:33:05AM -0700, Greg KH wrote: > > On Sun, Aug 12, 2012 at 08:25:31PM +0200, Daniel Vetter wrote: > > > On Sun, Aug 12, 2012 at 11:21:57AM -0700, Greg KH wrote: > > > > Hi Daniel

Re: v3.5 Oops in i2c_algo_bit.c:bit_xfer+0x23/0x870: i915 or i2c?

2012-08-13 Thread Daniel Vetter
precise vblank timestamp query. > [ 48.091182] vgaarb: device changed decodes: > PCI:0000:00:02.0,olddecodes=io+mem,decodes=io+mem:owns=io+mem > [ 48.511902] fbcon: inteldrmfb (fb0) is primary device > [ 48.852752] Console: switching to colour frame buffer device 240x67 >

Re: [PATCH 0/1] hopefully fix null pointer dereference on i915 load

2012-08-13 Thread Daniel Vetter
r patch? This seems to essentially undo commit 2ed06c93a1fce057808894d73167aae03c76deaf Author: Daniel Kurtz Date: Wed Mar 28 02:36:15 2012 +0800 drm/i915/intel_i2c: gmbus disabled and reserved ports are invalid Note that port numbers start at 1, whereas the array is 0-index based. So you pat

Re: [PATCH 1/1] drm/i915: ensure i2c adapter is all set before adding it

2012-08-13 Thread Daniel Vetter
> device detection GMBUS transfers timed out. Fix the issue by calling > i2c_add_adapter() only after intel_gpio_setup(). > > LKML-Reference: <5021f00b.7000...@ionic.de> > Signed-off-by: Jani Nikula Applied to -fixes with Mihai's tested-by added, thanks for the patch.

Re: [PATCH 1/7] drm/i915: Allow VGA on CRTC 2

2012-08-15 Thread Daniel Vetter
thers until it's a bit clearer what's going on/wrong. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [Linaro-mm-sig] [PATCH 4/4] dma-buf-mgr: multiple dma-buf synchronization (v3)

2012-08-15 Thread Daniel Vetter
if (unlikely(sequence - dmabuf->val_seq < (1 << 31))) > + return -EAGAIN; > + } > + > + if (no_wait) > + return -EBUSY; > + > + spin_unlock(&dma_buf_reserve_lock); >

Re: [PATCH 2/2] drm/i915: fall back to bit-banging if GMBUS fails in CRT EDID reads

2012-08-16 Thread Daniel Vetter
On Mon, Aug 13, 2012 at 01:22:35PM +0300, Jani Nikula wrote: > GMBUS was enabled over bit-banging as the default in commits: > > commit c3dfefa0a6d235bd465309e12f4c56ea16e7 > Author: Daniel Vetter > Date: Tue Feb 14 22:37:25 2012 +0100 > > drm/i915: reenable

[PULL] drm-intel-fixes for 3.6

2012-07-25 Thread Daniel Vetter
(1): drm/i915: dereferencing an error pointer Daniel Vetter (6): drm/i915: fix up PCH backlight #define mixup drm/i915: check whether we actually received an edid in detect_ddc drm/i915: kill intel_ddc_probe drm/i915/lvds: ditch ->prepare special case d

Re: [REGRESSION] [KMS] [INTEL] Wrong resolution in console and XWindow

2012-07-25 Thread Daniel Vetter
; ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line "u

Re: [PULL] drm-intel-fixes for 3.6

2012-07-25 Thread Daniel Vetter
On Wed, Jul 25, 2012 at 10:17:33AM +0200, Daniel Vetter wrote: > Hi Dave, > > First pile of fixes for 3.6 already, and I'm afraid it's a bit larger than > what I'd wish for. But I've moved all the feature-y stuff to -next, so > this really is all -fixes. Most of

Re: [REGRESSION] [KMS] [INTEL] Wrong resolution in console and XWindow

2012-07-25 Thread Daniel Vetter
On Wed, Jul 25, 2012 at 10:54:25AM +0200, Maciej Rutecki wrote: > On środa, 25 lipca 2012 o 10:29:26 Daniel Vetter wrote: > > On Wed, Jul 25, 2012 at 10:20:47AM +0200, Maciej Rutecki wrote: > > > Last known good: 3.4.4 > > > First bad: 3.5.0 > > > > > &

Re: [REGRESSION] [KMS] [INTEL] Wrong resolution in console and XWindow

2012-07-25 Thread Daniel Vetter
On Wed, Jul 25, 2012 at 12:57 PM, Maciej Rutecki wrote: > On środa, 25 lipca 2012 o 11:29:28 Daniel Vetter wrote: >> On Wed, Jul 25, 2012 at 10:54:25AM +0200, Maciej Rutecki wrote: >> > On środa, 25 lipca 2012 o 10:29:26 Daniel Vetter wrote: >> > > On Wed, Jul 25, 20

[PULL] first drm-intel-next for 3.7

2012-08-17 Thread Daniel Vetter
ply the SNB pipe control w/a to gen6 drm/i915: Add I915_GEM_PARAM_HAS_SEMAPHORES drm/i915: Lazily apply the SNB+ seqno w/a Daniel Vetter (21): drm/i915: group ADPA #defines together drm/i915: simplify possible_clones computation drm/i915: add port parameter to intel

Re: [ 32/37] drm/i915: correctly order the ring init sequence

2012-08-18 Thread Daniel Vetter
On Sat, Aug 18, 2012 at 1:29 AM, Herton Ronaldo Krzesinski wrote: > On Fri, Aug 17, 2012 at 04:03:15AM +0100, Ben Hutchings wrote: >> 3.2-stable review patch. If anyone has any objections, please let me know. >> >> ------ >> >>

Re: [ 04/16] drm/i915: correctly order the ring init sequence

2012-08-20 Thread Daniel Vetter
On Tue, Aug 21, 2012 at 7:13 AM, Herton Ronaldo Krzesinski wrote: > On Sun, Aug 19, 2012 at 08:56:03PM -0700, Greg Kroah-Hartman wrote: >> From: Greg KH >> >> 3.0-stable review patch. If anyone has any objections, please let me know. >> >> ---

Re: inux-next: Tree for Aug 21 (call-trace when suspending: PM?)

2012-08-21 Thread Daniel Vetter
>> - Sedat - >> >> Forgot attachment! >> If you don't succeed - try try try... >> >> - Sedat - > > [ CC danvet ] > > I have pulled in drm-intel-fixes into my local GIT tree and rebuilt > i915 - this seems to fix the problem. > Daniel any suggestion whic

Re: inux-next: Tree for Aug 21 (call-trace when suspending: PM?)

2012-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2012 at 3:24 PM, Sedat Dilek wrote: > On Tue, Aug 21, 2012 at 1:53 PM, Daniel Vetter wrote: >> On Tue, Aug 21, 2012 at 1:14 PM, Sedat Dilek wrote: >>> On Tue, Aug 21, 2012 at 1:03 PM, Sedat Dilek wrote: >>>> On Tue, Aug 21, 2012 at 1:02 PM, Sedat D

Re: [ 04/16] drm/i915: correctly order the ring init sequence

2012-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2012 at 3:11 PM, Herton Ronaldo Krzesinski wrote: > On Tue, Aug 21, 2012 at 08:42:35AM +0200, Daniel Vetter wrote: >> On Tue, Aug 21, 2012 at 7:13 AM, Herton Ronaldo Krzesinski >> wrote: >> > I had the same problem as on 3.2 with this change, i915 stoppe

Re: inux-next: Tree for Aug 21 (call-trace when suspending: PM?)

2012-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2012 at 08:20:35PM +0200, Sedat Dilek wrote: > On Tue, Aug 21, 2012 at 6:39 PM, Daniel Vetter wrote: > > On Tue, Aug 21, 2012 at 3:24 PM, Sedat Dilek wrote: > >> On Tue, Aug 21, 2012 at 1:53 PM, Daniel Vetter wrote: > >>> On Tue, Aug 21

Re: i915-related and general system freezes with specific kernel config // IOMMU

2013-01-19 Thread Daniel Vetter
D_INTEL, 0x2a40, quirk_iommu_rwbf); +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x2e10, quirk_iommu_rwbf); #define GGC 0x52 #define GGC_MEMORY_SIZE_MASK (0xf << 8) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubs

Re: i915-related and general system freezes with specific kernel config // IOMMU

2013-01-19 Thread Daniel Vetter
On Sat, Jan 19, 2013 at 5:26 PM, Mihai Moldovan wrote: > The current patch errors out on my while compiling as quirk_iommu_rwbf is not > yet defined at that place. Oops, attached an old patch, updated one should work better. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation

[PULL] kms locking rework

2013-01-20 Thread Daniel Vetter
people.freedesktop.org/~danvet/drm-intel drm-kms-locking for you to fetch changes up to 57c45428f2b005e95bbc6706cd61574183ed8522: drm/fb_helper: check whether fbcon is bound (2013-01-20 15:59:55 +0100) -------- Daniel Vetter (36):

Re: thoughts on requiring multi-arch support for arm drm drivers?

2013-01-20 Thread Daniel Vetter
On Sun, Jan 20, 2013 at 4:08 PM, Rob Clark wrote: > One thing I've run into in the past when trying to make changes in drm > core, and Daniel Vetter has mentioned the same, is that it is a bit of > a pain to compile test things for the arm drivers that do not support > CONFIG_A

Re: [PULL] kms locking rework

2013-01-20 Thread Daniel Vetter
On Sun, Jan 20, 2013 at 4:32 PM, Daniel Vetter wrote: > Changes since the patchbomb on dri-devel: > - Added a patch to adjust the new omapdrm code in 3.8-rc4, reviewed by Rob > Clark on irc (hence also why the baseline of this pull is 3.8-rc4). > - Slightly fixed/clarified some com

Re: [PULL] kms locking rework

2013-01-20 Thread Daniel Vetter
t cause havoc. That needs something which pageflips, ofc. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

[PATCH] iommu/intel: disable DMAR for g4x integrated gfx

2013-01-20 Thread Daniel Vetter
g.cgi?id=51921 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=538163 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=538163 Cc: Adam Jackson Cc: David Woodhouse Cc: sta...@vger.kernel.org Tested-by: stathis Tested-by: Mihai Moldovan Signed-off-by: Daniel Vetter --- drivers/iommu/

Re: i915-related and general system freezes with specific kernel config // IOMMU

2013-01-20 Thread Daniel Vetter
> specifically. > Will probably do this tomorrow. Please let me know when this works solidly for you, so that I can put it into a real patch and also submit it for inclusion. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -

Re: linux-next: manual merge of the akpm tree with the drm tree

2013-01-21 Thread Daniel Vetter
blank_screen() if > oops in progress" from the akpm tree. > > I can't see an easy way to resolve these, so I just dropped the akpm tree > patch. > > -- > Cheers, > Stephen Rothwells...@canb.auug.org.au -- Daniel Vetter Software Engineer, Inte

Re: [PATCH] drm/fb: avoid sleeping in unblank_screen() if oops in progress

2013-01-21 Thread Daniel Vetter
return drm_fb_helper_dpms(info, DRM_MODE_DPMS_SUSPEND); > /* Display: Off; HSync: Off, VSync: Off */ > case FB_BLANK_POWERDOWN: > - drm_fb_helper_dpms(info, DRM_MODE_DPMS_OFF); > - break; > + return drm_fb_helper_dpms(info, DRM_MODE_DPMS_OFF); > } >

[PATCH] intel/iommu: force writebuffer-flush quirk on Gen 4 Chipsets

2013-01-21 Thread Daniel Vetter
: Mihai Moldovan Signed-off-by: Daniel Vetter --- drivers/iommu/intel-iommu.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 9743769..19854bf 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu

Re: [REGRESSION FIXED] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2013-01-22 Thread Daniel Vetter
of your issue here, this shouldn't happen. Please yell at us louder next time around. > I have tried 3.7, I don't have the issue any more (tested for a month > now). Perhaps it was already fixed in 3.6, but not much before. 3.7 seems likely, since we've fixed quite a few long-stan

Re: i915-related and general system freezes with specific kernel config // IOMMU

2013-01-22 Thread Daniel Vetter
g.bz2 disables IOMMU and Intel IOMMU via boot > parameter > [*] kern-iommu_static_off.log.bz2 has CONFIG_IOMMU_SUPPORT=n set and any > IOMMU > support statically disabled (also consequently DMAR) In any case I'll ping David about my 2nd quirk patch and whether that's

Re: [PATCH] iommu/intel: disable DMAR for g4x integrated gfx

2013-01-22 Thread Daniel Vetter
On Mon, Jan 21, 2013 at 01:03:48PM -0600, David Woodhouse wrote: > On Sun, 2013-01-20 at 23:50 +0100, Daniel Vetter wrote: > > DMAR support on g4x/gm45 integrated gpus seems to be totally busted. > > So don't bother, but instead disable it by default to allow distros to > &

Re: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

2013-01-23 Thread Daniel Vetter
Signed-off-by: xueminsu Imo just BUG_ON(!fb); and call it a day. Makes it pretty clear what's expected of the drivers. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscr

[PATCH 0/2] fbcon+i915 locking fixes

2013-01-23 Thread Daniel Vetter
this through your drm tree. I've looked through the patch and the new locking seems to be sane so feel free to smash a Reviewed-by: Daniel Vetter onto it. 2nd patch is a locking bug in the i915 driver with the new kms locking. Since the bug only happens in your drm-next tree, please apply

[PATCH 2/2] drm/i915: fixup per-crtc locking in intel_release_load_detect_pipe

2013-01-23 Thread Daniel Vetter
One of the early return cases missed the mutex unlocking. Hilarity ensued. This regression has been introduced in commit 7b24056be6db7ce907baffdd4cf142ab774ea60c Author: Daniel Vetter Date: Wed Dec 12 00:35:33 2012 +0100 drm: don't hold crtc mutexes for connector ->detect c

[PATCH 1/2] fb: Rework locking to fix lock ordering on takeover

2013-01-23 Thread Daniel Vetter
[danvet: Tiny whitespace cleanup.] Reported-and-tested-by: Hugh Dickins Reported-and-tested-by: Sasha Levin References: https://lkml.org/lkml/2012/10/25/516 Signed-off-by: Daniel Vetter --- drivers/tty/vt/vt.c | 81 +++-- drivers/video/console/fbcon.c

Re: [PATCH 1/2] fb: Rework locking to fix lock ordering on takeover

2013-01-23 Thread Daniel Vetter
On Wed, Jan 23, 2013 at 5:38 PM, Takashi Iwai wrote: > At Wed, 23 Jan 2013 17:25:08 +0100, > Daniel Vetter wrote: >> >> From: Alan Cox >> >> Adjust the console layer to allow a take over call where the caller already >> holds the locks. Make the fb layer lock

Re: [PATCH] intel/iommu: force writebuffer-flush quirk on Gen 4 Chipsets

2013-02-13 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 7:55 PM, David Woodhouse wrote: > On Mon, 2013-01-21 at 19:48 +0100, Daniel Vetter wrote: >> We already have the quirk entry for the mobile platform, but also >> reports on some desktop versions. So be paranoid and set it >> everywhere. >&

[pull] fb helper cleanups

2013-02-14 Thread Daniel Vetter
x into drm-next (2013-02-08 14:02:32 +1000) are available in the git repository at: git://people.freedesktop.org/~danvet/drm drm-fb-helper for you to fetch changes up to a065b46a01b25d7d364e01e75f7ec2bd9ed5d9cb: drm/fb-helper: remove unused members of struct drm_fb_helper (2013-02-14 00:08:

Re: [Linaro-mm-sig] [PATCH 2/3] mutex: add support for reservation style locks

2013-02-14 Thread Daniel Vetter
If you detect an inversion in a multi-buffer reservation you have to drop all locks and call these functions on the buffer which failed (that's the contention point, hence it's the right lock to sleep on). So every place using ticket locks will also call the above slowpath functi

Including drm-intel tree to linux-next

2013-02-14 Thread Daniel Vetter
#x27;m supposed to follow? And if possible please cc intel-...@lists.freedesktop.org besides dri-devel/lkml when conflicts with that tree pop up (you won't get moderation spam any more, we've fixed that up). Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 7

<    1   2   3   4   5   6   7   8   9   10   >