Re: [PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-03 Thread Adam Borowski
On Tue, Oct 03, 2017 at 12:40:12PM -0400, Theodore Ts'o wrote: > On Tue, Oct 03, 2017 at 03:07:24AM +0100, Al Viro wrote: > > That essay is full of shit, and you've even mentioned parts of that just > > above... > > NAK; you'd _still_ need proper quoting (or a shell with something > > resembling

Re: Linux 4.14: Reported regressions as of Sunday, 2017-10-08

2017-10-08 Thread Adam Borowski
On Sun, Oct 08, 2017 at 02:37:41PM +0200, Thorsten Leemhuis wrote: > Hi! Find below my second regression report for Linux 4.14. It lists 8 > regressions I'm currently aware of. One regression was fixed since last > weeks report. One was in there that shouldn't have been there. > > == Current regre

[PATCH] vt: fix \e[2m using the wrong placeholder color on graphical consoles

2017-06-03 Thread Adam Borowski
Only vgacon and sisusbcon did it right, the rest (via generic code) tried underline (usually cyan). Signed-off-by: Adam Borowski --- Compare this if clause with the two above it. Nice copypaste. :) drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 0/5] vt: get rid of worst cases of __put_user/__get_user

2017-06-03 Thread Adam Borowski
;m=149465866929092&w=2 Here's a few patches applying the lessons from that discussion to vt. None of the uses is performance-critical, but at least we get a nice bit of code simplification. And, it's a start of manual review + conversion that Al Viro wants. Adam Borowski (5):

[PATCH 5/5] vt: drop access_ok() calls in unimap ioctls

2017-06-03 Thread Adam Borowski
Done by copy_{from,to}_user(). Signed-off-by: Adam Borowski --- drivers/tty/vt/vt_ioctl.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c index 0cbfe1ff6f6c..96d389cb506c 100644 --- a/drivers/tty/vt/vt_ioctl.c +++ b/drivers/tty/vt

[PATCH 2/5] vt: fix unchecked __put_user() in tioclinux ioctls

2017-06-03 Thread Adam Borowski
n the future. If anyone cares about 3.7 and earlier, this is a security hole (untested) on real 80386 CPUs. Signed-off-by: Adam Borowski CC: sta...@vger.kernel.org # v3.7- --- drivers/tty/vt/vt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/vt/vt.c b/driver

[PATCH 4/5] vt: use memdup_user in PIO_UNIMAP ioctl

2017-06-03 Thread Adam Borowski
Again, a nice linear transfer that simplifies the code. Signed-off-by: Adam Borowski --- drivers/tty/vt/consolemap.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c index c6a692f63a9b..a5f88cf0f61d 100644

[PATCH 3/5] vt: use copy_to_user instead of __put_user in GIO_UNIMAP ioctl

2017-06-03 Thread Adam Borowski
A nice big linear transfer, no need to flip stac/PAN/etc every half-entry. Also, yay __put_user() after checking only read. Signed-off-by: Adam Borowski --- drivers/tty/vt/consolemap.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/tty/vt/consolemap.c

[PATCH 1/5] vt: use copy_from/to_user instead of __get/put_user for scrnmap ioctls

2017-06-03 Thread Adam Borowski
Linus wants to get rid of these functions, and these uses are especially egregious: they copy a big linear array element by element. Signed-off-by: Adam Borowski --- drivers/tty/vt/consolemap.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git a

Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards

2017-07-24 Thread Adam Borowski
On Tue, Jul 25, 2017 at 11:04:24AM +0800, icen...@aosc.io wrote: > 在 2017-07-24 15:58,Maxime Ripard 写道: > > On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote: > > > Allwinner A64 SoC has an EMAC which is used to provide Ethernet > > > function on several boards. > > > > > > The EMAC it

MikeeUSA warning (Re: Yes you have standing to sue GRSecurity.)

2017-07-29 Thread Adam Borowski
Note that this is quite clearly yet another of MikeeUSA's sockpuppets. And you guys really don't want to be caught in another of his troll threads. Yeah, GRsecurity is a problem, but don't let our dear Mikee milk it. -- ⢀⣴⠾⠻⢶⣦⠀ What Would Jesus Do, MUD/MMORPG edition: ⣾⠁⢰⠒⠀⣿⡁ • multiplay with

Re: Problematic culture around Signed-off-by

2017-07-31 Thread Adam Borowski
On Sun, Jul 30, 2017 at 08:52:36PM +0200, Pavel Machek wrote: > > I've been away from kernel development for a bit, but I've returned and > > I'm troubled by what seems to be an entrenched and widespread (IMO) > > misuse of the "Signed-off-by:" in commits. > > > > I've now either been asked to sig

Re: [PATCH] fbcon: Use background color for margins

2017-07-31 Thread Adam Borowski
On Mon, Jul 31, 2017 at 12:25:28PM -0500, David Lechner wrote: > On 07/30/2017 04:51 PM, Pavel Machek wrote: > > > > > Screens that don't have a black border around the active area will > > > > > have > > > > > ugly black bars for the margin when the text background color is not > > > > > black.

Re: [PATCH] drm/nouveau/imem/nv50: fix incorrect use of refcount API

2017-12-08 Thread Adam Borowski
On Fri, Dec 08, 2017 at 06:30:34PM +, Ard Biesheuvel wrote: > Commit be55287aa5b ("drm/nouveau/imem/nv50: embed nvkm_instobj directly > into nv04_instobj") introduced some new calls to the refcount api to > the nv50 mapping code. In one particular instance, it does the > following: > > if

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-10-17 Thread Adam Borowski
On Mon, Oct 17, 2016 at 02:57:09PM +1100, Nicholas Piggin wrote: > On Sat, 15 Oct 2016 17:22:05 -0700 Omar Sandoval wrote: > > On Fri, Oct 14, 2016 at 10:12:46PM +0200, Michal Marek wrote: > > > please pull these kbuild changes for v4.9-rc1: > > > > > > - EXPORT_SYMBOL for asm source by Al Viro.

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-10-17 Thread Adam Borowski
On Mon, Oct 17, 2016 at 05:59:51PM +1100, Nicholas Piggin wrote: > On Mon, 17 Oct 2016 08:51:31 +0200 > Adam Borowski wrote: > > On Mon, Oct 17, 2016 at 02:57:09PM +1100, Nicholas Piggin wrote: > > > On Sat, 15 Oct 2016 17:22:05 -0700 Omar Sandoval > > > wrote:

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-10-17 Thread Adam Borowski
On Mon, Oct 17, 2016 at 02:22:34PM +0200, Mathieu OTHACEHE wrote: > > +#include > > +#include > > Included twice. D'oh! > > +#include > > +#include > > +#include > > + > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > No for __sw_hweight32 and __sw_hweig

Re: 784d5699eddc ("x86: move exports to actual definitions")

2016-10-18 Thread Adam Borowski
On Tue, Oct 18, 2016 at 10:29:15PM +0200, Markus Trippelsdorf wrote: > On 2016.10.18 at 22:23 +0200, Borislav Petkov wrote: > > I see the gazillion warnings below when building -rc1 here. > > > > When I revert > > > > 784d5699eddc ("x86: move exports to actual definitions") > > > > the warnings

Re: x32 is broken in 4.9-rc1 due to "x86/signal: Add SA_{X32,IA32}_ABI sa_flags"

2016-10-19 Thread Adam Borowski
; > - > if (in_ia32_syscall()) > act->sa.sa_flags |= SA_IA32_ABI; > if (in_x32_syscall()) > -- > 2.10.0 Works for me. Tested on general operation, a few by-hand checks and several random package builds. It'd be nice to check glibc's testsui

[PATCH resend] vfs: allow FILE_EXTENT_SAME (dedupe_file_range) on a file opened ro

2016-10-05 Thread Adam Borowski
lowed for root/cap. Tested on btrfs and not-yet-merged xfs, as only them implement this ioctl. Signed-off-by: Adam Borowski Reviewed-by: Mark Fasheh --- fs/read_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index 66215a7..8ea5297 1

[tip:x86/build] x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y

2018-10-09 Thread tip-bot for Adam Borowski
Commit-ID: 72a9c673636b779e370983fea08e40f97039b981 Gitweb: https://git.kernel.org/tip/72a9c673636b779e370983fea08e40f97039b981 Author: Adam Borowski AuthorDate: Tue, 9 Oct 2018 08:28:03 +0200 Committer: Ingo Molnar CommitDate: Wed, 10 Oct 2018 08:29:51 +0200 x86/defconfig: Enable

[tip:perf/urgent] perf/x86/amd: Set the size of event map array to PERF_COUNT_HW_MAX

2016-04-28 Thread tip-bot for Adam Borowski
Commit-ID: 0a25556f84d5f79e68e9502bb1f32a43377ab2bf Gitweb: http://git.kernel.org/tip/0a25556f84d5f79e68e9502bb1f32a43377ab2bf Author: Adam Borowski AuthorDate: Wed, 27 Apr 2016 11:35:31 +0200 Committer: Ingo Molnar CommitDate: Thu, 28 Apr 2016 10:20:25 +0200 perf/x86/amd: Set the

<    1   2   3