Re: [PATCH] virtio-net: disable delayed refill when pausing rx

2025-04-10 Thread Bui Quang Minh
On 4/9/25 13:44, Bui Quang Minh wrote: On 4/8/25 14:34, Jason Wang wrote: On Mon, Apr 7, 2025 at 10:27 AM Bui Quang Minh wrote: On 4/7/25 08:03, Xuan Zhuo wrote: On Fri,  4 Apr 2025 16:39:03 +0700, Bui Quang Minh wrote: When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_di

RE: [PATCH 1/7] irqbypass: Drop pointless and misleading THIS_MODULE get/put

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > Drop irqbypass.ko's superfluous and misleading get/put calls on > THIS_MODULE. A module taking a reference to itself is useless; no amount > of checks will prevent doom and destruction if the caller hasn't already > guarante

Re: [linus:master] [fs/dax] bde708f1a6: WARNING:at_mm/truncate.c:#truncate_folio_batch_exceptionals

2025-04-10 Thread Christoph Hellwig
On Thu, Apr 10, 2025 at 05:01:26PM +1000, Alistair Popple wrote: > However I note that this is ext2. Commit 0e2f80afcfa6 doesn't actually update > ext2 so the warning will persist. The fix should basically be the same as for > ext4: Are there any actual users of fsdax for ext2, and can't these use

RE: [PATCH 2/7] irqbypass: Drop superfluous might_sleep() annotations

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > Drop superfluous might_sleep() annotations from irqbypass, mutex_lock() > provides all of the necessary tracking. > > Signed-off-by: Sean Christopherson Reviewed-by: Kevin Tian

[PATCH] virtio-net: hold netdev_lock when pausing rx

2025-04-10 Thread Bui Quang Minh
When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_disable() on the receive queue's napi. In delayed refill_work, it also calls napi_disable() on the receive queue's napi. When napi_disable() is called on an already disabled napi, it will sleep in napi_disable_locked while still

RE: [PATCH 3/7] irqbypass: Take ownership of producer/consumer token tracking

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > @@ -505,15 +505,12 @@ static int vfio_msi_set_vector_signal(struct > vfio_pci_core_device *vdev, > if (ret) > goto out_put_eventfd_ctx; > > - ctx->producer.token = trigger; > ctx->producer.irq =

RE: [PATCH 5/7] irqbypass: Use paired consumer/producer to disconnect during unregister

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > @@ -173,8 +157,6 @@ > EXPORT_SYMBOL_GPL(irq_bypass_unregister_producer); > * @consumer: pointer to consumer structure > * @eventfd: pointer to the eventfd context associated with the consumer > * > - * Add the provided I

RE: [PATCH 4/7] irqbypass: Explicitly track producer and consumer bindings

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > Explicitly track IRQ bypass producer:consumer bindings. This will allow > making removal an O(1) operation; searching through the list to find > information that is trivially tracked (and useful for debug) is wasteful. > >

RE: [PATCH 6/7] irqbypass: Use guard(mutex) in lieu of manual lock+unlock

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > Use guard(mutex) to clean up irqbypass's error handling. > > Signed-off-by: Sean Christopherson Reviewed-by: Kevin Tian

[PATCH] firmware: cs_dsp: test_bin_error: Fix uninitialized data used as fw version

2025-04-10 Thread Richard Fitzgerald
Call cs_dsp_mock_xm_header_get_fw_version() to get the firmware version from the dummy XM header data in cs_dsp_bin_err_test_common_init(). Make the same change to cs_dsp_bin_test_common_init() and remove the cs_dsp_mock_xm_header_get_fw_version_from_regmap() function. The code in cs_dsp_test_bin

[PATCH v5 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-04-10 Thread David Heidelberg via B4 Relay
With the growing popularity of running upstream Linux on mobile devices, we're beginning to run into more and more edgecases. The OnePlus 6 is a fairly well supported 2018 era smartphone, selling over a million units in it's first 22 days. With this level of popularity, it's almost inevitable that

[PATCH v5 6/7] Input: synaptics-rmi4 - read product ID on aftermarket touch ICs

2025-04-10 Thread David Heidelberg via B4 Relay
From: Kaustabh Chakraborty Some replacement displays include third-party touch ICs which do not report the product ID correctly unless we read directly from the product ID register. Add a check and a fallback read to handle this. Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly

[PATCH v5 5/7] Input: synaptics-rmi4 - don't do unaligned reads in IRQ context

2025-04-10 Thread David Heidelberg via B4 Relay
From: Kaustabh Chakraborty Some replacement displays include third-party touch ICs which incur a significant penalty (1-2 seconds) when doing certain unaligned reads. This is enough to break functionality when it happens in the hot path, so adjust the interrupt handler to not read from an unalign

[PATCH v5 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b

2025-04-10 Thread David Heidelberg via B4 Relay
From: David Heidelberg Mostly irrelevant for authentic Synaptics touchscreens, but very important for applying workarounds to cheap TS knockoffs. These knockoffs work well with the downstream driver, and since the user has no way to distinguish them, later in this patch set, we introduce workaro

[PATCH v3] DAX: warn when kmem regions are truncated for memory block alignment.

2025-04-10 Thread Gregory Price
Device capacity intended for use as system ram should be aligned to the architecture-defined memory block size or that capacity will be silently truncated and capacity stranded. As hotplug dax memory becomes more prevelant, the memory block size alignment becomes more important for platform and de

Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload

2025-04-10 Thread Antonio Quartulli
On 10/04/2025 16:03, Sabrina Dubroca wrote: [...] For the series: Reviewed-by: Sabrina Dubroca Thanks again for your patience, Antonio. Thank you (!) Sabrina for all the effort you've put during this long journey. You've been of incredible help to the ovpn prototype and to me. "And we're j

Re: [PATCH v2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
On 4/10/2025 9:54 AM, Joel Fernandes wrote: > Currently, the ->gpwrap is not tested (at all per my testing) due to the > requirement of a large delta between a CPU's rdp->gp_seq and its node's > rnp->gpseq. > > This results in no testing of ->gpwrap being set. This patch by default > adds 5 min

Re: [PATCH RFC v7 5/8] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes

2025-04-10 Thread Christoph Hellwig
On Thu, Apr 10, 2025 at 06:53:15AM -0700, Ackerley Tng wrote: > > So why do other alloc_anon_inode callers not need > > security_inode_init_security_anon? > > Thanks for this tip! > > When I did this refactoring, I was just refactoring > anon_inode_create_getfile(), to set up the guest_memfd inod

[PATCH v3 2/2] rcutorture: Fix issue with re-using old images on ARM64

2025-04-10 Thread Joel Fernandes
On ARM64, when running with --configs '36*SRCU-P', I noticed that only 1 instance instead of 36 for starting. Fix it by checking for Image files, instead of bzImage which ARM does not seem to have. With this I see all 36 instances running at the same time in the batch. Signed-off-by: Joel Fernan

Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for SOFT RESERVES

2025-04-10 Thread Bowman, Terry
On 4/4/2025 8:25 AM, Andy Shevchenko wrote: > On Fri, Apr 04, 2025 at 02:16:39PM +0100, Jonathan Cameron wrote: >> On Thu, 3 Apr 2025 13:33:12 -0500 Terry Bowman wrote: > >>> Add a release_Sam_region_adjustable() interface to allow for >> >> Who is Sam? (typo) > > Somebody's uncle? > > ... >

Re: [PATCH v2 01/32] selftests: harness: Add harness selftest

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: Add a selftest for the harness itself so any changes can be validated. kselftest harness? Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/kselftest/.gitignore | 1 +

Re: [PATCH v2 00/32] kselftest harness and nolibc compatibility

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small, and compiled with just a kernel crosscompiler, without userspace support. Currently nolibc is only usable with kselftest.h, not the more convenient to use kselftest_harness.h This serie

Re: [PATCH 3/7] irqbypass: Take ownership of producer/consumer token tracking

2025-04-10 Thread Sean Christopherson
On Thu, Apr 10, 2025, Kevin Tian wrote: > > From: Sean Christopherson > > +int irq_bypass_register_consumer(struct irq_bypass_consumer *consumer, > > +struct eventfd_ctx *eventfd) > > { > > struct irq_bypass_consumer *tmp; > > struct irq_bypass_producer *produc

Re: [PATCH v3 2/4] cxl: Update Soft Reserved resources upon region creation

2025-04-10 Thread Bowman, Terry
On 4/4/2025 8:32 AM, Jonathan Cameron wrote: > On Thu, 3 Apr 2025 13:33:13 -0500 > Terry Bowman wrote: > >> From: Nathan Fontenot >> >> Update handling of SOFT RESERVE iomem resources that intersect with >> CXL region resources to remove intersections from the SOFT RESERVE >> resources. The curr

Re: rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Hello, Paul, On Thu, 10 Apr 2025 13:35:35 GMT, "Paul E. McKenney" wrote: [...] > > > > kernel/rcu/rcu.h| 4 +++ > > > > kernel/rcu/rcutorture.c | 64 > > > > kernel/rcu/tree.c | 34 -- > > > > kernel/rcu/tree.h | 1

Re: [PATCH v3 0/2] arm64: livepatch: Enable livepatch without sframe

2025-04-10 Thread Petr Mladek
On Thu 2025-03-20 10:15:57, Song Liu wrote: > There are recent efforts to enable livepatch for arm64, with sframe [1] or > without sframe [2]. This set tries to enable livepatch without sframe. Some > of the code, however, are from [1]. > > Although the sframe implementation is more promising in l

Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: For tests without fixtures the variant argument is unused. This is intentional, prevent to compiler from complaining. Include the warning in the change log for reference. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/kselftest_harness

[PATCH v5 4/7] Input: synaptics-rmi4 - f55: handle zero electrode count

2025-04-10 Thread David Heidelberg via B4 Relay
From: Kaustabh Chakraborty Some third party ICs claim to support f55 but report an electrode count of 0. Catch this and bail out early so that we don't confuse the i2c bus with 0 sized reads. Signed-off-by: Kaustabh Chakraborty [simplify code, adjust wording] Signed-off-by: Caleb Connolly Sign

[PATCH v5 7/7] Input: synaptics-rmi4 - support fallback values for PDT descriptor bytes

2025-04-10 Thread David Heidelberg via B4 Relay
From: Kaustabh Chakraborty Some replacement displays include third-party touch ICs which do not expose the function number and the interrupt status in its PDT entries. OnePlus 6 (original touch IC) rmi4_i2c 12-0020: read 6 bytes at 0x00e3: 0 (2b 22 0d 06 01 01) OnePlus 6 (aftermarket touch IC

Re: [PATCH v2 02/32] selftests: harness: Use C89 comment style

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: All comments in this file use C89 comment style. Except for this one. Change it to get one step closer to C89 compatibility. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/kselftest_harness.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH v5 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries

2025-04-10 Thread David Heidelberg via B4 Relay
From: Caleb Connolly Some third party rmi4-compatible ICs don't expose their PDT entries very well. Add a few checks to skip duplicate entries as well as entries for unsupported functions. This is required to support some phones with third party displays. Validated on a stock OnePlus 6T (origin

Re: [PATCH] arm64: dts: qcom: msm8953: Add uart_5

2025-04-10 Thread Konrad Dybcio
On 4/6/25 3:52 PM, Luca Weiss wrote: > From: Felix Kaechele > > Add the node and pinctrl for uart_5 found on the MSM8953 SoC. > > Signed-off-by: Felix Kaechele > [luca: Prepare patch for upstream submission] > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/msm8953.dtsi | 32 ++

[PATCH v17 09/15] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment

2025-04-10 Thread Frank Li
Introduce the helper function pci_epf_align_inbound_addr() to adjust addresses according to PCI BAR alignment requirements, converting addresses into base and offset values. Signed-off-by: Frank Li --- Change from v15 to v16 - none Change from v14 to v15 - change out address type to dma_addr_t t

Re: rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Hello, Paul, On Thu, 10 Apr 2025 13:35:35 GMT, "Paul E. McKenney" wrote: [...] > > > > kernel/rcu/rcu.h| 4 +++ > > > > kernel/rcu/rcutorture.c | 64 > > > > kernel/rcu/tree.c | 34 -- > > > > kernel/rcu/tree.h | 1

Re: [PATCH RFC v7 5/8] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes

2025-04-10 Thread Ackerley Tng
Christoph Hellwig writes: > On Tue, Apr 08, 2025 at 11:23:59AM +, Shivank Garg wrote: >> From: Ackerley Tng >> >> Using guest mem inodes allows us to store metadata for the backing >> memory on the inode. Metadata will be added in a later patch to support >> HugeTLB pages. >> >> Metadata a

[PATCH v2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Currently, the ->gpwrap is not tested (at all per my testing) due to the requirement of a large delta between a CPU's rdp->gp_seq and its node's rnp->gpseq. This results in no testing of ->gpwrap being set. This patch by default adds 5 minutes of testing with ->gpwrap forced by lowering the delta

[PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Currently, the ->gpwrap is not tested (at all per my testing) due to the requirement of a large delta between a CPU's rdp->gp_seq and its node's rnp->gpseq. This results in no testing of ->gpwrap being set. This patch by default adds 5 minutes of testing with ->gpwrap forced by lowering the delta

Re: [PATCH RFC v7 7/8] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-04-10 Thread Ackerley Tng
Shivank Garg writes: > Previously, guest-memfd allocations followed local NUMA node id in absence > of process mempolicy, resulting in arbitrary memory allocation. > Moreover, mbind() couldn't be used since memory wasn't mapped to userspace > in the VMM. > > Enable NUMA policy support by implemen

[PATCH v5 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs

2025-04-10 Thread David Heidelberg via B4 Relay
From: Kaustabh Chakraborty Some replacement displays include third-party touch ICs which are devoid of register descriptors. Create a fake data register descriptor for such ICs and provide hardcoded default values. It isn't possible to reliably determine if the touch IC is original or not, so th

Re: [linus:master] [fs/dax] bde708f1a6: WARNING:at_mm/truncate.c:#truncate_folio_batch_exceptionals

2025-04-10 Thread Jan Kara
On Thu 10-04-25 17:01:26, Alistair Popple wrote: > On Thu, Apr 10, 2025 at 01:14:42PM +0800, kernel test robot wrote: > > > > > > Hello, > > > > kernel test robot noticed > > "WARNING:at_mm/truncate.c:#truncate_folio_batch_exceptionals" on: > > > > commit: bde708f1a65d025c45575bfe1e7bf7bdf7e71

Re: [PATCH net-next 1/2] vsock: Linger on unsent data

2025-04-10 Thread Paolo Abeni
On 4/7/25 8:41 PM, Michal Luczaj wrote: > Change the behaviour of a lingering close(): instead of waiting for all > data to be consumed, block until data is considered sent, i.e. until worker > picks the packets and decrements virtio_vsock_sock::bytes_unsent down to 0. I think it should be better

Re: [PATCH 5/5] KVM: VMX: Always honor guest PAT on CPUs that support self-snoop

2025-04-10 Thread Myrsky Lintu
Thank you. I will try to bring this up with QEMU developers then. On 2025-04-10 05:12:01, Yan Zhao wrote: > Hi, > > AFAIK, the commit c9c1e20b4c7d ("KVM: x86: Introduce Intel specific quirk > KVM_X86_QUIRK_IGNORE_GUEST_PAT") which re-allows honoring guest PAT on Intel's > platforms has been in kv

[PATCH v1] fs/dax: fix folio splitting issue by resetting old folio order + _nr_pages

2025-04-10 Thread David Hildenbrand
Alison reports an issue with fsdax when large extends end up using large ZONE_DEVICE folios: [ 417.796271] BUG: kernel NULL pointer dereference, address: 0b00 [ 417.796982] #PF: supervisor read access in kernel mode [ 417.797540] #PF: error_code(0x) - not-present page [ 417.798

Re: [PATCH v7 0/5] Configure imx8mp dsp node for rproc usage

2025-04-10 Thread Laurentiu Mihalcea
On 3/20/2025 2:09 PM, Daniel Baluta wrote: > DSP found in i.MX8MP SOC can be used by multiple frameworks in order to > enable various applications: > >

Re: [linus:master] [fs/dax] bde708f1a6: WARNING:at_mm/truncate.c:#truncate_folio_batch_exceptionals

2025-04-10 Thread Alistair Popple
t; arch/x86/mm/fault.c:1538) > [ 47.037332][ T333] > [ 47.042576][ T4025] entry_SYSCALL_64_after_hwframe > (arch/x86/entry/entry_64.S:130) > [ 47.042596][ T4025] RIP: 0033:0x7fe697166af7 > [ 47.048552][ T333] 262144 bytes (262 kB, 256 KiB) copied, 0.00560232 s, > 46.8 MB/s > [ 47.052938][ T4025] Code: 0f 93 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 > 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 > <48> 3d 00 f0 ff ff 77 01 c3 48 8b 15 d9 92 0c 00 f7 d8 64 89 02 b8 > All code > >0: 0f 93 0c 00 setae (%rax,%rax,1) >4: f7 d8 neg%eax >6: 64 89 01mov%eax,%fs:(%rcx) >9: 48 83 c8 ff or $0x,%rax >d: c3 ret > > > The kernel config and materials to reproduce are available at: > https://download.01.org/0day-ci/archive/20250410/202504101036.390f29a5-...@intel.com > > > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki >

Re: [PATCH v2] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-10 Thread Greg Kroah-Hartman
On Thu, Apr 10, 2025 at 08:21:09AM +0200, Gon Solo wrote: > > > This is not necessary as it was Python's fault and is fixed by 3.13.3 > > > which came out yesterday. I just checked. > > > > It will take some time before this reaches all distributions. This > > patch is relatively simple. > > > >

RE: [PATCH 7/7] irqbypass: Use xarray to track producers and consumers

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Saturday, April 5, 2025 5:15 AM > > Track IRQ bypass produsers and consumers using an xarray to avoid the > O(2n) > insertion time associated with walking a list to check for duplicate > entries, and to search for an partner. > > At low (tens or few hundreds)

Re: [PATCH] virtio-net: hold netdev_lock when pausing rx

2025-04-10 Thread Bui Quang Minh
On 4/10/25 14:58, Michael S. Tsirkin wrote: On Thu, Apr 10, 2025 at 02:05:57PM +0700, Bui Quang Minh wrote: When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_disable() on the receive queue's napi. In delayed refill_work, it also calls napi_disable() on the receive queue's napi

Re: [PATCH RFC v7 5/8] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes

2025-04-10 Thread Christoph Hellwig
On Tue, Apr 08, 2025 at 11:23:59AM +, Shivank Garg wrote: > From: Ackerley Tng > > Using guest mem inodes allows us to store metadata for the backing > memory on the inode. Metadata will be added in a later patch to support > HugeTLB pages. > > Metadata about backing memory should not be sto

Re: [PATCH RFC v7 3/8] security: Export security_inode_init_security_anon for KVM guest_memfd

2025-04-10 Thread Christoph Hellwig
On Tue, Apr 08, 2025 at 11:23:57AM +, Shivank Garg wrote: > KVM guest_memfd is implementing its own inodes to store metadata for > backing memory using a custom filesystem. This requires the ability to > initialize anonymous inode using security_inode_init_security_anon(). > > As guest_memfd c

Re: [PATCH] virtio-net: hold netdev_lock when pausing rx

2025-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2025 at 02:05:57PM +0700, Bui Quang Minh wrote: > When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call > napi_disable() on the receive queue's napi. In delayed refill_work, it > also calls napi_disable() on the receive queue's napi. When > napi_disable() is called on an a

Re: [PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel Offload (ovpn)

2025-04-10 Thread ALOK TIWARI
On 08-04-2025 01:16, Antonio Quartulli wrote: Although it wasn't easy to convince the community, `ovpn` implements only a limited number of the data-channel features supported by the userspace program. Each feature that made it to `ovpn` was attentively vetted to avoid carrying too much legac

Re: [PATCH] kbuild: Require pahole >v1.29 with GENDWARFKSYMS and BTF on X86

2025-04-10 Thread Alan Maguire
On 07/04/2025 09:25, Sam James wrote: > [with regard to > https://lore.kernel.org/linux-kbuild/20250320232757.2283956-2-samitolva...@google.com/] > > Would it be possible to have a new release with that fix, to avoid > distros all having to cherrypick the fix commit? > > Thanks in advance, > sam

[PATCH v17 01/15] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()

2025-04-10 Thread Frank Li
platform_device_msi_init_and_alloc_irqs() performs two tasks: allocating the MSI domain for a platform device, and allocate a number of MSIs in that domain. platform_device_msi_free_irqs_all() only frees the MSIs, and leaves the MSI domain alive. Given that platform_device_msi_init_and_alloc_irqs

[PATCH bpf-next v4 2/3] bpf, sockmap: avoid using sk_socket after free when reading

2025-04-10 Thread Jiayuan Chen
There are potential concurrency issues, as shown below. ''' CPU0 CPU1 sk_psock_verdict_data_ready: socket *sock = sk->sk_socket if (!sock) return close(fd): ...

[PATCH net-next v25 10/23] ovpn: store tunnel and transport statistics

2025-04-10 Thread Antonio Quartulli
Byte/packet counters for in-tunnel and transport streams are now initialized and updated as needed. To be exported via netlink. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 12 +++- drivers/net/ovpn/peer.c | 2 ++ drivers/net/ovpn

[PATCH net-next v25 11/23] ovpn: implement TCP transport

2025-04-10 Thread Antonio Quartulli
With this change ovpn is allowed to communicate to peers also via TCP. Parsing of incoming messages is implemented through the strparser API. Note that ovpn redefines sk_prot and sk_socket->ops for the TCP socket used to communicate with the peer. For this reason it needs to access inet6_stream_op

[PATCH v17 07/15] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller

2025-04-10 Thread Frank Li
Doorbell feature is implemented by mapping the EP's MSI interrupt controller message address to a dedicated BAR in the EPC core. It is the responsibility of the EPF driver to pass the actual message data to be written by the host to the doorbell BAR region through its own logic. Tested-by: Niklas

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-10 Thread Michael S. Tsirkin
Wow great job digging through all these hypervisors! On Mon, Apr 07, 2025 at 10:38:59AM +0200, David Hildenbrand wrote: > crossvm: > https://github.com/google/crosvm/blob/main/devices/src/virtio/balloon.rs > > -> Hard-codes queue numbers; does *not* offer/implement >VIRTIO_BALLOON_F_STATS_VQ

Re: [PATCH 7/7] irqbypass: Use xarray to track producers and consumers

2025-04-10 Thread Sean Christopherson
On Thu, Apr 10, 2025, Kevin Tian wrote: > > From: Sean Christopherson > > Sent: Saturday, April 5, 2025 5:15 AM > > > > Track IRQ bypass produsers and consumers using an xarray to avoid the > > O(2n) > > insertion time associated with walking a list to check for duplicate > > entries, and to sear

[PATCH AUTOSEL 5.15 4/8] sound/virtio: Fix cancel_sync warnings on uninitialized work_structs

2025-04-10 Thread Sasha Levin
From: John Stultz [ Upstream commit 3c7df2e27346eb40a0e86230db1ccab195c97cfe ] Betty reported hitting the following warning: [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182 ... [8.713282][ T221] Call trace: [8.713365][ T221] __flush_work+0x8d0/0x914 [8.

Re: [PATCH v3 0/4] Add managed SOFT RESERVE resource handling

2025-04-10 Thread Bowman, Terry
On 4/7/2025 2:31 AM, Zhijian Li (Fujitsu) wrote: > Hi Terry, > > If I understand correctly, this patch set has only considered the situation > where the > soft reserved area and the region are exactly the same, as in pattern 1. Hi Zhijian, I'm working on example test case(s) for your questions

[PATCH net-next v25 12/23] skb: implement skb_send_sock_locked_with_flags()

2025-04-10 Thread Antonio Quartulli
When sending an skb over a socket using skb_send_sock_locked(), it is currently not possible to specify any flag to be set in msghdr->msg_flags. However, we may want to pass flags the user may have specified, like MSG_NOSIGNAL. Extend __skb_send_sock() with a new argument 'flags' and add a new in

[PATCH RFT v15 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack()

2025-04-10 Thread Mark Brown
Currently as a result of templating from x86 code gcs_alloc_thread_stack() returns a pointer as an unsigned int however on arm64 we don't actually use this pointer value as anything other than a pass/fail flag. Simplify the interface to just return an int with 0 on success and a negative error code

[PATCH v2] kbuild: Require pahole v1.29 with GENDWARFKSYMS on X86

2025-04-10 Thread Sami Tolvanen
With CONFIG_GENDWARFKSYMS, __gendwarfksyms_ptr variables are added to the kernel in EXPORT_SYMBOL() to ensure DWARF type information is available for exported symbols in the TUs where they're actually exported. These symbols are dropped when linking vmlinux, but dangling references to them remain i

Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for SOFT RESERVES

2025-04-10 Thread Bowman, Terry
On 4/4/2025 8:16 AM, Jonathan Cameron wrote: > On Thu, 3 Apr 2025 13:33:12 -0500 > Terry Bowman wrote: > >> From: Nathan Fontenot >> >> Add a release_Sam_region_adjustable() interface to allow for > > Who is Sam? (typo) > Hi Jonathan, It is a typo. I will fix. >> removing SOFT RESERVE memo

[PATCHv6 net-next 2/2] wireguard: selftests: update to using nft for qemu test

2025-04-10 Thread Hangbin Liu
Since we will replace iptables with nft for wireguard netns testing, let's also convert the qemu test to use nft at the same time. Co-developed-by: Phil Sutter Signed-off-by: Phil Sutter Signed-off-by: Hangbin Liu --- .../testing/selftests/wireguard/qemu/Makefile | 36 ++- .../

[PATCH AUTOSEL 6.12 06/22] sound/virtio: Fix cancel_sync warnings on uninitialized work_structs

2025-04-10 Thread Sasha Levin
From: John Stultz [ Upstream commit 3c7df2e27346eb40a0e86230db1ccab195c97cfe ] Betty reported hitting the following warning: [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182 ... [8.713282][ T221] Call trace: [8.713365][ T221] __flush_work+0x8d0/0x914 [8.

Re: [PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Paul E. McKenney
On Thu, Apr 10, 2025 at 11:29:03AM -0700, Paul E. McKenney wrote: > On Thu, Apr 10, 2025 at 11:03:27AM -0400, Joel Fernandes wrote: > > Currently, the ->gpwrap is not tested (at all per my testing) due to > the > requirement of a large delta between a CPU's rdp->gp_seq and its > node's > rnp->gpseq

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-10 Thread David Hildenbrand
Heh, but that one said: +\item[ VIRTIO_BALLOON_F_WS_REPORTING(6) ] The device has support for Working Set Which does not seem to reflect reality ... Please feel free to disregard these features and reuse their bits and queue indexes; as far as I know, they are not actually enabled anywhere cur

RE: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file

2025-04-10 Thread Zhuo, Qiuxu
Hi Shuah Khan, Just a gentle ping regarding this patch. If you have any questions, please feel free to let me know. Thanks! -Qiuxu > From: Zhuo, Qiuxu > [...] > Subject: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the > end of the file > > When running the mincore_selftes

Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload

2025-04-10 Thread Sabrina Dubroca
2025-04-07, 21:46:08 +0200, Antonio Quartulli wrote: > Notable changes since v24: > * disable TCP disconnections of attached sockets (tcp_disconnect() > returns -EBUSY) - similarly to kTLS. > * used rcu_replace_pointer instead of > rcu_dereference_protected+rcu_assign_pointer > * dropped useless

Re: [PATCH v1] fs/dax: fix folio splitting issue by resetting old folio order + _nr_pages

2025-04-10 Thread Alison Schofield
On Thu, Apr 10, 2025 at 11:10:20AM +0200, David Hildenbrand wrote: > Alison reports an issue with fsdax when large extends end up using > large ZONE_DEVICE folios: > Passes the ndctl/dax unit tests. Tested-by: Alison Schofield snip

[PATCH v17 13/15] pci: imx6: Add helper function imx_pcie_add_lut_by_rid()

2025-04-10 Thread Frank Li
Add helper function imx_pcie_add_lut_by_rid(), which will be used for Endpoint mode in the future. No functional change. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- drivers/pci/controller/dwc/pci-imx6.c | 17 ++--- 1 file changed,

[PATCH v17 15/15] arm64: dts: imx95: Add msi-map for pci-ep device

2025-04-10 Thread Frank Li
Add msi-map for pci-ep device. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- arch/arm64/boot/dts/freescale/imx95.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/

Re: [PATCH net-next v25 02/23] ovpn: add basic netlink support

2025-04-10 Thread ALOK TIWARI
On 08-04-2025 01:16, Antonio Quartulli wrote: +/** + * ovpn_nl_register - perform any needed registration in the NL subsustem typo subsustem -> subsystem + * + * Return: 0 on success, a negative error code otherwise + */ +int __init ovpn_nl_register(void) +{ + int ret = genl_register

Re: [PATCH v3 3/4] dax/mum: Save the dax mum platform device pointer

2025-04-10 Thread Bowman, Terry
On 4/4/2025 8:34 AM, Jonathan Cameron wrote: > On Thu, 3 Apr 2025 13:33:14 -0500 > Terry Bowman wrote: > >> From: Nathan Fontenot > > mum? > >> >> In order to handle registering hmem devices for SOFT RESERVE >> resources after the dax hmem device initialization occurs >> we need to save a refe

Re: [PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Paul E. McKenney
On Thu, Apr 10, 2025 at 11:03:27AM -0400, Joel Fernandes wrote: > Currently, the ->gpwrap is not tested (at all per my testing) due to the > requirement of a large delta between a CPU's rdp->gp_seq and its node's > rnp->gpseq. > > This results in no testing of ->gpwrap being set. This patch by def

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-10 Thread David Hildenbrand
On 02.04.25 22:36, David Hildenbrand wrote: If we finds a vq without a name in our input array in virtio_ccw_find_vqs(), we treat it as "non-existing" and set the vq pointer to NULL; we will not call virtio_ccw_setup_vq() to allocate/setup a vq. Consequently, we create only a queue if it actuall

Re: [PATCH net-next v25 05/23] ovpn: introduce the ovpn_peer object

2025-04-10 Thread ALOK TIWARI
On 08-04-2025 01:16, Antonio Quartulli wrote: An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffers, napi, etc. Only support for one peer is introduced (P2P mode). Multi peer support is intr

Re: [PATCH] firmware: cs_dsp: test_bin_error: Fix uninitialized data used as fw version

2025-04-10 Thread Mark Brown
On Thu, 10 Apr 2025 14:21:29 +0100, Richard Fitzgerald wrote: > Call cs_dsp_mock_xm_header_get_fw_version() to get the firmware version > from the dummy XM header data in cs_dsp_bin_err_test_common_init(). > > Make the same change to cs_dsp_bin_test_common_init() and remove the > cs_dsp_mock_xm_he

Re: [PATCH v1] fs/dax: fix folio splitting issue by resetting old folio order + _nr_pages

2025-04-10 Thread Dan Williams
David Hildenbrand wrote: > Alison reports an issue with fsdax when large extends end up using > large ZONE_DEVICE folios: > > [ 417.796271] BUG: kernel NULL pointer dereference, address: 0b00 > [ 417.796982] #PF: supervisor read access in kernel mode > [ 417.797540] #PF: error_code(

[PATCH v3] selftests/x86/lam: fix resource leak in do_uring() and allocate_dsa_pasid()

2025-04-10 Thread Malaya Kumar Rout
Exception branch returns without closing the file descriptors 'file_fd' and 'fd' Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/x86/lam.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/la

Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning

2025-04-10 Thread David Hildenbrand
On 09.04.25 12:31, David Hildenbrand wrote: On 09.04.25 12:25, Anshuman Khandual wrote: On 4/9/25 15:51, David Hildenbrand wrote: On 09.04.25 12:09, Anshuman Khandual wrote: On 4/9/25 15:27, David Hildenbrand wrote: On 09.04.25 11:50, Anshuman Khandual wrote: Following build warning come

[PATCH net-next v25 18/23] ovpn: implement peer add/get/dump/delete via netlink

2025-04-10 Thread Antonio Quartulli
This change introduces the netlink command needed to add, delete and retrieve/dump known peers. Userspace is expected to use these commands to handle known peer lifecycles. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/netlink.c | 686 - driver

Re: [PATCH v1] fs/dax: fix folio splitting issue by resetting old folio order + _nr_pages

2025-04-10 Thread Matthew Wilcox
On Thu, Apr 10, 2025 at 01:46:06PM -0700, Dan Williams wrote: > Matthew Wilcox wrote: > > On Thu, Apr 10, 2025 at 01:15:07PM -0700, Dan Williams wrote: > > > For consistency and clarity what about this incremental change, to make > > > the __split_folio_to_order() path reuse folio_reset_order(), an

Re: [PATCH 3/7] irqbypass: Take ownership of producer/consumer token tracking

2025-04-10 Thread Sean Christopherson
On Thu, Apr 10, 2025, Alex Williamson wrote: > On Fri, 4 Apr 2025 14:14:45 -0700 > Sean Christopherson wrote: > > diff --git a/include/linux/irqbypass.h b/include/linux/irqbypass.h > > index 9bdb2a781841..379725b9a003 100644 > > --- a/include/linux/irqbypass.h > > +++ b/include/linux/irqbypass.h

RE: [PATCH 7/7] irqbypass: Use xarray to track producers and consumers

2025-04-10 Thread Tian, Kevin
> From: Sean Christopherson > Sent: Thursday, April 10, 2025 10:52 PM > > On Thu, Apr 10, 2025, Kevin Tian wrote: > > > From: Sean Christopherson > > > Sent: Saturday, April 5, 2025 5:15 AM > > > > > > Track IRQ bypass produsers and consumers using an xarray to avoid the > > > O(2n) > > > insert

Re: [PATCHv6 net-next 1/2] wireguard: selftests: convert iptables to nft

2025-04-10 Thread Phil Sutter
On Tue, Apr 08, 2025 at 11:38:31AM +0200, Phil Sutter wrote: > On Tue, Apr 08, 2025 at 08:16:51AM +, Hangbin Liu wrote: > > Convert the selftest to nft as it is the replacement for iptables, which > > is used by default in most releases. > > > > Signed-off-by: Hangbin Liu > > What are the ch

Re: [PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Paul E. McKenney
On Thu, Apr 10, 2025 at 11:54:13AM -0700, Paul E. McKenney wrote: > On Thu, Apr 10, 2025 at 11:29:03AM -0700, Paul E. McKenney wrote: > > On Thu, Apr 10, 2025 at 11:03:27AM -0400, Joel Fernandes wrote: > > > Currently, the ->gpwrap is not tested (at all per my testing) due to > > the > requirement

[PATCH net-next] selftests/vsock: add initial vmtest.sh for vsock

2025-04-10 Thread Bobby Eshleman
This commit introduces a new vmtest.sh runner for vsock. It uses virtme-ng/qemu to run tests in a VM. The tests are designed to validate both G2H and H2G paths. The testing tools from tools from tools/testing/vsock/ are reused. Currently, only vsock_test is used. Only tested on x86. To run: $

Re: [PATCH net-next v25 07/23] ovpn: implement basic TX path (UDP)

2025-04-10 Thread Jakub Kicinski
On Mon, 07 Apr 2025 21:46:15 +0200 Antonio Quartulli wrote: > diff --git a/drivers/net/ovpn/socket.c b/drivers/net/ovpn/socket.c > index > 97f6a249b09fe26cc6d078d80abc955f8d35e821..200036757fcd0a7f2ae554a1e3a3c03915c0e32f > 100644 > --- a/drivers/net/ovpn/socket.c > +++ b/drivers/net/ovpn/socket.

Re: [PATCH RFC v7 7/8] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-04-10 Thread Shivank Garg
On 4/10/2025 7:10 PM, Ackerley Tng wrote: > Shivank Garg writes: > >> Previously, guest-memfd allocations followed local NUMA node id in absence >> of process mempolicy, resulting in arbitrary memory allocation. >> Moreover, mbind() couldn't be used since memory wasn't mapped to userspace >> i

Re: [PATCH RFC v7 3/8] security: Export security_inode_init_security_anon for KVM guest_memfd

2025-04-10 Thread Shivank Garg
On 4/10/2025 2:11 PM, Christoph Hellwig wrote: > On Tue, Apr 08, 2025 at 11:23:57AM +, Shivank Garg wrote: >> KVM guest_memfd is implementing its own inodes to store metadata for >> backing memory using a custom filesystem. This requires the ability to >> initialize anonymous inode using sec

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

2025-04-10 Thread David Hildenbrand
On 07.04.25 11:11, David Hildenbrand wrote: On 07.04.25 10:58, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: On 07.04.25 10:49, Michael S. Tsirkin wrote: On Mon, Apr 07, 2025 at 10:44:21AM +0200, David Hildenbrand wrote: Whoever adds new feat

Re: [PATCH 4/4] sysctl: Close test ctl_headers with a for loop

2025-04-10 Thread Kees Cook
On Fri, Mar 21, 2025 at 01:47:27PM +0100, Joel Granados wrote: > As more tests are added, the exit function gets longer than it should > be. Condense the un-register calls into a for loop to make it easier to > add/remove tests. > > Signed-off-by: Joel Granados Much cleaner too. :) Reviewed-by:

Re: [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB

2025-04-10 Thread Mark Brown
On Wed, Apr 09, 2025 at 03:34:27PM +0100, Richard Fitzgerald wrote: > On 09/04/2025 3:24 pm, Mark Brown wrote: > > This by itself results in the Cirrus tests being removed from a kunit > > --alltests run which is a regression in coverage. I'd expect to see > > some corresponding updates in the KU

Re: [PATCH v1] fs/dax: fix folio splitting issue by resetting old folio order + _nr_pages

2025-04-10 Thread Dan Williams
Matthew Wilcox wrote: > On Thu, Apr 10, 2025 at 01:15:07PM -0700, Dan Williams wrote: > > For consistency and clarity what about this incremental change, to make > > the __split_folio_to_order() path reuse folio_reset_order(), and use > > typical bitfield helpers for manipulating _flags_1? > > I d

Re: [PATCH RFC v3 4/8] slab: sheaf prefilling for guaranteed allocations

2025-04-10 Thread Suren Baghdasaryan
On Mon, Mar 17, 2025 at 7:33 AM Vlastimil Babka wrote: > > Add functions for efficient guaranteed allocations e.g. in a critical > section that cannot sleep, when the exact number of allocations is not > known beforehand, but an upper limit can be calculated. > > kmem_cache_prefill_sheaf() returns

[PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-10 Thread T.J. Mercier
pid_max.c: In function ‘pid_max_cb’: pid_max.c:42:15: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration] 42 | ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0); | ^ pid_max.c:42:36: error: ‘MS_

  1   2   >